On Thu, Jun 2, 2011 at 2:34 PM, Wolfgang Denk w...@denx.de wrote:
Dear Tom Warren,
In message BANLkTi=w1u7q+w-vkrycq-wb50e7edf...@mail.gmail.com you wrote:
Let me double-check. IIRC, one (cmd_gpio) didn't apply since it was
from another SoC and didn't have the commands we use on Tegra
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/include/asm/arch-tegra2/clk_rst.h |5 +
arch/arm/include/asm/arch-tegra2/pinmux.h |6 +
board/nvidia/common/board.c| 147
board/nvidia/common/board.h|1 +
drivers/mmc/Makefile
Signed-off-by: Tom Warren twar...@nvidia.com
---
include/configs/harmony.h | 11 +++
include/configs/seaboard.h | 11 +++
2 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/include/configs/harmony.h b/include/configs/harmony.h
index 34bd899..89e4911 100644
On Mon, May 2, 2011 at 4:16 PM, Mike Frysinger vap...@gentoo.org wrote:
On Monday, May 02, 2011 19:06:51 Tom Warren wrote:
Seaboard has a touchscreen on SPI1, but U-Boot doesn't care about that.
fwiw, u-boot has splash screen support
-mike
Thanks, Mike. I'm talking touchscreen support. We'll
Mike,
On Fri, Apr 29, 2011 at 4:21 PM, Mike Frysinger vap...@gentoo.org wrote:
On Thursday, April 28, 2011 10:55:13 Tom Warren wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
This patch adds support for the SPIFLASH peripheral on Tegra2 (SPI 1).
Probe, erase, read and write are all
Mike,
On Fri, Apr 29, 2011 at 4:22 PM, Mike Frysinger vap...@gentoo.org wrote:
same as the SPI patch, if this is a driver for GPIO hardware on a processor,
then it should be labeled as such. do not mention specific boards.
OK. I'll change the comments.
changes that update board config
GPIO for all boards (tegra2-common.h)
Tom Warren (2):
GPIO: Tegra2: add GPIO driver for Tegra2
arm: Tegra2: GPIO: enable GPIO for Tegra2 boards
arch/arm/include/asm/arch-tegra2/gpio.h | 244 -
drivers/gpio/Makefile |1 +
drivers/gpio/tegra2_gpio.c
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes in V2:
- use 'gpio_pin' enum in gpio.h (Simon Glass review request)
- change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request)
- change 'offset' to 'pin' globally
arch/arm/include/asm/arch-tegra2/gpio.h | 244
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes in V2:
- enable GPIO for all boards (tegra2-common.h)
include/configs/tegra2-common.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/configs/tegra2-common.h b/include/configs/tegra2-common.h
index
Mike,
On Mon, May 2, 2011 at 2:26 PM, Mike Frysinger vap...@gentoo.org wrote:
On Monday, May 02, 2011 11:33:24 Tom Warren wrote:
On Fri, Apr 29, 2011 at 4:21 PM, Mike Frysinger wrote:
On Thursday, April 28, 2011 10:55:13 Tom Warren wrote:
This patch adds support for the SPIFLASH peripheral
Mike,
On Mon, May 2, 2011 at 4:15 PM, Mike Frysinger vap...@gentoo.org wrote:
On Monday, May 02, 2011 18:45:47 Tom Warren wrote:
+U_BOOT_CMD(
+ gpio, 5, 1, do_gpio,
looks to me like you're duplicating a lot of code that already exists in
common/cmd_gpio.c
-mike
Possible
Signed-off-by: Tom Warren twar...@nvidia.com
---
This patch adds support for the SPIFLASH peripheral on Tegra2 (SPI 1).
Probe, erase, read and write are all supported, as well as low-level
SPI commands via 'sspi'.
Note that, at this time, only Seaboard has a SPI flash part (Winbond
On Mon, Apr 18, 2011 at 2:11 PM, Tom Warren twarren.nvi...@gmail.com wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/include/asm/arch-tegra2/gpio.h | 236 -
drivers/gpio/Makefile | 1 +
drivers/gpio/tegra2_gpio.c
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/include/asm/arch-tegra2/gpio.h | 236 -
drivers/gpio/Makefile |1 +
drivers/gpio/tegra2_gpio.c | 301 +++
include/configs/harmony.h
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/cpu/armv7/tegra2/ap20.c | 29
arch/arm/include/asm/arch-tegra2/clk_rst.h |6 +++-
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c b/arch/arm/cpu
to loading from NAND
on Seaboard and Harmony - testing to follow.
Changes in V2:
- Change 2nd patch's description to 'Add basic GPIO definitions'
- Add more descriptive comment for CPCON use in init_pllx
Tom Warren (3):
arm: Tegra2: Add missing PLLX init
arm: Tegra2: GPIO: Add
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/include/asm/arch-tegra2/gpio.h | 59 +
arch/arm/include/asm/arch-tegra2/tegra2.h |1 +
2 files changed, 60 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/include/asm/arch-tegra2/gpio.h
diff
Signed-off-by: Tom Warren twar...@nvidia.com
---
board/nvidia/common/board.c | 32 +++
board/nvidia/common/board.h |4 +++
board/nvidia/harmony/Makefile|1 +
board/nvidia/harmony/harmony.c | 34
board/nvidia/seaboard
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove returns in void functions
- Move inline assembly code to .S file
- Simplify some if/else code, break out common code
- Minimize the use of local vars
- Inline some single-instance
to loading from NAND
on Seaboard and Harmony - testing to follow.
Tom Warren (3):
arm: Tegra2: Add missing PLLX init
arm: Tegra2: GPIO: Add basic GPIO functionality
arm: Tegra2: Move clk/mux init to board_early_init_f, add GPIO init
arch/arm/cpu/armv7/tegra2/ap20.c | 29
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/cpu/armv7/tegra2/ap20.c | 29
arch/arm/include/asm/arch-tegra2/clk_rst.h |6 +++-
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c b/arch/arm/cpu
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/include/asm/arch-tegra2/gpio.h | 59 +
arch/arm/include/asm/arch-tegra2/tegra2.h |1 +
2 files changed, 60 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/include/asm/arch-tegra2/gpio.h
diff
Signed-off-by: Tom Warren twar...@nvidia.com
---
board/nvidia/common/board.c | 32 +++
board/nvidia/common/board.h |4 +++
board/nvidia/harmony/Makefile|1 +
board/nvidia/harmony/harmony.c | 34
board/nvidia/seaboard
Albert,
On Wed, Apr 13, 2011 at 1:09 PM, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Le 12/04/2011 23:02, Tom Warren a écrit :
diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c
b/arch/arm/cpu/armv7/tegra2/ap20.c
new file mode 100644
index 000..075341e
--- /dev/null
+++ b/arch/arm/cpu
CPCON (Charge Pump Control) is a 4-bit field, bits 11:8. The default
value is 0001. I'll change the comment to /* CPCON [11:8] = 0001 */
On Wed, Apr 13, 2011 at 1:12 PM, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Le 13/04/2011 22:07, Tom Warren a écrit :
+ reg = CPCON
Albert,
On Wed, Apr 13, 2011 at 1:14 PM, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Hi Tom,
Le 13/04/2011 22:07, Tom Warren a écrit :
Signed-off-by: Tom Warrentwar...@nvidia.com
---
arch/arm/include/asm/arch-tegra2/gpio.h | 59
+
arch/arm/include/asm
Albert,
On Wed, Apr 13, 2011 at 1:30 PM, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Hi Tom,
Le 13/04/2011 22:21, Tom Warren a écrit :
+
+ /* Wait for the power to come up */
+ while (!is_cpu_powered())
+ ; /* Do
Albert,
On Wed, Apr 13, 2011 at 1:31 PM, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Tom,
Le 13/04/2011 22:26, Tom Warren a écrit :
Albert,
On Wed, Apr 13, 2011 at 1:14 PM, Albert ARIBAUD
albert.u.b...@aribaud.net wrote:
Hi Tom,
Le 13/04/2011 22:07, Tom Warren a écrit :
Signed
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove returns in void functions
- Move inline assembly code to .S file
- Simplify some if/else code, break out common code
- Minimize the use of local vars
- Inline some single-instance
Albert,
On Sun, Mar 27, 2011 at 9:22 AM, Albert ARIBAUD albert.arib...@free.fr wrote:
Le 24/03/2011 16:08, Tom Warren a écrit :
Albert,
On Thu, Mar 24, 2011 at 7:27 AM, Albert ARIBAUDalbert.arib...@free.fr
wrote:
Le 22/03/2011 20:27, Tom Warren a écrit :
Albert,
On Wed, Feb 23, 2011
Peter,
On Fri, Mar 25, 2011 at 9:02 AM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
Things look pretty good. Minor comments/questions below.
snip
+/*
+ * TBD: Move cold_boot() to assembly file.
+ * Values/offsets of the table vars make this difficult.
+ */
+
+void cold_boot(void)
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove returns in void functions
- Move inline assembly code to .S file
- Simplify some if/else code, break out common code
- Minimize the use of local vars
- Inline some single-instance
Peter,
On Fri, Mar 25, 2011 at 10:22 AM, Peter Tyser pty...@xes-inc.com wrote:
On Fri, 2011-03-25 at 09:16 -0700, Tom Warren wrote:
Peter,
On Fri, Mar 25, 2011 at 9:02 AM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
Things look pretty good. Minor comments/questions below.
snip
Albert,
On Thu, Mar 24, 2011 at 7:27 AM, Albert ARIBAUD albert.arib...@free.fr wrote:
Le 22/03/2011 20:27, Tom Warren a écrit :
Albert,
On Wed, Feb 23, 2011 at 1:45 PM, Albert ARIBAUDalbert.arib...@free.fr
wrote:
Le 23/02/2011 21:03, Tom Warren a écrit :
OK, I'm an idiot. I see now
Peter,
On Thu, Mar 17, 2011 at 7:32 AM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
+ /* Is PLL-X already running? */
+ reg = readl(clkrst-crc_pllx_base);
+ if (reg PLL_ENABLE)
+ return;
+
+ /* Do PLLX init if it isn't running, but BootROM
Allesandro,
On Thu, Mar 17, 2011 at 8:30 AM, Alessandro Rubini
rubini-l...@gnudd.com wrote:
It looks like most of your uses are standalone functions that would
function just fine on their own. Is there a reason you prefer to have
them in a C-file instead of in an assembly file?
Just
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove returns in void functions
- Move inline assembly code to .S file
- Simplify some if/else code, break out common code
- Minimize the use of local vars
- Inline some single-instance
Albert,
On Sun, Mar 13, 2011 at 10:46 AM, Albert ARIBAUD albert.arib...@free.fr wrote:
Le 16/02/2011 21:26, Tom Warren a écrit :
Signed-off-by: Tom Warrentwar...@nvidia.com
---
arch/arm/cpu/armv7/start.S | 6 +
arch/arm/cpu/armv7/tegra2/Makefile | 2 +-
arch
Peter,
On Mon, Mar 14, 2011 at 8:33 AM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
I'm not too familiar with the architecture, so many comments are
aesthetic. It would be a good idea to run the patch through
checkpatch.pl too.
I run checkpatch on every submission. Only 1 warning was
Peter,
On Mon, Mar 14, 2011 at 3:20 PM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
snip
+static void init_pll_x(void)
+{
+ struct clk_rst_ctlr *clkrst = (struct clk_rst_ctlr *)NV_PA_CLK_RST
_BASE;
+ u32 reg;
The spaces in front of reg can be removed. Ditto for
Albert,
On Tue, Feb 22, 2011 at 4:57 PM, Albert ARIBAUD albert.arib...@free.fr wrote:
Hi Tom,
Le 23/02/2011 00:41, Tom Warren a écrit :
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
I should be able to review it during the week-end--not before
Albert,
On Tue, Feb 22, 2011 at 4:57 PM, Albert ARIBAUD albert.arib...@free.fr wrote:
Hi Tom,
Le 23/02/2011 00:41, Tom Warren a écrit :
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
I should be able to review it during the week-end--not before
Seaboard build stopped working due to Sandeep's recent mach-types.h update
to match the Linux kernel. Change Seaboard to use MACH_TYPE_SEABOARD.
Tom Warren (1):
arm: Tegra2: Change mach-type to MACH_TYPE_SEABOARD due to
mach-types.h update
include/configs/seaboard.h |2 +-
1 files
Signed-off-by: Tom Warren twar...@nvidia.com
---
include/configs/seaboard.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
index fd87560..59eef56 100644
--- a/include/configs/seaboard.h
+++ b/include/configs
Seaboard build stopped working due to Sandeep's recent mach-types.h update
to match the Linux kernel. Change Seaboard to use MACH_TYPE_SEABOARD.
Tom Warren (1):
arm: Tegra2: Change mach-type to MACH_TYPE_SEABOARD due to
mach-types.h update
include/configs/seaboard.h |2 +-
1 files
OK, I'm an idiot. I see now that I needed to add -n to format-patch to
add the numbering to the [PATCH] header.
Sorry for the noise - resending now with the corrected patchset.
Tom
On Wed, Feb 23, 2011 at 12:54 PM, Tom Warren twarren.nvi...@gmail.com wrote:
Signed-off-by: Tom Warren twar
Signed-off-by: Tom Warren twar...@nvidia.com
---
include/configs/seaboard.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
index fd87560..59eef56 100644
--- a/include/configs/seaboard.h
+++ b/include/configs
Seaboard build stopped working due to Sandeep's recent mach-types.h update
to match the Linux kernel. Change Seaboard to use MACH_TYPE_SEABOARD.
Tom Warren (1):
arm: Tegra2: Change mach-type to MACH_TYPE_SEABOARD due to
mach-types.h update
include/configs/seaboard.h |2 +-
1 files
Signed-off-by: Tom Warren twar...@nvidia.com
---
include/configs/seaboard.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
index fd87560..59eef56 100644
--- a/include/configs/seaboard.h
+++ b/include/configs
Anyone willing to review this? I'd like to get it pulled in to
Albert's arm repo ASAP.
Thanks,
Tom
On Wed, Feb 16, 2011 at 1:26 PM, Tom Warren twarren.nvi...@gmail.com wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/cpu/armv7/start.S | 6 +
arch/arm/cpu
then proceeds using the A9 CPU.
Tom Warren (1):
arm: Tegra2: add support for A9 CPU init
arch/arm/cpu/armv7/start.S |6 +
arch/arm/cpu/armv7/tegra2/Makefile |2 +-
arch/arm/cpu/armv7/tegra2/ap20.c | 490
arch/arm/cpu/armv7
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/cpu/armv7/start.S |6 +
arch/arm/cpu/armv7/tegra2/Makefile |2 +-
arch/arm/cpu/armv7/tegra2/ap20.c | 490
arch/arm/cpu/armv7/tegra2/ap20.h | 105
Marcel,
On Sun, Feb 13, 2011 at 12:08 PM, Anton Staaf robot...@chromium.org wrote:
Hi Marcel,
I think your best bet right now is to use the nvflash tool provided in
the Chromium chroot. That's what the burn-u-boot script uses (by the way,
that script recently changed to write_tegra_bios
Albert,
On Fri, Feb 4, 2011 at 11:50 PM, Albert ARIBAUD albert.arib...@free.fr wrote:
Le 02/02/2011 19:44, Albert ARIBAUD a écrit :
Le 02/02/2011 18:06, Tom Warren a écrit :
Mike,
On Wed, Feb 2, 2011 at 12:57 AM, Mike Rapoportm...@compulab.co.il
wrote:
On 02/02/11 02:09, Tom Warren
Mike,
On Wed, Feb 2, 2011 at 12:57 AM, Mike Rapoport m...@compulab.co.il wrote:
On 02/02/11 02:09, Tom Warren wrote:
I haven't seen any new feedback on this version (V6) of the patchset
since it was posted.
Wolfgang, Mike, Peter, et al - are you happy with the current patch?
I'm Ok
I haven't seen any new feedback on this version (V6) of the patchset
since it was posted.
Wolfgang, Mike, Peter, et al - are you happy with the current patch?
If so, when can I expect it to be pushed?
Thanks,
Tom
On Thu, Jan 27, 2011 at 1:58 PM, Tom Warren twarren.nvi...@gmail.com wrote
Mike,
On Thu, Jan 27, 2011 at 12:41 AM, Mike Rapoport m...@compulab.co.il wrote:
Tom,
On 01/26/11 19:05, Tom Warren wrote:
Mike,
On Wed, Jan 26, 2011 at 1:13 AM, Mike Rapoport m...@compulab.co.il wrote:
My point was that pin muxing belongs to the board code rather than to the
driver
- Use #if defined() where possible in config files/UART code
- Drop all typedef and volatile struct declarations in header files
Tom Warren (4):
arm: Tegra2: Add basic NVIDIA Tegra2 SoC support
serial: Add Tegra2 serial port support
arm: Tegra2: Add support for NVIDIA Harmony
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Coding style cleanup
- Move serial driver changes to separate patch
- Use board/nvidia instead of board/tegra
- Remove TRUE/FALSE defines
- Use standard NS16550 registers/bit defines in UART
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Move serial driver to separate patch
Changes for V5:
- Move arch/arm/cpu/armv7/uart.c board.h to drivers/serial and
rename to serial_tegra2.c
- Remove use of uart_num UART_A/D
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Use board/nvidia/ instead of /board/tegra
- Change nv-common.h config file to tegra2-common.h
Changes for V6:
- Use #if defined() where possible in config files/UART code
MAINTAINERS
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove mach-types.h change; wait for ARM kernel sync-up
- Use board/nvidia instead of board/tegra
Changes for V6:
- Use #if defined() where possible in config files/UART code
MAINTAINERS
Mike,
On Wed, Jan 26, 2011 at 1:13 AM, Mike Rapoport m...@compulab.co.il wrote:
On 01/26/11 00:24, Peter Tyser wrote:
As I've already pointed out (1) this covers only one possibility of
UART pin
muxing options. I agree that it makes sense when this is a part of the
board-specific code.
Mike,
On Tue, Jan 25, 2011 at 1:11 AM, Mike Rapoport m...@compulab.co.il wrote:
On 01/22/11 01:06, Tom Warren wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
[ snip ]
+/*
+ * Routine: pin_mux_uart
+ * Description: setup the pin muxes/tristate values for a UART
+ */
+static void
Mike,
On Tue, Jan 25, 2011 at 2:12 PM, Mike Rapoport m...@compulab.co.il wrote:
On 01/25/11 18:50, Tom Warren wrote:
Mike,
On Tue, Jan 25, 2011 at 1:11 AM, Mike Rapoport m...@compulab.co.il wrote:
On 01/22/11 01:06, Tom Warren wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
Mike et al,
On Tue, Jan 25, 2011 at 2:37 PM, Tom Warren twarren.nvi...@gmail.com wrote:
Mike,
On Tue, Jan 25, 2011 at 2:12 PM, Mike Rapoport m...@compulab.co.il wrote:
On 01/25/11 18:50, Tom Warren wrote:
Mike,
On Tue, Jan 25, 2011 at 1:11 AM, Mike Rapoport m...@compulab.co.il wrote
Mike,
On Mon, Jan 24, 2011 at 4:55 AM, Mike Rapoport m...@compulab.co.il wrote:
On 01/19/11 23:19, Tom Warren wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Coding style cleanup
- Move serial driver changes to separate patch
- Use board
Mike,
On Mon, Jan 24, 2011 at 4:58 AM, Mike Rapoport m...@compulab.co.il wrote:
On 01/19/11 23:19, Tom Warren wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Use board/nvidia/ instead of /board/tegra
- Change nv-common.h config file to tegra2
Peter,
On Fri, Jan 21, 2011 at 4:46 PM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
On Fri, 2011-01-21 at 16:06 -0700, Tom Warren wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Move serial driver to separate patch
Changes for V5:
- Move arch/arm
Peter,
On Mon, Jan 24, 2011 at 10:51 AM, Peter Tyser pty...@xes-inc.com wrote:
snip
It looks like arch/arm/cpu/armv7/tegra2/board.h and
arch/arm/cpu/armv7/tegra2/uart.c are added in the first patch, then
moved in this patch. It'd be ideal to just add them once in the proper
location.
Wolfgang ( Mike),
On Mon, Jan 24, 2011 at 12:00 PM, Wolfgang Denk w...@denx.de wrote:
Dear Tom Warren,
In message AANLkTinoK+s5OivHAyLg10Z=gwzkccujwjdykssfg...@mail.gmail.com you
wrote:
...
+#define NV_PA_APB_UARTD_BASE (NV_PA_APB_MISC_BASE + 0x6300)
+#define NV_PA_APB_UARTE_BASE
Peter,
On Mon, Jan 24, 2011 at 12:14 PM, Peter Tyser pty...@xes-inc.com wrote:
snip
I see what you're talking about now - I've got uart.c in 2 patch files -
created
in 0001 and then moved in 0002. My bad - that wasn't the intent, just what
happened when I applied my V4 patches to a new
Minkyu,
On Fri, Jan 21, 2011 at 1:16 AM, Minkyu Kang proms...@gmail.com wrote:
Dear Tom Warren,
On 21 January 2011 09:42, Tom Warren twarren.nvi...@gmail.com wrote:
diff --git a/arch/arm/cpu/armv7/tegra2/uart.c
b/arch/arm/cpu/armv7/tegra2/uart.c
new file mode 100644
index 000..5e60bd8
seedshope, (?)
On Fri, Jan 21, 2011 at 9:35 AM, seedshope bocui...@gmail.com wrote:
On 01/21/2011 08:42 AM, Tom Warren wrote:
+
+enum {
+ UART_A = 1,
+ UART_B,
+ UART_C,
+ UART_D,
+ UART_E
+};
+
+#endif /* _BOARD_H_ */
snip
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Move serial driver to separate patch
Changes for V5:
- Move arch/arm/cpu/armv7/uart.c board.h to drivers/serial and
rename to serial_tegra2.c
- Remove use of uart_num UART_A/D
/uart.c board.h to drivers/serial and
rename to serial_tegra2.c
- Remove use of uart_num UART_A/D in serial_tegra2, simplify code
Tom Warren (4):
arm: Tegra2: Add basic NVIDIA Tegra2 SoC support
serial: Add Tegra2 serial port support
arm: Tegra2: Add support
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove mach-types.h change; wait for ARM kernel sync-up
- Use board/nvidia instead of board/tegra
MAINTAINERS|1 +
board/nvidia/seaboard/Makefile | 50
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Coding style cleanup
- Move serial driver changes to separate patch
- Use board/nvidia instead of board/tegra
- Remove TRUE/FALSE defines
- Use standard NS16550 registers/bit defines in UART
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Use board/nvidia/ instead of /board/tegra
- Change nv-common.h config file to tegra2-common.h
MAINTAINERS |4 +
board/nvidia/harmony/Makefile | 50
boards.cfg
On Wed, Jan 19, 2011 at 5:04 PM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
Some last minutes nits:
It looks like some of the new functions can be declared statically.
It'd be nice to do so where possible.
Which functions, Peter? Please point them out specifically, thanks.
snip
---
Graeme,
On Wed, Jan 19, 2011 at 5:20 PM, Graeme Russ graeme.r...@gmail.com wrote:
On Thu, Jan 20, 2011 at 8:19 AM, Tom Warren twarren.nvi...@gmail.com wrote:
+
+/*
+ * Routine: uart_clock_init
+ * Description: init the PLL and clock for the UART in uart_num
+ */
+void uart_clock_init(int
Wolfgang,
On Thu, Jan 20, 2011 at 1:40 AM, Wolfgang Denk w...@denx.de wrote:
Dear Tom Warren,
In message 1295471986-2395-2-git-send-email-twar...@nvidia.com you wrote:
Signed-off-by: Tom Warren twar...@nvidia.com
checkpatch.pl reports:
total: 6 errors, 12 warnings, 1155 lines
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Move serial driver to separate patch
common/serial.c |3 ++-
include/serial.h |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/serial.c b/common/serial.c
index 051ae4e..8ebf9a5 100644
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Coding style cleanup
- Move serial driver changes to separate patch
- Use board/nvidia instead of board/tegra
- Remove TRUE/FALSE defines
- Use standard NS16550 registers/bit defines in UART
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Use board/nvidia/ instead of /board/tegra
- Change nv-common.h config file to tegra2-common.h
MAINTAINERS |4 +
board/nvidia/harmony/Makefile | 50
boards.cfg
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove mach-types.h change; wait for ARM kernel sync-up
- Use board/nvidia instead of board/tegra
MAINTAINERS|1 +
board/nvidia/seaboard/Makefile | 50
- Remove empty lines, fix mixed case hex #s comments in header(s)
- Move board/nvidia/common/board.c UART code header to
arch/arm/cpu/armv7/tegra2/
- Declare internal functions as static in UART code
Tom Warren (4):
arm: Tegra2: Add basic NVIDIA Tegra2 SoC
Wolfgang,
On Mon, Jan 17, 2011 at 4:27 PM, Wolfgang Denk w...@denx.de wrote:
Dear Tom Warren,
In message AANLkTi=f-14jnam_dy5c1sgtt0nmqm-pnok6gdg4d...@mail.gmail.com you
wrote:
1) IO access functions - I pre-reviewed my patch series with Wolfgang
(to hopefully catch any blatant errors
in UART init
- Change nv-common.h config file to tegra2-common.h
Changes for V3:
- Use I/O accessors for Tegra2 HW MMIO register access
- Allow conditional compile of UARTA/UARTD code to save space
Tom Warren (4):
arm: Tegra2: Add basic NVIDIA Tegra2 SoC support
serial: Add
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Move serial driver changes to separate patch
common/serial.c |3 ++-
include/serial.h |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/serial.c b/common/serial.c
index 051ae4e
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Coding style cleanup
- Move serial driver changes to separate patch
- Use board/nvidia/ instead of /board/tegra
- Remove TRUE/FALSE defines
- Use standard NS16550 register/bit defines in UART
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Remove mach-types.h change; wait for ARM kernel sync-up
- Use board/nvidia/ instead of /board/tegra
MAINTAINERS|1 +
board/nvidia/seaboard/Makefile | 50
Signed-off-by: Tom Warren twar...@nvidia.com
---
Changes for V2:
- Use board/nvidia/ instead of /board/tegra
- Change nv-common.h config file to tegra2-common.h
MAINTAINERS |4 +
board/nvidia/harmony/Makefile | 50
boards.cfg
changes based on feedback from Peter Tyser and Sandeep Paulraj.
Tom Warren (4):
arm: Tegra2: Add basic NVIDIA Tegra2 SoC support
serial: Add Tegra2 serial port support
arm: Tegra2: Add support for NVIDIA Harmony board
arm: Tegra2: Add support for NVIDIA Seaboard board
MAINTAINERS
Basic support for the NVIDIA Harmony board. U-Boot will load and respond
to serial console commands with this patch. Further peripheral support
(USB, SD/MMC, NAND, etc.) to follow.
Signed-off-by: Tom Warren twar...@nvidia.com
---
MAINTAINERS |4 +
board/nvidia/harmony
Basic support for the NVIDIA Seaboard board. U-Boot will load and respond
to serial console commands with this patch. Further peripheral support
(USB, SD/MMC, SPI, etc.) to follow.
Signed-off-by: Tom Warren twar...@nvidia.com
---
MAINTAINERS|1 +
board/nvidia/seaboard
Add basic support for NVIDIA Tegra2 SoC chipset
Signed-off-by: Tom Warren twar...@nvidia.com
---
arch/arm/cpu/armv7/tegra2/Makefile | 48 ++
arch/arm/cpu/armv7/tegra2/board.c| 91 ++
arch/arm/cpu/armv7/tegra2/config.mk | 28 +++
arch/arm/cpu
Enable support for serial output on Tegra2 builds
Signed-off-by: Tom Warren twar...@nvidia.com
---
common/serial.c |3 ++-
include/serial.h |3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/common/serial.c b/common/serial.c
index 051ae4e..8ebf9a5 100644
--- a/common
On Fri, Jan 14, 2011 at 12:59 PM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
On Fri, 2011-01-14 at 10:11 -0700, Tom Warren wrote:
This series of patches adds preliminary/baseline support for NVIDIA's
Tegra2 SoC. Basic CPU (AVP), RAM and UART init are covered so that the
system (Harmony
On Fri, Jan 14, 2011 at 2:36 PM, Peter Tyser pty...@xes-inc.com wrote:
On Fri, 2011-01-14 at 13:41 -0700, Tom Warren wrote:
On Fri, Jan 14, 2011 at 12:59 PM, Peter Tyser pty...@xes-inc.com wrote:
Hi Tom,
On Fri, 2011-01-14 at 10:11 -0700, Tom Warren wrote:
This series of patches adds
901 - 1000 of 1006 matches
Mail list logo
