[PATCH] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-17 Thread Tony Dinh
on the following patch: https://patchwork.ozlabs.org/project/uboot/patch/20220412201820.10291-1-mibo...@gmail.com/ Signed-off-by: Tony Dinh --- arch/arm/dts/kirkwood-nsa310s.dts | 1 + board/zyxel/nsa310s/nsa310s.c | 119 +- board/zyxel/nsa310s/nsa310s.h | 46

[PATCH] net: marvell: mvgbe: Set PHY page 0 before phy_connect

2022-04-12 Thread Tony Dinh
MV88E1318) Dell Kace M300 (88F6282, network chip MV88E1318) - out of tree u-boot Signed-off-by: Tony Dinh --- drivers/net/mvgbe.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 954bf86121..d2db1e584a 100644 --- a/drivers/net/mvgbe.c +++ b

Re: [RFC PATCH v2] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-11 Thread Tony Dinh
410e90 phy.c phy_connect_dev: ethernet-controller@72000 connected to Marvell 88E1310 phy.c board_phy_config m88e1310_config m88e1011s_startup ethernet-controller@72000 Waiting for PHY auto negotiation to complete. done host 192.168.0.249 is alive On Fri, Apr 8, 2022 at 5:57 PM Tony Dinh

Re: [PATCH 1/2] Kconfig: Change SYS_MALLOC_F_LEN default to 0x2000

2022-04-09 Thread Tony Dinh
Hi Tom, For nsa310s_defconfig. Reviewed-by: Tony Dinh On Fri, Apr 8, 2022 at 5:52 AM Masami Hiramatsu wrote: > > Hi Tom, > > This looks good to me for the synquacer-defconfig part. > > Reviewed-by: Masami Hiramatsu > > Thank you, > > 2022年4月8日(金) 1:33 Tom Ri

[RFC PATCH v2] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-08 Thread Tony Dinh
Signed-off-by: Tony Dinh --- Changes in v2: Cleanup patch formatting arch/arm/dts/kirkwood-nsa310s.dts | 1 + board/zyxel/nsa310s/nsa310s.c | 120 +- board/zyxel/nsa310s/nsa310s.h | 46 configs/nsa310s_defconfig | 3 + drivers/net

Re: [RFC Patch] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-08 Thread Tony Dinh
Hi Stefan, On Thu, Apr 7, 2022 at 10:55 PM Tony Dinh wrote: > > On Thu, Apr 7, 2022 at 10:39 PM Stefan Roese wrote: > > > > Hi Tony, > > > > On 4/8/22 07:03, Tony Dinh wrote: > > > Hi all, > > > > > > This is a work-in-progress patch th

Re: [RFC Patch] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-07 Thread Tony Dinh
On Thu, Apr 7, 2022 at 10:39 PM Stefan Roese wrote: > > Hi Tony, > > On 4/8/22 07:03, Tony Dinh wrote: > > Hi all, > > > > This is a work-in-progress patch that I'm working on, to clean up the > > DM Ethernet code for the Zyxel NSA310S board (Kirkwood 88F

[RFC Patch] arm: kirkwood: nsa310s: Use Marvell uclass mvgbe and PHY driver for DM Ethernet

2022-04-07 Thread Tony Dinh
Dinh + * Copyright (C) 2015, 2021-2022 Tony Dinh * Copyright (C) 2015 Gerald Kerma */ #include #include -#include -#include +#include #include #include #include #include #include -#include "nsa310s.h" +#include DECLARE_GLOBAL_DATA_PTR; +/* + * low GPIO's + *

Re: [PATCH] arm: kirkwood: Add nas440 board, Marvell 88SE6121 AHCI

2022-03-28 Thread Tony Dinh
Hi Hajo & Pali, On Mon, Mar 28, 2022 at 2:28 AM Pali Rohár wrote: > > Hello! > > On Monday 28 March 2022 10:36:36 Hajo Noerenberg wrote: > > Hi Pali, > > > > Am 28.03.2022 um 10:04 schrieb Pali Rohár: > > > On Monday 28 March 2022 09:57:41 Hajo Noerenberg wrote: > > >> I wonder if it would be a

Re: [PATCH] arm: kirkwood: Add nas440 board, Marvell 88SE6121 AHCI

2022-03-25 Thread Tony Dinh
il/u-boot/2022-March/478823.html Thanks, Tony On Thu, Mar 24, 2022 at 3:04 PM Tony Dinh wrote: > > Hi Hajo, > > I've added Stefan. > > When you send patches for Kirkwood or other Marvell boards, please > also send it directly to Stefan (Stefan is the maintainer of Marvell >

Re: [PATCH] arm: kirkwood: Add nas440 board, Marvell 88SE6121 AHCI

2022-03-24 Thread Tony Dinh
Hi Hajo, I've added Stefan. When you send patches for Kirkwood or other Marvell boards, please also send it directly to Stefan (Stefan is the maintainer of Marvell u-boots). Tony On Thu, Mar 24, 2022 at 3:11 AM Pali Rohár wrote: > > Hello! > > On Thursday 24 March 2022 10:55:38 Hajo

Re: [PATCH v3] arm: kirkwood: nas220: Add DM Ethernet, SATA, GPIO

2022-03-23 Thread Tony Dinh
merged to master. All the best, Tony On Thu, Mar 17, 2022 at 7:20 PM Tony Dinh wrote: > > Hi Stefan & Hajo, > > Please see my comment below. > > On Wed, Mar 9, 2022 at 2:44 PM Tony Dinh wrote: > > > > Hi Hajo, > > > > Please see comments belo

Re: [PATCH] arm: kirkwood: Sheevaplug : Use Marvell uclass mvgbe and PHY driver for Ethernet

2022-03-22 Thread Tony Dinh
for the 1st approach, because by holding off the 2 pending patches, we don't lose any functionality in the meantime. And it will be much easier to do. Thanks, Tony On Mon, Mar 21, 2022 at 4:46 AM Tom Rini wrote: > > On Mon, Mar 21, 2022 at 03:36:50AM -0700, Tony Dinh wrote: > >

Re: [PATCH] arm: kirkwood: Sheevaplug : Use Marvell uclass mvgbe and PHY driver for Ethernet

2022-03-21 Thread Tony Dinh
r 21, 2022 at 03:36:50AM -0700, Tony Dinh wrote: > > > Hi Stefan, > > > > Perhaps you've missed merging this patch into your tree, or during the > > pull request to Tom. > > > > I saw Tom's recent patch to move the CONFIG_RESET_PHY_R to Kconfig: > > https:

Re: [PATCH] arm: kirkwood: Sheevaplug : Use Marvell uclass mvgbe and PHY driver for Ethernet

2022-03-21 Thread Tony Dinh
/sheevaplug_defconfig +CONFIG_RESET_PHY_R=y And that should not be added for the Sheevaplug, since we have undef CONFIG_RESET_PHY_R in include/configs/sheevaplug.h Thanks, Tony On Tue, Mar 8, 2022 at 4:25 AM Stefan Roese wrote: > > On 3/7/22 00:12, Tony Dinh wrote: > > The Globalscale

Re: [PATCH v3] arm: kirkwood: nas220: Add DM Ethernet, SATA, GPIO

2022-03-17 Thread Tony Dinh
Hi Stefan & Hajo, Please see my comment below. On Wed, Mar 9, 2022 at 2:44 PM Tony Dinh wrote: > > Hi Hajo, > > Please see comments below. > > On Wed, Mar 9, 2022 at 5:42 AM Hajo Noerenberg > wrote: > > > > On 09.03.2022 at 12:26 Tony Dinh wrote:

Re: [PATCH v3] arm: kirkwood: nas220: Add DM Ethernet, SATA, GPIO

2022-03-09 Thread Tony Dinh
Hi Hajo, Please see comments below. On Wed, Mar 9, 2022 at 5:42 AM Hajo Noerenberg wrote: > > On 09.03.2022 at 12:26 Tony Dinh wrote: > > Hi Hajo, > > > > Hi Tony, > > > On Wed, Mar 9, 2022 at 1:27 AM Hajo Noerenberg > > wrote: > >> >

Re: [PATCH v3] arm: kirkwood: nas220: Add DM Ethernet, SATA, GPIO

2022-03-09 Thread Tony Dinh
Hi Hajo, On Wed, Mar 9, 2022 at 1:27 AM Hajo Noerenberg wrote: > > Bring the NAS220 board up to current standards. This is basically an > adaptation of the changes Tony Dinh implemented for the Dockstar board. > > - Implement the changes to v2 as suggested by Stefa

Re: kwboot - positional tty argument

2022-03-07 Thread Tony Dinh
Hi Stefan, On Mon, Mar 7, 2022 at 6:39 AM Stefan Roese wrote: > > On 3/7/22 12:40, Pali Rohár wrote: > > Hello! > > > > On Sunday 06 March 2022 14:38:57 Tony Dinh wrote: > >> Hi Pali, > >> > >> I have an observation, which is not related to th

Re: [PATCH v2 3/3] tools: kwboot: Allow to mix positional arguments with option -b

2022-03-07 Thread Tony Dinh
Hi Pali, I've tested this patch series and it's all working fine! Thanks, Tony Tested-by: Tony Dinh On Mon, Mar 7, 2022 at 10:04 AM Pali Rohár wrote: > > Commit 9e6d71d2b55f ("tools: kwboot: Allow to use -b without image path as > the last getopt() option") br

[PATCH] arm: kirkwood: Sheevaplug : Use Marvell uclass mvgbe and PHY driver for Ethernet

2022-03-06 Thread Tony Dinh
and remove header file board/Marvell/sheevaplug/sheevaplug.h, use BIT macro, and add/cleanup comments. Signed-off-by: Tony Dinh --- board/Marvell/sheevaplug/sheevaplug.c | 83 +-- board/Marvell/sheevaplug/sheevaplug.h | 24 configs/sheevaplug_defconfig | 1

Re: [PATCH] tools: kwboot: Check if baudrate value is supported before sending image

2022-03-06 Thread Tony Dinh
Hi Pali, I have an observation, which is not related to this patch. But about the kwboot options changes in general, I hope it is OK to mention it here. Before the changes you've made to solve the problem with the -b option, I can do this: kwboot -t -B 115200 /dev/ttyUSB0 -b uboot.kwb But

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-03 Thread Tony Dinh
). Thanks for a new and improved kwboot! Tested-by: Tony Dinh Thanks, Tony On Thu, Mar 3, 2022 at 4:05 PM Pali Rohár wrote: > > Hello! > > On Thursday 03 March 2022 15:58:41 Tony Dinh wrote: > > Hi Pali, > > > > Here is the test report. > > > > 1. Kirkw

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-03 Thread Tony Dinh
, Tony On Wed, Mar 2, 2022 at 1:18 PM Tony Dinh wrote: > > Hi Pali, > > > On Wed, Mar 2, 2022 at 1:03 PM Pali Rohár wrote: > > > > On Wednesday 02 March 2022 12:51:25 Tony Dinh wrote: > > > Hi Pali, > > > > > > The patch did not apply c

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-02 Thread Tony Dinh
Hi Pali, On Wed, Mar 2, 2022 at 1:03 PM Pali Rohár wrote: > > On Wednesday 02 March 2022 12:51:25 Tony Dinh wrote: > > Hi Pali, > > > > The patch did not apply cleanly to the master branch (I downloaded the > > series from patchwork). Do you have a link where I can

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-02 Thread Tony Dinh
Hi Pali, The patch did not apply cleanly to the master branch (I downloaded the series from patchwork). Do you have a link where I can use it? Thanks, Tony On Wed, Mar 2, 2022 at 2:52 AM Pali Rohár wrote: > > This patch series fixes sending boot and debug patterns by doing it in > separate

Re: [PATCH] arm: kirkwood: nas220: Add DM Ethernet, SATA, GPIO

2022-02-24 Thread Tony Dinh
Hi Hajo, I've added Stefan to the reviewers. And please see a couple of minor comments below. On Thu, Feb 24, 2022 at 5:48 AM Hajo Noerenberg wrote: > > Bring the NAS220 board up to current standards. This is basically an > adaptation of the changes Tony Dinh implemented for the Docks

Re: kwboot: Marvell Dove UART booting

2022-02-16 Thread Tony Dinh
Hi Pali, Please see below. On Tue, Feb 15, 2022 at 3:02 PM Pali Rohár wrote: > > Hello! > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > *** With jumper inserted, serial console connected, start serial console > > > > # picocom --b 115200

Re: [PATCH u-boot-marvell 0/7] tools: kwbimage: Support for parsing extended v0 format

2022-02-16 Thread Tony Dinh
Thanks! Tested-by: Tony Dinh On Tue, Feb 15, 2022 at 10:59 AM Pali Rohár wrote: > > This patch series extends kwbimage v0 format support by providing > ability to dump content of Dove boot images (extension of v0 format). > It also fixes recognition of these images in kwboot utility

Re: kwboot: Marvell Dove UART booting

2022-02-15 Thread Tony Dinh
Hi Pali, On Tue, Feb 15, 2022 at 11:11 AM Pali Rohár wrote: > > On Monday 14 February 2022 14:00:19 Tony Dinh wrote: > > Hi Pali, > > > > On Mon, Feb 14, 2022 at 1:58 AM Pali Rohár wrote: > > > > > > On Sunday 13 February 2022 17:10:26 Tony Dinh wrot

Re: kwboot: Marvell Dove UART booting

2022-02-14 Thread Tony Dinh
Hi Pali, On Mon, Feb 14, 2022 at 1:58 AM Pali Rohár wrote: > > On Sunday 13 February 2022 17:10:26 Tony Dinh wrote: > > Hi Pali, > > > > Please see below. > > > > On Sun, Feb 13, 2022 at 4:21 PM Pali Rohár wrote: > > > > > > On Sunday 13 F

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, Please see below. On Sun, Feb 13, 2022 at 4:21 PM Pali Rohár wrote: > > On Sunday 13 February 2022 16:08:51 Tony Dinh wrote: > > Hi Pali, > > > > On Sun, Feb 13, 2022 at 3:42 PM Pali Rohár wrote: > > > > > > On Sunday 13 February 2022

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, On Sun, Feb 13, 2022 at 3:42 PM Pali Rohár wrote: > > On Sunday 13 February 2022 15:24:46 Tony Dinh wrote: > > Hi Pali, > > > > Looks different, but the BootROM did not start the image. Please see > > the log below. > > > > On Sun,

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, Looks different, but the BootROM did not start the image. Please see the log below. On Sun, Feb 13, 2022 at 2:48 PM Pali Rohár wrote: > > On Sunday 13 February 2022 14:45:07 Tony Dinh wrote: > > Hi Pali, > > > > Some compile errors, please see below. > >

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, Some compile errors, please see below. On Sun, Feb 13, 2022 at 8:16 AM Pali Rohár wrote: > > On Wednesday 22 December 2021 20:08:56 Tony Dinh wrote: > > *** Run kwboot > > > > # kwboot -t -p -B 115200 /dev/ttyUSB0 -D /localdisk/mtd0.t5335z > > Patchin

Re: kwboot: Marvell Dove UART booting

2022-02-13 Thread Tony Dinh
Hi Pali, On Sun, Feb 13, 2022 at 1:33 PM Marek Behún wrote: > > On Sun, 13 Feb 2022 22:23:10 +0100 > Pali Rohár wrote: > > > > In that case the whole ternary operator can be dropped, i.e. instead of > > > ((hdr->ext > 1) ? (hdr->ext * 0x20) : 0) > > > you can have > > > ((hdr->ext - 1) *

[PATCH] arm: kirkwood: Pogoplug E02 : Convert Ethernet to Driver Model

2022-02-08 Thread Tony Dinh
-off-by: Tony Dinh --- board/cloudengines/pogo_e02/pogo_e02.c | 51 +++--- board/cloudengines/pogo_e02/pogo_e02.h | 29 --- configs/pogo_e02_defconfig | 6 ++- include/configs/pogo_e02.h | 13 ++- 4 files changed, 22 insertions(+), 77

Re: Marvell Avanta UART booting

2022-02-07 Thread Tony Dinh
Hi Pali, On Mon, Feb 7, 2022 at 12:44 AM Pali Rohár wrote: > > On Sunday 06 February 2022 15:37:53 Tony Dinh wrote: > > Hi Pali, > > > > I've also tried the latest kwboot with the Marvell Avanta SoC. AFAICT, > > it works fine. > > > > Board:

Re: [PATCH] tools/mrvl_uart.sh: Remove script

2022-02-07 Thread Tony Dinh
Most Kirwood boards work with the current kwboot. And those boards have the BootROM version 1.2.1. For a few that don't, mrvl_uart.sh does not work either. And that is due to the defect in the BootROM version 1.1.1. Thanks! Reviewed-by: Tony Dinh On Sun, Feb 6, 2022 at 11:27 PM Marcel

Marvell Avanta UART booting

2022-02-06 Thread Tony Dinh
Hi Pali, I've also tried the latest kwboot with the Marvell Avanta SoC. AFAICT, it works fine. Board: ActionTec MI424WR-I SoC: 88F6560 A0 Thanks, Tony

[RESEND PATCH] arm: kirkwood: Dockstar : Add DM Ethernet

2022-02-03 Thread Tony Dinh
/project/uboot/patch/20210812051854.1340-2-mibo...@gmail.com/ Signed-off-by: Tony Dinh --- board/Seagate/dockstar/dockstar.c | 62 ++- board/Seagate/dockstar/dockstar.h | 27 -- configs/dockstar_defconfig| 5 +++ include/configs/dockstar.h

[PATCH] arm: kirkwood: iConnect : Add Ethernet support

2022-02-01 Thread Tony Dinh
Ethernet. - Miscellaneous changes: Move constants to .c file and remove header file board/iomega/iconnect/iconnect.h. Add CONFIG_HUSH_PARSER, use BIT macro, and cleanup comments. Signed-off-by: Tony Dinh --- board/iomega/iconnect/iconnect.c | 17 ++--- board/iomega/iconnect/iconnect.h | 24

[PATCH] arm: kirkwood: Dreamplug : Use Marvell uclass mvgbe and PHY driver for Ethernet

2022-01-30 Thread Tony Dinh
to be orphaned, could not contact Jason Cooper using current email). - Miscellaneous changes: Move constants to .c file and remove header file board/Marvell/dreamplug/dreamplug.h, cleanup comments. Signed-off-by: Tony Dinh --- board/Marvell/dreamplug/MAINTAINERS | 1 + board/Marvell/dreamplug

[PATCH] arm: kirkwood: GoFlex Home : Use Marvell uclass mvgbe and PHY driver for Ethernet

2022-01-25 Thread Tony Dinh
BIT macro, and cleanup comments. Signed-off-by: Tony Dinh --- board/Seagate/goflexhome/goflexhome.c | 84 --- configs/goflexhome_defconfig | 2 + include/configs/goflexhome.h | 32 +++--- 3 files changed, 22 insertions(+), 96 deletions(-) diff

Re: [PATCH] arm: kirkwood: Pogoplug V4 : Use Marvel network PHY driver

2022-01-25 Thread Tony Dinh
Hi Stefan, On Tue, Jan 25, 2022 at 7:49 AM Stefan Roese wrote: > > On 1/25/22 10:48, Tony Dinh wrote: > > The Pogoplug V4 board has the network chip Marvell 88E1118R. So to > > properly configure the network, enable CONFIG_PHY_MARVELL to activate > > the driver M88E111

[RESEND PATCH] arm: kirkwood: Pogoplug V4 : Use Marvell network PHY driver

2022-01-25 Thread Tony Dinh
/ Signed-off-by: Tony Dinh --- configs/pogo_v4_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig index 5490067b9e..1cf409c834 100644 --- a/configs/pogo_v4_defconfig +++ b/configs/pogo_v4_defconfig @@ -62,6 +62,7

[PATCH] arm: kirkwood: Pogoplug V4 : Use Marvel network PHY driver

2022-01-25 Thread Tony Dinh
-by: Tony Dinh --- configs/pogo_v4_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/pogo_v4_defconfig b/configs/pogo_v4_defconfig index 5490067b9e..1cf409c834 100644 --- a/configs/pogo_v4_defconfig +++ b/configs/pogo_v4_defconfig @@ -62,6 +62,7 @@ CONFIG_KIRKWOOD_GPIO=y

Re: [PATCH v5 3/3] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-24 Thread Tony Dinh
Hi Stefan, On Mon, Jan 24, 2022 at 2:25 AM Tony Dinh wrote: > > Hi Stefan, > > On Mon, Jan 24, 2022 at 1:41 AM Stefan Roese wrote: > > > > On 1/24/22 07:17, Tony Dinh wrote: > > > Add board header, defconfig, and implementation files for Pogoplug V4. >

Re: [PATCH v5 3/3] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-24 Thread Tony Dinh
Hi Stefan, On Mon, Jan 24, 2022 at 1:41 AM Stefan Roese wrote: > > On 1/24/22 07:17, Tony Dinh wrote: > > Add board header, defconfig, and implementation files for Pogoplug V4. > > > > Signed-off-by: Tony Dinh > > --- > > > > Changes in v5: > >

[PATCH v5 3/3] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-23 Thread Tony Dinh
Add board header, defconfig, and implementation files for Pogoplug V4. Signed-off-by: Tony Dinh --- Changes in v5: - Currently, CONFIG_RESET_PHY_R symbol is used in arch/arm/mach-kirkwood/include/mach/config.h for all Kirkwood boards with mv8831116 PHY, with each board defines the function

[PATCH v5 2/3] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2022-01-23 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v3) Changes in v3: - Migrate symbols from board include header to Kconfig arch/arm/mach-kirkwood/Kconfig | 6 ++ board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 22

[PATCH v5 1/3] arm: kirkwood: Pogoplug-V4 : Add DTS files

2022-01-23 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- (no changes since v2) Changes in v2: - Use mainline Linux DTS version arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug-series-4.dts | 180 2

[PATCH v5 0/3] arm: kirkwood: Add support for Pogoplug V4

2022-01-23 Thread Tony Dinh
for unselectable config symbols in header file Changes in v2: - Use mainline Linux DTS version - Move constants to .c file and remove header file - Use canonical format for defconfig file Tony Dinh (3): arm: kirkwood: Pogoplug-V4 : Add DTS files arm: kirkwood: Pogoplug-V4 : Add Kconfig files

Re: [PATCH v4 3/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-22 Thread Tony Dinh
Hi Pali, On Fri, Jan 21, 2022 at 1:33 PM Tony Dinh wrote: > > Hi Pali and Stefan, > > On Fri, Jan 21, 2022 at 2:01 AM Pali Rohár wrote: > > > > On Thursday 20 January 2022 17:50:54 Tony Dinh wrote: > > > diff --git a/board/cloudengines/pogo_v4/pogo_v4.c &

Re: [PATCH v4 3/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-21 Thread Tony Dinh
Hi Pali and Stefan, On Fri, Jan 21, 2022 at 2:01 AM Pali Rohár wrote: > > On Thursday 20 January 2022 17:50:54 Tony Dinh wrote: > > diff --git a/board/cloudengines/pogo_v4/pogo_v4.c > > b/board/cloudengines/pogo_v4/pogo_v4.c > > new file mode 100644 > > index 0

Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-21 Thread Tony Dinh
Hi Stefan, On Wed, Jan 19, 2022 at 3:23 PM Tony Dinh wrote: > > fHi Stefan, > > On Wed, Jan 19, 2022 at 6:37 AM Stefan Roese wrote: > > > > Hi Tony, > > > > On 1/19/22 02:31, Tony Dinh wrote: > > > > > > > > >>> +#if

[PATCH v4 4/4] arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

2022-01-20 Thread Tony Dinh
Add board include header and defconfig files for Pogoplug V4 Signed-off-by: Tony Dinh --- Changes in v4: - Remove CONFIG_FEATURE_COMMAND_EDITING and ifdefs for CMD_NET in include header Changes in v3: - Migrate config symbols from board include header to defconfig - Remove obsolete config

[PATCH v4 3/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-20 Thread Tony Dinh
rewritten to use livetree calls. Signed-off-by: Tony Dinh --- (no changes since v3) Changes in v3: - Squash board file small patches into one patch Changes in v2: - Move constants to .c file and remove header file board/cloudengines/pogo_v4/MAINTAINERS | 6 + board/cloudengines/pogo_v4/Makefile

[PATCH v4 2/4] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2022-01-20 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v3) Changes in v3: - Migrate symbols from board include header to Kconfig arch/arm/mach-kirkwood/Kconfig | 6 ++ board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 22

[PATCH v4 1/4] arm: kirkwood: Pogoplug-V4 : Add DTS files

2022-01-20 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- (no changes since v2) Changes in v2: - Use mainline Linux DTS version arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug-series-4.dts | 180 2

[PATCH v4 0/4] arm: kirkwood: Add support for Pogoplug V4

2022-01-20 Thread Tony Dinh
file Changes in v2: - Use mainline Linux DTS version - Move constants to .c file and remove header file - Use canonical format for defconfig file Tony Dinh (4): arm: kirkwood: Pogoplug-V4 : Add DTS files arm: kirkwood: Pogoplug-V4 : Add Kconfig files arm: kirkwood: Pogoplug-V4 : Add board

Re: [RESEND PATCH v3 4/4] arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

2022-01-20 Thread Tony Dinh
Hi Stefan, On Thu, Jan 20, 2022 at 3:55 AM Stefan Roese wrote: > > Hi Tony, > > On 1/20/22 01:28, Tony Dinh wrote: > > Add board include header and defconfig files for Pogoplug V4 > > > > Signed-off-by: Tony Dinh > > --- > > > > Changes in v3:

[RESEND PATCH v3 4/4] arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

2022-01-19 Thread Tony Dinh
Add board include header and defconfig files for Pogoplug V4 Signed-off-by: Tony Dinh --- Changes in v3: - Migrate config symbols from board include header to defconfig - Remove obsolete config symbols from header file - Don't use ifdefs for unselectable config symbols in header file Changes

[RESEND PATCH v3 3/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-19 Thread Tony Dinh
rewritten to use livetree calls. Signed-off-by: Tony Dinh --- Changes in v3: - Squash board file small patches into one patch Changes in v2: - Move constants to .c file and remove header file board/cloudengines/pogo_v4/MAINTAINERS | 6 + board/cloudengines/pogo_v4/Makefile | 10 ++ board

[RESEND PATCH v3 2/4] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2022-01-19 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- Changes in v3: - Migrate symbols from board include header to Kconfig arch/arm/mach-kirkwood/Kconfig | 6 ++ board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 22 insertions(+) create mode

[RESEND PATCH v3 1/4] arm: kirkwood: Pogoplug-V4 : Add DTS files

2022-01-19 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- (no changes since v2) Changes in v2: - Use mainline Linux DTS version arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug-series-4.dts | 180 2

[RESEND PATCH v3 0/4] arm: kirkwood: Add support for Pogoplug V4

2022-01-19 Thread Tony Dinh
header file - Use canonical format for defconfig file Tony Dinh (4): arm: kirkwood: Pogoplug-V4 : Add DTS files arm: kirkwood: Pogoplug-V4 : Add Kconfig files arm: kirkwood: Pogoplug-V4 : Add board implementation files arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-19 Thread Tony Dinh
fHi Stefan, On Wed, Jan 19, 2022 at 6:37 AM Stefan Roese wrote: > > Hi Tony, > > On 1/19/22 02:31, Tony Dinh wrote: > > > > >>> +#if defined(CONFIG_RESET_PHY_R) > >>> +/* Configure and initialize PHY */ > >>> +void reset_phy(vo

Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-18 Thread Tony Dinh
Hi Stefan, On Mon, Jan 17, 2022 at 11:54 PM Stefan Roese wrote: > > On 1/18/22 07:58, Tony Dinh wrote: > > Note: currently the fdt_get_phy_addr function in this file is > > duplicate in this board and many other Kirkwood boards > > (eg. Sheevaplug, GoFlex Home, etc.)

[PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-17 Thread Tony Dinh
rewritten to use livetree calls. Signed-off-by: Tony Dinh --- Changes in v3: - Squash board file small patches into one patch Changes in v2: - Move constants to .c file and remove header file board/cloudengines/pogo_v4/MAINTAINERS | 6 + board/cloudengines/pogo_v4/Makefile | 10 ++ board

[PATCH v3 3/4] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2022-01-17 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- Changes in v3: - Migrate symbols from board include header to Kconfig arch/arm/mach-kirkwood/Kconfig | 6 ++ board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 22 insertions(+) create mode

[PATCH v3 2/4] arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files

2022-01-17 Thread Tony Dinh
Add board include header and defconfig files for Pogoplug V4 Signed-off-by: Tony Dinh --- Changes in v3: - Migrate config symbols from board include header to defconfig - Remove obsolete config symbols from header file - Don't use ifdefs for unselectable config symbols in header file Changes

[PATCH v3 1/4] arm: kirkwood: Pogoplug-V4 : Add DTS files

2022-01-17 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- (no changes since v2) Changes in v2: - Use mainline Linux DTS version arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug-series-4.dts | 180 2

[PATCH v3 0/4] arm: kirkwood: Add support for Pogoplug V4

2022-01-17 Thread Tony Dinh
- Move constants to .c file and remove header file Tony Dinh (4): arm: kirkwood: Pogoplug-V4 : Add DTS files arm: kirkwood: Pogoplug V4 : Add board include header and defconfig files arm: kirkwood: Pogoplug-V4 : Add Kconfig files arm: kirkwood: Pogoplug-V4 : Add board implementation files

Re: [PATCH] pci: pci_mvebu: Add support for Kirkwood PCIe controllers

2022-01-14 Thread Tony Dinh
Hi Pali, On Thu, Jan 13, 2022 at 3:35 PM Tony Dinh wrote: > > Hi Pali, > > On Thu, Jan 13, 2022 at 5:28 AM Pali Rohár wrote: > > > > Kirkwood uses macros KW_DEFADR_PCI_MEM and KW_DEFADR_PCI_IO for base > > address of PCIe mappings. Size of PCIe windows is not de

Re: [PATCH v2 4/8] arm: kirkwood: Pogoplug-V4 : Add board include configs file

2022-01-13 Thread Tony Dinh
Hi Tom, On Thu, Jan 13, 2022 at 5:36 AM Tom Rini wrote: > > On Thu, Jan 13, 2022 at 02:32:00PM +0100, Stefan Roese wrote: > > On 12/23/21 08:26, Tony Dinh wrote: > > > Add include configs file for Pogoplug V4 board > > > > > > Signed-off-by: Tony Dinh >

Re: [PATCH] pci: pci_mvebu: Add support for Kirkwood PCIe controllers

2022-01-13 Thread Tony Dinh
Hi Pali, On Thu, Jan 13, 2022 at 5:28 AM Pali Rohár wrote: > > Kirkwood uses macros KW_DEFADR_PCI_MEM and KW_DEFADR_PCI_IO for base > address of PCIe mappings. Size of PCIe windows is not defined in any macro > yet, so export them in new KW_DEFADR_PCI_MEM_SIZE and KW_DEFADR_PCI_IO_SIZE > macros.

Re: [PATCH v2 8/8] arm: kirkwood: Pogoplug-V4 : Add board maintainer

2022-01-13 Thread Tony Dinh
Hi Stefan & Tom, On Thu, Jan 13, 2022 at 5:40 AM Stefan Roese wrote: > > On 12/23/21 08:26, Tony Dinh wrote: > > Add board maintainer for Pogoplug V4 board > > > > Signed-off-by: Tony Dinh > > Hmm, just this one file? > > I would prefer to not have thi

[PATCH 3/3] arm: kirkwood: iConnect : Update board maintainer

2022-01-01 Thread Tony Dinh
Add myself as maintainer. Signed-off-by: Tony Dinh --- board/iomega/iconnect/MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/board/iomega/iconnect/MAINTAINERS b/board/iomega/iconnect/MAINTAINERS index 167cf074b9..a1b018e816 100644 --- a/board/iomega/iconnect/MAINTAINERS +++ b

[PATCH 2/3] arm: kirkwood: iConnect : Add PCIe late init

2022-01-01 Thread Tony Dinh
- Add board_late_init function to enable pci_init Signed-off-by: Tony Dinh --- board/iomega/iconnect/iconnect.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/board/iomega/iconnect/iconnect.c b/board/iomega/iconnect/iconnect.c index fe4be28b13..9e123aab00 100644 --- a/board/iomega

[PATCH 1/3] arm: kirkwood: iConnect : Add PCIe related configs

2022-01-01 Thread Tony Dinh
- Add MVEBU PCIe configs - Also add SYS_THUMB_BUILD to keep u-boot image size within 512K Signed-off-by: Tony Dinh --- configs/iconnect_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/iconnect_defconfig b/configs/iconnect_defconfig index d8593bcdd2..bc44dbd218 100644

[PATCH 0/3] Add PCIe support for Iomega iConnect board

2022-01-01 Thread Tony Dinh
maintaining it actively Tony Dinh (3): arm: kirkwood: iConnect : Add PCIe related configs arm: kirkwood: iConnect : Add PCIe late init arm: kirkwood: iConnect : Update board maintainer board/iomega/iconnect/MAINTAINERS | 1 + board/iomega/iconnect/iconnect.c | 7 +++ configs

Re: kwboot: Marvell Dove UART booting

2022-01-01 Thread Tony Dinh
Hi Pali On Sat, Jan 1, 2022 at 3:12 PM Pali Rohár wrote: > > On Saturday 01 January 2022 14:54:34 Tony Dinh wrote: > > Hi Pali, > > > > On Sat, Jan 1, 2022 at 1:53 PM Pali Rohár wrote: > > > > > > On Sunday 26 December 2021 13:41:03 Tony Dinh wrote: >

Re: kwboot: Marvell Dove UART booting

2022-01-01 Thread Tony Dinh
Hi Pali, On Sat, Jan 1, 2022 at 1:53 PM Pali Rohár wrote: > > On Sunday 26 December 2021 13:41:03 Tony Dinh wrote: > > Follow up on the UART booting session before. > > > > Thanks for the advice about the Reset Strapping documentation. I've >

Re: kwboot: Marvell Dove UART booting

2021-12-26 Thread Tony Dinh
Hi Pali, On Wed, Dec 22, 2021 at 8:08 PM Tony Dinh wrote: > > Hi all, > > With great help from Pali, I've made some good progress on > kwboot the HP Thin Client T5335z (Marvell Dove SoC) board. > I had been unsuccessful running kwboot with this box until Pali > pointe

[PATCH v2 8/8] arm: kirkwood: Pogoplug-V4 : Add board maintainer

2021-12-22 Thread Tony Dinh
Add board maintainer for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v1) board/cloudengines/pogo_v4/MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 board/cloudengines/pogo_v4/MAINTAINERS diff --git a/board/cloudengines/pogo_v4/MAINTAINERS b

[PATCH v2 7/8] arm: kirkwood: Pogoplug-V4 : Add board implementation

2021-12-22 Thread Tony Dinh
for flattree only, the patch is being rewritten to use livetree calls. Signed-off-by: Tony Dinh --- Changes in v2: Merge constants from header file. board/cloudengines/pogo_v4/pogo_v4.c | 220 +++ 1 file changed, 220 insertions(+) create mode 100644 board/cloudengines

[PATCH v2 6/8] arm: kirkwood: Pogoplug-V4 : Add board Make file

2021-12-22 Thread Tony Dinh
Add board Makefile for Pogoplug V4 Signed-off-by: Tony Dinh --- Changes in v2: - Merge all constants into the pogo_v4.c file, remove pogo_v4.h board/cloudengines/pogo_v4/Makefile | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 board/cloudengines/pogo_v4/Makefile diff

[PATCH v2 5/8] arm: kirkwood: Pogoplug-V4 : Add board kwbimage file

2021-12-22 Thread Tony Dinh
Add board kwbimage file for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v1) board/cloudengines/pogo_v4/kwbimage.cfg | 148 1 file changed, 148 insertions(+) create mode 100644 board/cloudengines/pogo_v4/kwbimage.cfg diff --git a/board

[PATCH v2 4/8] arm: kirkwood: Pogoplug-V4 : Add board include configs file

2021-12-22 Thread Tony Dinh
Add include configs file for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v1) include/configs/pogo_v4.h | 94 +++ 1 file changed, 94 insertions(+) create mode 100644 include/configs/pogo_v4.h diff --git a/include/configs/pogo_v4.h b

[PATCH v2 3/8] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2021-12-22 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v1) arch/arm/mach-kirkwood/Kconfig | 4 board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 20 insertions(+) create mode 100644 board/cloudengines/pogo_v4/Kconfig diff

[PATCH v2 2/8] arm: kirkwood: Pogoplug V4 : Add board defconfig file

2021-12-22 Thread Tony Dinh
Add board defconfig file for Pogoplug V4 board Signed-off-by: Tony Dinh --- Changes in v2: - Use canonical format for defconfig file configs/pogo_v4_defconfig | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 configs/pogo_v4_defconfig diff

[PATCH v2 1/8] arm: kirkwood: Pogoplug-V4 : Add DTS files

2021-12-22 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Signed-off-by: Tony Dinh --- Changes in v2: - Use mainline Linux DTS version arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug-series-4.dts | 180 2 files changed, 181 insertions(+) create mode 100644

[PATCH v2 0/8] arm: kirkwood: Add support for Pogoplug V4

2021-12-22 Thread Tony Dinh
. Changes in v2: - Use mainline Linux DTS version - Use canonical format for defconfig file - Merge all constants into the pogo_v4.c file, remove pogo_v4.h Merge constants from header file. Tony Dinh (8): arm: kirkwood: Pogoplug-V4 : Add DTS files arm: kirkwood: Pogoplug V4 : Add board defconfig

kwboot: Marvell Dove UART booting

2021-12-22 Thread Tony Dinh
Hi all, With great help from Pali, I've made some good progress on kwboot the HP Thin Client T5335z (Marvell Dove SoC) board. I had been unsuccessful running kwboot with this box until Pali pointed out a few important aspects of the Dove SoC, and how the BootROM commands work (my apology for

Re: [PATCH 6/8] arm: kirkwood: Pogoplug-V4 : Add board implementation header

2021-12-20 Thread Tony Dinh
On Sun, Dec 19, 2021 at 11:23 PM Stefan Roese wrote: > > Hi Tony, > > On 12/18/21 22:47, Tony Dinh wrote: > > Hi Pali, > > > > On Sat, Dec 18, 2021 at 5:09 AM Pali Rohár wrote: > >> > >> On Friday 17 December 2021 20:23:32 Tony Dinh wrote: &g

Re: [PATCH 2/8] arm: kirkwood: Pogoplug V4 : Add board defconfig file

2021-12-20 Thread Tony Dinh
On Sun, Dec 19, 2021 at 11:18 PM Stefan Roese wrote: > > Hi Tony, > > On 12/18/21 22:41, Tony Dinh wrote: > > Hi Pali, > > > > On Sat, Dec 18, 2021 at 5:17 AM Pali Rohár wrote: > >> > >> On Friday 17 December 2021 20:23:28 Tony Dinh wrote: >

Re: [PATCH 1/8] arm: kirkwood: Pogoplug-V4 : Add DTS files

2021-12-18 Thread Tony Dinh
Hi Andre, On Sat, Dec 18, 2021 at 4:03 PM Andre Przywara wrote: > > On Sat, 18 Dec 2021 14:05:39 -0800 > Tony Dinh wrote: > > Hi Tony, > > > On Sat, Dec 18, 2021 at 8:38 AM Andre Przywara > > wrote: > > > > > > On Fri, 17 Dec 2021 20:23

Re: [PATCH 7/8] arm: kirkwood: Pogoplug-V4 : Add board implementation

2021-12-18 Thread Tony Dinh
Hi Marek, On Sat, Dec 18, 2021 at 2:59 PM Marek Behún wrote: > > > +#if defined(CONFIG_RESET_PHY_R) > > +/* Configure and initialize PHY */ > > +void reset_phy(void) > > +{ > > + u16 reg; > > + int phyaddr; > > + char *name = "ethernet-controller@72000"; > > + char *eth0_path =

Re: [PATCH 1/8] arm: kirkwood: Pogoplug-V4 : Add DTS files

2021-12-18 Thread Tony Dinh
HI Andre, On Sat, Dec 18, 2021 at 8:38 AM Andre Przywara wrote: > > On Fri, 17 Dec 2021 20:23:27 -0800 > Tony Dinh wrote: > > Hi, > > > Add DTS files for Pogoplug V4 board > > is there any reason you didn't take the kirkwood-pogoplug-series-4.dts > file from

<    1   2   3   4   5   >