Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-12-02 Thread Tom Rini
On Mon, Oct 26, 2020 at 02:10:49PM +0100, Pali Rohár wrote: > On more places is used pattern 'command > $@ || rm -f $@'. But it does not > propagate failure from 'command' as 'rm -f' returns success. > > Fix it by calling 'false' to correctly propagate failure after 'rm -f'. > > Signed-off-by:

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-11-17 Thread Tom Rini
On Tue, Nov 17, 2020 at 10:44:52PM +0100, Pali Rohár wrote: > Hello! I would like to remind this patch. I do not know who is maintainer > of Makefile and therefore who can take this patch but Simon has already > reviewed it. I'll take it, at some point. Unless this is missing a Fixes tag, I'm

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-11-17 Thread Pali Rohár
Hello! I would like to remind this patch. I do not know who is maintainer of Makefile and therefore who can take this patch but Simon has already reviewed it. On Tuesday 27 October 2020 20:10:37 Simon Glass wrote: > On Mon, 26 Oct 2020 at 07:11, Pali Rohár wrote: > > > > On more places is used

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-10-30 Thread Simon Glass
Hi Paul, On Tue, 27 Oct 2020 at 20:25, Pali Rohár wrote: > > On Tuesday 27 October 2020 20:10:37 Simon Glass wrote: > > Hi Paul, > > > > On Mon, 26 Oct 2020 at 07:11, Pali Rohár wrote: > > > > > > On more places is used pattern 'command > $@ || rm -f $@'. But it does not > > > propagate failure

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-10-27 Thread Pali Rohár
On Tuesday 27 October 2020 20:10:37 Simon Glass wrote: > Hi Paul, > > On Mon, 26 Oct 2020 at 07:11, Pali Rohár wrote: > > > > On more places is used pattern 'command > $@ || rm -f $@'. But it does not > > propagate failure from 'command' as 'rm -f' returns success. > > > > Fix it by calling

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-10-27 Thread Simon Glass
Hi Paul, On Mon, 26 Oct 2020 at 07:11, Pali Rohár wrote: > > On more places is used pattern 'command > $@ || rm -f $@'. But it does not > propagate failure from 'command' as 'rm -f' returns success. > > Fix it by calling 'false' to correctly propagate failure after 'rm -f'. > > Signed-off-by:

[PATCH] Makefile: Correctly propagate failure when removing target

2020-10-26 Thread Pali Rohár
On more places is used pattern 'command > $@ || rm -f $@'. But it does not propagate failure from 'command' as 'rm -f' returns success. Fix it by calling 'false' to correctly propagate failure after 'rm -f'. Signed-off-by: Pali Rohár --- Makefile | 12 ++-- 1 file changed, 6