Re: [PATCH] gpio-uclass: fix off-by-one in gpio_request_list_by_name_nodev()

2023-04-26 Thread Tom Rini
On Wed, Apr 19, 2023 at 12:10:13PM +0200, Rasmus Villemoes wrote: > By the time we jump to the err label, count represents the number of > gpios we've succesfully requested. So by subtracting one, we fail to > free the most recently requested. > > Signed-off-by: Rasmus Villemoes > Reviewed-by: S

Re: [PATCH] gpio-uclass: fix off-by-one in gpio_request_list_by_name_nodev()

2023-04-19 Thread Rasmus Villemoes
On 20/04/2023 00.40, Simon Glass wrote: > On Wed, 19 Apr 2023 at 22:11, Rasmus Villemoes > wrote: >> >> By the time we jump to the err label, count represents the number of >> gpios we've succesfully requested. So by subtracting one, we fail to >> free the most recently requested. >> >> Signed-off

Re: [PATCH] gpio-uclass: fix off-by-one in gpio_request_list_by_name_nodev()

2023-04-19 Thread Simon Glass
On Wed, 19 Apr 2023 at 22:11, Rasmus Villemoes wrote: > > By the time we jump to the err label, count represents the number of > gpios we've succesfully requested. So by subtracting one, we fail to > free the most recently requested. > > Signed-off-by: Rasmus Villemoes > --- > drivers/gpio/gpio-

[PATCH] gpio-uclass: fix off-by-one in gpio_request_list_by_name_nodev()

2023-04-19 Thread Rasmus Villemoes
By the time we jump to the err label, count represents the number of gpios we've succesfully requested. So by subtracting one, we fail to free the most recently requested. Signed-off-by: Rasmus Villemoes --- drivers/gpio/gpio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -