Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-26 Thread Marek Vasut
On 5/11/20 9:36 PM, Tom Rini wrote: > On Sun, May 10, 2020 at 09:24:19PM +0200, Marek Vasut wrote: >> On 5/8/20 9:21 PM, Tom Rini wrote: >>> On Fri, May 08, 2020 at 09:00:02PM +0200, Marek Vasut wrote: On 5/8/20 8:47 PM, Tom Rini wrote: > On Fri, May 08, 2020 at 03:37:01AM +0200, Marek

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-11 Thread Tom Rini
On Sun, May 10, 2020 at 09:24:19PM +0200, Marek Vasut wrote: > On 5/8/20 9:21 PM, Tom Rini wrote: > > On Fri, May 08, 2020 at 09:00:02PM +0200, Marek Vasut wrote: > >> On 5/8/20 8:47 PM, Tom Rini wrote: > >>> On Fri, May 08, 2020 at 03:37:01AM +0200, Marek Vasut wrote: > On 5/7/20 10:46 PM,

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-10 Thread Marek Vasut
On 5/8/20 9:21 PM, Tom Rini wrote: > On Fri, May 08, 2020 at 09:00:02PM +0200, Marek Vasut wrote: >> On 5/8/20 8:47 PM, Tom Rini wrote: >>> On Fri, May 08, 2020 at 03:37:01AM +0200, Marek Vasut wrote: On 5/7/20 10:46 PM, Samuel Holland wrote: > On 5/6/20 12:02 PM, trini at konsulko.com

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-08 Thread Tom Rini
On Fri, May 08, 2020 at 09:00:02PM +0200, Marek Vasut wrote: > On 5/8/20 8:47 PM, Tom Rini wrote: > > On Fri, May 08, 2020 at 03:37:01AM +0200, Marek Vasut wrote: > >> On 5/7/20 10:46 PM, Samuel Holland wrote: > >>> On 5/6/20 12:02 PM, trini at konsulko.com (Tom Rini) wrote: > I'm not

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-08 Thread Marek Vasut
On 5/8/20 8:47 PM, Tom Rini wrote: > On Fri, May 08, 2020 at 03:37:01AM +0200, Marek Vasut wrote: >> On 5/7/20 10:46 PM, Samuel Holland wrote: >>> On 5/6/20 12:02 PM, trini at konsulko.com (Tom Rini) wrote: I'm not sure that it is. Can we easily/safely memmove the data to be

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-08 Thread Tom Rini
On Fri, May 08, 2020 at 03:37:01AM +0200, Marek Vasut wrote: > On 5/7/20 10:46 PM, Samuel Holland wrote: > > On 5/6/20 12:02 PM, trini at konsulko.com (Tom Rini) wrote: > >> I'm not sure that it is. Can we easily/safely memmove the data to be > >> aligned? Is that really a better option

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-07 Thread Marek Vasut
On 5/7/20 10:46 PM, Samuel Holland wrote: > On 5/6/20 12:02 PM, trini at konsulko.com (Tom Rini) wrote: >> I'm not sure that it is. Can we easily/safely memmove the data to be >> aligned? Is that really a better option in this case than ensuring >> alignment within the file? >

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-07 Thread Samuel Holland
On 5/6/20 12:02 PM, trini at konsulko.com (Tom Rini) wrote: > I'm not sure that it is. Can we easily/safely memmove the data to be > aligned? Is that really a better option in this case than ensuring > alignment within the file? Can't we use the new mkimage -B option to

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Marek Vasut
On 5/6/20 7:02 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 06:35:52PM +0200, Marek Vasut wrote: >> On 5/6/20 6:33 PM, Tom Rini wrote: >>> On Wed, May 06, 2020 at 06:17:47PM +0200, Marek Vasut wrote: On 5/6/20 6:04 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 05:52:45PM +0200, Marek

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Tom Rini
On Wed, May 06, 2020 at 06:35:52PM +0200, Marek Vasut wrote: > On 5/6/20 6:33 PM, Tom Rini wrote: > > On Wed, May 06, 2020 at 06:17:47PM +0200, Marek Vasut wrote: > >> On 5/6/20 6:04 PM, Tom Rini wrote: > >>> On Wed, May 06, 2020 at 05:52:45PM +0200, Marek Vasut wrote: > On 5/6/20 5:43 PM,

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Marek Vasut
On 5/6/20 6:33 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 06:17:47PM +0200, Marek Vasut wrote: >> On 5/6/20 6:04 PM, Tom Rini wrote: >>> On Wed, May 06, 2020 at 05:52:45PM +0200, Marek Vasut wrote: On 5/6/20 5:43 PM, Alex Kiernan wrote: > On Wed, May 6, 2020 at 3:41 PM Marek Vasut

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Tom Rini
On Wed, May 06, 2020 at 06:17:47PM +0200, Marek Vasut wrote: > On 5/6/20 6:04 PM, Tom Rini wrote: > > On Wed, May 06, 2020 at 05:52:45PM +0200, Marek Vasut wrote: > >> On 5/6/20 5:43 PM, Alex Kiernan wrote: > >>> On Wed, May 6, 2020 at 3:41 PM Marek Vasut wrote: > > On 5/6/20 4:37 PM,

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Marek Vasut
On 5/6/20 6:04 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 05:52:45PM +0200, Marek Vasut wrote: >> On 5/6/20 5:43 PM, Alex Kiernan wrote: >>> On Wed, May 6, 2020 at 3:41 PM Marek Vasut wrote: On 5/6/20 4:37 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 04:33:37PM +0200, Marek

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Tom Rini
On Wed, May 06, 2020 at 05:52:45PM +0200, Marek Vasut wrote: > On 5/6/20 5:43 PM, Alex Kiernan wrote: > > On Wed, May 6, 2020 at 3:41 PM Marek Vasut wrote: > >> > >> On 5/6/20 4:37 PM, Tom Rini wrote: > >>> On Wed, May 06, 2020 at 04:33:37PM +0200, Marek Vasut wrote: > On 5/6/20 4:27 PM, Tom

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Marek Vasut
On 5/6/20 5:43 PM, Alex Kiernan wrote: > On Wed, May 6, 2020 at 3:41 PM Marek Vasut wrote: >> >> On 5/6/20 4:37 PM, Tom Rini wrote: >>> On Wed, May 06, 2020 at 04:33:37PM +0200, Marek Vasut wrote: On 5/6/20 4:27 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 04:17:35PM +0200, Marek Vasut

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Alex Kiernan
On Wed, May 6, 2020 at 3:41 PM Marek Vasut wrote: > > On 5/6/20 4:37 PM, Tom Rini wrote: > > On Wed, May 06, 2020 at 04:33:37PM +0200, Marek Vasut wrote: > >> On 5/6/20 4:27 PM, Tom Rini wrote: > >>> On Wed, May 06, 2020 at 04:17:35PM +0200, Marek Vasut wrote: > On 5/6/20 3:48 PM, Tom Rini

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Marek Vasut
On 5/6/20 4:37 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 04:33:37PM +0200, Marek Vasut wrote: >> On 5/6/20 4:27 PM, Tom Rini wrote: >>> On Wed, May 06, 2020 at 04:17:35PM +0200, Marek Vasut wrote: On 5/6/20 3:48 PM, Tom Rini wrote: > On Tue, May 05, 2020 at 11:17:19PM +0200, Michael

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Tom Rini
On Wed, May 06, 2020 at 04:33:37PM +0200, Marek Vasut wrote: > On 5/6/20 4:27 PM, Tom Rini wrote: > > On Wed, May 06, 2020 at 04:17:35PM +0200, Marek Vasut wrote: > >> On 5/6/20 3:48 PM, Tom Rini wrote: > >>> On Tue, May 05, 2020 at 11:17:19PM +0200, Michael Walle wrote: > Hi all, > >

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Marek Vasut
On 5/6/20 4:27 PM, Tom Rini wrote: > On Wed, May 06, 2020 at 04:17:35PM +0200, Marek Vasut wrote: >> On 5/6/20 3:48 PM, Tom Rini wrote: >>> On Tue, May 05, 2020 at 11:17:19PM +0200, Michael Walle wrote: Hi all, Am 2020-05-05 20:41, schrieb Simon Glass: > Hi Tom, > > On

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Tom Rini
On Wed, May 06, 2020 at 04:17:35PM +0200, Marek Vasut wrote: > On 5/6/20 3:48 PM, Tom Rini wrote: > > On Tue, May 05, 2020 at 11:17:19PM +0200, Michael Walle wrote: > >> Hi all, > >> > >> Am 2020-05-05 20:41, schrieb Simon Glass: > >>> Hi Tom, > >>> > >>> On Tue, 5 May 2020 at 11:50, Tom Rini

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Marek Vasut
On 5/6/20 3:48 PM, Tom Rini wrote: > On Tue, May 05, 2020 at 11:17:19PM +0200, Michael Walle wrote: >> Hi all, >> >> Am 2020-05-05 20:41, schrieb Simon Glass: >>> Hi Tom, >>> >>> On Tue, 5 May 2020 at 11:50, Tom Rini wrote: On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote:

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Tom Rini
On Tue, May 05, 2020 at 11:17:19PM +0200, Michael Walle wrote: > Hi all, > > Am 2020-05-05 20:41, schrieb Simon Glass: > > Hi Tom, > > > > On Tue, 5 May 2020 at 11:50, Tom Rini wrote: > > > > > > On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > > > > On 5/5/20 6:37 PM, Alex

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Alex Kiernan
On Tue, May 5, 2020 at 7:41 PM Simon Glass wrote: > > Hi Tom, > > On Tue, 5 May 2020 at 11:50, Tom Rini wrote: > > > > On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > > > On 5/5/20 6:37 PM, Alex Kiernan wrote: > > > > On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: > > > >> > >

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Alex Kiernan
On Tue, May 5, 2020 at 10:17 PM Michael Walle wrote: > > Hi all, > > Am 2020-05-05 20:41, schrieb Simon Glass: > > Hi Tom, > > > > On Tue, 5 May 2020 at 11:50, Tom Rini wrote: > >> > >> On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > >> > On 5/5/20 6:37 PM, Alex Kiernan wrote: >

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-06 Thread Michael Walle
Am 2020-05-05 23:17, schrieb Michael Walle: Hi all, Am 2020-05-05 20:41, schrieb Simon Glass: Hi Tom, On Tue, 5 May 2020 at 11:50, Tom Rini wrote: On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > On 5/5/20 6:37 PM, Alex Kiernan wrote: > > On Tue, May 5, 2020 at 2:28 PM Marek

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Michael Walle
Hi all, Am 2020-05-05 20:41, schrieb Simon Glass: Hi Tom, On Tue, 5 May 2020 at 11:50, Tom Rini wrote: On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > On 5/5/20 6:37 PM, Alex Kiernan wrote: > > On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: > >> > >> On 5/5/20 3:22 PM,

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Simon Glass
Hi Tom, On Tue, 5 May 2020 at 11:50, Tom Rini wrote: > > On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > > On 5/5/20 6:37 PM, Alex Kiernan wrote: > > > On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: > > >> > > >> On 5/5/20 3:22 PM, Alex Kiernan wrote: > > >>> On Mon, May 4,

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Marek Vasut
On 5/5/20 8:06 PM, Tom Rini wrote: > On Tue, May 05, 2020 at 07:59:24PM +0200, Marek Vasut wrote: >> On 5/5/20 7:55 PM, Tom Rini wrote: >>> On Tue, May 05, 2020 at 07:53:42PM +0200, Marek Vasut wrote: On 5/5/20 7:50 PM, Tom Rini wrote: > On Tue, May 05, 2020 at 06:39:58PM +0200, Marek

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Tom Rini
On Tue, May 05, 2020 at 07:59:24PM +0200, Marek Vasut wrote: > On 5/5/20 7:55 PM, Tom Rini wrote: > > On Tue, May 05, 2020 at 07:53:42PM +0200, Marek Vasut wrote: > >> On 5/5/20 7:50 PM, Tom Rini wrote: > >>> On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > On 5/5/20 6:37 PM,

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Marek Vasut
On 5/5/20 7:55 PM, Tom Rini wrote: > On Tue, May 05, 2020 at 07:53:42PM +0200, Marek Vasut wrote: >> On 5/5/20 7:50 PM, Tom Rini wrote: >>> On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: On 5/5/20 6:37 PM, Alex Kiernan wrote: > On Tue, May 5, 2020 at 2:28 PM Marek Vasut

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Tom Rini
On Tue, May 05, 2020 at 07:53:42PM +0200, Marek Vasut wrote: > On 5/5/20 7:50 PM, Tom Rini wrote: > > On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > >> On 5/5/20 6:37 PM, Alex Kiernan wrote: > >>> On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: > > On 5/5/20 3:22 PM,

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Marek Vasut
On 5/5/20 7:50 PM, Tom Rini wrote: > On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: >> On 5/5/20 6:37 PM, Alex Kiernan wrote: >>> On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: On 5/5/20 3:22 PM, Alex Kiernan wrote: > On Mon, May 4, 2020 at 12:28 PM Tom Rini wrote:

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Tom Rini
On Tue, May 05, 2020 at 06:39:58PM +0200, Marek Vasut wrote: > On 5/5/20 6:37 PM, Alex Kiernan wrote: > > On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: > >> > >> On 5/5/20 3:22 PM, Alex Kiernan wrote: > >>> On Mon, May 4, 2020 at 12:28 PM Tom Rini wrote: > > On Fri, May 01, 2020 at

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Marek Vasut
On 5/5/20 6:37 PM, Alex Kiernan wrote: > On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: >> >> On 5/5/20 3:22 PM, Alex Kiernan wrote: >>> On Mon, May 4, 2020 at 12:28 PM Tom Rini wrote: On Fri, May 01, 2020 at 05:40:25PM +0200, Marek Vasut wrote: > There is no reason to

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Alex Kiernan
On Tue, May 5, 2020 at 2:28 PM Marek Vasut wrote: > > On 5/5/20 3:22 PM, Alex Kiernan wrote: > > On Mon, May 4, 2020 at 12:28 PM Tom Rini wrote: > >> > >> On Fri, May 01, 2020 at 05:40:25PM +0200, Marek Vasut wrote: > >> > >>> There is no reason to tail-pad fitImage with external data to

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Marek Vasut
On 5/5/20 3:22 PM, Alex Kiernan wrote: > On Mon, May 4, 2020 at 12:28 PM Tom Rini wrote: >> >> On Fri, May 01, 2020 at 05:40:25PM +0200, Marek Vasut wrote: >> >>> There is no reason to tail-pad fitImage with external data to 4-bytes, >>> while fitImage without external data does not have any such

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-05 Thread Alex Kiernan
On Mon, May 4, 2020 at 12:28 PM Tom Rini wrote: > > On Fri, May 01, 2020 at 05:40:25PM +0200, Marek Vasut wrote: > > > There is no reason to tail-pad fitImage with external data to 4-bytes, > > while fitImage without external data does not have any such padding and > > is often unaligned. DT spec

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-04 Thread Tom Rini
On Fri, May 01, 2020 at 05:40:25PM +0200, Marek Vasut wrote: > There is no reason to tail-pad fitImage with external data to 4-bytes, > while fitImage without external data does not have any such padding and > is often unaligned. DT spec also does not mandate any such padding. > > Moreover, the

Re: [PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-02 Thread Simon Glass
On Fri, 1 May 2020 at 09:40, Marek Vasut wrote: > > There is no reason to tail-pad fitImage with external data to 4-bytes, > while fitImage without external data does not have any such padding and > is often unaligned. DT spec also does not mandate any such padding. > > Moreover, the tail-pad

[PATCH V2] mkimage: fit: Do not tail-pad fitImage with external data

2020-05-01 Thread Marek Vasut
There is no reason to tail-pad fitImage with external data to 4-bytes, while fitImage without external data does not have any such padding and is often unaligned. DT spec also does not mandate any such padding. Moreover, the tail-pad fills the last few bytes with uninitialized data, which could