Hi Quentin,
Thanks for your response.
As for the CONFIG_TPL_SERIAL flag, I agree that it should use 'imply'
to be allowed to disable it, to silence the serial in TPL. However,
currently, disabling this flag makes the code unbuildable (which could
be the reason 'select' is used). I'd keep this
Hi Lukasz,
I would have renamed the commit title to be something like
rockchip: px30-board-tpl: sync ifdef guards with full TPL
because CONFIG_TPL_BANNER_PRINT isn't really a flag but a Kconfig symbol
and the effect of this patch is to not print the banner when the symbol
is not selected.
From: Lukasz Czechowski
Display TPL init information message only when TPL_BANNER_PRINT
configuration entry is set. This allows to disable information
message in case logs on UART are unwanted.
Update parent ifdef condition to check also CONFIG_TPL_SERIAL
to match logic of the non-PX30 TPL
3 matches
Mail list logo
