Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Heinrich Schuchardt
On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote: > On 03/18/2018 01:27 PM, Marek Vasut wrote: >> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >>> Assigning a value to ret if it is immediately overwritten does not make >>> sense. >>> >>> Signed-off-by: Heinrich Schuchardt

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Marek Vasut
On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote: > On 03/18/2018 01:27 PM, Marek Vasut wrote: >> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >>> Assigning a value to ret if it is immediately overwritten does not make >>> sense. >>> >>> Signed-off-by: Heinrich Schuchardt

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Heinrich Schuchardt
On 03/18/2018 01:27 PM, Marek Vasut wrote: > On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: >> Assigning a value to ret if it is immediately overwritten does not make >> sense. >> >> Signed-off-by: Heinrich Schuchardt > > Did you even compile-test this ? I have a feeling

Re: [U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Marek Vasut
On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote: > Assigning a value to ret if it is immediately overwritten does not make > sense. > > Signed-off-by: Heinrich Schuchardt Did you even compile-test this ? I have a feeling this file is not used at all, so maybe we should

[U-Boot] [PATCH 1/1] usb: ehci-farady: remove redundant assignment

2018-03-18 Thread Heinrich Schuchardt
Assigning a value to ret if it is immediately overwritten does not make sense. Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/ehci-faraday.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-faraday.c