Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-05-04 Thread Stefan Roese
On 03.05.2016 19:18, Marek Vasut wrote: On 05/03/2016 07:00 PM, Stefan Roese wrote: On 03.05.2016 18:53, Marek Vasut wrote: On 05/02/2016 05:20 PM, Stefan Roese wrote: On 29.04.2016 12:13, Marek Vasut wrote: On 28.04.2016 00:36, Marek Vasut wrote: The indirect write code is buggy pile of

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-05-03 Thread Marek Vasut
On 05/03/2016 07:00 PM, Stefan Roese wrote: > On 03.05.2016 18:53, Marek Vasut wrote: >> On 05/02/2016 05:20 PM, Stefan Roese wrote: >>> On 29.04.2016 12:13, Marek Vasut wrote: > On 28.04.2016 00:36, Marek Vasut wrote: >> The indirect write code is buggy pile of nastiness which fails

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-05-03 Thread Stefan Roese
On 03.05.2016 18:53, Marek Vasut wrote: On 05/02/2016 05:20 PM, Stefan Roese wrote: On 29.04.2016 12:13, Marek Vasut wrote: On 28.04.2016 00:36, Marek Vasut wrote: The indirect write code is buggy pile of nastiness which fails horribly when the system runs fast enough to saturate the

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-05-03 Thread Marek Vasut
On 05/02/2016 05:20 PM, Stefan Roese wrote: > On 29.04.2016 12:13, Marek Vasut wrote: >>> On 28.04.2016 00:36, Marek Vasut wrote: The indirect write code is buggy pile of nastiness which fails horribly when the system runs fast enough to saturate the controller. The failure results

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-05-03 Thread Marek Vasut
On 05/03/2016 12:42 PM, Pavel Machek wrote: > Hi! > >> This patch replaces the whole unmaintainable indirect write implementation >> with the one from upcoming Linux CQSPI driver, which went through multiple >> rounds of thorough review and testing. While this makes the patch look >> terrifying

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-05-03 Thread Pavel Machek
Hi! > This patch replaces the whole unmaintainable indirect write implementation > with the one from upcoming Linux CQSPI driver, which went through multiple > rounds of thorough review and testing. While this makes the patch look > terrifying and violates all best-practices of software

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-05-02 Thread Stefan Roese
On 29.04.2016 12:13, Marek Vasut wrote: >> On 28.04.2016 00:36, Marek Vasut wrote: >>> The indirect write code is buggy pile of nastiness which fails horribly >>> when the system runs fast enough to saturate the controller. The failure >>> results in some pages (256B) not being written to the

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-04-29 Thread Marek Vasut
On 04/29/2016 11:35 AM, Stefan Roese wrote: > Hi Marek, > > On 28.04.2016 00:36, Marek Vasut wrote: >> The indirect write code is buggy pile of nastiness which fails horribly >> when the system runs fast enough to saturate the controller. The failure >> results in some pages (256B) not being

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-04-29 Thread Stefan Roese
Hi Marek, On 28.04.2016 00:36, Marek Vasut wrote: > The indirect write code is buggy pile of nastiness which fails horribly > when the system runs fast enough to saturate the controller. The failure > results in some pages (256B) not being written to the flash. This can be > observed on systems

Re: [U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-04-29 Thread Vignesh R
On 04/28/2016 04:06 AM, Marek Vasut wrote: > The indirect write code is buggy pile of nastiness which fails horribly > when the system runs fast enough to saturate the controller. The failure > results in some pages (256B) not being written to the flash. This can be > observed on systems which

[U-Boot] [PATCH 1/2] mtd: cqspi: Simplify indirect write code

2016-04-27 Thread Marek Vasut
The indirect write code is buggy pile of nastiness which fails horribly when the system runs fast enough to saturate the controller. The failure results in some pages (256B) not being written to the flash. This can be observed on systems which run with Dcache enabled and L2 cache enabled, like the