Re: [U-Boot] [PATCH 6/9] phy: atheros: fix delay configuration

2019-11-29 Thread Joe Hershberger
On Fri, Oct 25, 2019 at 7:30 PM Michael Walle wrote: > > The delay_config() code could only set the delay bit. Thus, it could > only enable the delay mode, but not disable it. To make things worse, > the RX delay mode is enabled by default after a hardware reset, so it > could never be disabled.

Re: [U-Boot] [PATCH 6/9] phy: atheros: fix delay configuration

2019-10-28 Thread Vladimir Oltean
On Sat, 26 Oct 2019 at 03:31, Michael Walle wrote: > > The delay_config() code could only set the delay bit. Thus, it could > only enable the delay mode, but not disable it. To make things worse, > the RX delay mode is enabled by default after a hardware reset, so it > could never be disabled.

[U-Boot] [PATCH 6/9] phy: atheros: fix delay configuration

2019-10-25 Thread Michael Walle
The delay_config() code could only set the delay bit. Thus, it could only enable the delay mode, but not disable it. To make things worse, the RX delay mode is enabled by default after a hardware reset, so it could never be disabled. Fix this, by always setting or clearing the bits. This is also