Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Ley Foon Tan
On Thu, Oct 10, 2019 at 6:09 PM Marek Vasut wrote: > > On 10/10/19 12:00 PM, Anatolij Gustschin wrote: > > On Thu, 10 Oct 2019 11:39:13 +0200 > > Marek Vasut wrote: > > ... > >>> The preferred way for I/O access is documented in [1], see "Use structures > >>> for I/O access" section. > >> > >>

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Marek Vasut
On 10/10/19 12:00 PM, Anatolij Gustschin wrote: > On Thu, 10 Oct 2019 11:39:13 +0200 > Marek Vasut wrote: > ... >>> The preferred way for I/O access is documented in [1], see "Use structures >>> for I/O access" section. >> >> This seems to not scale and I keep running into the problem where a

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Anatolij Gustschin
On Thu, 10 Oct 2019 11:39:13 +0200 Marek Vasut ma...@denx.de wrote: ... > > The preferred way for I/O access is documented in [1], see "Use structures > > for I/O access" section. > > This seems to not scale and I keep running into the problem where a few > registers changed between various

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Simon Goldschmidt
On Thu, Oct 10, 2019 at 11:29 AM Anatolij Gustschin wrote: > > On Thu, 10 Oct 2019 10:43:46 +0200 > Simon Goldschmidt simon.k.r.goldschm...@gmail.com wrote: > ... > > > Why is this required? In the past we have rejected all new code adding > > > defines instead of structs for register accesses.

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Marek Vasut
On 10/10/19 11:29 AM, Anatolij Gustschin wrote: > On Thu, 10 Oct 2019 10:43:46 +0200 > Simon Goldschmidt simon.k.r.goldschm...@gmail.com wrote: > ... >>> Why is this required? In the past we have rejected all new code adding >>> defines instead of structs for register accesses. Have we changed our

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Anatolij Gustschin
On Thu, 10 Oct 2019 10:43:46 +0200 Simon Goldschmidt simon.k.r.goldschm...@gmail.com wrote: ... > > Why is this required? In the past we have rejected all new code adding > > defines instead of structs for register accesses. Have we changed our mind > > now? > > Who is we? U-Boot

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Simon Goldschmidt
On Thu, Oct 10, 2019 at 10:09 AM Anatolij Gustschin wrote: > > On Thu, 10 Oct 2019 09:16:14 +0200 > Simon Goldschmidt simon.k.r.goldschm...@gmail.com wrote: > > > On Thu, Oct 10, 2019 at 8:20 AM Ley Foon Tan wrote: > > > > > > Convert system manager for Gen5, Arria 10 and Stratix 10 from struct

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Anatolij Gustschin
On Thu, 10 Oct 2019 09:16:14 +0200 Simon Goldschmidt simon.k.r.goldschm...@gmail.com wrote: > On Thu, Oct 10, 2019 at 8:20 AM Ley Foon Tan wrote: > > > > Convert system manager for Gen5, Arria 10 and Stratix 10 from struct > > to defines. > > Same as 2/4: please add a description about the

Re: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Simon Goldschmidt
On Thu, Oct 10, 2019 at 8:20 AM Ley Foon Tan wrote: > > Convert system manager for Gen5, Arria 10 and Stratix 10 from struct > to defines. Same as 2/4: please add a description about the "read address from dts" thing. Regards, Simon > > Signed-off-by: Ley Foon Tan > > --- > v3: > - Remove "No

[U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines

2019-10-10 Thread Ley Foon Tan
Convert system manager for Gen5, Arria 10 and Stratix 10 from struct to defines. Signed-off-by: Ley Foon Tan --- v3: - Remove "No functional change" in commit description. v2: - Revert to use writel(), readl() and etc. - Get base address from DT. - Add prefix to defines. ---