Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env

2024-01-11 Thread Lukasz Majewski
Hi Fabio, > Hi Fabio, > > > On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam > > wrote: > > > > > > Hi Lukasz, > > > > > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski > > > wrote: > > > > +serverip=10.8.217.79 > > > > +nfs_serverip=10.8.218.113 > > > > +gatewayip=10.8.209.250 > > > >

Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env

2024-01-11 Thread Lukasz Majewski
Hi Fabio, > On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam > wrote: > > > > Hi Lukasz, > > > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski > > wrote: > > > +serverip=10.8.217.79 > > > +nfs_serverip=10.8.218.113 > > > +gatewayip=10.8.209.250 > > > > These IP addresses should not be

Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env

2024-01-11 Thread Lukasz Majewski
Hi Fabio, > Hi Lukasz, > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski wrote: > > > +serverip=10.8.217.79 > > +nfs_serverip=10.8.218.113 > > +gatewayip=10.8.209.250 > > These IP addresses should not be hardcoded here. > > They were not present in xea.h originally. Please remove them.

Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env

2024-01-11 Thread Fabio Estevam
On Thu, Jan 11, 2024 at 8:16 AM Fabio Estevam wrote: > > Hi Lukasz, > > On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski wrote: > > > +serverip=10.8.217.79 > > +nfs_serverip=10.8.218.113 > > +gatewayip=10.8.209.250 > > These IP addresses should not be hardcoded here. > > They were not present in

Re: [PATCH v2 1/3] arm: xea: Move XEA's environment variables from xea.h to xea.env

2024-01-11 Thread Fabio Estevam
Hi Lukasz, On Thu, Jan 11, 2024 at 8:06 AM Lukasz Majewski wrote: > +serverip=10.8.217.79 > +nfs_serverip=10.8.218.113 > +gatewayip=10.8.209.250 These IP addresses should not be hardcoded here. They were not present in xea.h originally. Please remove them.