Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Kever, > On 13 Apr 2018, at 09:51, Kever Yang wrote: > On 04/08/2018 09:45 AM, Kever Yang wrote: > +__weak int arch_cpu_init(void) +{ +return 0; +} + +__weak int rk_board_init_f(void) +{ +return 0; +} >>> This

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

On Fri, Apr 13, 2018 at 03:51:07PM +0800, Kever Yang wrote: > Hi Philipp, > > > On 04/08/2018 09:45 AM, Kever Yang wrote: > >>> +__weak int arch_cpu_init(void) > >>> +{ > >>> +    return 0; > >>> +} > >>> + > >>> +__weak int rk_board_init_f(void) > >>> +{ > >>> +    return 0; > >>> +} > >> This

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Hi Philipp, On 04/08/2018 09:45 AM, Kever Yang wrote: >>> +__weak int arch_cpu_init(void) >>> +{ >>> +    return 0; >>> +} >>> + >>> +__weak int rk_board_init_f(void) >>> +{ >>> +    return 0; >>> +} >> This doesn't really help in modularising our board-support and I am >> not a fan of adding

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

> On 10 Apr 2018, at 14:32, Tom Rini wrote: > > On Tue, Apr 10, 2018 at 02:54:09PM +0800, Kever Yang wrote: >> Hi Tom, >> >> >> On 04/09/2018 06:35 AM, Tom Rini wrote: I have do a lot of test and re-work in my local branch and at last make it landed in

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

On Tue, Apr 10, 2018 at 02:54:09PM +0800, Kever Yang wrote: > Hi Tom, > > > On 04/09/2018 06:35 AM, Tom Rini wrote: > >> I have do a lot of test and re-work in my local branch and at last make > >> it landed in > >> rockchip vendor U-Boot, with testing in most of SoCs(not including > >>

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Hi Tom, On 04/09/2018 06:35 AM, Tom Rini wrote: >> I have do a lot of test and re-work in my local branch and at last make >> it landed in >> rockchip vendor U-Boot, with testing in most of SoCs(not including >> rk3066/rk3188). >> Well, I do try to split it into pieces, but I found that actually

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Kever, > On 8 Apr 2018, at 03:45, Kever Yang wrote: > > Philipp, > > > On 04/02/2018 05:28 AM, Philipp Tomsich wrote: >> >> >> On Tue, 27 Mar 2018, Kever Yang wrote: >> >>> We use common board/spl/tpl file for all rockchip SoCs, >>> - all the SoC spec setting

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Kever, > On 9 Apr 2018, at 00:35, Tom Rini wrote: > > On Sun, Apr 08, 2018 at 09:45:22AM +0800, Kever Yang wrote: >> Philipp, >> >> >> On 04/02/2018 05:28 AM, Philipp Tomsich wrote: >>> >>> >>> On Tue, 27 Mar 2018, Kever Yang wrote: >>> We use common board/spl/tpl

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

On Sun, Apr 08, 2018 at 09:45:22AM +0800, Kever Yang wrote: > Philipp, > > > On 04/02/2018 05:28 AM, Philipp Tomsich wrote: > > > > > > On Tue, 27 Mar 2018, Kever Yang wrote: > > > >> We use common board/spl/tpl file for all rockchip SoCs, > >> - all the SoC spec setting should move into SoC

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Philipp, On 04/02/2018 05:28 AM, Philipp Tomsich wrote: > > > On Tue, 27 Mar 2018, Kever Yang wrote: > >> We use common board/spl/tpl file for all rockchip SoCs, >> - all the SoC spec setting should move into SoC file like rk3288.c; >> - tpl is option and only purpose to init DRAM, clock,

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

On Tue, 27 Mar 2018, Kever Yang wrote: We use common board/spl/tpl file for all rockchip SoCs, - all the SoC spec setting should move into SoC file like rk3288.c; - tpl is option and only purpose to init DRAM, clock, uart(option); - spl do secure relate one time init, boot device select, boot

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

> We use common board/spl/tpl file for all rockchip SoCs, > - all the SoC spec setting should move into SoC file like rk3288.c; > - tpl is option and only purpose to init DRAM, clock, uart(option); > - spl do secure relate one time init, boot device select, boot into > U-Boot or trust or OS in