Re: [PATCH v2 1/2] net: cortina_ni: Addd eth support for Cortina Access CAxxxx SoCs

On Wed, Apr 29, 2020 at 05:07:29PM -0700, Alex Nemirovsky wrote: Now, > From: Aaron Tseng > > Add Cortina Access Ethernet device driver for CA SoCs. > This driver supports both legacy and DM_ETH network models. > > Signed-off-by: Aaron Tseng > Signed-off-by: Alex Nemirovsky >

[PATCH 2/2] board: kontron: add sl28 support

Add basic support for the Kontron SMARC-sAL28 board. This includes just the bare minimum to be able to bring up the board and boot linux. Also only one board variant is supported for now. That is the Single PHY variant. Other variants will fall back to this one. In particular, there is no

[PATCH 1/2] armv8: ls1028a: move FSL_LAYERSCAPE to kconfig

CONFIG_FSL_LAYERSCAPE is available in kconfig. There is no need to define it per board; the ls1028a_common.h is really board dependent and only fits to the NXP eval boards. Instead select CONFIG_FSL_LAYERSCAPE when ARCH_LS1028A is selected. Signed-off-by: Michael Walle ---

[PATCH 2/6] efi_loader: Add headers for EDK2 StandAloneMM communication

From: Sughosh Ganu In Arm devices OP-TEE has the ability to run StandAloneMM (from EDK2) in a separate partition and handle UEFI variables. A following patch introduces this functionality. Add the headers needed for OP-TEE <--> StandAloneMM communication Signed-off-by: Sughosh Ganu

[PATCH 3/6] efi_loader: Implement EFI variable handling via OP-TEE

In OP-TEE we can run EDK2's StandAloneMM on a secure partition. StandAloneMM is responsible for the UEFI variable support. In combination with OP-TEE and it's U-Boot supplicant, variables are authenticated/validated in secure world and stored on an RPMB partition. So let's add a new config option

[PATCH 6/6] doc: uefi.rst: Add OP-TEE variable storage config options

If OP-TEE is compiled with an EDK2 application running in secure world it can process and store UEFI variables in an RPMB. Add documentation for the config options enabling this Signed-off-by: Ilias Apalodimas --- doc/uefi/uefi.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH 0/6] EFI variable support via OP-TEE

With new OP-TEE and EDK2 patches (not yet upstreamed [1][2]) we can run a secure world application which manages UEFI variables. Leveraging the U-Boot's OP-TEE supplicant we can then store those values in an RPMB device. The Secure World application responsible for doing that is coming from

[PATCH 1/6] charset: Add support for calculating bytes occupied by a u16 string

From: Sughosh Ganu The current code uses 'u16_strlen(x) + 1) * sizeof(u16)' in various places to calculate the number of bytes occupied by a u16 string. Let's introduce a wrapper around this. This wrapper is used on following patches Signed-off-by: Sughosh Ganu --- include/charset.h | 11

[PATCH 5/6] MAINTAINERS: Add maintainer for EFI variables via OP-TEE

Add myself as maintainer for the OP-TEE related UEFI variable storage and add the headers files on the existing EFI list Signed-off-by: Ilias Apalodimas --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ec59ce8b8802..f33fd74b330b 100644

[PATCH 4/6] cmd: efidebug: Add support for querying UEFI variable storage

With the previous patches that use OP-TEE and StandAloneMM for UEFI variable storage we've added functionality for efi_query_variable_info. So let's add the relevant command to efidebug and retrieve information about the container used to store UEFI variables Signed-off-by: Ilias Apalodimas ---

Re: [PATCH v3 00/12] phy: atheros: dt bindings and cleanup

Am 2020-05-06 21:14, schrieb Michael Walle: This patch series superseeds the following two: From Vladimir Oltean https://patchwork.ozlabs.org/cover/1031360/ From me: https://patchwork.ozlabs.org/cover/1184507/ Although the first is marked as accepted into u-boot-net I guess it was removed

Re: [PATCH] lib: rsa: Fix unaligned 64-bit fdt accesses

On Wed, May 06, 2020 at 06:32:03PM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > The fdt only provides 32-bit alignment of data. If the public_exponent > happens to be not 64-bit aligned, we can trigger an exception on certain > architectures. Seen on TI AM64x. > > Note that the normal way

[PATCH 1/1] efi_loader: put device tree into EfiACPIReclaimMemory

According to the UEFI spec ACPI tables should be placed in EfiACPIReclaimMemory. Let's do the same with the device tree. Suggested-by: Ard Biesheuvel Cc: Grant Likely Signed-off-by: Heinrich Schuchardt --- cmd/bootefi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 11/12] phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver. If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY.

[PATCH v3 08/12] phy: atheros: introduce debug read and write functions

Provide functions to read and write the Atheros debug registers. Signed-off-by: Michael Walle --- drivers/net/phy/atheros.c | 57 --- 1 file changed, 41 insertions(+), 16 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index

[PATCH v2 2/2] board: kontron: add sl28 support

Add basic support for the Kontron SMARC-sAL28 board. This includes just the bare minimum to be able to bring up the board and boot linux. Also only one board variant is supported for now. That is the Single PHY variant. Other variants will fall back to this one. In particular, there is no

[PATCH v2 1/2] armv8: ls1028a: move FSL_LAYERSCAPE to kconfig

CONFIG_FSL_LAYERSCAPE is available in kconfig. There is no need to define it per board; the ls1028a_common.h is really board dependent and only fits to the NXP eval boards. Instead select CONFIG_FSL_LAYERSCAPE when ARCH_LS1028A is selected. Signed-off-by: Michael Walle --- changes since v1:

Re: [PATCH v3 00/12] phy: atheros: dt bindings and cleanup

On Wed, May 06, 2020 at 09:47:10PM +0200, Michael Walle wrote: > Am 2020-05-06 21:14, schrieb Michael Walle: > > This patch series superseeds the following two: > > From Vladimir Oltean > > https://patchwork.ozlabs.org/cover/1031360/ > > From me: > > https://patchwork.ozlabs.org/cover/1184507/

Re: [PATCH 32/36] bdinfo: m68k: Move m68k-specific info into its own file

On Tue, May 5, 2020 at 1:19 AM Simon Glass wrote: > > We don't really want to have m68k-specific code in a generic file. Create > a new arch-specific function to hold it, and move it into that. > > Make the function weak so that any arch can implement it. > > Signed-off-by: Simon Glass > --- > >

[PATCH v3 01/12] phy: atheros: Make RGMII Tx delays actually configurable for AR8035

From: Vladimir Oltean Delete the extraneous write to debug reg 5 that enables Tx delay When the driver was originally introduced in commit "6027384a phylib: Add Atheros AR8035 GETH PHY support", the Tx delay was being unconditionally enabled. Then during "2ec4d10b phy: atheros: add support for

[PATCH v3 03/12] phy: atheros: Clarify the configuration of the CLK_25M output pin

From: Vladimir Oltean Also take the opportunity to use the phy_read_mmd and phy_write_mmd convenience functions. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git

[PATCH v3 10/12] phy: atheros: add device tree bindings and config

Add support for configuring the CLK_25M pin as well as the RGMII I/O voltage by the device tree. By default the AT803x PHYs outputs the 25MHz clock of the XTAL input. But this output can also be changed by software to other frequencies. This commit introduces a generic way to configure this

[PATCH v3 00/12] phy: atheros: dt bindings and cleanup

This patch series superseeds the following two: >From Vladimir Oltean https://patchwork.ozlabs.org/cover/1031360/ >From me: https://patchwork.ozlabs.org/cover/1184507/ Although the first is marked as accepted into u-boot-net I guess it was removed due to broken boards ("DT as ABI", RGMII

[PATCH v3 06/12] phy: atheros: fix AR8021 PHY ID mask

The upper bits are all the OUI. Signed-off-by: Michael Walle --- drivers/net/phy/atheros.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 3cc162828c..01953a1390 100644 --- a/drivers/net/phy/atheros.c +++

[PATCH v3 02/12] phy: atheros: Use common functions for RGMII internal delays

From: Vladimir Oltean Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 69 +++ 1 file changed, 41 insertions(+), 28 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index

[PATCH v3 04/12] phy: atheros: Explicitly disable RGMII delays

From: Vladimir Oltean To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on. If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the PHY_INTERFACE_MODE_RGMII_RXID or

[PATCH v3 05/12] phy: atheros: Clarify the intention of ar8021_config

From: Vladimir Oltean Debug register 5 contains TX_CLK DELAY at bit 8 and reserved values at the other bit positions, just like the other PHYs in the family do. Therefore, it is not necessary to hardcode the reserved values, but instead simply follow the read-modify-write procedure from the

[PATCH v3 12/12] phy: atheros: consolidate {ar8031|ar8035}_config()

The two functions are now exactly the same, remove one of them. Signed-off-by: Michael Walle --- drivers/net/phy/atheros.c | 30 +++--- 1 file changed, 3 insertions(+), 27 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index

[PATCH v3 07/12] phy: atheros: use defines for PHY IDs

Signed-off-by: Michael Walle --- drivers/net/phy/atheros.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 01953a1390..5ff5875d3d 100644 --- a/drivers/net/phy/atheros.c +++ b/drivers/net/phy/atheros.c @@

[PATCH v3 09/12] phy: atheros: move delay config to common function

Signed-off-by: Michael Walle --- drivers/net/phy/atheros.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 660dcd9491..22035c2496 100644 --- a/drivers/net/phy/atheros.c +++

Re: [PATCH 1/2] JFFS2: Process obsolete nodes as well as accurate ones

On Mon, Apr 27, 2020 at 06:43:25PM +0200, petr.bors...@i.cz wrote: > From: Petr Borsodi > > Obsolete nodes (ie. without the JFFS2_NODE_ACCURATE flag) were ignored because > they had seemingly invalid crc. This could lead to finding the phantom node > header in obsolete node data. > >

Re: raspberrypi cm3 v2019.07 not working

On Tue, May 5, 2020 at 10:18 PM Belisko Marek wrote: > > Hi, > > I'm trying to run 2019.07 u-boot on raspberrypi cm3 module but I got > no feedback on console. When used 2018.01 it boots fine. Probably I > need to do git bisect but maybe someone have some idea or experience > what can cause that.

efi_loader: pkcs7_parse_message() returns error pointer

Since pkcs7_parse_message() returns an error pointer, we must not check for NULL. We have to explicitly set msg to NULL in the error case, otherwise the call to pkcs7_free_message() on the goto err path will assume it's a valid object. Signed-off-by: Patrick Wildt diff --git

TPM: remove duplicate definitions

With the recent change to tpm-v2.h, some enums are now defined twice and tpm2_tis_spi.c fails to build. Unfortunately I fear removing the defines from tpm_tis.h, like in this diff, will break the TPMv1 drivers tpm_tis_infineon.c and pm_tis_st33zp24_i2c.c, which depend on those defines. Maybe

Re: [PATCH 04/10] efi_loader: capsule: add capsule_on_disk support

On Thu, Apr 30, 2020 at 09:51:51PM +0200, Heinrich Schuchardt wrote: > On 4/30/20 2:52 PM, Sughosh Ganu wrote: > > > > On Tue, 28 Apr 2020 at 05:58, AKASHI Takahiro > > mailto:takahiro.aka...@linaro.org>> wrote: > > > > Heinrich, > > > > On Mon, Apr 27, 2020 at 10:28:35PM +0200, Heinrich

[PATCH 0/6] patman: Fixes to allow patman to work with Zephyr OS

At present patman doesn't correctly parse the output of checkpatch if the --emacs and --show-types options are given in the .checkpatch.conf file. This series corrects these problems, allowing patman to be used to check patches intended for Zephyr OS. Simon Glass (6): patman: Fix 'warning'

RE: [PATCH 10/13] imx: load calibration parameters from fuse for i.MX8MP

> Subject: Re: [PATCH 10/13] imx: load calibration parameters from fuse for > i.MX8MP > > Hi Peng, > > On Mon, May 4, 2020 at 11:50 PM Peng Fan wrote: > > > Busfreq could be disabled by set the device tree node to disabled. > > This does not help. If I use the NXP U-Boot I can boot the NXP

[PATCH 2/6] patman: Support emacs mode with checkpatch

If checkpatch is run in 'emacs' mode it shows the filename at the start of each line. Add support for this so that the warnings and errors are correctly detected. Signed-off-by: Simon Glass --- tools/patman/checkpatch.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[PATCH 1/6] patman: Fix 'warning' typo

If no warnings are detected due to checkpatch having unexpected options, patman currently shows an error: TypeError: unsupported operand type(s) for +=: 'int' and 'property' Fix this by initing the variable correctly. Signed-off-by: Simon Glass --- tools/patman/checkpatch.py | 2 +- 1

[PATCH 6/6] patman: Complain if a checkpatch line is not understood

Rather than suffering in silence, output a warning if something about the checkpatch output cannot be understood. Signed-off-by: Simon Glass --- tools/patman/checkpatch.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/patman/checkpatch.py b/tools/patman/checkpatch.py index

[PATCH 4/6] patman: Handle checkpatch output with notes and code

If checkpatch is configured to output code we should ignore it. Similarly, notes should be ignored. Update the logic to handle these situations. Signed-off-by: Simon Glass --- tools/patman/checkpatch.py | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH 3/6] patman: Don't try to process checkpatch lines twice

Once we have determined what the line refers to there is no point in processing it further. Update the logic to continue to the next line in these cases. Signed-off-by: Simon Glass --- tools/patman/checkpatch.py | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 5/6] patman: Support warnings in the patch subject

Sometimes checkpatch outputs problems in the patch subject. Add support for parsing this output and reporting it correctly. Signed-off-by: Simon Glass --- tools/patman/checkpatch.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/patman/checkpatch.py

Re: [PATCH v4 4/4] patman: Modify functional tests for new behavior

On Mon, 4 May 2020 at 14:29, Sean Anderson wrote: > > This patch adds or modifies functional tests for the Cover-changes, > Commit-changes, and Series-process-log tags in order to account for new > behavior added in the previous few patches. The '(no changes since v1)' > case is not tested for,

Re: [PATCH 08/10] cmd: add "efidebug capsule" command

On Thu, Apr 30, 2020 at 06:08:11PM +0530, Sughosh Ganu wrote: > On Mon, 27 Apr 2020 at 15:19, AKASHI Takahiro > wrote: > > > "efidebug capsule" is more or less a debugging utility. > > efidebug capsule update: invoke UpdateCapsule against data on memory > > efidebug capsule show: show a

[PATCH v4 02/12] phy: atheros: Use common functions for RGMII internal delays

From: Vladimir Oltean Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 69 +++ 1 file changed, 41 insertions(+), 28 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index

[PATCH v4 01/12] phy: atheros: Make RGMII Tx delays actually configurable for AR8035

From: Vladimir Oltean Delete the extraneous write to debug reg 5 that enables Tx delay When the driver was originally introduced in commit "6027384a phylib: Add Atheros AR8035 GETH PHY support", the Tx delay was being unconditionally enabled. Then during "2ec4d10b phy: atheros: add support for

[PATCH v4 03/12] phy: atheros: Clarify the configuration of the CLK_25M output pin

From: Vladimir Oltean Also take the opportunity to use the phy_read_mmd and phy_write_mmd convenience functions. Signed-off-by: Vladimir Oltean Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git

[PATCH v4 00/12] phy: atheros: dt bindings and cleanup

This patch series superseeds the following two: >From Vladimir Oltean https://patchwork.ozlabs.org/cover/1031360/ >From me: https://patchwork.ozlabs.org/cover/1184507/ Although the first is marked as accepted into u-boot-net I guess it was removed due to broken boards ("DT as ABI", RGMII

[PATCH v4 09/12] phy: atheros: move delay config to common function

Signed-off-by: Michael Walle Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 660dcd9491..22035c2496 100644 ---

[PATCH v4 04/12] phy: atheros: Explicitly disable RGMII delays

From: Vladimir Oltean To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on. If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the PHY_INTERFACE_MODE_RGMII_RXID or

[PATCH v4 06/12] phy: atheros: fix AR8021 PHY ID mask

The upper bits are all the OUI. Signed-off-by: Michael Walle Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 3cc162828c..01953a1390 100644 ---

[PATCH v4 05/12] phy: atheros: Clarify the intention of ar8021_config

From: Vladimir Oltean Debug register 5 contains TX_CLK DELAY at bit 8 and reserved values at the other bit positions, just like the other PHYs in the family do. Therefore, it is not necessary to hardcode the reserved values, but instead simply follow the read-modify-write procedure from the

[PATCH v4 07/12] phy: atheros: use defines for PHY IDs

Signed-off-by: Michael Walle Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index 01953a1390..5ff5875d3d 100644 --- a/drivers/net/phy/atheros.c +++

Re: [PATCH 1/2] test: describe naming conventions for macro UNIT_TEST

On 5/6/20 10:26 AM, Heinrich Schuchardt wrote: > Strict naming conventions have to be followed for Python function > generate_ut_subtest() to collect C unit tests to be executed via > command 'ut'. > > Describe the requirements both on the C as well on the Python side. > +/** > + * UNIT_TEST() -

efi_loader: efi_variable_parse_signature() returns NULL on error

efi_variable_parse_signature() returns NULL on error, so IS_NULL() is an incorrect check. The goto err leads to pkcs7_free_message(), which works fine on a NULL ptr. Signed-off-by: Patrick Wildt diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c index

Re: [PATCH 8/8] qemu: arm64: Add documentation for capsule update

On Fri, May 01, 2020 at 11:17:27AM +0530, Sughosh Ganu wrote: > On Fri, 1 May 2020 at 00:57, Tom Rini wrote: > > > On Fri, May 01, 2020 at 12:38:45AM +0530, Sughosh Ganu wrote: > > > On Fri, 1 May 2020 at 00:07, Heinrich Schuchardt > > wrote: > > > > > > > On 4/30/20 7:36 PM, Sughosh Ganu

Re: [PATCH 10/13] imx: load calibration parameters from fuse for i.MX8MP

Hi Peng, On Wed, May 6, 2020 at 9:08 PM Peng Fan wrote: > I'll give a look. Thanks for raising the issue. I understand the issue now. I will send a patch soon. Thanks

Re: [PATCH 3/8] qemu: arm64: Add support for efi firmware management protocol routines

On Fri, May 01, 2020 at 11:33:42AM +0200, Heinrich Schuchardt wrote: > On 4/30/20 9:13 PM, Sughosh Ganu wrote: > > > > On Fri, 1 May 2020 at 00:09, Heinrich Schuchardt > > wrote: > > > > On 4/30/20 7:36 PM, Sughosh Ganu wrote: > > > Add support for the

[PATCH v4 08/12] phy: atheros: introduce debug read and write functions

Provide functions to read and write the Atheros debug registers. Signed-off-by: Michael Walle Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 57 --- 1 file changed, 41 insertions(+), 16 deletions(-) diff --git a/drivers/net/phy/atheros.c

[PATCH v4 10/12] phy: atheros: add device tree bindings and config

Add support for configuring the CLK_25M pin as well as the RGMII I/O voltage by the device tree. By default the AT803x PHYs outputs the 25MHz clock of the XTAL input. But this output can also be changed by software to other frequencies. This commit introduces a generic way to configure this

[PATCH v4 12/12] phy: atheros: consolidate {ar8031|ar8035}_config()

The two functions are now exactly the same, remove one of them. Signed-off-by: Michael Walle Acked-by: Joe Hershberger --- drivers/net/phy/atheros.c | 30 +++--- 1 file changed, 3 insertions(+), 27 deletions(-) diff --git a/drivers/net/phy/atheros.c

[PATCH v4 11/12] phy: atheros: ar8035: remove static clock config

We can configure the clock output in the device tree. Disable the hardcoded one in here. This is highly board-specific and should have never been enabled in the PHY driver. If bisecting shows that this commit breaks your board it probably depends on the clock output of your Atheros AR8035 PHY.

Re: [PATCH 1/1] test: stabilize test_efi_secboot

Heinrich, On Mon, May 04, 2020 at 12:33:26PM +0200, Heinrich Schuchardt wrote: > When setting up the console via function efi_console_register() we call > query_console_serial(). This functions sends an escape sequence to the > terminal to query the display size. The response is another escape >

Re: [PATCH v10 20/21] doc: riscv: Add documentation for Sipeed Maix Bit

Hi Sean > On 5/5/20 1:02 PM, Sean Anderson wrote: > > On 5/5/20 5:01 AM, Rick Chen wrote: > >> Hi Sean > >> > >>> This patch adds documentation for the Sipeed Maix bit, and more generally > >>> for the Kendryte K210 processor. > >>> > >>> Signed-off-by: Sean Anderson > >>> --- > >>> > >>>

Re: [PATCH v10 20/21] doc: riscv: Add documentation for Sipeed Maix Bit

>> [1] https://travis-ci.org/github/Forty-Bot/u-boot/jobs/682461390 > > I just remove your v10 patchs and run again today, it will pass (Build #53) > https://travis-ci.org/github/rickchen36/u-boot-riscv/builds/683645440 > > Please check about 52 and 53. > > Thanks, > Rick > Yes, those were

RE: [PATCH] powerpc: dts: p1010: add i2c node

>-Original Message- >From: U-Boot On Behalf Of Biwen Li >Sent: Sunday, April 12, 2020 2:35 PM >To: Jagdish Gediya ; Priyanka Jain >; h...@denx.de; ja...@amarulasolutions.com; >aford...@gmail.com; Alison Wang ; >jh80.ch...@samsung.com; Pramod Kumar ; >Rajesh Bhagat ; Ruchika Gupta >;

Re: [PATCH 02/36] bdinfo: riscv: Use generic bd_info

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > At present riscv still uses its own private bd_info struct. Move it over > to use the generic one like other archs. > > Signed-off-by: Simon Glass > --- > > arch/riscv/include/asm/u-boot.h | 19 ++- > 1 file changed, 2

Re: [PATCH 03/36] bdinfo: m68k: Drop bd_info->bi_ipbfreq

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This field is not used anymore. Drop it. > > Signed-off-by: Simon Glass > --- > > include/asm-generic/u-boot.h | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin Meng

Re: [PATCH 01/36] bdinfo: nds32: Use generic bd_info

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > At present nds32 still uses its own private bd_info struct. Move it over > to use the generic one like other archs. > > Signed-off-by: Simon Glass > --- > > arch/nds32/include/asm/u-boot.h | 20 ++-- > 1 file changed, 2

Re: [PATCH 06/36] bdinfo: nios2: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > Nios2 currently has some code to output SRAM information which is behind > an #ifdef. No nios2 boards define this option, so the code can be removed. > > Move Nios2 over to use the generic function. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 27/36] bdinfo: net: Inline print_eths()

Hi Simon, On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This function has only one line of code so inline it. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c > index

Re: [PATCH 23/36] bdinfo: Drop print_cpu_word_size()

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This function only has one line of code in it so inline it. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 26/36] bdinfo: net: Drop legacy ethernet bdinfo

Hi Simon, On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This code pre-dates driver model and the migration date is nearly upon us. > Pare the print_eths() function down and enable it for driver model, since > it works correctly. > > The IP address is already printed in

Re: [PATCH 24/36] bdinfo: net: ppc: Drop bi_enet1addr and other similar info

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > These values were 'old' in 2013 so it should be safe to remove them. They > are never set in U-Boot anyway, so the values will always be zero. > > Signed-off-by: Simon Glass > --- > > common/board_r.c | 16 +--- >

Re: [PATCH 25/36] bdinfo: net: ppc: Drop prints for CONFIG_HAS_ETHn

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > These config options have not been migrated to Kconfig. This should be > handled using driver model, iterating over the available Ethernet devices. > For now, remove the code. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 15

Re: [PATCH 20/36] bdinfo: sh: arc: Drop arch-specific print_bi_mem()

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > It isn't worth having arch-specific code for such minor output > differences. In fact it is better if all archs are consistent. > > Drop the arch-specific code in print_bi_mem() and inline it to avoid a > two-line function. > > Signed-off-by:

Re: [PATCH 22/36] bdinfo: Drop print_bi_flash()

Hi Simon, On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This function only has three lines of code in it so inline it. What's our guideline for inlining functions? To me if there is only one line, inline the function looks good to me. But 3 lines? I am not sure. > > Signed-off-by:

Re: [PATCH v8 05/14] usb: dwc3: use the phy bulk API to get phys

Am 6. Mai 2020 05:09:55 MESZ schrieb Chunfeng Yun : >Would you please help to test the function on xilinx-board? due to I >just build it pass, no board to test it. > >Thank you for sending out the v8 series of pathes Hi, I also only fixed the build-error (to get series merged into 2020-07

Re: [PATCH 0/2] u-boot support for ODROID-C4

Hi Beniamino, On 05/05/2020 22:22, Beniamino Galvani wrote: > Hi, > > these two patches add initial u-boot support for Hardkernel ODROID-C4. Thanks for the patchset, I already have one in my test tree, by you did beat me by sending it to the list ! > >

Re: [PATCH 05/36] bdinfo: mips: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > MIPS currently has a few extra things which are generally useful. Add them > to the generic function and move MIPS over to use it. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 13 - > 1 file changed, 4 insertions(+), 9

Re: [PATCH 11/36] bdinfo: nds32: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This arch has none of its own info to show. Move it over to use the > generic do_bdinfo(). > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 12/36] bdinfo: riscv: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This arch has none of its own info to show. Move it over to use the > generic do_bdinfo(). > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 13/36] bdinfo: arm: Use the generic bd command

Hi Simon, On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > Unfortunately ARM has a lot of special stuff. Move it into the generic > function for now, so we can have it all in one place. > > Add in the frame-buffer printout, since it supports driver model too. > > Signed-off-by: Simon Glass

Re: [PATCH 07/36] bdinfo: microblaze: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > Microblaze prints out ethernet and FDT information. This is useful to > most archs, so move it into the generic code and move microblaze over to > use it. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 30

Re: [PATCH 04/36] bdinfo: xtensa: Create a generic do_bdinfo for xtensa

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This arch uses only the generic function. It would be nice if all the > archs did the same. As a first step, create a new generic function for the > 'bd' command and make xtensa use it. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c |

Re: [PATCH 09/36] bdinfo: x86: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This arch shows 'ethspeed' info but only the freescale drivers use it, so > it can be dropped. > > It also calls print_bi_dram() which is safe to call from any arch since it > has an #ifdef inside it. Add this to the generic do_bdinfo() and

Re: [PATCH 08/36] bdinfo: sh: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This arch has no code that is not already in the generic function. Drop > the arch-specific function and change sh over to use the generic one. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 13 + > 1 file changed, 1

Re: [PATCH 10/36] bdinfo: sandbox: Use the generic bd command

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > Sandbox has a printout of 'FB base' but this code is not used since > sandbox uses driver model for everything. > > Move sandbox over to use the generic do_bdinfo(). > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 16 +---

Re: [PATCH 30/36] bdinfo: arm: Move ARM-specific info into its own file

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > We don't really want to have ARM-specific code in a generic file. Create > a new arch-specific function to hold it, and move it into that. > > Make the function weak so that any arch can implement it. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 31/36] bdinfo: ppc: Move PPC-specific info into its own file

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > We don't really want to have PPC-specific code in a generic file. Create > a new arch-specific function to hold it, and move it into that. > > Make the function weak so that any arch can implement it. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 28/36] bdinfo: net: Inline print_eth_ip_addr()

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > This function only has two lines of code now, so inline it. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH 32/36] bdinfo: m68k: Move m68k-specific info into its own file

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > We don't really want to have m68k-specific code in a generic file. Create > a new arch-specific function to hold it, and move it into that. > > Make the function weak so that any arch can implement it. > > Signed-off-by: Simon Glass > --- > >

Re: [PATCH 35/36] bdinfo: dm: Update fb_base when using driver model

On Tue, May 5, 2020 at 7:25 AM Simon Glass wrote: > > Update this value with the address of a video device so that it shows with > the 'bd' command. > > It would be better to obtain the address from the uclass by looking in > struct video_uc_platdata for each device. We can move over to that once

Re: [PATCH 36/36] bdinfo: x86: vesa: Update fb_base to the correct value

Hi Simon, On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > Set this value in global_data so that it is reported correctly on x86 > boards. > > In fact, space is allocated for the frame buffer even though it is not > used. The FSP picks the address itself, which is why the current value > is

Re: [PATCH 33/36] bdinfo: m68k: ppc: Move arch-specific code from bdinfo

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > We don't have an easy way to share these three lines of code with two > architectures. We also want to make it clear that this code is actually > arch-specific. > > So just duplicate it in each arch-specific file. > > Signed-off-by: Simon

Re: [PATCH 34/36] bdinfo: Update the file comments

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > Update the comment at the top of the file to indicate what this file does. > Also drop the line at the bottom and an unnecessary header include. > > Signed-off-by: Simon Glass > --- > > cmd/bdinfo.c | 8 ++-- > 1 file changed, 2

[PATCH] fastboot: getvar: fix partition-size return value

The size returned by 'getvar partition-size' should be in bytes, not in blocks as fastboot uses that value to generate empty partition when running format [1]. [1] https://android.googlesource.com/platform/system/core/+/refs/heads/android10-release/fastboot/fastboot.cpp#1500 Signed-off-by: Gary

Re: [PATCH 29/36] bdinfo: Export some basic printing functions

On Tue, May 5, 2020 at 7:19 AM Simon Glass wrote: > > At present the functions to print a number and a frequency are static. We > want to move some of the code in here to an arch-specific file. For > consistency that code should use these same functions. So export them with > an appropriate name.

Re: [PATCH v3 1/2] arm: rpi: Add function to trigger VL805's firmware load

Hi Bin, On Wed, 2020-05-06 at 13:33 +0800, Bin Meng wrote: > Hi Nicolas, > > On Wed, May 6, 2020 at 12:26 AM Nicolas Saenz Julienne > wrote: > > On the Raspberry Pi 4, after a PCI reset, VL805's (a xHCI chip) firmware > > may either be loaded directly from an EEPROM or, if not present, by the >

  1   2   3   >