Re: [PATCH] tools: mksunxiboot: Use sunxi_image header directly

2021-10-14 Thread Samuel Holland
On 10/13/21 7:19 PM, Andre Przywara wrote: > On Tue, 12 Oct 2021 19:35:41 -0500 > Samuel Holland wrote: > >> When adding eGON support to mkimage, the struct boot_file_head >> definition was moved to its own header. This is the only thing >> mksunxiboot needed out of asm/arch/spl.h. Clean up the

[RFC PATCH 1/1] tools: mkimage: Add Allwinner TOC1 support

2021-10-14 Thread Samuel Holland
TOC1 is an container format used by Allwinner's boot0 that can hold multiple images. It supports encryption and signatures, but that functionality is not implemented, only the basic "non-secure" subset. A config file is used to provide the list of data files to include. Its path is passed as the

[RFC PATCH 0/1] tools: mkimage: Add Allwinner TOC1 support

2021-10-14 Thread Samuel Holland
The SPL port for the Allwinner D1 RISC-V SoC will probably take a while longer than porting U-Boot proper, as none of the relevant drivers are set up for DM in SPL. In the meantime, we are using[1][2] a fork[3] of Allwinner's boot0 loader, which they also call "spl" in their BSP. boot0 uses this

[PATCH v3 2/4] tools: mkimage: Add Allwinner TOC0 support

2021-10-14 Thread Samuel Holland
Most Allwinner sunxi SoCs have separate boot ROMs in non-secure and secure mode. The "non-secure" or "normal" boot ROM (NBROM) uses the existing sunxi_egon image type. The secure boot ROM (SBROM) uses a completely different image type, known as TOC0. A TOC0 image is composed of a header and two

[PATCH v3 4/4] sunxi: Support building a SPL as a TOC0 image

2021-10-14 Thread Samuel Holland
Now that mkimage can generate TOC0 images, and the SPL can interpret them, hook up the build infrastructure so the user can choose which image type to build. Since the absolute load address is stored in the TOC0 header, that information must be passed to mkimage. Signed-off-by: Samuel Holland

[PATCH v3 3/4] sunxi: Support SPL in both eGON and TOC0 images

2021-10-14 Thread Samuel Holland
SPL uses the image header to detect the boot device and to find the offset of the next U-Boot stage. Since this information is stored differently in the eGON and TOC0 image headers, add code to find the correct value based on the image type currently in use. Signed-off-by: Samuel Holland ---

[PATCH v3 1/4] tools: Separate image types which depend on OpenSSL

2021-10-14 Thread Samuel Holland
Some image types (kwbimage and mxsimage) always depend on OpenSSL, so they can only be included in mkimage when TOOLS_LIBCRYPTO is selected. Use Makefile logic to conditionally link the files. When building for platforms which use those image types, automatically select TOOLS_LIBCRYPTO, since it

[PATCH v3 0/4] sunxi: TOC0 image type support

2021-10-14 Thread Samuel Holland
This series adds support for the TOC0 image format used by the Allwinner secure boot ROM (SBROM). This series has been tested on the following SoCs/boards, with the eFuse burnt to enable secure mode: - A50: Ainol Q88 Tablet - A64: Pine A64 Plus - H5: Orange Pi Zero Plus - H6: Pine H64 Model B

Re: External dts building

2021-10-14 Thread Giulio Benetti
Hi Simon, > Il giorno 15 ott 2021, alle ore 02:53, Simon Glass ha > scritto: > > Hi Giulio, > >> On Thu, 14 Oct 2021 at 15:12, Giulio Benetti >> wrote: >> >> Hi Simon, >> >> Il giorno 14 ott 2021, alle ore 22:43, Simon Glass ha >> scritto: >> >> Hi Giulio, >> >> On Thu, 14 Oct 2021

Re: [PATCH] CI: Switch running the nokia_rx51 test with in-container toolchain

2021-10-14 Thread Simon Glass
On Thu, 14 Oct 2021 at 20:21, Tom Rini wrote: > > Instead of fetching an arm toolchain to use, run the test with the one > that's already in the container image. > > Signed-off-by: Tom Rini > --- > .azure-pipelines.yml | 3 +-- > .gitlab-ci.yml | 3 +-- > 2 files changed, 2 insertions(+),

Re: [PATCH 1/4] serial: samsung: add support for skip debug init in s5p

2021-10-14 Thread Minkyu Kang
Dear Dzmitry Sankouski, On Wed, 13 Oct 2021 at 00:42, Dzmitry Sankouski wrote: > Signed-off-by: Dzmitry Sankouski > Cc: Minkyu Kang > --- > drivers/serial/serial_s5p.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/serial/serial_s5p.c

[PATCH] CI: Switch running the nokia_rx51 test with in-container toolchain

2021-10-14 Thread Tom Rini
Instead of fetching an arm toolchain to use, run the test with the one that's already in the container image. Signed-off-by: Tom Rini --- .azure-pipelines.yml | 3 +-- .gitlab-ci.yml | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.azure-pipelines.yml

Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults

2021-10-14 Thread Simon Glass
Hi Peng, Sean, On Thu, 14 Oct 2021 at 19:17, Peng Fan wrote: > > > Subject: Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults > > > > > > On 10/13/21 5:37 AM, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > Current code has a force clk_set_defaults in multiple stages, U-Boot > > >

[PATCH next v6 11/12] configs: aspeed: Make EXTRA_ENV_SETTINGS board specific

2021-10-14 Thread Chia-Wei Wang
Move CONFIG_EXTRA_ENV_SETTINGS to board-specific configuration headers. Signed-off-by: Chia-Wei Wang --- include/configs/aspeed-common.h | 9 - include/configs/evb_ast2500.h | 9 + include/configs/evb_ast2600.h | 9 + 3 files changed, 18 insertions(+), 9 deletions(-)

[PATCH next v6 04/12] crypto: aspeed: Add AST2600 HACE support

2021-10-14 Thread Chia-Wei Wang
From: Johnny Huang Hash and Crypto Engine (HACE) is designed to accelerate the throughput of hash data digest, and symmetric-key encryption. Signed-off-by: Johnny Huang Signed-off-by: Chia-Wei Wang --- drivers/crypto/Kconfig | 2 + drivers/crypto/Makefile | 1 +

[PATCH next v6 12/12] configs: ast2600: Boot kernel FIT in DRAM

2021-10-14 Thread Chia-Wei Wang
AST2600 leverages the FIT hash/signature verification to fulfill secure boot trust chain. To improve the performance and save SW code size for those crypto operations, the two HW crypto engine, HACE and ACRY, are enabled. However, both of the engines can only access to data stored in DRAM space.

[PATCH next v6 07/12] crypto: aspeed: Add AST2600 ACRY support

2021-10-14 Thread Chia-Wei Wang
ACRY is deisnged to accerlerate ECC/RSA digital signature generation and verification. Signed-off-by: Chia-Wei Wang --- drivers/crypto/aspeed/Kconfig | 10 ++ drivers/crypto/aspeed/Makefile | 1 + drivers/crypto/aspeed/aspeed_acry.c | 182

[PATCH next v6 09/12] ast2600: spl: Locate load buffer in DRAM space

2021-10-14 Thread Chia-Wei Wang
Return CONFIG_SYS_LOAD_ADDR pointing to DRAM space for spl_get_load_buffer() to allow generic SPL image loading code (e.g. FIT and Ymodem) to store data in DRAM. Signed-off-by: Chia-Wei Wang --- arch/arm/mach-aspeed/ast2600/spl.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-)

[PATCH next v6 08/12] ARM: dts: ast2600: Add ACRY to device tree

2021-10-14 Thread Chia-Wei Wang
Add ACRY DTS node and enable it for AST2600 EVB. Signed-off-by: Chia-Wei Wang --- arch/arm/dts/ast2600-evb.dts | 5 + arch/arm/dts/ast2600.dtsi| 9 + 2 files changed, 14 insertions(+) diff --git a/arch/arm/dts/ast2600-evb.dts b/arch/arm/dts/ast2600-evb.dts index

[PATCH next v6 10/12] configs: ast2600-evb: Enable SPL FIT support

2021-10-14 Thread Chia-Wei Wang
Enable SPL FIT image load and verification support. The HW accelerated SHA is also available with the newly added support of the HACE HW hash engine. The SPL thumb build is also enabled to keep the binary less than 64KB to fit into the Aspeed secure boot design. Signed-off-by: Chia-Wei Wang ---

[PATCH next v6 06/12] clk: ast2600: Add RSACLK control for ACRY

2021-10-14 Thread Chia-Wei Wang
Add RSACLK enable for ACRY, the HW RSA/ECC crypto engine of ASPEED AST2600 SoCs. As ACRY and HACE share the same reset control bit, we do not perform the reset-hold-n-release operation during their clock ungating process. Instead, only reset release is conducted to prevent mutual interference.

[PATCH next v6 05/12] ARM: dts: ast2600: Add HACE to device tree

2021-10-14 Thread Chia-Wei Wang
From: Joel Stanley Add HACE DTS node and enable it for AST2600 EVB. Signed-off-by: Joel Stanley Signed-off-by: Chia-Wei Wang --- arch/arm/dts/ast2600-evb.dts | 5 + arch/arm/dts/ast2600.dtsi| 8 2 files changed, 13 insertions(+) diff --git a/arch/arm/dts/ast2600-evb.dts

[PATCH next v6 00/12] aspeed: Support secure boot chain with FIT image verification

2021-10-14 Thread Chia-Wei Wang
This patch series intends to provide a secure boot chain from SPL to Linux kernel based on the hash and signature verification of FIT image paradigm. To improve the performance and save code size (SPL is limited to 64KB due to HW-RoT), the drviers of two HW crypto engine HACE and ACRY are also

[PATCH next v6 03/12] clk: ast2600: Add YCLK control for HACE

2021-10-14 Thread Chia-Wei Wang
From: Joel Stanley Add YCLK enable for HACE, the HW hash engine of ASPEED AST2600 SoCs. Signed-off-by: Joel Stanley Signed-off-by: Chia-Wei Wang --- .../arm/include/asm/arch-aspeed/scu_ast2600.h | 5 +++-- drivers/clk/aspeed/clk_ast2600.c | 20 +++ 2 files

[PATCH next v6 01/12] image: fit: Fix parameter name for hash algorithm

2021-10-14 Thread Chia-Wei Wang
Fix inconsistent parameter naming of the hash algorithm. Signed-off-by: Chia-Wei Wang Fixes: 92055e138f2 ("image: Drop if/elseif hash selection in calculate_hash()") --- common/image-fit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/image-fit.c

[PATCH next v6 02/12] aspeed: ast2600: Enlarge SRAM size

2021-10-14 Thread Chia-Wei Wang
The AST2600 SRAM has been extended to 88KB since A1 chip revision. This patch updates the SRAM size to offer more space for early stack/heap use. Signed-off-by: Chia-Wei Wang --- arch/arm/include/asm/arch-aspeed/platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 4/4] sunxi: specify architecture when generating SPL boot image

2021-10-14 Thread Samuel Holland
From: Icenowy Zheng As mkimage -T sunxi_egon now gains support for -A parameter, specify the architecture when generating SPL boot image for sunxi. Reviewed-by: Andre Przywara Signed-off-by: Icenowy Zheng Signed-off-by: Samuel Holland --- (no changes since v1) scripts/Makefile.spl | 2 +-

[PATCH v3 2/4] mkimage: sunxi_egon: refactor for multi-architecture support

2021-10-14 Thread Samuel Holland
From: Icenowy Zheng Refactor some functions in mkimage sunxi_egon type, in order to prepare for adding support for more CPU architectures (e.g. RISC-V). In addition, compatibility for operation w/o specified architecture is kept, in this case the architecture is assumed as ARM. Reviewed-by:

[PATCH v3 3/4] mkimage: sunxi_egon: add support for riscv

2021-10-14 Thread Samuel Holland
From: Icenowy Zheng There's now a sun20i family in sunxi, which uses RISC-V CPU. Add support for making eGON.BT0 image for RISC-V. Reviewed-by: Andre Przywara Signed-off-by: Icenowy Zheng Signed-off-by: Samuel Holland --- (no changes since v1) tools/sunxi_egon.c | 23

[PATCH v3 1/4] mkimage: add a flag to describe whether -A is specified

2021-10-14 Thread Samuel Holland
From: Icenowy Zheng The sunxi_egon type used to take no -A argument (because we assume sunxi targets are all ARM). However, as Allwinner D1 appears as the first RISC-V sunxi target, we need to support -A; in addition, as external projects rely on U-Boot mkimage to generate sunxi eGON.BT0 header,

[PATCH v3 0/4] mkimage: sunxi_egon: add riscv support

2021-10-14 Thread Samuel Holland
This patchset updates mkimage -T sunxi_egon to be able to generate an eGON.BT0 image for Allwinner RISC-V SoCs (e.g. D1). In addition, to keep the compatibility, it will still consider the architecture to be ARM when no architecture is specified. This v3 is a minor update to Icenowy's patch

Re: [PATCH 1/1] cmd: simplify 'efidebug boot add' command

2021-10-14 Thread Heinrich Schuchardt
On 10/14/21 11:46 PM, Heinrich Schuchardt wrote: We can determine the length of the device path in the boot option after it is created. There is no need to keep track of the length while building the device path. As we are using end of total device path node as separator this does not work.

[PATCH 1/1] efi_loader: efi_dp_from_lo() should skip VenMedia node

2021-10-14 Thread Heinrich Schuchardt
The 'efidebug boot dump' command should not display the VenMedia() device path node preceding the device path of the initial ram disk. By letting efi_dp_from_lo() skip the VenMedia() device path node we can simplify the coding. Signed-off-by: Heinrich Schuchardt ---

RE: [PATCH next v5 01/12] image: fit: Fix parameter name for hash algorithm

2021-10-14 Thread ChiaWei Wang
Hi Simon, > From: Simon Glass > Sent: Thursday, October 14, 2021 11:10 PM > > Hi Chia-Wei, > > On Sun, 3 Oct 2021 at 19:54, Chia-Wei Wang > wrote: > > > > Fix inconsistent function parameter name of the hash algorithm. > > > > Signed-off-by: Chia-Wei Wang > > Fixes: 92055e138f2 ("image: Drop

Re: [PATCH] buildman: Add gcc-11.1.0 to the directory list

2021-10-14 Thread Tom Rini
On Thu, Oct 14, 2021 at 07:25:24PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 14 Oct 2021 at 19:12, Tom Rini wrote: > > > > On Thu, Oct 14, 2021 at 07:05:33PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 5 Oct 2021 at 10:20, Tom Rini wrote: > > > > > > > > While CI has been

Re: [PATCH] buildman: Add gcc-11.1.0 to the directory list

2021-10-14 Thread Simon Glass
Hi Tom, On Thu, 14 Oct 2021 at 19:12, Tom Rini wrote: > > On Thu, Oct 14, 2021 at 07:05:33PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 5 Oct 2021 at 10:20, Tom Rini wrote: > > > > > > While CI has been using gcc-11.1.0 for a long time, we have not updated > > > buildman to match.

RE: [PATCH] clk: introduce u-boot,ignore-clk-defaults

2021-10-14 Thread Peng Fan
> Subject: Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults > > > On 10/13/21 5:37 AM, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > Current code has a force clk_set_defaults in multiple stages, U-Boot > > reuse the same device tree and Linux Kernel device tree, but we not > > register

Re: [PATCH] buildman: Add gcc-11.1.0 to the directory list

2021-10-14 Thread Tom Rini
On Thu, Oct 14, 2021 at 07:05:33PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 5 Oct 2021 at 10:20, Tom Rini wrote: > > > > While CI has been using gcc-11.1.0 for a long time, we have not updated > > buildman to match. Correct this omission. > > > > Signed-off-by: Tom Rini > > --- > >

Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults

2021-10-14 Thread Sean Anderson
On 10/13/21 5:37 AM, Peng Fan (OSS) wrote: From: Peng Fan Current code has a force clk_set_defaults in multiple stages, U-Boot reuse the same device tree and Linux Kernel device tree, but we not register all the clks as Linux Kernel, so clk_set_defaults will fail and cause the clk provider

Re: [PATCH] buildman: Add gcc-11.1.0 to the directory list

2021-10-14 Thread Simon Glass
Hi Tom, On Tue, 5 Oct 2021 at 10:20, Tom Rini wrote: > > While CI has been using gcc-11.1.0 for a long time, we have not updated > buildman to match. Correct this omission. > > Signed-off-by: Tom Rini > --- > tools/buildman/toolchain.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: External dts building

2021-10-14 Thread Simon Glass
Hi Giulio, On Thu, 14 Oct 2021 at 15:12, Giulio Benetti wrote: > > Hi Simon, > > Il giorno 14 ott 2021, alle ore 22:43, Simon Glass ha > scritto: > > Hi Giulio, > > On Thu, 14 Oct 2021 at 13:23, Giulio Benetti > wrote: > > > Hi Simon, > > > Il giorno 14 ott 2021, alle ore 20:24, Simon Glass

Re: [PATCH v4 03/11] efi_loader: capsule: add back efi_get_public_key_data()

2021-10-14 Thread Simon Glass
Hi Takahiro, On Thu, 7 Oct 2021 at 00:25, AKASHI Takahiro wrote: > > The commit 47a25e81d35c ("Revert "efi_capsule: Move signature from DTB to > .rodata"") failed to revert the removal of efi_get_public_key_data(). > > Add back this function and move it under lib/efi_loader so that other >

Re: [PATCH v4 04/11] tools: add fdtsig.sh

2021-10-14 Thread Simon Glass
Hi Takahiro, On Mon, 11 Oct 2021 at 19:42, AKASHI Takahiro wrote: > > Simon, > > On Mon, Oct 11, 2021 at 08:54:09AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 7 Oct 2021 at 00:25, AKASHI Takahiro > > wrote: > > > > > > With this script, a public key is added to a device tree

Re: [PATCH v2 04/13] env: Change env_match() to static and remove from header

2021-10-14 Thread Simon Glass
On Thu, 14 Oct 2021 at 12:24, Simon Glass wrote: > > Hi Marek, > > On Thu, 14 Oct 2021 at 10:06, Marek Behún wrote: > > > > On Thu, 14 Oct 2021 09:11:08 -0600 > > Simon Glass wrote: > > > > > Hi Marek, > > > > > > On Wed, 13 Oct 2021 at 09:46, Marek Behún wrote: > > > > > > > > From: Marek

Re: [PATCH v2 1/7] iommu: Add IOMMU uclass

2021-10-14 Thread Simon Glass
Hi Mark, On Thu, 14 Oct 2021 at 15:11, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Thu, 14 Oct 2021 14:55:19 -0600 > > > > Hi Mark, > > > > On Thu, 14 Oct 2021 at 14:51, Mark Kettenis wrote: > > > > > > > From: Simon Glass > > > > Date: Thu, 14 Oct 2021 14:20:21 -0600 > > > > > > >

Re: [PATCH v2 10/13] env: Use better name for variable in env_get_f()

2021-10-14 Thread Simon Glass
Hi Marek, On Wed, 13 Oct 2021 at 09:46, Marek Behún wrote: > > From: Marek Behún > > The `nxt` variable actually points to the terminating null-byte of the > current env var, and the next env var is at `nxt + 1`, not `nxt`. So a > better name for this variable is `end`. > > Signed-off-by: Marek

Re: [PATCH v2 09/13] env: Use string pointer instead of indexes in env_get_f()

2021-10-14 Thread Simon Glass
Hi Marek, On Wed, 13 Oct 2021 at 09:46, Marek Behún wrote: > > From: Marek Behún > > Since we no longer use env_get_char() to access n-th character of > linearized environment data, but rather access the arrays themselves, we > can convert the iteration to use string pointers instead of

[PATCH 1/1] efi_loader: avoid multiple local copies of lf2_initrd_guid

2021-10-14 Thread Heinrich Schuchardt
Create the GUID as a global variable. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 3 +-- include/efi_load_initrd.h| 1 + lib/efi_loader/efi_helper.c | 5 + lib/efi_loader/efi_load_initrd.c | 3 +-- 4 files changed, 8 insertions(+), 4 deletions(-)

[PATCH 1/1] efi_loader: efi_dp_from_lo() unused parameter size

2021-10-14 Thread Heinrich Schuchardt
Parameter size is never used in function efi_dp_from_lo(). Remove it. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 3 +-- include/efi_loader.h | 1 - lib/efi_loader/efi_device_path.c | 2 -- lib/efi_loader/efi_helper.c | 2 +- 4 files changed, 2

[PATCH 1/1] efi_loader: simplify show_efi_boot_opt_data()

2021-10-14 Thread Heinrich Schuchardt
Use printf code %pD for printing device paths. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 5235dbb7c1..70a4658012 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@

Re: [PATCH] arm: spl: flush and disable cache before jumping to OPTEE

2021-10-14 Thread Tom Rini
On Sat, Sep 25, 2021 at 05:05:43PM +0300, Oleksandr Suvorov wrote: > From: Ricardo Salveti > > Make sure to flush, disable caches and interrupts before jumpint to > OPTEE. This fixes the SDP->SPL->OPTEE boot flow on iMX6Q and most > likely on some other ARM SoCs. > > Signed-off-by: Ricardo

[PATCH 1/1] efi_loader: efi_dp_from_lo() don't copy GUID

2021-10-14 Thread Heinrich Schuchardt
Instead of copying a GUID and then using a pointer to the copy for calling guidcmp(), just pass the pointer to the orginal GUID. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 2 +- include/efi_loader.h | 3 ++- lib/efi_loader/efi_device_path.c | 5 +++--

Re: [PATCH v3 7/7] doc: board: apple: Add Apple M1 documentation

2021-10-14 Thread François Ozog
Le jeu. 14 oct. 2021 à 22:44, Simon Glass a écrit : > Hi Mark, > > On Thu, 14 Oct 2021 at 14:09, Mark Kettenis > wrote: > > > > > From: Simon Glass > > > Date: Mon, 11 Oct 2021 11:01:20 -0600 > > > > > > Hi Mark, > > > > > > On Mon, 11 Oct 2021 at 10:40, Mark Kettenis > wrote: > > > > > > > >

[PATCH 1/1] cmd: simplify 'efidebug boot add' command

2021-10-14 Thread Heinrich Schuchardt
We can determine the length of the device path in the boot option after it is created. There is no need to keep track of the length while building the device path. Signed-off-by: Heinrich Schuchardt --- cmd/efidebug.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: External dts building

2021-10-14 Thread Giulio Benetti
On 10/14/21 8:22 PM, Tom Rini wrote: On Thu, Oct 14, 2021 at 08:08:37PM +0200, Giulio Benetti wrote: Il giorno 14 ott 2021, alle ore 15:45, Tom Rini ha scritto: On Thu, Oct 14, 2021 at 02:53:30AM +0200, Giulio Benetti wrote: Hello All, is there a way to pass a dts file without touching

Re: External dts building

2021-10-14 Thread Giulio Benetti
Hi Simon, > Il giorno 14 ott 2021, alle ore 22:43, Simon Glass ha > scritto: > > Hi Giulio, > >> On Thu, 14 Oct 2021 at 13:23, Giulio Benetti >> wrote: >> >> Hi Simon, >> Il giorno 14 ott 2021, alle ore 20:24, Simon Glass ha scritto: >>> >>> Hi, >>> On Thu, 14 Oct 2021

Re: [PATCH v2 1/7] iommu: Add IOMMU uclass

2021-10-14 Thread Mark Kettenis
> From: Simon Glass > Date: Thu, 14 Oct 2021 14:55:19 -0600 > > Hi Mark, > > On Thu, 14 Oct 2021 at 14:51, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Thu, 14 Oct 2021 14:20:21 -0600 > > > > > > Hi Mark, > > > > > > On Thu, 14 Oct 2021 at 13:35, Mark Kettenis > > > wrote: >

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread Simon Glass
Hi François, On Thu, 14 Oct 2021 at 12:13, François Ozog wrote: > > > > Le mer. 13 oct. 2021 à 20:06, Simon Glass a écrit : >> >> Hi François, >> >> On Wed, 13 Oct 2021 at 11:35, François Ozog wrote: >> > >> > Hi Simon >> > >> > Le mer. 13 oct. 2021 à 16:49, Simon Glass a écrit : >> >> >> >>

Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION

2021-10-14 Thread Simon Glass
Hi Takahiro, On Thu, 14 Oct 2021 at 02:03, AKASHI Takahiro wrote: > > Simon, > > On Wed, Oct 13, 2021 at 12:05:58PM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Tue, 12 Oct 2021 at 19:32, AKASHI Takahiro > > wrote: > > > > > > On Tue, Oct 12, 2021 at 11:14:17AM -0400, Tom Rini wrote: >

Re: [PATCH v2 1/7] iommu: Add IOMMU uclass

2021-10-14 Thread Simon Glass
Hi Mark, On Thu, 14 Oct 2021 at 14:51, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Thu, 14 Oct 2021 14:20:21 -0600 > > > > Hi Mark, > > > > On Thu, 14 Oct 2021 at 13:35, Mark Kettenis wrote: > > > > > > > From: Simon Glass > > > > Date: Mon, 11 Oct 2021 11:00:34 -0600 > > > > > > >

Re: [PATCH v2 1/7] iommu: Add IOMMU uclass

2021-10-14 Thread Mark Kettenis
> From: Simon Glass > Date: Thu, 14 Oct 2021 14:20:21 -0600 > > Hi Mark, > > On Thu, 14 Oct 2021 at 13:35, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Mon, 11 Oct 2021 11:00:34 -0600 > > > > > > Hi Mark, > > > > > > On Sun, 3 Oct 2021 at 12:31, Mark Kettenis wrote: > > > > >

Re: [PATCH v3 7/7] doc: board: apple: Add Apple M1 documentation

2021-10-14 Thread Simon Glass
Hi Mark, On Thu, 14 Oct 2021 at 14:09, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 11 Oct 2021 11:01:20 -0600 > > > > Hi Mark, > > > > On Mon, 11 Oct 2021 at 10:40, Mark Kettenis wrote: > > > > > > Provide preliminary instructions on how to get U-Boot to run on > > > Apple

Re: [PATCH v3 7/7] doc: board: apple: Add Apple M1 documentation

2021-10-14 Thread Simon Glass
Hi Mark, On Thu, 14 Oct 2021 at 14:15, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 11 Oct 2021 13:10:02 -0600 > > > > Hi Mark, > > > > On Mon, 11 Oct 2021 at 10:40, Mark Kettenis wrote: > > > > > > Provide preliminary instructions on how to get U-Boot to run on > > > Apple

Re: [PATCH v2 2/7] test: Add tests for IOMMU uclass

2021-10-14 Thread Simon Glass
Hi Mark, On Thu, 14 Oct 2021 at 13:51, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 11 Oct 2021 11:00:36 -0600 > > > > On Sun, 3 Oct 2021 at 12:31, Mark Kettenis wrote: > > > > > > Add a set of tests for the IOMMU uclass. > > > > > > Signed-off-by: Mark Kettenis > > > --- > > >

Re: External dts building

2021-10-14 Thread Simon Glass
Hi Giulio, On Thu, 14 Oct 2021 at 13:23, Giulio Benetti wrote: > > Hi Simon, > > > Il giorno 14 ott 2021, alle ore 20:24, Simon Glass ha > > scritto: > > > > Hi, > > > >> On Thu, 14 Oct 2021 at 07:46, Tom Rini wrote: > >> > >>> On Thu, Oct 14, 2021 at 02:53:30AM +0200, Giulio Benetti wrote:

Re: [PATCH v2 6/7] arm: dts: apple: Add preliminary device trees

2021-10-14 Thread Mark Kettenis
> From: Rob Herring > Date: Mon, 11 Oct 2021 14:48:46 -0500 Hi Rob, Trimming the CC list a bit and adding marcan. > On Mon, Oct 11, 2021 at 2:00 PM Mark Kettenis wrote: > > > > > From: Rob Herring > > > Date: Mon, 11 Oct 2021 13:36:29 -0500 > > > > Hi Rob, > > > > > On Sun, Oct 3, 2021 at

Re: [PATCH v2 1/7] iommu: Add IOMMU uclass

2021-10-14 Thread Simon Glass
Hi Mark, On Thu, 14 Oct 2021 at 13:35, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Mon, 11 Oct 2021 11:00:34 -0600 > > > > Hi Mark, > > > > On Sun, 3 Oct 2021 at 12:31, Mark Kettenis wrote: > > > > > > This uclass is intended to manage IOMMUs on systems where the > > > IOMMUs are

Re: [PATCH v3 7/7] doc: board: apple: Add Apple M1 documentation

2021-10-14 Thread Mark Kettenis
> From: Simon Glass > Date: Mon, 11 Oct 2021 13:10:02 -0600 > > Hi Mark, > > On Mon, 11 Oct 2021 at 10:40, Mark Kettenis wrote: > > > > Provide preliminary instructions on how to get U-Boot to run on > > Apple Silicon Macs. > > Apple-Silicon > > This is ambiguous. The Macs are not made out

Re: [PATCH v3 7/7] doc: board: apple: Add Apple M1 documentation

2021-10-14 Thread Mark Kettenis
> From: Simon Glass > Date: Mon, 11 Oct 2021 11:01:20 -0600 > > Hi Mark, > > On Mon, 11 Oct 2021 at 10:40, Mark Kettenis wrote: > > > > Provide preliminary instructions on how to get U-Boot to run on > > Apple Silicon Macs. > > > > Please can you add a change log to this patch? Patman will do

Re: [PATCH v2 4/7] serial: s5p: Add Apple M1 support

2021-10-14 Thread Mark Kettenis
> From: Simon Glass > Date: Mon, 11 Oct 2021 11:00:39 -0600 > > Hi Mark, > > On Sun, 3 Oct 2021 at 12:33, Mark Kettenis wrote: > > > > Apple M1 SoCs include an S5L UART which is a variant of the S5P > > UART. Add support for this variant and enable it by default > > on Apple SoCs. > > > >

Re: [PATCH v2 2/7] test: Add tests for IOMMU uclass

2021-10-14 Thread Mark Kettenis
> From: Simon Glass > Date: Mon, 11 Oct 2021 11:00:36 -0600 > > On Sun, 3 Oct 2021 at 12:31, Mark Kettenis wrote: > > > > Add a set of tests for the IOMMU uclass. > > > > Signed-off-by: Mark Kettenis > > --- > > arch/sandbox/dts/test.dts | 6 ++ > > configs/sandbox64_defconfig

Re: [PATCH v2 1/7] iommu: Add IOMMU uclass

2021-10-14 Thread Mark Kettenis
> From: Simon Glass > Date: Mon, 11 Oct 2021 11:00:34 -0600 > > Hi Mark, > > On Sun, 3 Oct 2021 at 12:31, Mark Kettenis wrote: > > > > This uclass is intended to manage IOMMUs on systems where the > > IOMMUs are not in bypass mode by default. In that case U-Boot > > cannot ignore the IOMMUs

Re: External dts building

2021-10-14 Thread Giulio Benetti
Hi Simon, > Il giorno 14 ott 2021, alle ore 20:24, Simon Glass ha > scritto: > > Hi, > >> On Thu, 14 Oct 2021 at 07:46, Tom Rini wrote: >> >>> On Thu, Oct 14, 2021 at 02:53:30AM +0200, Giulio Benetti wrote: >>> >>> Hello All, >>> >>> is there a way to pass a dts file without touching the

Re: IMX8M OP-TEE

2021-10-14 Thread Tim Harvey
On Mon, Oct 11, 2021 at 3:15 PM Tim Harvey wrote: > > Greetings, > > Is anyone successfully booting U-Boot with OP-TEE support on the IMX8M? > > My understanding is that you need to add tee.bin to the images in the > FIT image and include it in loadables following the ATF. > > While this was done

RE: i.mx7ulp u-boot image flashing to SD card - Doesn't use the new image from SD card.

2021-10-14 Thread Karicheri, Murali
Found the issue. The of=/dev/sde >sudo dd if=u-boot-dtb.imx of=/dev/sde1 bs=1k seek=1 conv=fsync Murali Karicheri, Software Architect S Electric Company (Work from Home) 18702 Broken Oak Rd, Boyds, Maryland, USA 20841 Phone: (301) 256 8139 E-Mail: murali.karich...@sandc.com

[PATCH v3 17/18] doc: Move distro boot doc to rST

2021-10-14 Thread Simon Glass
Move this over to the new rST format. Signed-off-by: Simon Glass --- (no changes since v1) doc/{README.distro => develop/distro.rst} | 177 ++ doc/develop/index.rst | 1 + 2 files changed, 80 insertions(+), 98 deletions(-) rename doc/{README.distro

[PATCH v3 15/18] pxe: Return the file size from the getfile() function

2021-10-14 Thread Simon Glass
It is pretty strange that the pxe code uses the 'filesize' environment variable find the size of a file it has just read. Partly this is because it uses the command-line interpreter to parse its request to load the file. As a first step towards unwinding this, return it directly from the

[PATCH v3 18/18] pxe: Allow calling the pxe_get logic directly

2021-10-14 Thread Simon Glass
Refactor this code so that we can call the 'pxe get' command without going through the command-line interpreter. This makes it easier to get the information we need, without going through environment variables. Signed-off-by: Simon Glass --- Changes in v3: - Rebase to -master Changes in v2: -

[PATCH v3 14/18] lib: Add a function to convert a string to a hex value

2021-10-14 Thread Simon Glass
Add an xtoa() function, similar to itoa() but for hex instead. Signed-off-by: Simon Glass --- (no changes since v1) include/vsprintf.h | 16 ++-- lib/vsprintf.c | 20 ++-- test/print_ut.c| 24 3 files changed, 56 insertions(+), 4

[PATCH v3 16/18] pxe: Refactor sysboot to have one helper

2021-10-14 Thread Simon Glass
The only difference between the three helpers is the filesystem type. Factor this out and call the filesystem functions directly, instead of through the command-line interpreter. This allows the file size to be obtained directly, instead of via an environment variable. We cannot do the same thing

[PATCH v3 10/18] pxe: Move common parsing coding into pxe_util

2021-10-14 Thread Simon Glass
Both the syslinux and pxe commands use essentially the same code to parse and run extlinux.conf files. Move this into a common function. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c| 20 cmd/pxe.c | 15 --- cmd/sysboot.c

[PATCH v3 13/18] lib: Add tests for simple_itoa()

2021-10-14 Thread Simon Glass
Add test and a comment for this function. Signed-off-by: Simon Glass --- (no changes since v1) include/vsprintf.h | 13 - test/print_ut.c| 17 + 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/include/vsprintf.h b/include/vsprintf.h index

[PATCH v3 11/18] pxe: Clean up the use of bootfile

2021-10-14 Thread Simon Glass
The 'bootfile' environment variable is read in the bowels of pxe_util to provide a directory to which all loaded files are relative. This is not obvious from the API to PXE and it is strange to make the caller set an environment variable rather than pass this as a parameter. The code is also

[PATCH v3 12/18] pxe: Drop get_bootfile_path()

2021-10-14 Thread Simon Glass
This function no longer makes sense, since it is pretty easy to prepend the boot directory to the filename. Drop it and update its only caller. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c| 53 + include/pxe_utils.h | 3

[PATCH v3 08/18] pxe: Tidy up some comments in pxe_utils

2021-10-14 Thread Simon Glass
Some of these functions are a big vague in the comments. Tidy them up a bit. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c | 189 ++- 1 file changed, 138 insertions(+), 51 deletions(-) diff --git a/boot/pxe_utils.c

[PATCH v3 09/18] pxe: Tidy up code style a little in pxe_utils

2021-10-14 Thread Simon Glass
There are a few more blank lines than makes sense for readability. Also free() handles a NULL pointer so drop the pointless checks. Signed-off-by: Simon Glass --- (no changes since v1) boot/pxe_utils.c | 66 ++-- 1 file changed, 13 insertions(+), 53

[PATCH v3 07/18] pxe: Move pxe_utils files

2021-10-14 Thread Simon Glass
Move the header file into the main include/ directory so we can use it from the bootmethod code. Move the C file into boot/ since it relates to booting. Signed-off-by: Simon Glass --- (no changes since v1) boot/Makefile| 3 +++ {cmd => boot}/pxe_utils.c| 0 cmd/Makefile

[PATCH v3 06/18] pxe: Tidy up the is_pxe global

2021-10-14 Thread Simon Glass
Move this into the context to avoid a global variable. Also rename it since the current name does not explain what it actually affects. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe.c | 6 ++ cmd/pxe_utils.c | 13 +++-- cmd/pxe_utils.h | 8 +---

[PATCH v3 03/18] pxe: Use a context pointer

2021-10-14 Thread Simon Glass
At present the PXE functions pass around a pointer to command-table entry which is very strange. It is only needed in a few places and it is odd to pass around a data structure from another module in this way. For bootmethod we will need to provide some context information when reading files.

[PATCH v3 02/18] pxe: Move API comments to the header files

2021-10-14 Thread Simon Glass
Put the function comments in the header file so that the full API can we examined in one place. Expand the comments to cover parameters and return values. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe_utils.c | 45 - cmd/pxe_utils.h | 77

[PATCH v3 04/18] pxe: Move do_getfile() into the context

2021-10-14 Thread Simon Glass
Rather than having a global variable, pass the function as part of the context. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe.c | 10 -- cmd/pxe_utils.c | 9 - cmd/pxe_utils.h | 20 +--- cmd/sysboot.c | 20 ++-- 4 files

[PATCH v3 05/18] pxe: Add a userdata field to the context

2021-10-14 Thread Simon Glass
Allow the caller to provide some info which is passed back to the readfile() method. Signed-off-by: Simon Glass --- (no changes since v1) cmd/pxe.c | 4 ++-- cmd/pxe_utils.c | 3 ++- cmd/pxe_utils.h | 6 +- cmd/sysboot.c | 2 +- 4 files changed, 10 insertions(+), 5 deletions(-)

[PATCH v3 01/18] Create a new boot/ directory

2021-10-14 Thread Simon Glass
Quite a lot of the code in common/relates to booting and images. Before adding more it seems like a good time to move the code into its own directory. Most files with 'boot' or 'image' in them are moved, except: - autoboot.c which relates to U-Boot automatically running a script - bootstage.c

[PATCH v3 00/18] pxe: Refactoring to tidy up and prepare for bootflow

2021-10-14 Thread Simon Glass
This collects together the patches previously sent relating to PXE. Firstly, it moves the boot code out of common/ and into a new boot/ directory. This helps to collect these related files in one place, as common/ is quite large. Secondly, it provides patache so clean up the PXE code and

Re: [PATCH v3 2/3] timer: cadence: Add bind function to driver

2021-10-14 Thread Sean Anderson
On 10/14/21 2:24 PM, Simon Glass wrote: Hi Sean, On Thu, 14 Oct 2021 at 09:36, Sean Anderson wrote: On 10/14/21 11:09 AM, Simon Glass wrote: > Hi Michal, > > On Wed, 6 Oct 2021 at 08:19, Michal Simek wrote: >> >> When DT node has pwm-cells property it shouldn't be bind as timer driver

Re: [PATCH v3 2/3] timer: cadence: Add bind function to driver

2021-10-14 Thread Simon Glass
Hi Sean, On Thu, 14 Oct 2021 at 09:36, Sean Anderson wrote: > > > > On 10/14/21 11:09 AM, Simon Glass wrote: > > Hi Michal, > > > > On Wed, 6 Oct 2021 at 08:19, Michal Simek wrote: > >> > >> When DT node has pwm-cells property it shouldn't be bind as timer driver > >> but as PWM driver. That's

Re: [PATCH v2 04/13] env: Change env_match() to static and remove from header

2021-10-14 Thread Simon Glass
Hi Marek, On Thu, 14 Oct 2021 at 10:06, Marek Behún wrote: > > On Thu, 14 Oct 2021 09:11:08 -0600 > Simon Glass wrote: > > > Hi Marek, > > > > On Wed, 13 Oct 2021 at 09:46, Marek Behún wrote: > > > > > > From: Marek Behún > > > > > > This function was used by other parts of U-Boot in the past

Re: [PATCH] cmd: sysboot: dont overwrite bootfile env

2021-10-14 Thread Simon Glass
Hi Art, On Wed, 13 Oct 2021 at 22:34, Art Nikpal wrote: > > > Please also see this refactor which conflicts with this patch: > > > > http://patchwork.ozlabs.org/project/uboot/list/?series=264265 > > > > I think that series should be reviewed/applied first since it was sent > in August. > > yes !

Re: [PATCH] cmd: pxe_utils: Check fdtcontroladdr in label_boot

2021-10-14 Thread Simon Glass
Hi Peter, On Thu, 14 Oct 2021 at 02:40, Peter Hoyes wrote: > > From: Peter Hoyes > > If using OF_CONTROL, fdtcontroladdr is set to the fdt used to configure > U-Boot. When using PXE, if no fdt is defined in the menu file, and > there is no fdt at fdt_addr, add fall back on fdtcontroladdr too. >

Re: External dts building

2021-10-14 Thread Simon Glass
Hi, On Thu, 14 Oct 2021 at 07:46, Tom Rini wrote: > > On Thu, Oct 14, 2021 at 02:53:30AM +0200, Giulio Benetti wrote: > > > Hello All, > > > > is there a way to pass a dts file without touching the > > arch/arm/boot/dts/Makefile? > > > > On Buildroot we support the possibility to pass an

  1   2   >