Re: [PATCH 2/2] dt-bindings: u-boot: Add an initial binding for config

2021-10-24 Thread Simon Glass
Hi Mark, On Thu, 21 Oct 2021 at 02:51, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Wed, 20 Oct 2021 16:44:41 -0600 > > > > Hi Rob, > > > > On Mon, 18 Oct 2021 at 16:26, Rob Herring wrote: > > > > > > On Wed, Oct 13, 2021 at 11:33 AM Simon Glass wrote: > > > > > > > > " > > > > Hi

Re: [PATCH v10 3/9] env: Allow U-Boot scripts to be placed in a .env file

2021-10-24 Thread Wolfgang Denk
Dear Tom, In message <20211022142912.GF3577824@bill-the-cat> you wrote: > > > However, '\' is also a legal character in a variable name (and > > doubled backslashes or apostrophes etc. are legal, too), so > > above line should actually set the environment variable "maximum\+" > > to "value". > >

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-24 Thread Wolfgang Denk
Dear Tom, In message <20211022144759.GG3577824@bill-the-cat> you wrote: > > > Any escape character is also a legal name character. > > I am struggling to have a non-meme reaction to this. Perhaps the best > step is just earlier on in the series note that variable names need to > fit within the

Re: [PATCH] kontron-sl-mx8mm: fix missing configs and deadlock in CI

2021-10-24 Thread Frieder Schrempf
On 20.10.21 12:03, Stefano Babic wrote: > Even if board can be successfuly built, CI goes in deadlock (see thread > on https://www.mail-archive.com/u-boot@lists.denx.de/msg419663.html). > This is caused by SYS_CONFIG set in header file and because defconfig > for the board is out of sync with

Re: [PATCH] imx8mm-cl-iot-gate-optee: align config with Kconfig

2021-10-24 Thread Fabio Estevam
Hi Stefano, On 20/10/2021 07:16, Stefano Babic wrote: Due to missing configs, CI goes in deadlock until an OOM is tracked. Add CONFIG_SYS_LOAD_ADDR and replace CONFIG_SYS_EXTRA_OPTIONS with CONFIG_IMX_CONFIG. Signed-off-by: Stefano Babic CC: Ying-Chun Liu (PaulLiu)" CC: Fabio Estevam

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-24 Thread Tom Rini
On Sun, Oct 24, 2021 at 05:46:00PM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20211022144759.GG3577824@bill-the-cat> you wrote: > > > > > Any escape character is also a legal name character. > > > > I am struggling to have a non-meme reaction to this. Perhaps the best > > step is

Re: [PATCH v4 1/4] dm: core: Bind another driver with the same compatible string

2021-10-24 Thread Simon Glass
Hi Michal, On Fri, 15 Oct 2021 at 07:17, Michal Simek wrote: > > When one IP can have multiple configurations (like timer and PWM) covered > by multiple drivers. Because it is the same IP it should also have the same > compatible string. > Current code look for the first driver which matches

Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file

2021-10-24 Thread Simon Glass
Hi Rasmus, On Fri, 22 Oct 2021 at 00:41, Rasmus Villemoes wrote: > > On 21/10/2021 18.03, Tom Rini wrote: > > On Thu, Oct 21, 2021 at 09:59:38AM -0600, Simon Glass wrote: > >> Hi Marek, > >> > >> On Thu, 21 Oct 2021 at 07:28, Marek Behún wrote: > >>> > >>> On Thu, 21 Oct 2021 15:25:37 +0200 >

Re: [PATCH] lib: uuid: fix the test on RNG device presence

2021-10-24 Thread Simon Glass
On Fri, 22 Oct 2021 at 09:05, Patrick Delaunay wrote: > > Correct the test on RNG device presence,when ret is equal to 0, > before to call dm_rng_read function. > > Without this patch the RNG device is not used when present (when ret == 0) > or a data abort occurs in dm_rng_read when

Re: [PATCH v2] lmb: Reserve U-Boot separately if relocation is disabled

2021-10-24 Thread Simon Glass
On Fri, 15 Oct 2021 at 09:49, wrote: > > From: Marek Vasut > > In case U-Boot starts with GD_FLG_SKIP_RELOC, the U-Boot code is > not relocated, however the stack and heap is at the end of DRAM > after relocation. Reserve a LMB area for the non-relocated U-Boot > code so it won't be overwritten.

Re: [RFC PATCH 06/23] sunxi: Skip non-DM UART pin setup when PINCTRL=y

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 22:55, Samuel Holland wrote: > > When a pinctrl driver is available, it will take care of setting up > these pins. However, for now this code is still needed in SPL. > > Signed-off-by: Samuel Holland > --- > > arch/arm/mach-sunxi/board.c | 2 ++ > 1 file changed, 2

Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults

2021-10-24 Thread Sean Anderson
On 10/14/21 10:19 PM, Simon Glass wrote: Hi Peng, Sean, On Thu, 14 Oct 2021 at 19:17, Peng Fan wrote: Subject: Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults On 10/13/21 5:37 AM, Peng Fan (OSS) wrote: From: Peng Fan Current code has a force clk_set_defaults in multiple stages,

RE: [PATCH next v7 06/12] clk: ast2600: Add RSACLK control for ACRY

2021-10-24 Thread ChiaWei Wang
> From: Joel Stanley > Sent: Thursday, October 21, 2021 8:08 AM > > On Wed, 20 Oct 2021 at 02:50, Chia-Wei Wang > wrote: > > > > Add RSACLK enable for ACRY, the HW RSA/ECC crypto engine of ASPEED > > AST2600 SoCs. > > > > As ACRY and HACE share the same reset control bit, we do not perform > >

Re: [PATCH 3/4] power: axp: Avoid do_poweroff conflict with sysreset

2021-10-24 Thread Samuel Holland
On 10/24/21 7:38 PM, Andre Przywara wrote: > On Sun, 22 Aug 2021 18:18:05 -0500 > Samuel Holland wrote: > > Hi Samuel, > >> The sysreset uclass has an option to provide the do_poweroff() function. >> When that option is enabled, the AXP power drivers should not provide >> their own definition.

Re: [PATCH v4 05/11] tools: mkeficapsule: add firmwware image signing

2021-10-24 Thread AKASHI Takahiro
Hi, Masami, On Wed, Oct 20, 2021 at 05:17:12PM +0900, Masami Hiramatsu wrote: > Hello Akashi-san, > > Can you split this patch out from this series? > It seems that the series is doing several different things. This > capsule signing has no alternatives, but others are modifying or > replacing

Re: [PATCH 1/1] smbios: amend the description of smbios_string()

2021-10-24 Thread Simon Glass
Hi Heinrich, On Thu, 21 Oct 2021 at 03:16, Heinrich Schuchardt wrote: > > Add a warning that this function only works for strings preceding the first > non-string field. What is a non-string field? If you mean an int field, for example, then that would not have an entry in the string table, so

Re: [PATCH 1/1 RFC] treewide: Deprecate OF_PRIOR_STAGE

2021-10-24 Thread Simon Glass
Hi Thomas, On Fri, 15 Oct 2021 at 10:19, Thomas Fitzsimmons wrote: > > Hi Tom, > > Tom Rini writes: > > > On Wed, Oct 13, 2021 at 01:36:00PM -0400, Thomas Fitzsimmons wrote: > >> Simon Glass writes: > >> > >> [...] > >> > >> > On Wed, 13 Oct 2021 at 10:26, Thomas Fitzsimmons > >> > wrote: >

Re: [PATCH v6 2/2] board: kontron: pitx-imx8m: Add Kontron pitx-imx8m board support

2021-10-24 Thread Simon Glass
Hi Heiko, On Fri, 22 Oct 2021 at 11:54, Heiko Thiery wrote: > > Hi Simon, > > Am Fr., 22. Okt. 2021 um 18:07 Uhr schrieb Simon Glass : > > > > Hi Heiko, > > > > On Fri, 22 Oct 2021 at 07:24, Heiko Thiery wrote: > > > > > > Hi, > > > > > > Am Fr., 22. Okt. 2021 um 14:37 Uhr schrieb Stefano Babic

Re: [PATCH v2] board_f: Copy GD to new GD even if relocation disabled

2021-10-24 Thread Simon Glass
On Fri, 15 Oct 2021 at 09:48, wrote: > > From: Marek Vasut > > Even if U-Boot has relocation disabled via GD_FLG_SKIP_RELOC , the > relocated stage of U-Boot still picks GD from new_gd location. The > U-Boot itself is not relocated, but GD might be, so copy the GD to > new GD location even if

Re: [PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2021-10-24 Thread Simon Glass
Hi Andy, On Wed, 20 Oct 2021 at 06:37, Andy Shevchenko wrote: > > The dsdt.asl is usually combined out of several files that are included > in the main one. Whenever we change the content of any of such files, > build system is not able to recognize them. Hence the easiest way is to > force DSDT

RE: [PATCH next v7 04/12] crypto: aspeed: Add AST2600 HACE support

2021-10-24 Thread ChiaWei Wang
> From: U-Boot On Behalf Of ChiaWei Wang > Sent: Thursday, October 21, 2021 9:57 AM > > > From: Dhananjay Phadke > > Sent: Thursday, October 21, 2021 9:33 AM > > > > On Wed, 20 Oct 2021, Chia-Wei Wang wrote: > > > > > +static const struct hash_ops aspeed_hace_ops = { > > > + .hash_init =

Re: [PATCH v2 2/2] pxe_utils: Clean up {bootm,zboot}_argv generation

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 01:18, Zhaofeng Li wrote: > > Signed-off-by: Zhaofeng Li > Cc: Simon Glass > Cc: Bin Meng > --- > cmd/pxe_utils.c | 45 +++-- > 1 file changed, 27 insertions(+), 18 deletions(-) > Reviewed-by: Simon Glass But please add a

Re: [PATCH 0/2] add selftest for EFI_TCG2_PROTOCOL and Measured Boot

2021-10-24 Thread Simon Glass
Hi Masahisa, On Fri, 22 Oct 2021 at 05:23, Masahisa Kojima wrote: > > This patch series adds the selftest for the EFI_TCG2_PROTOCOL and > Measured Boot flow. > This selftest is verified on qemu with swtpm. Is this in CI? Where are the instructions for doing this? I have expressed my preference

Re: [RFC PATCH 04/23] sunxi: pinctrl: Implement pin configuration

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 22:55, Samuel Holland wrote: > > The sunxi pinctrl hardware has bias and drive control. Add driver > support for configuring those options. > > Signed-off-by: Samuel Holland > --- > > drivers/pinctrl/sunxi/Kconfig | 1 + > drivers/pinctrl/sunxi/pinctrl-sunxi.c |

Re: [PATCH] arm64: zynqmp: Replace comma by semicolon

2021-10-24 Thread Simon Glass
On Thu, 21 Oct 2021 at 00:59, Michal Simek wrote: > > Fix issue reported by checkpatch.pl > > WARNING: Possible comma where semicolon could be used > #499: FILE: board/xilinx/zynqmp/zynqmp.c:499: > + size = ALIGN(CONFIG_SYS_MALLOC_LEN + total_size, MMU_SECTION_SIZE), > + reg =

Re: [PATCH] gpio: stm32: create include file for driver private data

2021-10-24 Thread Simon Glass
On Fri, 22 Oct 2021 at 12:12, Patrick Delaunay wrote: > > The stm32 gpio driver private data are not needed in arch include files, > they are not used by code except for stm32 gpio and pincontrol drivers, > using the same IP; the defines for this IP is moved in a new file > "stm32_gpio_priv.h" in

Re: [PATCH 3/4] gpio: sunxi: Implement .set_flags

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 22:53, Samuel Holland wrote: > > This, along with gpio_flags_xlate(), allows the GPIO driver to handle > pull-up/down flags provided by consumer drivers or in the device tree. > > Signed-off-by: Samuel Holland > --- > > drivers/gpio/sunxi_gpio.c | 62

Re: [PATCH v2] part: return -ENOSYS when get_info not valid.

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 06:16, schspa wrote: > > In some case, get_info() interface can be NULL, add this check to stop > from crash. > > Signed-off-by: schspa > --- > disk/part.c | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-10-24 Thread Simon Glass
Hi, On Wed, 20 Oct 2021 at 01:17, Rasmus Villemoes wrote: > > On 20/08/2021 20.18, Simon Glass wrote: > > Hi Harm, > > > > On Wed, 18 Aug 2021 at 08:09, Harm Berntsen wrote: > >> > >> On Thu, 2021-05-13 at 19:39 -0600, Simon Glass wrote: > >>> int clk_uclass_post_probe(struct udevice *dev) >

[PATCH v2 4/4] power: pmic: axp: Implement poweroff via sysreset

2021-10-24 Thread Samuel Holland
The AXP PMICs have the ability to power off the system. The existing code for this is duplicated for each PMIC variant, and uses the legacy non-DM "pmic_bus" interface. When SYSRESET is enabled, this can all be replaced with a sysreset device using the DM_PMIC interface. Since the trigger bit is

[PATCH v2 2/4] include: axp_pmic: Include headers for all variants

2021-10-24 Thread Samuel Holland
A single DM-based driver should be able to support some feature for several PMIC variants where the interface is the same. For example, all PMIC variants use the same register bit to trigger poweroff. However, currently only definitions for a single PMIC are available at a time. This requires

[PATCH v2 3/4] power: axp: Avoid do_poweroff conflict with sysreset

2021-10-24 Thread Samuel Holland
The sysreset uclass has an option to provide the do_poweroff() function. When that option is enabled, the AXP power drivers should not provide their own definition. For the AXP305, which is paired with 64-bit systems where TF-A provides PSCI, there is another possible conflict with the PSCI

[PATCH v2 1/4] include: axp_pmic: Add missing header guard definition

2021-10-24 Thread Samuel Holland
This header attempted to avoid multiple inclusion using a header guard. But the preprocessor symbol was never defined, so the guard had no effect. Fix this by defining the symbol. Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara --- (no changes since v1) include/axp_pmic.h | 1 + 1

Re: [PATCH] introduce CONFIG_DEVICE_TREE_INCLUDES

2021-10-24 Thread Simon Glass
Hi Roman, On Tue, 28 Sept 2021 at 03:55, Roman Kopytin wrote: > > Hi, all > I prepared 3 patches for fdt_add_pubkey adding. > But in our company infrastructure I can't use git send-email. Our IT can't > help me to resolve issue. > I suppose I should point out that the Internet does normally

Re: [PATCH] lib: rsa: rsa-verify: also check that padding is not NULL

2021-10-24 Thread Simon Glass
On Fri, 15 Oct 2021 at 03:28, Philippe Reynes wrote: > > This commit adds a check on the padding in the function rsa_verify_key > to avoid using a NULL pointer. > > Signed-off-by: Philippe Reynes > --- > lib/rsa/rsa-verify.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] clk: introduce u-boot,ignore-clk-defaults

2021-10-24 Thread Simon Glass
Hi Peng, On Fri, 15 Oct 2021 at 02:58, Peng Fan (OSS) wrote: > > Simon, > > On 2021/10/14 23:11, Simon Glass wrote: > > On Wed, 13 Oct 2021 at 03:00, Peng Fan (OSS) wrote: > >> > >> From: Peng Fan > >> > >> Current code has a force clk_set_defaults in multiple stages, > >> U-Boot reuse the

Re: [PATCH] fit: display proper node on error

2021-10-24 Thread Simon Glass
Hi Alex, On Wed, 6 Oct 2021 at 10:00, Alex G. wrote: > > + Simon > > On 10/6/21 10:47 AM, Angelo Dureghello wrote: > > Fix final error message from > > > > Verification failed for '' hash node in 'conf@1' config node > > > > to > > > > Verification failed for 'signature@1' hash node in 'conf@1'

Re: [PATCH 15/16] fdt: Make OF_BOARD a bool option

2021-10-24 Thread Simon Glass
Hi Sean, On Wed, 13 Oct 2021 at 11:30, Sean Anderson wrote: > > On 10/13/21 12:58 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 12 Oct 2021 at 22:22, Heinrich Schuchardt > > wrote: > >> > >> > >> > >> On 10/13/21 03:01, Simon Glass wrote: > >>> This should not be a separate option

Re: [PATCH next v7 01/12] image: fit: Fix parameter name for hash algorithm

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 20:23, ChiaWei Wang wrote: > > > From: Joel Stanley > > Sent: Thursday, October 21, 2021 8:08 AM > > > > On Wed, 20 Oct 2021 at 02:49, Chia-Wei Wang > > wrote: > > > > > > Fix inconsistent function parameter name of the hash algorithm. > > > > > > Signed-off-by: Chia-Wei

Re: [PATCH] common: Kconfig.boot: add config SPL_FIT_RSASSA_PSS

2021-10-24 Thread Simon Glass
On Fri, 15 Oct 2021 at 03:35, Philippe Reynes wrote: > > The padding pss is only supported on u-boot and tools since > commit 2bbed3ff8c7f ("image: Use Kconfig to enable FIT_RSASSA_PSS on host") > > This commit adds the config SPL_FIT_RSASSA_PSS to support > the padding pss in the SPL. > >

Re: [PATCH v10 8/9] sandbox: Update the test MAC/IP addresses

2021-10-24 Thread Tom Rini
On Sun, Oct 24, 2021 at 01:54:17PM -0600, Simon Glass wrote: > Hi Heinrich, > > On Sat, 23 Oct 2021 at 02:30, Heinrich Schuchardt wrote: > > > > > > > > On 10/22/21 05:08, Simon Glass wrote: > > > These conflict with real-word addresses. Use locally administered > > > MAC addresses and a

Re: [PATCH 4/4] power: pmic: axp: Implement poweroff via sysreset

2021-10-24 Thread Andre Przywara
On Sun, 22 Aug 2021 18:18:06 -0500 Samuel Holland wrote: Hi Samuel, > The AXP PMICs have the ability to power off the system. The existing > code for this is duplicated for each PMIC variant, and uses the legacy > non-DM "pmic_bus" interface. When SYSRESET is enabled, this can all be > replaced

Re: [PATCH 2/4] include: axp_pmic: Include headers for all variants

2021-10-24 Thread Andre Przywara
On Sun, 22 Aug 2021 18:18:04 -0500 Samuel Holland wrote: > A single DM-based driver should be able to support some feature for > several PMIC variants where the interface is the same. For example, > all PMIC variants use the same register bit to trigger poweroff. > > However, currently only

Re: [PATCH 3/4] power: axp: Avoid do_poweroff conflict with sysreset

2021-10-24 Thread Andre Przywara
On Sun, 22 Aug 2021 18:18:05 -0500 Samuel Holland wrote: Hi Samuel, > The sysreset uclass has an option to provide the do_poweroff() function. > When that option is enabled, the AXP power drivers should not provide > their own definition. > > For the AXP305, which is paired with 64-bit systems

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-10-24 Thread Rick Chen
Hi Bin, > From: Bin Meng > Sent: Tuesday, October 19, 2021 4:55 PM > To: Alexandre Ghiti > Cc: Heinrich Schuchardt ; Tom Rini > ; Leo Yu-Chi Liang(梁育齊) ; Rick > Jian-Zhi Chen(陳建志) ; Pragnesh Patel > ; Dimitri John Ledkov > ; Zong Li ; Green Wan > ; U-Boot Mailing List > Subject: Re:

[PATCH v2 0/4] power: axp: Move poweroff to DM_PMIC/SYSRESET driver

2021-10-24 Thread Samuel Holland
This series replaces the do_poweroff() implementation from the non-DM AXP PMIC drivers with a sysreset uclass device, if sysreset is providing its own do_poweroff() definition. After applying this series, plus the following additional series:

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-10-24 Thread Bin Meng
Hi Rick, On Mon, Oct 25, 2021 at 9:49 AM Rick Chen wrote: > > Hi Bin, > > > From: Bin Meng > > Sent: Tuesday, October 19, 2021 4:55 PM > > To: Alexandre Ghiti > > Cc: Heinrich Schuchardt ; Tom Rini > > ; Leo Yu-Chi Liang(梁育齊) ; Rick > > Jian-Zhi Chen(陳建志) ; Pragnesh Patel > > ; Dimitri John

Re: [PATCH 1/1] board: sifive: unmatched: enlarge CONFIG_SYS_SPL_MALLOC_SIZE

2021-10-24 Thread Rick Chen
Hi, Bin > Hi Rick, > > On Mon, Oct 25, 2021 at 9:49 AM Rick Chen wrote: > > > > Hi Bin, > > > > > From: Bin Meng > > > Sent: Tuesday, October 19, 2021 4:55 PM > > > To: Alexandre Ghiti > > > Cc: Heinrich Schuchardt ; Tom Rini > > > ; Leo Yu-Chi Liang(梁育齊) ; Rick > > > Jian-Zhi Chen(陳建志) ;

Re: [PATCH v4 04/11] tools: add fdtsig.sh

2021-10-24 Thread AKASHI Takahiro
Simon, On Thu, Oct 14, 2021 at 06:40:24PM -0600, Simon Glass wrote: > Hi Takahiro, > > On Mon, 11 Oct 2021 at 19:42, AKASHI Takahiro > wrote: > > > > Simon, > > > > On Mon, Oct 11, 2021 at 08:54:09AM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Thu, 7 Oct 2021 at 00:25, AKASHI

Re: [PATCH v4 03/11] efi_loader: capsule: add back efi_get_public_key_data()

2021-10-24 Thread AKASHI Takahiro
On Wed, Oct 20, 2021 at 07:39:37AM -0600, Simon Glass wrote: > Hi Masami, > > On Wed, 20 Oct 2021 at 02:18, Masami Hiramatsu > wrote: > > > > Hi Simon, > > > > 2021年10月15日(金) 9:40 Simon Glass : > > > > > > Hi Takahiro, > > > > > > On Thu, 7 Oct 2021 at 00:25, AKASHI Takahiro > > > wrote: > > >

Re: [PATCH 1/2] cmd: kaslrseed: add command to generate value from hwrng

2021-10-24 Thread Simon Glass
Hi, On Fri, 15 Oct 2021 at 23:48, Heinrich Schuchardt wrote: > > Am 15. Oktober 2021 14:54:03 MESZ schrieb Kever Yang > : > >Reviewed-by: Kever Yang > > > > > >Thanks, > >- Kever > > > >Chris Morgan 于2021年8月26日周四 上午12:23写道: > >> > >> From: Chris Morgan > >> > >> Allow the kaslr-seed value in

Re: [PATCH] cmd: pxe_utils: Check fdtcontroladdr in label_boot

2021-10-24 Thread Simon Glass
Hi, On Fri, 15 Oct 2021 at 05:21, Andre Przywara wrote: > > On Thu, 14 Oct 2021 12:24:45 -0600 > Simon Glass wrote: > > Hi Simon, > > > On Thu, 14 Oct 2021 at 02:40, Peter Hoyes wrote: > > > > > > From: Peter Hoyes > > > > > > If using OF_CONTROL, fdtcontroladdr is set to the fdt used to

Re: uboot FIT signature difference

2021-10-24 Thread Simon Glass
Hi Frank, On Sun, 10 Oct 2021 at 11:51, Frank Wunderlich wrote: > > Hi, > > i try to create a upstream uboot binary for use with rockchip rk3568 > (bananapi r2 pro). Currently i'm on preparation phase as i don't have the > hardware yet (so i cannot test it). > > First thanks to everybody

Re: [PATCH v6 7/7] bootm: Tidy up use of autostart env var

2021-10-24 Thread Simon Glass
Hi Wolfgang, On Fri, 15 Oct 2021 at 08:45, Wolfgang Denk wrote: > > Dear Simon Glass, > > In message <20211014182257.468649-6-...@chromium.org> you wrote: > > This has different semantics in different places. Go with the bootm method > > and put it in a common function so that the behaviour is

Re: [PATCH v2 1/2] pxe_utils: Fix arguments to x86 zboot

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 01:18, Zhaofeng Li wrote: > > bootm and zboot accept different arguments: > > > bootm [addr [arg ...]] > >- boot application image stored in memory > >passing arguments 'arg ...'; when booting a Linux kernel, > >'arg' can be the address of an initrd

Re: [PATCH v1 1/1] x86: tangier: Replace Method() by Name() for _STA object

2021-10-24 Thread Simon Glass
On Wed, 20 Oct 2021 at 06:51, Andy Shevchenko wrote: > > There is no point to use Method() for the constant. > Replace it with Name() defined object. For the _STA > case it saves 3 bytes per each entry. > > Before: 2881 > After: 2833 > > Signed-off-by: Andy Shevchenko > --- >

Re: [PATCH v2 4/9] usb: common: silence dubious errors

2021-10-24 Thread Simon Glass
On Fri, 15 Oct 2021 at 07:15, Michael Walle wrote: > > Both dr_mode and maximum-speed properties are usually optional. Drivers > will still try to fetch the properties nonetheless, which leads to error > messages, although they are no errors. Change pr_err() to pr_debug(). > > Signed-off-by:

Re: [PATCH v2 2/9] test: dm: add test for ofnode_for_each_compatible_node()

2021-10-24 Thread Simon Glass
On Fri, 15 Oct 2021 at 07:15, Michael Walle wrote: > > Check that all matching nodes have the correct compatible and that there > is at least one match. > > Signed-off-by: Michael Walle > --- > test/dm/ofnode.c | 18 ++ > 1 file changed, 18 insertions(+) > Reviewed-by: Simon

Re: [PATCH v2] bootstage: Add SPL support

2021-10-24 Thread Marek Vasut
On 10/24/21 9:54 PM, Simon Glass wrote: On Fri, 22 Oct 2021 at 19:06, Marek Vasut wrote: Allow usage of the bootstage facilities in SPL. Signed-off-by: Marek Vasut Cc: Simon Glass --- V2: Fix multiple misuses of BOOTSTAGE vs SHOW_BOOT_PROGRESS --- arch/x86/cpu/cpu.c| 2 +-

[RFC PATCH 3/5] Set HVBAR register correctly

2021-10-24 Thread Jim Posen
This is the base address register for the vector table when in hypervisor mode. Signed-off-by: Jim Posen --- arch/arm/cpu/armv7/start.S | 5 + arch/arm/lib/relocate.S| 8 2 files changed, 13 insertions(+) diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S

[RFC PATCH 5/5] Fix PC adjustment logic in exception handlers

2021-10-24 Thread Jim Posen
The link register is at a different offset depending on processor mode, so ensure it applies the correct adjustment. Signed-off-by: Jim Posen --- arch/arm/include/asm/u-boot-arm.h | 14 +++--- arch/arm/lib/interrupts.c | 26 +- arch/arm/lib/vectors.S

[RFC PATCH 2/5] Hypervisor mode interrupt vector table

2021-10-24 Thread Jim Posen
Create separate vector table for exceptions taken to PL2, which happens when U-Boot is running in hypervisor mode. The handler logic is different enough that a separate vector table is the simplest way to handle it. Signed-off-by: Jim Posen --- arch/arm/lib/vectors.S | 95

[RFC PATCH 1/5] Compile for ARMv7-A with virtualization extensions

2021-10-24 Thread Jim Posen
In order to assemble instructions that read the ELR_hyp register, which is part of the ARMv7-A virtualization extensions, the assembler target architecture needs to be changed. Signed-off-by: Jim Posen --- arch/arm/Makefile | 4 arch/arm/mach-bcm283x/Kconfig | 3 +++

[RFC PATCH 4/5] Remove dead code

2021-10-24 Thread Jim Posen
This code was missed in commit 01abae4d0486 ("Remove various unused interrupt related code") Signed-off-by: Jim Posen --- arch/arm/lib/vectors.S | 32 +--- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S

[RFC PATCH 0/5] Exception handling in HYP mode on ARMv7-A

2021-10-24 Thread Jim Posen
Currently, when U-Boot is running in hypervisor mode on ARMv7-A CPUs with virtualization extensions, the exception handling does not work. A couple things need to change which are detailed in my earlier message to the u-boot mailing list with the subject "Exception handling in HYP mode on

Re: [PATCH 1/4] include: axp_pmic: Add missing header guard definition

2021-10-24 Thread Andre Przywara
On Sun, 22 Aug 2021 18:18:03 -0500 Samuel Holland wrote: > This header attempted to avoid multiple inclusion using a header guard. > But the preprocessor symbol was never defined, so the guard had no > effect. Fix this by defining the symbol. > > Signed-off-by: Samuel Holland Reviewed-by:

RE: [PATCH next v7 00/12] aspeed: Support secure boot chain with FIT image verification

2021-10-24 Thread ChiaWei Wang
Thank you all for the review comments and tags. I will prepare the v8 patch with tag included and comments addressed. In addition, as DM_HASH has been merged into the master branch. The v8 patch will be rebased on the master branch. Thanks, Chiawei > From: U-Boot On Behalf Of Chia-Wei Wang >

Re: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset

2021-10-24 Thread Michael Walle
>On Mon, Sep 13, 2021 at 01:22:10PM +0530, Rayagonda Kokatanur wrote: >> On Mon, Sep 13, 2021 at 11:29 AM Priyanka Jain (OSS) >> wrote: .. >> > Tom, >> > >> > I agree that bindings patch is essential for device-tree changes. >> > But merging this patch will break Layerscape Platforms. >> > We

Re: [PATCH v2 2/2] cmd: brcm: netXtreme commands

2021-10-24 Thread Simon Glass
On Fri, 22 Oct 2021 at 17:17, Roman Bacik wrote: > > From: Bharat Gooty > > Following netXtreme commands are supported:- > Device probe, remove, supported speeds, get/set speeds and > get/set MAC address. > > Signed-off-by: Bharat Gooty > > Signed-off-by: Roman Bacik > --- > > (no changes

Re: [PATCH v2] bootstage: Add SPL support

2021-10-24 Thread Simon Glass
On Fri, 22 Oct 2021 at 19:06, Marek Vasut wrote: > > Allow usage of the bootstage facilities in SPL. > > Signed-off-by: Marek Vasut > Cc: Simon Glass > --- > V2: Fix multiple misuses of BOOTSTAGE vs SHOW_BOOT_PROGRESS > --- > arch/x86/cpu/cpu.c| 2 +- >

Re: [PATCH v10 8/9] sandbox: Update the test MAC/IP addresses

2021-10-24 Thread Simon Glass
Hi Heinrich, On Sat, 23 Oct 2021 at 02:30, Heinrich Schuchardt wrote: > > > > On 10/22/21 05:08, Simon Glass wrote: > > These conflict with real-word addresses. Use locally administered > > MAC addresses and a suitable IPv4 address from 192.0.2.0/24 > > (TEST-NET-1). > > > > Signed-off-by: Simon

Re: [PATCH] patman: Add "postfix" support to patch subjects

2021-10-24 Thread Simon Glass
On Fri, 22 Oct 2021 at 17:07, Sean Anderson wrote: > > In some communities, it may be necessary to append something after PATCH > in the subject line. For example, the Linux networking subsystem > expects [1] patch subject prefixes like [RFC PATCH net-next 0/99]. This > adds support for such

Re: [PATCH 1/1] blk: simplify blk_get_devnum_by_typename()

2021-10-24 Thread Simon Glass
Hi Heinrich, On Sat, 23 Oct 2021 at 08:06, Heinrich Schuchardt wrote: > > The block descriptor contains the if_type. There is no need to first look > up the uclass for the if_type and then to check the parent device's uclass > to know if the device has the correct if_type. > > Signed-off-by:

Re: [PATCH v2] imx8mm_beacon: Switch to binman for generating image

2021-10-24 Thread Simon Glass
On Fri, 22 Oct 2021 at 15:49, Marcel Ziswiler wrote: > > From: Adam Ford > > To eliminate a warning when using custom imx tools for generating > a binary, use binman to generate flash.bin. > > Signed-off-by: Adam Ford > Signed-off-by: Marcel Ziswiler > > --- > Note that this re-base is only

Re: [PATCH v4 05/11] tools: mkeficapsule: add firmwware image signing

2021-10-24 Thread Masami Hiramatsu
Hi Takahiro, 2021年10月25日(月) 12:12 AKASHI Takahiro : > > Hi, Masami, > > On Wed, Oct 20, 2021 at 05:17:12PM +0900, Masami Hiramatsu wrote: > > Hello Akashi-san, > > > > Can you split this patch out from this series? > > It seems that the series is doing several different things. This > > capsule