Re: [PATCH v3 05/11] rockchip: rock5a-rk3588s: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:16, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

Re: [PATCH v3 04/11] rockchip: quartzpro64-rk3588: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:16, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

Re: [PATCH v3 03/11] rockchip: nanopc-t6-rk3588: use DRAM banks from ATAGS

2024-04-22 Thread Kever Yang
On 2024/4/15 22:16, Quentin Schulz wrote: From: Quentin Schulz RK3588-based devices now support creating DRAM banks with proper holes by reading the ATAGS from Rockchip TPL blob, so let's use that mechanism instead. Since ft_board_setup isn't defined anymore, there's no need for selecting

Re: [PATCH v3 02/11] rockchip: NR_DRAM_BANKS now defaults to 10 when Rockchip TPL blob is used

2024-04-22 Thread Kever Yang
On 2024/4/15 22:16, Quentin Schulz wrote: From: Quentin Schulz When Rockchip TPL blob is used, the memory areas that can be used for DRAM is gotten from ATAGS passed through the DRAM at a specific address. The DDR_MEM tag contains at most 10 areas, so we should default to 10 if Rockchip TPL

Re: [PATCH v3 01/11] rockchip: sdram: Support getting banks from TPL for rk3568 and rk3588

2024-04-22 Thread Kever Yang
On 2024/4/15 22:16, Quentin Schulz wrote: From: Quentin Schulz Allow RK3568 and RK3588 based boards to get the RAM bank configuration from the ROCKCHIP_TPL stage instead of the current logic. This fixes both an issue where 256MB of RAM is blocked for devices with >= 4GB of RAM and where

Re: [PATCH] board: rk3288: simplify the DT file list in MAINTAINERS

2024-04-22 Thread Kever Yang
On 2024/4/18 15:06, Dragan Simic wrote: Use a wildcard to simplify the list of board DT files in the MAINTAINERS file for the Radxa Rock 2 Square board. Signed-off-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- board/radxa/rock2/MAINTAINERS | 4 +--- 1 file changed, 1

Re: [PATCH v2 3/3] rockchip: io-domain: Add support for RK3328

2024-04-22 Thread Kever Yang
On 2024/4/22 04:09, Jonas Karlman wrote: Port the RK3328 part of the Rockchip IO-domain driver from linux. This differs from linux version in that pmu io iodomain bit is enabled in the write ops instead of in an init ops as in linux, this way we can avoid keeping a full state of all supply

Re: [PATCH v2 2/3] rockchip: rk3328: Enable ARMv8 crypto extensions

2024-04-22 Thread Kever Yang
On 2024/4/22 04:09, Jonas Karlman wrote: The RK3328 SoC support ARMv8 Cryptography Extensions and use of the ARMv8 crypto extensions help speed up FIT checksum validation in SPL. Imply ARMV8_SET_SMPEN and ARMV8_CRYPTO to take advantage of the crypto extensions for SHA256 when validating

Re: [PATCH v2 1/3] rockchip: rk3328: Sort imply statements alphabetically

2024-04-22 Thread Kever Yang
On 2024/4/22 04:09, Jonas Karlman wrote: Sort imply statements under ROCKCHIP_RK3328 alphabetically and remove ENABLE_ARM_SOC_BOOT0_HOOK, DEBUG_UART_BOARD_INIT and SYS_NS16550, they are already implyed or selected by ARCH_ROCKCHIP. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang

Re: [PATCH] rockchip: rk3328: Fix bootph prop for vop node

2024-04-22 Thread Kever Yang
On 2024/4/22 04:12, Jonas Karlman wrote: The vop node should not be included in TPL/SPL control FDT, it should only be included at U-Boot proper pre-reloc phase. Change to use bootph-some-ram prop to fix this. Fixes: 6794063d5065 ("ARM: dts: rk3328: Enable VOP for bootph-all") Signed-off-by:

Re: [PATCH v3 28/28] rockchip: rk35xx-generic: Disable unused features

2024-04-22 Thread Kever Yang
On 2024/4/22 14:29, Jonas Karlman wrote: The generic RK35xx board targets are intended to be used as a bare minimum target that can be used to e.g. boot boards that mostly follow reference hw design before a board spefic target has been added or for flashing and recovery purposes. Disable

Re: [PATCH v3 27/28] rockchip: rk3588-generic: Add support for USB OTG

2024-04-22 Thread Kever Yang
On 2024/4/22 14:29, Jonas Karlman wrote: Add support for USB OTG, RockUSB and UMS to the generic RK3588S/RK3588 target. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: No change v2: Split patch --- arch/arm/dts/rk3588-generic-u-boot.dtsi | 22

Re: [PATCH v3 26/28] rockchip: rk3588-generic: Use M0 iomux for UART2

2024-04-22 Thread Kever Yang
On 2024/4/22 14:29, Jonas Karlman wrote: The default pinctrl for UART2 is using M1 iomux, however, all other supported RK3588 boards in U-Boot use M0 iomux for UART2. Change to use the M0 pinctrl for UART2 to match other supported boards. Fixes: b54c3d0dd69b ("rockchip: board: Add minimal

Re: [PATCH v3 25/28] rockchip: rk356x-generic: Add support for USB OTG

2024-04-22 Thread Kever Yang
On 2024/4/22 14:29, Jonas Karlman wrote: Add support for USB OTG, RockUSB and UMS to the generic RK3566/RK3568 target. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: No change v2: Split patch --- arch/arm/dts/rk3568-generic.dts | 19 ++-

Re: [PATCH v3 24/28] rockchip: rk356x-generic: Add support for SPI flash

2024-04-22 Thread Kever Yang
On 2024/4/22 14:29, Jonas Karlman wrote: Add support for booting from SPI flash using the generic RK3566/RK3568 target. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: No change v2: Split patch --- arch/arm/dts/rk3568-generic-u-boot.dtsi | 7 +++

Re: [PATCH v3 23/28] rockchip: rk356x-generic: Fix eMMC and SD-card pinctrl

2024-04-22 Thread Kever Yang
On 2024/4/22 14:29, Jonas Karlman wrote: Add missing emmc_datastrobe and sdmmc0_det pinctrl to fix possible issue reading from eMMC or SD-card. Also use correct node for mmc1 alias. Fixes: 683f61a13f16 ("rockchip: board: Add minimal generic RK3566/RK3568 board") Fixes: 363cbd578169

Re: [PATCH v3 22/28] rockchip: rk3588-edgeble-neu6: Enable FIT checksum validation

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Enable SPL_FIT_SIGNATURE=y and LEGACY_IMAGE_FORMAT=y to validate FIT images checksum in SPL. Change to SPL_MAX_SIZE=0x4 to allow SPL up to 256 KiB in size. Enable SPL_DM_SEQ_ALIAS=y and SPL_PINCTRL=y to ensure eMMC and SD-card pinctrl is

Re: [PATCH v3 21/28] rockchip: rk3588-turing-rk1: Use dwc3-generic driver

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: RK35xx boards are expected to use the dwc3-generic driver and not the xhci-dwc3 driver. Remove the USB_XHCI_DWC3 option to ensure that the dwc3-generic driver is used. Fixes: 153ac950a599 ("board: rockchip: Add the Turing RK1 SoM") Signed-off-by:

Re: [PATCH v3 20/28] rockchip: rk3588-toybrick: Add .dtb-file entry in Makefile

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Add Rockchip Toybrick TB-RK3588X .dtb-file entry in Makefile. Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- v3: New patch split from

Re: [PATCH v3 19/28] rockchip: rk3588-toybrick: Use pinctrl and aliases in SPL

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Pinctrl must be configured for eMMC, SD-card and SPI flash to successfully read FIT from all possible fallback media in SPL. Include pinctrl props and enable the SPL_PINCTRL Kconfig option to ensure FIT can be loaded from eMMC, SD-card and SPI flash.

Re: [PATCH v3 18/28] rockchip: rk3588-coolpi: Fix .dtb-file entries in Makefile

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Fix CoolPi 4 Model B and CoolPi CM5 EVB .dtb-file entries in Makefile. Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based Cool Pi CM5 EVB") Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, -

Re: [PATCH v3 17/28] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the documentation. Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based Cool Pi CM5 EVB") Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, -

Re: [PATCH v3 16/28] rockchip: rk3566-pinetab2: Fix reading FIT from SPI flash

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: The SF_DEFAULT_SPEED Kconfig option got lost during merge and this prevent reading FIT from SPI flash. Restore the SF_DEFAULT_SPEED option to fix this. Fixes: 8a94c376f6cb ("rockchip: Use common bss and stack addresses on RK356x") Signed-off-by: Jonas

Re: [PATCH v3 15/28] rockchip: rk3588-evb: Use pinctrl and aliases in SPL

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Pinctrl must be configured for eMMC, SD-card and SPI flash to successfully read FIT from all possible fallback media in SPL. Include pinctrl props and enable the SPL_PINCTRL Kconfig option to ensure FIT can be loaded from eMMC, SD-card and SPI flash.

Re: [PATCH v3 14/28] rockchip: rk3568-evb: Use pinctrl in SPL

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Pinctrl must be configured for eMMC, SD-card and SPI flash to successfully read FIT from all possible fallback media in SPL. Include pinctrl props and enable the SPL_PINCTRL Kconfig option to ensure FIT can be loaded from eMMC, SD-card and SPI flash.

Re: [PATCH v3 13/28] rockchip: rk3588: Update bootph props

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: After the commit aca95282c1b7 ("Makefile: Use the fdtgrep -u flag") bootph props is propagating to parent nodes. Update bootph props to ensure eMMC, SD-card and SPI flash is available in SPL and U-Boot proper pre-reloc phase also remove unneeded bootph

Re: [PATCH v3 12/28] rockchip: rk356x: Update bootph props

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: After the commit aca95282c1b7 ("Makefile: Use the fdtgrep -u flag") bootph props is propagating to parent nodes. Update bootph props to ensure eMMC, SD-card and SPI flash is available in SPL and U-Boot proper pre-reloc phase also remove unneeded bootph

Re: [PATCH v3 11/28] rockchip: rk35xx: Sort soc u-boot.dtsi alphabetically

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Sort nodes and props in RK356x/RK3588 u-boot.dtsi alphabetically, nodes is sorted by reg addr then by alphabetical order. This has no intended change beside sorting existing nodes and removing a duplicated usbdpphy0_grf node. Signed-off-by: Jonas

Re: [PATCH v3 10/28] rockchip: rk356x: Imply enhanced features for standard boot

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Imply BOOTSTD_FULL for all RK356x boards to more closely follow RK3588. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2: No change --- arch/arm/mach-rockchip/Kconfig

Re: [PATCH v3 09/28] rockchip: rk35xx: Imply support for GbE PHY

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Imply support for GbE PHY status parsing and configuration when support for onboard ethernet is enabled. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect

Re: [PATCH v3 08/28] rockchip: rk35xx: Enable random generator

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: The RK35xx SoCs contain a crypto engine block that can generate random numbers. Enable rng node in soc u-boot.dtsi and enable Kconfig options to take advantage of the random generator. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic

Re: [PATCH v3 07/28] rockchip: rk35xx: Sort imply statements alphabetically

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: Sort imply statements under ROCKCHIP_RK3568 and ROCKCHIP_RK3588 alphabetically. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2: No change ---

Re: [PATCH v3 06/28] rockchip: rk3566-anbernic-rgxx3: Remove SPL_ROCKCHIP_BACK_TO_BROM option

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: SPL_ROCKCHIP_BACK_TO_BROM should normally only be enabled when BROM should load U-Boot binary. SPL on Anbernic RGxx3 devices load TF-A and U-Boot proper from FIT images and does never jump back to BROM from SPL. Remove the superfluous Kconfig option

Re: [PATCH v3 05/28] rockchip: rk3588: Drop REGULATOR_PWM Kconfig option

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: RK3588 boards do not have any pwm-regulator compatible nodes in DT, drop the superfluous REGULATOR_PWM Kconfig options. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic Reviewed-by: Kever Yang Thanks, - Kever --- v3: Collect r-b tag v2: No

Re: [PATCH v3 04/28] rockchip: rk35xx: Drop USB_GADGET_PRODUCT_NUM Kconfig option

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: The commit 8c19275fdb13 ("rockchip: Update the default USB Product ID value") added default product id for all supported Rockchip SoCs. Remove USB_GADGET_PRODUCT_NUM options that match default value from RK35xx boards. Signed-off-by: Jonas Karlman

Re: [PATCH v3 03/28] clk: rockchip: rk356x: Fix set rate of SCLK_SFC clock

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: The SCLK_SFC can be set to a rate of 24, 50, 75, 100, 125 or 150 MHz. However, clk_set_rate() will fail unless one of those exact rates are used, and with newer and updated device tree files that contain spi-max-frequency values that does not exactly

Re: [PATCH v3 02/28] clk: rockchip: rk3588: Add REF_CLK_USB3OTGx support

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: The REF_CLK_USB3OTGx clocks is used as reference clock for USB3 block. Add simple support to get rate of REF_CLK_USB3OTGx clocks to fix reference clock period configuration. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Acked-by: Sean

Re: [PATCH v3 01/28] clk: rockchip: rk356x: Add CLK_USB3OTGx_REF support

2024-04-22 Thread Kever Yang
On 2024/4/22 14:28, Jonas Karlman wrote: The CLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. Add simple support to get rate of CLK_USB3OTGx_REF clocks to fix reference clock period configuration. Signed-off-by: Jonas Karlman Acked-by: Sean Anderson Reviewed-by: Kever

Re: [RESEND PATCH v3 5/5] power: regulator: tps65941: Add TPS65224 PMIC regulator support

2024-04-22 Thread Bhargav Raviprakash
On Thu, 18 Apr 2024 09:33:30 +0900, Jaehoon Chung wrote: > On 3/18/24 18:49, Bhargav Raviprakash wrote: > > Reuse TPS65941 regulator driver to adds support for > > TPS65224 PMIC's regulators. 4 BUCKs and 3 LDOs, where > > BUCK1 and BUCK2 can be configured in dual phase mode. > > > >

Re: BTRFS use-after-free bug at free_extent_buffer_internal

2024-04-22 Thread Qu Wenruo
在 2024/4/22 16:07, Sachi King 写道: Hi, I've hit a bug with u-boot on my BTRFS filesystem, and I'm fairly certain it's a bug and not a corruption issue. A bit of history on the filesystem. It is a fairly new filesystem as it was being used to give me access to test a wayland application on a

[PATCH v3 28/28] rockchip: rk35xx-generic: Disable unused features

2024-04-22 Thread Jonas Karlman
The generic RK35xx board targets are intended to be used as a bare minimum target that can be used to e.g. boot boards that mostly follow reference hw design before a board spefic target has been added or for flashing and recovery purposes. Disable BOOTMETH_VBE, NET and ADC as these features are

[PATCH v3 27/28] rockchip: rk3588-generic: Add support for USB OTG

2024-04-22 Thread Jonas Karlman
Add support for USB OTG, RockUSB and UMS to the generic RK3588S/RK3588 target. Signed-off-by: Jonas Karlman --- v3: No change v2: Split patch --- arch/arm/dts/rk3588-generic-u-boot.dtsi | 22 ++ arch/arm/dts/rk3588-generic.dts | 2 +-

[PATCH v3 25/28] rockchip: rk356x-generic: Add support for USB OTG

2024-04-22 Thread Jonas Karlman
Add support for USB OTG, RockUSB and UMS to the generic RK3566/RK3568 target. Signed-off-by: Jonas Karlman --- v3: No change v2: Split patch --- arch/arm/dts/rk3568-generic.dts | 19 ++- configs/generic-rk3568_defconfig | 10 ++ 2 files changed, 28 insertions(+), 1

[PATCH v3 26/28] rockchip: rk3588-generic: Use M0 iomux for UART2

2024-04-22 Thread Jonas Karlman
The default pinctrl for UART2 is using M1 iomux, however, all other supported RK3588 boards in U-Boot use M0 iomux for UART2. Change to use the M0 pinctrl for UART2 to match other supported boards. Fixes: b54c3d0dd69b ("rockchip: board: Add minimal generic RK3588S/RK3588 board") Signed-off-by:

[PATCH v3 22/28] rockchip: rk3588-edgeble-neu6: Enable FIT checksum validation

2024-04-22 Thread Jonas Karlman
Enable SPL_FIT_SIGNATURE=y and LEGACY_IMAGE_FORMAT=y to validate FIT images checksum in SPL. Change to SPL_MAX_SIZE=0x4 to allow SPL up to 256 KiB in size. Enable SPL_DM_SEQ_ALIAS=y and SPL_PINCTRL=y to ensure eMMC and SD-card pinctrl is configured in SPL. Enable SYS_NS16550_MEM32=y to use

[PATCH v3 24/28] rockchip: rk356x-generic: Add support for SPI flash

2024-04-22 Thread Jonas Karlman
Add support for booting from SPI flash using the generic RK3566/RK3568 target. Signed-off-by: Jonas Karlman --- v3: No change v2: Split patch --- arch/arm/dts/rk3568-generic-u-boot.dtsi | 7 +++ arch/arm/dts/rk3568-generic.dts | 14 +- configs/generic-rk3568_defconfig

[PATCH v3 23/28] rockchip: rk356x-generic: Fix eMMC and SD-card pinctrl

2024-04-22 Thread Jonas Karlman
Add missing emmc_datastrobe and sdmmc0_det pinctrl to fix possible issue reading from eMMC or SD-card. Also use correct node for mmc1 alias. Fixes: 683f61a13f16 ("rockchip: board: Add minimal generic RK3566/RK3568 board") Fixes: 363cbd578169 ("rockchip: rk3568-generic: Enable eMMC HS200 mode")

[PATCH v3 21/28] rockchip: rk3588-turing-rk1: Use dwc3-generic driver

2024-04-22 Thread Jonas Karlman
RK35xx boards are expected to use the dwc3-generic driver and not the xhci-dwc3 driver. Remove the USB_XHCI_DWC3 option to ensure that the dwc3-generic driver is used. Fixes: 153ac950a599 ("board: rockchip: Add the Turing RK1 SoM") Signed-off-by: Jonas Karlman --- v3: No change v2: Drop change

[PATCH v3 20/28] rockchip: rk3588-toybrick: Add .dtb-file entry in Makefile

2024-04-22 Thread Jonas Karlman
Add Rockchip Toybrick TB-RK3588X .dtb-file entry in Makefile. Fixes: 9fdd9a546986 ("board: rockchip: add Rockchip Toybrick TB-RK3588X board") Signed-off-by: Jonas Karlman --- v3: New patch split from rk3588-toybrick defconfig patch v2: Fix Makefile entry from .dts to .dtb (Quentin) ---

[PATCH v3 18/28] rockchip: rk3588-coolpi: Fix .dtb-file entries in Makefile

2024-04-22 Thread Jonas Karlman
Fix CoolPi 4 Model B and CoolPi CM5 EVB .dtb-file entries in Makefile. Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based Cool Pi CM5 EVB") Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v3: New patch, split from rk3588-coolpi documentation patch v3: Collect r-b

[PATCH v3 19/28] rockchip: rk3588-toybrick: Use pinctrl and aliases in SPL

2024-04-22 Thread Jonas Karlman
Pinctrl must be configured for eMMC, SD-card and SPI flash to successfully read FIT from all possible fallback media in SPL. Include pinctrl props and enable the SPL_PINCTRL Kconfig option to ensure FIT can be loaded from eMMC, SD-card and SPI flash. Also enable the SPL_DM_SEQ_ALIAS Kconfig

[PATCH v3 17/28] rockchip: rk3588-coolpi: Add boards to documentation

2024-04-22 Thread Jonas Karlman
Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the documentation. Fixes: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based Cool Pi CM5 EVB") Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v3: Split Makefile change to a separate patch v3: Collect r-b tag v2: No

[PATCH v3 13/28] rockchip: rk3588: Update bootph props

2024-04-22 Thread Jonas Karlman
After the commit aca95282c1b7 ("Makefile: Use the fdtgrep -u flag") bootph props is propagating to parent nodes. Update bootph props to ensure eMMC, SD-card and SPI flash is available in SPL and U-Boot proper pre-reloc phase also remove unneeded bootph props that automatically is propagated to

[PATCH v3 16/28] rockchip: rk3566-pinetab2: Fix reading FIT from SPI flash

2024-04-22 Thread Jonas Karlman
The SF_DEFAULT_SPEED Kconfig option got lost during merge and this prevent reading FIT from SPI flash. Restore the SF_DEFAULT_SPEED option to fix this. Fixes: 8a94c376f6cb ("rockchip: Use common bss and stack addresses on RK356x") Signed-off-by: Jonas Karlman --- v3: No change v2: No change ---

[PATCH v3 14/28] rockchip: rk3568-evb: Use pinctrl in SPL

2024-04-22 Thread Jonas Karlman
Pinctrl must be configured for eMMC, SD-card and SPI flash to successfully read FIT from all possible fallback media in SPL. Include pinctrl props and enable the SPL_PINCTRL Kconfig option to ensure FIT can be loaded from eMMC, SD-card and SPI flash. Signed-off-by: Jonas Karlman --- v3: New

[PATCH v3 15/28] rockchip: rk3588-evb: Use pinctrl and aliases in SPL

2024-04-22 Thread Jonas Karlman
Pinctrl must be configured for eMMC, SD-card and SPI flash to successfully read FIT from all possible fallback media in SPL. Include pinctrl props and enable the SPL_PINCTRL Kconfig option to ensure FIT can be loaded from eMMC, SD-card and SPI flash. Also enable the SPL_DM_SEQ_ALIAS Kconfig

[PATCH v3 09/28] rockchip: rk35xx: Imply support for GbE PHY

2024-04-22 Thread Jonas Karlman
Imply support for GbE PHY status parsing and configuration when support for onboard ethernet is enabled. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Reviewed-by: Dragan Simic --- v3: Collect r-b tag v2: Collect r-b tag --- arch/arm/mach-rockchip/Kconfig | 2 ++ 1 file changed, 2

[PATCH v3 12/28] rockchip: rk356x: Update bootph props

2024-04-22 Thread Jonas Karlman
After the commit aca95282c1b7 ("Makefile: Use the fdtgrep -u flag") bootph props is propagating to parent nodes. Update bootph props to ensure eMMC, SD-card and SPI flash is available in SPL and U-Boot proper pre-reloc phase also remove unneeded bootph props that automatically is propagated to

[PATCH v3 08/28] rockchip: rk35xx: Enable random generator

2024-04-22 Thread Jonas Karlman
The RK35xx SoCs contain a crypto engine block that can generate random numbers. Enable rng node in soc u-boot.dtsi and enable Kconfig options to take advantage of the random generator. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v3: Collect r-b tag v2: No change ---

[PATCH v3 10/28] rockchip: rk356x: Imply enhanced features for standard boot

2024-04-22 Thread Jonas Karlman
Imply BOOTSTD_FULL for all RK356x boards to more closely follow RK3588. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v3: Collect r-b tag v2: No change --- arch/arm/mach-rockchip/Kconfig | 1 + configs/bpi-r2-pro-rk3568_defconfig | 1 - 2 files changed, 1 insertion(+), 1

[PATCH v3 11/28] rockchip: rk35xx: Sort soc u-boot.dtsi alphabetically

2024-04-22 Thread Jonas Karlman
Sort nodes and props in RK356x/RK3588 u-boot.dtsi alphabetically, nodes is sorted by reg addr then by alphabetical order. This has no intended change beside sorting existing nodes and removing a duplicated usbdpphy0_grf node. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz --- v3:

[PATCH v3 05/28] rockchip: rk3588: Drop REGULATOR_PWM Kconfig option

2024-04-22 Thread Jonas Karlman
RK3588 boards do not have any pwm-regulator compatible nodes in DT, drop the superfluous REGULATOR_PWM Kconfig options. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v3: Collect r-b tag v2: No change --- configs/evb-rk3588_defconfig | 1 - configs/neu6a-io-rk3588_defconfig

[PATCH v3 07/28] rockchip: rk35xx: Sort imply statements alphabetically

2024-04-22 Thread Jonas Karlman
Sort imply statements under ROCKCHIP_RK3568 and ROCKCHIP_RK3588 alphabetically. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v3: Collect r-b tag v2: No change --- arch/arm/mach-rockchip/Kconfig | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff

[PATCH v3 06/28] rockchip: rk3566-anbernic-rgxx3: Remove SPL_ROCKCHIP_BACK_TO_BROM option

2024-04-22 Thread Jonas Karlman
SPL_ROCKCHIP_BACK_TO_BROM should normally only be enabled when BROM should load U-Boot binary. SPL on Anbernic RGxx3 devices load TF-A and U-Boot proper from FIT images and does never jump back to BROM from SPL. Remove the superfluous Kconfig option from defconfig to align with other RK356x

[PATCH v3 04/28] rockchip: rk35xx: Drop USB_GADGET_PRODUCT_NUM Kconfig option

2024-04-22 Thread Jonas Karlman
The commit 8c19275fdb13 ("rockchip: Update the default USB Product ID value") added default product id for all supported Rockchip SoCs. Remove USB_GADGET_PRODUCT_NUM options that match default value from RK35xx boards. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v3: Collect r-b

[PATCH v3 03/28] clk: rockchip: rk356x: Fix set rate of SCLK_SFC clock

2024-04-22 Thread Jonas Karlman
The SCLK_SFC can be set to a rate of 24, 50, 75, 100, 125 or 150 MHz. However, clk_set_rate() will fail unless one of those exact rates are used, and with newer and updated device tree files that contain spi-max-frequency values that does not exactly match these rates use of SPI flash may fail.

[PATCH v3 02/28] clk: rockchip: rk3588: Add REF_CLK_USB3OTGx support

2024-04-22 Thread Jonas Karlman
The REF_CLK_USB3OTGx clocks is used as reference clock for USB3 block. Add simple support to get rate of REF_CLK_USB3OTGx clocks to fix reference clock period configuration. Signed-off-by: Jonas Karlman Reviewed-by: Quentin Schulz Acked-by: Sean Anderson --- v3: Collect a-b tag v2: Collect

[PATCH v3 01/28] clk: rockchip: rk356x: Add CLK_USB3OTGx_REF support

2024-04-22 Thread Jonas Karlman
The CLK_USB3OTGx_REF clocks is used as reference clock for USB3 block. Add simple support to get rate of CLK_USB3OTGx_REF clocks to fix reference clock period configuration. Signed-off-by: Jonas Karlman Acked-by: Sean Anderson --- v3: Collect a-b tag v2: No change ---

[PATCH v3 00/28] rockchip: rk35xx: Miscellaneous fixes and updates

2024-04-22 Thread Jonas Karlman
This series include miscellaneous fixes and updates for RK356x and RK3588 boards. Patch 1-2 adds support for reference clocks used by USB driver. Patch 3 fix SPI flash clk for spi-max-frequency used in new board DTs. Patch 4-6 drops unnecessary Kconfig options. Patch 7-10 sort and imply RNG,

<    1   2