Re: [U-Boot] [PATCH 20/20] x86: Remove CONFIG_USB_MAX_CONTROLLER_COUNT

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > As all x86 boards have been switched over to use DM USB, remove > CONFIG_USB_MAX_CONTROLLER_COUNT which is not used by DM USB. > > Signed-off-by: Bin Meng > > --- > > include/configs/conga-qeval20-qa3-e3845.h |

Re: [U-Boot] [PATCH 10/20] usb: xhci: Change MAX_HC_PORTS to 255

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > HCSPARAMS1:MaxPorts field specifies the maximum port number value, > and its valid values are in the range of 1 to 255. > > Signed-off-by: Bin Meng > --- > > drivers/usb/host/xhci.h | 6 +++--- > 1 file changed,

Re: [U-Boot] [PATCH v1 1/3] rockchip: defconfig: Increase max video resolution for mipi panel

2017-06-16 Thread Simon Glass
On 16 June 2017 at 02:49, Eric Gao wrote: > The mipi panel used on evb-rk3399 has a 1920x1200 resolution. But now > the max resolution is 1920x1080. So increase it. > > Signed-off-by: Eric Gao > > --- > > configs/evb-rk3399_defconfig | 8

Re: [U-Boot] [PATCH 3/3] clk_rv1108.c: Fix unused variable warning

2017-06-16 Thread Simon Glass
On 16 June 2017 at 11:06, Tom Rini wrote: > > The variables gpll_init_cfg and apll_init_cfg are unused in this file, > remove them. > > Cc: Simon Glass > Cc: Philipp Tomsich > Signed-off-by: Tom Rini

Re: [U-Boot] [PATCH 13/20] usb: ehci: Get rid of CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > EHC reports supported maximum number of ports in the HCSPARAMS > register, so it's unnecessary to use a hardcoded config option > CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS. > > Signed-off-by: Bin Meng > --- > >

Re: [U-Boot] [PATCH v2] rockchip: video: mipi: Modify variable type for arm32 compatibility

2017-06-16 Thread Simon Glass
On 16 June 2017 at 04:42, Eric Gao wrote: > Some address relevant varibable is defined originally as u64. To > compatible with arm32, this patch change them to "void __iomem *" type. > > Signed-off-by: Eric Gao > > --- > > Changes in v1: >

Re: [U-Boot] [PATCH 17/20] x86: minnowmax: Configure GPIO pins to turn on USB ports VBUS

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > GPIO bank E pin 8 & 9 are used to control the on-board two USB ports > VBUS on/off. Let's configure them in the misc_init_r(). > > Signed-off-by: Bin Meng > --- > > board/intel/minnowmax/minnowmax.c | 53 >

Re: [U-Boot] [PATCH 19/20] x86: minnowmax: Enable USB xHCI support

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > BayTrail SoC supports both EHCI and xHCI controllers. However only > one host controller (either EHCI or xHCI) can be used. To enable > HSIC and SS ports, xHCI must be used. This turns on xHCI support on > Intel MinnowMax board. > >

Re: [U-Boot] [PATCH v1 3/3] rockchip: video: defconfig: Add support for rk3288 mipi dsi

2017-06-16 Thread Simon Glass
Hi Eric, On 16 June 2017 at 02:52, Eric Gao wrote: > Add support for rk3288 mipi dsi. > I think you should mention in the subject that this is for evb-rk3288. Reviewed-by: Simon Glass > Signed-off-by: Eric Gao > --- > >

Re: [U-Boot] [PATCH] rockchip: mkimage: correct spl_size for rk3399

2017-06-16 Thread Simon Glass
On 14 June 2017 at 02:20, Dr. Philipp Tomsich wrote: > On 14 Jun 2017, at 08:54, Kever Yang wrote: >> >> The maximum spl_size for rk3399 is the internal memory size minus >> the size used in bootrom (which usually can get from

Re: [U-Boot] [PATCH 4/7] rockchip: rk3368: add sdram driver for U-Boot

2017-06-16 Thread Simon Glass
On 13 June 2017 at 03:29, Kever Yang wrote: > Add sdram driver in U-Boot for get the correct sdram size from > sys_reg, so that U-Boot can co-work with Rockchip loader or SPL > to get different dram capability and then tell the kernel. > > Signed-off-by: Kever Yang

Re: [U-Boot] [PATCH] rockchip: rk3399: correct SPL_MAX_SIZE

2017-06-16 Thread Simon Glass
On 14 June 2017 at 02:46, Dr. Philipp Tomsich wrote: > >> On 14 Jun 2017, at 10:14, Kever Yang wrote: >> >> The SPL_MAX_SIZE is the internal memory size minux the space >> used by bootrom. >> >> Signed-off-by: Kever Yang

Re: [U-Boot] [PATCH v1 2/3] rockchip: video: Makefile: Add soc specific driver for rk3288 mipi dsi

2017-06-16 Thread Simon Glass
On 16 June 2017 at 02:52, Eric Gao wrote: > Signed-off-by: Eric Gao > --- > > drivers/video/rockchip/Makefile | 1 + > 1 file changed, 1 insertion(+) > This should be merged into the previous patch. > diff --git

Re: [U-Boot] [PATCH 1/2] Makefile: Allow arch post-link hook

2017-06-16 Thread Simon Glass
On 15 June 2017 at 18:05, Paul Burton wrote: > This commit allows an architecture to provide a Makefile.postlink whose > u-boot target gets invoked after the u-boot ELF is linked. This will be > of use for MIPS in a following commit. > > This mirrors Linux commit

Re: [U-Boot] [U-Boot, 6/7] rockchip: firefly-rk3399: enable dwmmc driver for the board

2017-06-16 Thread Simon Glass
On 14 June 2017 at 13:07, Vagrant Cascadian wrote: > On 2017-06-14, Kever Yang wrote: >> Enable mmc_dw_rockchip driver, disable CONFIG_SPL_OF_PLATDATA >> first for some dependence patches still not merged. >> >> Signed-off-by: Kever Yang > > Tested

Re: [U-Boot] [PATCH 11/20] usb: xhci: Get rid of CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > xHC reports supported maximum number of ports in the HCSPARAMS1 > register, so it's unnecessary to use a hardcoded config option > CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS. > > Signed-off-by: Bin Meng > --- > >

Re: [U-Boot] [RFC PATCH 1/5] armv7: move boot hook before '_start'

2017-06-16 Thread Simon Glass
Hi, On 13 June 2017 at 04:31, Dr. Philipp Tomsich wrote: > >> On 13 Jun 2017, at 11:47, Marek Vasut wrote: >> >> On 06/13/2017 11:44 AM, Dr. Philipp Tomsich wrote: >>> Marek, >>> On 13 Jun 2017, at 10:42, Marek Vasut

Re: [U-Boot] [PATCH 01/20] usb: xhci: Remove incorrect comments for struct xhci_container_ctx

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > There is no member called 'dma' in struct xhci_container_ctx. Remove > the comments that mentions it. > > Signed-off-by: Bin Meng > --- > > drivers/usb/host/xhci.h | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [U-Boot] [PATCH 3/7] rockchip: rk3328: add sdram driver in U-Boot

2017-06-16 Thread Simon Glass
On 13 June 2017 at 03:29, Kever Yang wrote: > Add sdram driver in U-Boot for get the correct sdram size from > sys_reg, so that U-Boot can co-work with Rockchip loader or SPL > to get different dram capability and then tell the kernel. Do you think we might be able to

Re: [U-Boot] [PATCH 1/7] rockchip: add sdram_common for common functions

2017-06-16 Thread Simon Glass
Hi Kever, On 13 June 2017 at 03:29, Kever Yang wrote: > There are some functions like sdram_size_mb can be re-used for > different rockchip SoCs, just put them into common file. > > Signed-off-by: Kever Yang > --- > >

Re: [U-Boot] [PATCH 08/20] usb: hub: Change USB hub descriptor to match USB 3.0 hubs

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > USB 3.0 hubs have a slightly different hub descriptor than USB 2.0 > hubs, with a fixed (rather than variable length) size. Change the > host controller drivers that access those last two fields > (DeviceRemovable and

Re: [U-Boot] [PATCH] treewide: remove unneeded semicolons

2017-06-16 Thread Simon Glass
On 13 June 2017 at 00:17, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada > --- > > arch/powerpc/cpu/ppc4xx/speed.c| 2 +- > board/amcc/bamboo/bamboo.c | 2 +- > board/amcc/luan/luan.c | 2 +- >

Re: [U-Boot] [PATCH v1 1/3] rockchip: video: mipi: Add rk3288 soc specific driver for mipi dsi

2017-06-16 Thread Simon Glass
Hi Eric, On 16 June 2017 at 02:52, Eric Gao wrote: > Add rk3288 soc specific driver for mipi dsi. > > Signed-off-by: Eric Gao > > --- > > drivers/video/rockchip/rk3288_mipi.c | 191 > +++ > 1 file changed, 191

Re: [U-Boot] [PATCH 5/7] rockchip: firefly-rk3399: dts: enable sdmmc device

2017-06-16 Thread Simon Glass
On 14 June 2017 at 02:31, Kever Yang wrote: > Enable sdmmc device and add the spl boot device sequence. > > Signed-off-by: Kever Yang > --- > > arch/arm/dts/rk3399-firefly.dts | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by:

Re: [U-Boot] [PATCH v5 04/11] usb: host: xhci-rockchip: use fixed regulator to control vbus

2017-06-16 Thread Simon Glass
Hi Marek, On 15 June 2017 at 10:53, Marek Vasut wrote: > On 06/15/2017 05:51 AM, rock-chips(daniel.meng) wrote: >> >> >> On 2017/6/13 17:11, Marek Vasut wrote: >>> On 06/12/2017 11:19 AM, Meng Dongyang wrote: Use fixed regulator to control the voltage of vbus and turn off

Re: [U-Boot] [PATCH 02/20] usb: xhci: Correct command TRB 4th dword initialization

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > In xhci_queue_command(), when the command is not 'reset endpoint', > 'stop endpoint' or 'set TR dequeue pointer', endpoint ID should not > be encoded in the TRB. > > Signed-off-by: Bin Meng > --- > >

Re: [U-Boot] [PATCH 6/7] rockchip: dts: rk3368: add dmc node

2017-06-16 Thread Simon Glass
On 13 June 2017 at 03:30, Kever Yang wrote: > Add dmc node to enable sdram driver. > > Signed-off-by: Kever Yang > --- > > arch/arm/dts/rk3368.dtsi | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 7/7] rockchip: correct the bank0 ram size

2017-06-16 Thread Simon Glass
On 13 June 2017 at 03:30, Kever Yang wrote: > The bank0 ram size should be the DRAM size minus reserved size, > the DRAM size may be 1GB, 2GB, 4GB, we can not hard code it. > > Signed-off-by: Kever Yang > --- > >

Re: [U-Boot] [PATCH 07/12] power: regulator: tps65090: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/tps65090_regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH 06/20] usb: hub: Send correct wValue to get hub descriptor of a USB 3.0 hub

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > Testing a USB 3.0 hub by connecting it to the xHCI port on Intel > MinnowMax, when issuing 'get hub descriptor' to the hub, xHCI > reports a transfer event TRB with a completion code 6 which means > 'Stall Error'. > > In fact super

Re: [U-Boot] [PATCH 15/20] usb: cmd: Print actual packet size for super speed devices

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > USB 3.0 defines bMaxPacketSize0 field in the device descriptor as > the exponent of 2, so let's print the calculated actual size. > > Signed-off-by: Bin Meng > --- > > cmd/usb.c | 7 +-- > 1 file changed, 5

Re: [U-Boot] [PATCH 16/20] usb: xhci: Convert CONFIG_USB_XHCI_PCI to Kconfig

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > Add CONFIG_USB_XHCI_PCI as a Kconfig option. > > Signed-off-by: Bin Meng > --- > > drivers/usb/host/Kconfig | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Simon Glass > > diff

Re: [U-Boot] [PATCH v2 11/13] am43xx: Add USB device boot support

2017-06-16 Thread Simon Glass
On 13 June 2017 at 06:10, Vignesh R wrote: > Add function to populate MAC address for usb ether device to support > RNDIS in SPL. Also make arch_misc_init() available when > CONFIG_SPL_USBEHT_SUPPORT is defined so that usb_ether_init() is called > for am43xx as well. > >

Re: [U-Boot] [PATCH 4/7] rockchip: dwmmc: use max-frequency when OF_PLATDATA enabled

2017-06-16 Thread Simon Glass
On 14 June 2017 at 02:31, Kever Yang wrote: > Since the 'clock-freq-min-max' is deprecated, we use max-frequency for > all rockchip SoC dwmmc controller. > > Signed-off-by: Kever Yang > --- > > drivers/mmc/rockchip_dw_mmc.c | 3 ++- > 1 file

Re: [U-Boot] [PATCH v3 2/4] power: regulator: rk8xx: Allow input current/charger shutdown configuration

2017-06-16 Thread Simon Glass
On 13 June 2017 at 02:11, Wadim Egorov wrote: > Hi, > > > Am 13.06.2017 um 01:51 schrieb Simon Glass: >> Hi Wadim, >> >> On 12 June 2017 at 03:59, Wadim Egorov wrote: >>> The RK818 PMIC contains a charger. Add very basic charger functionality >>> to be

Re: [U-Boot] [PATCH 2/7] rockchip: rk3288: dtsi use max-frequency for mmc node

2017-06-16 Thread Simon Glass
On 14 June 2017 at 02:31, Kever Yang wrote: > Since the 'clock-freq-min-max' is deprecated, we use max-frequency. > > Signed-off-by: Kever Yang > --- > > arch/arm/dts/rk3288.dtsi | 8 > 1 file changed, 4 insertions(+), 4

Re: [U-Boot] [PATCH 5/7] rockchip: dts: rk3328: add dmc node

2017-06-16 Thread Simon Glass
On 13 June 2017 at 03:30, Kever Yang wrote: > Add a dmc node for sdram driver. > > Signed-off-by: Kever Yang > --- > > arch/arm/dts/rk3328.dtsi | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 2/2] rockchip: rk3036: sync os_reg2 define with other soc

2017-06-16 Thread Simon Glass
On 13 June 2017 at 02:10, Kever Yang wrote: > Rockchip using the same bit definition for dram info and write > to os_reg, the col and bw info is not correct and let's fix it. > > Signed-off-by: Kever Yang > --- > >

Re: [U-Boot] [PATCH v2 12/13] configs: am43xx: Enable configs to support USB device boot

2017-06-16 Thread Simon Glass
On 13 June 2017 at 06:10, Vignesh R wrote: > Clean up include/configs/am43xx_evm.h and add configs to support USB > device boot for am43xx evm. > > Signed-off-by: Vignesh R > --- > configs/am43xx_evm_defconfig | 13 - > include/configs/am43xx_evm.h

Re: [U-Boot] [PATCH 09/20] usb: hub: Add 3.0 hub port status mask of 2.0 hub

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > USB 3.0 hub port status has different bit position regarding to > port power, port speed, etc. But others are the same as 2.0 hubs. > > Signed-off-by: Bin Meng > --- > > include/usb_defs.h | 7 ++- > 1 file

Re: [U-Boot] [PATCH 04/20] usb: xhci: Add input slot context in xhci_set_configuration()

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > A valid input slot context for a 'configure endpoint' command requires > the 'Context Entries' field to be initialized to the index of the last > valid endpoint context that is defined by the target configuration. We > set up the

Re: [U-Boot] [PATCH 2/7] rockchip: use common sdram function

2017-06-16 Thread Simon Glass
On 13 June 2017 at 03:29, Kever Yang wrote: > Replace the sdram_init() in board init and rockchip_sdram_size() in > sdram driver for all the Rockchip SoCs which enable CONFIG_RAM. > > Signed-off-by: Kever Yang > --- > >

Re: [U-Boot] [PATCH 12/12] power: regulator: lp87565: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/lp87565_regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH 18/20] x86: minnowmax: Add a environment variable for USB power-on delay

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > Occasionally it was observed that on Intel MinnowMax board, with a > USB 2.0 device connected to the bottom port, when doing 'usb start' > on the xHCI controller: > > scanning bus 0 for devices... cannot reset port 3!? > > But

Re: [U-Boot] [PATCH v3 3/4] rockchip: Add basic support for phyCORE-RK3288 SoM based carrier board

2017-06-16 Thread Simon Glass
Hi Wadim, On 13 June 2017 at 03:10, Wadim Egorov wrote: > > > Am 13.06.2017 um 01:51 schrieb Simon Glass: >> On 12 June 2017 at 03:59, Wadim Egorov wrote: >>> The phyCORE-RK3288 is a SoM (System on Module) containing a RK3288 SoC. >>> The module can be

Re: [U-Boot] [PATCH 07/20] usb: hub: Revise wLength for 'get port status' request

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > For accuracy, we should use 'sizeof(struct usb_port_status)' as the > wLength for 'get port status' request, although it happens to be > equal to 'sizeof(struct usb_hub_status)'. > > Signed-off-by: Bin Meng > ---

Re: [U-Boot] [PATCH 05/12] power: regulator: palmas: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/palmas_regulator.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [U-Boot] [PATCH v2 09/13] usb: gadget: ether: Populate DM_FLAG_PRE_RELOC flag

2017-06-16 Thread Simon Glass
On 13 June 2017 at 06:10, Vignesh R wrote: > Populate DM_FLAG_PRE_RELOC, so that usb_ether can be used before > relocation in case of RNDIS boot. > > Signed-off-by: Vignesh R > --- > drivers/usb/gadget/ether.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH 10/12] power: regulator: s5m8767: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/s5m8767.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code

2017-06-16 Thread Simon Glass
+Tom On 13 June 2017 at 01:06, Lothar Waßmann wrote: > Hi, > > On Mon, 12 Jun 2017 17:50:45 -0600 Simon Glass wrote: >> On 8 June 2017 at 02:16, Lothar Waßmann wrote: >> > Create exception stack in IRAM if available to facilitate debugging of

Re: [U-Boot] [PATCH v2 10/13] usb: gadget: add DWC3 USB gadget support

2017-06-16 Thread Simon Glass
On 13 June 2017 at 06:10, Vignesh R wrote: > DWC3 can operate in either device mode or host mode. Add an entry to > support DWC3 gadget. > > Signed-off-by: Vignesh R > --- > drivers/usb/gadget/gadget_chips.h | 2 ++ > 1 file changed, 2 insertions(+)

Re: [U-Boot] [PATCH 03/20] usb: xhci: Initialize scratchpad buffer array and scratchpad buffers

2017-06-16 Thread Simon Glass
On 16 June 2017 at 07:31, Bin Meng wrote: > The scratchpad buffer array is used to define the locations of > statically allocated memory pages that are available for the > private use of the xHC. The xHCI spec explicitly mentions that > system software shall allocate the

Re: [U-Boot] [PATCH 06/12] power: regulator: pfuze100: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/pfuze100.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH 1/2] rockchip: rk3036 remove CONFIG_RAM from defconfig

2017-06-16 Thread Simon Glass
On 13 June 2017 at 02:10, Kever Yang wrote: > rk3036 sdram driver does not use DM, remove CONFIG_RAM first. > > Signed-off-by: Kever Yang > --- > > configs/evb-rk3036_defconfig | 1 - > configs/kylin-rk3036_defconfig | 1 - > 2 files

Re: [U-Boot] [PATCH 1/7] rockchip: rk3036: dtsi use max-frequency for mmc node

2017-06-16 Thread Simon Glass
On 14 June 2017 at 02:31, Kever Yang wrote: > Since the 'clock-freq-min-max' is deprecated, we use max-frequency. > > Signed-off-by: Kever Yang > --- > > arch/arm/dts/rk3036.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [U-Boot] [PATCH 7/7] Revert "mmc: dw_mmc: rockchip: select proper card clock"

2017-06-16 Thread Simon Glass
On 14 June 2017 at 02:31, Kever Yang wrote: > The origin patch get rockchip dwmmc by name 'ciu', which lead > to the SPL not able to remove 'clock-names' node in dts. > I'm not saying this is not correct, but I would prefer to handle > this in dts or clock driver to

Re: [U-Boot] [PATCH] rockchip: rk3328: correct mem_region

2017-06-16 Thread Simon Glass
On 13 June 2017 at 07:00, Kever Yang wrote: > According to rk3328 TRM: > 0~0xff00 is ddr space; > 0xff00~0x is device space. > > Signed-off-by: Kever Yang > --- > > arch/arm/mach-rockchip/rk3328/rk3328.c | 8 > 1

Re: [U-Boot] [PATCH 2/2] mmc: rpmb: update size format for write_counter

2017-06-16 Thread Simon Glass
On 12 June 2017 at 20:11, Kever Yang wrote: > Hi Simon, > > > On 06/09/2017 08:28 PM, Simon Glass wrote: >> >> On 7 June 2017 at 19:20, Kever Yang wrote: >>> >>> According to MMC spec, the write_counter is 4-byte length, >>> use 'int' instead

Re: [U-Boot] [PATCH 08/12] power: regulator: rk8xx: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/rk8xx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: [U-Boot] [PATCH 09/12] power: sandbox: fixed: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/sandbox.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/fixed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [U-Boot] [PATCH 01/12] regulator: Change get_enable return type to integer from bool

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > Change get_enable return type to int so errors can be returned. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/regulator-uclass.c | 2 +- > include/power/regulator.h | 8 > 2

Re: [U-Boot] [PATCH 11/12] power: regulator: lp873x: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/lp873x_regulator.c | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [U-Boot] [PATCH v5 08/11] usb: dwc2: force to host mode if not support HNP/SRP

2017-06-16 Thread Simon Glass
Hi Meng, On 12 June 2017 at 03:19, Meng Dongyang wrote: > In current code, after running the command of "usb start", the controller > will keep in otg mode and can't switch to host mode if not support > SNP/SRP capability. So add the property of "hnp-srp-disable" in

Re: [U-Boot] [PATCH 03/12] power: regulator: act8846: get_enable should return integer

2017-06-16 Thread Simon Glass
On 12 June 2017 at 22:23, Keerthy wrote: > get_enable should be able to return error values. Hence change > the return type to integer. > > Signed-off-by: Keerthy > --- > drivers/power/regulator/act8846.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH v5 05/11] usb: host: xhci-rockchip: add support for rk3328

2017-06-16 Thread Simon Glass
On 12 June 2017 at 03:19, Meng Dongyang wrote: > Add the compatible "rockchip,rk3328-xhci" in match table > for rk3328 to probe xhci controller. > > Signed-off-by: Meng Dongyang > --- > > Chagnes in v5: None > Changes in v4: > - New patch,

Re: [U-Boot] [PATCH 2/2] MIPS: Stop building position independent code

2017-06-16 Thread Daniel Schwierzeck
Am 16.06.2017 um 02:05 schrieb Paul Burton: > U-Boot has up until now built with -fpic for the MIPS architecture, > producing position independent code which uses indirection through a > global offset table, making relocation fairly straightforward as it > simply involves patching up GOT

Re: [U-Boot] [PATCH v4 00/30]

2017-06-16 Thread Franklin S Cooper Jr
Sorry. Somehow I left out the subject from this. I resent just the cover letter with the proper subject. On 06/16/2017 05:25 PM, Franklin S Cooper Jr wrote: > This patchset adds support for the new Keystone 2 Industrial Communication > Engine board. > > This patchset includes the introduction of

[U-Boot] [PATCH v4 22/30] board: ks2: Use board detection to wrap code not specific to K2G ICE evm

2017-06-16 Thread Franklin S Cooper Jr
Some code doesn't apply to K2G ICE evm. Therefore, use board detection to wrap these calls. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- board/ti/ks2_evm/board.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff

[U-Boot] [PATCH v4 26/30] ARM: dts: keystone-k2g-evm: Add unit address to memory node

2017-06-16 Thread Franklin S Cooper Jr
Upstream Linux has the unit address being added to the various 66AK2Gx boards dts. Therefore, update the dts to mimic this change. Also remove memory node from the base K2G dtsi file. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini ---

[U-Boot] [PATCH v4 25/30] ARM: dts: keystone-k2g: Remove skeleton.dtsi

2017-06-16 Thread Franklin S Cooper Jr
Adding the unit address to the memory node was causing the below error: Warning (reg_format): "reg" property in /memory has invalid length (8 bytes) (#address-cells == 2, #size-cells == 2) Further debugging showed that this was due to the memory node added by default to skeleton.dtsi which was

[U-Boot] [PATCH v4 27/30] ARM: dts: k2g: Disable netcp by default

2017-06-16 Thread Franklin S Cooper Jr
Disable netcp by default like all other peripherals in the dtsi file. Enable the peripheral explicitly in the board specific dts file. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- arch/arm/dts/keystone-k2g-evm.dts| 4

[U-Boot] [PATCH v4 28/30] ARM: dts: k2g: Add DT support for K2G Industrial Communication Engine evm

2017-06-16 Thread Franklin S Cooper Jr
Add basic DT support for K2G ICE evm. Only minimal peripherals are supported to allow console output and MMC boot. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- arch/arm/dts/Makefile | 3 ++-

[U-Boot] [PATCH v4 00/30] ARM: k2g: Add support for new K2G ICE EVM.

2017-06-16 Thread Franklin S Cooper Jr
This patchset adds support for the new Keystone 2 Industrial Communication Engine board. This patchset includes the introduction of embedded FIT images in U-boot. This creates a FIT image of dtb files that enables board specific code to select which DTB to use at runtime. Initially during boot a

[U-Boot] [PATCH v4 24/30] ARM: k2g: Update board_name u-boot env variable at runtime

2017-06-16 Thread Franklin S Cooper Jr
Enable CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG to allow "board_name" to be set depending on the board it is being ran on. Update findfdt to use this new dynamic board_name value to determine which dtb should be used. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini

[U-Boot] [PATCH v4 23/30] ARM: k2g: Use board detection to wrap K2G GP specific calls

2017-06-16 Thread Franklin S Cooper Jr
Certain peripherals used by K2G GP aren't used on K2G ICE evm. Or configuration is slightly different. Therefore, use board detection to deal with these variations. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- board/ti/ks2_evm/board_k2g.c |

[U-Boot] [PATCH v4 19/30] ks2_evm: Add EEPROM based board detection helper functions

2017-06-16 Thread Franklin S Cooper Jr
Add a function that can be used to determine if the board being ran on is a K2G Industrial Communication Engine EVM or K2G General Purpose EVM based on values programmed on the EEPROM. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini ---

[U-Boot] [PATCH v4 30/30] defconfig: k2g_evm_defconfig: Add K2G ICE to OF_LIST

2017-06-16 Thread Franklin S Cooper Jr
Include K2G ICE to OF_LIST so it can be used for runtime board detection. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- configs/k2g_evm_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/k2g_evm_defconfig

[U-Boot] [PATCH v4 17/30] ARM: k2g: Program DDR PHY MR2 register with the default value

2017-06-16 Thread Franklin S Cooper Jr
K2G GP doesn't require the MR2 register to be programed since the default is good enough. However, newer K2G boards do need to change this register value. Therefore, instead of not writing this register if ran on a K2G board just program the value to be written to match the default/reset value.

[U-Boot] [PATCH v4 20/30] ARM: k2g: Add pinmux support for K2G ICE evm

2017-06-16 Thread Franklin S Cooper Jr
Add basic pinmux data for new K2G ICE evm. Also add pinmuxing for a generic K2G evm which includes I2C 0 and 1 used for board detection purposes. Since multiple K2G boards are supported that means initially generic pinmuxing should be used when board detection hasn't ran. Once board detection

[U-Boot] [PATCH v4 29/30] ARM: k2g: Add K2G ICE DTB to the list of possible DTBs

2017-06-16 Thread Franklin S Cooper Jr
K2G ICE evm will have its own dtb. Therefore, add it to the list of dtbs located in the appended U-boot dtb FIT image. Therefore, when swapping out dtbs K2G ICE boards can grab the correct one. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini ---

[U-Boot] [PATCH v4 21/30] ARM: k2g: Add DDR3 configuration for K2G ICE evm

2017-06-16 Thread Franklin S Cooper Jr
Add configuration settings used by the K2G ICE evm. Also use board detection to determine which DDR3 configuration to use. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- board/ti/ks2_evm/ddr3_k2g.c | 62

[U-Boot] [PATCH v4 12/30] ARM: k2g: Define embedded_dtb_select for runtime DTB selection in U-boot

2017-06-16 Thread Franklin S Cooper Jr
For K2G, runtime DTB selection utilizes the embedded_dtb_select function. Therefore, define the function which will perform a EEPROM read and then retries selecting the correct dtb now that it can detect which board its on. For other Keystone devices use an empty function since they will still use

[U-Boot] [PATCH v4 18/30] ARM: k2g: Program DDRPHY_DATX8 registers via mask and value variables

2017-06-16 Thread Franklin S Cooper Jr
Different K2G evms may need to program the various KS2_DDRPHY_DATX8_X_OFFSET registers in different ways. Therefore, use the mask and val registers for each KS2_DDRPHY_DATAX_X_OFFSET to properly program the register. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini

[U-Boot] [PATCH v4 13/30] ARM: keystone2: Define board_fit_config_name_match for Keystone 2 boards

2017-06-16 Thread Franklin S Cooper Jr
Now with support for U-boot runtime dtb selection each board needs to define board_fit_config_name_match so U-boot can determine what the correct dtb is within the FIT blob. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini ---

[U-Boot] [PATCH v4 16/30] ARM: keystone2: Add additional fields used for DDR3 configuration

2017-06-16 Thread Franklin S Cooper Jr
Future boards will need to configure DDR3 registers in a slightly different manner. Support this by defining additional variables and defines that will be utilized later. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini ---

[U-Boot] [PATCH v4 08/30] arm: dts: Add new "generic" 66AK2Gx device tree file.

2017-06-16 Thread Franklin S Cooper Jr
With U-boot runtime board detect for DTB selection a "default" dtb needs to be created. This will be used temporarily until the "proper" dtb is selected. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- arch/arm/dts/Makefile

[U-Boot] [PATCH v4 15/30] defconfig: keystone2: Enable U-boot runtime DTB detection

2017-06-16 Thread Franklin S Cooper Jr
Enable various config options to allow U-boot at runtime to select the proper dtb to use from the list of dtb's within the FIT image. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- configs/k2e_evm_defconfig | 3 +++ configs/k2g_evm_defconfig

[U-Boot] [PATCH v4 06/30] dts: Allow OF_LIST to depend on FIT_EMBED

2017-06-16 Thread Franklin S Cooper Jr
OF_LIST will be useable by SPL and U-boot. Therefore, update its dependency to allow it to be enable by either SPL or U-boot specific config option. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini Reviewed-by: Lokesh Vutla

[U-Boot] [PATCH v4 11/30] ARM: keystone2: Allow to build with all image formats

2017-06-16 Thread Franklin S Cooper Jr
u-boot.bin is a copy of: u-boot-fit-dtb.bin if CONFIG_FIT_EMBED is enabled, u-boot-dtb.bin if CONFIG_OF_SEPARATE is enabled, u-boot-nodtb.bin if DT is not enabled. So, use u-boot.bin to to generate keystone images instead of u-boot-dtb.bin Signed-off-by: Franklin S Cooper Jr

[U-Boot] [PATCH v4 14/30] ks2_evm: Add EEPROM based board detection

2017-06-16 Thread Franklin S Cooper Jr
Some K2G evms have their EEPROM programming while most do not. Therefore, add EEPROM board detection to be used as the default method and fall back to the alternative board detection when needed. Also reorder board configuration. Perform bare minimal configuration initially since board detection

[U-Boot] [PATCH v4 05/30] ti: common: board_detect: Add function to determine if EEPROM was read

2017-06-16 Thread Franklin S Cooper Jr
When the EEPROM is first read its contents are stored in memory as a cache to avoid further I2C operations. To determine if the EEPROM was previously read the easiest way is to check the memory to see if the EEPROM's magic header value is set. Create a new function that can determine if the EEPROM

[U-Boot] [PATCH v4 09/30] board_f: Add new function to allow runtime DTB selection

2017-06-16 Thread Franklin S Cooper Jr
Runtime U-boot dtb selection is generally a two step process. First step is to simply use an initial generic dtb. The second step is to select the dtb and perhaps execute additional code ones U-boot knows what board it is running on. Embedded_dtb_select handles the second step by allowing board

[U-Boot] [PATCH v4 07/30] ARM: dts: k2g: Introduce U-boot specific dtsi file

2017-06-16 Thread Franklin S Cooper Jr
Introduce K2G evm specific dtsi file for U-boot specific configurations. This will help seperate U-boot only configurations thus making it easier to keep device tree files synced between U-boot and Linux. For now only add nodes to allow i2c drivers to be probed early during the boot process.

[U-Boot] [PATCH v4 10/30] Makefile: Build additional binaries for dtb FIT blobs appended to U-boot

2017-06-16 Thread Franklin S Cooper Jr
Add additional make targets and options for building embedded FIT U-boot images. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- .gitignore | 1 + Makefile | 18 -- 2 files changed, 17 insertions(+), 2 deletions(-) diff

[U-Boot] [PATCH v4 02/30] spl: fit: Break out some functions into a common file

2017-06-16 Thread Franklin S Cooper Jr
Some of the functions within spl_fit will be used for non spl purposes. Instead of duplicating functions simply break the functions to be reused into its own file. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini Reviewed-by: Simon Glass

[U-Boot] [PATCH v4 03/30] boot_fit: Create helper functions that can be used to select DTB out of FIT

2017-06-16 Thread Franklin S Cooper Jr
Some platforms may append a FIT image to the U-boot image. This function aids in parsing the FIT image and selecting the correct DTB at runtime. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Tom Rini --- Version 4 changes: Updated to work with latest

[U-Boot] [PATCH v4 04/30] fdt: Enable selecting correct DTB from appended FIT Image

2017-06-16 Thread Franklin S Cooper Jr
This patch gives U-boot the runtime support to have the board specific code decide which FDT to use. This is especially useful for devices that need this type of runtime determination and also doesn't use SPL. Signed-off-by: Franklin S Cooper Jr Reviewed-by: Lokesh Vutla

[U-Boot] [PATCH v4 01/30] ti: common: board_detect: Allow settings board detection variables manually

2017-06-16 Thread Franklin S Cooper Jr
From: Nishanth Menon In some situations the EEPROM used for board detection may not be programmed or simply programmed incorrectly. Therefore, it may be necessary to "simulate" reading the contents of the EEPROM to set appropriate variables used in the board detection code. This

[U-Boot] [PATCH v4 00/30]

2017-06-16 Thread Franklin S Cooper Jr
This patchset adds support for the new Keystone 2 Industrial Communication Engine board. This patchset includes the introduction of embedded FIT images in U-boot. This creates a FIT image of dtb files that enables board specific code to select which DTB to use at runtime. Initially during boot a

  1   2   >