Re: [U-Boot] [PATCH v2] arm64: ls1012afrdm: Add distro boot support

> -Original Message- > From: York Sun > Sent: Thursday, October 05, 2017 8:30 PM > To: Rajesh Bhagat ; u-boot@lists.denx.de > Cc: Bhaskar Upadhaya > Subject: Re: [PATCH v2] arm64: ls1012afrdm: Add distro boot support > > On 10/05/2017

Re: [U-Boot] efi_loader: arch/arm/include/asm/setjmp.h

On 07.10.17 22:23, Heinrich Schuchardt wrote: > Hello Alex, > > our current logic for removing the handler of the loaded image is wrong: > > If a driver image calls Exit() with EFI_SUCCESS the image has to remain. > > I tried to rework the logic and needed a second setjmp in cmd/bootefi.c >

Re: [U-Boot] [PATCH 11/11] test/py: fix typo in test_efi_loader.py

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > Make a comment line easier to read. > > Signed-off-by: Heinrich Schuchardt > --- > test/py/tests/test_efi_loader.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v4] arm64: ls1012ardb: Add distro boot support

> -Original Message- > From: York Sun > Sent: Thursday, October 05, 2017 8:27 PM > To: Rajesh Bhagat ; u-boot@lists.denx.de > Cc: Bhaskar Upadhaya > Subject: Re: [PATCH v4] arm64: ls1012ardb: Add distro boot support > > On 10/05/2017

Re: [U-Boot] [PATCH 031/080] serial: ns16550: Fix address translation

Hi Mario, On 29 September 2017 at 06:51, Mario Six wrote: > The dev_read_addr function does not do any bus translations, and just > returns the raw address read from the device tree, which makes the > driver not work on systems that need bus translations to get the actual >

Re: [U-Boot] [PATCH 070/080] common: board_f: Fix style violations

On 29 September 2017 at 06:52, Mario Six wrote: > Fix some style violations in the board_f file. > > Signed-off-by: Mario Six > --- > common/board_f.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 02/11] efi_loader: avoid NULL dereference in efi_dp_match

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > When calling bootefi hello twice a kernel dump occurs. > > Neither bootefi hello nor bootefi selftest have an image > device patch. So do not try to dereference the NULL > value. > > Fixes: 95c5553ea26 efi_loader:

Re: [U-Boot] [PATCH 08/11] efi_selftest: allow to select a single test for exexution

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > The second argument of bootefi is passed as a configuration > table to the selftest application. It is used to select > a single test to be executed. > > Tests get an on_request property. If this property is set > the

Re: [U-Boot] [PATCH] cmd/fdt.c align data buffer to avoid unaligned word access

On 28 September 2017 at 03:29, Bernhard Messerklinger wrote: > Since the compiler is free to place a char array to any address in > memory (in this case the stack), also to a non word aligned address the > function "fdt_prop_parse" runs into troubles upon

Re: [U-Boot] [PATCH] xyz-modem: Fix timeout loop waiting with WATCHDOG

Hi Lokesh, On 27 September 2017 at 00:27, Lokesh Vutla wrote: > > > On Monday 25 September 2017 07:45 AM, Simon Glass wrote: >> Hi, >> >> On 16 September 2017 at 23:12, Lokesh Vutla wrote: >>> Simon, >>> >>> On 9/16/2017 9:43 PM, Simon Glass wrote:

Re: [U-Boot] [PATCH 029/080] gpio: pca953x_gpio: Make live-tree compatible

On 29 September 2017 at 06:51, Mario Six wrote: > Make the pca953x_gpio driver compatible with a live device tree. > > Signed-off-by: Mario Six > --- > drivers/gpio/pca953x_gpio.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by:

Re: [U-Boot] [PATCH 024/080] net: tsec: Make live-tree compatible

On 29 September 2017 at 06:51, Mario Six wrote: > Make the tsec ethernet driver compatible with a live device tree. > > Signed-off-by: Mario Six > --- > drivers/net/tsec.c | 41 ++--- > 1 file changed, 18 insertions(+),

Re: [U-Boot] [PATCH v3 1/7] spl: fix assignment of board info to global data

On 28 September 2017 at 09:42, York Sun wrote: > Commit 15eb1d43bf47 ("spl: reorder the assignment of board info to > global data") intended to move assignment of board info earlier, > into board_init_r(). However, function preload_console_init() is > called either from

Re: [U-Boot] [PATCH 017/080] spi: Remove spi_setup_slave_fdt

On 29 September 2017 at 06:51, Mario Six wrote: > A previous patch removed the spi_flash_probe_fdt function, which > contained the last call of the spi_setup_slave_fdt function, which is > now equally obsolete. > > This patch removes the function. > > Signed-off-by: Mario Six

Re: [U-Boot] [PATCH 013/080] clk: Remove superfluous gd declarations

On 29 September 2017 at 06:51, Mario Six wrote: > The clk uclass was converted to support a live device tree recently, > hence the global data pointer declarations are no longer needed. > > Signed-off-by: Mario Six > --- > drivers/clk/clk-uclass.c | 2

Re: [U-Boot] [PATCH 005/080] lib: fdtdec: Fix whitespace style violations

On 29 September 2017 at 06:51, Mario Six wrote: > Fix some whitespace-related style violations in fdtdec.c. > > Signed-off-by: Mario Six > --- > lib/fdtdec.c | 56 ++-- > 1 file changed, 30

Re: [U-Boot] [PATCH 021/080] sf_probe: Merge spi_flash_probe_tail into spi_flash_probe

On 29 September 2017 at 06:51, Mario Six wrote: > spi_flash_probe_tail is now only called from spi_flash_probe, hence we > can merge its body into spi_flash_probe. > > Signed-off-by: Mario Six > --- > drivers/mtd/spi/sf_probe.c | 19 +++ >

Re: [U-Boot] [PATCH 012/080] clk: clk_fixed_rate: Fix style violation

On 29 September 2017 at 06:51, Mario Six wrote: > Fix a mis-indented function call in clk_fixed_rate.c > > Signed-off-by: Mario Six > --- > drivers/clk/clk_fixed_rate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 2/2] ARM: dts: OMAP5+: Add support for bandgap sensor in SPL

On 6 October 2017 at 05:35, Faiz Abbas wrote: > Mark bandgap node as uboot,dm-spl so that it can be accessed in spl > > Signed-off-by: Faiz Abbas > --- > arch/arm/dts/omap5-u-boot.dtsi | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v2 08/19] fs: Enable generic filesystems interface support in SPL.

On 25 September 2017 at 02:40, wrote: > From: Tien Fong Chee > > Enable generic filesystem interface drivers(fs.c and fat/) build > for SPL. This would allow generic filesystem being used in SPL. > > Signed-off-by: Tien Fong Chee

Re: [U-Boot] [PATCH] linux/bitfield.h: import from Linux 4.13

On 25 September 2017 at 21:12, Masahiro Yamada wrote: > Copied from Linux 4.13. > > Commit log of 3e9b3112ec74 of Linux explains well why this header > is useful. > > Signed-off-by: Masahiro Yamada > --- > > In order to use this

Re: [U-Boot] [PATCH 05/11] efi_loader: move efi_search_obj up in code

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > To avoid a forward declaration move efi_search_obj before > all protocol services functions. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 41

Re: [U-Boot] [PATCH 03/11] efi_loader: comments for functions add missing @return

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > For some functions the @return description is missing. > > Fix typo. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_boottime.c | 9 - > 1 file changed, 8 insertions(+), 1

Re: [U-Boot] [PATCH 06/11] efi_loader: implement SetWatchdogTimer

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > The watchdog is initialized with a 5 minute timeout period. > It can be reset by SetWatchdogTimer. > It is stopped by ExitBoottimeServices. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [U-Boot] [PATCH 016/080] spi: Remove spi_flash_probe_fdt

On 29 September 2017 at 06:51, Mario Six wrote: > Commit ba45756 ("dm: x86: spi: Convert ICH SPI driver to driver model") > removed the last usage of the spi_flash_probe_fdt function, rendering it > obsolete. > > This patch removes the function. > > Signed-off-by: Mario Six

Re: [U-Boot] [PATCH 004/080] include: dm: Fix 'devioe'/'devuce' typos

On 29 September 2017 at 06:51, Mario Six wrote: > There are some typos in the documentation of some functions in read.h; > fix those. > > Signed-off-by: Mario Six > --- > include/dm/read.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [U-Boot] [PATCH] imx: serial: Wait for ongoing transmission to finish before serial reset

Hi Lukasz, On 3 October 2017 at 03:16, Lukasz Majewski wrote: > It may happen that the MXC serial IP block is performing some ongoing > transmission (started at e.g. board_init()) when the "initr_serial" is > called. > > As a result the serial port IP block is reset, so

Re: [U-Boot] [PATCH 01/11] efi_selftest: avoid dereferencing NULL in tpl test

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > The task priority levels test uses two events one passes the > notification counter as context. The other passes NULL. > Both use the same notification function. So we need to check > for NULL here. > > Signed-off-by:

Re: [U-Boot] [PATCH 020/080] spi: spi-uclass: Fix style violations

On 29 September 2017 at 06:51, Mario Six wrote: > Remove a superfluous newline, and reduce the scope of a variable. > > Signed-off-by: Mario Six > --- > drivers/spi/spi-uclass.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by:

Re: [U-Boot] [PATCH 07/11] efi_selftest: provide test for watchdog timer

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > The test verifies that resetting the watchdog timer ensures > that it is not called during the timeout period. > > Testing that the watchdog timer actually executes a reset > would require a test outside the efi_selftest

Re: [U-Boot] [PATCH 10/11] test/py: test reboot by EFI watchdog

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > Provide a test verifying that the EFI watchdog > reboots the system upon timeout. > > The test depends on CONFIG_CMD_EFI_SELFTEST=y. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [U-Boot] [PATCH 1/2] thermal: ti-bandgap: Add support for temperature sensor

Hi Faiz, On 6 October 2017 at 05:35, Faiz Abbas wrote: > The dra7xx series of SOCs contain a temperature sensor and an > associated analog-to-digital converter (ADC) which produces > an output which is proportional to the SOC temperature. > Add support for this temperature

Re: [U-Boot] [PATCH 006/080] lib: fdtdec: Fix some style violations

On 29 September 2017 at 06:51, Mario Six wrote: > Fix some style violations in fdtdec.c, and reduce the scope of some > variables. > > Signed-off-by: Mario Six > --- > lib/fdtdec.c | 31 --- > 1 file changed, 16 insertions(+),

Re: [U-Boot] [PATCH v2 12/17] efi_loader: fix efi_net_get_status

On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > The returned interrupt status was wrong. > > As out transmit buffer is empty we need to always set > EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT. > > When we have received a packet we need to set >

Re: [U-Boot] [PATCH 09/11] efi_selftest: test reboot by watchdog

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > A test is added that verifies that the watchdog timer actually > causes a reboot upon timeout. The test in only executed on > request using > > bootefi selftest 'watchdog reboot' > > Signed-off-by: Heinrich

Re: [U-Boot] [PATCH 011/080] clk: clk-uclass: Fix style violations

On 29 September 2017 at 06:51, Mario Six wrote: > checkpatch.pl complains that the clk_ops structures used in clk-uclass.c > ought to be static, so we mark them as static. Do you mean static, or const? Otherwise: Reviewed-by: Simon Glass > >

Re: [U-Boot] [PATCH 009/080] core: Add {ofnode, dev}_translate_address functions

On 29 September 2017 at 06:51, Mario Six wrote: > Signed-off-by: Mario Six > --- > drivers/core/ofnode.c | 8 > drivers/core/read.c | 5 + > include/dm/ofnode.h | 13 + > include/dm/read.h | 17 + > 4

Re: [U-Boot] [PATCH 007/080] core: ofnode: Fix style violations

On 29 September 2017 at 06:51, Mario Six wrote: > There are some style violations in ofnode.c; fix those. > > Signed-off-by: Mario Six > --- > drivers/core/ofnode.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) Reviewed-by:

Re: [U-Boot] [PATCH 018/080] spi: Remove CONFIG_OF_SPI_FLASH

On 29 September 2017 at 06:51, Mario Six wrote: > Previous patches removed the last usages of this config variable, so > that it is now obsolete. > > This patch removes it from the whitelist. > > Signed-off-by: Mario Six > --- >

Re: [U-Boot] [PATCH v2 10/17] efi_loader: use events for efi_net_receive

On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > A timer event is defined. The timer handler cares for receiving new > packets. > > efi_timer_check is called both in efi_net_transmit and efi_net_receive > to enable events during network communication. > > Calling

Re: [U-Boot] [PATCH 015/080] spi: Remove obsolete spi_base_setup_slave_fdt

On 29 September 2017 at 06:51, Mario Six wrote: > 0efc024 ("spi_flash: Add spi_flash_probe_fdt() to locate SPI by FDT > node") added a helper function spi_base_setup_slave_fdt to to set up a > SPI slave from a given FDT blob. The only user was the exynos SPI > driver. > > But

Re: [U-Boot] [PATCH 071/080] common: board_r: Fix style violations

On 29 September 2017 at 06:52, Mario Six wrote: > Fix some style violations in the board_r file. > > Signed-off-by: Mario Six > --- > common/board_r.c | 27 ++- > 1 file changed, 14 insertions(+), 13 deletions(-) Reviewed-by:

Re: [U-Boot] [PATCH] ARM: SPL: FIT: fix DTC warnings on FIT generation

Hi Andre, On 4 October 2017 at 17:24, Andre Przywara wrote: > Newer versions of the device tree compiler (rightfully) complain about > mismatches between attributed node names (name@) and a missing > reg property in that node. > Adjust the FIT build script for 64-bit

Re: [U-Boot] [PATCH 010/080] core: Make device_is_compatible live-tree compatible

On 29 September 2017 at 06:51, Mario Six wrote: > Judging from its name and parameters, device_is_compatible looks like it > is compatible with a live device tree, but it actually isn't. > > Make is compatible with a live device tree. > > Signed-off-by: Mario Six

Re: [U-Boot] [PATCH v2 09/19] arm: socfpga: Add drivers for programing FPGA from flash

Hi, On 25 September 2017 at 02:40, wrote: > From: Tien Fong Chee > > These drivers handle FPGA program operation from flash loading > RBF to memory and then to program FPGA. > > Signed-off-by: Tien Fong Chee > --- >

Re: [U-Boot] [PATCH v2 07/26] mmc: Add a function to dump the mmc capabilities

On 2 October 2017 at 02:57, Jean-Jacques Hiblot wrote: > Hi Jaehoon, > > > On 22/09/2017 15:54, Jaehoon Chung wrote: >> >> Hi, >> >> On 09/21/2017 11:29 PM, Jean-Jacques Hiblot wrote: >>> >>> This adds a simple helper function to display information (bus width and >>> mode) based

Re: [U-Boot] [PATCH 080/080] clk: Makefile: Sort entries alphabetically

On 29 September 2017 at 06:52, Mario Six wrote: > The Makefile entries in the clk driver directory were not alphabetically > sorted. Correct this. > > Signed-off-by: Mario Six > --- > drivers/clk/Makefile | 20 ++-- > 1 file changed, 10

Re: [U-Boot] [PATCH 04/11] efi_selftest: error handling in SNP test

On 7 October 2017 at 22:57, Heinrich Schuchardt wrote: > Avoid NULL pointer dereference after setup failed due to a > missing network. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_snp.c | 9 - > 1 file changed, 8

Re: [U-Boot] [PATCH v2 13/17] efi_loader: size fields in SimpleNetworkProtocol

On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > The size fields in the Simple Network Protocol are all > UINTN in the UEFI spec. So use size_t. > > Provide a function description of the receive function. > > Signed-off-by: Heinrich Schuchardt >

Re: [U-Boot] [PATCH] usb: kbd: Don't fail with iomux

+Tom On 26 September 2017 at 19:19, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to

Re: [U-Boot] [PATCH v2 14/17] efi_loader: fill return values in SimpleNetworkProtocol

On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > In the receive function all return values should be filled. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_net.c | 27 +-- >

Re: [U-Boot] [PATCH 08/11] efi_selftest: allow to select a single test for exexution

On 08.10.17 06:57, Heinrich Schuchardt wrote: > The second argument of bootefi is passed as a configuration > table to the selftest application. It is used to select > a single test to be executed. > > Tests get an on_request property. If this property is set > the tests are only executed if

Re: [U-Boot] [PATCH v2 17/17] efi_loader: supply EFI network test

On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > This patch provices an EFI application to check the correct function > of the Simple Network Protocol implementation. > > It sends a DHCP request and analyzes the DHCP offer. > > Different error conditions including a

Re: [U-Boot] [PATCH v2 01/17] efi_loader: call EFI_EXIT in efi_copy_mem, efi_set_mem

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > EFI_ENTRY and EFI_EXIT calls must match. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_boottime.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [U-Boot] [PATCH v2 16/17] efi_selftest: allow printing MAC addresses

On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > Add %pm as format string to print a MAC address. > This is helpful when analyzing network problems. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- >

Re: [U-Boot] [PATCH v2 09/17] efi_net: return EFI_UNSUPPORTED where appropriate

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > U-Boot does not implement all functions of the simple network > protocol. The unimplemented functions return either of > EFI_SUCCESS and EFI_INVALID_PARAMETER. > > The UEFI spec foresees to return EFI_UNSUPPORTED in

Re: [U-Boot] [PATCH 030/080] serial: ns16550: Fix style violation

On 29 September 2017 at 06:51, Mario Six wrote: > Clarify the computation precedence in two ternary operator > constructions. > > Signed-off-by: Mario Six > --- > drivers/serial/ns16550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [U-Boot] [PATCH v2 05/17] efi_loader: incorrect definition of EFI_SIMPLE_NETWORK_PROTOCOL

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > WaitForPacket is an event and not a function pointer. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH 008/080] core: read: Fix style violations

On 29 September 2017 at 06:51, Mario Six wrote: > There are some whitespace-related style violations in read.c; fix those. > > Signed-off-by: Mario Six > --- > drivers/core/read.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-)

Re: [U-Boot] [PATCH v2 15/17] efi_selftest: correct definition of efi_st_error

On 5 October 2017 at 08:36, Heinrich Schuchardt wrote: > Enclose definition in parantheses to allow using efi_st_error > like a void function. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_selftest.h | 4 ++-- >

Re: [U-Boot] [PATCH v2 04/17] efi_loader: wrong type in wait_for_event

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > The UEFI spec defines parameter index of WaitForEvent as UINTN*. > So we should use size_t here. > > I deliberately do not use UINTN because I hold a following patch > that will eliminate UINTN because uppercase types to

Re: [U-Boot] [PATCH v2 07/17] efi_loader: fill simple network protocol revision

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > Provide the simple network protocol revision. > This revision number could be used to identify backwards compatible > enhancements of the protocol. > > Signed-off-by: Heinrich Schuchardt > --- > v2 >

Re: [U-Boot] [PATCH v2 08/17] efi_loader: efi_net: hwaddr_size = 6

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > The length of a MAC address is 6. > We have to set this length in the EFI_SIMPLE_NETWORK_MODE > structure of the EFI_SIMPLE_NETWORK_PROTOCOL. > > Without this patch iPXE fails to initialize the network with > error

Re: [U-Boot] [PATCH v2 03/17] efi_loader: pass GUIDs as const efi_guid_t *

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > We need to call some boottime services internally. > Our GUIDs are stored as const efi_guid_t *. > > The boottime services never change GUIDs. > So we can define the parameters as const efi_guid_t *. > > Signed-off-by:

Re: [U-Boot] efi_loader: Fix disk dp's for pre-DM/legacy devices

> This fixes an issue with OpenBSD's bootloader, and I think should also > fix a similar issue with grub2 on legacy devices. In the legacy case > we were creating disk objects for the partitions, but not also the > parent device. > > Reported-by: Jonathan Gray > Signed-off-by:

Re: [U-Boot] [PATCH 06/11] efi_loader: implement SetWatchdogTimer

On 08.10.17 06:57, Heinrich Schuchardt wrote: > The watchdog is initialized with a 5 minute timeout period. > It can be reset by SetWatchdogTimer. > It is stopped by ExitBoottimeServices. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/bootefi.c | 1 + >

Re: [U-Boot] [PATCH 1/1] rockchip: provide installation instruction for Firefly-RK3399.

On 27 September 2017 at 21:35, Heinrich Schuchardt wrote: > Unfortunately installing U-Boot on an SD card for the Firefly-RK3399 > is not trivial. > > I could not get U-Boot running with SPL. So I ended up using the > Rockchip miniloader. > > Adding a README hopefully will

Re: [U-Boot] [PATCH v2 02/17] efi_loader: parameters of CopyMem and SetMem

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > The UEFI spec defines the length parameters of CopyMem and SetMem > as UINTN. We should size_t here. > > The source buffer of CopyMem should be marked as const. > > Signed-off-by: Heinrich Schuchardt

Re: [U-Boot] [PATCH 10/10] efi_selftest: check notification of ExitBootServices

Hi Heinrich, On 25 September 2017 at 00:01, Heinrich Schuchardt wrote: > > On 09/25/2017 04:12 AM, Simon Glass wrote: > > Hi Heinrich, > > > > On 15 September 2017 at 02:06, Heinrich Schuchardt > > wrote: > >> Check that the notification function of an >

Re: [U-Boot] [PATCH v2 06/17] efi_loader: correct bits of receive_filters bit mask

On 5 October 2017 at 08:35, Heinrich Schuchardt wrote: > Remove extraneous commas. > Add comment. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 11 ++- > 1 file changed, 6 insertions(+), 5

Re: [U-Boot] [PATCH 1/1] efi_selftest: use efi_st_error for all error messages

On 4 October 2017 at 04:37, Heinrich Schuchardt wrote: > All error messages in the selftests should use efi_st_error. > efi_st_error will print the file name and line number of the error. > > Splitting message texts due to lines being over 80 > characters is avoided. This

Re: [U-Boot] [PATCH v2 1/1] efi_selftest: make tests easier to read

Hi Heinrich, On 4 October 2017 at 07:31, Heinrich Schuchardt wrote: > Rename counter to more illustrative names. > Update notification function description. > Simplify notification function. > Add comment for arbitrary non-zero value. > Document @return. > Use constants for

Re: [U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

On Sun, Oct 08, 2017 at 11:33:08AM -0400, Rob Clark wrote: > This fixes an issue with OpenBSD's bootloader, and I think should also > fix a similar issue with grub2 on legacy devices. In the legacy case > we were creating disk objects for the partitions, but not also the > parent device. > >

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Sun, Oct 08, 2017 at 10:56:26PM -0300, Fabio Estevam wrote: > On Sun, Oct 8, 2017 at 11:04 AM, Jonathan Gray wrote: > > > It turns out to be > > > > commit 2460098cffacd18729262e3ed36656e6943783ed > > Author: Tom Rini > > Date: Fri Sep 22 07:37:43 2017

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Sun, Oct 8, 2017 at 11:04 AM, Jonathan Gray wrote: > It turns out to be > > commit 2460098cffacd18729262e3ed36656e6943783ed > Author: Tom Rini > Date: Fri Sep 22 07:37:43 2017 -0400 > > fs/fat: Reduce stack usage > > We have limited stack in SPL

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Sat, Oct 7, 2017 at 1:23 PM, Rob Clark wrote: > On Fri, Oct 6, 2017 at 10:08 PM, Jonathan Gray wrote: >> On Fri, Oct 06, 2017 at 08:21:26AM -0400, Rob Clark wrote: >>> On Fri, Oct 6, 2017 at 12:35 AM, Jonathan Gray wrote: >>> > On Thu, Oct

[U-Boot] efi_loader: enough-uefi-for-shell: [PATCH 06/11] efi_loader: implement SetWatchdogTimer

On 10/08/2017 06:57 AM, Heinrich Schuchardt wrote: > The watchdog is initialized with a 5 minute timeout period. > It can be reset by SetWatchdogTimer. > It is stopped by ExitBoottimeServices. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/bootefi.c | 1

[U-Boot] [PATCH] ARM: tegra: Remove unused define CONFIG_ARMCORTEXA9

This macro isn't used by anything, and in fact hasn't ever been used according to the Git logs. Signed-off-by: Tuomas Tynkkynen --- include/configs/tegra-common.h | 1 - scripts/config_whitelist.txt | 1 - 2 files changed, 2 deletions(-) diff --git

[U-Boot] [PATCH 2/2] configs: Re-sync CONFIG_CMD_IMLS with moveconfig

The option is specified in Kconfig, but still a few config header files are overriding the choice by #undef'ing it. Re-sync the option with moveconfig to rid of the #undefs. Signed-off-by: Tuomas Tynkkynen --- configs/ls1012afrdm_qspi_defconfig | 1 -

Re: [U-Boot] [PATCH] usb: xhci: Add Renesas R-Car xHCI driver

On Sun, Oct 08, 2017 at 08:34:46PM +0200, Marek Vasut wrote: > Add firmware V3, firmware loader and XHCI glue for the Renesas R-Car > Gen3 SoCs XHCI controller. Thus far only the R-Car Gen3 R8A7795 ES2.0+ > and R8A7796 are supported. > > Signed-off-by: Marek Vasut

[U-Boot] [PATCH] usb: xhci: Add Renesas R-Car xHCI driver

Add firmware V3, firmware loader and XHCI glue for the Renesas R-Car Gen3 SoCs XHCI controller. Thus far only the R-Car Gen3 R8A7795 ES2.0+ and R8A7796 are supported. Signed-off-by: Marek Vasut Cc: Nobuhiro Iwamatsu ---

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

On Sun, Oct 8, 2017 at 12:41 PM, Alexander Graf wrote: > > >> Am 08.10.2017 um 17:54 schrieb Rob Clark : >> >>> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt >>> wrote: >>> Patch efi_loader: add stub HII protocols uses UINTN

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

> Am 08.10.2017 um 17:54 schrieb Rob Clark : > >> On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt >> wrote: >> Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent >> comment Simon remarked that types should not be uppercase.

Re: [U-Boot] [PATCH 1/1] efi_loader: use type bool for event states

On Wed, Oct 4, 2017 at 12:02 PM, Heinrich Schuchardt wrote: > Patch efi_loader: add stub HII protocols uses UINTN heavily. In a recent > comment Simon remarked that types should not be uppercase. So I was > planning to replace all occurences of UINTN by size_t in an upcoming

[U-Boot] [PATCH] efi_loader: Fix disk dp's for pre-DM/legacy devices

This fixes an issue with OpenBSD's bootloader, and I think should also fix a similar issue with grub2 on legacy devices. In the legacy case we were creating disk objects for the partitions, but not also the parent device. Reported-by: Jonathan Gray Signed-off-by: Rob Clark

Re: [U-Boot] [PATCH] cmd/gpt.c, cmd/nvedit.c, tools/fit_image.c: Rework recent fixes for Coverity

On Sat, Oct 07, 2017 at 08:19:21PM -0400, Tom Rini wrote: > The recent changes to these files did not completely fix the previous > issues, or introduced different (minor) issues. In cmd/gpt.c we need to > dereference str_disk_guid to be sure that malloc worked. In > cmd/nvedit.c we need to be

Re: [U-Boot] [PATCH] Travis-CI: Fix microblaze and xilinx jobs

On Sat, Oct 07, 2017 at 08:19:22PM -0400, Tom Rini wrote: > Given how we handle the ARM toolchain we can't easily combine these two > jobs, so don't. Give xilinx/ARM a separate build. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [U-Boot] Please pull u-boot-x86

On Sat, Oct 07, 2017 at 03:16:26PM +0800, Bin Meng wrote: > Hi Tom, > > The following changes since commit 3ea0520512089cffbe02b7d6eb645cdfddb09c5c: > > disk: part_dos: Use the original allocation scheme for the SPL case > (2017-10-05 10:45:33 -0400) > > are available in the git repository

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Sun, Oct 08, 2017 at 09:56:15AM -0300, Fabio Estevam wrote: > On Sat, Oct 7, 2017 at 10:06 PM, Jonathan Gray wrote: > > > I wonder if you have the same kind of fat filesystem. > > No, I have only used ext4 file system. > > > Can you try writing > >

Re: [U-Boot] Please pull u-boot-x86

On Sat, 2017-10-07 at 16:32 +0800, Bin Meng wrote: +Cc: Ferry (he might be interested in this thread) > > Edison?! Edison is dead (end), as I know it... Some people don't think so, there are ones who like the board. Actually, while working for Linux kernel at Intel I'm using that board on

Re: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case

On Sat, Oct 7, 2017 at 10:06 PM, Jonathan Gray wrote: > I wonder if you have the same kind of fat filesystem. No, I have only used ext4 file system. > Can you try writing > https://ftp.openbsd.org/pub/OpenBSD/snapshots/armv7/miniroot-cubox-62.fs > to an sd card then write a new