Re: [U-Boot] [PATCH v2 03/10] tiny-printf: Reorder code to support %p

2020-02-03 Thread Vignesh Raghavendra
Faiz, On 31/01/20 11:44 pm, Simon Glass wrote: > Hi Vignesh, > > On Thu, 30 Jan 2020 at 22:12, Vignesh Raghavendra wrote: >> >> Hi Simon, >> >> On 31/01/20 7:57 am, Simon Glass wrote: >>> Hi Faiz, >>> >>> On Thu, 30 Jan 2020 at 08:22, Faiz Abbas wrote: Hi Simon, On 22/10/19

RE: [EXT] Re: [Patch v4 0/7] Transition of fsl qspi driver to spi-mem framework

2020-02-03 Thread Kuldeep Singh
++Joe Hi, > -Original Message- > From: Jagan Teki > Sent: Monday, January 27, 2020 3:44 PM > To: Schrempf Frieder ; Kuldeep Singh > > Cc: U-Boot-Denx ; Priyanka Jain > ; Ashish Kumar ; Stefan > Roese ; Vignesh R > Subject: Re: [EXT] Re: [Patch v4 0/7] Transition of fsl qspi driver to

Re: [PATCH v2 07/17] x86: apl: Drop the I2C config in FSP-S

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > This config is not actually used here and in U-Boot it seems better to set > this using the device tree for each individual controller. The monolithic > config of the FSP-S is only necessary if the FSP is actually configuring > something, but

Re: [PATCH v2 05/17] x86: Add a clock driver for Intel devices

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > So far we have avoided adding a clock driver for Intel devices. But the > Designware I2C driver needs a different clock (133MHz) on Intel devices > than on others (166MHz). Add a simple driver that provides this > information. > > This driver

Re: [PATCH v2 08/17] x86: coral: Update i2c and rtc status

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > These are actually working correctly, so update the status. > > Signed-off-by: Simon Glass > --- > > Changes in v2: None > > doc/board/google/chromebook_coral.rst | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 04/17] tegra: i2c: Change driver to use helper function

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > Now that we have uclass_first_device_drvdata(), use it from the I2C driver > to reduce code duplication. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to change tegra driver to use helper function > >

Re: [PATCH v2 03/17] dm: core: Change syscon to use helper function

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > Now that we have uclass_first_device_drvdata(), use it from syscon to > reduce code duplication. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Add new patch to change syscon to use helper function > >

Re: [PATCH v2 02/17] dm: core: Add a function to find a device by drvdata

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > It is sometimes useful to find a device in a uclass using only its driver > data. The driver data often indicates the 'subtype' of the device, e,g, > via its compatible string. > > Add a function to handle this. > > Signed-off-by: Simon Glass

Re: [PATCH v2 01/17] dm: core: Allow iterating devices without uclass_get()

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > At present we have uclass_foreach_dev() which requires that uclass_get() > be called beforehand to find the uclass. This is good if we suspect that > that function might fail, but often we know that the uclass is available. > > Add a new

Re: [PATCH v2] dm: uclass: don't assign aliased seq numbers

2020-02-03 Thread Michal Simek
On 03. 02. 20 18:16, Michael Walle wrote: > Hi Simon, > > Am 2020-01-30 03:16, schrieb Simon Glass: >> Hi Michael, >> >> On Fri, 20 Dec 2019 at 06:29, Michael Walle wrote: >>> >>> If there are aliases for an uclass, set the base for the "dynamically" >>> allocated numbers next to the highest

Re: [RFC PATCH 03/10] i2c: mmc: add nexell driver (gpio, i2c, mmc, pwm)

2020-02-03 Thread Heiko Schocher
Hello Stefan, Am 03.02.2020 um 21:40 schrieb Stefan Bosch: Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - i2c/nx_i2c.c: Some adaptions mainly because of changes in "struct udevice". - mmc: nexell_dw_mmc.c changed to nexell_dw_mmc_dm.c (switched to DM). Signed-off-by: Stefan

Please pull u-boot-x86

2020-02-03 Thread Bin Meng
Hi Tom, This PR includes the following changes for v2020.04: - Various minor fixes for x86 - Switch to ACPI mode on Intel edison - Support run-time configuration for NS16550 driver - Update coreboot and slimbootloader serial drivers to use NS16550 run-time configuration - ICH SPI driver fixes to

[PATCH] configs: lx2160a: Define ENV_SECT_SIZE

2020-02-03 Thread Kuldeep Singh
LX2160ARDB/QDS has mt35xu512aba flash with 128K sector size. Define ENV_SECT_SIZE value as 0x2. Signed-off-by: Kuldeep Singh --- configs/lx2160aqds_tfa_defconfig | 3 ++- configs/lx2160ardb_tfa_defconfig | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 04/10] mmc: sdhci: Expose sdhci_init() as non-static

2020-02-03 Thread Faiz Abbas
Hi, On 31/01/20 3:55 am, Simon Goldschmidt wrote: > Am 30.01.2020 um 23:21 schrieb Jaehoon Chung: >> Hi Simon, >> >> On 1/29/20 11:16 PM, Simon Goldschmidt wrote: >>> On Wed, Jan 29, 2020 at 12:00 AM Jaehoon Chung >>> wrote: On 1/24/20 8:52 PM, Faiz Abbas wrote: > Expose

[PATCH v7 08/10] include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 & main_r5fss0_core0

2020-02-03 Thread Keerthy
Add env variables for mcu_r5fss0_core0 & main_r5fss0_core0 firmware loadaddr and name. Signed-off-by: Keerthy --- include/configs/j721e_evm.h | 4 1 file changed, 4 insertions(+) diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h index 4371c471e5..fc73a9c932 100644 ---

[PATCH v7 10/10] configs: j721e_evm_r5_defconfig: Remove saving ENV in eMMC

2020-02-03 Thread Keerthy
Remove saving ENV in eMMC in R5 as the power domains are not setup. Environment in eMMC cannot be read if we do not boot from eMMC. Signed-off-by: Keerthy --- configs/j721e_evm_r5_defconfig | 4 1 file changed, 4 deletions(-) diff --git a/configs/j721e_evm_r5_defconfig

[PATCH v7 09/10] configs: j721e_evm_r5: Enable R5F remoteproc support

2020-02-03 Thread Keerthy
Enable R5F remoteproc support in R5 defconfig so that R5s can be started in SPL. While at it enable the SPL_FS_EXT4 config option to load the firmwares from file system. Signed-off-by: Keerthy Signed-off-by: Lokesh Vutla --- configs/j721e_evm_r5_defconfig | 2 ++ 1 file changed, 2

[PATCH v7 05/10] armv7R: K3: Add support for jumping to firmware

2020-02-03 Thread Keerthy
MCU Domain rf50 is currently shutting down after loading the ATF. Load elf firmware and jump to firmware post loading ATF. ROM doesn't enable ATCM memory, so make sure that firmware that is being loaded doesn't use ATCM memory or override SPL. Signed-off-by: Keerthy Signed-off-by: Lokesh Vutla

[PATCH v7 06/10] arm: dts: k3-j721e-r5-u-boot: Add fs_loader node

2020-02-03 Thread Keerthy
Add fs_loader node which will be needed for loading firmwares from the boot media/filesystem. Signed-off-by: Keerthy Reviewed-by: Tom Rini --- .../dts/k3-j721e-r5-common-proc-board-u-boot.dtsi | 15 +++ 1 file changed, 15 insertions(+) create mode 100644

[PATCH v7 07/10] arm: dts: k3-j721e-r5: Enable r5fss0 cluster in SPL

2020-02-03 Thread Keerthy
Enable MAIN domain r5fss0 cluster and its core0 in R5 spl. Signed-off-by: Keerthy Reviewed-by: Tom Rini --- .../dts/k3-j721e-r5-common-proc-board-u-boot.dtsi| 12 arch/arm/dts/k3-j721e-r5-common-proc-board.dts | 2 ++ 2 files changed, 14 insertions(+) diff --git

[PATCH v7 03/10] arm: k3: Add support for loading non linux remote cores

2020-02-03 Thread Keerthy
Add MAIN domain R5FSS0 remoteproc support from spl. This enables loading the elf firmware in SPL and starting the remotecore. In order to start the core, there should be a file with path "/lib/firmware/j7-main-r5f0_0-fw" under filesystem of respective boot mode. Signed-off-by: Keerthy

[PATCH v7 01/10] env: nowhere: set default enviroment

2020-02-03 Thread Keerthy
In case only CONFIG_ENV_IS_NOWHERE without any of the memory based configs like CONFIG_ENV_IS_IN_MMC the env_set function fails as the gd->flags & GD_FLG_ENV_READY check fails. Set default enviroment so that set_env calls succeed when only ENV_IS_NOWHERE set. Signed-off-by: Keerthy Reviewed-by:

[PATCH v7 02/10] lib: elf: Move the generic elf loading/validating functions to lib

2020-02-03 Thread Keerthy
Move the generic elf loading/validating functions to lib/ so that they can be re-used and accessed by code existing outside cmd. While at it remove the duplicate static version of load_elf_image_phdr under arch/arm/mach-imx/imx_bootaux.c. Signed-off-by: Keerthy Suggested-by: Simon Goldschmidt

[PATCH v7 04/10] armv7R: K3: r5_mpu: Enable execute permission for MCU0 BTCM

2020-02-03 Thread Keerthy
Enable execute permission for mcu_r5fss0_core0 BTCM so that we can jump to a firmware directly from SPL. Signed-off-by: Keerthy --- arch/arm/mach-k3/r5_mpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/r5_mpu.c b/arch/arm/mach-k3/r5_mpu.c index

[PATCH v7 00/10] Add support for loading main_r5fss0_core0

2020-02-03 Thread Keerthy
This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0. Tested for firmware loading and execution on J721e. Changes in v7: * Added BSD-2 SPDX on lib/elf.c file. * Added Tom's Reviewed-by for the relevant patches. Changes in v6: * Fixed the imx build issue. Changes in v5: *

[PATCH] configs: lx2160a: Define ENV_ADDR value

2020-02-03 Thread Kuldeep Singh
CONFIG_ENV_ADDR helps in picking environment from flash before DDR init. Define the value as 0x2050 for lx2160ardb and lx2160aqds. Signed-off-by: Kuldeep Singh --- Hi Priyanka, This patch can be applied after applying below patch.

Re: [PATCH v5 02/10] lib: elf: Move the generic elf loading/validating functions to lib

2020-02-03 Thread Keerthy
On 29/01/20 9:27 pm, Tom Rini wrote: On Tue, Jan 28, 2020 at 04:21:07PM +0530, Keerthy wrote: Move the generic elf loading/validating functions to lib/ so that they can be re-used and accessed by code existing outside cmd. Signed-off-by: Keerthy Suggested-by: Simon Goldschmidt

[PATCH v2 12/12] configs: j721e_hs_evm: Enable OSPI related configs

2020-02-03 Thread Vignesh Raghavendra
Enable OSPI related configs for J721e HS variant. Signed-off-by: Vignesh Raghavendra --- configs/j721e_hs_evm_a72_defconfig | 8 +++- configs/j721e_hs_evm_r5_defconfig | 7 +++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/configs/j721e_hs_evm_a72_defconfig

[PATCH v2 11/12] configs: ama65x_hs_evm: Enable OSPI related configs

2020-02-03 Thread Vignesh Raghavendra
Enable OSPI related defconfigs for AM65x HS variant. Signed-off-by: Vignesh Raghavendra --- configs/am65x_hs_evm_a53_defconfig | 26 ++ configs/am65x_hs_evm_r5_defconfig | 19 +++ 2 files changed, 45 insertions(+) diff --git

[PATCH v2 09/12] configs: am65x_evm_defconfig: Enable OSPI configs

2020-02-03 Thread Vignesh Raghavendra
Enable OSPI related defconfigs. Also enable SPL_DMA so that DMA is used during OSPI boot Signed-off-by: Vignesh Raghavendra --- configs/am65x_evm_a53_defconfig | 25 + configs/am65x_evm_r5_defconfig | 17 + 2 files changed, 42 insertions(+) diff --git

[PATCH v2 07/12] configs: j721e_evm: Setup mtdparts for OSPI

2020-02-03 Thread Vignesh Raghavendra
Set up mtdparts cmdline argument to be passed to kernel Signed-off-by: Vignesh Raghavendra --- include/configs/j721e_evm.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h index

[PATCH v2 08/12] configs: j721e_evm_defconfig: Enable OSPI configs

2020-02-03 Thread Vignesh Raghavendra
Enable OSPI related defconfigs. Also enable SPL_DMA so that DMA is used during OSPI boot Signed-off-by: Vignesh Raghavendra --- configs/j721e_evm_a72_defconfig | 9 - configs/j721e_evm_r5_defconfig | 7 +++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git

[PATCH v2 10/12] board: ti: Update AM65x and J721e READMEs for OSPI boot

2020-02-03 Thread Vignesh Raghavendra
Update AM65x and J721e README files with instructions for flashing OSPI images. Signed-off-by: Vignesh Raghavendra --- board/ti/am65x/README | 55 +++ board/ti/j721e/README | 47 2 files changed, 102 insertions(+)

[PATCH v2 05/12] ARM: dts: k3-j721e: Add OSPI DT nodes

2020-02-03 Thread Vignesh Raghavendra
Add OSPI DT nodes to enable OSPI at U-Boot prompt and also to support OSPI boot. Signed-off-by: Vignesh Raghavendra --- .../k3-j721e-common-proc-board-u-boot.dtsi| 16 arch/arm/dts/k3-j721e-common-proc-board.dts | 33 arch/arm/dts/k3-j721e-mcu-wakeup.dtsi

[PATCH v2 06/12] configs: am65x_evm: Setup mtdparts for OSPI

2020-02-03 Thread Vignesh Raghavendra
Set up mtdparts cmdline argument to be passed to kernel Signed-off-by: Vignesh Raghavendra --- include/configs/am65x_evm.h | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h index

[PATCH v2 00/12] TI: AM654/J721e: Add support to boot from OSPI

2020-02-03 Thread Vignesh Raghavendra
This series adds support to boot from OSPI on TI's AM654 and J721e SoCs. These EVMs have Micron MT35x flash and works in 1-1-8 mode. v2: Update READMEs for OSPI boot Update HS EVM defconfigs to fix build issues Lokesh Vutla (1): ARM: mach-k3: sysfw-loader: Use SPI memmapped addr when loading

[PATCH v2 04/12] ARM: dts: k3-am65: Add OSPI DT nodes

2020-02-03 Thread Vignesh Raghavendra
Add OSPI DT nodes to enable OSPI at U-Boot prompt and also to support OSPI boot. Signed-off-by: Vignesh Raghavendra --- arch/arm/dts/k3-am65-mcu.dtsi| 38 +++ arch/arm/dts/k3-am65.dtsi| 13 ++- arch/arm/dts/k3-am654-base-board-u-boot.dtsi

[PATCH v2 02/12] ARM: mach-k3: arm64-mmu: map 64bit FSS MMIO space in A53 MMU

2020-02-03 Thread Vignesh Raghavendra
Populate address mapping entries in A53 MMU for 4 GB of MMIO space reserved for providing MMIO access to multiple flash devices through OSPI/HBMC IPs within FSS. Signed-off-by: Vignesh Raghavendra --- arch/arm/mach-k3/arm64-mmu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v2 03/12] ARM: mach-k3: sysfw-loader: Use SPI memmapped addr when loading SYSFW

2020-02-03 Thread Vignesh Raghavendra
From: Lokesh Vutla Since ROM configures OSPI controller to be in memory mapped mode in OSPI boot, R5 SPL can directly pass the memory mapped pointer to ROM. With this ROM can directly pull the SYSFW image from OSPI. Signed-off-by: Lokesh Vutla Signed-off-by: Vignesh Raghavendra ---

[PATCH v2 01/12] drivers: Descend to drivers/soc unconditionally

2020-02-03 Thread Vignesh Raghavendra
Descend to drivers/soc directory unconditionally for SPL and U-Boot builds. Individual drivers can have their own config to check what needs to be built for SPL. There should be no increase in SPL code size due to this change. This is required on K3 SoCs to support DMA in SPL. Signed-off-by:

Re: [PATCH v2 04/17] tegra: i2c: Change driver to use helper function

2020-02-03 Thread Heiko Schocher
Hello Simon, Am 04.02.2020 um 01:19 schrieb Simon Glass: Now that we have uclass_first_device_drvdata(), use it from the I2C driver to reduce code duplication. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to change tegra driver to use helper function

Re: [PATCH 2/2] x86: apl: Include ITSS driver

2020-02-03 Thread Bin Meng
On Mon, Feb 3, 2020 at 10:23 PM Bin Meng wrote: > > On Mon, Feb 3, 2020 at 9:07 PM Wolfgang Wallner > wrote: > > > > Atuomatically select the ITSS driver when building for Apollo Lake. > > > > Signed-off-by: Wolfgang Wallner > > > > --- > > > > arch/x86/cpu/apollolake/Kconfig | 1 + > > 1 file

Re: [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 10:35 AM Bin Meng wrote: > > Hi Wolfgang, > > On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner > wrote: > > > > Currently the ITSS driver is built unconditionally. Add a Kconfig option > > to support enabling/disabling the inclusion of the ITSS driver depending > > on the

Re: [PATCH 1/5] x86: fsp: Allow skipping init code when chain loading

2020-02-03 Thread Bin Meng
Hi Simon, On Tue, Feb 4, 2020 at 1:15 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 3 Feb 2020 at 10:10, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Feb 4, 2020 at 12:20 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Mon, 3 Feb 2020 at 04:05, Bin Meng wrote: > > > > > > > > Hi

Re: [PATCH] board: stih410-b2260: remove fdt_high and initrd_high

2020-02-03 Thread Tom Rini
On Mon, Feb 03, 2020 at 03:00:59PM +0100, Patrice Chotard wrote: > Remove fdt_high and initrd_high as they shouldn't be used, > this allows the fdt and initrd relocation. > This implies to set CONFIG_SYS_BOOTMAPSZ to indicate the > amount of memory available to contain kernel, device tree > and

Re: [PULL] u-boot-socfpga/master

2020-02-03 Thread Tom Rini
On Mon, Feb 03, 2020 at 09:47:04AM +0100, Marek Vasut wrote: > On 2/3/20 9:24 AM, Marek Vasut wrote: > > On 2/2/20 9:26 PM, Tom Rini wrote: > >> On Sun, Feb 02, 2020 at 06:18:53PM +0100, Marek Vasut wrote: > >> > >>> The following changes since commit > >>>

Re: [PATCH] ls1043a: Remove "fdt_high" environment variable

2020-02-03 Thread Tom Rini
On Mon, Feb 03, 2020 at 05:32:27PM +0800, Wen He wrote: > Remove "fdt_high" environment variable to use the bootm_size(or set > CONFIG_SYS_BOOTMAPSZ) to amount of memory available to safely contain > a kernel, device tree and initrd for relocation. > > Signed-off-by: Wen He > --- >

Re: [PATCH] ls1021a: Set CONFIG_SYS_BOOTMAPSZ to the memory for relocation

2020-02-03 Thread Tom Rini
On Mon, Feb 03, 2020 at 03:25:19PM +0800, Alison Wang wrote: > This patch sets CONFIG_SYS_BOOTMAPSZ to the amount of memory available > to safely contain a kernel, device tree and initrd for relocation. The > way to set fdt_high as 0x to disable device tree relocation is > removed. > >

Re: [PATCH 0/7] J721e: Add support for DFU boot mode

2020-02-03 Thread Lokesh Vutla
On 27/01/20 5:59 PM, Vignesh Raghavendra wrote: > This series adds support to boot via USB DFU mode. Series pulled into u-boot-ti tree. Thanks and regards, Lokesh

Re: [PATCH 1/3] watchdog: omap_wdt: Fix WDT timeout configuration

2020-02-03 Thread Lokesh Vutla
On 24/01/20 10:14 AM, Marek Vasut wrote: > The timeout parameter of omap3_wdt_start() is in miliseconds, while > GET_WLDR_VAL() expects parameter in seconds. Fix this so the WDT > driver is actually usable. > > Signed-off-by: Marek Vasut > Cc: Grygorii Strashko > Cc: Sam Protsenko > Cc:

Re: [PATCH] gpio: pca953x_gpio: Add support for 24 bit IO expander

2020-02-03 Thread Lokesh Vutla
On 27/01/20 11:19 PM, Vignesh Raghavendra wrote: > J721e EVM has a TCA6424 IO expander that has 24 GPIOs. Add support for > the same > > Signed-off-by: Vignesh Raghavendra pulled into u-boot-ti tree. Thanks and regards, Lokesh

Re: [PATCH 0/4] J721e: Add I2C nodes

2020-02-03 Thread Lokesh Vutla
On 27/01/20 11:22 PM, Vignesh Raghavendra wrote: > Add I2C and I2C IO expander nodes Series pulled into u-boot-ti tree. Thanks and regards, Lokesh

Re: [PATCH v4 00/10] am57xx: Implement Android 10 boot flow

2020-02-03 Thread Lokesh Vutla
On 24/01/20 9:23 PM, Sam Protsenko wrote: > Android 10 brings a lot of new requirements for bootloaders: [1]. This > patch series attempts to implement such a boot process on BeagleBoard > X15 platform. Some common code is added too, which can be reused later > for other platforms (see

[GIT PULL] TI changes for v2020.04-rc2

2020-02-03 Thread Lokesh Vutla
Hi Tom, Please find the pull request for v2020.04-rc2 containing TI specific changes. This PR is a re spin of previous PR[0] without mmc changes and fetched few dt changes and watchdog fixes. [0] https://patchwork.ozlabs.org/patch/1230709/ Travis-CI build:

Re: [PATCH 0/9] TI: AM654/J721e: Add support to boot from OSPI

2020-02-03 Thread Lokesh Vutla
On 29/01/20 5:48 PM, Vignesh Raghavendra wrote: > This series adds support to boot from OSPI on TI's AM654 and J721e SoCs. > These EVMs have Micron MT35x flash and works in 1-1-8 mode. This is causing build failures on hs configs. Can you fix it and repost? Thanks and regards, Lokesh > >

Re: [PATCH 0/2] x86: serial: Use NS16550_DYNAMIC in Slim Bootloader

2020-02-03 Thread Park, Aiden
Hi Bin, > On Feb 3, 2020, at 7:03 PM, Bin Meng wrote: > > Hi Aiden, > >> On Wed, Dec 18, 2019 at 1:56 PM Park, Aiden wrote: >> >> Slim Bootloader provides serial port info in its HOB to support >> both IO or MMIO serial ports, but it's controlled by SYS_NS16550_MEM32 >> or

Re: [PATCHv5 1/5] mmc: meson-gx: Fix clk phase tuning for MMC

2020-02-03 Thread Anand Moon
Hi Jerome, Thanks for your review comments, On Mon, 3 Feb 2020 at 23:14, Jerome Brunet wrote: > > > On Mon 03 Feb 2020 at 17:38, Anand Moon wrote: > > > Hi Jerome, > > > > Thanks for your review, > > > > On Mon, 3 Feb 2020 at 21:11, Jerome Brunet wrote: > >> > >> > >> On Mon 03 Feb 2020 at

Re: [PATCH 0/2] x86: serial: Use NS16550_DYNAMIC in Slim Bootloader

2020-02-03 Thread Bin Meng
Hi Aiden, On Wed, Dec 18, 2019 at 1:56 PM Park, Aiden wrote: > > Slim Bootloader provides serial port info in its HOB to support > both IO or MMIO serial ports, but it's controlled by SYS_NS16550_MEM32 > or SYS_NS16550_PORT_MAPPED in U-Boot. > To support both serial port configurations

Re: [PATCH v2 3/3] gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

2020-02-03 Thread Bin Meng
Hi Andy, On Mon, Feb 3, 2020 at 8:34 PM Andy Shevchenko wrote: > > On Mon, Feb 3, 2020 at 12:38 PM Wolfgang Wallner > wrote: > > > > Fix the following in intel_gpio_get_value(): > > > > * The value of the register is contained in the variable 'reg', not in > >'mode'. The variable 'mode'

Re: [PATCH v2 3/3] gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

2020-02-03 Thread Bin Meng
On Mon, Feb 3, 2020 at 6:38 PM Wolfgang Wallner wrote: > > Fix the following in intel_gpio_get_value(): > > * The value of the register is contained in the variable 'reg', not in >'mode'. The variable 'mode' contains only the configuration whether >the gpio is currently an input or an

Re: [PATCH v2 2/3] gpio: intel_gpio: Clear tx state bit when setting output

2020-02-03 Thread Bin Meng
On Mon, Feb 3, 2020 at 6:38 PM Wolfgang Wallner wrote: > > Add missing 'PAD_CFG0_TX_STATE' to the clear mask for pcr_clrsetbits32(). > Otherwise this bit cannot be cleared again after it has been set once. > > Signed-off-by: Wolfgang Wallner > Reviewed-by: Simon Glass > Reviewed-by: Bin Meng >

Re: [PATCH v2 1/3] gpio: intel_gpio: Pass pinctrl device to pcr_clrsetbits32()

2020-02-03 Thread Bin Meng
On Mon, Feb 3, 2020 at 6:48 PM Bin Meng wrote: > > On Mon, Feb 3, 2020 at 6:38 PM Wolfgang Wallner > wrote: > > > > The function pcr_clrsetbits32() expects a device with a P2SB parent > > device. In intel_gpio_direction_output() and intel_gpio_set_value() > > the device 'dev' is passed to

Re: [PATCH] azure: Move to vs2017-win2016 platform build host

2020-02-03 Thread Bin Meng
On Mon, Feb 3, 2020 at 10:20 PM Bin Meng wrote: > > On Mon, Feb 3, 2020 at 8:25 PM Tom Rini wrote: > > > > Azure is moving to remove the vs2015-win2012r2 platform build host. The > > two suggested new platforms to use are vs2017-win2016 and windows-2019. > > For now, move up to vs2017-win2016.

Re: [PATCH 1/2] x86: itss: Add a Kconfig option to enable/disable ITSS driver

2020-02-03 Thread Bin Meng
Hi Wolfgang, On Mon, Feb 3, 2020 at 9:06 PM Wolfgang Wallner wrote: > > Currently the ITSS driver is built unconditionally. Add a Kconfig option > to support enabling/disabling the inclusion of the ITSS driver depending > on the platform. > > Signed-off-by: Wolfgang Wallner > --- > >

Re: [PATCH v2 08/13] dm: irq: Add support for requesting interrupts

2020-02-03 Thread Bin Meng
Hi Simon, On Tue, Feb 4, 2020 at 8:19 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 3 Feb 2020 at 10:05, Bin Meng wrote: > > > > Hi Simon, > > > > On Sun, Dec 22, 2019 at 2:16 AM Simon Glass wrote: > > > > > > At present driver model supports the IRQ uclass but there is no way to > > > request

[PATCH v2 16/17] tpm: Add a driver for H1/Cr50

2020-02-03 Thread Simon Glass
H1 is a Google security chip present in recent Chromebooks, Pixel phones and other devices. Cr50 is the name of the software that runs on H1 in Chromebooks. This chip is used to handle TPM-like functionality and also has quite a few additional features. Add a driver for this. Signed-off-by:

[PATCH v2 14/17] x86: coral: Add I2C and TPM device-tree definitions

2020-02-03 Thread Simon Glass
Add nodes to the device tree for Cr50 and other available I2C ports. Also enable the ACPI interrupt driver. Signed-off-by: Simon Glass --- Changes in v2: - Move intel-clock.h inclusion to the correct patch arch/x86/cpu/apollolake/Kconfig | 1 + arch/x86/dts/chromebook_coral.dts | 88

[PATCH v2 15/17] tpm: Add more TPM2 definitions

2020-02-03 Thread Simon Glass
Add definitions for access and status. Need to drop the mixed case. Signed-off-by: Simon Glass --- Changes in v2: None include/tpm-v2.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index ae00803f6d..d53d2e4023 100644

[PATCH v2 17/17] x86: coral: Enable TPM

2020-02-03 Thread Simon Glass
Enable TPM2 so that we can use cr50. Signed-off-by: Simon Glass --- Changes in v2: - Update the commit message - Add new patches to handle requesting interrupts and interrupt state configs/chromebook_coral_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 11/17] x86: itss: Add of-platdata support

2020-02-03 Thread Simon Glass
Allow this driver to be used in TPL by setting up the interrupt type correctly. Signed-off-by: Simon Glass --- Changes in v2: None arch/x86/cpu/intel_common/itss.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/x86/cpu/intel_common/itss.c

[PATCH v2 13/17] x86: Add support for ACPI general-purpose events

2020-02-03 Thread Simon Glass
ACPI GPEs are used to signal interrupts from peripherals that are accessed via ACPI. In U-Boot these are modelled as interrupts using a separate interrupt controller. Configuration is via the device tree. Add a simple driver for this. Signed-off-by: Simon Glass --- Changes in v2: None

[PATCH v2 10/17] x86: Give each driver an IRQ type

2020-02-03 Thread Simon Glass
Add an IRQ type to each driver and use irq_first_device_type() to find and probe the correct one. Signed-off-by: Simon Glass --- Changes in v2: - Move 'success' comment into previous patch arch/x86/cpu/apollolake/fsp_s.c | 4 ++-- arch/x86/cpu/i386/interrupt.c| 3 ++-

[PATCH v2 12/17] dm: irq: Add support for requesting interrupts

2020-02-03 Thread Simon Glass
At present driver model supports the IRQ uclass but there is no way to request a particular interrupt for a driver. Add a mechanism, similar to clock and reset, to read the interrupts required by a device from the device tree and to request those interrupts. U-Boot itself does not have

[PATCH v2 07/17] x86: apl: Drop the I2C config in FSP-S

2020-02-03 Thread Simon Glass
This config is not actually used here and in U-Boot it seems better to set this using the device tree for each individual controller. The monolithic config of the FSP-S is only necessary if the FSP is actually configuring something, but here it is not. The FSP-S does enable/disable the various

[PATCH v2 09/17] dm: irq: Add support for interrupt controller types

2020-02-03 Thread Simon Glass
There can be different types of interrupt controllers in a system and some drivers may need to distinguish between these. In general this can be handled using the device tree by adding the interrupt information to device nodes. However on x86 devices we have interrupt controllers which are not

[PATCH v2 05/17] x86: Add a clock driver for Intel devices

2020-02-03 Thread Simon Glass
So far we have avoided adding a clock driver for Intel devices. But the Designware I2C driver needs a different clock (133MHz) on Intel devices than on others (166MHz). Add a simple driver that provides this information. This driver can be expanded later as needed. Signed-off-by: Simon Glass

[PATCH v2 04/17] tegra: i2c: Change driver to use helper function

2020-02-03 Thread Simon Glass
Now that we have uclass_first_device_drvdata(), use it from the I2C driver to reduce code duplication. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to change tegra driver to use helper function drivers/i2c/tegra_i2c.c | 13 + 1 file changed, 1 insertion(+), 12

[PATCH v2 08/17] x86: coral: Update i2c and rtc status

2020-02-03 Thread Simon Glass
These are actually working correctly, so update the status. Signed-off-by: Simon Glass --- Changes in v2: None doc/board/google/chromebook_coral.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/board/google/chromebook_coral.rst b/doc/board/google/chromebook_coral.rst index

[PATCH v2 03/17] dm: core: Change syscon to use helper function

2020-02-03 Thread Simon Glass
Now that we have uclass_first_device_drvdata(), use it from syscon to reduce code duplication. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to change syscon to use helper function drivers/core/syscon-uclass.c | 15 --- 1 file changed, 4 insertions(+), 11

[PATCH v2 06/17] x86: apl: Use the clock driver

2020-02-03 Thread Simon Glass
Enable the Intel clock driver and modify coral's device tree to use it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: - Move intel-clock.h inclusion to the correct patch arch/x86/cpu/apollolake/Kconfig | 3 +++ arch/x86/dts/chromebook_coral.dts | 5 + 2 files

[PATCH v2 01/17] dm: core: Allow iterating devices without uclass_get()

2020-02-03 Thread Simon Glass
At present we have uclass_foreach_dev() which requires that uclass_get() be called beforehand to find the uclass. This is good if we suspect that that function might fail, but often we know that the uclass is available. Add a new helper which does this uclass_get() automatically, so that only the

[PATCH v2 02/17] dm: core: Add a function to find a device by drvdata

2020-02-03 Thread Simon Glass
It is sometimes useful to find a device in a uclass using only its driver data. The driver data often indicates the 'subtype' of the device, e,g, via its compatible string. Add a function to handle this. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to find a device by drvdata

[PATCH v2 00/17] x86: coral: Add support for Cr50

2020-02-03 Thread Simon Glass
This series adds a driver for the Cr50 security chip and enables it on coral. This supports the 'tpm' command. In order to make this work a few other changes are included: - Additional UCLASS_IRQ operations to support requesting and reading interrupts, using the device tree - A driver for ACPI

Re: [PATCH v2 08/13] dm: irq: Add support for requesting interrupts

2020-02-03 Thread Simon Glass
Hi Bin, On Mon, 3 Feb 2020 at 10:05, Bin Meng wrote: > > Hi Simon, > > On Sun, Dec 22, 2019 at 2:16 AM Simon Glass wrote: > > > > At present driver model supports the IRQ uclass but there is no way to > > request a particular interrupt for a driver. > > > > Add a mechanism, similar to clock and

Re: [PATCH v3 05/12] dm: Add support for simple-pm-bus

2020-02-03 Thread Sean Anderson
> Please can you add a test for this new functionality? Should this be separate from test/dm/bus.c? As far as I can tell, that file tests the concept of busses, and not the bus uclass. --Sean

Re: [PATCH v3 04/12] reset: Add generic reset driver

2020-02-03 Thread Sean Anderson
> Is there a sandbox test for this driver somewhere in your series? There is not. Presumably if such a test were to exist, it would try asserting different resets, and then check to see if the associated register got changed. However, I am confused as to where such a test would be located. There

Re: [U-Boot] [PATCH] fit: Do not automatically decompress ramdisk images

2020-02-03 Thread Rasmus Villemoes
On 08/08/2019 05.16, Tom Rini wrote: > On Fri, Aug 02, 2019 at 03:52:28PM -0700, Julius Werner wrote: > >> The Linux ramdisk should always be decompressed by the kernel itself, >> not by U-Boot. Therefore, the 'compression' node in the FIT image should >> always be set to "none" for ramdisk

Re: [PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-02-03 Thread Anatolij Gustschin
On Mon, 3 Feb 2020 09:47:08 -0500 Tom Rini tr...@konsulko.com wrote: ... > > yes, this evb board config is common across most of the rk3399 > > defconfig boards. this patch enable hdmi on few rk3399 boards all use > > same config file, evb_rk3399.h > > Yes, the ROCKCHIP_DEVICE_SETTINGS part

[PATCH] video: add opt out option for VIDEO_BBP selection

2020-02-03 Thread Anatolij Gustschin
Enable all BPP options by default to avoid empty video console output (this was the case before commit 2cc393f32fd9 ("video: make BPP and ANSI configs optional")). But also support optional selection of only required VIDEO_BBP settings. Signed-off-by: Anatolij Gustschin ---

[PATCH v2] cmd: Add command to dump drivers and compatible strings

2020-02-03 Thread Sean Anderson
This adds a subcommand to dm to dump out what drivers are installed, and their compatible strings. I have found this useful in ensuring that I have the correct drivers compiled, and that I have put in the correct compatible strings. Signed-off-by: Sean Anderson --- Changes for v2: - Check if

[RFC PATCH 10/10] arm: add (default) config for nanopi2 board

2020-02-03 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - Configuration changed, mainly several "CONFIG_..." moved from s5p4418_nanopi2.h to s5p4418_nanopi2_defconfig. - s5p4418_nanopi2.h: "CONFIG_" removed from several s5p4418/nanopi2 specific defines because the appropriate values do

[RFC PATCH 09/10] arm: add support for SoC s5p4418 (cpu) / nanopi2 board

2020-02-03 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - SPL not supported yet --> no spl-dir in arch/arm/cpu/armv7/s5p4418/. Appropriate line in Makefile removed. - cpu.c: '#include ' added. - arch/arm/cpu/armv7/s5p4418/u-boot.lds removed, is not required anylonger. - s5p4418.dtsi:

[RFC PATCH 08/10] video: add nexell video driver (display/video driver)

2020-02-03 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - nexell_display.c: Changed to DM, CONFIG_FB_ADDR can not be used anymore because framebuffer is allocated by video_reserve() in video-uclass.c. Therefore code changed appropriately. Signed-off-by: Stefan Bosch ---

[RFC PATCH 07/10] video: add nexell video driver (soc: dpc, makefile)

2020-02-03 Thread Stefan Bosch
Low level functions for DPC (Display Controller) and Makefile for all nexell video low level functions. Signed-off-by: Stefan Bosch --- drivers/video/nexell/soc/Makefile | 11 + drivers/video/nexell/soc/s5pxx18_soc_dpc.c | 1569

[RFC PATCH 06/10] video: add nexell video driver (soc: lvds, hdmi)

2020-02-03 Thread Stefan Bosch
Low level functions for LVDS and HDMI display interfaces. Signed-off-by: Stefan Bosch --- drivers/video/nexell/soc/s5pxx18_soc_hdmi.c | 50 +++ drivers/video/nexell/soc/s5pxx18_soc_hdmi.h | 488 drivers/video/nexell/soc/s5pxx18_soc_lvds.c | 278

[RFC PATCH 05/10] video: add nexell video driver (soc: mlc, mipi)

2020-02-03 Thread Stefan Bosch
Low level functions for MLC (Multi Layer Control) and MIPI (Mobile Industry Processor Interface). Signed-off-by: Stefan Bosch --- drivers/video/nexell/soc/s5pxx18_soc_mipi.c | 580 + drivers/video/nexell/soc/s5pxx18_soc_mipi.h | 291 + drivers/video/nexell/soc/s5pxx18_soc_mlc.c

[RFC PATCH 04/10] video: add nexell video driver (soc: displaytop)

2020-02-03 Thread Stefan Bosch
Low level functions for DisplayTop (Display Topology). Signed-off-by: Stefan Bosch --- drivers/video/nexell/soc/s5pxx18_soc_disptop.c | 185 ++ drivers/video/nexell/soc/s5pxx18_soc_disptop.h | 385 + drivers/video/nexell/soc/s5pxx18_soc_disptop_clk.c | 309

[RFC PATCH 03/10] i2c: mmc: add nexell driver (gpio, i2c, mmc, pwm)

2020-02-03 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - i2c/nx_i2c.c: Some adaptions mainly because of changes in "struct udevice". - mmc: nexell_dw_mmc.c changed to nexell_dw_mmc_dm.c (switched to DM). Signed-off-by: Stefan Bosch --- drivers/gpio/Kconfig | 9 +

[RFC PATCH 02/10] arm: add mach-nexell (all files except header files)

2020-02-03 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - SPL not supported yet --> no spl-directory in arch/arm/mach-nexell. Appropriate line in Makefile removed. - clock.c: 'section(".data")' added to declaration of clk_periphs[] and core_hz. - Kconfig: Changes to have a structure like

[RFC PATCH 01/10] arm: add mach-nexell (header files)

2020-02-03 Thread Stefan Bosch
Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - DM_VIDEO support (display_dev.h). - boot0.h added, handles NSIH --> tools/nexell obsolete. - gpio.h: Include-path to errno.h changed. Signed-off-by: Stefan Bosch --- arch/arm/mach-nexell/include/mach/boot0.h| 40 +++

  1   2   3   >