> -Original Message-
> From: Kuldeep Singh
> Sent: Thursday, February 20, 2020 10:58 PM
> To: u-boot@lists.denx.de
> Cc: Frieder Schrempf ; Stefan Roese
> ; Priyanka Jain ; Jagan Teki
> ; Stefano Babic ; Fabio
> Estevam ; Vignesh Raghavendra ;
> Kuldeep Singh ; Ashish Kumar
>
>
We cannot rely on a parent bus that needs to be probed, until we know that
it is probed. That means that code in the ofdata_to_platdata() method
cannot rely on the parent bus being probed.
Move the ofdata code in the two serial drivers into a probe() method.
This fixes serial output on
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
the UARTs do not correctly select the pinconfig to enable the UART pins.
Fix this so that the U-Boot banner is printed.
This fixes serial output on rpi_3b_32b with the following config.txt
options:
enable_uart=1
On 2020/3/19 上午12:22, Miquel Raynal wrote:
Depending on the SoC, a header of four characters is prepended to the
image. There is already a macro defining the number of characters:
RK_SPL_HDR_SIZE, so use it instead of hardcoding "4".
Signed-off-by: Miquel Raynal
Reviewed-by: Kever Yang
Hi Tom,
On Thu, 2 Jan 2020 at 20:59, Tom Rini wrote:
>
> On Thu, Jan 02, 2020 at 07:28:50PM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Thu, 2 Jan 2020 at 19:27, Simon Glass wrote:
> > >
> > > Hi Tom,
> > >
> > > On Thu, 2 Jan 2020 at 16:11, Tom Rini wrote:
> > > >
> > > > On Tue, Dec 31,
Currently the code only flushes the first RX descriptor, not every entry
in the RX descriptor ring. Fix this, to make sure the DMA engine can pick
the RX descriptors correctly.
Signed-off-by: Marek Vasut
Cc: Joe Hershberger
Cc: Patrice Chotard
Cc: Patrick Delaunay
Cc: Ramon Fried
Cc: Stephen
The current code polls the RX desciptor ring for new packets by reading
the RX descriptor status. This works by accident, as the RX descriptors
are often in non-cacheable memory. However, the driver does support use
of RX descriptors in cacheable memory.
This patch adds a missing RX descriptor
The DMA may attempt to write a DMA descriptor in the ring while it is
being updated. By writing the DMA descriptor buffer address to 0, it
is assured the DMA will not use such a buffer and the buffer can be
updated without any interference.
Signed-off-by: Marek Vasut
Cc: Joe Hershberger
Cc:
This patch prevents an issue where the RX packet might have been
accessed by the CPU, which now has cached data from the packet in
the caches and possibly various write buffers, and these data may
be evicted from the caches into the DRAM while the buffer is also
written by the DMA.
By
This code programs the next descriptor in the TX descriptor ring into
the hardware as the last valid TX descriptor. The problem is that if
the currenty descriptor is the last one in the array, the code will
not wrap around correctly and use TX descriptor 0 again, but instead
will use TX descriptor
The RX descriptor field 3 should contain only OWN and BUF1V bits before
being used for receiving data by the DMA engine. However, right now, if
the descriptor was already used for receiving data and is being cleared,
the field 3 is only modified and the aforementioned two bits are ORRed
into the
Hi Jaehoon,
> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
>
> On 3/18/20 10:00 AM, Peng Fan wrote:
> >> Subject: Re: [PATCH v2 0/3] Support SDMA mode on RPI4 target - 32bit
> >>
> >> Hi
> >>
> >> Is there any comment or plan to apply?
> >
> > Sorry, I missed this
On 03/03/2020 13.19, Rasmus Villemoes wrote:
> On 28/01/2020 13.04, Rasmus Villemoes wrote:
>> [resending with Mario's correct address, sorry for the double post]
>>
>> The driver correctly uses the shadow register when asked for the
>> current value of an output gpio. Unfortunately, it does RMW
This patchset passed travis:
https://travis-ci.org/github/giuliobenetti/u-boot-imxrt/builds/665577905?utm_medium=notification_source=email
And also:
./tools/buildman/buildman.py --branch=dev/imxrt-lcdif odroid edison
trats trats2 imxrt --show_errors --force-build --count=19
Sorry I've sent this patch twice.
--
Giulio Benetti
Benetti Engineering sas
On 3/22/20 11:44 PM, Giulio Benetti wrote:
Add lcdif node to SoC.
Signed-off-by: Giulio Benetti
---
arch/arm/dts/imxrt1050.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git
mxsfb needs a dcache function not implemented in cortex-M7, so for the
moment let's keep dcache not enabled.
Signed-off-by: Giulio Benetti
---
configs/imxrt1050-evk_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configs/imxrt1050-evk_defconfig b/configs/imxrt1050-evk_defconfig
Enable DM_VIDEO subsystem and its BACKLIGHT_GPIO. Then enable
SYS_WHITE_ON_BLACK to have classic black background on display. Need
also to enable CONFIG_SYS_CONSOLE_ENV_OVERWRITE to retrieve
stdin/stdout/stderr from CONFIG_EXTRA_ENV_SETTINGS.
Signed-off-by: Giulio Benetti
---
Add lcdif node and its pinctrl.
Signed-off-by: Giulio Benetti
---
arch/arm/dts/imxrt1050-evk.dts | 60 ++
1 file changed, 60 insertions(+)
diff --git a/arch/arm/dts/imxrt1050-evk.dts b/arch/arm/dts/imxrt1050-evk.dts
index 56b75986e2..b5e781275e 100644
---
Add lcdif node to SoC.
Signed-off-by: Giulio Benetti
---
arch/arm/dts/imxrt1050.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050.dtsi
index b1d98e6feb..0123f4788c 100644
--- a/arch/arm/dts/imxrt1050.dtsi
+++
Linux doesn't provide skeleton.dtsi file so let's remove its include and
provide #address-cells/size-cells = <1> that were defined in
skeleton.dtsi before.
Signed-off-by: Giulio Benetti
---
arch/arm/dts/imxrt1050.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
ENABLE signal can now be flipped by writing its bitmask on vdctrl0
register.
Signed-off-by: Giulio Benetti
---
drivers/video/mxsfb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 648e1c22fe..8a5a61c9fb 100644
---
Add lcdif node to SoC.
Signed-off-by: Giulio Benetti
---
arch/arm/dts/imxrt1050.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050.dtsi
index b1d98e6feb..0123f4788c 100644
--- a/arch/arm/dts/imxrt1050.dtsi
+++
Allow using DM CLK instead of mxs_set_lcdclk() so we can avoid to
implement a special function to set lcd clock on i.MXRT.
Signed-off-by: Giulio Benetti
---
drivers/video/mxsfb.c | 30 +-
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git
i.MXRT1050 provides mxsfb compatible lcd controller, so let's enable
video mxsfb driver with 16bpp depth if CONFIG_DM_VIDEO is selected since
board has 16bpp only connection.
Signed-off-by: Giulio Benetti
---
include/configs/imxrt1050-evk.h | 15 +++
1 file changed, 15 insertions(+)
struct display_timings provides more informations such clock and DE
polarity, so let's refactor the code to use struct display_timings
instead of struct ctfb_res_modes, so we'll become able to get clock and
DE polarity settings and set register according to them in the next patch.
Signed-off-by:
HSYNC signal can now be flipped according to display_flags bitmaks by
writing its bitmask on vdctrl0 register.
Signed-off-by: Giulio Benetti
---
drivers/video/mxsfb.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/video/mxsfb.c
DOTCLK signal can now be flipped by writing its bitmask on vdctrl0
register.
Signed-off-by: Giulio Benetti
---
drivers/video/mxsfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 4d33e24e1a..648e1c22fe 100644
---
This function converts from "struct ctf_res_modes" to
"struct display_timing".
Signed-off-by: Giulio Benetti
---
drivers/video/videomodes.c | 29 +
drivers/video/videomodes.h | 3 +++
2 files changed, 32 insertions(+)
diff --git a/drivers/video/videomodes.c
Add support for i.MXRT by adding CONFIG_IMXRT in register structure and
adding .compatible = "fsl,imxrt-lcdif".
Signed-off-by: Giulio Benetti
---
arch/arm/include/asm/arch-imxrt/imx-regs.h | 6 ++
arch/arm/include/asm/mach-imx/regs-lcdif.h | 6 +++---
drivers/video/mxsfb.c
Since video_ctfb_mode_to_display_timing() has been implemented by moving
sunxi_ctfb_mode_to_display_timing() to video_modes.c and it's meant to be
used by other video subsystem, let's use it instead of local
sunxi_ctfb_mode_to_display_timing().
Signed-off-by: Giulio Benetti
---
VSYNC signal can now be flipped by writing its bitmask on vdctrl0
register.
Signed-off-by: Giulio Benetti
---
drivers/video/mxsfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 9912cf3d82..4d33e24e1a 100644
--- a/drivers/video/mxsfb.c
Need to add set_parent() callback to allow dts assigned-clock-parents to
work so let's add it accordingly.
Signed-off-by: Giulio Benetti
---
V1->V2:
* introduce patch to allow clock's parent setting in dts to work
---
drivers/clk/imx/clk-imxrt1050.c | 19 +++
1 file changed, 19
"video:" must be "video", ":" is a typo.
Signed-off-by: Giulio Benetti
Reviewed-by: Lukasz Majewski
---
drivers/clk/imx/clk-imxrt1050.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c
index
pllv3 PLLs have powerdown/up bits but enable bits too. Specifically
"enable bit" enable the pll output, so when dis/enabling pll by
setting/clearing power_bit we must also set/clear enable_bit.
Signed-off-by: Giulio Benetti
Reviewed-by: Lukasz Majewski
---
drivers/clk/imx/clk-pllv3.c | 9
mxsfb needs PLL5 as source, so let's setup it at its default frequency
specified in RM(650Mhz).
Signed-off-by: Giulio Benetti
Reviewed-by: Lukasz Majewski
---
V1->V2:
* removed LCDIF set_parent() since it's setup in dts file(suggested by Fabio)
---
drivers/clk/imx/clk-imxrt1050.c | 9 -
This patchset add support for LCDIF on i.MXRT1050 evk. This requires
PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd
has inverted PIXCLOCK from dts.
With this patchset applied we temporary loose DCache support until it will
get implemented, since a function in mxsfb.c is
As with other related ClearFog patches, I haven't received any review
responses on this series
(http://patchwork.ozlabs.org/project/uboot/list/?series=155760) and
would like to ping out for additional review. I'd especially like
feedback on the approach for support of multiple SCSI devices, if
I just wanted to ping on this review
(http://patchwork.ozlabs.org/project/uboot/list/?series=155850). I
haven't seen any review feedback, so would like to check if it's
agreeably in a state ready for merging in the next merge window or if
there are issues.
Thanks!
Joel
On 2020-01-29 07:50,
I just wanted to ping on this review
(http://patchwork.ozlabs.org/project/uboot/list/?series=155533) to see
if it had reached an agreeable state or if there were still lingering
issues. I've been using it without issue against RC releases.
If the plan is to not include it in v2020.04 that's
Hi Harald,
On Sun, 22 Mar 2020 at 03:56, Harald Seiler wrote:
>
> Hi Simon,
>
> On Sat, 2020-03-21 at 13:07 -0600, Simon Glass wrote:
> > Hi Harald,
> >
> > On Mon, 24 Feb 2020 at 06:27, Harald Seiler wrote:
> > > Hello Simon,
> > >
> > > On Sun, 2020-02-23 at 19:34 -0700, Simon Glass wrote:
>
Hi All,
On 2/26/20 6:15 PM, Giulio Benetti wrote:
This patchset add support for LCDIF on i.MXRT1050 evk. This requires
PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd
has inverted PIXCLOCK from dts.
With this patchset applied we temporary loose DCache support until it
Hi Lukasz, Fabio,
On 3/9/20 10:11 AM, Lukasz Majewski wrote:
On Sun, 8 Mar 2020 22:05:42 +0100
Giulio Benetti wrote:
Hi Lukasz,
On 3/8/20 9:27 PM, Lukasz Majewski wrote:
On Wed, 26 Feb 2020 18:15:46 +0100
Giulio Benetti wrote:
mxsfb needs PLL5 as source, so let's setup it and set it
On Sun, Mar 22, 2020 at 2:06 AM Marek Vasut wrote:
>
> Replace combination of malloc()+memset() with calloc() as the behavior
calloc() -> kzalloc()
to sync with the actual code.
Please fix the subject as well.
> is exactly the same and the amount of code is reduced.
>
> Signed-off-by:
'vendor' is both an input and an output parameter. So it cannot be
constant.
Fixes: 0bda81bfdc5c ("efi_loader: use const efi_guid_t * for variable services")
Signed-off-by: Heinrich Schuchardt
---
include/efi_api.h | 2 +-
include/efi_loader.h | 2 +-
On 3/22/20 4:17 PM, Simon Glass wrote:
> Hi Marek,
Hi,
> On Sat, 21 Mar 2020 at 20:15, Marek Vasut wrote:
>>
>> On 3/22/20 3:08 AM, Simon Glass wrote:
>>> Hi Marek,
>>
>> Hi,
>>
>>> I think at this point we've covered all the ground and mentioned the
>>> pros and cons of each method, so I'll
Hi Marek,
On Sat, 21 Mar 2020 at 20:15, Marek Vasut wrote:
>
> On 3/22/20 3:08 AM, Simon Glass wrote:
> > Hi Marek,
>
> Hi,
>
> > I think at this point we've covered all the ground and mentioned the
> > pros and cons of each method, so I'll leave the discussion where it
> > is.
>
> Great, so
Hello,
I use u-boot for raspberry, but i have a different behavior between
rpi3b and rpi4b.
* i use the same u-boot source files (2020.04-rc3-00161-g14eb12a3c8)
* i use the same method for compiling ( make -j4 ARCH=arm
CROSS_COMPILE=aarch64-linux-gnu- all )
* i use the same dhcp/tftp server
On 3/22/20 2:00 PM, Lukasz Majewski wrote:
> This code adds check if QT_TOKEN_STATUS_XACTERR error occurred. When it is
> detected the token is reconfigured and transmission is retried.
>
> This code is the port to newest U-Boot of the fix from - "rayvt" (from [1]).
>
> Links:
> [1] -
On 3/22/20 2:00 PM, Lukasz Majewski wrote:
[...]
> diff --git a/common/usb_storage.c b/common/usb_storage.c
> index 92e1e54d1c..3c2324fa1a 100644
> --- a/common/usb_storage.c
> +++ b/common/usb_storage.c
> @@ -729,6 +729,7 @@ static int usb_stor_BBB_transport(struct scsi_cmd *srb,
> struct
On 3/22/20 2:00 PM, Lukasz Majewski wrote:
> This change provides some extra time for some slow (or degraded) USB devices
> to become fully operational.
>
> This code is the port to newest U-Boot of the fix from - "rayvt" (from [1]).
>
> Links:
> [1] -
On 3/22/20 2:00 PM, Lukasz Majewski wrote:
> This change brings support for handling XACTERR error during DATA phase
> of USB BBB (bulk) transmission.
>
> The fix is to clear stall'ed endpoint and reset recovery on the USB mass
> storage class.
>
> This code is the port to newest U-Boot of the
On 3/22/20 2:00 PM, Lukasz Majewski wrote:
> This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6.
>
> Signed-off-by: Lukasz Majewski
This patch lacks any and all explanation why this is being reverted. The
patch you are reverting here explains why it was added and what real
issues it
This code adds check if QT_TOKEN_STATUS_XACTERR error occurred. When it is
detected the token is reconfigured and transmission is retried.
This code is the port to newest U-Boot of the fix from - "rayvt" (from [1]).
Links:
[1] - https://forum.doozan.com/read.php?3,35295,35295#msg-35295
[2] -
This change brings support for handling XACTERR error during DATA phase
of USB BBB (bulk) transmission.
The fix is to clear stall'ed endpoint and reset recovery on the USB mass
storage class.
This code is the port to newest U-Boot of the fix from - "rayvt" (from [1]).
Links:
[1] -
This change provides some extra time for some slow (or degraded) USB devices
to become fully operational.
This code is the port to newest U-Boot of the fix from - "rayvt" (from [1]).
Links:
[1] - https://forum.doozan.com/read.php?3,35295,35295#msg-35295
[2] -
This reverts commit 02b0e1a36c5bc20174299312556ec4e266872bd6.
Signed-off-by: Lukasz Majewski
---
drivers/usb/host/ehci-hcd.c | 51 ++---
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
After this change USB mass storage devices - mostly HDDs connected via USB
- will gain handling of extra time needed for their spin up.
This operation is realized with issuing SCSI start/stop unit (0x1B) command.
This code is the port to newest U-Boot of the fix from - "rayvt" (from [1]).
This patch set is rather a request for testing (and a starting point for the
discussion), as it may improve the robustness of USB with some pendrives - and
yes sacrifice some performance for reliability.
The previous version of this patch: https://patchwork.ozlabs.org/patch/1244928/
fixed issue
Modify the ls_pcie_dump_atu function, make it can print the INBOUND
windows registers.
Signed-off-by: Xiaowei Bao
---
drivers/pci/pcie_layerscape.c| 25 +
drivers/pci/pcie_layerscape.h| 2 +-
drivers/pci/pcie_layerscape_ep.c | 3 +++
Add the INBOUND configuration for VFs of PF.
Signed-off-by: Xiaowei Bao
---
drivers/pci/pcie_layerscape.c| 8 +---
drivers/pci/pcie_layerscape.h| 13 -
drivers/pci/pcie_layerscape_ep.c | 34 +-
3 files changed, 42 insertions(+), 13
The VF_BARn_REG register's Prefetchable and Type bit fields
are overwritten by a write to VF's BAR Mask register.
workaround: Before writing to the VF_BARn_MASK_REG register,
write 0b to the PCIE_MISC_CONTROL_1_OFF register.
Signed-off-by: Xiaowei Bao
---
drivers/pci/pcie_layerscape_ep.c | 9
Due to the ls2085a and ls2080a use difference way to set the BAR size,
so add the BAR size init code here.
Signed-off-by: Xiaowei Bao
---
drivers/pci/pcie_layerscape_ep.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pcie_layerscape_ep.c
Add the PCIe EP mode support for lx2160a-v2 platform.
Signed-off-by: Xiaowei Bao
---
drivers/pci/pcie_layerscape.h| 9 -
drivers/pci/pcie_layerscape_ep.c | 8 +++-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie_layerscape.h
Split the RC and EP driver, and reimplement the EP driver base on
the EP framework.
Signed-off-by: Xiaowei Bao
---
drivers/pci/Makefile| 2 +-
drivers/pci/pcie_layerscape.c | 492 +++-
drivers/pci/pcie_layerscape.h | 44 +++-
Add the multiple function support for Layerscape platform, some PEXs
of Layerscaple platform have more than one PF.
Signed-off-by: Xiaowei Bao
---
drivers/pci/pcie_layerscape.c| 6 +-
drivers/pci/pcie_layerscape.h| 21 +--
drivers/pci/pcie_layerscape_ep.c | 119
Add the PCIe EP node for ls1046a.
Signed-off-by: Xiaowei Bao
---
arch/arm/dts/fsl-ls1046a.dtsi | 33 +
1 file changed, 33 insertions(+)
diff --git a/arch/arm/dts/fsl-ls1046a.dtsi b/arch/arm/dts/fsl-ls1046a.dtsi
index fdf93fd..e4b4a8e 100644
---
Some EP deivces need to initialize before RC scan it, e.g. NXP
layerscape platform, so add the init function in pci_ep uclass.
Signed-off-by: Xiaowei Bao
---
common/board_r.c | 12
drivers/pci_endpoint/pci_ep-uclass.c | 11 +++
include/init.h
Dear Harald,
In message you wrote:
>
> I added something similar to this in our DENX internal tbot configurations but
> did not yet publish it anywhere (maybe I should add it to tbot_contrib?).
> Just
Yes, please do!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH,
The runtime service GetNextVariable() returns the length of the next
variable including the closing 0x. This length should be in bytes.
Comparing the output of EDK2 and U-Boot shows that this is currently not
correctly implemented:
EDK2:
OsIndicationsSupported: 46
PlatformLang: 26
The runtime service GetNextVariable() returns the length of the next
variable including the closing 0x. This length should be in bytes.
Comparing the output of EDK2 and U-Boot shows that this is currently not
correctly implemented:
EDK2:
OsIndicationsSupported: 46
PlatformLang: 26
GetNextVariableName should report the length of the variable including the
final 0x in bytes.
Check this in the unit test.
Increase the buffer size for variable names. 40 bytes is too short.
Signed-off-by: Heinrich Schuchardt
---
v2:
Increase the buffer size for variable names.
---
Hi Simon,
On Sat, 2020-03-21 at 13:07 -0600, Simon Glass wrote:
> Hi Harald,
>
> On Mon, 24 Feb 2020 at 06:27, Harald Seiler wrote:
> > Hello Simon,
> >
> > On Sun, 2020-02-23 at 19:34 -0700, Simon Glass wrote:
> > > Hi Heiko,
> > >
> > > Thanks for the hints! I pushed your things here:
> > >
For EFI binaries we have to provide an implementation of memmove() in
efi_freestanding.c.
Before this patch the memmove() function was copying in the wrong
direction.
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_freestanding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Provide unit tests for CalculateCrc32(), CopyMem(), SetMem().
Signed-off-by: Heinrich Schuchardt
---
lib/efi_selftest/Makefile | 1 +
lib/efi_selftest/efi_selftest_mem.c | 77 +
2 files changed, 78 insertions(+)
create mode 100644
Correct the description of function efi_convert_pointer().
Signed-off-by: Heinrich Schuchardt
---
lib/efi_loader/efi_runtime.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/efi_runtime.c b/lib/efi_loader/efi_runtime.c
index 4be51335bc..6a25acbbcd 100644
75 matches
Mail list logo
