Re: [PATCH] net: tftp: fix option validation as per RFCs

2020-05-22 Thread Ramon Fried
On Tue, May 19, 2020 at 7:36 AM Ravik Hasija wrote: > > RFC2348, RFC2349: > - Option string is case in-sensitive. > - Client must generate ERR pkt in case option value mismatch in server OACK > - Fix debug print for options > > Signed-off-by: Ravik Hasija > --- > > net/tftp.c | 59

Re: [PATCH] net: tftp: fix progress marker for file transfer

2020-05-22 Thread Ramon Fried
On Fri, May 8, 2020 at 2:16 PM Ravik Hasija wrote: > > During packet sequence number wraparound the show_block_marker() API was > not called, as a result the progress marker doesn't stay within column > boundary. Use position in file instead of sequence number to align the > marker. > >

Re: Warnings on Edison

2020-05-22 Thread Ferry Toth
Op 20-05-2020 om 16:16 schreef Andy Shevchenko: On Wed, May 20, 2020 at 09:35:34AM -0400, Tom Rini wrote: ... as Edison still works. I believe no-one who is building it from sources for Edison uses that old ACPICA tools. Building with Yocto we are on 20190215

[PATCH] Clean up the Spansion/Cypress/Infineon device ID table

2020-05-22 Thread bacem . daassi
From: Bacem Daassi Signed-off-by: Bacem Daassi Clean up the Spansion/Cypress/Infineon device ID table. Remove s25fl512s_256k since it's a duplicate of s25fl512s. Remove s25fl512s_64k and s25fl512s_512k since these devices do not exist. Rename s25fl128s to s25fl128s1. Add the new

Re: [PATCH 0/5] Enable I2C in SPL, support runtime detection of add-on board

2020-05-22 Thread Chen-Yu Tsai
Hi, On Sat, May 23, 2020 at 2:04 AM wrote: > > From: Suniel Mahesh > > This patch series adds runtime detection of add-on board(ROC-RK3399-PC > Mezzanine) by > enabling I2C in SPL. > This add on board hosts a CW2015 chip which is connected as slave to I2C2. In > order > to dynamically detect

Re: rk3399 - Rock Pi 4 PCIe

2020-05-22 Thread Anthony Davies
Just applied it and rebooted all 4 with success. Given it is an intermittent issue I will do some more testing on the morrow. Thanks for the help, its greatly appreciated. On Fri, 22 May 2020 at 22:36, Mark Kettenis wrote: > > From: Anthony Davies > > Date: Fri, 22 May 2020 10:49:12 +1000 > >

[PATCH] tbs2910: migrate to DM_VIDEO

2020-05-22 Thread Anatolij Gustschin
Migration to DM_VIDEO driver is long overdue, configure it in board config files. To enable the display set stdout like: setenv stdout serial,vidconsole Signed-off-by: Anatolij Gustschin --- This is only build tested. configs/tbs2910_defconfig | 7 ++- include/configs/tbs2910.h | 2 --

[PULL] u-boot-usb/master

2020-05-22 Thread Marek Vasut
The following changes since commit 2fa581ba910368d0f7f995fb906d6c5e4218b594: Merge git://git.denx.de/u-boot-sh (2020-05-21 08:26:40 -0400) are available in the Git repository at: git://git.denx.de/u-boot-usb.git master for you to fetch changes up to

[PULL] u-boot-socfpga/net

2020-05-22 Thread Marek Vasut
So here are some more network patches for 2020.07 , the patches were posted even before 2020.04 . However, I would really like Joe to come back soon. CI passes: https://gitlab.denx.de/u-boot/custodians/u-boot-socfpga/pipelines/3367 The following changes since commit

Re: [PATCH 00/26] x86: video: Speed up the framebuffer

2020-05-22 Thread Simon Glass
Hi Bin, On Fri, 22 May 2020 at 17:09, Bin Meng wrote: > > Hi Simon, > > On Sat, May 23, 2020 at 12:34 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Fri, 22 May 2020 at 09:30, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Wed, May 20, 2020 at 7:11 AM Simon Glass wrote: > > > > > > >

Re: [PATCH 1/1] MAINTAINERS: add doc/driver-model/ to DRIVER MODEL

2020-05-22 Thread Simon Glass
On Wed, 20 May 2020 at 15:24, Heinrich Schuchardt wrote: > > The documentation should rest with the same maintainer as the code. > > Signed-off-by: Heinrich Schuchardt > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Simon Glass

Re: [RFC 1/6] dtoc: add support to scan drivers

2020-05-22 Thread Simon Glass
Hi Walter, On Thu, 21 May 2020 at 07:15, Walter Lozano wrote: > > Hi Simon, > > On 20/5/20 00:07, Simon Glass wrote: > > Hi Walter, > > > > On Wed, 13 May 2020 at 14:13, Walter Lozano > > wrote: > >> Currently dtoc scans dtbs to convert them to struct platdata and > >> to generate

Re: [PATCH 3/3] doc: rockchip: Remove list of supported boards

2020-05-22 Thread Simon Glass
Hi Walter, On Fri, 22 May 2020 at 16:39, Walter Lozano wrote: > > Hi Ezequiel, > > On 22/5/20 18:37, Ezequiel Garcia wrote: > > On Fri, 22 May 2020 at 11:16, Walter Lozano > > wrote: > >> As documentation is being moved to doc/boards/rockchip create a warning > >> message and remove the

Re: [PATCH v6 1/2] usb: provide a device tree node to USB devices

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 10:38, Michael Walle wrote: > > It is possible to specify a device tree node for an USB device. This is > useful if you have a static USB setup and want to use aliases which > point to these nodes, like on the Raspberry Pi. > The nodes are matched against their hub port

Re: [RFC 2/6] core: extend struct driver_info to point to device

2020-05-22 Thread Simon Glass
Hi Walter, On Thu, 21 May 2020 at 07:15, Walter Lozano wrote: > > Hi Simon, > > On 20/5/20 00:07, Simon Glass wrote: > > Hi Walter, > > > > On Wed, 13 May 2020 at 14:14, Walter Lozano > > wrote: > >> Currently when creating an U_BOOT_DEVICE entry a struct driver_info > >> is declared, which

Re: [PATCH] libfdt: Remove superfluous NUL character from overlay symbols

2020-05-22 Thread Simon Glass
Hi Marcus, On Fri, 22 May 2020 at 10:42, Marcus Comstedt wrote: > > The symbol path already ends with a NUL character (something which is > actually checked by the code) and this NUL is included in > rel_path_len, so there is no need to add a second one. > > This change fixes incorrect display

Re: [PATCH 1/1] doc: driver-model: there is no UCLASS_SATA

2020-05-22 Thread Simon Glass
On Wed, 20 May 2020 at 15:27, Heinrich Schuchardt wrote: > > %s/UCLASS_SATA/UCLASS_AHCI/g > > Signed-off-by: Heinrich Schuchardt > --- > doc/driver-model/design.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass

Re: [PATCH 2/3] doc: board: rockchip: Add missing supported boards

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 08:15, Walter Lozano wrote: > > Update the list of supported boards with the information available > on doc/README.rockchip. > > Signed-off-by: Walter Lozano > --- > doc/board/rockchip/rockchip.rst | 16 > 1 file changed, 16 insertions(+) > Reviewed-by:

Re: [PATCH 3/4] cmd: zip: fix implicit declaration warning

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 06:07, Michael Walle wrote: > > Fix the following warning: > > cmd/zip.c: In function ‘do_zip’: > cmd/zip.c:30:6: warning: implicit declaration of function ‘gzip’; did you > mean ‘do_zip’? [-Wimplicit-function-declaration] > if (gzip((void *) dst, _len, (void *) src,

Re: [PATCH 1/3] doc: board: rockchip: Improve supported board list format

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 08:15, Walter Lozano wrote: > > As an additional step to move documentation to doc/boards/rockchip > improve format of the supported board list to make it more readable. > Additionally, add the configuration files used to build them based on > doc/README.rockchip. > >

Re: [PATCH v6 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 03:09, Heiko Schocher wrote: > > save the GPIOD_ flags also in the gpio descriptor. > > Signed-off-by: Heiko Schocher > Reviewed-by: Patrick Delaunay > Fixes: 788ea834124b ("gpio: add function _dm_gpio_set_dir_flags") > > --- > > Changes in v6: > - add reviewed by from

Re: [PATCH v4 4/8] lib: rsa: fix allocated size for rr and rrtmp in rsa_gen_key_prop()

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 08:13, Heiko Stuebner wrote: > > From: Heiko Stuebner > > When calculating rrtmp/rr rsa_gen_key_prop() tries to make > (((rlen + 31) >> 5) + 1) steps in the rr uint32_t array and > (((rlen + 7) >> 3) + 1) / 4 steps in uint32_t rrtmp[] > with rlen being num_bits * 2 > > On

Re: [PATCH 4/4] sandbox: move compression option to Kconfig

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 06:07, Michael Walle wrote: > > CONFIG_BZIP2 and CONFIG_GZIP_COMPRESSED are Kconfig options. Select them > by CONFIG_SANDBOX instead of setting them in configs/sandbox.h. > > Signed-off-by: Michael Walle > --- > arch/Kconfig | 2 ++ >

Re: [PATCH 2/4] cmd: zip: automatically pull in gzip()

2020-05-22 Thread Simon Glass
On Fri, 22 May 2020 at 06:07, Michael Walle wrote: > > Move the CONFIG_GZIP_COMPRESSED from a config.h macro to a Kconfig menu > item. It is not selectable by a user because there is no reason to do > so. Instead it will be automatically selected by the stuff which uses > gzip(), like the zip

[PATCH] armv8: layerscape: pretty print info about SMP cores

2020-05-22 Thread Michael Walle
Make the print of the starting address a debug output and pretty print the info about online cores. Signed-off-by: Michael Walle --- arch/arm/cpu/armv8/fsl-layerscape/mp.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/mp.c

Re: [PATCH] checkpatch.pl: Add check for defining CONFIG_CMD_xxx via config files

2020-05-22 Thread Simon Glass
On Thu, 21 May 2020 at 14:32, Tom Rini wrote: > > All of our cmds have a Kconfig entry. Making enabling a CMD via the > config file an error to checkpatch.pl. > > Signed-off-by: Tom Rini > --- > scripts/checkpatch.pl | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 00/26] x86: video: Speed up the framebuffer

2020-05-22 Thread Bin Meng
Hi Simon, On Sat, May 23, 2020 at 12:34 AM Simon Glass wrote: > > Hi Bin, > > On Fri, 22 May 2020 at 09:30, Bin Meng wrote: > > > > Hi Simon, > > > > On Wed, May 20, 2020 at 7:11 AM Simon Glass wrote: > > > > > > Some architectures use a cached framebuffer and flush the cache as needed > > >

[PATCH] armv8: layerscape: fix spin-table support

2020-05-22 Thread Michael Walle
Spin tables are broken with bootefi. This is because - in contrast to the booti call chain - there is no call to smp_kick_all_cpus(). Due to this missing call the secondary CPUs are never released from their "wait for interrupt state", see secondary_boot_func() in lowlevel.S. Originally, this

Re: [PATCH v2] board: nitrogen6x: migrate to CONFIG_DM_VIDEO

2020-05-22 Thread Anatolij Gustschin
On Fri, 22 May 2020 10:10:37 -0700 Troy Kisky troy.ki...@boundarydevices.com wrote: > Enable driver model for Video to remove compiler warning. > To enable display, issue > > setenv stdout serial,vidconsole; > > Add CONFIG_DM_VIDEO to all defconfigs whose board is > nitrogen6x. >

Re: [PATCH 3/3] doc: rockchip: Remove list of supported boards

2020-05-22 Thread Walter Lozano
Hi Ezequiel, On 22/5/20 18:37, Ezequiel Garcia wrote: On Fri, 22 May 2020 at 11:16, Walter Lozano wrote: As documentation is being moved to doc/boards/rockchip create a warning message and remove the redundant list of supported boards. Signed-off-by: Walter Lozano --- doc/README.rockchip

[PATCH 2/6] checkpatch.pl: Add a U-Boot option

2020-05-22 Thread Simon Glass
Add an option to indicate that U-Boot-specific checks should be enabled. Add a function to house the code that will be added. Signed-off-by: Simon Glass --- .checkpatch.conf | 3 +++ scripts/checkpatch.pl | 12 2 files changed, 15 insertions(+) diff --git a/.checkpatch.conf

[PATCH 5/6] checkpatch.pl: Request a test when a new command is added

2020-05-22 Thread Simon Glass
This request is made with nearly every new command. Point to some docs on how to do it. Signed-off-by: Simon Glass --- doc/README.commands | 50 +++ scripts/checkpatch.pl | 6 ++ 2 files changed, 56 insertions(+) diff --git a/doc/README.commands

[PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-05-22 Thread Simon Glass
There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, suggest using the compile-time construct. Signed-off-by: Simon Glass --- scripts/checkpatch.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

[PATCH 4/6] checkpatch.pl: Warn if the flattree API is used

2020-05-22 Thread Simon Glass
We want people to use the livetree API, so request it. Signed-off-by: Simon Glass --- scripts/checkpatch.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 9dc42520e2d..e3a2a289aea 100755 --- a/scripts/checkpatch.pl +++

[PATCH 3/6] checkpatch.pl: Add a check for tests needed for uclasses

2020-05-22 Thread Simon Glass
A common problem when submitting a new uclass is to forget to add sandbox tests. Add a warning for this. Of course tests should always be added for new code, but this one seems to be missed by nearly every new contributor. Signed-off-by: Simon Glass --- scripts/checkpatch.pl | 6 ++ 1

[PATCH 1/6] checkpatch.pl: Update to v5.7-rc6

2020-05-22 Thread Simon Glass
Bring in the newest script. This is close enough to v5.8 that it will likely be final. Keep the U-Boot changes to $logFunctions Signed-off-by: Simon Glass --- scripts/checkpatch.pl | 216 +++--- 1 file changed, 55 insertions(+), 161 deletions(-) diff --git

[PATCH 0/6] checkpatch.pl: Add features to help improve U-Boot code

2020-05-22 Thread Simon Glass
U-Boot mostly follows linux for coding style, but it has some of its own features. These come up again and again in code review. We should try to reduce the load of reviewers. This series adds a little U-Boot function to the checkpatch script and an option to enable it. Hopefully it is easy

Re: [PATCH 3/3] doc: rockchip: Remove list of supported boards

2020-05-22 Thread Ezequiel Garcia
On Fri, 22 May 2020 at 11:16, Walter Lozano wrote: > > As documentation is being moved to doc/boards/rockchip create a warning > message and remove the redundant list of supported boards. > > Signed-off-by: Walter Lozano > --- > doc/README.rockchip | 72

Re: [PATCH v2 1/9] spl: Try to get SPL boot device via board_get_int

2020-05-22 Thread Tom Rini
On Fri, May 22, 2020 at 09:42:22PM +0530, Jagan Teki wrote: > On Wed, May 20, 2020 at 7:40 PM Tom Rini wrote: > > > > On Wed, May 20, 2020 at 06:46:55PM +0530, Jagan Teki wrote: > > > On Wed, May 20, 2020 at 6:32 PM Tom Rini wrote: > > > > > > > > On Wed, May 20, 2020 at 12:53:32AM +0530, Jagan

Re: [PATCH] thermal: imx_scu_thermal: prevent boot hang with zero pdata

2020-05-22 Thread Anatolij Gustschin
On Wed, 20 May 2020 10:21:53 +0200 Anatolij Gustschin ag...@denx.de wrote: > Should initialization of pdata values have failed for some reason, > we end up in endless loop when getting the CPU temperature value > and can not boot. Check alert value in pdata and only retry reading > temperature if

Re: [PATCH 1/2] cpu: imx8: fix type and rate detection

2020-05-22 Thread Anatolij Gustschin
On Sat, 16 May 2020 22:34:19 +0200 Anatolij Gustschin ag...@denx.de wrote: > CPU type and rate detection is broken, for A35 cpu we get A53: > ... > sc_pm_get_clock_rate: resource:0 clk:2: res:3 > Could not read CPU frequency: -22 > CPU: NXP i.MX8QXP RevB A53 at 0 MHz at 47C > > Fixes:

Re: [PATCH] cpu: imx8: use intended cpu-thermal device when getting temp value

2020-05-22 Thread Anatolij Gustschin
On Wed, 20 May 2020 01:31:44 +0200 Anatolij Gustschin ag...@denx.de wrote: > This fixes getting DT alert and critical pdata values in imx_scu_thermal > driver. On i.MX8QXP using not initialized alert pdata value resulted in > boot hang and endless loop outputting: > CPU Temperature (47200C) has

Re: Pull request: u-boot-rockchip-20200522

2020-05-22 Thread Tom Rini
> > https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip.git > tags/u-boot-rockchip-20200522 > > for you to fetch changes up to 33863f744d513f5c16a254870e7b3cef8580bbc9: > > rockchip: rk3328: rock64 - fix gen3 SPL hang (2020-05-22 20:53:20 +0800) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [GIT PULL] UniPhier SoC updates for v2020.07

2020-05-22 Thread Tom Rini
On Fri, May 22, 2020 at 11:33:13AM +0900, Masahiro Yamada wrote: > Hi Tom, > > Please pull changes for v2020.07 > Thanks. > > > > The following changes since commit 2fa581ba910368d0f7f995fb906d6c5e4218b594: > > Merge git://git.denx.de/u-boot-sh (2020-05-21 08:26:40 -0400) > > are

Re: [GIT PULL] Pull request: u-boot-imx u-boot-imx-20200511

2020-05-22 Thread Tom Rini
On Fri, May 22, 2020 at 02:09:09PM +0200, Anatolij Gustschin wrote: > On Mon, 11 May 2020 12:04:32 -0400 > Tom Rini tr...@konsulko.com wrote: > > > On Mon, May 11, 2020 at 12:29:37PM +0200, Stefano Babic wrote: > > > > > Hi Tom, > > > > > > please pull these i.MX's changes for 2020.07, thanks

Re: Pull request for UEFI sub-system for efi-2020-07-rc3 (2)

2020-05-22 Thread Tom Rini
On Fri, May 22, 2020 at 08:26:45AM +0200, Heinrich Schuchardt wrote: > The following changes since commit b0b13f4114d30b6756e0f6f3b5819d78de22541e: > > Merge https://gitlab.denx.de/u-boot/custodians/u-boot-fsl-qoriq > (2020-05-20 08:46:56 -0400) > > are available in the Git repository at: >

Re: [PATCH v4] net: tftp: Add client support for RFC 7440

2020-05-22 Thread Ramon Fried
Thanks. On Fri, May 22, 2020 at 3:29 AM rahasij wrote: > > Ramon Fried-4 wrote > > + if (strcmp((char *)pkt + i, "windowsize") == 0) { > > + tftp_windowsize = > > + simple_strtoul((char *)pkt + i + 11, > > +

[PATCH] rockchip: Fix spl mmc boot device ofpath

2020-05-22 Thread sunil
From: Suniel Mahesh Linux v5.7-rc1 dts(i) sync has changed the sdmmc node from dwmmc@fe32 to mmc@fe32 and this ofpath is being used in rockchip spl bootdevice code. So, update the ofpath with a new node name. Fixes: 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux"

Re: [PATCH 5/5] roc-pc-rk3399: Enable PCIe/M.2, NVMe

2020-05-22 Thread Jagan Teki
On Fri, May 22, 2020 at 11:34 PM wrote: > > From: Suniel Mahesh > > ROC-RK3399-PC Mezzanine is an add-on board for roc-pc-rk3399 target > and it hosts a PCIe/M.2 interface. As we have added runtime detection > support for this add-on board, this patch enables PCIe/M.2, NVMe so that > SSD's which

Re: [PATCH v2] drivers: crypto: mod_exp_sw: Re-add DM_FLAG_PRE_RELOC

2020-05-22 Thread Heinrich Schuchardt
On 5/22/20 5:21 PM, Jan Kiszka wrote: > On 22.05.20 16:55, Heinrich Schuchardt wrote: >> On 22.05.20 14:21, Jan Kiszka wrote: >>> On 22.05.20 13:38, Heinrich Schuchardt wrote: Am May 22, 2020 10:50:29 AM UTC schrieb Jan Kiszka : > On 22.05.20 12:42, Heinrich Schuchardt wrote: >>

Re: [PATCH 4/5] rk3399: drop ROC-RK3399-PC Mezzanine board

2020-05-22 Thread Jagan Teki
On Fri, May 22, 2020 at 11:34 PM wrote: > > From: Suniel Mahesh > > As we have added runtime detection support for ROC-RK3399-PC Mezzanine > board, which is an add-on board and as indicated in earlier commit, we > are dropping separate defconfig file and support. > > see commit f417d71ea78b

[PATCH 5/5] roc-pc-rk3399: Enable PCIe/M.2, NVMe

2020-05-22 Thread sunil
From: Suniel Mahesh ROC-RK3399-PC Mezzanine is an add-on board for roc-pc-rk3399 target and it hosts a PCIe/M.2 interface. As we have added runtime detection support for this add-on board, this patch enables PCIe/M.2, NVMe so that SSD's which have a PCIe/M.2 interface can be detected. => nvme

[PATCH 2/5] roc-pc-rk3399: Enable I2C in SPL for add-on board detection

2020-05-22 Thread sunil
From: Suniel Mahesh This patch enables I2C in SPL for any add-on board detection at run time. Signed-off-by: Suniel Mahesh Signed-off-by: Jagan Teki --- arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 13 + configs/roc-pc-rk3399_defconfig| 5 - 2 files changed, 17

[PATCH 4/5] rk3399: drop ROC-RK3399-PC Mezzanine board

2020-05-22 Thread sunil
From: Suniel Mahesh As we have added runtime detection support for ROC-RK3399-PC Mezzanine board, which is an add-on board and as indicated in earlier commit, we are dropping separate defconfig file and support. see commit f417d71ea78b ("rk3399: Add ROC-RK3399-PC Mezzanine board")

[PATCH 1/5] rockchip: spl: Move board_early_init_f after cpu timer

2020-05-22 Thread sunil
From: Jagan Teki Custom board_early_init_f not only deal with simple gpio configuration but also have a possibility to access clocks to process any clock related operations like checking reset cause state and etc. So, call it once the rockchip timer initialization done instead of calling first

[PATCH 3/5] roc-pc-rk3399: Add support for add-on board run-time detection

2020-05-22 Thread sunil
From: Suniel Mahesh roc-pc-rk3399 target has an add-on board, this add-on board hosts a CW2015 chip which is connected as slave to I2C2. In order to dynamically detect this add-on board at runtime, I2C2 is probed in SPL. If probe is successfull then a corresponding dtb is loaded, else regular

[PATCH 0/5] Enable I2C in SPL, support runtime detection of add-on board

2020-05-22 Thread sunil
From: Suniel Mahesh This patch series adds runtime detection of add-on board(ROC-RK3399-PC Mezzanine) by enabling I2C in SPL. This add on board hosts a CW2015 chip which is connected as slave to I2C2. In order to dynamically detect this add-on board at runtime, I2C2 is probed in SPL. If probe

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-22 Thread Tom Rini
On Fri, May 22, 2020 at 10:50:35AM -0600, Simon Glass wrote: > Hi Jagan, > > On Fri, 22 May 2020 at 08:41, Jagan Teki wrote: > > > > Hi Simon, > > > > On Fri, May 22, 2020 at 7:55 PM Simon Glass wrote: > > > > > > Hi Jagan, > > > > > > On Thu, 14 May 2020 at 12:09, Jagan Teki > > > wrote: > >

[PATCH v2] board: nitrogen6x: migrate to CONFIG_DM_VIDEO

2020-05-22 Thread Troy Kisky
Enable driver model for Video to remove compiler warning. To enable display, issue setenv stdout serial,vidconsole; Add CONFIG_DM_VIDEO to all defconfigs whose board is nitrogen6x. mx6qsabrelite_defconfig nitrogen6dl2g_defconfig nitrogen6dl_defconfig

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-22 Thread Simon Glass
Hi Jagan, On Fri, 22 May 2020 at 08:41, Jagan Teki wrote: > > Hi Simon, > > On Fri, May 22, 2020 at 7:55 PM Simon Glass wrote: > > > > Hi Jagan, > > > > On Thu, 14 May 2020 at 12:09, Jagan Teki wrote: > > > > > > Handling probing code for a particular uclass between > > > dm vs nodm always

[PATCH] libfdt: Remove superfluous NUL character from overlay symbols

2020-05-22 Thread Marcus Comstedt
The symbol path already ends with a NUL character (something which is actually checked by the code) and this NUL is included in rel_path_len, so there is no need to add a second one. This change fixes incorrect display in "fdt list /__symbols" after applying an overlay with symbols.

[PATCH v6 2/2] dm: uclass: don't assign aliased seq numbers

2020-05-22 Thread Michael Walle
If there are aliases for an uclass, set the base for the "dynamically" allocated numbers next to the highest alias. Please note, that this might lead to holes in the sequences, depending on the device tree. For example if there is only an alias "ethernet1", the next device seq number would be 2.

[PATCH v6 1/2] usb: provide a device tree node to USB devices

2020-05-22 Thread Michael Walle
It is possible to specify a device tree node for an USB device. This is useful if you have a static USB setup and want to use aliases which point to these nodes, like on the Raspberry Pi. The nodes are matched against their hub port number, the compatible strings are not matched for now.

Re: [PATCH 01/13] cbfs: Rename the result variable

2020-05-22 Thread Simon Glass
Hi Bin, On Tue, 19 May 2020 at 07:53, Bin Meng wrote: > > Hi Simon, > > On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > > > At present the result variable in the cbfs_priv is called 'result' as is > > the local variable in a few functions. Change the latter to 'ret' which is > > more

Re: [PATCH 03/13] cbfs: Use bool type for whether initialised

2020-05-22 Thread Simon Glass
Hi Bin, On Tue, 19 May 2020 at 07:53, Bin Meng wrote: > > Hi Simon, > > On Wed, May 13, 2020 at 10:24 PM Simon Glass wrote: > > > > At present this uses an int type. U-Boot now supports bool so use this > > instead. Also use English spelling for initialised which we are here. > > I don't

Re: [PATCH 00/26] x86: video: Speed up the framebuffer

2020-05-22 Thread Simon Glass
Hi Bin, On Fri, 22 May 2020 at 09:30, Bin Meng wrote: > > Hi Simon, > > On Wed, May 20, 2020 at 7:11 AM Simon Glass wrote: > > > > Some architectures use a cached framebuffer and flush the cache as needed > > so that changes are visible. This is supported by U-Boot. > > > > However x86 uses an

Re: [PATCH v3 00/13] x86: cbfs: Various clean-ups to CBFS implementation

2020-05-22 Thread Simon Glass
Hi Bin, On Fri, 22 May 2020 at 10:32, Simon Glass wrote: > > This code is very old and has not had much of a clean-up since it was > written. This series aims to tidy it up to use error codes, avoid using > BSS when not necessary and to add a few more features. > > Changes in v3: > - Fix typo in

[PATCH v3 10/13] cbfs: Return the error code from file_cbfs_init()

2020-05-22 Thread Simon Glass
We may as well return the error code and use it directly in the command code. CBFS still uses its own error enum which we may be able to remove, but leave it for now. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None cmd/cbfs.c | 3 +--

[PATCH v3 12/13] cbfs: Allow reading a file from a CBFS given its base addr

2020-05-22 Thread Simon Glass
Currently we support reading a file from CBFS given the address of the end of the ROM. Sometimes we only know the start of the CBFS. Add a function to find a file given that. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: - Use void * instead of u8 * in

[PATCH v3 13/13] cbfs: Don't require the CBFS size with cbfs_init_mem()

2020-05-22 Thread Simon Glass
The size is not actually used since it is present in the header. Drop this parameter. Also tidy up error handling while we are here. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: - Rebase to master (with x86/master cherry-picked in too) - Resending as

[PATCH v3 09/13] cbfs: Record the start address in cbfs_priv

2020-05-22 Thread Simon Glass
The start address of the CBFS is used when scanning for files. It makes sense to put this in our cbfs_priv struct and calculate it when we read the header. Update the code accordingly. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None

[PATCH v3 03/13] cbfs: Use bool type for whether initialised

2020-05-22 Thread Simon Glass
At present this uses an int type. U-Boot now supports bool so use this instead. Also use English spelling for initialised which we are here. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None fs/cbfs/cbfs.c | 28 ++-- include/cbfs.h | 2 +- 2 files

[PATCH v3 07/13] cbfs: Unify the two header loaders

2020-05-22 Thread Simon Glass
These two functions have mostly the same code. Pull this out into a common function. Also make this function zero the private data so that callers don't have to do it. Finally, update cbfs_load_header_ptr() to take the base of the ROM as its parameter, which makes more sense than passing the

[PATCH v3 11/13] cbfs: Change file_cbfs_find_uncached() to return an error

2020-05-22 Thread Simon Glass
This function currently returns a node pointer so there is no way to know the error code. Also it uses data in BSS which seems unnecessary since the caller might prefer to use a local variable. Update the function and split its body out into a separate function so we can use it later.

[PATCH v3 08/13] cbfs: Use void * for the position pointers

2020-05-22 Thread Simon Glass
It doesn't make sense to use u8 * as the pointer type for accessing the CBFS since we do not access it as bytes, but via structures. Change it to void *, which allows us to avoid a cast. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None

[PATCH v3 05/13] cbfs: Adjust file_cbfs_load_header() to use cbfs_priv

2020-05-22 Thread Simon Glass
This function is strange at the moment in that it takes a header pointer but then accesses the cbfs_s global. Currently clients have their own priv pointer, so update the function to take that as a parameter instead. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None

[PATCH v3 02/13] cbfs: Use ulong consistently

2020-05-22 Thread Simon Glass
U-Boot uses ulong for addresses but there are a few places in this driver that don't use it. Convert this driver over to follow this convention fully. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None fs/cbfs/cbfs.c | 9 - include/cbfs.h | 4

[PATCH v3 00/13] x86: cbfs: Various clean-ups to CBFS implementation

2020-05-22 Thread Simon Glass
This code is very old and has not had much of a clean-up since it was written. This series aims to tidy it up to use error codes, avoid using BSS when not necessary and to add a few more features. Changes in v3: - Fix typo in commit message - Add missing review tags Changes in v2: - Fix

[PATCH v3 01/13] cbfs: Rename the result variable

2020-05-22 Thread Simon Glass
At present the result variable in the cbfs_priv is called 'result' as is the local variable in a few functions. Change the latter to 'ret' which is more common in U-Boot and avoids confusion. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None

[PATCH v3 04/13] cbfs: Adjust return value of file_cbfs_next_file()

2020-05-22 Thread Simon Glass
At present his uses a true return to indicate it found a file. Adjust it to use 0 for this, so it is consistent with other functions. Update its callers accordingly and add a check for malloc() failure in file_cbfs_fill_cache(). Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in

[PATCH v3 06/13] cbfs: Adjust cbfs_load_header_ptr() to use cbfs_priv

2020-05-22 Thread Simon Glass
This function is strange at the moment in that it takes a header pointer but then accesses the cbfs_s global. Currently clients have their own priv pointer, so update the function to take that as a parameter instead. Reviewed-by: Bin Meng Signed-off-by: Simon Glass --- Changes in v3: None

[PATCH] mmc: fsl_esdhc: Gracefully fail on unsupported voltage switch

2020-05-22 Thread Marek Vasut
Unsupported voltage on voltage switch is not an error, do not print error message in such a case. This happens e.g. if the eMMC is already in 1V8 mode or when testing 1V2 mode operation on systems which only do 3V3/1V8 switching. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Jaehoon Chung

[PATCH] mmc: fsl_esdhc: Fix SDR104 and HS200 support

2020-05-22 Thread Marek Vasut
The 3V3/1V8 switching could never have worked on any of the iMXes ever since 51313b49f2 ("mmc: fsl_esdhc: support SDR104 and HS200"), because that commit uses priv->vqmmc_dev when switching voltages on mode switch, while local vqmmc_dev in probe to store the regulator pointer. Those are two

Re: [PATCH v2 1/9] spl: Try to get SPL boot device via board_get_int

2020-05-22 Thread Jagan Teki
On Wed, May 20, 2020 at 7:40 PM Tom Rini wrote: > > On Wed, May 20, 2020 at 06:46:55PM +0530, Jagan Teki wrote: > > On Wed, May 20, 2020 at 6:32 PM Tom Rini wrote: > > > > > > On Wed, May 20, 2020 at 12:53:32AM +0530, Jagan Teki wrote: > > > > > > > Usually, the associated board would supply spl

Re: [PATCH 25/26] x86: minnowmax: Enable the copy framebuffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:57 -0600 Simon Glass s...@chromium.org wrote: > Update the video driver to support this feature and enable it on > minnowmax to speed up the display. > > With this change, the time taken to print the environment to the display > without CONFIG_CONSOLE_SCROLL_LINES is

Re: [PATCH 24/26] x86: chromebook_link: Enable the copy framebuffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:56 -0600 Simon Glass s...@chromium.org wrote: > Update the video driver to support this feature and enable it on link. > Also remove the multi-line scrolling since normal scrolling is fast enough > now. > > With this change, the time taken to print the environment to

Re: [PATCH 23/26] x86: chromebook_samus: Enable the copy framebuffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:55 -0600 Simon Glass s...@chromium.org wrote: > Update the video driver to support this feature and enable it on samus. > Also remove the multi-line scrolling since normal scrolling is fast enough > now. > > With this change, the time taken to print the environment to

Re: [PATCH 22/26] x86: video: Support copy framebuffer with probed devices

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:54 -0600 Simon Glass s...@chromium.org wrote: > For PCI video devices that are not mentioned in the devicetree, U-Boot > does not bind a driver before relocation, since PCI is not fully probed > at that point. Furthermore it is possible for the video device to be on > a

Re: [PATCH 21/26] video: Correctly handle multiple framebuffers

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:53 -0600 Simon Glass s...@chromium.org wrote: > At present video_bottom is set to the bottom of each framebuffer when it > is allocated. This is not correct, since it should hold the bottom of the > entire area available for framebuffers. > > Fix this by adding a

Re: [PATCH 20/26] x86: fsp: video: Allocate a frame buffer when needed

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:52 -0600 Simon Glass s...@chromium.org wrote: > When the copy framebuffer is in use, we must also have the standard U-Boot > framebuffer available. Update the FSP driver to support this. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin

Re: [PATCH 19/26] video: pci: Set up the copy framebuffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:51 -0600 Simon Glass s...@chromium.org wrote: > When using a copy framebuffer we need to tell the video subsystem its > address. U-Boot's normally allocated framebuffer is used as the working > buffer, but nothing is displayed until it is copied to the copy >

Re: [PATCH 18/26] video: sandbox: Add support for the copy framebuffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:50 -0600 Simon Glass s...@chromium.org wrote: > Enable this feature on sandbox by updating the SDL driver to have two > framebuffers. > > Update the video tests to check that the copy framebuffer is kept in sync. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij

Re: [PATCH 17/26] video: Add comments to struct sandbox_sdl_plat

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:49 -0600 Simon Glass s...@chromium.org wrote: > This struct is not commented but needs it. Also fix the comment in > check_vidconsole_output() about the encoding for the rotation value. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin

Re: [PATCH 16/26] video: Update the copy framebuffer when writing bitmaps

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:48 -0600 Simon Glass s...@chromium.org wrote: > Adjust the bitmap code to sync to the copy framebuffer when done. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin

Re: [PATCH 00/26] x86: video: Speed up the framebuffer

2020-05-22 Thread Bin Meng
Hi Simon, On Wed, May 20, 2020 at 7:11 AM Simon Glass wrote: > > Some architectures use a cached framebuffer and flush the cache as needed > so that changes are visible. This is supported by U-Boot. > > However x86 uses an uncached framebuffer with a 'write-combining' feature > to speed up

Re: [PATCH 15/26] video: Update rotated console to support copy buffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:47 -0600 Simon Glass s...@chromium.org wrote: > Update the implementation to keep a track of what it changes in the frame > buffer and then tell the copy buffer about it. Use the special > vidconsole_memmove() helper so that memmove() operations are also > reflected in

Re: [PATCH 14/26] video: Update truetype console to support copy buffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:46 -0600 Simon Glass s...@chromium.org wrote: > Update the implementation to keep a track of what it changes in the frame > buffer and then tell the copy buffer about it. Use the special > vidconsole_memmove() helper so that memmove() operations are also > reflected in

Re: [PATCH v2] drivers: crypto: mod_exp_sw: Re-add DM_FLAG_PRE_RELOC

2020-05-22 Thread Jan Kiszka
On 22.05.20 16:55, Heinrich Schuchardt wrote: > On 22.05.20 14:21, Jan Kiszka wrote: >> On 22.05.20 13:38, Heinrich Schuchardt wrote: >>> Am May 22, 2020 10:50:29 AM UTC schrieb Jan Kiszka : On 22.05.20 12:42, Heinrich Schuchardt wrote: > On 5/20/20 2:22 PM, Tom Rini wrote: >> On Thu,

Re: [PATCH 13/26] video: Update normal console to support copy buffer

2020-05-22 Thread Anatolij Gustschin
On Tue, 19 May 2020 17:10:45 -0600 Simon Glass s...@chromium.org wrote: > Update the implementation to keep a track of what it changes in the frame > buffer and then tell the copy buffer about it. Use the special > vidconsole_memmove() helper so that memmove() operations are also > reflected in

Re: [PATCH 12/26] video: Add helpers for vidconsole for the copy framebuffer

2020-05-22 Thread Anatolij Gustschin
Hi Simon, On Tue, 19 May 2020 17:10:44 -0600 Simon Glass s...@chromium.org wrote: > Add a convenience function to call video_sync_copy() for a vidconsole. > Also add a memmove() helper, which does the memmove() as well as the sync. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij

  1   2   3   >