Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Masami Hiramatsu
Hi Takahiro, 2021年4月14日(水) 13:48 Takahiro Akashi : > > > > So why not define UEFI load options (BOOT) and use UEFI boot manager > > > ("bootefi bootmgr")? > > > That is the way how UEFI (at least boot manager) boots the kernel. > > > > Good point! Actually, I'm not sure how to define the BOOTx

Re: [PATCH] efi_loader: fix possible buffer overflow

2021-04-13 Thread Ilias Apalodimas
On Wed, Apr 14, 2021 at 11:55:49AM +0900, Masahisa Kojima wrote: > Variable "final" will have SHA512 digest, but currently > the array size is not sufficient. Let's fix it. > > Signed-off-by: Masahisa Kojima > --- > lib/efi_loader/efi_tcg2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [RFC PATCH v5 1/2] arch: riscv: cpu: Add callback to init each core

2021-04-13 Thread Green Wan
Thanks, Rick, It's very helpful. I'll fix them. On Wed, Apr 14, 2021 at 11:07 AM Rick Chen wrote: > > > From: Green Wan [mailto:green@sifive.com] > > Sent: Tuesday, April 13, 2021 5:32 PM > > Cc: Green Wan; Rick Jian-Zhi Chen(陳建志); Paul Walmsley; Pragnesh Patel; Sean > > Anderson; Bin Meng

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Takahiro Akashi
On Wed, Apr 14, 2021 at 11:06:36AM +0900, Masami Hiramatsu wrote: > Hi Takahiro, > > 2021年4月14日(水) 10:27 Takahiro Akashi : > > > > On Wed, Apr 14, 2021 at 10:12:42AM +0900, Masami Hiramatsu wrote: > > > Hello Tom, > > > > > > 2021年4月14日(水) 2:47 Tom Rini : > > > > > > > > On Wed, Apr 14, 2021 at 12

Re: [RFC PATCH v5 2/2] board: sifive: unmatched: clear feature disable CSR

2021-04-13 Thread Rick Chen
Hi Green, > From: Green Wan [mailto:green@sifive.com] > Sent: Tuesday, April 13, 2021 5:32 PM > Cc: Green Wan; Sean Anderson; Bin Meng; Rick Jian-Zhi Chen(陳建志); Paul > Walmsley; Pragnesh Patel; Bin Meng; Simon Glass; Atish Patra; Leo Yu-Chi > Liang(梁育齊); Brad Kim; open list > Subject: [RFC P

Re: [RFC PATCH v5 1/2] arch: riscv: cpu: Add callback to init each core

2021-04-13 Thread Rick Chen
> From: Green Wan [mailto:green@sifive.com] > Sent: Tuesday, April 13, 2021 5:32 PM > Cc: Green Wan; Rick Jian-Zhi Chen(陳建志); Paul Walmsley; Pragnesh Patel; Sean > Anderson; Bin Meng; Simon Glass; Atish Patra; Leo Yu-Chi Liang(梁育齊); Brad > Kim; open list > Subject: [RFC PATCH v5 1/2] arch: ri

[PATCH] efi_loader: fix possible buffer overflow

2021-04-13 Thread Masahisa Kojima
Variable "final" will have SHA512 digest, but currently the array size is not sufficient. Let's fix it. Signed-off-by: Masahisa Kojima --- lib/efi_loader/efi_tcg2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index ed8

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Masami Hiramatsu
Hi Takahiro, 2021年4月14日(水) 10:27 Takahiro Akashi : > > On Wed, Apr 14, 2021 at 10:12:42AM +0900, Masami Hiramatsu wrote: > > Hello Tom, > > > > 2021年4月14日(水) 2:47 Tom Rini : > > > > > > On Wed, Apr 14, 2021 at 12:31:21AM +0900, Masami Hiramatsu wrote: > > > > > > > Add the DeveloperBox 96boards EE

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Takahiro Akashi
On Wed, Apr 14, 2021 at 10:12:42AM +0900, Masami Hiramatsu wrote: > Hello Tom, > > 2021年4月14日(水) 2:47 Tom Rini : > > > > On Wed, Apr 14, 2021 at 12:31:21AM +0900, Masami Hiramatsu wrote: > > > > > Add the DeveloperBox 96boards EE support. This board is also > > > known as Socionext SynQuacer E-Ser

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Masami Hiramatsu
Hello Tom, 2021年4月14日(水) 2:47 Tom Rini : > > On Wed, Apr 14, 2021 at 12:31:21AM +0900, Masami Hiramatsu wrote: > > > Add the DeveloperBox 96boards EE support. This board is also > > known as Socionext SynQuacer E-Series. It contians one "SC2A11" > > SoC, which has 24-cores of arm Cortex-A53, and 4

Re: [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-04-13 Thread Masami Hiramatsu
Hello Tom, Thank you for your comment! 2021年4月14日(水) 2:47 Tom Rini : > > On Wed, Apr 14, 2021 at 12:30:15AM +0900, Masami Hiramatsu wrote: > > > Add device trees for 96boards EE DeveloperBox and basement SynQuacer > > SoC dtsi. These files are imported from EDK2 with cosmetic change > > and modif

Re: [PATCH v2] arm: mach-rmobile: Add CPU info support for RZ/G2

2021-04-13 Thread Marek Vasut
On 3/17/21 3:11 PM, Biju Das wrote: Add CPU info support for RZ/G2 SoC's. Applied, thanks

Re: [RFC PATCH v4 1/2] arch: riscv: cpu: Add callback to init each core

2021-04-13 Thread Rick Chen
Hi Sean, > On 4/13/21 12:12 AM, Rick Chen wrote: > > Hi Sean > > > >> On 4/12/21 10:39 PM, Rick Chen wrote: > >>> Hi Green, > >>> > From: Green Wan [mailto:green@sifive.com] > Sent: Monday, April 12, 2021 10:33 AM > To: Sean Anderson > Cc: Rick Chen; Rick Jian-Zhi Chen(陳建志)

[PULL] u-boot-sh/master

2021-04-13 Thread Marek Vasut
The following changes since commit a94ab561e2f49a80d8579930e840b810ab1a1330: Merge branch '2021-04-13-assorted-improvements' (2021-04-13 09:50:45 -0400) are available in the Git repository at: git://source.denx.de/u-boot-sh.git master for you to fetch changes up to 3e5f3dbe3a8556503afc00

[PATCH 1/2] env: allow environment to be amended from control dtb

2021-04-13 Thread Rasmus Villemoes
It can be useful to use the same U-Boot binary for multiple purposes, say the normal one, one for developers that allow breaking into the U-Boot shell, and one for use during bootstrapping which runs a special-purpose bootcmd. Or one can have several board variants that can share almost all boot lo

[PATCH 0/2] allow environment to be updated from dtb

2021-04-13 Thread Rasmus Villemoes
Patch 1 adds a config option for updating the environment, after it has been loaded from its persistent location, with a set of key/value pairs from a node in the control DTB. This is useful to create a few different images based on the same U-Boot binary, e.g. one for normal use, one for developm

[PATCH 2/2] sandbox: add test of CONFIG_ENV_IMPORT_FDT

2021-04-13 Thread Rasmus Villemoes
Check that a variable defined in /config/environment is found in the run-time environment, and that clearing fdt_env_path from within that node works. Signed-off-by: Rasmus Villemoes --- arch/sandbox/dts/test.dts | 7 +++ configs/sandbox64_defconfig | 1 + configs/sandbox_defconfig |

Re: [PATCH v3] cmd: net: Add the "arp" command

2021-04-13 Thread Sean Anderson
On 4/13/21 4:05 PM, Joe Xue wrote: I moved the v1 and v2 as "Superseeded" if that is what you mean. No, I mean what are the differences between this patch and the patch you sent labeled "v2"? There is no changelog after the diffstat. --Sean Thanks Joe Xue --

Re: [PATCH v3] cmd: net: Add the "arp" command

2021-04-13 Thread Joe Xue
I moved the v1 and v2 as "Superseeded" if that is what you mean. Thanks Joe Xue From: Sean Anderson Sent: April 13, 2021 11:16 AM To: lg...@hotmail.com ; u-boot@lists.denx.de Cc: bmeng...@gmail.com ; frederic.da...@collabora.com ; xypron.g...@gmx.de ; joe.her

[PATCH v2 2/2] powerpc: introduce CONFIG_CACHE_FLUSH_WATCHDOG_THRESHOLD

2021-04-13 Thread Rasmus Villemoes
When flush_cache() is called during boot on our ~7M kernel image, the hundreds of thousands of WATCHDOG_RESET calls end up adding significantly to boottime. Flushing a single cache line doesn't take many microseconds, so doing these calls for every cache line is complete overkill. The generic watc

[PATCH v2 1/2] powerpc: lib: remove leftover CONFIG_5xx

2021-04-13 Thread Rasmus Villemoes
CONFIG_5xx hasn't existed since commit 502589777416 (powerpc, 5xx: remove support for 5xx). Remove this last mention of it. Signed-off-by: Rasmus Villemoes --- arch/powerpc/lib/cache.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/lib/cache.c b/arch/powerpc/lib/cache.c index

[PATCH v2 0/2] powerpc: introduce CONFIG_CACHE_FLUSH_WATCHDOG_THRESHOLD

2021-04-13 Thread Rasmus Villemoes
Back in June, I sent a patch [1] to reduce the number of WATCHDOG_RESET calls in flush_cache() to one per 64K. Wolfgang rejected that, saying that the threshold should be configurable. So here's a new version which introduces a config knob. When left at its default, the generated code is binary id

Re: [PATCH v3 13/28] pci: Update to use new sequence numbers

2021-04-13 Thread Tim Harvey
On Sat, Dec 19, 2020 at 8:43 AM Simon Glass wrote: > > Now that we know the sequence number at bind time, there is no need for > special-case code in dm_pci_hose_probe_bus(). > > Note: the PCI_CAP_ID_EA code may need a look, but there are no test > failures so I have left it as is. > > Signed-off-

Re: [PATCH 11/13] board: synquacer: Add DeveloperBox 96boards EE support

2021-04-13 Thread Tom Rini
On Wed, Apr 14, 2021 at 12:31:21AM +0900, Masami Hiramatsu wrote: > Add the DeveloperBox 96boards EE support. This board is also > known as Socionext SynQuacer E-Series. It contians one "SC2A11" > SoC, which has 24-cores of arm Cortex-A53, and 4 DDR3 slots, > 3 PCIe slots (1 4x port and 2 1x ports

Re: [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox

2021-04-13 Thread Tom Rini
On Wed, Apr 14, 2021 at 12:30:15AM +0900, Masami Hiramatsu wrote: > Add device trees for 96boards EE DeveloperBox and basement SynQuacer > SoC dtsi. These files are imported from EDK2 with cosmetic change > and modified for accessing SPI NOR flash. > > Signed-off-by: Masami Hiramatsu > --- > ar

Do make sense an u-boot installer?

2021-04-13 Thread Alberto Planas
Hi, lately I am working on a small script that try to unify and help the installation of u-boot (and the different assets) into SD cards. As I am not knowledge about u-boot, I am starting small and with an use case that makes sense for my work. I want to discuss a bit if makes sense the idea,

[PATCH v2 11/11] configs: T1042D4RDB: enable DM_ETH

2021-04-13 Thread Camelia Groza
From: Camelia Groza Enable DM_ETH and DM_MDIO for the T1042D4RDB. Signed-off-by: Camelia Groza --- Changes in v2: - enable OF_CONTROL for the T1042D4RDB_SECURE_BOOT_defconfig configs/T1042D4RDB_NAND_defconfig| 3 +++ configs/T1042D4RDB_SDCARD_defconfig | 3 +++ configs/T1042D4RDB

[PATCH v2 10/11] powerpc: dts: t1042d4rdb: add FMan v3 nodes

2021-04-13 Thread Camelia Groza
From: Camelia Groza Add the FMan v3 nodes for the T1042D4RDB. The nodes are copied over with little modification from the Linux kernel source code. Signed-off-by: Camelia Groza --- arch/powerpc/dts/t1042d4rdb.dts | 55 - 1 file changed, 54 insertions(+), 1 delet

[PATCH v2 08/11] configs: T4240RDB: enable DM_ETH

2021-04-13 Thread Camelia Groza
From: Camelia Groza Enable DM_ETH and DM_MDIO for the T4240RDB. Signed-off-by: Camelia Groza --- configs/T4240RDB_SDCARD_defconfig | 3 +++ configs/T4240RDB_defconfig| 3 +++ 2 files changed, 6 insertions(+) diff --git a/configs/T4240RDB_SDCARD_defconfig b/configs/T4240RDB_SDCARD_def

[PATCH v2 09/11] powerpc: dts: t1042: add QorIQ DPAA 1 FMan v3 nodes

2021-04-13 Thread Camelia Groza
From: Camelia Groza Add the QorIQ DPAA 1 FMan v3 device tree nodes for the T1042 SoC. The device tree nodes are copied over with little modification from the Linux kernel source code. Signed-off-by: Camelia Groza --- arch/powerpc/dts/t1042si-post.dtsi | 46 ++ 1 fil

[PATCH v2 07/11] powerpc: dts: qoriq: update the mdio offsets under the second FMan v3

2021-04-13 Thread Camelia Groza
From: Camelia Groza When two FMan's are present on a board, the MDIO nodes are found at the same offsets inside each FMan. This causes "non unique device name" errors when registering the MDIO nodes under the second FMan. Fix this by updating the offsets of the MDIO nodes to include the parent FM

[PATCH v2 06/11] powerpc: dts: t4240rdb: add FMan v3 nodes

2021-04-13 Thread Camelia Groza
From: Camelia Groza Add the FMan v3 nodes for the T4240RDB. The nodes are copied over with little modification from the Linux kernel source code. Signed-off-by: Camelia Groza --- arch/powerpc/dts/t4240rdb.dts | 142 +- 1 file changed, 141 insertions(+), 1 deleti

[PATCH v2 05/11] powerpc: dts: t4240: add QorIQ DPAA 1 FMan v3 nodes

2021-04-13 Thread Camelia Groza
From: Camelia Groza Add the QorIQ DPAA 1 FMan v3 device tree nodes for the T4240 SoC. The device tree nodes are copied over with little modification from the Linux kernel source code. Signed-off-by: Camelia Groza --- arch/powerpc/dts/t4240si-post.dtsi | 101 + 1 fil

[PATCH v2 03/11] board: freescale: t208xrdb: fdt fixups under DM_ETH

2021-04-13 Thread Camelia Groza
From: Camelia Groza Disable the FMan mEMAC 5 and 6 nodes from the fdt since they are not available under the supported RCW. Also disable the associated "fsl,dpa-ethernet" nodes that reference them. This is a simplified version of the fdt_fixup_fman_ethernet call for use under DM_ETH. Signed-off

[PATCH v2 04/11] configs: T2080RDB: enable DM_ETH

2021-04-13 Thread Camelia Groza
From: Camelia Groza Enable DM_ETH and DM_MDIO for the T2080RDB. Signed-off-by: Camelia Groza --- configs/T2080RDB_NAND_defconfig | 3 +++ configs/T2080RDB_SDCARD_defconfig | 3 +++ configs/T2080RDB_SPIFLASH_defconfig | 3 +++ configs/T2080RDB_defconfig | 3 +++ 4 files changed,

[PATCH v2 02/11] powerpc: dts: t2080rdb: add FMan v3 nodes

2021-04-13 Thread Camelia Groza
From: Camelia Groza Add the FMan v3 nodes for the T2080RDB. The nodes are copied over with little modification from the Linux kernel source code. Signed-off-by: Camelia Groza --- arch/powerpc/dts/t2080rdb.dts | 69 ++- 1 file changed, 68 insertions(+), 1 deletio

[PATCH v2 01/11] powerpc: dts: t2080: add QorIQ DPAA 1 FMan v3 nodes

2021-04-13 Thread Camelia Groza
From: Camelia Groza Add the QorIQ DPAA 1 FMan v3 device tree nodes for the T2080 SoC. The device tree nodes are copied over with little modification from the Linux kernel source code. Signed-off-by: Camelia Groza --- arch/powerpc/dts/t2080si-post.dtsi | 51 ++ 1 fil

[PATCH v2 00/11] Enable DM_ETH for DPAA1 PowerPC T-series boards

2021-04-13 Thread Camelia Groza
This patch series enables DM_ETH and DM_MDIO on the T2080RDB, T4240RDB and T1042D4RDB DPAA1 PowerPC boards. The necessary FMan v3 Ethernet and MDIO nodes are added to each platform's SoC and board device tree. On T2080RDB, fdt fixups are performed before booting into the OS using a simplified new

[PATCH] board: sl28: fix RGMII clock and voltage

2021-04-13 Thread Michael Walle
It was noticed that the clock isn't continuously enabled when there is no link. This is because the 125MHz clock is derived from the internal PLL which seems to go into some kind of power-down mode every once in a while. The LS1028A expects a contiuous clock. Thus enable the PLL all the time. Also

Re: [BUG][Cyrus BOARD] out of bound access in board/varisys/common/sys_eeprom.c

2021-04-13 Thread Andy Fleming
On Sun, Apr 11, 2021 at 17:40 Tom Rini wrote: > On Mon, Apr 12, 2021 at 12:25:32AM +0200, Heinrich Schuchardt wrote: > > > Hello Andy, > > > > in the code of your patch "mpc85xx: Add support for the Varisys Cyrus > > board" merged in 2015 as 87e29878cab an out of bound access occurs. See > > belo

RE: [PATCH 01/11] powerpc: dts: t2080: add QorIQ DPAA 1 FMan v3 nodes

2021-04-13 Thread Camelia Alexandra Groza (OSS)
> -Original Message- > From: Priyanka Jain > Sent: Tuesday, April 13, 2021 12:48 > To: Camelia Alexandra Groza (OSS) ; u- > b...@lists.denx.de; w...@denx.de; Shengzhou Liu > ; Z.q. Hou > Cc: Madalin Bucur (OSS) ; Camelia Alexandra > Groza > Subject: RE: [PATCH 01/11] powerpc: dts: t2080:

Re: [PATCH v3] cmd: net: Add the "arp" command

2021-04-13 Thread Sean Anderson
On 4/13/21 11:14 AM, lg...@hotmail.com wrote: From: Joe Xue The command is to query and show mac address of a specific ipAddress. Signed-off-by: Joe Xue --- cmd/Kconfig | 6 ++ cmd/net.c | 37 + doc/usage/arp.rst | 31

[PATCH v3] cmd: net: Add the "arp" command

2021-04-13 Thread lgxue
From: Joe Xue The command is to query and show mac address of a specific ipAddress. Signed-off-by: Joe Xue --- cmd/Kconfig | 6 ++ cmd/net.c | 37 + doc/usage/arp.rst | 31 +++ include/net.h | 5 + net

[PATCH] watchdog: use time_after_eq() in watchdog_reset()

2021-04-13 Thread Rasmus Villemoes
Some boards don't work with the rate-limiting done in the generic watchdog_reset() provided by wdt-uclass. For example, on powerpc, get_timer() ceases working during bootm since interrupts are disabled before the kernel image gets decompressed, and when the decompression takes longer than the watc

Re: [PATCH] [RFC] cmd: exit: Fix return value

2021-04-13 Thread Tom Rini
On Tue, Apr 06, 2021 at 02:00:24PM +0200, Marek Vasut wrote: > In case exit is called in a script without parameter, the command > returns -2 ; in case exit is called with a numerical parameter, > the command returns -2 and lower. This leads to the following problem: > => setenv foo 'echo bar ; ex

Re: [PATCH v7 2/2] gpio: Drop dm_gpio_set_dir()

2021-04-13 Thread Tom Rini
On Tue, Mar 23, 2021 at 02:52:07PM +1300, Simon Glass wrote: > This function is not used. Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] scmi: translate the resource only when livetree is not activated

2021-04-13 Thread Tom Rini
On Tue, Mar 30, 2021 at 03:29:03PM +0200, Patrick Delaunay wrote: > Call the translation function on the ofnode_read_resource result only > when the livetree is not activated. > > Today of_address_to_resource() calls ofnode_read_resource() for livetree > support and fdt_get_resource() when livetr

Re: [PATCH v7 1/2] gpio: i2c-gpio: Drop use of dm_gpio_set_dir()

2021-04-13 Thread Tom Rini
On Tue, Mar 23, 2021 at 02:52:06PM +1300, Simon Glass wrote: > This is the only driver that uses this function. Update it to use the > alternative which is dm_gpio_clrset_flags(). > > Signed-off-by: Simon Glass > Tested-by: Harm Berntsen Applied to u-boot/master, thanks! -- Tom signature.a

Re: [PATCH v8 4/4] qemu: arm: select QFW, MMIO on qemu-arm

2021-04-13 Thread Tom Rini
On Fri, Mar 19, 2021 at 06:21:43PM +1100, Asherah Connor wrote: > Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and > arm64). > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass > Reviewed-by: Bin Meng Applied to u-boot/master, thanks! -- Tom signature.asc Descrip

Re: [PATCH 2/2] moveconfig.py: add to the "do not process" list

2021-04-13 Thread Tom Rini
On Mon, Mar 15, 2021 at 12:01:33PM -0400, Trevor Woerner wrote: > Skip the processing of *.aml and *.dat files while iterating through the > source in order to process header files. > > Signed-off-by: Trevor Woerner Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP sig

Re: [PATCH v2 1/5] lib: string: Fix strlcpy return value

2021-04-13 Thread Tom Rini
On Thu, Mar 11, 2021 at 12:15:41AM -0500, Sean Anderson wrote: > strlcpy should always return the number of bytes copied. We were > accidentally missing the nul-terminator. We also always used to return a > non-zero value, even if we did not actually copy anything. > > Fixes: 23cd138503 ("Integra

Re: [PATCH v8 2/4] test: qemu: add qfw sandbox driver, dm tests, qemu tests

2021-04-13 Thread Tom Rini
On Fri, Mar 19, 2021 at 06:21:41PM +1100, Asherah Connor wrote: > A sandbox driver and test are added for the qfw uclass, and a test in > QEMU added for qfw functionality to confirm it doesn't break in real > world use. > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass > Reviewed-by:

Re: [PATCH v8 3/4] qemu: add MMIO driver for QFW

2021-04-13 Thread Tom Rini
On Fri, Mar 19, 2021 at 06:21:42PM +1100, Asherah Connor wrote: > Add MMIO driver for QFW. > > Note that there is no consumer as of this patch. > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass > Reviewed-by: Bin Meng Applied to u-boot/master, thanks! -- Tom signature.asc Desc

Re: [PATCH v8 1/4] x86: qemu: move QFW to its own uclass

2021-04-13 Thread Tom Rini
On Fri, Mar 19, 2021 at 06:21:40PM +1100, Asherah Connor wrote: > We move qfw into its own uclass and split the PIO functions into a > specific driver for that uclass. The PIO driver is selected in the > qemu-x86 board config (this covers x86 and x86_64). > > include/qfw.h is cleaned up and docu

Re: [PATCH v2 5/5] checkpatch: Add warnings for using strn(cat|cpy)

2021-04-13 Thread Tom Rini
On Thu, Mar 11, 2021 at 12:15:45AM -0500, Sean Anderson wrote: > strn(cat|cpy) has a bad habit of not nul-terminating the destination, > resulting in constructions like > > strncpy(foo, bar, sizeof(foo) - 1); > foo[sizeof(foo) - 1] = '\0'; > > However, it is very easy to forget about

Re: [PATCH] scmi: correctly configure MMU for SCMI buffer

2021-04-13 Thread Tom Rini
On Tue, Mar 16, 2021 at 09:29:40AM +0100, Patrick Delaunay wrote: > Align the MMU area for SCMI shared buffer on section size; > use the ALIGN macro in mmu_set_region_dcache_behaviour call. > > Since commit d877f8fd0f09 ("arm: provide a function for boards init > code to modify MMU virtual-physic

Re: [PATCH v2 4/5] fastboot: Fix possible buffer overrun

2021-04-13 Thread Tom Rini
On Thu, Mar 11, 2021 at 12:15:44AM -0500, Sean Anderson wrote: > This fixes several uses of strn(cpy|cat) which did not terminate their > destinations properly. > > Fixes de1728ce4c ("fastboot: Allow u-boot-style partitions") > > Reported-by: Coverity Scan > Signed-off-by: Sean Anderson Applie

Re: Getting rid of falcon mode

2021-04-13 Thread Maxime Ripard
On Tue, Apr 13, 2021 at 10:13:50AM -0400, Tom Rini wrote: > On Tue, Apr 13, 2021 at 09:08:01AM -0500, Alex G. wrote: > > Hi Maxime, > > > > On 4/13/21 3:56 AM, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Apr 12, 2021 at 04:32:49PM -0500, Alex G. wrote: > > > > ## Introduction > > > > > >

Re: [PATCH v2] tee: optee: Change printing during optee_probe

2021-04-13 Thread Tom Rini
On Wed, Mar 10, 2021 at 03:35:11PM +0200, Ilias Apalodimas wrote: > Right now the error messages when optee has a version mismatch or shared > memory is not configured are done with a debug(). > That's not very convenient since you have to enable debugging to figure > out what's going on, although

Re: [PATCH v2 3/5] test: Add test for strlcat

2021-04-13 Thread Tom Rini
On Thu, Mar 11, 2021 at 12:15:43AM -0500, Sean Anderson wrote: > This test is adapted from glibc, which is very concerned about alignment. > It also tests strlcpy by dependency. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.a

Re: [PATCH 1/2] terminal: correct stdio_dev invocations

2021-04-13 Thread Tom Rini
On Wed, Mar 10, 2021 at 10:39:23PM +1100, Asherah Connor wrote: > stdio_dev methods have taken a pointer to themselves since 709ea543 > (nearly 7 years ago). > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v2 2/5] lib: string: Implement strlcat

2021-04-13 Thread Tom Rini
On Thu, Mar 11, 2021 at 12:15:42AM -0500, Sean Anderson wrote: > This introduces strlcat, which provides a safer interface than strncat. It > never copies more than its size bytes, including the terminating nul. In > addition, it never reads past dest[size - 1], even if dest is not > nul-terminate

Re: [PATCH 2/2] terminal: only serial_reinit_all if available

2021-04-13 Thread Tom Rini
On Wed, Mar 10, 2021 at 10:39:24PM +1100, Asherah Connor wrote: > serial_reinit_all() is only available if CONFIG_SERIAL is defined (i.e. > !CONFIG_DM_SERIAL). > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: P

Re: [PATCH v4 4/5] test: scmi: add local variables for scmi agent reference

2021-04-13 Thread Tom Rini
On Mon, Mar 08, 2021 at 10:38:09PM +0100, Etienne Carriere wrote: > Add local variables agent0/agent1 to refer to SCMI sandbox context > agent and ease readability of the test. > > For consistency, rename regul_dev to regul0_dev and remove sandbox_voltd > in dm_test_scmi_voltage_domains(). > > S

Re: [PATCH v2] rtc: add support for rv3028 rtc

2021-04-13 Thread Tom Rini
On Wed, Mar 10, 2021 at 08:15:00AM +0100, Heiko Schocher wrote: > Add support for rtc3028 rtc from microcrystal. > based on linux dirver: > commit a38fd8748464: ("Linux 5.12-rc2") > > Signed-off-by: Heiko Schocher > > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom sign

Re: [PATCH] disk: gpt: verify alternate LBA points to last usable LBA

2021-04-13 Thread Tom Rini
On Mon, Mar 08, 2021 at 04:07:11PM +, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > The gpt command require the GPT backup header at the standard location > at the end of the device. Check the alternate LBA value before reading > the GPT backup header from the last usable

Re: [PATCH v4 3/5] firmware: scmi: fix inline comments and minor coding style issues

2021-04-13 Thread Tom Rini
On Mon, Mar 08, 2021 at 10:38:08PM +0100, Etienne Carriere wrote: > Fix inline comments and empty line in scmi driver and test files. > > Remove test on IS_ENABLED(CONFIG_*_SCMI) in test/dm/scmi.c since these > configuration are expected enabled when CONFIG_FIRMWARE_SCMI is enabled > in sandbox c

Re: [PATCH v4 2/5] firmware: scmi: sandbox test for voltage regulator

2021-04-13 Thread Tom Rini
On Mon, Mar 08, 2021 at 10:38:07PM +0100, Etienne Carriere wrote: > Implement sandbox regulator devices for SCMI voltage domains > and test them in DM scmi tests. > > Signed-off-by: Etienne Carriere > Reviewed-by: Simon Glass > Reviewed-by: Jaehoon Chung Applied to u-boot/master, thanks! --

Re: [PATCH] pci: Mark 64bit Memory BARs as such

2021-04-13 Thread Tom Rini
On Wed, Mar 03, 2021 at 01:57:35AM +0100, Phil Sutter wrote: > Just a bit more info to the reader. > > Signed-off-by: Phil Sutter > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 1/5] firmware: scmi: voltage regulator

2021-04-13 Thread Tom Rini
On Mon, Mar 08, 2021 at 10:38:06PM +0100, Etienne Carriere wrote: > Implement voltage regulators interfaced by the SCMI voltage domain > protocol. The DT bindings are defined in the Linux kernel since > SCMI voltage domain and regulators patches [1] and [2] integration > in v5.11-rc7. > > Link: [

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-04-13 Thread Tom Rini
On Sun, Feb 28, 2021 at 04:29:51PM -0500, Sean Anderson wrote: > If there were no variable substitutions in a command, then initial > assignments would be misinterpreted as commands, instead of being skipped > over. This is demonstrated by the following example: > > => foo=bar echo baz >

Re: [PATCH] cmd: xtrace: Convert to bool

2021-04-13 Thread Tom Rini
On Thu, Mar 04, 2021 at 11:34:23AM -0500, Sean Anderson wrote: > This variable is a boolean, not a string. > > Signed-off-by: Sean Anderson > Reviewed-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/3] hw_sha: Fix coding style errors

2021-04-13 Thread Tom Rini
On Wed, Feb 17, 2021 at 01:50:40PM +1030, Joel Stanley wrote: > Checkpatch complains about: > > ERROR: "foo * bar" should be "foo *bar" > > and > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Joel Stanley Applied to u-boot/master, thanks! -- Tom signature.asc Desc

Re: [PATCH] mtd: Update fail_addr when erase fails due to bad blocks

2021-04-13 Thread Tom Rini
On Wed, Feb 24, 2021 at 03:25:53PM -0800, Farhan Ali wrote: > For all other erase failures, the fail_addr is updated with the > failing address. Only in the case of erase failure due to bad block > detection, the fail_addr is not updated. This change simply updates > the fail_addr for this specifi

Re: [PATCH 3/3] hash: Allow for SHA512 hardware implementations

2021-04-13 Thread Tom Rini
On Wed, Feb 17, 2021 at 01:50:42PM +1030, Joel Stanley wrote: > Similar to support for SHA1 and SHA256, allow the use of hardware hashing > engine by enabling the algorithm and setting CONFIG_SHA_HW_ACCEL / > CONFIG_SHA_PROG_HW_ACCEL. > > Signed-off-by: Joel Stanley Applied to u-boot/master, t

Re: [PATCH] Tegra: remove e2220-1170 board

2021-04-13 Thread Tom Rini
On Wed, Feb 17, 2021 at 05:06:53PM +, Peter Robinson wrote: > It's an old bringup board with out upstream Linux or L4T support > > Signed-off-by: Peter Robinson > Cc: Stephen Warren > Cc: Tom Warren > Acked-by: Stephen Warren Applied to u-boot/master, thanks! -- Tom signature.asc Des

Re: [PATCH 1/2] board: warp: add power_max77696_init() function

2021-04-13 Thread Tom Rini
On Thu, Jan 28, 2021 at 08:42:33PM +0900, Jaehoon Chung wrote: > Add power_max77696_init() function. > Since warp doesn't support DM, the keeping its code in board file is > better than maintainig the file of driver. > > Signed-off-by: Jaehoon Chung Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] lib: optee: migration optee_copy_fdt_nodes for OF_LIVE support

2021-04-13 Thread Tom Rini
On Mon, Feb 08, 2021 at 01:54:31PM +0100, Patrick Delaunay wrote: > The optee_copy_fdt_nodes is only used to copy op-tee nodes > of U-Boot device tree (from gd->fdt_blob when OF_LIVE is not activated) > to external device tree but it is not compatible with OF_LIVE. > > This patch migrates all use

Re: [PATCH] bootm: do not hang on failure

2021-04-13 Thread Tom Rini
On Wed, Feb 17, 2021 at 12:55:54PM +0100, Heinrich Schuchardt wrote: > On ARMv8 systems > > load mmc 0:1 $loadaddr vmlinuz-5.10.0-3-arm64 > booti > > leads to a hanging system requiring to physically reset the system: > > FDT and ATAGS support not compiled in - hanging > ### ER

Re: [PATCH 2/2] power: pmic: remove pmic_max77696.c file

2021-04-13 Thread Tom Rini
On Thu, Jan 28, 2021 at 08:42:34PM +0900, Jaehoon Chung wrote: > Remove pmic_max77696.c file. > The maintaining pmic_max77696.c file is useless. > > Signed-off-by: Jaehoon Chung Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: Getting rid of falcon mode

2021-04-13 Thread Maxime Ripard
On Tue, Apr 13, 2021 at 09:08:01AM -0500, Alex G. wrote: > On 4/13/21 3:56 AM, Maxime Ripard wrote: > > On Mon, Apr 12, 2021 at 04:32:49PM -0500, Alex G. wrote: > > > ## Introduction > > > > > > Today we use "falcon mode" to mean "boot linux straight from SPL". This > > > designation makes sense,

Re: Getting rid of falcon mode

2021-04-13 Thread Tom Rini
On Tue, Apr 13, 2021 at 09:08:01AM -0500, Alex G. wrote: > Hi Maxime, > > On 4/13/21 3:56 AM, Maxime Ripard wrote: > > Hi, > > > > On Mon, Apr 12, 2021 at 04:32:49PM -0500, Alex G. wrote: > > > ## Introduction > > > > > > Today we use "falcon mode" to mean "boot linux straight from SPL". This >

Re: Getting rid of falcon mode

2021-04-13 Thread Alex G.
Hi Maxime, On 4/13/21 3:56 AM, Maxime Ripard wrote: Hi, On Mon, Apr 12, 2021 at 04:32:49PM -0500, Alex G. wrote: ## Introduction Today we use "falcon mode" to mean "boot linux straight from SPL". This designation makes sense, since falcons "fly at high speed and change direction rapidly" acco

[u-boot-fslc] enable d-cache in SPL for i.MX6

2021-04-13 Thread Asfak Rahman
Hello, Has anybody succeeded to enable d-cache in SPL for imx6 (SOLO/DUAL) chip? I am using u-boot-fslc 2018.11. I found one patch which enables d-cache for omap chip, but similar approach did not work for me. The omap patch: https://lists.denx.de/pipermail/u-boot/2016-November/274325.html Best

RE: [PATCH 01/11] powerpc: dts: t2080: add QorIQ DPAA 1 FMan v3 nodes

2021-04-13 Thread Priyanka Jain
>-Original Message- >From: Camelia Alexandra Groza (OSS) >Sent: Friday, April 9, 2021 7:53 PM >To: u-boot@lists.denx.de; Priyanka Jain ; w...@denx.de; >Shengzhou Liu ; Z.q. Hou >Cc: Madalin Bucur (OSS) ; Camelia Alexandra >Groza >Subject: [PATCH 01/11] powerpc: dts: t2080: add QorIQ DP

[RFC PATCH v5 2/2] board: sifive: unmatched: clear feature disable CSR

2021-04-13 Thread Green Wan
Clear feature disable CSR to turn on all features of hart. The detail is specified at section, 'SiFive Feature Disable CSR', in user manual https://sifive.cdn.prismic.io/sifive/aee0dd4c-d156-496e-a6c4-db0cf54bbe68_sifive_U74MC_rtl_full_20G1.03.00_manual.pdf Signed-off-by: Green Wan Reviewed-by:

[RFC PATCH v5 1/2] arch: riscv: cpu: Add callback to init each core

2021-04-13 Thread Green Wan
Add a callback harts_early_init() to ./arch/riscv/cpu/start.S to allow different riscv hart perform setup code for each hart as early as possible. Since all the harts enter the callback, they must be able to run the same setup. Signed-off-by: Green Wan --- arch/riscv/cpu/cpu.c | 15 +++

[RFC PATCH v5 0/2] arch: riscv: cpu: Add callback to init each core

2021-04-13 Thread Green Wan
Add a callback interface, harts_early_init() to perform riscv CPU hart-dependent configuration for each hart. harts_early_init() is placed after stack of harts are initialized and before main boot hart is picked up. Several conditions should be aware of or avoided are listed: - cannot access gd

Re: Getting rid of falcon mode

2021-04-13 Thread Maxime Ripard
Hi, On Mon, Apr 12, 2021 at 04:32:49PM -0500, Alex G. wrote: > ## Introduction > > Today we use "falcon mode" to mean "boot linux straight from SPL". This > designation makes sense, since falcons "fly at high speed and change > direction rapidly" according to Wikipedia. > > The way we implement

Re: [RFC PATCH v4 1/2] arch: riscv: cpu: Add callback to init each core

2021-04-13 Thread Green Wan
On Tue, Apr 13, 2021 at 12:17 PM Sean Anderson wrote: > > On 4/13/21 12:12 AM, Rick Chen wrote: > > Hi Sean > > > >> On 4/12/21 10:39 PM, Rick Chen wrote: > >>> Hi Green, > >>> > From: Green Wan [mailto:green@sifive.com] > Sent: Monday, April 12, 2021 10:33 AM > To: Sean Anderso

Re: [RFC PATCH v4 1/2] arch: riscv: cpu: Add callback to init each core

2021-04-13 Thread Green Wan
Hi Rick, Sorry for the late reply. My working environment got problems. Just recovered from it. See my reply below. On Tue, Apr 13, 2021 at 11:33 AM Rick Chen wrote: > > Hi Green, > > > From: Green Wan [mailto:green@sifive.com] > > Sent: Tuesday, March 30, 2021 1:27 PM > > Cc: Green Wan; Ric

[PATCH] configs: ls1046afrwy: Add secure boot config

2021-04-13 Thread Manish Tomar
Add required CONFIG_NXP_ESBC for ls1046afrwy to enable ESBC Chain of Trust. Signed-off-by: Manish Tomar --- configs/ls1046afrwy_tfa_SECURE_BOOT_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/ls1046afrwy_tfa_SECURE_BOOT_defconfig b/configs/ls1046afrwy_tfa_SECURE_BOOT_defco