[PATCH v2] test/py: efi_capsule: align with efidebug syntax changes

2021-07-19 Thread AKASHI Takahiro
After the commit c70f44817d46 ("efi_loader: simplify 'printenv -e'"), "-all" option is no longer necessary. Just remove them in the test script. Fixes: c70f44817d46 ("efi_loader: simplify 'printenv -e'") Signed-off-by: AKASHI Takahiro --- v2: no change ---

[PATCH v2] efi_loader: remove asm/setjmp.h from efi_api.h

2021-07-19 Thread AKASHI Takahiro
In the commit c982874e930d ("efi_loader: refactor efi_setup_loaded_image()"), setjmp-related definitions were moved to efi_loaded_image_obj in efi_loader.h. So setjmp.h is no longer refererenced in efi_api.h. This also fixes some error when efi_api.h will be included in mkeficapsule.c. Fixes:

[PATCH v2] efi_loader: capsule: remove unused guid

2021-07-19 Thread AKASHI Takahiro
efi_guid_capsule_root_cert_guid is never used. Just remove it. Signed-off-by: AKASHI Takahiro --- v2: correct the commit message --- lib/efi_loader/efi_capsule.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c index

[PATCH v2] efi_loader: capsule: remove authentication data

2021-07-19 Thread AKASHI Takahiro
If capsule authentication is disabled and yet a capsule file is signed, its signature must be removed from image data to flush. Otherwise, the firmware will be corrupted after update. Fixes: 04be98bd6bcf ("efi: capsule: Add support for uefi capsule authentication") Signed-off-by: AKASHI

Re: [PATCH] efi_loader: capsule: remove authentication data

2021-07-19 Thread AKASHI Takahiro
Please ignore this patch as I mistakenly sent out v1. -Takahiro Akashi On Tue, Jul 20, 2021 at 02:44:42PM +0900, AKASHI Takahiro wrote: > If capsule authentication is disabled and yet a capsule file is signed, > its signature must be removed from image data to flush. > Otherwise, the firmware

[PATCH] efi_loader: capsule: remove authentication data

2021-07-19 Thread AKASHI Takahiro
If capsule authentication is disabled and yet a capsule file is signed, its signature must be removed from image data to flush. Otherwise, the firmware will be corrupted after update. Fixes: 04be98bd6bcf ("efi: capsule: Add support for uefi capsule authentication") Signed-off-by: AKASHI

Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

2021-07-19 Thread Jaehoon Chung
On 7/20/21 2:23 PM, Lokesh Vutla wrote: > > > On 20/07/21 10:51 am, Jaehoon Chung wrote: >> Hi Lokesh, >> >> On 7/20/21 1:10 PM, Lokesh Vutla wrote: >>> +Tom >>> >>> On 20/07/21 3:45 am, Jaehoon Chung wrote: Hi Aswath, On 7/19/21 3:48 PM, Aswath Govindraju wrote: > Hi Peng,

Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

2021-07-19 Thread Lokesh Vutla
On 20/07/21 10:51 am, Jaehoon Chung wrote: > Hi Lokesh, > > On 7/20/21 1:10 PM, Lokesh Vutla wrote: >> +Tom >> >> On 20/07/21 3:45 am, Jaehoon Chung wrote: >>> Hi Aswath, >>> >>> On 7/19/21 3:48 PM, Aswath Govindraju wrote: Hi Peng, On 09/06/21 8:56 pm, Aswath Govindraju wrote:

Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

2021-07-19 Thread Jaehoon Chung
Hi Lokesh, On 7/20/21 1:10 PM, Lokesh Vutla wrote: > +Tom > > On 20/07/21 3:45 am, Jaehoon Chung wrote: >> Hi Aswath, >> >> On 7/19/21 3:48 PM, Aswath Govindraju wrote: >>> Hi Peng, >>> >>> On 09/06/21 8:56 pm, Aswath Govindraju wrote: Hi Peng, On 10/05/21 7:18 pm, Aswath

Re: [PATCH 2/2] cmd/sbi: add missing SBI information

2021-07-19 Thread Sean Anderson
On 7/20/21 12:59 AM, Heinrich Schuchardt wrote: Am 20. Juli 2021 03:11:34 MESZ schrieb Sean Anderson : On 7/19/21 4:28 PM, Heinrich Schuchardt wrote: Let the sbi command display: * SBI implementation version * machine vendor ID * machine architecture ID * machine implementation ID With this

Re: Help wanted: Adding OpenSSL in FSL HAB

2021-07-19 Thread Daniel D
The architecture is arm (i.MX 6UL board) and I've successfully added HAB. I want to include OpenSSL library into the U-Boot now. Can you comment on this? Kind regards, Daniel Selvan D. -- P Please consider the environment before printing this email. From: "Jojan" To: "u-boot" ,

Re: [PATCH 2/2] cmd/sbi: add missing SBI information

2021-07-19 Thread Heinrich Schuchardt
Am 20. Juli 2021 03:11:34 MESZ schrieb Sean Anderson : >On 7/19/21 4:28 PM, Heinrich Schuchardt wrote: >> Let the sbi command display: >> >> * SBI implementation version >> * machine vendor ID >> * machine architecture ID >> * machine implementation ID >> >> With this patch the output for the

Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

2021-07-19 Thread Lokesh Vutla
+Tom On 20/07/21 3:45 am, Jaehoon Chung wrote: > Hi Aswath, > > On 7/19/21 3:48 PM, Aswath Govindraju wrote: >> Hi Peng, >> >> On 09/06/21 8:56 pm, Aswath Govindraju wrote: >>> Hi Peng, >>> >>> On 10/05/21 7:18 pm, Aswath Govindraju wrote: Hi Peng, On 07/04/21 3:52 am, Jaehoon

Re: IMX8M Mini HAB secure boot - working?

2021-07-19 Thread Heiko Schocher
Hello Tim, On 20.07.21 00:23, Tim Harvey wrote: > On Sun, Jul 18, 2021 at 9:01 PM Heiko Schocher wrote: >> >> Hello Tim, >> >> On 12.07.21 18:06, Tim Harvey wrote: >>> On Sat, Jul 10, 2021 at 5:24 AM Heiko Schocher wrote: Hi Tim, Stefano, On 10.07.21 11:14, Stefano Babic

[PATCH v3 2/2] arm: imx8m: add support for Advantech RSB-3720

2021-07-19 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Add initial support for Advantech RSB-3720 board. The initial support includes: - MMC - eMMC - I2C - FEC - Serial console Signed-off-by: Darren Huang Signed-off-by: Kevin12.Chen Signed-off-by: Phill.Liu Signed-off-by: Tim Liang Signed-off-by: wei.zeng

Re: [PATCH] test/py: efi_capsule: aligned with efidebug syntax changes

2021-07-19 Thread AKASHI Takahiro
On Thu, May 20, 2021 at 05:14:36AM +0200, Heinrich Schuchardt wrote: > On 5/10/21 10:21 AM, AKASHI Takahiro wrote: > > In the subject: %s/aligned/align/ I think that the passive usage is grammatically correct here, but I can fix it if you like. > > After the commit c70f44817d46 ("efi_loader:

Re: [PATCH] efi_loader: move asm/setjmp.h to efi_loader.h

2021-07-19 Thread AKASHI Takahiro
On Thu, May 20, 2021 at 04:48:23AM +0200, Heinrich Schuchardt wrote: > On 5/10/21 10:21 AM, AKASHI Takahiro wrote: > > In the commit c982874e930d ("efi_loader: refactor > > efi_setup_loaded_image()"), setjmp-related definitions were moved to > > efi_loaded_image_obj in efi_loader.h. So setjmp.h is

Re: [PATCH] efi_loader: capsule: remove authentication data

2021-07-19 Thread AKASHI Takahiro
On Thu, May 20, 2021 at 04:37:58AM +0200, Heinrich Schuchardt wrote: > On 5/10/21 10:20 AM, AKASHI Takahiro wrote: > > If capsule authentication is disabled and yet a capsule file is signed, > > its signature must be removed from image data to flush. > > Otherwise, the firmware will be corrupted

Re: [PATCH] efi_loader: capsule: add a debug message in case of no key

2021-07-19 Thread AKASHI Takahiro
On Thu, May 20, 2021 at 04:06:12AM +0200, Heinrich Schuchardt wrote: > On 5/10/21 10:19 AM, AKASHI Takahiro wrote: > > It will probably be a common error case that a certificate (public key) > > is not provided by the system while capsule authentication is enabled. > > So add a debug message. > >

Re: [PATCH] efi_loader: capsule: remove unused guid

2021-07-19 Thread AKASHI Takahiro
On Tue, May 18, 2021 at 10:32:28PM +0200, Heinrich Schuchardt wrote: > On 5/10/21 10:20 AM, AKASHI Takahiro wrote: > > EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID is never used. > > Just remove it. > > > > Signed-off-by: AKASHI Takahiro > > --- > > lib/efi_loader/efi_capsule.c | 3 --- > > 1 file

Re: [PATCH 2/2] cmd/sbi: add missing SBI information

2021-07-19 Thread Sean Anderson
On 7/19/21 4:28 PM, Heinrich Schuchardt wrote: Let the sbi command display: * SBI implementation version * machine vendor ID * machine architecture ID * machine implementation ID With this patch the output for the HiFive Unmatched looks like => sbi SBI 0.3 OpenSBI 0.9

Re: [PATCH 1/2] riscv: provide missing base extension functions

2021-07-19 Thread Sean Anderson
On 7/19/21 4:28 PM, Heinrich Schuchardt wrote: Provide library functions to read: * SBI implementation version * machine vendor ID * machine architecture ID * machine implementation ID Signed-off-by: Heinrich Schuchardt --- arch/riscv/include/asm/sbi.h | 4 ++ arch/riscv/lib/sbi.c

Re: U-Boot loaded RAMDisk crashes Linux on MT7623

2021-07-19 Thread Daniel Schwierzeck
Hi Daniel, Am Montag, den 19.07.2021, 18:34 +0100 schrieb Daniel Golle: > Hi, > > I writing in the hope that someone has a good idea about why U-boot > is > handing over a broken memory address for a loaded ramdisk which > results > in Linux crashing very early on boot on MediaTek's MT7623N SoC

Re: U-Boot loaded RAMDisk crashes Linux on MT7623

2021-07-19 Thread Daniel Golle
Hi again, On Mon, Jul 19, 2021 at 06:34:38PM +0100, Daniel Golle wrote: > ... >Loading Ramdisk to ff4b9000, end ff9fab18 ... OK >^^ >Using Device Tree in place at 889f9288, end 88a04534 > > Starting kernel ... > ... > [0.00] Zone

Re: using binman fails boot

2021-07-19 Thread Tim Harvey
On Sat, Jul 17, 2021 at 7:22 PM Simon Glass wrote: > > Hi Tim, > > On Fri, 16 Jul 2021 at 17:15, Tim Harvey wrote: > > > > On Fri, Jul 16, 2021 at 3:11 PM Simon Glass wrote: > > > > > > () which has > > > Hi Tim, > > > > > > On Fri, 16 Jul 2021 at 15:43, Tim Harvey wrote: > > > > > > > > On

Re: IMX8M Mini HAB secure boot - working?

2021-07-19 Thread Tim Harvey
On Sun, Jul 18, 2021 at 9:01 PM Heiko Schocher wrote: > > Hello Tim, > > On 12.07.21 18:06, Tim Harvey wrote: > > On Sat, Jul 10, 2021 at 5:24 AM Heiko Schocher wrote: > >> > >> Hi Tim, Stefano, > >> > >> On 10.07.21 11:14, Stefano Babic wrote: > >>> Hi Tim, > >>> > >>> On 10.07.21 02:05, Tim

Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

2021-07-19 Thread Jaehoon Chung
Hi Aswath, On 7/19/21 3:48 PM, Aswath Govindraju wrote: > Hi Peng, > > On 09/06/21 8:56 pm, Aswath Govindraju wrote: >> Hi Peng, >> >> On 10/05/21 7:18 pm, Aswath Govindraju wrote: >>> Hi Peng, >>> >>> On 07/04/21 3:52 am, Jaehoon Chung wrote: On 4/5/21 11:44 PM, Aswath Govindraju wrote:

Re: [RFC 1/1] board: sifive: unmatched: use zero copy for initrd

2021-07-19 Thread Tom Rini
On Mon, Jul 19, 2021 at 11:52:09PM +0200, Heinrich Schuchardt wrote: > > > On 19.07.21 23:38, Heinrich Schuchardt wrote: > > Booting Ubuntu Impish showed the following output: > > > > relocaddr = 0xfff6 > > > > Loading Ramdisk to fa118000, end f19d ... > > > > The

Re: [RFC 1/1] board: sifive: unmatched: use zero copy for initrd

2021-07-19 Thread Heinrich Schuchardt
On 19.07.21 23:38, Heinrich Schuchardt wrote: Booting Ubuntu Impish showed the following output: relocaddr = 0xfff6 Loading Ramdisk to fa118000, end f19d ... The initrd is overwriting the U-Boot binary. Booting fails. There is no need to copy the initrd from

[RFC 1/1] board: sifive: unmatched: use zero copy for initrd

2021-07-19 Thread Heinrich Schuchardt
Booting Ubuntu Impish showed the following output: relocaddr = 0xfff6 Loading Ramdisk to fa118000, end f19d ... The initrd is overwriting the U-Boot binary. Booting fails. There is no need to copy the initrd from $ramdisk_addr_r. Set init_high = ~0UL to use zero copy.

Re: [PATCH 2/2] mx6cuboxi: Fix the console variable

2021-07-19 Thread Peter Robinson
On Mon, Jul 19, 2021 at 9:15 PM Fabio Estevam wrote: > > Do not pass the console baudrate to the 'console' variable > to avoid the baudrate being passed twice when extlinux.conf > contains the standard: console=${console},${baudrate} format. Maybe we could deal with this using the stdout-path

Re: Please pull u-boot-marvell/master

2021-07-19 Thread Tom Rini
On Mon, Jul 19, 2021 at 02:37:11PM +0200, Stefan Roese wrote: > Hi Tom, > > please pull the next batch of Marvell MVEBU related patches. Here the > summary log: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [GIT PULL] TI changes for v2021.10-rc1

2021-07-19 Thread Tom Rini
On Mon, Jul 19, 2021 at 11:05:27AM +0530, Lokesh Vutla wrote: > Hi Tom, > Please find the PR for master branch targeted for v2021.10-rc1 tag. > Details about the PR are updated in the tag message. > > Gitlab CI report: > https://source.denx.de/u-boot/custodians/u-boot-ti/-/pipelines/8254

Re: [PATCH 1/2] mx6cuboxi: Fix the mmc device for the rootfs

2021-07-19 Thread Peter Robinson
On Mon, Jul 19, 2021 at 9:15 PM Fabio Estevam wrote: > > After the conversion to DM_MMC, the rootfs becomes mmc 1, so > adjust it accordingly. Should this be fixed with an alias in the dts, what's now on mmc 0? > Signed-off-by: Fabio Estevam > --- > include/configs/mx6cuboxi.h | 2 +- > 1

[PATCH 0/2] cmd/sbi: add missing SBI information

2021-07-19 Thread Heinrich Schuchardt
The series provides library functions to read * SBI implementation version * machine vendor ID * machine architecture ID * machine implementation ID and enhances the sbi command to display this information. Heinrich Schuchardt (2): riscv: provide missing base extension functions cmd/sbi:

[PATCH 1/2] riscv: provide missing base extension functions

2021-07-19 Thread Heinrich Schuchardt
Provide library functions to read: * SBI implementation version * machine vendor ID * machine architecture ID * machine implementation ID Signed-off-by: Heinrich Schuchardt --- arch/riscv/include/asm/sbi.h | 4 ++ arch/riscv/lib/sbi.c | 71 2 files

[PATCH 2/2] cmd/sbi: add missing SBI information

2021-07-19 Thread Heinrich Schuchardt
Let the sbi command display: * SBI implementation version * machine vendor ID * machine architecture ID * machine implementation ID With this patch the output for the HiFive Unmatched looks like => sbi SBI 0.3 OpenSBI 0.9 Machine: Vendor ID 489 Architecture ID

[PATCH] lib: rsa: rsa-sign: Minor bug in debug message

2021-07-19 Thread Chan, Donald
*sig_size isn't set until later so use the correct variables. Signed-off-by: Donald Chan --- lib/rsa/rsa-sign.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c index f70f352311..5b85d61a13 100644 --- a/lib/rsa/rsa-sign.c +++

[PATCH 2/2] mx6cuboxi: Fix the console variable

2021-07-19 Thread Fabio Estevam
Do not pass the console baudrate to the 'console' variable to avoid the baudrate being passed twice when extlinux.conf contains the standard: console=${console},${baudrate} format. cat /proc/cmdline root=PARTUUID=-01 rootwait rw console=ttymxc0,115200,115200 Signed-off-by: Fabio Estevam

[PATCH 1/2] mx6cuboxi: Fix the mmc device for the rootfs

2021-07-19 Thread Fabio Estevam
After the conversion to DM_MMC, the rootfs becomes mmc 1, so adjust it accordingly. Signed-off-by: Fabio Estevam --- include/configs/mx6cuboxi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h index

U-Boot loaded RAMDisk crashes Linux on MT7623

2021-07-19 Thread Daniel Golle
Hi, I writing in the hope that someone has a good idea about why U-boot is handing over a broken memory address for a loaded ramdisk which results in Linux crashing very early on boot on MediaTek's MT7623N SoC (ARMv7). If anyone has a good idea why this is happening, I'd be very glad, as this

[PATCH v3 1/2] arm: dts: add imx8mp-rsb3720-a1 dts file

2021-07-19 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Add board dts for imx8mm-cl-iot-gate Signed-off-by: Darren Huang Signed-off-by: Kevin12.Chen Signed-off-by: Phill.Liu Signed-off-by: Tim Liang Signed-off-by: wei.zeng Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: uboot-imx --- v2: update dts ---

[PATCH v3 0/2] arm: imx8m: add support for Advantech RSB-3720

2021-07-19 Thread Ying-Chun Liu
From: "Ying-Chun Liu (PaulLiu)" Add initial support for Advantech RSB-3720 board. The initial support includes: - MMC - eMMC - I2C - FEC - Serial console Ying-Chun Liu (PaulLiu) (2): arm: dts: add imx8mp-rsb3720-a1 dts file arm: imx8m: add support for Advantech RSB-3720 v2: update dts

Re: [U-Boot] U-boot build: How to add a static library to the u-boot build

2021-07-19 Thread Daniel D
Hi, I would also like to add OpenSSL library into U-Boot. Can you help me on this? Kind regards, Daniel Selvan D. -- P Please consider the environment before printing this email.

[PATCH v2] serial: pl011: Resend the character if FIFO is full in debug uart

2021-07-19 Thread Chen Baozi
pl01x_putc() might return -EAGAIN if there was no space in FIFO. In that case, high-level caller should wait until there is space and resend the character. Signed-off-by: Chen Baozi Reviewed-by: Stefan Roese --- drivers/serial/serial_pl01x.c | 3 ++- 1 file changed, 2 insertions(+), 1

[Patch V3 43/44] arm: dts: add i.MX8ULP dtsi

2021-07-19 Thread Peng Fan (OSS)
From: Peng Fan Add i.MX8ULP dtsi Signed-off-by: Peng Fan --- arch/arm/dts/imx8ulp-pinfunc.h| 978 ++ arch/arm/dts/imx8ulp.dtsi | 728 include/dt-bindings/clock/imx8ulp-clock.h | 247 ++ 3 files changed, 1953 insertions(+)

Help wanted: Adding OpenSSL in FSL HAB

2021-07-19 Thread Daniel D
Hi, I would like to compile U-Boot with OpenSSL library and I'm using OpenSSL functions in Freescale's " hab.c ". I do not know how to add the ssl & crypto libraries to U-Boot's makefile (as there are many). I'm quite new to these kind of work, hence I request someone to provide some detailed

Re: [BUG] U-Boot makes Linux kernel boot failed with "mmc1: invalid bus width" on RPi 400

2021-07-19 Thread Jian-Hong Pan
Jian-Hong Pan 於 2021年7月7日 週三 下午12:23寫道: > > Hi, > > I tried to boot Linux next kernel at tag 5.13.0-next-20210701 from > latest U-Boot at commit 1311dd37ec ("Merge branch > '2021-07-01-update-CI-containers'") on Raspberry Pi 400. > * U-Boot goes with the bcm2711-rpi-400.dtb from Raspberry Pi OS >

[PATCH] lib: rsa: rsa-verify: Fix a typo in a debug message

2021-07-19 Thread Thomas Perrot
Signed-off-by: Thomas Perrot --- lib/rsa/rsa-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rsa/rsa-verify.c b/lib/rsa/rsa-verify.c index bb8cc61d94b5..3840764e420e 100644 --- a/lib/rsa/rsa-verify.c +++ b/lib/rsa/rsa-verify.c @@ -556,7 +556,7 @@ int

Re: [PATCH u-boot-mvebu v2 19/41] tools: kwbimage: Do not hide usage of secure header under CONFIG_ARMADA_38X

2021-07-19 Thread Stefan Roese
Hi Marek, On 19.07.21 14:50, Marek Behún wrote: Hi Stefan, just noticed that this patch and patch 37 need rebase (some lines are at different offset in tools/Makefile). The fix is pretty simple, but I can send v3, if you want. No need, thanks. I'll try to resolve the merge conflict myself,

Re: [PATCH u-boot-mvebu v2 19/41] tools: kwbimage: Do not hide usage of secure header under CONFIG_ARMADA_38X

2021-07-19 Thread Marek Behún
Hi Stefan, just noticed that this patch and patch 37 need rebase (some lines are at different offset in tools/Makefile). The fix is pretty simple, but I can send v3, if you want. Marek

Please pull u-boot-marvell/master

2021-07-19 Thread Stefan Roese
Hi Tom, please pull the next batch of Marvell MVEBU related patches. Here the summary log: - Marvell SheevaPlug: Convert Ethernet and SATA to Driver Model (Tony) - Zyxel NSA310S NAS: Convert to Driver Model (Tony) - Turris_omnia:

Re: [PATCH 0/3] Marvell SheevaPlug : convert Ethernet and SATA to Driver Model.

2021-07-19 Thread Stefan Roese
On 14.07.21 06:35, Tony Dinh wrote: - Add DM_ETH, SATA_MV and associated configs to sheevaplug_defconfig - Remove IDE, and add SATA configs in board file sheevaplug.h - Replace old device name "egiga0" with Ethernet PHY name from device tree. - Replace the old Ethernet PHY addr lookup with a

Re: [PATCH 0/4] Zyxel NSA310S NAS : convert to Driver Model.

2021-07-19 Thread Stefan Roese
On 01.07.21 06:26, Tony Dinh wrote: - Add device tree kirkwood-nsa310s.dts - Add DM_USB, DM_ETH, DM_SATA and associated configs to nsa310s_defconfig - Move some miscellaneous configs from board file to nsa310s_defconfig - Replace old device name "egiga0" with Ethernet PHY name from device tree

Re: [PATCH] Makefile: Remove DM_VIDEO and DM_SPI_FLASH checks

2021-07-19 Thread Tom Rini
On Sun, Jul 18, 2021 at 09:07:54PM -0400, Tom Rini wrote: > As we have now completed the DM_VIDEO and DM_SPI_FLASH migrations we can > remove the checks. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 5/5] m68k: Remove M52277EVB board

2021-07-19 Thread Tom Rini
On Mon, Jul 12, 2021 at 12:42:14PM -0400, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. As this is also the last in family remove the related > support as well. > > Cc: Angelo Durgehello > Cc: TsiChung Liew > Signed-off-by: Tom Rini

Re: [PATCH 4/5] m68k: Remove M54451EVB board

2021-07-19 Thread Tom Rini
On Mon, Jul 12, 2021 at 12:42:13PM -0400, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. As this is also the last in family remove the related > support as well. > > Cc: Angelo Durgehello > Signed-off-by: Tom Rini Applied to u-boot/master,

Re: [PATCH 3/5] m68k: Remove M54418TWR board

2021-07-19 Thread Tom Rini
On Mon, Jul 12, 2021 at 12:42:12PM -0400, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. > > Cc: Angelo Durgehello > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/5] m68k: Remove M54455EVB board

2021-07-19 Thread Tom Rini
On Mon, Jul 12, 2021 at 12:42:11PM -0400, Tom Rini wrote: > This board has not been converted to CONFIG_DM_MMC by the deadline. > Remove it. > > Cc: Angelo Durgehello > Cc: TsiChung Liew > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 1/5] vinco: Enable DM_USB and DM_SPI_FLASH support

2021-07-19 Thread Tom Rini
On Mon, Jul 12, 2021 at 12:42:10PM -0400, Tom Rini wrote: > As this platform already enables CONFIG_DM and CONFIG_OF_CONTROL, > migrating to DM_USB and DM_SPI_FLASH is just a matter of enabling the > correct options. > > Cc: Gregory CLEMENT > u-boot@lists.denx.de (open list) > Reported-by:

Re: [PATCHv2 3/4] treewide: Test on CONFIG_USB_HOST (or CONFIG_CMD_USB) not CONFIG_USB

2021-07-19 Thread Tom Rini
On Fri, Jul 09, 2021 at 10:11:55AM -0400, Tom Rini wrote: > As the logic here is only used when we have a USB host controller, test > on CONFIG_USB_HOST rather than CONFIG_USB in general. This lets us move > towards using CONFIG_USB only as a menu symbol to say that we have some > form of USB,

Re: [PATCHv2 4/4] usb: Enforce DM_USB migration for USB_HOST devices.

2021-07-19 Thread Tom Rini
On Fri, Jul 09, 2021 at 10:11:56AM -0400, Tom Rini wrote: > As the deadline for migration to DM_USB, when using a USB host > controller has now gone two years past the deadline, enforce migration. > This is done by: > > - Ensuring that all host controller options (other than the very legacy >

Re: [PATCHv2 2/4] tegra: Test on CONFIG_CMD_USB being enabled for distro bootcmd

2021-07-19 Thread Tom Rini
On Fri, Jul 09, 2021 at 10:11:54AM -0400, Tom Rini wrote: > Reuse the common logic to allow for BOOT_TARGET_DEVICES to list USB as a > possibility if we're building for a platform that will have USB but not > if we don't, so that we don't hit the link-time check for trying to have > USB boot on a

Re: [PATCHv2 1/4] ge_bx50v3: Remove unused USB related defines

2021-07-19 Thread Tom Rini
On Fri, Jul 09, 2021 at 10:11:53AM -0400, Tom Rini wrote: > These USB defines do not change the build as there is no USB support > enabled currently. > > Cc: Ian Ray > Cc: Sebastian Reichel > Signed-off-by: Tom Rini > Reviewed-by: Sebastian Reichel Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 27/27] pci: Require DM_PCI

2021-07-19 Thread Tom Rini
On Fri, May 14, 2021 at 09:34:32PM -0400, Tom Rini wrote: > As the migration deadline has passed, require that DM_PCI be used. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH v3 2/2] imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards (N801x)

2021-07-19 Thread Frieder Schrempf
From: Frieder Schrempf The Kontron SoM-Line i.MX8MM (N801x) by Kontron Electronics GmbH is a SoM module with an i.MX8M-Mini SoC, 1/2/4 GB LPDDR4 RAM, SPI NOR, eMMC and PMIC. The matching evaluation boards (Board-Line) have 2 Ethernets, USB 2.0, HDMI/LVDS, SD card, CAN, RS485 and much more.

[PATCH v3 1/2] imx: imx6ul: Add support for Kontron Electronics SL/BL i.MX6UL/ULL boards (N63xx/N64xx)

2021-07-19 Thread Frieder Schrempf
From: Frieder Schrempf This adds support for i.MX6UL/ULL-based evaluation kits with SoMs by Kontron Electronics GmbH. Currently there are the following SoM flavors (SoM-Line): * N6310: SOM with i.MX6UL-2, 256MB RAM, 256MB SPI NAND * N6311: SOM with i.MX6UL-2, 512MB RAM, 512MB SPI NAND *

[PATCH u-boot-mvebu v2 40/41] kwbimage: Add support for extracting images via dumpimage tool

2021-07-19 Thread Marek Behún
From: Pali Rohár The kwbimage library does not support extracting subimages. Implement it. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- tools/kwbimage.c | 72 ++-- 1 file changed, 64 insertions(+), 8 deletions(-) diff --git

[PATCH u-boot-mvebu v2 41/41] kwbimage: Update help message about how to extract from an existing image

2021-07-19 Thread Marek Behún
From: Pali Rohár Extracting is now supported by dumpimage, so mention it in help instead of `kwbimage -x`. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index

[PATCH u-boot-mvebu v2 39/41] arm: mvebu: gdsys: Remove custom spl_board_init()

2021-07-19 Thread Marek Behún
From: Pali Rohár Now it is possible to use BootROM to load and boot main U-Boot binary. It is just required to disable config option CONFIG_SPL_SPI_FLASH_SUPPORT. gdsys a38x config file (controlcenterdc_defconfig) does not have that option enabled so there is no need to provide custom

[PATCH u-boot-mvebu v2 38/41] arm: mvebu: Remove unused macro CONFIG_SYS_U_BOOT_OFFS

2021-07-19 Thread Marek Behún
From: Pali Rohár Macro CONFIG_SYS_U_BOOT_OFFS is set but not used anymore. Remove it. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Chris Packham --- include/configs/clearfog.h| 6 +- include/configs/controlcenterdc.h | 6 -- include/configs/db-88f6720.h

[PATCH u-boot-mvebu v2 37/41] tools: kwbimage: Remove v1 kwbimage SPL padding to CONFIG_SYS_U_BOOT_OFFS bytes

2021-07-19 Thread Marek Behún
From: Pali Rohár This padding depends on board config file and therefore it makes the mkimage binary tool board specific, which is not correct. One cannot use mkimage tool built as a result for board A to generate images for board B, even if both A and B are on the same platform. This

[PATCH u-boot-mvebu v2 36/41] arm: mvebu: Remove legacy U-Boot header from kwbimage v1 files

2021-07-19 Thread Marek Behún
From: Pali Rohár The SPL code now already parses kwbimage v1 headers where all necessary information about how to load and execute main U-Boot is present. The legacy 64-byte U-Boot header is not used anymore. Remove this 64-byte header by putting u-boot.bin binary (instead of u-boot.img) into

[PATCH u-boot-mvebu v2 35/41] arm: mvebu: Load main U-Boot binary in SPL code based on kwbimage header

2021-07-19 Thread Marek Behún
From: Pali Rohár Now that proper load and execution addresses are set in v1 kwbimage we can use it for loading and booting main U-Boot binary. Use the new spl_parse_board_header() function to implement parsing the kwbimage v1 header. Use information from this header to locate offset and size of

[PATCH u-boot-mvebu v2 33/41] SPL: Add support for specifying offset between header and image

2021-07-19 Thread Marek Behún
From: Pali Rohár Some image types (e.g. kwbimage v1) store the offset to SPL binary and offset to main U-Boot binary in their headers. To avoid reading SPL binary when loading main U-Boot, add support for specifying offset in struct spl_image_info, which defines the offset from the beginning of

[PATCH u-boot-mvebu v2 34/41] SPL: Add support for parsing board / BootROM specific image types

2021-07-19 Thread Marek Behún
From: Pali Rohár Platform specific BootROM may use its own image type for loading SPL or main U-Boot binary. In some cases it makes sense to not use BootROM supplied code for booting main U-Boot binary but rather to use U-Boot SPL to load main U-Boot binary, e.g. when U-Boot SPL can load main

[PATCH u-boot-mvebu v2 32/41] arm: mvebu: Use U-Boot's SPL BootROM framework for booting from NAND/UART

2021-07-19 Thread Marek Behún
From: Pali Rohár Current code uses hack in board_init_f() which calls return_to_bootrom() to skip U-Boot SPL code and return back to BootROM to load U-Boot via UART or from NAND. This change migrates that hack from the board_init_f() function and changes it to return BOOT_DEVICE_BOOTROM instead

[PATCH u-boot-mvebu v2 31/41] arm: mvebu: Implement return_to_bootrom() via U-Boot's SPL framework

2021-07-19 Thread Marek Behún
From: Pali Rohár U-Boot's SPL framework already has an API for loading U-Boot via BootROM. Implement the function board_return_to_bootrom() for mvebu SPL code. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham

[PATCH u-boot-mvebu v2 30/41] arm: mvebu: Mark return_to_bootrom() as a noreturn function

2021-07-19 Thread Marek Behún
From: Pali Rohár This function does not return, so add the appropriate compiler flag. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- arch/arm/mach-mvebu/include/mach/cpu.h | 2 +- 1 file changed, 1

[PATCH u-boot-mvebu v2 29/41] arm: mvebu: Fix return_to_bootrom()

2021-07-19 Thread Marek Behún
From: Pali Rohár Register r0 should be set to return value 0x0 - NO_ERR. Set r0 with return value after all registers are restored from the stack, so that the return value is always correct. Signed-off-by: Pali Rohár Fixes: 944c7a317675 ("arm: mvebu: Add option to use UART xmodem protocol via

[PATCH u-boot-mvebu v2 28/41] tools: kwboot: Fix checking image header version

2021-07-19 Thread Marek Behún
From: Pali Rohár Function image_version() returns unsigned value, so it can never be negative. Explicitly check for two supported image versions: v0 and v1. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- tools/kwboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH u-boot-mvebu v2 27/41] tools: kwboot: Check for v1 header size

2021-07-19 Thread Marek Behún
From: Pali Rohár Too small invalid headers may cause kwboot to crash. Check for header size of v1 images. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwboot.c | 5 + 1 file changed, 5

[PATCH u-boot-mvebu v2 26/41] tools: kwboot: Cosmetic fix - add missing curly brackets

2021-07-19 Thread Marek Behún
From: Pali Rohár Add missing curly brackets for this else statement. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH u-boot-mvebu v2 25/41] tools: kwboot: Print trailing newline after terminal is terminated

2021-07-19 Thread Marek Behún
From: Pali Rohár Print trailing newline as the last printed byte can be something different. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwboot.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH u-boot-mvebu v2 24/41] tools: kwboot: Fix restoring terminal

2021-07-19 Thread Marek Behún
From: Pali Rohár Call tcsetattr() only if the file descriptor is valid. It may be invalidated by previous lines (if it is not a tty descriptor). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham ---

[PATCH u-boot-mvebu v2 23/41] tools: kwboot: Fix wrong parameter passed to read()

2021-07-19 Thread Marek Behún
From: Pali Rohár The 'buf' variable is a pointer and '_buf' is the array itself. Therefore we should pass sizeof(_buf) instead of sizeof(buf) to read(). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham ---

[PATCH u-boot-mvebu v2 22/41] tools: dumpimage: Show error message when trying to extract data from kwbimage

2021-07-19 Thread Marek Behún
From: Pali Rohár There is no code for extracting data from kwbimage, so show an error message when user tries this via e.g. dumpimage call: ./tools/dumpimage -T kwbimage -o /tmp/out u-boot-spl.kwb Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- tools/kwbimage.c | 5 + 1 file

[PATCH u-boot-mvebu v2 21/41] tools: dumpimage: Fix crashing when trying to extract data from kwbimage

2021-07-19 Thread Marek Behún
From: Pali Rohár Trying to call the following command causes NULL pointer dereference in strlen(): ./tools/dumpimage -T kwbimage -o /tmp/out u-boot-spl.kwb Fix it by checking whether params->imagename is non-NULL before calling strlen(). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún

[PATCH u-boot-mvebu v2 19/41] tools: kwbimage: Do not hide usage of secure header under CONFIG_ARMADA_38X

2021-07-19 Thread Marek Behún
From: Pali Rohár The mkimage host tool can be used to generate kwbimage v1 image with secure header on host system for A38x plaform also when U-Boot is being compiled for different platform. So there is no reason to not allow compiling of mkimage/kwbimage with secure header support for e.g.

[PATCH u-boot-mvebu v2 20/41] tools: kwbimage: Mark all BootROM structures __packed

2021-07-19 Thread Marek Behún
From: Pali Rohár These structures must have specific size without padding, so mark them as packed via the de-facto standard macro __packed. Also replace PACKED macro. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- tools/kwbimage.h | 30 ++ tools/kwboot.c

[PATCH u-boot-mvebu v2 18/41] tools: kwbimage: Add support for a new DATA_DELAY command

2021-07-19 Thread Marek Behún
From: Pali Rohár This command is supported only by v1 images and specifies a milliseconds delay after executing some set of DATA commands. The special string value SDRAM_SETUP instructs BootROM to setup SDRAM controller instead of executing delay. SDRAM_SETUP may be specified only once and after

[PATCH u-boot-mvebu v2 17/41] tools: kwbimage: Add support for DATA command also for v1 images

2021-07-19 Thread Marek Behún
From: Pali Rohár The DATA command is already supported by mkimage for v0 images, but not for v1 images. BootROM code which executes v1 images also supports DATA command via an optional extended v1 header OPT_HDR_V1_REGISTER_TYPE. Implement support for DATA command for v1 images.

[PATCH u-boot-mvebu v2 16/41] tools: kwbimage: Don't parse PAYLOAD keyword

2021-07-19 Thread Marek Behún
From: Pali Rohár The PAYLOAD keyword does nothing. No code is using it and both mkimage and kwbimage completely ignore it. It looks like a relict from the past. The payload image itself can be specified only via -d parameter to mkimage. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún

[PATCH u-boot-mvebu v2 15/41] tools: kwbimage: Add support for more BINARY headers

2021-07-19 Thread Marek Behún
From: Pali Rohár The kwbimage v1 format supports multiple BINARY executable headers. Add support for it into mkimage/kwbimage tool. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwbimage.c | 59

[PATCH u-boot-mvebu v2 14/41] tools: kwbimage: Fix calculating size of binary header

2021-07-19 Thread Marek Behún
From: Pali Rohár Binary header consist of: * 1 byte for header type * 3 bytes for header size * 1 byte for number of arguments * 3 reserved bytes * N*4 bytes for arguments * M bytes (aligned to 4 bytes) for executable data * 1 byte for information about next header * 3 reserved bytes The first

[PATCH u-boot-mvebu v2 13/41] tools: kwbimage: Change maximum number of arguments in binary header to 256

2021-07-19 Thread Marek Behún
From: Pali Rohár The number is stored in one byte, so the maximum should be 255. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index 76c25628d4..2d4574af7d 100644

[PATCH u-boot-mvebu v2 12/41] tools: kwbimage: Use -a parameter (load address) for v1 images

2021-07-19 Thread Marek Behún
From: Pali Rohár The data part of v1 kwbimage currently contains U-Boot binary prepended by 64 bytes long Legacy U-Boot image header. This means that the load address is currently substracted by 64 bytes to ensure that U-Boot's entry point is at specified execution address. As mkimage has

[PATCH u-boot-mvebu v2 10/41] tools: kwbimage: Print size of binary header in kwbimage_print_header()

2021-07-19 Thread Marek Behún
From: Pali Rohár The binary header in kwbimage contains executable SPL code. Print information about this binary header and not only information about it's data part. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris

[PATCH u-boot-mvebu v2 11/41] tools: kwbimage: Cosmetic fix - remove redundant space character

2021-07-19 Thread Marek Behún
Remove this space, since the constants are indented by tabs. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwbimage.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.h b/tools/kwbimage.h

[PATCH u-boot-mvebu v2 07/41] tools: kwbimage: Fix check for v0 extended header checksum

2021-07-19 Thread Marek Behún
From: Pali Rohár Extended header checksum for v0 image is present only in the case when extended header is present. Skip checksum validation if extended header is not present. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by:

  1   2   >