Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops"

2021-07-23 Thread Dennis Gilmore
On Fri, Jul 23, 2021 at 10:25 PM Tom Rini wrote: > > On Fri, Jul 23, 2021 at 09:46:44PM -0500, Dennis Gilmore wrote: > > > removing the header is not sufficient to have the boards booting from SPI. > > > > U-Boot TPL 2021.07-00768-g49373a3334-dirty (Jul 23 2021 - 20:42:57) > > Channel 0: LPDDR4,

Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops"

2021-07-23 Thread Tom Rini
On Fri, Jul 23, 2021 at 09:46:44PM -0500, Dennis Gilmore wrote: > removing the header is not sufficient to have the boards booting from SPI. > > U-Boot TPL 2021.07-00768-g49373a3334-dirty (Jul 23 2021 - 20:42:57) > Channel 0: LPDDR4, 50MHz > BW=32 Col=10 Bk=8 CS0 Row=16/15 CS=1 Die BW=16

Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops"

2021-07-23 Thread Dennis Gilmore
removing the header is not sufficient to have the boards booting from SPI. U-Boot TPL 2021.07-00768-g49373a3334-dirty (Jul 23 2021 - 20:42:57) Channel 0: LPDDR4, 50MHz BW=32 Col=10 Bk=8 CS0 Row=16/15 CS=1 Die BW=16 Size=2048MB Channel 1: LPDDR4, 50MHz BW=32 Col=10 Bk=8 CS0 Row=16/15 CS=1 Die

Re: Help with TI-U-BOOT

2021-07-23 Thread Nishanth Menon
On 14:17-20210723, Antoine Naud wrote: > Here is the full list of my commands: > > $ sudo apt-get update > $ sudo apt-get install git-core > $ sudo apt-get install build-essential autoconf automake bison flex > libssl-dev bc u-boot-tools python diffstat texinfo gawk chr

[PATCH] mkimage: use environment variable MKIMAGE_SIGN_PIN to set pin for OpenSSL Engine

2021-07-23 Thread Marc Kleine-Budde
This patch adds the possibility to pass the PIN the OpenSSL Engine used during signing via the environment variable MKIMAGE_SIGN_PIN. This follows the approach used during kernel module signing ("KBUILD_SIGN_PIN") or UBIFS image signing ("MKIMAGE_SIGN_PIN"). Signed-off-by: Marc Kleine-Budde ---

RE: Help with TI-U-BOOT

2021-07-23 Thread Antoine Naud
Here is the full list of my commands: $ sudo apt-get update $ sudo apt-get install git-core $ sudo apt-get install build-essential autoconf automake bison flex libssl-dev bc u-boot-tools python diffstat texinfo gawk chrpath dos2unix wget unzip socat doxygen libc6:i386 libncurses5:i386

[PATCH] board: fsl_validate: Fix resource leak issue

2021-07-23 Thread Kshitiz Varshney
Free dynamically allocated memory before every return statement in calc_esbchdr_esbc_hash() function. Verified the secure boot changes using ls1046afrwy board. Signed-off-by: Kshitiz Varshney --- board/freescale/common/fsl_validate.c | 25 ++--- 1 file changed, 18

[PATCH] board: fsl_validate: Fix resource leak issue

2021-07-23 Thread Kshitiz Varshney
Free dynamically allocated memory before every return statement in calc_img_key_hash() function. Verified the secure boot changes using ls1046afrwy board. Signed-off-by: Kshitiz Varshney --- board/freescale/common/fsl_validate.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

SAMA5D27 - UTMI issue?

2021-07-23 Thread Tim
Hi, I have a custom board using the SAMA5D27 and basically have u-boot running now. The only issue I have is that because it uses a 24MHz crystal (like the SOM EV board) the UTMICKTRIM register needs to be set correctly (not just for USB - the CAN system runs best from the 480MHz UPLL clock). I

Re: using binman fails boot

2021-07-23 Thread Tim Harvey
On Fri, Jul 23, 2021 at 2:41 PM Simon Glass wrote: > > Hi Tim, > > On Fri, 23 Jul 2021 at 15:06, Tim Harvey wrote: > > > > On Thu, Jul 22, 2021 at 8:07 PM Simon Glass wrote: > > > > > > Hi Tim, > > > > > > On Mon, 19 Jul 2021 at 17:23, Tim Harvey wrote: > > > > > > > > On Sat, Jul 17, 2021 at

Re: using binman fails boot

2021-07-23 Thread Simon Glass
Hi Tim, On Fri, 23 Jul 2021 at 15:06, Tim Harvey wrote: > > On Thu, Jul 22, 2021 at 8:07 PM Simon Glass wrote: > > > > Hi Tim, > > > > On Mon, 19 Jul 2021 at 17:23, Tim Harvey wrote: > > > > > > On Sat, Jul 17, 2021 at 7:22 PM Simon Glass wrote: > > > > > > > > [..] > > > > > > > But isn't

Re: [PATCH v3 2/6] cmd: printf: import busybox-1.33.1 printf.c

2021-07-23 Thread Simon Glass
Hi Roland, On Fri, 23 Jul 2021 at 06:30, Roland Gaudig wrote: > > From: Roland Gaudig > > Import printf.c from the Busybox project, which provides Bash like > format string handling. > > src-url: https://git.busybox.net/busybox/ > commit bcc5b0e6caca6c7602a6a41f "Bump version to 1.33.1" >

Re: [PATCH 00/15] lib: Add support for a decimal 0m prefix for numbers

2021-07-23 Thread Simon Glass
Hi, On Wed, 21 Jul 2021 at 08:46, Simon Glass wrote: > > Hi Wolfgang, > > On Wed, 21 Jul 2021 at 01:53, Wolfgang Denk wrote: > > > > Hi, > > > > In message <20210720160547.GM9379@bill-the-cat> you wrote: > > > > > > > So for example (10)123 would mean decimal 123? I don't know how we > > > >

Re: [PATCH v3 6/6] test: cmd: setexpr: add format string tests

2021-07-23 Thread Simon Glass
Hi Roland, On Fri, 23 Jul 2021 at 06:30, Roland Gaudig wrote: > > From: Roland Gaudig > > Add test cases for the setexpr format string operator. > > Signed-off-by: Roland Gaudig > --- > > (no changes since v1) > > test/cmd/setexpr.c | 84 ++ > 1

Re: [PATCH v3 5/6] doc: usage: add description for setexpr command

2021-07-23 Thread Simon Glass
Hi Roland, On Fri, 23 Jul 2021 at 06:30, Roland Gaudig wrote: > > From: Roland Gaudig > > Add usage for the setexpr command. It has been added to describe > mainly the new setexpr format string operation. > > Signed-off-by: Roland Gaudig > --- > > (no changes since v1) > > MAINTAINERS

Re: [PATCH v3 4/6] cmd: setexpr: add format string handling

2021-07-23 Thread Simon Glass
Hi Roland, On Fri, 23 Jul 2021 at 06:30, Roland Gaudig wrote: > > From: Roland Gaudig > > Add format string handling operator to the setexpr command. > It allows to use C or Bash like format string expressions to be > evaluated with the result being stored inside the environment variable >

Re: [PATCH v3 1/6] lib: strto: add simple_strtoll function

2021-07-23 Thread Simon Glass
On Fri, 23 Jul 2021 at 06:29, Roland Gaudig wrote: > > From: Roland Gaudig > > Add simple_strtoll function for converting a string containing digits > into a long long int value. > > Signed-off-by: Roland Gaudig > --- > > (no changes since v1) > > include/vsprintf.h | 1 + > lib/strto.c

Re: [PATCH 13/15] RFC: lib: Support a binary prefix 0y

2021-07-23 Thread Simon Glass
Hi Wolfgang, On Fri, 23 Jul 2021 at 00:55, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > Drop? AFAICT we never supported octal. Something like "md 040" will > > > start dumping at 0x0040, right? > > > > There are quite a few places where simple_strtoul() is

Re: using binman fails boot

2021-07-23 Thread Tim Harvey
On Thu, Jul 22, 2021 at 8:07 PM Simon Glass wrote: > > Hi Tim, > > On Mon, 19 Jul 2021 at 17:23, Tim Harvey wrote: > > > > On Sat, Jul 17, 2021 at 7:22 PM Simon Glass wrote: > > > > > [..] > > > > > But isn't blob-ext@4 a correct name? I can't use 'blob-ext-4' as > > > > that's an unknown entry

Re: Help with TI-U-BOOT

2021-07-23 Thread Ramon Fried
On Fri, Jul 23, 2021 at 5:17 PM Antoine Naud wrote: > > Here is the full list of my commands: > > $ sudo apt-get update > $ sudo apt-get install git-core > $ sudo apt-get install build-essential autoconf automake bison flex > libssl-dev bc u-boot-tools python diffstat texinfo gawk chrpath

Re: [PATCH v5 8/8] test: add first autoboot unit tests

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:40PM +0200, Steffen Jaeckel wrote: > This adds tests for the crypt-based and plain SHA256-based password hashing > algorithms in the autoboot flow. > > Signed-off-by: Steffen Jaeckel > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v5 7/8] common: add support to fallback to plain SHA256

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:39PM +0200, Steffen Jaeckel wrote: > In case crypt-based hashing is enabled this will be the default mechanism > that is used. If a user wants to have support for both, the environment > variable `bootstopusesha256` can be set to `true` to allow plain SHA256 > based

Re: [PATCH v5 6/8] common: add AUTOBOOT_FLUSH_STDIN option

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:38PM +0200, Steffen Jaeckel wrote: > The key-sequence based unlock mechanisms are sensitive to junk symbols > that could have been sent to stdin and are still waiting to be retrieved. > Enabling this option will read all symbols off stdin before displaying the >

Re: [PATCH v5 5/8] common: allow disabling of timeout for password entry

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:37PM +0200, Steffen Jaeckel wrote: > In case a user has to enter a complicated password it is sometimes > desireable to give the user more time than the default timeout. > Enabling this feature will disable the timeout entirely in case the user > presses the key

Re: [PATCH v5 4/8] common: Rename macro appropriately

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:36PM +0200, Steffen Jaeckel wrote: > While doing code-review internally this got nitpicked by 2 reviewers, so > I decided to include this here. > > Signed-off-by: Steffen Jaeckel > Reviewed-by: Simon Glass > Reviewed-by: Heiko Schocher Applied to u-boot/master,

Re: [PATCH v5 2/8] lib: wrap crypt API to hide errno usage

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:34PM +0200, Steffen Jaeckel wrote: > In order to prevent using the global errno, replace it with a static > version and create a wrapper function which returns the error value. > > Signed-off-by: Steffen Jaeckel > Reviewed-by: Simon Glass > Reviewed-by: Heiko

Re: [PATCH v5 3/8] common: integrate crypt-based passwords

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:35PM +0200, Steffen Jaeckel wrote: > Hook into the autoboot flow as an alternative to the existing > mechanisms. > > Signed-off-by: Steffen Jaeckel > Reviewed-by: Simon Glass > Reviewed-by: Heiko Schocher Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v5 1/8] lib: add crypt subsystem

2021-07-23 Thread Tom Rini
On Thu, Jul 08, 2021 at 03:57:33PM +0200, Steffen Jaeckel wrote: > Add the basic functionality required to support the standard crypt > format. > The files crypt-sha256.c and crypt-sha512.c originate from libxcrypt and > their formatting is therefor retained. > The integration is done via a

Re: [PATCH v4 3/3] reboot-mode: read the boot mode from RTC memory

2021-07-23 Thread Tom Rini
On Thu, Jun 10, 2021 at 04:56:45PM +0300, Nandor Han wrote: > RTC devices could provide battery-backed memory that can be used for > storing the reboot mode magic value. > > Add a new reboot-mode back-end that uses RTC to store the reboot-mode > magic value. The driver also supports both

Re: [PATCH v4 2/3] reboot-mode: read the boot mode from GPIOs status

2021-07-23 Thread Tom Rini
On Thu, Jun 10, 2021 at 04:56:44PM +0300, Nandor Han wrote: > A use case for controlling the boot mode is when the user wants > to control the device boot by pushing a button without needing to > go in user-space. > > Add a new backed for reboot mode where GPIOs are used to control the >

Re: [PATCH v4 1/3] reboot-mode: add support for reboot mode control

2021-07-23 Thread Tom Rini
On Thu, Jun 10, 2021 at 04:56:43PM +0300, Nandor Han wrote: > A new driver uclass is created to handle the reboot mode control. > > The new uclass driver is updating an environment variable with the > configured reboot mode. The mode is extracted from a map provided > at initialization time. The

[PATCH u-boot-mvebu] arm64: a37xx: pinctrl: Correct PWM pins definitions

2021-07-23 Thread Marek Behún
The PWM pins on North Bridge on Armada 37xx can be configured into PWM or GPIO functions. When in PWM function, each pin can also be configured to drive low on 0 and tri-state on 1 (LED mode). The current definitions handle this by declaring two pin groups for each pin: - group "pwmN" with

[PATCH] qemu-riscv64_smode: fix extlinux (define preboot)

2021-07-23 Thread Dimitri John Ledkov
Commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to Kconfig") removed preboot commands in RISC-V targets and broke extlinux support as reported by Fu Wei . The patch finishes migration of CONFIG_USE_PREBOOT and CONFIG_REBOOT to Kconfig. Signed-off-by: David Abdurachmanov

Re: Help with TI-U-BOOT

2021-07-23 Thread Ramon Fried
On Fri, Jul 23, 2021 at 3:31 PM Antoine Naud wrote: > > Okay ! Thanks for answering, > > Here is the error I got when trying to compile using the command (make > CROSS_COMPILE=arm-none-linux-gnueabihf- O=CSCM_build CSCM_defconfig all): > > In file included from ../include/dm/of.h:11, >

Re: [PATCH] test/py: Improve check for mksquashfs version

2021-07-23 Thread João Marcos Costa
Em qui., 22 de jul. de 2021 às 17:52, Marek Behún escreveu: > > Some builds of squashfs-tools append version string with "-git" or > similar. The float() conversion will fail in this case. > > Improve the code to only convert to float() the string before the '-' > character. > > Signed-off-by:

RE: Help with TI-U-BOOT

2021-07-23 Thread Antoine Naud
Okay ! Thanks for answering, Here is the error I got when trying to compile using the command (make CROSS_COMPILE=arm-none-linux-gnueabihf- O=CSCM_build CSCM_defconfig all): In file included from ../include/dm/of.h:11, from ../include/dm/ofnode.h:12, from

Re: [PATCH] net: remove CONFIG_NET_MULTI (again)

2021-07-23 Thread Tom Rini
On Wed, Jul 14, 2021 at 09:12:41AM +0200, Michal Simek wrote: > CONFIG_NET_MULTI has been removed long time ago by commit 795428fc679f > ("net: remove CONFIG_NET_MULTI") but 4 boards were added later which wasn't > found. The patch is removing this reference from 4 boards. > > Signed-off-by:

Re: [PATCH] mux: correct prototype for mux_control_try_select()

2021-07-23 Thread Tom Rini
On Tue, Jul 13, 2021 at 11:02:18PM +0200, Patrick Wildt wrote: > The macro should be passed a state, which should be passed > to the actual function. Otherwise using that macro would > yield a build error. > > Signed-off-by: Patrick Wildt > Reviewed-by: Pratyush Yadav Applied to

Re: [PATCH] arm: vexpress64: juno: Enable distro_bootcmd functionality

2021-07-23 Thread Tom Rini
On Mon, Jul 12, 2021 at 12:25:15AM +0100, Andre Przywara wrote: > The ARM Juno boards can be used as somewhat decent machines to run > off-the-shelf distributions, with USB, SATA, GBit Ethernet and 8GB of > DRAM. > > With stable DTs in the board's NOR flash this would work really nicely, >

Re: [PATCH] distro_boot: Fix block device after DHCP boot sequence

2021-07-23 Thread Tom Rini
On Mon, Jul 12, 2021 at 12:07:09AM +0100, Andre Przywara wrote: > The generic distro boot sequence iterates over several types of devices, > trying one after another. In doing do, it starts with setting the > "devtype" variable, then uses this later in more generic commands. > > Now most (block)

Re: [PATCH] Kconfig.boot: Make 0x0 the default SYS_TEXT_BASE for POSITION_INDEPENDENT

2021-07-23 Thread Tom Rini
On Fri, Jul 09, 2021 at 10:39:21AM -0400, Tom Rini wrote: > When we build U-Boot with POSITION_INDEPENDENT we must have > SYS_TEXT_BASE be set to zero. Make this the default in that case. > > Signed-off-by: Tom Rini > Reviewed-by: Mark Kettenis Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] fit: Allow external data for FDTs

2021-07-23 Thread Tom Rini
On Fri, Jun 25, 2021 at 05:58:04PM +0100, John Keeping wrote: > Switch to fit_image_get_data_and_size() for consistency with all other > data loaded from FIT. > > Signed-off-by: John Keeping > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH] cmd: part: Correct error handling

2021-07-23 Thread Tom Rini
On Tue, Jun 22, 2021 at 10:40:01AM +0100, Anders Dellien wrote: > As 'part_get_info_by_name' now returns more status codes than just > -1 to indicate failure, we need to update the return value check. > > Signed-off-by: Anders Dellien > Reviewed-by: Sean Anderson Applied to u-boot/master,

Re: [PATCH 2/2] i2c: pcf8575: Add support for 8 bit I2C IO expanders (like pca8574)

2021-07-23 Thread Tom Rini
On Mon, Jun 07, 2021 at 02:26:34PM +0200, Lukasz Majewski wrote: > This patch add support for using NXP's pca8574 I2C IO expander, which > has only 8 IO lines. > > After this change the .data member's information from struct udevice_id > are used to either sent one or two bytes. > > Moreover,

Re: [PATCH 1/2] i2c: pcf8575: Remove not used members of pcf8575_chip structure

2021-07-23 Thread Tom Rini
On Mon, Jun 07, 2021 at 02:26:33PM +0200, Lukasz Majewski wrote: > Those members are not used anymore as ones from gpio_dev_priv > structure (when DM_GPIO support is enabled) are used instead. > > Signed-off-by: Lukasz Majewski > Reviewed-by: Heiko Schocher Applied to u-boot/master, thanks!

Re: [PATCH] spl: fit: Also record architecture in /fit-images

2021-07-23 Thread Tom Rini
On Mon, May 31, 2021 at 10:57:07AM +0200, Michal Simek wrote: > On ARM64 secure OS can run as 64bit or 32bit that's why it is necessary to > record information about architecture that other code can read it and > properly pass it to TF-A and start in 64bit or 32bit mode. > > Signed-off-by:

Re: [PATCH v3 2/2] cmd: pinmux: support pin name in status command

2021-07-23 Thread Tom Rini
On Fri, May 21, 2021 at 09:47:32AM +0200, Patrick Delaunay wrote: > Allow pin name parameter for pimux staus command, > as gpio command to get status of one pin. > > The possible usage of the command is: > > > pinmux dev pinctrl > > pinmux status > > > pinmux status -a > > > pinmux status >

Re: [PATCH v3 1/2] cmd: pinmux: update result of do_status

2021-07-23 Thread Tom Rini
On Fri, May 21, 2021 at 09:47:31AM +0200, Patrick Delaunay wrote: > Update the result of do_status and always returns a CMD_RET_ value > (-ENOSYS was a possible result of show_pinmux). > > This patch also adds pincontrol name in error messages (dev->name) > and treats correctly the status sub

Re: [PATCH v2] tee: optee: sync cache on pre-reloc OP-TEE invocation

2021-07-23 Thread Tom Rini
On Wed, May 19, 2021 at 04:27:41PM +0200, Etienne Carriere wrote: > This change ensures both U-Boot and OP-TEE see the same content > from shared memory when OP-TEE is invoked prior U-Boot relocation. > > This change is required since U-Boot may execute with data cache off > while OP-TEE always

Re: [PATCH] spl: use CONFIG_IS_ENABLED(LOAD_FIT_FULL)

2021-07-23 Thread Tom Rini
On Wed, May 19, 2021 at 03:05:53PM +0100, John Keeping wrote: > It's possible that LOAD_FIT_FULL will have different values for TPL and > SPL, in which case just checking CONFIG_SPL_LOAD_FIT_FULL causes this to > be compiled in to the TPL even though functions and struct members it > depends on

[PATCH v3 6/6] test: cmd: setexpr: add format string tests

2021-07-23 Thread Roland Gaudig
From: Roland Gaudig Add test cases for the setexpr format string operator. Signed-off-by: Roland Gaudig --- (no changes since v1) test/cmd/setexpr.c | 84 ++ 1 file changed, 84 insertions(+) diff --git a/test/cmd/setexpr.c b/test/cmd/setexpr.c

[PATCH v3 5/6] doc: usage: add description for setexpr command

2021-07-23 Thread Roland Gaudig
From: Roland Gaudig Add usage for the setexpr command. It has been added to describe mainly the new setexpr format string operation. Signed-off-by: Roland Gaudig --- (no changes since v1) MAINTAINERS | 1 + doc/usage/index.rst | 1 + doc/usage/setexpr.rst | 148

[PATCH v3 4/6] cmd: setexpr: add format string handling

2021-07-23 Thread Roland Gaudig
From: Roland Gaudig Add format string handling operator to the setexpr command. It allows to use C or Bash like format string expressions to be evaluated with the result being stored inside the environment variable name. setexpr fmt [value]... The following example setexpr foo fmt "%d,

[PATCH v3 3/6] cmd: printf: add helper functions from busybox

2021-07-23 Thread Roland Gaudig
From: Roland Gaudig Import the following helper functions from Busybox-1.33.1 which are required by printf.c: process_escape_sequence from libbb/process_escape_sequence.c, skip_whitespace from libbb/skip_whitespace.c, overlapping_strcpy from libbb/safe_strncpy.c src-url:

[PATCH v3 2/6] cmd: printf: import busybox-1.33.1 printf.c

2021-07-23 Thread Roland Gaudig
From: Roland Gaudig Import printf.c from the Busybox project, which provides Bash like format string handling. src-url: https://git.busybox.net/busybox/ commit bcc5b0e6caca6c7602a6a41f "Bump version to 1.33.1" version: 1.33.1 Signed-off-by: Roland Gaudig --- (no changes since v1)

[PATCH v3 1/6] lib: strto: add simple_strtoll function

2021-07-23 Thread Roland Gaudig
From: Roland Gaudig Add simple_strtoll function for converting a string containing digits into a long long int value. Signed-off-by: Roland Gaudig --- (no changes since v1) include/vsprintf.h | 1 + lib/strto.c| 8 2 files changed, 9 insertions(+) diff --git

[PATCH v3 0/6] cmd: setexpr: add fmt format string operation

2021-07-23 Thread Roland Gaudig
From: Roland Gaudig In contrast to version 2, the "fmt" operator has been made more flexible like its Bash counterpart, as some comments to version 2 requested. For license compatibility reasons the code for parsing the format string has been taken from the BusyBox project and not from Bash.

[PATCH] test/py: tpm2: Skip tpm pytest based on env variable

2021-07-23 Thread Ashok Reddy Soma
From: T Karthik Reddy Tpm test cases relies on tpm device setup. Provide an environment variable "env__tpm_device_test_skip = True" to skip the test case if tpm device is not present. Only needed will have to add variable to the py-test framework. Test runs successfully even this variable is

Re: Please pull u-boot-net

2021-07-23 Thread Tom Rini
On Thu, Jul 22, 2021 at 11:12:52PM +0300, Ramon Fried wrote: > Hi Tom, > > Please pull the latest patches in u-boot-net tree. > > The following changes since commit 806734f41b25931798fdf667b5a2ae830229c13f: > > Merge https://gitlab.denx.de/u-boot/custodians/u-boot-fsl-qoriq > (2021-07-22

Re: [PATCH V1] arm: add initial support for the Phytium Pomelo Board

2021-07-23 Thread Andre Przywara
On Mon, 19 Jul 2021 17:46:41 +0800 nicholas_zh...@outlook.com wrote: Hi, as Peter already mentioned, this should be [PATCH v2], the next version [PATCH v3], and so on. And please don't resend the same email (and they are identical, I diffed them) without any comments as to why. If you want to

RPI 4 U-Boot 2021.01 Yocto fails with Card did not respond to voltage select! : -110

2021-07-23 Thread Kaiwan N Billimoria
Hi all, Env am using: Yocto 3.3.1 hardknott meta-raspberrypi bsp layer U-Boot 2021.01 (it pulls this in) The boot on an RPi 4B consistently fails with: U-Boot 2021.01 (Jan 11 2021 - 18:11:43 +) DRAM: 1.9 GiB RPI 4 Model B (0xb03114) MMC: mmcnr@7e30: 1, emmc2@7e34: 0 Loading

Re: [PATCH v4 2/2] imx: imx8mm: Add support for Kontron Electronics SL/BL i.MX8M-Mini boards (N801x)

2021-07-23 Thread Michael Walle
Hi Frieder, Am 2021-07-21 10:03, schrieb Frieder Schrempf: From: Frieder Schrempf The Kontron SoM-Line i.MX8MM (N801x) by Kontron Electronics GmbH is a SoM module with an i.MX8M-Mini SoC, 1/2/4 GB LPDDR4 RAM, SPI NOR, eMMC and PMIC. The matching evaluation boards (Board-Line) have 2

Re: [PATCH v4 1/2] imx: imx6ul: Add support for Kontron Electronics SL/BL i.MX6UL/ULL boards (N63xx/N64xx)

2021-07-23 Thread Michael Walle
Am 2021-07-21 10:03, schrieb Frieder Schrempf: From: Frieder Schrempf This adds support for i.MX6UL/ULL-based evaluation kits with SoMs by Kontron Electronics GmbH. Currently there are the following SoM flavors (SoM-Line): * N6310: SOM with i.MX6UL-2, 256MB RAM, 256MB SPI NAND * N6311:

[PATCH u-boot-mvebu v3 23/41] tools: kwboot: Fix wrong parameter passed to read()

2021-07-23 Thread Marek Behún
From: Pali Rohár The 'buf' variable is a pointer and '_buf' is the array itself. Therefore we should pass sizeof(_buf) instead of sizeof(buf) to read(). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham ---

[PATCH u-boot-mvebu v3 34/41] SPL: Add support for parsing board / BootROM specific image types

2021-07-23 Thread Marek Behún
From: Pali Rohár Platform specific BootROM may use its own image type for loading SPL or U-Boot proper. In some cases it makes sense to not use BootROM supplied code for booting U-Boot proper but rather to use U-Boot SPL for this, e.g. when U-Boot SPL can load U-Boot proper faster than BootROM.

[PATCH u-boot-mvebu v3 25/41] tools: kwboot: Print trailing newline after terminal is terminated

2021-07-23 Thread Marek Behún
From: Pali Rohár Print trailing newline as the last printed byte can be something different. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwboot.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH u-boot-mvebu v3 15/41] tools: kwbimage: Add support for more BINARY headers

2021-07-23 Thread Marek Behún
From: Pali Rohár The kwbimage v1 format supports multiple BINARY executable headers. Add support for it into mkimage/kwbimage tool. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Chris Packham Reviewed-by: Stefan Roese Tested-by: Chris Packham --- tools/kwbimage.c | 59

[PATCH u-boot-mvebu v3 31/41] arm: mvebu: Implement return_to_bootrom() via U-Boot's SPL framework

2021-07-23 Thread Marek Behún
From: Pali Rohár U-Boot's SPL framework already has an API for loading U-Boot via BootROM. Implement the function board_return_to_bootrom() for mvebu SPL code. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham

[PATCH u-boot-mvebu v3 28/41] tools: kwboot: Fix checking image header version

2021-07-23 Thread Marek Behún
From: Pali Rohár Function image_version() returns unsigned value, so it can never be negative. Explicitly check for two supported image versions: v0 and v1. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese --- tools/kwboot.c | 2 +- 1 file changed, 1

[PATCH u-boot-mvebu v3 32/41] arm: mvebu: Use U-Boot's SPL BootROM framework for booting from NAND/UART

2021-07-23 Thread Marek Behún
From: Pali Rohár Current code uses hack in board_init_f() which calls return_to_bootrom() to skip U-Boot SPL code and return back to BootROM to load U-Boot via UART or from NAND. This change migrates that hack from the board_init_f() function and changes it to return BOOT_DEVICE_BOOTROM instead

[PATCH u-boot-mvebu v3 17/41] tools: kwbimage: Add support for DATA command also for v1 images

2021-07-23 Thread Marek Behún
From: Pali Rohár The DATA command is already supported by mkimage for v0 images, but not for v1 images. BootROM code which executes v1 images also supports DATA command via an optional extended v1 header OPT_HDR_V1_REGISTER_TYPE. Implement support for DATA command for v1 images.

[PATCH u-boot-mvebu v3 22/41] tools: dumpimage: Show error message when trying to extract data from kwbimage

2021-07-23 Thread Marek Behún
From: Pali Rohár There is no code for extracting data from kwbimage, so show an error message when user tries this via e.g. dumpimage call: ./tools/dumpimage -T kwbimage -o /tmp/out u-boot-spl.kwb Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese ---

[PATCH u-boot-mvebu v3 19/41] tools: kwbimage: Do not hide usage of secure header under CONFIG_ARMADA_38X

2021-07-23 Thread Marek Behún
From: Pali Rohár The mkimage host tool can be used to generate kwbimage v1 image with secure header on host system for A38x plaform also when U-Boot is being compiled for different platform. So there is no reason to not allow compiling of mkimage/kwbimage with secure header support for e.g.

[PATCH u-boot-mvebu v3 21/41] tools: dumpimage: Fix crashing when trying to extract data from kwbimage

2021-07-23 Thread Marek Behún
From: Pali Rohár Trying to call the following command causes NULL pointer dereference in strlen(): ./tools/dumpimage -T kwbimage -o /tmp/out u-boot-spl.kwb Fix it by checking whether params->imagename is non-NULL before calling strlen(). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún

[PATCH u-boot-mvebu v3 16/41] tools: kwbimage: Don't parse PAYLOAD keyword

2021-07-23 Thread Marek Behún
From: Pali Rohár The PAYLOAD keyword does nothing. No code is using it and both mkimage and kwbimage completely ignore it. It looks like a relict from the past. The payload image itself can be specified only via -d parameter to mkimage. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún

[PATCH u-boot-mvebu v3 29/41] arm: mvebu: Fix return_to_bootrom()

2021-07-23 Thread Marek Behún
From: Pali Rohár Register r0 should be set to return value 0x0 - NO_ERR. Set r0 with return value after all registers are restored from the stack, so that the return value is always correct. Signed-off-by: Pali Rohár Fixes: 944c7a317675 ("arm: mvebu: Add option to use UART xmodem protocol via

[PATCH u-boot-mvebu v3 18/41] tools: kwbimage: Add support for a new DATA_DELAY command

2021-07-23 Thread Marek Behún
From: Pali Rohár This command is supported only by v1 images and specifies a milliseconds delay after executing some set of DATA commands. The special string value SDRAM_SETUP instructs BootROM to setup SDRAM controller instead of executing delay. SDRAM_SETUP may be specified only once and after

[PATCH u-boot-mvebu v3 24/41] tools: kwboot: Fix restoring terminal

2021-07-23 Thread Marek Behún
From: Pali Rohár Call tcsetattr() only if the file descriptor is valid. It may be invalidated by previous lines (if it is not a tty descriptor). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham ---

[PATCH u-boot-mvebu v3 27/41] tools: kwboot: Check for v1 header size

2021-07-23 Thread Marek Behún
From: Pali Rohár Too small invalid headers may cause kwboot to crash. Check for header size of v1 images. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwboot.c | 5 + 1 file changed, 5

[PATCH u-boot-mvebu v3 30/41] arm: mvebu: Mark return_to_bootrom() as a noreturn function

2021-07-23 Thread Marek Behún
From: Pali Rohár This function does not return, so add the appropriate compiler flag. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- arch/arm/mach-mvebu/include/mach/cpu.h | 2 +- 1 file changed, 1

[PATCH u-boot-mvebu v3 26/41] tools: kwboot: Cosmetic fix - add missing curly brackets

2021-07-23 Thread Marek Behún
From: Pali Rohár Add missing curly brackets for this else statement. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH u-boot-mvebu v3 41/41] kwbimage: Update help message about how to extract from an existing image

2021-07-23 Thread Marek Behún
From: Pali Rohár Extracting is now supported by dumpimage, so mention it in help instead of `kwbimage -x`. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.c

[PATCH u-boot-mvebu v3 40/41] kwbimage: Add support for extracting images via dumpimage tool

2021-07-23 Thread Marek Behún
From: Pali Rohár The kwbimage library does not support extracting subimages. Implement it. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese --- tools/kwbimage.c | 72 ++-- 1 file changed, 64 insertions(+), 8

[PATCH u-boot-mvebu v3 38/41] arm: mvebu: Remove unused macro CONFIG_SYS_U_BOOT_OFFS

2021-07-23 Thread Marek Behún
From: Pali Rohár Macro CONFIG_SYS_U_BOOT_OFFS is set but not used anymore. Remove it. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Chris Packham Reviewed-by: Stefan Roese --- include/configs/clearfog.h| 6 +- include/configs/controlcenterdc.h | 6 --

[PATCH u-boot-mvebu v3 39/41] arm: mvebu: gdsys: Remove custom spl_board_init()

2021-07-23 Thread Marek Behún
From: Pali Rohár The gdsys a38x config file (controlcenterdc_defconfig) uses BootROM to load U-Boot proper. Since it is now possible to do this via U-Boot SPL framework, we do not need to provide custom spl_board_init() which calls return_to_bootrom(). Signed-off-by: Pali Rohár Reviewed-by:

[PATCH u-boot-mvebu v3 37/41] tools: kwbimage: Remove v1 kwbimage SPL padding to CONFIG_SYS_U_BOOT_OFFS bytes

2021-07-23 Thread Marek Behún
From: Pali Rohár This padding depends on board config file and therefore it makes the mkimage binary tool board specific, which is not correct. One cannot use mkimage tool built as a result for board A to generate images for board B, even if both A and B are on the same platform. This

[PATCH u-boot-mvebu v3 33/41] SPL: Add support for specifying offset between header and image

2021-07-23 Thread Marek Behún
From: Pali Rohár Some image types (e.g. kwbimage v1) store the offset to SPL binary and offset to U-Boot proper binary in their headers. To avoid reading SPL binary when loading U-Boot proper, add support for specifying offset in struct spl_image_info, which defines the offset from the beginning

[PATCH u-boot-mvebu v3 35/41] arm: mvebu: Load U-Boot proper binary in SPL code based on kwbimage header

2021-07-23 Thread Marek Behún
From: Pali Rohár Now that proper load and execution addresses are set in v1 kwbimage we can use it for loading and booting U-Boot proper. Use the new spl_parse_board_header() function to implement parsing the kwbimage v1 header. Use information from this header to locate offset and size of the

[PATCH u-boot-mvebu v3 20/41] tools: kwbimage: Mark all BootROM structures __packed

2021-07-23 Thread Marek Behún
From: Pali Rohár These structures must have specific size without padding, so mark them as packed via the de-facto standard macro __packed. Also replace PACKED macro. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese --- tools/kwbimage.h | 30

[PATCH u-boot-mvebu v3 36/41] arm: mvebu: Remove legacy U-Boot header from kwbimage v1 files

2021-07-23 Thread Marek Behún
From: Pali Rohár The SPL code now already parses kwbimage v1 headers where all necessary information about how to load and execute U-Boot proper is present. The legacy 64-byte U-Boot header is not used anymore. Remove this 64-byte header by putting u-boot.bin binary (instead of u-boot.img) into

[PATCH u-boot-mvebu v3 14/41] tools: kwbimage: Fix calculating size of binary header

2021-07-23 Thread Marek Behún
From: Pali Rohár Binary header consist of: * 1 byte for header type * 3 bytes for header size * 1 byte for number of arguments * 3 reserved bytes * N*4 bytes for arguments * M bytes (aligned to 4 bytes) for executable data * 1 byte for information about next header * 3 reserved bytes The first

[PATCH u-boot-mvebu v3 13/41] tools: kwbimage: Change maximum number of arguments in binary header to 256

2021-07-23 Thread Marek Behún
From: Pali Rohár The number is stored in one byte, so the maximum should be 255. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index

[PATCH u-boot-mvebu v3 12/41] tools: kwbimage: Use -a parameter (load address) for v1 images

2021-07-23 Thread Marek Behún
From: Pali Rohár The data part of v1 kwbimage currently contains U-Boot binary prepended by 64 bytes long Legacy U-Boot image header. This means that the load address is currently substracted by 64 bytes to ensure that U-Boot's entry point is at specified execution address. As mkimage has

[PATCH u-boot-mvebu v3 02/41] tools: kwbimage: Simplify aligning and calculating checksum

2021-07-23 Thread Marek Behún
From: Pali Rohár The return value of kwbimage_generate() is used for aligning the data part of kwbimage. Use it for calculating proper 4 byte alignment as is required by BootROM and also use it for allocating additional 4 bytes for the 32-bit data checksum. This simplifies the alignment code to

[PATCH u-boot-mvebu v3 11/41] tools: kwbimage: Cosmetic fix - remove redundant space character

2021-07-23 Thread Marek Behún
Remove this space, since the constants are indented by tabs. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwbimage.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.h b/tools/kwbimage.h

[PATCH u-boot-mvebu v3 10/41] tools: kwbimage: Print size of binary header in kwbimage_print_header()

2021-07-23 Thread Marek Behún
From: Pali Rohár The binary header in kwbimage contains executable SPL code. Print information about this binary header and not only information about it's data part. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris

[PATCH u-boot-mvebu v3 09/41] tools: kwbimage: Validate data checksum of v1 images

2021-07-23 Thread Marek Behún
From: Pali Rohár The data part of v1 images contains 32-bit checksum after the data. Validate whether this checksum is correct. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwbimage.c | 43

[PATCH u-boot-mvebu v3 08/41] tools: kwbimage: Validate extended headers of v1 images

2021-07-23 Thread Marek Behún
From: Pali Rohár Add basic checks for extended headers of v1 images. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham --- tools/kwbimage.c | 29 + 1 file changed, 29 insertions(+)

[PATCH u-boot-mvebu v3 07/41] tools: kwbimage: Fix check for v0 extended header checksum

2021-07-23 Thread Marek Behún
From: Pali Rohár Extended header checksum for v0 image is present only in the case when extended header is present. Skip checksum validation if extended header is not present. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by:

[PATCH u-boot-mvebu v3 06/41] tools: kwbimage: Don't crash when binary file name does not contain '/'

2021-07-23 Thread Marek Behún
From: Pali Rohár In the case when the file name is specified relative to the current working directory, it does not contain '/' character and strrchr() returns NULL. The following strcmp() function then crashes on NULL pointer dereference. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún

  1   2   >