Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Heinrich Schuchardt
On 11/6/21 02:52, Andre Przywara wrote: On Fri, 5 Nov 2021 18:56:34 -0400 Tom Rini wrote: On Fri, Nov 05, 2021 at 09:38:50PM +0100, Heinrich Schuchardt wrote: On 11/5/21 20:17, Tom Rini wrote: On Fri, Nov 05, 2021 at 07:37:02PM +0100, Heinrich Schuchardt wrote: On 11/5/21 17:12, Simon

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Tony Dinh
Hi Pali, On Fri, Nov 5, 2021 at 5:10 PM Pali Rohár wrote: > > On Friday 05 November 2021 16:36:47 Tony Dinh wrote: > > Hi Pali, > > > > On Fri, Nov 5, 2021 at 3:15 PM Pali Rohár wrote: > > > > > > On Friday 05 November 2021 15:07:17 Tony Dinh wrote: > > > > > > Also, I have several Kirkwood

Re: [RFC PATCH 00/13] Add support for Allwinner R329

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > This patchset adds Allwinner R329 support to U-Boot. > > First, some code refactors happen for SoCs w/o SCP/MMC2. > > Then the basical support for R329 come as several parts (memory map, > clocks, pinmux, DRAM, final Kconfig option). > > Then, as the

Re: [PATCH v1 1/2] image: Fix typo in boot_get_kbd()

2021-11-05 Thread Simon Glass
On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko wrote: > > After the commit 4ed37abc49c2 ("image: Remove ifdefs around > image_setup_linux() el at"): > > common/image-board.c: In function ‘boot_get_kbd’: > common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’ > 902 |

Re: [PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-05 Thread Simon Glass
Hi Andy, On Fri, 5 Nov 2021 at 14:10, Andy Shevchenko wrote: > > Compiler is not happy: > > common/image-board.c: In function ‘boot_get_kbd’: > common/image-board.c:902:17: warning: implicit declaration of function > ‘do_bdinfo’ [-Wimplicit-function-declaration] > 902 |

Re: [PATCH] usb: Use the first available device for ehci_gadget

2021-11-05 Thread Simon Glass
On Fri, 5 Nov 2021 at 10:53, Sean Anderson wrote: > > For whatever reason, usb_setup_ehci_gadget removes and probes USB device > 0. However, not all systems have a device 0. Use the first device > instead. > > The device probed should probably have something to do with the > controller (as

Re: rk3399-gru-kevin: issues on bringup

2021-11-05 Thread Simon Glass
Hi Alper, On Tue, 2 Nov 2021 at 17:05, Simon Glass wrote: > > Hi Alpher, > > On Mon, 1 Nov 2021 at 17:25, Alper Nebi Yasak > wrote: > > > > Hi, > > > > I've had some recent success with my gru-kevin and wanted to update you > > on this. Long story short, I can boot from SPI flash and have the

Re: [RFC PATCH 12/13] sunxi: sync R329 DTs from internal WIP kernel tree

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > Signed-off-by: Icenowy Zheng > --- > arch/arm/dts/Makefile | 2 + > arch/arm/dts/sun50i-r329-maix-iia-dock.dts | 36 > arch/arm/dts/sun50i-r329-maix-iia.dtsi | 45 + > arch/arm/dts/sun50i-r329.dtsi |

Re: [RFC PATCH 11/13] mmc: sunxi: add support for R329 MMC controller

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > R329 SoC has similar MMC controllers with previous Allwinner SoCs. > > Add support for it by adding its compatible string. > > Signed-off-by: Icenowy Zheng It really is that simple; as far as I can tell, the other checks are covered by

Re: [RFC PATCH 10/13] clk: sunxi: add support for R329 in sunxi DM clock driver

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > Currently only a subset of clocks/resets (similar to other SoCs) are > supported. > > Signed-off-by: Icenowy Zheng Reviewed-by: Samuel Holland > --- > drivers/clk/sunxi/Kconfig| 7 +++ > drivers/clk/sunxi/Makefile | 1 + >

Re: [RFC PATCH 08/13] sunxi: add Kconfig option for R329

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > As most code are ready for basic R329 support, let's add a Kconfig > option for it. > > Signed-off-by: Icenowy Zheng Reviewed-by: Samuel Holland with one minor comment below. > --- > arch/arm/mach-sunxi/Kconfig| 14 +- >

Re: [RFC PATCH 07/13] sunxi: add support for R329 DRAM controller

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > R329 has a new DRAM controller, which looks like a combination of the > H6/H616 MCTL_COM part and the SUNXI_DW MCTL_CTL part. This design has > already got reused by Allwinner, and V831/V833 SoCs have similar > memory controller. > > Add support for it.

Re: [RFC PATCH 06/13] sunxi: add support for basical pinmux setup on R329

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > Allwinner R329 SoC is the first known Allwinner SoC that has two > possible pinmux setups for MMC0 controller. > > Support configuration of both setups of MMC0 and UART0 at PB4/5. > > Signed-off-by: Icenowy Zheng > --- >

Re: [RFC PATCH 05/13] sunxi: add support for R329 clocks

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > R329 has a quite different clock tree than other SoCs. It has only 4 > PLLs and its PLL-PERIPH has two post dividers, one for the normal > PLL-PERIPH-2x output and another for a special PLL-PERIPH-800M output. > In addition, its PLL configuration

Re: [RFC PATCH 04/13] sunxi: add memory addresses for R329 SoC

2021-11-05 Thread Samuel Holland
On 7/22/21 1:30 AM, Icenowy Zheng wrote: > Allwinner R329 SoC has a different memory map with previous post-H6 > SoCs. > > Add the memory map to a dedicated header file, fill everywhere that > uses a hardcoded MMIO address and specify the SPL/ATF load address. > > Signed-off-by: Icenowy Zheng >

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Andre Przywara
On Fri, 5 Nov 2021 18:56:34 -0400 Tom Rini wrote: > On Fri, Nov 05, 2021 at 09:38:50PM +0100, Heinrich Schuchardt wrote: > > On 11/5/21 20:17, Tom Rini wrote: > > > On Fri, Nov 05, 2021 at 07:37:02PM +0100, Heinrich Schuchardt wrote: > > > > On 11/5/21 17:12, Simon Glass wrote: > > > > >

Re: [PATCH 00/11] fsl_esdhc_imx: port several patches from fsl_esdhc

2021-11-05 Thread Sean Anderson
On 11/5/21 7:32 PM, Michael Walle wrote: Am 2021-11-05 18:39, schrieb Sean Anderson: This series ports some of the patches from fsl_esdhc to fsl_esdhc_imx. Because these drivers share a common lineage, many of these patches apply with minor changes. For each one, I have noted the originating

Re: [PATCH] cmd: pxe_utils: sysboot: add label override support

2021-11-05 Thread Amjad Ouled-Ameur
Hi Simon, On 05/11/2021 03:02, Simon Glass wrote: Hi Amjad, On Fri, 22 Oct 2021 at 09:55, Amjad Ouled-Ameur wrote: This will allow consumers to choose a pxe label at runtime instead of having to prompt the user. One good use-case for this, is choosing whether or not to apply a dtbo depending

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 16:36:47 Tony Dinh wrote: > Hi Pali, > > On Fri, Nov 5, 2021 at 3:15 PM Pali Rohár wrote: > > > > On Friday 05 November 2021 15:07:17 Tony Dinh wrote: > > > > > Also, I have several Kirkwood boards (with various old BootROM > > > > > versions) that I can run the kwboot

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Tony Dinh
Hi Pali, On Fri, Nov 5, 2021 at 3:15 PM Pali Rohár wrote: > > On Friday 05 November 2021 15:07:17 Tony Dinh wrote: > > > > Also, I have several Kirkwood boards (with various old BootROM > > > > versions) that I can run the kwboot tests on. Will keep you posted. > > > > > > Ok! Do you have some

Re: [PATCH 00/11] fsl_esdhc_imx: port several patches from fsl_esdhc

2021-11-05 Thread Michael Walle
Am 2021-11-05 18:39, schrieb Sean Anderson: This series ports some of the patches from fsl_esdhc to fsl_esdhc_imx. Because these drivers share a common lineage, many of these patches apply with minor changes. For each one, I have noted the originating commit in the style of linux stable

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 09:38:50PM +0100, Heinrich Schuchardt wrote: > On 11/5/21 20:17, Tom Rini wrote: > > On Fri, Nov 05, 2021 at 07:37:02PM +0100, Heinrich Schuchardt wrote: > > > On 11/5/21 17:12, Simon Glass wrote: > > > > Hi, > > > > > > > > On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: >

[PATCH v8 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v8: - remove PCICFG_ME_REGISTER Changes in v7: - move bnxt_*.h files to drivers/net/bnxt/ - remove

Allow FIT Image Signature Verification to use RSA Public Key specified in DER Format

2021-11-05 Thread Harshvardhan Patel
Hi All, I have been able to get the FIT Image Signature verification running on a Raspberry Pi 4 Model B by following the documentation here: https://source.denx.de/u-boot/u-boot/-/blob/master/doc/uImage.FIT/beaglebone_vboot.txt. The public key, as the doc states, is stored in the Control FDT.

[PATCH v8 2/2] board: brcm-ns3: Load netXtreme firmware

2021-11-05 Thread Roman Bacik
From: Bharat Gooty Load NetXtreme firmware in board_init when BNXT_ETH is selected. Signed-off-by: Bharat Gooty Signed-off-by: Roman Bacik --- (no changes since v4) Changes in v4: - remove bnxt commands - load bnxt firmware in board_init Changes in v3: - remove commands set/get mac/speed

[PATCH] tools: kwboot: Always print kwboot version

2021-11-05 Thread Pali Rohár
It is useful to see kwboot version in the boot log output for debugging purposes. Signed-off-by: Pali Rohár --- tools/kwboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/kwboot.c b/tools/kwboot.c index 4e4d544efd3f..d22e6ea96a5c 100644 --- a/tools/kwboot.c +++

[PATCH] tools: kwboot: Fix sending Kirkwood v0 images

2021-11-05 Thread Pali Rohár
Properly calculate and align image header size to xmodem block size. Kirkwood v0 images do not have stored total size of header in header structure itself like it is for v1 images. So kwbheader_size() calculates size by traversing image structure itself. Aligning is done in kwboot by putting zero

[PATCH 1/1] kconfig: allow defconfigs to live in board directory

2021-11-05 Thread Troy Kisky
This will reduce the size of the configs directory, and make it more clear which board directory uses the defconfig file. Signed-off-by: Troy Kisky --- scripts/kconfig/Makefile | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/Makefile

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 15:07:17 Tony Dinh wrote: > > > Also, I have several Kirkwood boards (with various old BootROM > > > versions) that I can run the kwboot tests on. Will keep you posted. > > > > Ok! Do you have some Kirkwood board with PCIe slot? If yes, I would like > > to see dumps from

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
On Fri, Nov 5, 2021 at 3:04 PM Pali Rohár wrote: > > On Friday 05 November 2021 22:09:47 Pali Rohár wrote: > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > > + pci_read_word16(bp->pdev, > > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > > +

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Tony Dinh
Hi Pali, On Fri, Nov 5, 2021 at 2:39 PM Pali Rohár wrote: > > Hello! > > On Friday 05 November 2021 14:25:14 Tony Dinh wrote: > > Hi Pali, > > > > On Fri, Nov 5, 2021 at 3:19 AM Pali Rohár wrote: > > > > > > On Friday 05 November 2021 09:38:28 Pali Rohár wrote: > > > > Hello! > > > > > > > > On

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 22:09:47 Pali Rohár wrote: > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > + pci_read_word16(bp->pdev, > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > + >subsystem_vendor); > > > > +

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 14:41:44 Roman Bacik wrote: > On Fri, Nov 5, 2021 at 2:29 PM Pali Rohár wrote: > > > > On Friday 05 November 2021 14:19:46 Roman Bacik wrote: > > > Hi Pali, > > > > > > On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > > > > > > > On Friday 05 November 2021 12:54:24

Re: [PATCH 3/4] gpio: sunxi: Implement .set_flags

2021-11-05 Thread Samuel Holland
On 11/5/21 9:43 AM, Heinrich Schuchardt wrote: > On 10/21/21 06:52, Samuel Holland wrote: >> This, along with gpio_flags_xlate(), allows the GPIO driver to handle >> pull-up/down flags provided by consumer drivers or in the device tree. >> >> Signed-off-by: Samuel Holland >> Reviewed-by: Simon

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
On Fri, Nov 5, 2021 at 2:29 PM Pali Rohár wrote: > > On Friday 05 November 2021 14:19:46 Roman Bacik wrote: > > Hi Pali, > > > > On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > > > > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > > > + pci_read_word16(bp->pdev, > > > > > >

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Pali Rohár
Hello! On Friday 05 November 2021 14:25:14 Tony Dinh wrote: > Hi Pali, > > On Fri, Nov 5, 2021 at 3:19 AM Pali Rohár wrote: > > > > On Friday 05 November 2021 09:38:28 Pali Rohár wrote: > > > Hello! > > > > > > On Thursday 04 November 2021 23:27:32 Tony Dinh wrote: > > > > Hi Marek and Pali, >

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 14:19:46 Roman Bacik wrote: > Hi Pali, > > On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > > + pci_read_word16(bp->pdev, > > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > > +

Re: kwboot: Testing latest kwboot with Kirkwood SoC boards

2021-11-05 Thread Tony Dinh
Hi Pali, On Fri, Nov 5, 2021 at 3:19 AM Pali Rohár wrote: > > On Friday 05 November 2021 09:38:28 Pali Rohár wrote: > > Hello! > > > > On Thursday 04 November 2021 23:27:32 Tony Dinh wrote: > > > Hi Marek and Pali, > > > > > > First off all, thanks for your hughe work on this. I have a few

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
Hi Pali, On Fri, Nov 5, 2021 at 2:09 PM Pali Rohár wrote: > > On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > > + pci_read_word16(bp->pdev, > > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > > + >subsystem_vendor); > > > > + pci_read_word16(bp->pdev,

Re: [PATCH v3 0/3] fpga: zynqmp: Adding support of loading authenticated images

2021-11-05 Thread Oleksandr Suvorov
Hello Michal, On Wed, Nov 3, 2021 at 1:45 PM Michal Simek wrote: > > > > On 11/2/21 14:49, Oleksandr Suvorov wrote: > > > > This patchset introduces support for the authenticated FPGA images > > on ZynqMP boards, besides that introducing common way to pass the > > compatible property to any fpga

Re: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Pali Rohár
On Friday 05 November 2021 12:54:24 Roman Bacik wrote: > > > + pci_read_word16(bp->pdev, > > > + PCI_SUBSYSTEM_VENDOR_ID, > > > + >subsystem_vendor); > > > + pci_read_word16(bp->pdev, PCI_SUBSYSTEM_ID, > > >subsystem_device); > > > + pci_read_word16(bp->pdev,

[PATCH v7 2/2] board: brcm-ns3: Load netXtreme firmware

2021-11-05 Thread Roman Bacik
From: Bharat Gooty Load NetXtreme firmware in board_init when BNXT_ETH is selected. Signed-off-by: Bharat Gooty Signed-off-by: Roman Bacik --- (no changes since v4) Changes in v4: - remove bnxt commands - load bnxt firmware in board_init Changes in v3: - remove commands set/get mac/speed

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Heinrich Schuchardt
On 11/5/21 20:17, Tom Rini wrote: On Fri, Nov 05, 2021 at 07:37:02PM +0100, Heinrich Schuchardt wrote: On 11/5/21 17:12, Simon Glass wrote: Hi, On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: Hi Andre, Added Tom to Cc. On

[PATCH v1 2/2] image: Explicitly declare do_bdinfo()

2021-11-05 Thread Andy Shevchenko
Compiler is not happy: common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: warning: implicit declaration of function ‘do_bdinfo’ [-Wimplicit-function-declaration] 902 | do_bdinfo(NULL, 0, 0, NULL); | ^ Move the forward

[PATCH v1 1/2] image: Fix typo in boot_get_kbd()

2021-11-05 Thread Andy Shevchenko
After the commit 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at"): common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’ 902 | do_bdinfo(NULL, 0, 0, NULL); | ^

Re: Booting zImage with appended DTB without ATAGs support

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 04:47:31PM +0100, Pali Rohár wrote: > On Friday 05 November 2021 11:20:01 Tom Rini wrote: > > On Fri, Nov 05, 2021 at 04:16:46PM +0100, Pali Rohár wrote: > > > So now I have a question: Do we want to support booting zImage with > > > appended DTB in U-Boot when ATAGs

RE: [PATCH v6 1/2] net: brcm: netXtreme driver

2021-11-05 Thread Roman Bacik
Hi Pali, > -Original Message- > From: Pali Rohár > Sent: Wednesday, November 3, 2021 4:14 PM > To: Roman Bacik > Cc: U-Boot Mailing List ; Bharat Gooty > ; Joe Hershberger > ; Ramon Fried > Subject: Re: [PATCH v6 1/2] net: brcm: netXtreme driver > > Hello! See inline comments below. >

Re: [PATCH 10/10] Convert CONFIG_BOARD_EARLY_INIT_F et al to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:57PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_BOARD_EARLY_INIT_F >CONFIG_BOARD_LATE_INIT >CONFIG_DISPLAY_BOARDINFO >CONFIG_DISPLAY_BOARDINFO_LATE > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 09/10] Convert CONFIG_SPL_DRIVERS_MISC et al to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:56PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_SPL_DRIVERS_MISC >CONFIG_SPL_ENV_SUPPORT >CONFIG_SPL_GPIO >CONFIG_SPL_I2C >CONFIG_SPL_LDSCRIPT >CONFIG_SPL_LIBCOMMON_SUPPORT >CONFIG_SPL_LIBGENERIC_SUPPORT >

Re: [PATCH 08/10] Convert CONFIG_BMP_16BPP to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:55PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_BMP_16BPP > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 07/10] Convert CONFIG_OF_EMBED to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:54PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_OF_EMBED > > Signed-off-by: Tom Rini > Reviewed-by: Rick Chen Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 06/10] Convert CONFIG_MCFUART to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:53PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_MCFUART > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 05/10] Convert CONFIG_FEC_MXC to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:52PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_FEC_MXC > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 04/10] Convert CONFIG_SUPPORT_EMMC_BOOT to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:51PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_SUPPORT_EMMC_BOOT > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 03/10] Convert CONFIG_SYS_TEXT_BASE to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:50PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_SYS_TEXT_BASE > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 02/10] Convert CONFIG_SYS_HZ to Kconfig

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:49PM -0400, Tom Rini wrote: > This converts the following to Kconfig: > CONFIG_SYS_HZ > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 01/10] spl: Make use of CONFIG_IS_ENABLED(OS_BOOT) in SPL/TPL common code paths

2021-11-05 Thread Tom Rini
On Sat, Oct 30, 2021 at 11:03:48PM -0400, Tom Rini wrote: > When building a system that has both TPL and SPL_OS_BOOT, code which > tests for CONFIG_SPL_OS_BOOT will be built and enabled in TPL, which is > not correct. While there is no CONFIG_TPL_OS_BOOT symbol at this time > (and likely will

Re: [PATCH] fs: yaffs2: Finish Kconfig migration

2021-11-05 Thread Tom Rini
On Tue, Oct 19, 2021 at 09:10:14PM -0400, Tom Rini wrote: > For the symbols which are both hard-coded as enabled and used, move to > Kconfig. The rest of the CONFIG_YAFFS namespace is unselected anywhere, > so we leave it as is. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks!

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Simon Glass
Hi Andre, On Fri, 5 Nov 2021 at 11:07, Andre Przywara wrote: > > On Fri, 5 Nov 2021 10:12:11 -0600 > Simon Glass wrote: > > Hi, > > > On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > > > > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > > > Hi Andre, > > > > > > > > Added

Re: "mmc: rockchip_sdhci: add phy and clock config for rk3399" broke spl emmc boot

2021-11-05 Thread Jack Mitchell
On 05/11/2021 19:03, Alistair Delva wrote: > Hi Yifeng, > > Since "mmc: rockchip_sdhci: add phy and clock config for rk3399", my > RockPi 4b device can't boot off of eMMC. It will start tpl/spl and > then fail: > > U-Boot TPL 2021.10-rc1-gac804143cf-dirty (Aug 11 2021 - 10:02:07) > Channel 0:

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Tom Rini
On Fri, Nov 05, 2021 at 07:37:02PM +0100, Heinrich Schuchardt wrote: > On 11/5/21 17:12, Simon Glass wrote: > > Hi, > > > > On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > > > > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > > > Hi Andre, > > > > > > > > Added Tom to Cc.

[PATCH 6/6 v5] MAINTAINERS: Add entry for TPM drivers

2021-11-05 Thread Ilias Apalodimas
TPM drivers have currently no maintainers. Add myself since I contributed the TIS implementation. Reviewed-by: Heinrich Schuchardt Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 3/6 v5] tpm: Use the new API on tpm2 spi driver

2021-11-05 Thread Ilias Apalodimas
Convert our SPI TPM driver and use the newly added API Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- drivers/tpm/Makefile | 2 +- drivers/tpm/tpm2_tis_spi.c | 447 +++-- 2 files changed, 32 insertions(+), 417 deletions(-) diff --git

[PATCH 5/6 v5] doc: qemu: Add instructions for swtpm usage

2021-11-05 Thread Ilias Apalodimas
A previous patch added support for an mmio based TPM. Add an example in QEMU on it's usage Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- doc/board/emulation/qemu-arm.rst | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH 4/6 v5] configs: Enable tpmv2 mmio on qemu for arm/arm64

2021-11-05 Thread Ilias Apalodimas
A previous commit is adding an MMIO TPMv2 driver. Include in the default qemu arm configs, since we plan on using them on EFI testing Reviewed-by: Simon Glass Signed-off-by: Ilias Apalodimas --- configs/qemu_arm64_defconfig | 2 ++ configs/qemu_arm_defconfig | 2 ++ 2 files changed, 4

[PATCH 2/6 v5] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Ilias Apalodimas
Add support for devices that expose a TPMv2 though MMIO. Apart from those devices, we can use the driver in our QEMU setups and test TPM related code which is difficult to achieve using the sandbox driver (e.g test the EFI TCG2 protocol). It's worth noting that a previous patch added TPMv2 TIS

[PATCH 1/6 v5] tpm2: Introduce TIS tpm core

2021-11-05 Thread Ilias Apalodimas
There's a lot of code duplication in U-Boot right now. All the TPM TIS compatible drivers we have at the moment have their own copy of a TIS implementation. So let's create a common layer which implements the core TIS functions. Any driver added from now own, which is compatible with the TIS

[PATCH 0/6 v5] TPM cleanups and MMIO driver

2021-11-05 Thread Ilias Apalodimas
Hi! This is the update for [1]. Changes since v4: - renamed struct udevice *udev -> struct udevice *dev - added comments on struct tpm_tis_phy_ops - removed duplicate defines from tpm2_tis_spi driver (now in tpm_tis.h) - moved API function description for the .c to the .h file - added

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Heinrich Schuchardt
On 11/5/21 17:12, Simon Glass wrote: Hi, On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: Hi Andre, Added Tom to Cc. On 05.11.21 11:04, Andre Przywara wrote: On Thu, 4 Nov 2021 20:02:41 -0600 Simon Glass wrote: Hi, On Thu, 4

[PATCH 1/1] watchdog: don't autostart watchdog on Sunxi boards

2021-11-05 Thread Heinrich Schuchardt
The Sunxi boards only support a 16 second watchdog timeout. This is too short to boot Linux. The UEFI specification requires 300 seconds as default timeout. Change the default for CONFIG_WATCHDOG_AUTOSTART for ARCH_SUNXI. Fixes: b147bd3607f8 ("sunxi: Enable watchdog timer support by default")

Re: [PATCH] sf: Querying write-protect status before operating the flash

2021-11-05 Thread Jagan Teki
On Fri, Nov 5, 2021 at 10:47 PM wrote: > > Hi, > > On 6/22/21 8:21 AM, chao zeng wrote: > > From: Chao Zeng > > > > When operating the write-protection flash,spi_flash_std_write() and > > spi_flash_std_erase() would return wrong result.The flash is protected, > > but write or erase the flash

[PATCH 10/11] mmc: fsl_esdhc_imx: replace most #ifdefs by IS_ENABLED()

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit 52faec31827ec1a1837977e29c067424426634c5 ] Make the code cleaner and drop the old-style #ifdef constructs where it is possible. Signed-off-by: Michael Walle Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 209

[PATCH 09/11] mmc: fsl_esdhc_imx: simplify esdhc_setup_data()

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit 7e48a028a42c111ba38a90b86e5f57dace980fa0 ] First, we need the waterlevel setting for PIO mode only. Secondy, both DMA setup code is identical for both directions, except for the data pointer. Thus, unify them. Signed-off-by: Michael Walle Signed-off-by:

[PATCH 11/11] mmc: fsl_esdhc_imx: set sysctl register for clock initialization

2021-11-05 Thread Sean Anderson
From: Yangbo Lu [ fsl_esdhc commit 263ddfc3454ead3a988adef39b962479adce2b28 ] The initial clock setting should be through sysctl register only, while the mmc_set_clock() will call mmc_set_ios() introduce other configurations like bus width, mode, and so on. Signed-off-by: Yangbo Lu

[PATCH 08/11] mmc: fsl_esdhc_imx: use dma-mapping API

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit b1ba1460a445bcc67972a617625d0349e4f22b31 ] Use the dma_{map,unmap}_single() calls. These will take care of the flushing and invalidation of caches. Signed-off-by: Michael Walle Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 50

[PATCH 06/11] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 30f6444d024a74ee48aa6969c1531aecd3c59deb ] Fix mmc->clock with actual clock which is divided by the controller, and record it with priv->clock. Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 07/11] mmc: fsl_esdhc_imx: simplify 64bit check for SDMA transfers

2021-11-05 Thread Sean Anderson
From: Michael Walle [ fsl_esdhc commit da86e8cfcb03ed5c1d8e0718bc8bc8583e60ced8 ] SDMA can only do DMA with 32 bit addresses. This is true for all architectures (just doesn't apply to 32 bit ones). Simplify the code and remove unnecessary CONFIG_FSL_LAYERSCAPE. Also make the error message more

[PATCH 05/11] mmc: fsl_esdhc_imx: drop redundant code for non-removable feature

2021-11-05 Thread Sean Anderson
From: Yangbo Lu [ fsl_esdhc commit commit 08197cb8dff7cd097ab07a325093043c39d19bbd ] Drop redundant code for non-removable feature. "non-removable" property has been read in mmc_of_parse(). Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 28

[PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] This patch is to clean up bus width setting code. - For DM_MMC, remove getting "bus-width" from device tree. This has been done in mmc_of_parse(). - For non-DM_MMC, move bus width configuration from fsl_esdhc_init() to

[PATCH 03/11] mmc: fsl_esdhc_imx: fix voltage validation

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 5b05fc0310cd933acf76ee661577c6b07a95e684 ] Voltage validation should be done by CMD8. Current comparison between mmc_cfg voltages and host voltage capabilities is meaningless. So drop current comparison and let voltage validation is through CMD8. Signed-off-by: Yangbo Lu

[PATCH 02/11] mmc: fsl_esdhc_imx: remove redundant DM_MMC checking

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 2913926f3b3dec282f8773e3c02377c9600d8267 ] Remove redundant DM_MMC checking which is already in DM_MMC conditional compile block. Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson --- drivers/mmc/fsl_esdhc_imx.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 01/11] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC

2021-11-05 Thread Sean Anderson
[ fsl_esdhc commit 41dec2fe99512e941261594f522b2e7d485c314b ] U-boot prefers DM_MMC + BLK for MMC. Now eSDHC driver has already support it, so let's force to use it. - Drop non-BLK support for DM_MMC introduced by below patch. 66fa035 mmc: fsl_esdhc: fix probe issue without CONFIG_BLK enabled

[PATCH 00/11] fsl_esdhc_imx: port several patches from fsl_esdhc

2021-11-05 Thread Sean Anderson
This series ports some of the patches from fsl_esdhc to fsl_esdhc_imx. Because these drivers share a common lineage, many of these patches apply with minor changes. For each one, I have noted the originating commit in the style of linux stable backports. In fa33d20749 ("mmc: split fsl_esdhc

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread Simon Glass
) to signal Hi François, On Fri, 5 Nov 2021 at 10:31, François Ozog wrote: > > Hi Simon, > > Le ven. 5 nov. 2021 à 17:12, Simon Glass a écrit : >> >> Hi François, >> >> On Fri, 5 Nov 2021 at 02:27, François Ozog wrote: >> > >> > >> > >> > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: >> >>

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Andre Przywara
On Fri, 5 Nov 2021 10:12:11 -0600 Simon Glass wrote: Hi, > On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > > Hi Andre, > > > > > > Added Tom to Cc. > > > > > > On 05.11.21 11:04, Andre Przywara wrote: > > > > On Thu, 4

[PATCH] usb: Use the first available device for ehci_gadget

2021-11-05 Thread Sean Anderson
For whatever reason, usb_setup_ehci_gadget removes and probes USB device 0. However, not all systems have a device 0. Use the first device instead. The device probed should probably have something to do with the controller (as specified by e.g. ums or fastboot ). In fact, I find it odd that we

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread François Ozog
Hi Simon, Le ven. 5 nov. 2021 à 17:12, Simon Glass a écrit : > Hi François, > > On Fri, 5 Nov 2021 at 02:27, François Ozog > wrote: > > > > > > > > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: > >> > >> Hi François, > >> > >> On Tue, 2 Nov 2021 at 10:03, François Ozog > wrote: > >> > > >>

Re: [PATCH 2/6 v4] tpm2: Add a TPMv2 MMIO TIS driver

2021-11-05 Thread Simon Glass
Hi Ilias, On Fri, 5 Nov 2021 at 02:23, Ilias Apalodimas wrote: > > On Fri, Nov 05, 2021 at 10:17:21AM +0200, Ilias Apalodimas wrote: > > Hi Simon, > > > > [...] > > > > > > + u8 *result) > > > > +{ > > > > + struct tpm_tis_chip_data *drv_data = (void > > > >

Re: [PATCH v2 08/12] sysinfo: Add support for iterating string list

2021-11-05 Thread Simon Glass
Hi Marek, On Fri, 5 Nov 2021 at 05:24, Marek Behún wrote: > > On Thu, 4 Nov 2021 20:02:29 -0600 > Simon Glass wrote: > > > Better to make iter a struct sysinfo_str_list_iter, I think and > > require the caller to declare it: > > > > sysinfo_str_list_iter iter; > > char str[80]' > > > > p =

Re: [PATCH 00/31] passage: Define a standard for firmware data flow

2021-11-05 Thread Simon Glass
Hi François, On Fri, 5 Nov 2021 at 02:27, François Ozog wrote: > > > > On Fri, 5 Nov 2021 at 03:02, Simon Glass wrote: >> >> Hi François, >> >> On Tue, 2 Nov 2021 at 10:03, François Ozog wrote: >> > >> > Hi Simon, >> > >> > On Tue, 2 Nov 2021 at 15:59, Simon Glass wrote: >> >> >> >> Hi

Re: [PATCH v5 05/11] test/py: efi_capsule: add image authentication test

2021-11-05 Thread Simon Glass
Hi Takahiro, On Thu, 4 Nov 2021 at 21:24, AKASHI Takahiro wrote: > > On Thu, Nov 04, 2021 at 08:02:37PM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 4 Nov 2021 at 19:21, AKASHI Takahiro > > wrote: > > > > > > On Wed, Nov 03, 2021 at 08:49:04PM -0600, Simon Glass wrote: > > > > Hi

Re: [RFC 2/2] binman: catch RunException for mkimage runtime failure

2021-11-05 Thread Simon Glass
Hi Heiko, On Fri, 5 Nov 2021 at 01:50, Heiko Thiery wrote: > > Hi Simon, > > Am Fr., 5. Nov. 2021 um 03:02 Uhr schrieb Simon Glass : > > > > Hi Heiko, > > > > On Thu, 4 Nov 2021 at 12:53, Heiko Thiery wrote: > > > > > > In case mkimage exits with a return code other than zero do not stop. > > >

Re: [PATCH v5 04/11] doc: update UEFI document for usage of mkeficapsule

2021-11-05 Thread Simon Glass
Hi Takahiro, On Thu, 4 Nov 2021 at 21:15, AKASHI Takahiro wrote: > > On Thu, Nov 04, 2021 at 09:11:51AM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Wed, 3 Nov 2021 at 19:49, AKASHI Takahiro > > wrote: > > > > > > On Tue, Nov 02, 2021 at 08:57:48AM -0600, Simon Glass wrote: > > > > Hi

Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION

2021-11-05 Thread Simon Glass
Hi Takahiro, On Thu, 4 Nov 2021 at 20:49, AKASHI Takahiro wrote: > > On Thu, Nov 04, 2021 at 08:02:05PM -0600, Simon Glass wrote: > > Hi, > > > > On Tue, 2 Nov 2021 at 01:43, Heinrich Schuchardt wrote: > > > > > > > > > > > > On 11/1/21 03:14, Simon Glass wrote: > > > > Hi Takahiro, > > > > > >

Re: [PATCH v2 06/12] sysinfo: Add get_str_list() method

2021-11-05 Thread Simon Glass
Hi Marek, On Fri, 5 Nov 2021 at 05:20, Marek Behún wrote: > > On Thu, 4 Nov 2021 20:02:27 -0600 > Simon Glass wrote: > > > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > > > From: Marek Behún > > > > > > Add get_str_list() method to sysinfo operations. > > > > > > The get_str_list()

Re: [PATCH 1/6 v4] tpm2: Introduce TIS tpm core

2021-11-05 Thread Simon Glass
Hi Ilias, On Fri, 5 Nov 2021 at 01:02, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > > +int tpm_tis_open(struct udevice *udev); > > > > Please add comments > > There are comments for all of those in drivers/tpm/tpm2_tis_core.c, > isn't that enough? So just move them to the header

Re: [PATCH v2 04/12] sysinfo: Make sysinfo_get_str() behave like snprintf()

2021-11-05 Thread Simon Glass
Hi Marek, On Fri, 5 Nov 2021 at 05:19, Marek Behún wrote: > > On Thu, 4 Nov 2021 20:02:25 -0600 > Simon Glass wrote: > > > Hi Marek, > > > > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > > > From: Marek Behún > > > > > > Currently sysinfo_get_str() returns 0 if a string is filled in

Re: Injecting public keys into FTDs for FIT verification

2021-11-05 Thread Simon Glass
Hi, On Fri, 5 Nov 2021 at 07:04, Jan Kiszka wrote: > > On 05.11.21 13:42, Jan Kiszka wrote: > > On 05.11.21 11:28, Rasmus Villemoes wrote: > >> On 05/11/2021 11.16, Jan Kiszka wrote: > >>> Hi all, > >>> > >>> in order to use CONFIG_FIT_SIGNATURE and also > >>> CONFIG_SPL_FIT_SIGNATURE, a public

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-05 Thread Simon Glass
Hi, On Fri, 5 Nov 2021 at 08:21, Tom Rini wrote: > > On Fri, Nov 05, 2021 at 12:14:47PM +0100, Stefan Roese wrote: > > Hi Andre, > > > > Added Tom to Cc. > > > > On 05.11.21 11:04, Andre Przywara wrote: > > > On Thu, 4 Nov 2021 20:02:41 -0600 > > > Simon Glass wrote: > > > > > > Hi, > > > > > >

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-11-05 Thread Heinrich Schuchardt
On 10/21/21 06:52, Samuel Holland wrote: Now that the sunxi_gpio driver handles pull-up/down via the driver model, pin configuration does not need a platform-specific function. Signed-off-by: Samuel Holland I tested on an OrangePi PC (orangepi_pc_defconfig). The 'mmc rescan' command detects

  1   2   >