Re: [PATCH u-boot-marvell 02/10] arm: mvebu: a38x: serdes: Move non-serdes PCIe code to pci_mvebu.c

2021-11-28 Thread Stefan Roese
Hi Pali, On 11/23/21 16:59, Pali Rohár wrote: On Friday 19 November 2021 07:55:00 Stefan Roese wrote: On 11/18/21 19:01, Pali Rohár wrote: On Friday 12 November 2021 15:01:57 Stefan Roese wrote: On 11/11/21 16:35, Marek Behún wrote: From: Pali Rohár As explained in commit 3bedbcc3aa18

[PATCH v8 3/3] efi_loader: Extend PCR's for firmware measurements

2021-11-28 Thread Ruchika Gupta
Firmwares before U-Boot may be capable of doing tpm measurements and passing them to U-Boot in the form of eventlog. However there may be scenarios where the firmwares don't have TPM driver and are not capable of extending the measurements in the PCRs. Based on TCG spec, if previous firnware has

[PATCH v8 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-28 Thread Ruchika Gupta
The current tpm2_pcr_read is hardcoded using SHA256. Make the actual command to TPM configurable to use wider range of algorithms. The current command line is kept as is i.e limited to SHA-256 only. Signed-off-by: Ruchika Gupta Reviewed-by: Ilias Apalodimas --- v8: No change v7: No change v6:

[PATCH v8 1/3] efi_loader: Add check for event log passed from firmware

2021-11-28 Thread Ruchika Gupta
Platforms may have support to measure their initial firmware components and pass the event log to u-boot. The event log address can be passed in property tpm_event_log_addr and tpm_event_log_size of the tpm node. Platforms may choose their own specific mechanism to do so. A weak function is added

RE: [EXT] Re: [PATCH v4 01/16] crypto/fsl: Add support for CAAM Job ring driver model

2021-11-28 Thread Gaurav Jain
Hello Simon > -Original Message- > From: Simon Glass > Sent: Thursday, November 25, 2021 5:42 AM > To: Gaurav Jain > Cc: U-Boot Mailing List ; Stefano Babic > ; Fabio Estevam ; Peng Fan > ; Priyanka Jain ; Ye Li > ; Horia Geanta ; Ji Luo > ; Franck Lenormand ; Silvano Di > Ninno ; Sahil

Re: [PATCH v3] efi_loader: check tcg2 protocol installation outside the TCG protocol

2021-11-28 Thread Ilias Apalodimas
Hi Kojima-san [...] > > > +efi_status_t efi_tcg2_do_initial_measurement(void) > > > +{ > > > + efi_status_t ret; > > > + struct udevice *dev; > > > + > > > + ret = platform_get_tpm2_device(); > > > + if (ret != EFI_SUCCESS) > > > + goto out; > > > + > > > + ret =

Re: [PATCH 1/1] tis: fix tpm_tis_remove()

2021-11-28 Thread Ilias Apalodimas
Hi Heinrich, On Mon, Nov 29, 2021 at 12:03:44AM +0100, Heinrich Schuchardt wrote: > tpm_tis_remove() leads to calling tpm_tis_ready() with the IO region > unmapped and chip->locality == -1 (locality released). This leads to a > crash in mmio_write_bytes(). > > The patch implements these

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-28 Thread Sughosh Ganu
hi Ilias, Thanks for the review. On Fri, 26 Nov 2021 at 17:05, Ilias Apalodimas wrote: > Hi Sughosh, > > On Thu, Nov 25, 2021 at 12:42:55PM +0530, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata,

Re: [PATCH 1/1] doc: qemu-arm peripherials

2021-11-28 Thread Ilias Apalodimas
Hi Heinrich On Sun, 28 Nov 2021 at 21:04, Ilias Apalodimas wrote: > > Hi Heinrich, > > > On Sun, 28 Nov 2021 at 12:56, Heinrich Schuchardt > wrote: > > > > * add description how to add RNG device > > * for a disk specify format=raw to avoid a warning > > * fix a typo > > > > Signed-off-by:

Re: [PATCH v3] efi_loader: check tcg2 protocol installation outside the TCG protocol

2021-11-28 Thread Masahisa Kojima
Hi Ilias, On Fri, 26 Nov 2021 at 23:55, Ilias Apalodimas wrote: > > Hi Kojima-san, > > On Fri, Nov 26, 2021 at 10:31:16AM +0900, Masahisa Kojima wrote: > > There are functions that calls tcg2_agile_log_append() outside > > of the TCG protocol invocation (e.g tcg2_measure_pe_image). > > These

Please pull u-boot-dm/next

2021-11-28 Thread Simon Glass
Hi Tom, This is for the next branch. https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10005 he following changes since commit 1943f2a2a7c58b76812fcad2d3012036af7464ce: Merge branch '2021-11-23-scmi-and-tee-updates' into next (2021-11-23 16:24:24 -0500) are available in the

[PATCH] board: iot2050: update build documentation for OP-TEE

2021-11-28 Thread Ivan Mikhaylov
From: Ivan Mikhaylov Set ta-target explicitly to correspond with OP-TEE recipe in siemens/meta-iot2050. Errors without explicit set of ta-target: aarch64-linux-gnu-gcc: error: unrecognized command-line option ‘-mthumb’ aarch64-linux-gnu-gcc: error: unrecognized command-line option

Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2021-11-28 Thread Angus Ainslie
Hi Fabio, On 2021-11-28 7:15 a.m., Fabio Estevam wrote: > Hi Angus, > > On Sun, Nov 28, 2021 at 11:52 AM Angus Ainslie wrote: >> On imx8m it is more correct to read the data register than the pad status >> register. >> >> In output mode the pad status register does not contain the value being >>

Re: [PATCH v4] env: Avoid using GNU features in awk

2021-11-28 Thread Simon Glass
Hi Mark, On Sun, 28 Nov 2021 at 15:57, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Wed, 24 Nov 2021 07:40:14 -0700 > > > > GNU has a very useful third argument to match() but this is not supported > > in the POSIX awk. > > > > Update the code to cope, so that the script is

Re: [PATCH v4] env: Avoid using GNU features in awk

2021-11-28 Thread Simon Glass
Hi Mark, On Sun, 28 Nov 2021 at 15:57, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Wed, 24 Nov 2021 07:40:14 -0700 > > > > GNU has a very useful third argument to match() but this is not supported > > in the POSIX awk. > > > > Update the code to cope, so that the script is

[PATCH 1/1] tis: fix tpm_tis_remove()

2021-11-28 Thread Heinrich Schuchardt
tpm_tis_remove() leads to calling tpm_tis_ready() with the IO region unmapped and chip->locality == -1 (locality released). This leads to a crash in mmio_write_bytes(). The patch implements these changes: tpm_tis_remove(): Unmap the IO region after calling tpm_tis_cleanup(). tpm_tis_cleanup():

Re: [PATCH V2] cmd_nandbcb: Support secondary boot address of imx8mn

2021-11-28 Thread Michael Nazzareno Trimarchi
Hi Fabio On Sun, Nov 28, 2021 at 7:00 PM Fabio Estevam wrote: > > Hi Michael, > > On Sun, Nov 28, 2021 at 1:58 PM Michael Nazzareno Trimarchi > wrote: > > > > Hi Fabio > > > > Any time to review it? > > Please fix the checkpatch warnings: > > WARNING: Possible unwrapped commit description

Re: [PATCH v4] env: Avoid using GNU features in awk

2021-11-28 Thread Mark Kettenis
> From: Simon Glass > Date: Wed, 24 Nov 2021 07:40:14 -0700 > > GNU has a very useful third argument to match() but this is not supported > in the POSIX awk. > > Update the code to cope, so that the script is POSIX-compliant. > > Signed-off-by: Simon Glass > --- > > Changes in v4: > - Avoid

Re: [BUG] tpm2_tis_mmio driver crashes on device_remove()

2021-11-28 Thread Heinrich Schuchardt
On 11/28/21 11:27, Heinrich Schuchardt wrote: Hello Ilias, I have compiled qemu_arm64_defconfig with CONFIG_CMD_EFIDEBUG=y and CONFIG_CMD_UNBIND. When I execute the commands     efidebug dh     unbind tpm 0 a crash occurs in tpm_tis_ready(). tpm_tis_remove() calls iounmmap() before

Re: [PATCH] mtd: sf: Set SF parameters as env variables

2021-11-28 Thread Marek Vasut
On 10/7/21 2:46 PM, Marek Vasut wrote: On 10/7/21 2:40 PM, Pratyush Yadav wrote: On 23/09/21 10:00PM, Marek Vasut wrote: On 9/23/21 8:53 PM, Pratyush Yadav wrote: On 14/09/21 05:28AM, Marek Vasut wrote: Set the SF page size, erase block size and total size as an environment variable after

Re: [PATCH 1/1] doc: qemu-arm peripherials

2021-11-28 Thread Ilias Apalodimas
Hi Heinrich, On Sun, 28 Nov 2021 at 12:56, Heinrich Schuchardt wrote: > > * add description how to add RNG device > * for a disk specify format=raw to avoid a warning > * fix a typo > > Signed-off-by: Heinrich Schuchardt > --- > doc/board/emulation/qemu-arm.rst | 9 +++-- >

Re: [PATCH V2] cmd_nandbcb: Support secondary boot address of imx8mn

2021-11-28 Thread Fabio Estevam
Hi Michael, On Sun, Nov 28, 2021 at 1:58 PM Michael Nazzareno Trimarchi wrote: > > Hi Fabio > > Any time to review it? Please fix the checkpatch warnings: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #81: • Secondary boot is disabled if fuse value is

Re: [RFC PATCH 3/3] imx: imx8mp_evk: override env_get_location

2021-11-28 Thread Tommaso Merciai
On Fri, Nov 26, 2021 at 07:00:21PM +0100, Marek Behún wrote: > On Fri, 26 Nov 2021 18:43:31 +0100 > Tommaso Merciai wrote: > > > Override env_get_location function at board level, previously dropped > > down from soc.c > > > > References: > > - commit f1575f23df1ef704051f218d5bc4aeeb20c2c542 >

Re: [PATCH V2] cmd_nandbcb: Support secondary boot address of imx8mn

2021-11-28 Thread Michael Nazzareno Trimarchi
Hi Fabio Any time to review it? Michael On Thu, Nov 18, 2021 at 3:01 PM Michael Trimarchi wrote: > > Add support of secondary boot address for imx8mn. The secondary > boot address is hardcoded in the fuse. The value is calculated > from there according to the following description: > > The

[PATCH 2/2] cmd: fuse: Add a command to read fuses to memory

2021-11-28 Thread Angus Ainslie
With the fuse values in memory we can use some of the other u-boot shell conditonal operators to do tests. Signed-off-by: Angus Ainslie --- cmd/fuse.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/cmd/fuse.c b/cmd/fuse.c index 78b1065d99e..0676bb7a812 100644

[PATCH 1/2] cmd: fuse: add a fuse comparison function

2021-11-28 Thread Angus Ainslie
Compare a hexval to the fuse value and return pass or fail. Signed-off-by: Angus Ainslie --- cmd/fuse.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/cmd/fuse.c b/cmd/fuse.c index e001619d172..78b1065d99e 100644 --- a/cmd/fuse.c +++ b/cmd/fuse.c @@

Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2021-11-28 Thread Angus Ainslie
Hi Fabio, On 2021-11-28 07:21, Fabio Estevam wrote: Hi Angus, On Sun, Nov 28, 2021 at 12:18 PM Angus Ainslie wrote: I have tried it with the SION bit set but I thought it would be better if the dts would match the linux dts and return the same result. Just to confirm: with the SION bit

Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2021-11-28 Thread Fabio Estevam
Hi Angus, On Sun, Nov 28, 2021 at 12:18 PM Angus Ainslie wrote: > I have tried it with the SION bit set but I thought it would be better > if the dts would match the linux dts and return the same result. Just to confirm: with the SION bit set, you read the correct values, right? If so, the

Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2021-11-28 Thread Angus Ainslie
Hi Fabio, On 2021-11-28 07:15, Fabio Estevam wrote: Hi Angus, On Sun, Nov 28, 2021 at 11:52 AM Angus Ainslie wrote: On imx8m it is more correct to read the data register than the pad status register. In output mode the pad status register does not contain the value being output so we

Re: [PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2021-11-28 Thread Fabio Estevam
Hi Angus, On Sun, Nov 28, 2021 at 11:52 AM Angus Ainslie wrote: > > On imx8m it is more correct to read the data register than the pad status > register. > > In output mode the pad status register does not contain the value being > output so we must read the DR for the value. > > In input mode

[PATCH] drivers: spi-nor: Add JEDEC id for W25Q16JV

2021-11-28 Thread Angus Ainslie
Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory with DUAL/QUAD SPI Signed-off-by: Angus Ainslie --- drivers/mtd/spi/spi-nor-ids.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c index

[PATCH] mxc_gpio: on imx8m read the DR instead of the PSR

2021-11-28 Thread Angus Ainslie
On imx8m it is more correct to read the data register than the pad status register. In output mode the pad status register does not contain the value being output so we must read the DR for the value. In input mode the DR will contain the same value as the PSR when the pad mode is GPIO. If the

[PATCH v4 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-11-28 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit adds support for MMC controllers found on Actions OWL SoC platform(S700/S900). Signed-off-by: Amit Singh Tomar --- Changes since v3: * Re-based to latest master (2ad8d0cb950da) There are some "dm: treewide" changes have been made

[PATCH v4 6/6] configs: Enable mmc support

2021-11-28 Thread Amit Singh Tomar
From: Amit Singh Tomar This commits enables mmc on the Actions Cubieboard7 board. Signed-off-by: Amit Singh Tomar --- Changes since previous versions * No change. --- configs/cubieboard7_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/cubieboard7_defconfig

[PATCH v4 4/6] ARM: dts: s700: add MMC/SD controller node

2021-11-28 Thread Amit Singh Tomar
From: Amit Singh Tomar This patch adds node for mmc/sd controller found on Action Semi OWL S700 SoC. Since, upstream Linux binding has not been merged for S700 MMC/SD controller, Changes are put in u-boot specific dtsi file. Signed-off-by: Amit Singh Tomar --- Changes since previous versions

[PATCH v4 3/6] ARM: dts: sync Actions Semi S700 DT from Linux 5.10-rc7

2021-11-28 Thread Amit Singh Tomar
From: Amit Singh Tomar This Synchronizes the Actions Semi S700 SoC DT changes from commit "0477e9288185" ("Linux 5.10-rc7"). Signed-off-by: Amit Singh Tomar --- Changes since previous versions * No change. --- arch/arm/dts/s700.dtsi| 17 -

[PATCH v4 2/6] clk: actions: Add SD/MMC clocks

2021-11-28 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit adds SD/MMC clocks, and provides .set/get_rate callbacks for SD/MMC device present on Actions OWL S700 SoCs. Signed-off-by: Amit Singh Tomar --- Changes since v3: * No change. Changes since v2: * Fixed the weird div assignment. * Moved

[PATCH v4 1/6] clk: actions: Introduce dummy get/set_rate callbacks

2021-11-28 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit introduces get/set_rate callbacks, these are dummy at the moment, and can be used to get/set clock for various devices based on the clk id. Signed-off-by: Amit Singh Tomar --- Changes since v3: * No changes. Changes since v2: * No changes.

[PATCH v4 0/6] Add MMC/SD support for S700/S900

2021-11-28 Thread Amit Singh Tomar
Hi, Sorry, it took me some time to come up with v4. For v3, all the comments are from MMC driver(patch 5/6), and tried to address in this series(v4) with changelog mentioned in the patch (5/6) itself. This series(v3) addresses review

[PATCH 1/1] doc: qemu-arm peripherials

2021-11-28 Thread Heinrich Schuchardt
* add description how to add RNG device * for a disk specify format=raw to avoid a warning * fix a typo Signed-off-by: Heinrich Schuchardt --- doc/board/emulation/qemu-arm.rst | 9 +++-- drivers/tpm/tpm2_tis_mmio.c | 5 - 2 files changed, 11 insertions(+), 3 deletions(-) diff

[BUG] tpm2_tis_mmio driver crashes on device_remove()

2021-11-28 Thread Heinrich Schuchardt
Hello Ilias, I have compiled qemu_arm64_defconfig with CONFIG_CMD_EFIDEBUG=y and CONFIG_CMD_UNBIND. When I execute the commands efidebug dh unbind tpm 0 a crash occurs in tpm_tis_ready(). tpm_tis_remove() calls iounmmap() before calling tpm_tis_cleanup() which invokes