Re: [PATCH 2/2] net: eth-phy: prevent undesired de-assertion of phy-reset on request

2022-03-02 Thread Ramon Fried
On Tue, Mar 1, 2022 at 10:38 PM Joe Hershberger wrote: > > On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey wrote: > > > > When gpio_request_by_name allocates a gpio output it by default will > > de-assert the gpio which for phy-reset will take the PHY out of reset. > > As this occurs before

Re: [PATCH 1/2] net: fec: prevent undesired de-assertion of phy-reset on request

2022-03-02 Thread Ramon Fried
On Wed, Mar 2, 2022 at 3:58 AM Adam Ford wrote: > > On Tue, Mar 1, 2022 at 2:38 PM Joe Hershberger wrote: > > > > On Tue, Mar 1, 2022 at 2:15 PM Tim Harvey wrote: > > > > > > When gpio_request_by_name allocates a gpio output it by default will > > > de-assert the gpio which for phy-reset will

Re: [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string

2022-03-02 Thread Ramon Fried
On Mon, Feb 28, 2022 at 1:31 AM Marcel Ziswiler wrote: > > On Sat, 2022-02-26 at 04:36 +0100, Marek Vasut wrote: > > The correct compatible string for i.MX8MP variant of DWC EQoS MAC > > is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of > > the current wrong compatible string to

Re: [PATCH 7/9] net: Remove CONFIG_BOOTP_DHCP_REQUEST_DELAY

2022-03-02 Thread Ramon Fried
On Fri, Feb 25, 2022 at 6:20 PM Tom Rini wrote: > > This option is not in use anywhere and the documentation implies it's > for some very old and unlikely to be seen currently issues. Rather than > update the code so the CONFIG symbol could be easily in Kconfig, remove > the code. > > Cc: Ramon

Re: [PATCH 2/2] net: phy: atheros: avoid error in ar803x_of_init() when PHY has no OF node

2022-03-02 Thread Ramon Fried
On Wed, Feb 23, 2022 at 3:21 PM Vladimir Oltean wrote: > > A DM_ETH driver may use phy_connect() towards a PHY address on an MDIO > bus which is not specified in the device tree, as evidenced by: > > pfe_eth_probe > -> pfe_phy_configure >-> phy_connect > > When this happens, the PHY will have

Re: [PATCH 1/2] net: phy: dp83867: avoid error in dp83867_of_init() when PHY has no OF node

2022-03-02 Thread Ramon Fried
On Wed, Feb 23, 2022 at 3:21 PM Vladimir Oltean wrote: > > A DM_ETH driver may use phy_connect() towards a PHY address on an MDIO > bus which is not specified in the device tree, as evidenced by: > > pfe_eth_probe > -> pfe_phy_configure >-> phy_connect > > When this happens, the PHY will have

[PATCH v7 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash

2022-03-02 Thread JaimeLiao
Adding Macronix Octal flash for Octal DTR support. The octaflash series can be divided into the following types: MX25 series : Serial NOR Flash. MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW

[PATCH v7 3/4] mtd: spi-nor: Parse SFDP SCCR Map

2022-03-02 Thread JaimeLiao
Parse SCCR 22nd dword and check DTR Octal Mode Enable Volatile bit for Octal DTR enable Signed-off-by: JaimeLiao --- drivers/mtd/spi/spi-nor-core.c | 52 ++ include/linux/mtd/spi-nor.h| 1 + 2 files changed, 53 insertions(+) diff --git

[PATCH v7 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset

2022-03-02 Thread JaimeLiao
Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from 8D-8D-8D in the begging of probe. Command extension type is not standardized across flash vendors in DTR mode. For suiting different vendor flash devices, adding a flag to seperate types for soft reset on boot.

[PATCH v7 1/4] mtd: spi-nor: add support for Macronix Octal flash

2022-03-02 Thread JaimeLiao
Follow patch (Allow using Micron mt35xu512aba in Octal DTR mode). Enable Octal DTR mode with 20 dummy cycles to allow running at the maximum supported frequency for adding Macronix flash in Octal DTR mode.

[PATCH v7 0/4] Add octal DTR support for Macronix flash

2022-03-02 Thread JaimeLiao
This series add support for Macronix octal DTR flash, add flag for Softreset with "INVERT" command extension type on boot and follow linux kernel to enable 4byte opcode when possible. v7: Correct title and description of patchworks. Correct description for spi_nor_macronix_octal_dtr_enable.

pull request of u-boot-fsl-qoriq for v2022.04

2022-03-02 Thread Priyanka Jain
Dear Tom, Please find my pull-request for u-boot-fsl-qoriq/master https://github.com/u-boot/u-boot/pull/132 Summary Update and fixes for sl28, lx2, pblimage generation for some powerpc products Regards Priyanka --- The following changes since commit a900c7f8161b74fc66ec715e68e7244b53f04298:

Re: [PATCH v2 10/10] cmd: rng: Add support for selecting RNG device

2022-03-02 Thread Simon Glass
Hi Sughosh, On Tue, 1 Mar 2022 at 21:56, Sughosh Ganu wrote: > > hi Simon, > > On Tue, 1 Mar 2022 at 20:29, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu wrote: > > > > > > The 'rng' u-boot command is used for printing a select number of > > > random

Re: [PATCH v2 06/10] configs: chromebook_coral: Build TPMV1 library routines

2022-03-02 Thread Simon Glass
Hi Sughosh, On Wed, 2 Mar 2022 at 11:12, Sughosh Ganu wrote: > > hi Simon, > > On Wed, 2 Mar 2022 at 21:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Tue, 1 Mar 2022 at 21:50, Sughosh Ganu wrote: > > > > > > hi Simon, > > > > > > On Tue, 1 Mar 2022 at 20:29, Simon Glass wrote: > > > >

Re: [PATCH v2 08/10] tpm: Add the RNG child device

2022-03-02 Thread Simon Glass
Hi Sughosh, On Tue, 1 Mar 2022 at 21:53, Sughosh Ganu wrote: > > hi Simon, > > On Tue, 1 Mar 2022 at 20:29, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu wrote: > > > > > > The TPM device comes with the random number generator(RNG) > > >

Re: [PATCH v2 04/10] tpm: Move the TPM version detection functions to the uclass driver

2022-03-02 Thread Simon Glass
Hi Sughosh, On Tue, 1 Mar 2022 at 21:40, Sughosh Ganu wrote: > > hi Simon, > > On Tue, 1 Mar 2022 at 20:29, Simon Glass wrote: > > > > On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu wrote: > > > > > > Make the TPM version detection functions as external symbols and move > > > them to the TPM

Re: [PATCH v2 07/10] tpm: rng: Move the TPM RNG functionality to driver model

2022-03-02 Thread Simon Glass
Hi Sughosh, On Tue, 1 Mar 2022 at 21:36, Sughosh Ganu wrote: > > hi Simon, > > On Tue, 1 Mar 2022 at 20:28, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu wrote: > > > > > > Currently, the TPM random number generator(RNG) functions are defined > > >

Re: [PATCH v6 12/16] tools: binman: add support for pre-load header

2022-03-02 Thread Simon Glass
Hi Philippe, On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > Adds the support of the pre-load header with the image signature > to binman. > > Signed-off-by: Philippe Reynes > --- > tools/binman/etype/pre_load.py| 165 ++ > tools/binman/ftest.py

Re: [PATCH v6 11/16] Makefile: provide sah-key to binman

2022-03-02 Thread Simon Glass
On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > Set the variable key-path with the shell variable > KEY_PATH that contain the keys path (used for signature). > This variable key-path is provided to binman. > > Signed-off-by: Philippe Reynes > --- > Makefile | 1 + > 1 file changed, 1

Re: [PATCH v6 07/16] boot: image: add a stage pre-load

2022-03-02 Thread Simon Glass
Hi Philippe, On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > Add a stage pre-load that could > check or modify an image. > > For the moment, only a header with a signature is > supported. This header has the following format: > - magic : 4 bytes > - version : 4 bytes > - header size : 4

Re: [PATCH v6 10/16] mkimage: add public key for image pre-load stage

2022-03-02 Thread Simon Glass
On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > This commit enhances mkimage to update the node > /image/pre-load/sig with the public key. > > Signed-off-by: Philippe Reynes > --- > include/image.h| 15 ++ > tools/fit_image.c | 3 ++ > tools/image-host.c | 114

Re: [PATCH v6 16/16] configs: sandbox_defconfig: enable config CMD_VERIFY

2022-03-02 Thread Simon Glass
On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > Enable the command verify on sandbox. > > Signed-off-by: Philippe Reynes > --- > configs/sandbox_defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass Please add documentation to doc/ Also, is it possible to do

Re: [PATCH v6 15/16] cmd: verify: initial import

2022-03-02 Thread Simon Glass
Hi Philippe, On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > Add the command verify that check the signature of > an image with the pre-load header. If the check > succeed, the u-boot env variable 'loadaddr_verified' > is set to the address of the image (without the header). > > It

Re: [PATCH v6 14/16] test: py: vboot: add test for global image signature

2022-03-02 Thread Simon Glass
Hi Philippe, On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > Adds test units for the pre-load header signature. > > Signed-off-by: Philippe Reynes > --- > test/py/tests/test_vboot.py | 125 +++--- > test/py/tests/vboot/sandbox-binman-pss.dts| 25

Re: [PATCH v6 13/16] configs: sandbox_defconfig: enable stage pre-load in bootm

2022-03-02 Thread Simon Glass
On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > Enable the support of stage pre-load in bootm. > For the moment, this stage allow to verify the > signature of the full image with a header. > > Signed-off-by: Philippe Reynes > --- > configs/sandbox_defconfig | 3 +++ > 1 file changed, 3

Re: [PATCH v6 04/16] lib: allow to build asn1 decoder and oid registry in SPL

2022-03-02 Thread Simon Glass
On Fri, 25 Feb 2022 at 07:58, Philippe Reynes wrote: > > This commit adds the options: > - SPL_ASN1_DECODER > - SPL_OID_REGISTRY > > Signed-off-by: Philippe Reynes > --- > lib/Kconfig | 19 +++ > lib/Makefile | 4 ++-- > 2 files changed, 21 insertions(+), 2 deletions(-)

Re: [PATCH v2 12/12] rockchip: fix boot_devices constants

2022-03-02 Thread Simon Glass
Hi Johan, On Mon, 28 Feb 2022 at 18:48, Johan Jonker wrote: > > The DT node name pattern in mmc-controller.yaml for mmc > is "^mmc(@.*)?$". The Rockchip mmc nodes have been synced > with Linux, so update the boot_devices constants as well. > > Signed-off-by: Johan Jonker > Reviewed-by: Simon

Re: [PATCH] patman: Define Commit.path in the constructor

2022-03-02 Thread Simon Glass
On Wed, 2 Mar 2022 at 19:12, Simon Glass wrote: > > It is good practice to init all variables in the constructor and pylint > sometimes checks this. Fix it. > > Signed-off-by: Simon Glass Reported-by: Tom Rini > --- > Example here: > >

[PATCH] patman: Define Commit.path in the constructor

2022-03-02 Thread Simon Glass
It is good practice to init all variables in the constructor and pylint sometimes checks this. Fix it. Signed-off-by: Simon Glass --- Example here: https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3733=logs =b31543ba-bf3a-552c-25a8-2f4df22f9328=093e08d5-0fd9-5b91-9d3b-fd9f41aee005

Re: [PATCH] driver: gpio: fix gpio glitch for output-high gpio-hog

2022-03-02 Thread Tim Harvey
On Wed, Mar 2, 2022 at 6:01 PM Tim Harvey wrote: > > A gpio-hog can be specified as output-low, output-high, or input where > output-low means 'de-asserted' and 'output-high' means asserted vs > voltage levels. > > When a hog is probed gpio_request_tail() calls dm_gpio_set_dir_flags() > which

[PATCH] driver: gpio: fix gpio glitch for output-high gpio-hog

2022-03-02 Thread Tim Harvey
A gpio-hog can be specified as output-low, output-high, or input where output-low means 'de-asserted' and 'output-high' means asserted vs voltage levels. When a hog is probed gpio_request_tail() calls dm_gpio_set_dir_flags() which ends up setting the GPIO as an output with a driven 'de-asserted'

Re: [PATCH v2 0/3] Add SPI boot to SPL on SUNIV/F1C100s

2022-03-02 Thread Andre Przywara
On Mon, 28 Feb 2022 23:42:13 -0500 Jesse Taube wrote: Hi, > Hey just checking if you know about this set. > > This patch adds the ability to detect the BROM's boot source, > > as well as the ability to boot from SPI. So I fixed two more things (FEL booting and reset), and massaged the first

[PATCH] sunxi: f1c100s: Drop SYSRESET to enable reset functionality

2022-03-02 Thread Andre Przywara
The F1C100s DT contains the wrong compatible string for the watchdog, which breaks reset functionality. Updating the DT goes via the Linux tree, but to allow reset functionality meanwhile (useful for development!), disable SYSRESET for now, to let the old-fashioned watchdog driver kick in and

Re: [PATCH v2 6/6] armv8: Fix and simplify branch_if_master/branch_if_slave

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 11:29:39AM +, Andre Przywara wrote: > The branch_if_master macro jumps to a label if the CPU is the "master" > core, which we define as having all affinity levels set to 0. To check > for this condition, we need to mask off some bits from the MPIDR > register, then

Re: [PATCH v2 5/6] armv8: Simplify switch_el macro

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 11:29:38AM +, Andre Przywara wrote: > The switch_el macro is a neat contraption to handle cases where we need > different code depending on the current exception level, but its > implementation was longer than needed. > > Simplify it by doing just one comparison, then

Re: [PATCH v2 4/6] arm: Clean up asm/io.h

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 11:29:37AM +, Andre Przywara wrote: > asm/io.h is the header file containing the central MMIO accessor macros. > Judging by the header and the comments, it was apparently once copied > from the Linux kernel, but has deviated since then *heavily*. There is > absolutely

Re: [PATCH v2 3/6] armv8: Force SP_ELx stack pointer usage

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 11:29:36AM +, Andre Przywara wrote: > In ARMv8 we have the choice between two stack pointers to use: SP_EL0 or > SP_ELx, which is banked per exception level. This choice is stored in > the SP field of PState, and can be read and set via the SPSel special > register.

Re: [PATCH v2 2/6] armv8: Always unmask SErrors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 11:29:35AM +, Andre Przywara wrote: > The ARMv8 architecture describes the "SError interrupt" as the fourth > kind of exception, next to synchronous exceptions, IRQs, and FIQs. > Those SErrors signal exceptional conditions from which the system might > not easily

Re: [PATCH v2 1/6] cmd: exception: arm64: fix undefined, add faults

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 11:29:34AM +, Andre Przywara wrote: > The arm64 version of the exception command was just defining the > undefined exception, but actually copied the AArch32 instruction. > > Replace that with an encoding that is guaranteed to be and stay > undefined. Also add

Re: [PATCH v2 23/25] rockchip: Support building the all output files in binman

2022-03-02 Thread Peter Geis
On Wed, Feb 23, 2022 at 6:04 PM Simon Glass wrote: > Good Evening, > Add the required binman images to replace the Makefile rules which are > currently used. This includes subsuming: > >- tpl/u-boot-tpl-rockchip.bin if TPL is enabled >- idbloader.img if either or both of SPL and TPL

Re: [PATCH] dt-bindings: mtd: partitions: add UBI binding

2022-03-02 Thread Rob Herring
On Thu, Feb 17, 2022 at 11:24:48AM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > UBI is often used on embedded devices to store UBI volumes with device > configuration / calibration data. Such volumes may need to be documented > and referenced for proper boot & setup. > > Some examples:

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-02 Thread Tony Dinh
Hi Pali, On Wed, Mar 2, 2022 at 1:03 PM Pali Rohár wrote: > > On Wednesday 02 March 2022 12:51:25 Tony Dinh wrote: > > Hi Pali, > > > > The patch did not apply cleanly to the master branch (I downloaded the > > series from patchwork). Do you have a link where I can use it? > > Hello, this patch

arm: Simple delay function because of an chicken and egg problem

2022-03-02 Thread Johannes (krjdev) Krottmayer
Hi, I'm running into an chicken and egg problem when modifying (fixing) some drivers for STMicroelectronics SoC's. The problem, I will implement a timeout, when accessing some registers. Unfortunately I cannot use the basic mdelay() or higher level functions, which use this function, because

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-02 Thread Pali Rohár
On Wednesday 02 March 2022 12:51:25 Tony Dinh wrote: > Hi Pali, > > The patch did not apply cleanly to the master branch (I downloaded the > series from patchwork). Do you have a link where I can use it? Hello, this patch series depends on following kwboot patch:

Re: [PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-02 Thread Tony Dinh
Hi Pali, The patch did not apply cleanly to the master branch (I downloaded the series from patchwork). Do you have a link where I can use it? Thanks, Tony On Wed, Mar 2, 2022 at 2:52 AM Pali Rohár wrote: > > This patch series fixes sending boot and debug patterns by doing it in > separate

Re: [PATCH] lib: rsa: use actual OpenSSL 1.1.0 EVP MD API

2022-03-02 Thread Yann Droneaud
Hi, Le 02/03/2022 à 02:10, Simon Glass a écrit : On Tue, 1 Mar 2022 at 08:12, Yann Droneaud wrote: Since OpenSSL 1.1.0, EVP_MD_CTX_create() is EVP_MD_CTX_new() EVP_MD_CTX_destroy() is EVP_MD_CTX_free() EVP_MD_CTX_init() is EVP_MD_CTX_reset() As

Re: [PATCH 9/9] Azure/GitLab CI: Add the pylint checker

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:26PM -0700, Simon Glass wrote: > Add a check that new Python code does not regress the pylint score for > any module. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 8/9] buildman: Update default config to build for sandbox

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:25PM -0700, Simon Glass wrote: > At present the default .buildman file written by buildman does not specify > a default toolchain. Add an 'other' line so this works correctly and > sandbox builds run as expected. > > Signed-off-by: Simon Glass Applied to

Re: [PATCH 7/9] Makefile: Add a way to check for pylint errors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:24PM -0700, Simon Glass wrote: > Add a new 'pylint_err' target which only reports errors, not warnings. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 6/9] test: Correct pylint errors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:23PM -0700, Simon Glass wrote: > Fix pylint errors in all test. > > This requires adding a get_spawn() method to the ConsoleBase base, so that > its subclass is happy. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc

Re: [PATCH 5/9] moveconfig: Correct pylint errors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:22PM -0700, Simon Glass wrote: > Fix two pylint errors in this file. > > Note ACTION_SPL_NOT_EXIST is not defined so the dead code can be removed. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 4/9] binman: Correct pylint errors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:21PM -0700, Simon Glass wrote: > Fix pylint errors that can be fixed and mask those that seem to be > incorrect. > > A complication with binman is that it tries to avoid importing libfdt > (or anything that imports it) unless needed, so that things like help > still

Re: [PATCH 3/9] dtoc: Correct pylint errors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:20PM -0700, Simon Glass wrote: > Fix pylint errors in this directory. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/9] buildman: Correct pylint errors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:19PM -0700, Simon Glass wrote: > Fix pylint errors that can be fixed and mask those that seem to be > incorrect. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/9] patman: Correct pylint errors

2022-03-02 Thread Tom Rini
On Fri, Feb 11, 2022 at 01:23:18PM -0700, Simon Glass wrote: > Fix pylint errors that can be fixed and mask those that seem to be > incorrect. > > Signed-off-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 06/10] configs: chromebook_coral: Build TPMV1 library routines

2022-03-02 Thread Sughosh Ganu
hi Simon, On Wed, 2 Mar 2022 at 21:02, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 1 Mar 2022 at 21:50, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Tue, 1 Mar 2022 at 20:29, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu > > > wrote:

Re: [PATCH v2] drivers: adc: fix return value if timeout occurs

2022-03-02 Thread Michael Nazzareno Trimarchi
Hi On Tue, Mar 1, 2022 at 9:23 PM Francois Berder wrote: > > Because unsigned integers cannot be negative, > timeout variable is never less than zero. Hence, checks > in Amlogic Meson ADC driver to detect timeouts always > evaluated to false. Fix that. > > Signed-off-by: Francois Berder > --- >

drivers: clk: stm32h7: Endless loop of dead in driver probe function

2022-03-02 Thread Johannes (krjdev) Krottmayer
Hi, Some IMHO fatal issues in the the clock driver for the STM32H7 series driver. Affected driver: drivers/clk/clk_stm32h7.c Affected configs (boards): configs/stm32h750-art-pi_defconfig configs/stm32h743-disco_defconfig configs/stm32h743-eval_defconfig Description: The driver currently

[PATCH] bootcount: clarify documentation

2022-03-02 Thread Michael Opdenacker
- Grammar fixes - Clarify explanations Signed-off-by: Michael Opdenacker --- doc/README.bootcount | 34 ++ drivers/bootcount/Kconfig | 10 +- 2 files changed, 23 insertions(+), 21 deletions(-) diff --git a/doc/README.bootcount b/doc/README.bootcount

[PATCH] drivers: led: bcm6858: Set default brightness when setting LED state

2022-03-02 Thread Paul HENRYS
When setting the LED state (OFF, ON or blinking), the default maximum brightness is set for ON and blinking state and the brightness is set to 0 for OFF state. This should make sure the LED controller's registers affecting the brightness are correctly initialized and should give consistent

Re: [PATCH v2 0/6] Exception handling in HYP mode on ARMv7-A

2022-03-02 Thread Tom Rini
On Wed, Nov 24, 2021 at 02:39:55PM -0500, Jim Posen wrote: > Currently, when U-Boot is running in hypervisor mode on ARMv7-A CPUs > with virtualization extensions, the exception handling does not work. > A couple things need to change which are detailed in my earlier > message to the u-boot

Re: [PATCH v2 06/10] configs: chromebook_coral: Build TPMV1 library routines

2022-03-02 Thread Simon Glass
Hi Sughosh, On Tue, 1 Mar 2022 at 21:50, Sughosh Ganu wrote: > > hi Simon, > > On Tue, 1 Mar 2022 at 20:29, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu wrote: > > > > > > The TPM code currently does a runtime detection of the TPM version and > > >

arm: stm32h7: Support for the STM32H747I-DISCO board

2022-03-02 Thread Johannes (krjdev) Krottmayer
Hi, I want add support for STM32H747I-DISCO from STMicroelectronics, for the purpose of education. Want to use U-Boot as boot-loader for my projects. Here you the official website from the board: https://www.st.com/en/evaluation-tools/stm32h747i-disco.html But there some issues on the website:

[PATCH] arm64: zynqmp: add support for zcu106 rev1.0

2022-03-02 Thread Michal Simek
From: Neal Frager This patch adds psu_init for Xilinx ZCU106 rev1.0. Xilinx ZCU106 rev1.0 has newer x16 DDR4 memories and it is SW compatible with revA. Signed-off-by: Neal Frager Signed-off-by: Michal Simek --- arch/arm/dts/Makefile | 1 +

[PATCH v6 2/2] sf: Query write-protection status before operating the flash

2022-03-02 Thread Jan Kiszka
From: Jan Kiszka Do not suggest successful operation if a flash area to be changed is actually locked, thus will not execute the request. Rather report an error and bail out. That's way more user-friendly than asking them to manually check for this case. Derived from original patch by Chao

[PATCH v6 1/2] mtd: spi: Convert is_locked callback to is_unlocked

2022-03-02 Thread Jan Kiszka
From: Jan Kiszka There was no user of this callback after 5b66fdb29dc3 anymore, and its semantic as now inconsistent between stm and sst26. What we need for the upcoming new usecase is a "completely unlocked" semantic. So consolidate over this. Signed-off-by: Jan Kiszka ---

[PATCH v6 0/2] sf: Check protection before writing/erasing flash

2022-03-02 Thread Jan Kiszka
Changes in v6: - fixed embarrassingly inverted logic in unlock check (and properly tested it this time) Changes in v5: - adjust unused is_locked callback to our is_unlocked needs - use this callback in sf command instead Jan Jan Kiszka (2): mtd: spi: Convert is_locked callback to

Re: [PATCH u-boot-marvell 8/8] arm: mvebu: turris_omnia: Add support for USB3.0 mode in WWAN MiniPCIe slot

2022-03-02 Thread Marek Behún
On Wed, 2 Mar 2022 12:47:58 +0100 Pali Rohár wrote: > PCIe Mini CEM 2.1 spec added support for USB3.0 mode on MiniPCIe cards. > USB3.0 and PCIe share same pins and only one function can be active at the > same time. PCIe Mini CEM 2.1 spec says that determining function is > platform specific

Re: [PATCH u-boot-marvell 6/8] arm: mvebu: turris_omnia: Extract code for disabling sata/pcie

2022-03-02 Thread Marek Behún
On Wed, 2 Mar 2022 12:47:56 +0100 Pali Rohár wrote: > Move code for disabling sata and pcie DT nodes to own functions, so this > code can be called from other places in follow up patches. > > Signed-off-by: Pali Rohár > --- > board/CZ.NIC/turris_omnia/turris_omnia.c | 96

Re: [PATCH u-boot-marvell 2/8] arm: mvebu: turris_omnia: Provide env_sf_get_env_addr() function

2022-03-02 Thread Marek Behún
On Wed, 2 Mar 2022 12:47:52 +0100 Pali Rohár wrote: > BootROM maps SPI Flash to fixed address 0xD400 and this mapping is > active also when BootROM is executing binary kwbimage headers, which > includes also U-Boot SPL. > > Therefore no initialization code is required to access SPI Flags

Re: [PATCH u-boot-marvell 5/8] arm: mvebu: turris_omnia: Allow to configure mSATA slot via env variable

2022-03-02 Thread Marek Behún
> { > - if (omnia_detect_sata()) { > +#ifdef CONFIG_SPL_ENV_SUPPORT > + /* Do not use env_load() as malloc() pool is too small at this stage */ > + bool has_env = (env_init() == 0); > +#endif > + const char *env_value = NULL; > + > +#ifdef CONFIG_SPL_ENV_SUPPORT > + /* beware

[PATCH u-boot-marvell 8/8] arm: mvebu: turris_omnia: Add support for USB3.0 mode in WWAN MiniPCIe slot

2022-03-02 Thread Pali Rohár
PCIe Mini CEM 2.1 spec added support for USB3.0 mode on MiniPCIe cards. USB3.0 and PCIe share same pins and only one function can be active at the same time. PCIe Mini CEM 2.1 spec says that determining function is platform specific and spec does not define any dedicated pin which could say if

[PATCH u-boot-marvell 7/8] arm: mvebu: turris_omnia: Signal error when sata/pcie DT mode

2022-03-02 Thread Pali Rohár
Show error message when DT file does not contain sata or pcie node which should be explicitly disabled. This can happen when U-Boot code for finding those nodes is incomplete or when those DT nodes are in different unexpected location. In any case it is needed to know if DT not was not explicitly

[PATCH u-boot-marvell 5/8] arm: mvebu: turris_omnia: Allow to configure mSATA slot via env variable

2022-03-02 Thread Pali Rohár
Some PCIe-based MiniPCIe cards are broken and they do not ground PIN 43 which is required by PCIe mini CEM specs. Such broken cards are incorrectly detected as mSATA cards because SATA specs requires that PIN 43 on mSATA cards has to be disconnected. PIN 43 on Turris Omnia is used only for

[PATCH u-boot-marvell 6/8] arm: mvebu: turris_omnia: Extract code for disabling sata/pcie

2022-03-02 Thread Pali Rohár
Move code for disabling sata and pcie DT nodes to own functions, so this code can be called from other places in follow up patches. Signed-off-by: Pali Rohár --- board/CZ.NIC/turris_omnia/turris_omnia.c | 96 +--- 1 file changed, 52 insertions(+), 44 deletions(-) diff --git

[PATCH u-boot-marvell 3/8] arm: mvebu: turris_omnia: Enable ENV support in SPL

2022-03-02 Thread Pali Rohár
Allow to read ENV variables also in SPL on Turris Omnia. Signed-off-by: Pali Rohár --- configs/turris_omnia_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig index 280dd55f001b..9f633583022c 100644 ---

[PATCH u-boot-marvell 4/8] arm: mvebu: turris_omnia: Define only one serdes map variable

2022-03-02 Thread Pali Rohár
By default use primary serdes map with PCIe function in combined miniPCIe/mSATA slot. When SATA is detected change serdes map variable at runtime. Signed-off-by: Pali Rohár --- board/CZ.NIC/turris_omnia/turris_omnia.c | 23 --- 1 file changed, 8 insertions(+), 15

[PATCH u-boot-marvell 1/8] env: sf: Allow to use env_sf_init_addr() at any stage

2022-03-02 Thread Pali Rohár
In some cases it makes sense to use env_sf_init_addr() also in SPL mode. Allow it for boards by providing custom implementation of weak function env_sf_get_env_addr(). When this function returns NULL it signals that address is invalid, like config option CONFIG_ENV_ADDR. There is no change in

[PATCH u-boot-marvell 2/8] arm: mvebu: turris_omnia: Provide env_sf_get_env_addr() function

2022-03-02 Thread Pali Rohár
BootROM maps SPI Flash to fixed address 0xD400 and this mapping is active also when BootROM is executing binary kwbimage headers, which includes also U-Boot SPL. Therefore no initialization code is required to access SPI Flags from U-Boot SPL. In proper U-Boot it is remapped to other

[PATCH u-boot-marvell 0/8] Turris Omnia: Add support for configuring mSATA and WWAN slots via env variables

2022-03-02 Thread Pali Rohár
Some mPCIe cards are broken and their PIN 43 incorrectly that card is mSATA. U-Boot SPL on Turris Omnia is using PIN 43 for configuring PCIe vs SATA functionality on SerDes. Allow to configure functionality via additional env variable "omnia_msata_slot" which may override PIN 43. To force PCIe

Re: [PATCH] .mailmap: Record all address for main U-Boot contributor

2022-03-02 Thread Bin Meng
On Tue, Mar 1, 2022 at 7:43 PM Michal Simek wrote: > > Based on looking at top contributors it was seen that top statistics from > top contributors don't include all contributions from different email > addresses. That's why I checked all top contributors are checked it. > > git shortlog -n

[PATCH u-boot-marvell 10/10] tools: kwboot: Update references with public links

2022-03-02 Thread Pali Rohár
Public documents about BootROM of some Marvell SoCs are available in the public Web Archive. Put this information into source code. Signed-off-by: Pali Rohár --- tools/kwboot.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/tools/kwboot.c

[PATCH u-boot-marvell 09/10] tools: kwboot: Update doc about Avanta

2022-03-02 Thread Pali Rohár
Testes proved that current kwboot version supports also Avanta SoCs. It looks like that Avanta SoCs are using same kwbimage format as Armada. Signed-off-by: Pali Rohár Tested-by: Tony Dinh --- doc/kwboot.1 | 2 +- tools/kwboot.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH u-boot-marvell 08/10] tools: kwboot: Update manpage

2022-03-02 Thread Pali Rohár
Document -D, -b, -d, -q and -s options. Add common examples how to use kwboot. Add information about Armada 38x BootROM bug for debug console mode and how to workaround it. Signed-off-by: Pali Rohár --- doc/kwboot.1 | 103 +-- 1 file changed, 99

[PATCH u-boot-marvell 05/10] tools: kwboot: Fix sending and processing debug message pattern (-d option)

2022-03-02 Thread Pali Rohár
-d option is currently broken. In most cases BootROM does not detect this message pattern. For sending debug message pattern it is needed to do same steps as for boot message pattern. Implement sending debug message pattern via same separate thread like it is for boot message pattern. Checking

[PATCH u-boot-marvell 07/10] tools: kwboot: Update usage

2022-03-02 Thread Pali Rohár
Add all supported Armada SoCs and document -b and -d options in usage. Signed-off-by: Pali Rohár --- tools/kwboot.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/kwboot.c b/tools/kwboot.c index 26cfe6dea6a7..11aca00bf1e6 100644 --- a/tools/kwboot.c +++

[PATCH u-boot-marvell 06/10] tools: kwboot: Add support for backspace key in mini terminal

2022-03-02 Thread Pali Rohár
Marvell BootROM recognize only '\b' byte as backspace. Use terminfo for retrieving current backspace sequence and replace any occurrence of backspace sequence by the '\b' byte. Reading terminfo database is possible via tigetstr() function from system library libtinfo.so.*. So link kwboot with

[PATCH u-boot-marvell 00/10] tools: kwboot: Fix boot and terminal mode

2022-03-02 Thread Pali Rohár
This patch series fixes sending boot and debug patterns by doing it in separate thread. Entering BootROM debug mode via '-d' option is now more stable and working fine on Armada 385. There is also support for backspace key and updated documentation. Stefan and Tony, could you test this patch

[PATCH u-boot-marvell 03/10] tools: kwboot: Cleanup bootmsg and debugmsg variables

2022-03-02 Thread Pali Rohár
Function kwboot_debugmsg() is always called with kwboot_msg_debug as msg and function kwboot_bootmsg() with kwboot_msg_debug as msg. Function kwboot_bootmsg() is never called with NULL msg. Simplify, cleanup and remove dead code. No functional change. Signed-off-by: Pali Rohár ---

[PATCH u-boot-marvell 02/10] tools: kwboot: Remove msg_req_delay

2022-03-02 Thread Pali Rohár
Variable msg_req_delay is set but never used. So completely remove it. Signed-off-by: Pali Rohár --- tools/kwboot.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/kwboot.c b/tools/kwboot.c index 5a7c53ce8929..4dfb1038b4ff 100644 --- a/tools/kwboot.c +++

[PATCH u-boot-marvell 04/10] tools: kwboot: Use separate thread for sending boot message pattern

2022-03-02 Thread Pali Rohár
After BootROM successfully detects boot message pattern on UART it waits until host stop sending data on UART. For example Armada 385 BootROM requires that host does not send anything on UART at least 24 ms. If host is still sending something then BootROM waits (possibly infinitely). BootROM

[PATCH u-boot-marvell 01/10] tools: kwboot: Check for return value of kwboot_tty_send() and tcflush()

2022-03-02 Thread Pali Rohár
Failure of kwboot_tty_send() and tcflush() functions is fatal, it does not make sense to continue. So return error back to the caller like in other places where are called these functions. Signed-off-by: Pali Rohár --- tools/kwboot.c | 30 +++--- 1 file changed, 19

Re: [PATCH 2/2] efi_loader: use short-form DP for load options

2022-03-02 Thread AKASHI Takahiro
On Sat, Feb 26, 2022 at 12:56:51PM +0100, Heinrich Schuchardt wrote: > The GUID of partitions is sufficient for identification and will stay > constant in the lifetime of a boot option. The preceding path of the > device-path may change due to changes in the enumeration of devices. > Therefore it

[PATCH 2/2] doc: boards: amlogic: Add documentation on pre-generated FIP files

2022-03-02 Thread Neil Armstrong
It add documentation on licencing & provides links to the amlogic-boot-fip pre-built files collections. Signed-off-by: Neil Armstrong --- doc/board/amlogic/beelink-gtking.rst| 2 + doc/board/amlogic/beelink-gtkingpro.rst | 2 + doc/board/amlogic/index.rst | 8 +++

[PATCH 1/2] doc: board: amlogic-p20x: fix FIP generation doc

2022-03-02 Thread Neil Armstrong
The doc used GXL instructions, which couldn't work on GXBB SoCs. Signed-off-by: Neil Armstrong --- doc/board/amlogic/p200.rst | 57 +- doc/board/amlogic/p201.rst | 57 +- 2 files changed, 52 insertions(+), 62 deletions(-)

[PATCH] bosch: Add inital board support for ACC

2022-03-02 Thread Philip Oberfichtner
The Bosch ACC (Air Center Control) Board is based on the i.MX6D. Signed-off-by: Philip Oberfichtner --- This board supports depends on: - "Add pmic bootcount driver", patchwork id 287976 - "crypto/fsl: Fallback to SW sha1/256 is misaligned buffers", patchwork id 270524 ---