On 2023-07-06 01:27, Stefan Agner wrote:
> On 2023-07-02 22:47, Jonas Karlman wrote:
>> Hardkernel ODROID-M1 is a single board computer with a RK3568B2 SoC,
>> a slightly modified version of the RK3568 SoC.
>>
>> Features tested on a ODROID-M1 8GB v1.0 2022-06-13:
>> - SD-card boot
>> - eMMC boot
* Tom Rini [230703 16:22]:
> On Mon, Jul 03, 2023 at 07:12:47PM +0300, Roger Quadros wrote:
> > Linux DT files are correct. USB0 is a dual-role port so it sets it to 'otg'.
> > u-boot doesn't support 'otg' so we need to override it to 'peripheral' in
> > -u-boot.dtsi
>
> Ah, thanks, that was
> -Original Message-
> From: Luca Ellero
> Sent: 2023年7月5日 20:56
> To: u-boot@lists.denx.de; sba...@denx.de; feste...@gmail.com; dl-uboot-imx
> ; luca.ell...@brickedbrain.com; Ye Li ;
> Peng Fan ; Bough Chen
> Cc: Luca Ellero
> Subject: [PATCH 1/2] dm: adc: add iMX93 ADC support
>
>
Hi,
On Wed, Jul 05, 2023 at 01:24:32PM +, Neil Jones wrote:
> >> Please can someone describe the format of the file needed for the default
> >> / built-in EFI secure boot keys (ubootefi.var)
> >>
> >> The only docs I have found suggest its best to enroll the keys from within
> >> u-boot
On Sun, 02 Jul 2023 00:10:01 +0100, Conor Dooley wrote:
> intro
> =
>
> When the RISC-V dt-bindings were accepted upstream in Linux, the base
> ISA etc had yet to be ratified. By the ratification of the base ISA,
> incompatible changes had snuck into the specifications - for example the
>
On 2023-07-02 22:47, Jonas Karlman wrote:
> Hardkernel ODROID-M1 is a single board computer with a RK3568B2 SoC,
> a slightly modified version of the RK3568 SoC.
>
> Features tested on a ODROID-M1 8GB v1.0 2022-06-13:
> - SD-card boot
> - eMMC boot
> - SPI Flash boot
> - PCIe/NVMe/AHCI
> - SATA
In case the i.MX8M Plus starts from eMMC BOOT1/BOOT2 HW partitions, the
flash.bin container is stored at offset 0 from the start, that means the
fitImage itb is at offset 0x2c0 instead of 0x300 sectors from the start.
Handle this difference in custom spl_mmc_get_uboot_raw_sector() .
On 2023-07-05 18:24, Jonas Karlman wrote:
> Hi Stefan,
> On 2023-07-05 18:16, Stefan Agner wrote:
>> Add ODROID-M1 board support. Board device tree rk3568-odroid-m1.dts
>> from v6.4.
>
> I sent out a series that add support for ODROID-M1 a few days ago.
> Please see
Hi Bhupesh,
On 2023-07-05 06:48, Bhupesh Sharma wrote:
> Hi Jonas,
>
> On Mon, 3 Jul 2023 at 01:18, Jonas Karlman wrote:
>>
>> On 2023-07-02 20:47, Bhupesh Sharma wrote:
>>> Since function 'phy_get_counts()' can return NULL,
>>> add handling for that error path inside callers of
>>> this
Hello everyone,
currently I have the Microchip SAM9X60-Curiosity board on my desk and
for evaluation purposes I'm trying to get it booting from NAND flash
without SD card. This series contains a collection of patches I made on
that journey. It's probably not the last set of patches, but I send
From: Alexander Dahl
- nodes moved
- using node references by label instead of dulicating the node tree
Makes it easier to compare with the dts file from Linux kernel.
Signed-off-by: Alexander Dahl
---
.../dts/at91-sam9x60_curiosity-u-boot.dtsi| 8 +-
From: Alexander Dahl
Basically the same as on sam9x60-ek. Same as in Linux. NAND flash is
correctly detected when booting into U-Boot:
U-Boot 2023.07-rc6-5-g12719f75dc-dirty (Jul 05 2023 - 13:06:35 +)
CPU: SAM9X60 128MiB DDR2 SiP
Crystal frequency: 24 MHz
CPU
From: Alexander Dahl
The user guide says it's a Microchip 24AA025E48 serial EEPROM, which is
a 2-Kbit I2C Serial EEPROM with EUI-48™ Identity. This is the chip
actually populated on board EV40E67A rev 4.
Signed-off-by: Alexander Dahl
---
Notes:
Sadly this did not fix the problem, that I
From: Alexander Dahl
No functional changes, but this:
- reorder nodes (ordered by memory offset as in Linux)
- add label to pinctrl node name for easier reference in board files
- fix whitespace
Diff to sam9x60.dtsi in Linux is much better readable now.
Signed-off-by: Alexander Dahl
---
From: Alexander Dahl
There's a more specific compatible string for the i2c interface, use it.
Signed-off-by: Alexander Dahl
---
Notes:
I²C access to the eeprom did not work though, neither before nor after
this change.
arch/arm/dts/at91-sam9x60_curiosity.dts | 2 +-
On Tue, 04 Jul 2023 22:18:09 +0200, Heinrich Schuchardt wrote:
> Compiling on armv7 results in:
>
> tools/renesas_spkgimage.c: In function ‘spkgimage_parse_config_line’:
> tools/renesas_spkgimage.c:76:66: warning: format ‘%ld’ expects
> argument of type ‘long int’, but argument 3 has type
Current 1866MHz sdram config is too high for NanoPC-T4.
On this frequency, its lpddr3 sdram becomes unstable,
causing memtest failures and random kernel crashes.
Signed-off-by: Lu jicong
---
arch/arm/dts/rk3399-nanopc-t4-u-boot.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Wed, Jul 5, 2023 at 1:31 PM Anne Macedo wrote:
> I think I'm on the right path :)
>
> 1. Included SUNXI_SETUP_REGULATORS=0 to the bl31 make
> 2. Changed the phy mode on arch/arm/dts/sun50i-h6-orangepi-one-plus.dts
>From rgmii-id to rgmii
This does not look like the correct fix. Please
On Wed, Jul 05, 2023 at 01:31:28PM -0300, Anne Macedo wrote:
> On Wed, Jul 05, 2023 at 03:24:23PM +, Anne Macedo wrote:
> > On Wed, Jul 05, 2023 at 10:46:25AM -0300, Fabio Estevam wrote:
> > > Hi Anne,
> > >
> > > On Tue, Jul 4, 2023 at 8:52 PM Anne Macedo wrote:
> > > >
> > > > Hey!
> > > >
On Wed, Jul 05, 2023 at 03:24:23PM +, Anne Macedo wrote:
> On Wed, Jul 05, 2023 at 10:46:25AM -0300, Fabio Estevam wrote:
> > Hi Anne,
> >
> > On Tue, Jul 4, 2023 at 8:52 PM Anne Macedo wrote:
> > >
> > > Hey!
> > >
> > > I'm trying to bake Linux images for the Orange Pi One Plus using
Hi Stefan,
On 2023-07-05 18:16, Stefan Agner wrote:
> Add ODROID-M1 board support. Board device tree rk3568-odroid-m1.dts
> from v6.4.
I sent out a series that add support for ODROID-M1 a few days ago.
Please see https://patchwork.ozlabs.org/project/uboot/list/?series=362045
Regards,
Jonas
>
>
Add ODROID-M1 board support. Board device tree rk3568-odroid-m1.dts
from v6.4.
Signed-off-by: Stefan Agner
---
arch/arm/dts/Makefile | 1 +
arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi | 29 +
arch/arm/dts/rk3568-odroid-m1.dts | 744 ++
On Tue, Jul 04, 2023 at 02:13:01PM -0300, Fabio Estevam wrote:
> On 04/07/2023 14:04, Francesco Dolcini wrote:
>
> > The boards that do not check the return value might start to behave
> > wrongly without an obvious error to help the debugging.
>
> Yes, the current implementation of
On Tue, 04 Jul 2023 14:09:45 -0300, Fabio Estevam wrote:
> For changing the USB OTG node status from "okay" to "disabled" more
> space is needed, so call fdt_increase_size() to avoid the following
> error:
>
> ```
> U-Boot 2023.07-rc5-0.0.0-devel+git.580eb31199be (Jun 27 2023 - 13:39:58
>
On Tue, 04 Jul 2023 14:25:36 +0300, Eugen Hristev wrote:
> add my patchwork alias
>
>
Applied to u-boot/master, thanks!
--
Tom
On Wed, Jul 05, 2023 at 10:46:25AM -0300, Fabio Estevam wrote:
> Hi Anne,
>
> On Tue, Jul 4, 2023 at 8:52 PM Anne Macedo wrote:
> >
> > Hey!
> >
> > I'm trying to bake Linux images for the Orange Pi One Plus using Yocto.
> > Everything works fine, except for Ethernet.
> >
> > On the u-boot
Just add inital doc.
Signed-off-by: Maxim Uvarov
---
doc/develop/index.rst| 1 +
doc/develop/net_lwip.rst | 59
2 files changed, 60 insertions(+)
create mode 100644 doc/develop/net_lwip.rst
diff --git a/doc/develop/index.rst
This commit adds lwip library for the U-boot network
stack. Supported commands: ping, tftp, dhcp and wget.
Signed-off-by: Maxim Uvarov
---
.gitignore| 9 +
boot/bootmeth_pxe.c | 2 +-
cmd/net.c | 48 +
cmd/pxe.c
This commit adds the lwip library as a git submodule. I think
there has to be advantages to compile lwip inside U-boot,
i.e. use the same compiler and flags as the main code.
One of them is LTO and the other is to enable additional debug
options for network protocol during development. Also we can
changelog:
v3: - use lwip commands for ping,tftp,wget,dhcp if this patch
applied. Drop CONFIG_LIB_LWIP_REPLACE_ option.
- docs: use rst variant and drop references to RFC.
build:
git submodule init
git submodule update
make
I tested with
Flushing kernel image after decompression was taking 113 milliseconds
with U-boot 2022.10. With U-boot 2023.01 and 2023.04, flushing
the same amount of memory takes approx 1.5 seconds. With
U-boot 2023.07-rc6, it takes 6.5 seconds.
powerpc flush_cache() function used to call WATCHDOG_RESET()
Hi Anne,
On Tue, Jul 4, 2023 at 8:52 PM Anne Macedo wrote:
>
> Hey!
>
> I'm trying to bake Linux images for the Orange Pi One Plus using Yocto.
> Everything works fine, except for Ethernet.
>
> On the u-boot prompt:
>
> => dhcp
> No ethernet found.
>
> After adding:
>
> CONFIG_SPL_SPI_SUNXI=y
>
>> Please can someone describe the format of the file needed for the default /
>> built-in EFI secure boot keys (ubootefi.var)
>>
>> The only docs I have found suggest its best to enroll the keys from within
>> u-boot onto some removable media, then copy this off and use this as the
>> default,
On Tue, Jul 04, 2023 at 04:25:55PM +0900, Jaehoon Chung wrote:
> Dear Tom,
>
> Please pull u-boot-pmic next into u-boot next branch.
> If there is a problem, let me know, plz.
>
> Best Regards,
> Jaehoon Chung
>
> CI: https://source.denx.de/u-boot/custodians/u-boot-pmic/-/pipelines/16767
>
>
On Wed, Jul 05, 2023 at 06:33:43PM +0530, Nikhil M Jain wrote:
> Hi Tom,
>
> Gentle reminder
>
> On 21/06/23 15:51, Nikhil M Jain wrote:
> > This patch series aims at updating SPL splashscreen framework for AM62x.
> >
> > This patch series depends on
> >
In case CC_OPTIMIZE_FOR_DEBUG is set, unused code will not be optimized out,
hence the reference to fpga_load will be compiled.
if DM_FPGA and SPL_FPGA are not set, the build will fail with :
aarch64-none-linux-gnu-ld.bfd: common/spl/spl_fit.o: in function
`spl_fit_upload_fpga':
Hi Tom,
Gentle reminder
On 21/06/23 15:51, Nikhil M Jain wrote:
This patch series aims at updating SPL splashscreen framework for AM62x.
This patch series depends on
https://lore.kernel.org/u-boot/20230504225829.2537050-1-...@chromium.org/
This series:
- Fixes compilation issues in case
iMX93 ADC features:
- 4 channels
- 12 bit resolution
Signed-off-by: Luca Ellero
---
configs/imx93_11x11_evk_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/imx93_11x11_evk_defconfig
b/configs/imx93_11x11_evk_defconfig
index 89edebc4c6..30ef460c80 100644
---
This commit adds driver for iMX93 ADC.
The driver is implemented using driver model and provides
ADC uclass's methods for ADC single channel operations:
- adc_start_channel()
- adc_channel_data()
- adc_stop()
ADC features:
- channels: 4
- resolution: 12-bit
Signed-off-by:
Add ADC support for NXP iMX93
Changes for v2:
- add "static" to functions
- enable ADC in iMX93 EVK
Changes for v3:
- split in 3 commits
- keep dts file in sync with Linux devicetree
- add comments to commits
Changes for v4:
- add imx93_adc_power_down() in imx93_adc_stop()
Changes for v5:
-
On Wed, Jul 05, 2023 at 12:08:30PM +, Anne Macedo wrote:
> On Wed, Jul 05, 2023 at 11:26:45AM +0100, Christopher Obbard wrote:
> > Hi Anne,
> >
> > [please don't forget to CC the list, in case someone else
> > has the same issue in future they don't miss the context ;-)]
> >
> > On Wed,
Enable measuring test coverage for buildman so we can see the gaps. It is
currently at 68%.
Signed-off-by: Simon Glass
---
Changes in v2:
- Drop patch to move -A logic up a little (since it breaks it)
tools/buildman/cmdline.py | 2 ++
tools/buildman/main.py | 15
This is useful for some tools and is easily available for buildman. Add
a new --print-arch option.
Signed-off-by: Simon Glass
---
Changes in v2:
- Add new patch to print the architecture for a board
tools/buildman/cmdline.py | 2 ++
tools/buildman/control.py | 24
This does not need to be in the class. Move it out to avoid a pylint
warning.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 47 +
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git
Make sure all functions have full argument documentation.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 66 ++---
1 file changed, 36 insertions(+), 30 deletions(-)
diff --git a/tools/buildman/builderthread.py
Provide the text of the exception when something goes wrong.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 7 +--
tools/buildman/func_test.py | 6 --
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git
Move the creating of the result object into the function which sets it
up, to simplify the code.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git
Move this code into a _config_and_build() function, so reduce the size of
run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 97 +
1 file changed, 61 insertions(+), 36 deletions(-)
diff --git
Put this in its own function to reduce the size of the run_commit()
function
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/tools/buildman/builderthread.py
Put this in its own function to reduce the size of the run_commit()
function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 34 -
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git
Put this in its own function to reduce the size of the run_commit()
function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/tools/buildman/builderthread.py
Move this logic into its own function to reduce the size of the
run_commt() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 66 +
1 file changed, 42 insertions(+), 24 deletions(-)
diff --git
Split this into its own function so reduce the size of run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 40 -
1 file changed, 30 insertions(+), 10 deletions(-)
diff --git a/tools/buildman/builderthread.py
Split this into its own function so reduce the size of run_commit().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 41 -
1 file changed, 30 insertions(+), 11 deletions(-)
diff --git a/tools/buildman/builderthread.py
This is probably a little more efficient and it allows passing the object
to another function to write data. Convert config_out to use a string I/O
device.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 9 +
1 file changed, 5 insertions(+), 4
Move more of the argument-building code into this function. Fix a missing
assignment for out_rel_dir too.
Rename the function since it now builds all the arguments.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 55 -
1
Move a few more pieces to this new function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index
Move some of this code into a new funciion, to help reduce the size of the
run_commits() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 38 -
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git
This is already set up earlier in the function, so drop the extra
assignment.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index
This variable has a different meaning in the outer scrop. Use a different
name to avoid confusion, or bugs.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Make this a public memory since it is used outside the class.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 8
tools/buildman/builderthread.py | 2 +-
tools/buildman/test.py | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
Fix the easy warnings in this file.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builderthread.py | 95 ++---
1 file changed, 51 insertions(+), 44 deletions(-)
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 228
tools/buildman/builderthread.py | 26 ++--
tools/buildman/control.py | 13 +-
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 8 +++---
tools/buildman/builderthread.py | 50 -
2 files changed, 29 insertions(+), 29 deletions(-)
diff
Split this into two functions to avoid a warning about too many
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 44 +--
1 file changed, 33 insertions(+), 11 deletions(-)
diff --git a/tools/buildman/cmdline.py
Use argparse to parse the arguments, since OptionParser is deprecated now.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 125
tools/buildman/control.py | 140 ++--
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/bsettings.py | 14 +++---
tools/buildman/control.py | 2 +-
tools/buildman/func_test.py | 12 ++--
tools/buildman/main.py | 2 +-
Add a simple functional test for the --boards option. Fix the example in
the docs while we are here. Also improve the docs for Builder.count so it
is clearer what it contains.
Signed-off-by: Simon Glass
---
Changes in v2:
- Use snake case for tests
tools/buildman/builder.py | 3 ++-
Tidu up warnings in this file.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/cmdline.py b/tools/buildman/cmdline.py
index 3066a0b38bbf..91571a5adb1d 100644
---
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/cmdline.py | 2 +-
tools/buildman/func_test.py | 2 +-
tools/buildman/main.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Move this code into a function. This removes the last pylint error in
the control module.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 34 +-
1 file changed, 25 insertions(+), 9 deletions(-)
diff --git
Avoid an unnecessary local variable by moving this code to a function.
This fixes the pylint warning about too many local variables.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
Move this into its own function to reduce the size of do_buildman().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 38 +++---
1 file changed, 27 insertions(+), 11 deletions(-)
diff --git a/tools/buildman/control.py
This is not needed until the builder is run. Move it there to reduce the
size of the do_buildman() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git
This function does not need to return. Simplify the code by exiting
immediately.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
Move setting of show_bloat to adjust_options() and adjust how the commits
variable is set. Together these remove the pylint warning about too many
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 13 +
1 file changed, 5 insertions(+), 8
Drop some variables at the end of the do_bulidman() function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index
Move this code into a new function. This removes the pylint warning about
too many branches.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 56 ---
1 file changed, 35 insertions(+), 21 deletions(-)
diff --git
Do these all in the constructor, so it is consistent.
Move the stray builder comment into the correct place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/builder.py | 25 ++---
tools/buildman/control.py | 18 +++---
2 files changed, 25
Move this code into a separate function to reduce the size of the main
do_buildman() directory.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 45 ---
1 file changed, 33 insertions(+), 12 deletions(-)
diff --git
Fix the pylint warning by using a variable instead of lots of 'return'
statements.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
Commits are numbered for use in tests. Do this in determine_series() since
it is already dealing with the series.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git
Move this code into a separate function to avoid a pylint warning in
determine_series().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 63 +--
1 file changed, 41 insertions(+), 22 deletions(-)
diff --git
Create a separate function to adjust options. Also move show_actions() up
as far as we can in the function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 33 insertions(+), 20 deletions(-)
diff
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git
Pass in the individual values rather than the whole options object, so we
can see what is needed.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git
Collect the two parts of the output-file handling into single place.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index
Set up output_dir at the start of the main function, instead of updating
the options.output_dir option.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/buildman/control.py
Move the code for dealing with toolchains out into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 53 ---
1 file changed, 38 insertions(+), 15 deletions(-)
diff
Move the code which obtains a Boards object into its own function, to
reduce the size of the main function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 54 ---
1 file changed, 39 insertions(+), 15 deletions(-)
diff
Move some more series-related code here, to reduce the size of the main
function.
Signed-off-by: Simon Glass
---
Changes in v2:
- Correct operation of -A
tools/buildman/control.py | 82 ---
1 file changed, 42 insertions(+), 40 deletions(-)
diff --git
Create a new determine_boards() function to hold the code which selects
which boards to build.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 59 ---
1 file changed, 43 insertions(+), 16 deletions(-)
diff --git
Move this up above where the builder is created, since it no-longer makes
use of the builder.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 88 ---
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git
This function only needs the output directory from the builder. This is
passed into the builder, so just pass the same value to show_actions().
The avoids needing a builder to call show_actions().
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 8
1
This lacks a test at present. Add one.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/func_test.py | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py
index d9b4c41ec68c..5dbbb53b6572
Reduce the size of the do_buildman() function a little by moving the code
that handles --fetch-arch into a separate function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 49 +--
1 file changed, 31 insertions(+), 18
This does not need any of the control features. Move it out of main to
reduce the size of the do_buildman() function.
For Python 3.6 the -H feature will not work, but this does not seem to be
a huge problem, as it dates from 2016.
Signed-off-by: Simon Glass
---
(no changes since v1)
Reduce the size of the do_buildman() function a little by moving the code
that figures out the series into a separate function.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 95 +++
1 file changed, 56 insertions(+), 39
Tidy up the easier-to-fix pylint warnings in module 'control'.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 119 +---
tools/buildman/func_test.py | 2 +-
2 files changed, 70 insertions(+), 51 deletions(-)
diff --git
Convert this file to snake case and update all files which use it.
Signed-off-by: Simon Glass
---
(no changes since v1)
tools/buildman/control.py | 31 ++-
tools/buildman/func_test.py | 7 ---
tools/buildman/main.py | 2 +-
tools/buildman/test.py
1 - 100 of 110 matches
Mail list logo
