Re: [U-Boot] [PATCH] cmd: part: use MAX_SEARCH_PARTITIONS for part search

> On 7 Sep 2018, at 11:37, Kever Yang wrote: > > Use Macro instead of hard code. Nitpick: mentioning where the macro is defined (and if it was recently introduced, what commit this references) would be helpful in a cursory review. I just ran a 'git grep’ instead ;-) > Signed-off-by: Kever

Re: [U-Boot] [U-Boot, 1/8] rockchip: add STIMER_BASE for Rockchip SoCs

Kever, [Sorry for the delay, I am switching laptops and this got stuck in my Drafts folder on the old machine — which I noticed only today] > On 3 Sep 2018, at 05:21, Kever Yang wrote: > > Hi Philipp, > > > On 08/30/2018 05:11 PM, Philipp Tomsich wrote: >> >> >> On Wed, 18 Apr 2018, Kever

Re: [U-Boot] [PATCH] rockchip: add TPL_TINY_FRAMEWORK support

> On 28 Aug 2018, at 11:23, Kever Yang wrote: > > Rockchip BootRom support load firmware from storage media twice, > one for ddr sdram init code into sram and another time to load > firmware into DDR. For ddr sdram init code(which is TPL in U-Boot > project), it's OK to re-use the stack and

Re: [U-Boot] [U-Boot, 01/10] rockchip: enable DEBUG_UART_BOARD_INIT by default

Kever, Could you rebase this series to u-boot-rockchip/next and resubmit? I’d like to avoid any issues from manually fixing up git-am issues (as I happened to introduce on last set of UART changes). Thanks, Philipp. > On 29 Aug 2018, at 20:33, Philipp Tomsich > wrote: > >> All Rockchip SoCs

Re: [U-Boot] [PATCH] rockchip: dts: fix unnecessary '-cells' warning

> On 28 Aug 2018, at 11:57, Kever Yang wrote: > > Fix warning below: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" > property > > Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich ___ U-Boot mailing list

Re: [U-Boot] [PATCH 11/25] clk: Allow clock defaults to be set also during re-reloc state

> On 24 Aug 2018, at 17:54, Andreas Dannenberg wrote: > > Philipp, > > On Fri, Aug 24, 2018 at 04:42:15PM +0200, Dr. Philipp Tomsich wrote: >> +Kever >> >>> On 24 Aug 2018, at 16:12, Tom Rini wrote: >>> >>> On Tue, Aug 21, 2018 a

Re: [U-Boot] [PATCH 11/25] clk: Allow clock defaults to be set also during re-reloc state

+Kever > On 24 Aug 2018, at 16:12, Tom Rini wrote: > > On Tue, Aug 21, 2018 at 08:01:49PM +0530, Lokesh Vutla wrote: > >> From: Andreas Dannenberg >> >> The earlier commit f4fcba5c5ba ("clk: implement clk_set_defaults()") >> which introduced the functionality for setting clock defaults such

Re: [U-Boot] [PATCH 3/3] bootcount: add DM-based backing store for bootcount

Simon, > On 23 Aug 2018, at 12:45, Simon Glass wrote: > > Hi Philipp, > > On 17 August 2018 at 06:56, Dr. Philipp Tomsich > wrote: >> Simon, >> >> On 17 Aug 2018, at 14:49, Simon Glass wrote: >> >> Hi Philipp, >> >> On 14 August

Re: [U-Boot] [PATCH 3/3] bootcount: add DM-based backing store for bootcount

Simon, > On 17 Aug 2018, at 14:49, Simon Glass wrote: > > Hi Philipp, > > On 14 August 2018 at 05:39, Dr. Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Lukasz, >> >>> On 14 Aug 2018, at 13:10, Lukasz Majewski wr

Re: [U-Boot] [PATCH v2] kconfig: fix typo 'parition'

> On 16 Aug 2018, at 09:44, Simon Goldschmidt > wrote: > > Replaced misspelled words "parition"/"paritioning" (missing 't') in two > Kconfig files by correct words "partition"/"partitioning" > > Signed-off-by: Simon Goldschmidt Reviewed-by: Philipp Tomsich

Re: [U-Boot] [PATCH 1/3] rtc: rv3029: add to Kconfig

> On 14 Aug 2018, at 18:46, Heinrich Schuchardt wrote: > > On 08/14/2018 11:51 AM, Philipp Tomsich wrote: >> The MicroCrystal RV3029 driver didn't have a Kconfig entry and was not used >> anywhere. Add it to Kconfig to make it selectable. >> >> Signed-off-by: Philipp Tomsich >> Tested-by:

Re: [U-Boot] [PATCH 3/3] bootcount: add DM-based backing store for bootcount

Lukasz, > On 14 Aug 2018, at 13:10, Lukasz Majewski wrote: > > Hi Philipp, > >> The original bootcount methods do not provide an interface to DM and >> rely on a static configuration for I2C devices (e.g. bus, chip-addr, >> etc. are configured through defines statically). On a modern system

Re: [U-Boot] [PATCH] spl: fix debug print in spl_common_init()

> On 13 Aug 2018, at 11:24, Simon Goldschmidt > wrote: > > spl_common_init() debug-prints "spl_early_init()\n" but it is > called both from spl_early_init() and spl_init(). > > Fix this by moving the debug() statement to the calling functions > which now print their name. > > Signed-off-by:

Re: [U-Boot] [PATCH] kconfig: fix typo 'parition'

> On 13 Aug 2018, at 11:34, Simon Goldschmidt > wrote: > > %s/parition/partition Make this a whole sentence to make it easier to read. > > Signed-off-by: Simon Goldschmidt Reviewed-by: Philipp Tomsich ___ U-Boot mailing list

Re: [U-Boot] [PATCH 1/9] dm: allow 4GB of DRAM on 32bit systems

> On 2 Aug 2018, at 22:36, Simon Glass wrote: > > On 26 July 2018 at 07:59, Philipp Tomsich > > wrote: >> Even on 32bit systems a full 4GB of DRAM may be installed and reported >> by the DRAM controller. Whether these 4GB are larger available >>

Re: [U-Boot] [PATCH] board_f: drop 'dead code' in ram_top computation

> On 27 Jul 2018, at 11:16, Philipp Tomsich > wrote: > > gd->ram_top is assigned to twice on consecutive lines and the compiler > won't be able to tell that the first assignment is dead (including its > r-value) due to the r-value containing a (side-effect free) function > call. > > This

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 27 Jul 2018, at 09:50, Carlo Caione wrote: > > On Fri, 2018-07-27 at 00:54 +0200, Dr. Philipp Tomsich wrote: >>> On 26 Jul 2018, at 22:05, Carlo Caione wrote: >>> >>> On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >>>> The cal

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 26 Jul 2018, at 22:05, Carlo Caione wrote: > > On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >> The calculation in `rockchip_sdram_size` would overflow for 4GB on >> 32bit systems (i.e. when PHYS_64BIT is not defined). >> >> This makes the internal variables and the signature

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 26 Jul 2018, at 22:05, Carlo Caione wrote: > > On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >> The calculation in `rockchip_sdram_size` would overflow for 4GB on >> 32bit systems (i.e. when PHYS_64BIT is not defined). >> >> This makes the internal variables and the signature

Re: [U-Boot] [PATCH 2/9] rockchip: support 4GB DRAM on 32bit systems

> On 26 Jul 2018, at 22:05, Carlo Caione wrote: > > On Thu, 2018-07-26 at 15:59 +0200, Philipp Tomsich wrote: >> The calculation in `rockchip_sdram_size` would overflow for 4GB on >> 32bit systems (i.e. when PHYS_64BIT is not defined). >> >> This makes the internal variables and the signature

Re: [U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

Ezequiel, > On 25 Jul 2018, at 22:31, Ezequiel Garcia wrote: > > On Sat, 2018-07-21 at 16:23 +0200, Dr. Philipp Tomsich wrote: >> Ezequiel, >> >> This series breaks the build (see >> https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695).

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Marty, > On 6 Jul 2018, at 05:11, Marty E. Plummer wrote: > > On Sat, May 19, 2018 at 02:08:53PM +0200, Dr. Philipp Tomsich wrote: >> Marty, >> >>> On 19 May 2018, at 12:40, Marty E. Plummer wrote: >>> >>> So explain to me what you'd like me

Re: [U-Boot] [PATCH 2/3] rockchip: add support for veyron-speedy (ASUS Chromebook C201)

> On 24 Jul 2018, at 07:12, Marty E. Plummer wrote: > > On Fri, Jul 13, 2018 at 12:31:49PM +0200, Dr. Philipp Tomsich wrote: >> >>> On 7 May 2018, at 02:20, Marty E. Plummer wrote: >>> >>> On Mon, May 07, 2018 at 12:12:54AM +0200, klaus.go...@t

Re: [U-Boot] [U-Boot,2/3] ARM: add RK3399 Ficus board

Ezequiel, This series breaks the build (see https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406351695). Did you test with Travis prior to submitting? When you revise, I’d also prefer a ‘rockchip:’ and a ‘board:’ tag over the ARM tag … Thanks, Philipp. > On 20 Jul 2018, at 19:30,

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, The first batch of changes for u-boot-rockchip/master in this iteration is ready for you to pull. The associated Travis report (prior to the rebase) is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/406299101 Thanks, Philipp. The following changes since commit

Re: [U-Boot] [U-Boot, 1/3] arm: dts: rockchip: add some common pin-settings to rk3399

> On 20 Jul 2018, at 19:14, Ezequiel Garcia wrote: > > On Fri, 2018-07-20 at 18:26 +0200, Philipp Tomsich wrote: >> >> On Mon, 16 Jul 2018, Ezequiel Garcia wrote: >> >>> From: Randy Li >>> >>> Those pins would be used by many boards. >> >> The Rockchip pinctrl driver in U-Boot does not

Re: [U-Boot] [U-Boot, 3/3] rockchip: rk3399: Add more instructions to the README

Thanks for the clarification, I’ll take this as-is. > On 20 Jul 2018, at 19:09, Ezequiel Garcia wrote: > > On Fri, 2018-07-20 at 18:28 +0200, Philipp Tomsich wrote: >> >> On Mon, 16 Jul 2018, Ezequiel Garcia wrote: >> >>> This commit adds a content section and also instructions >>> on how to

Re: [U-Boot] [PATCH v2 01/11] arch: arm: mach-rockchip: rk3288: Enable regulators in board_init

Janine, > On 18 Jul 2018, at 10:46, Janine Hagemann wrote: > > At start-up, the regulators have to be enabled. Let's use > regulators_enable_boot_on() to enable the regulators needed > for boot. > > Signed-off-by: Wadim Egorov > Signed-off-by: Janine Hagemann An equivalent change from Carlo

[U-Boot] CONFIG_SPL_TINY_MEMSET for configs/smartweb_defconfig?

Heiko, I have a SPL change assigned in my queue that breaks the smartweb config due to increasing SPL by a few bytes of extra code. I’d like to enable CONFIG_SPL_TINY_MEMSET in configs/smartweb_defconfig to fix this. If this is ok with you, I’ll submit a patch against the defconfing and then

Re: [U-Boot] [PATCH] sysreset: Add support for gpio-restart

> On 13 Jul 2018, at 11:15, Michal Simek wrote: > > The Linux kernel has binding for gpio-restart node. > This patch is adding basic support without supporting any optional > properties. Nice. This may also give us an opportunity to streamline some of the reset logic (and the FDT-interface to

Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

Joe, > On 14 Jun 2018, at 20:26, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 1:12 PM, Dr. Philipp Tomsich > wrote: >> >>> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: >>> >>> On Thu, Jun 14, 2018 at 4:48 AM, Jan

Re: [U-Boot] [PATCH 2/3] rockchip: add support for veyron-speedy (ASUS Chromebook C201)

> On 7 May 2018, at 02:20, Marty E. Plummer wrote: > > On Mon, May 07, 2018 at 12:12:54AM +0200, klaus.go...@theobroma-systems.com > wrote: >> >>> On 06.05.2018, at 16:25, Marty E. Plummer wrote: >>> >>> This adds support for the ASUS C201, a

Re: [U-Boot] [PATCH v3 4/4] rk3288: Convert register defines to const uintptr_t

> On 9 Jul 2018, at 05:05, Simon Glass wrote: > > On 11 June 2018 at 13:00, Carlo Caione wrote: >> From: Carlo Caione >> >> No functional change but at least we can now guarantee type safety. >> >> Signed-off-by: Carlo Caione >> --- >> arch/arm/mach-rockchip/rk3288-board.c | 5 ++--- >> 1

Re: [U-Boot] [PATCH 1/1] rockchip: rk3399: spl: add missing \n to output

at 19:28, Dr. Philipp Tomsich > wrote: >> >>> On 3 Jun 2018, at 21:10, Heinrich Schuchardt wrote: >>> >>> Without the patch SPL (in case of an error) creates an output like: >>> >>> U-Boot SPL board initMissing DTB >>> >&g

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 10 Jul 2018, at 16:41, Simon Glass wrote: > > Hi, > > On 8 May 2018 at 04:21, Dr. Philipp Tomsich > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> Marty, >> >>> On 8 May 2018, at 02:52, Marty E. Plummer wrote: >>>

Re: [U-Boot] build fail due to dependence error

9 GMT+09:00 Simon Glass : >>> +Masahiro who might know >>> >>> On 2 July 2018 at 01:23, Dr. Philipp Tomsich >>> wrote: >>>> Kever, >>>> >>>> Could you check the build artifacts in Jenkins to see whether after >>>> th

Re: [U-Boot] build fail due to dependence error

Glass wrote: >> Hi, >> >> On 28 June 2018 at 01:41, Dr. Philipp Tomsich >> wrote: >>> Kever, >>> >>> is the link for ‘asm’ set up correctly? >>> >>> Thanks, >>> Philipp. >>> >>> On 28 Jun 2018, at 10

Re: [U-Boot] build fail due to dependence error

Kever, is the link for ‘asm’ set up correctly? Thanks, Philipp. > On 28 Jun 2018, at 10:38, Kever Yang wrote: > > Hi Simon, > > Do you have any idea about this error? > > CC lib/asm-offsets.s > CC arch/arm/lib/asm-offsets.s > fixdep: error opening config file:

Re: [U-Boot] [PATCH 2/2] arm: timer: sunxi: add Allwinner timer erratum workaround

> On 27 Jun 2018, at 02:42, Andre Przywara wrote: > > The Allwinner A64 SoCs suffers from an arch timer implementation erratum, > where sometimes the lower 11 bits of the counter value erroneously > become all 0's or all 1's [1]. This leads to sudden jumps, both forwards and > backwards, with

Re: [U-Boot] [PATCH v2 1/6] dm: SMEM (Shared memory) uclass

> On 22 Jun 2018, at 04:11, Ramon Fried wrote: > > This is a uclass for Shared memory manager drivers. > > A Shared Memory Manager driver implements an interface for allocating > and accessing items in the memory area shared among all of the > processors. > > Signed-off-by: Ramon Fried

Re: [U-Boot] [PATCH 0/4] rockchip: Reduce prerequisites from the host

Vicente, > On 18 Jun 2018, at 22:07, Vicente Bergas wrote: > > On Wed, 13 Jun 2018 11:51:13 +0800, kever.yang at rock-chips.com wrote: >> (snip) >> I just not understand why remove the dependency on python is so important, >> there already many modules depend on python. > > On Wed, 13 Jun 2018

Re: [U-Boot] [PATCH 03/12] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

> On 14 Jun 2018, at 19:39, Joe Hershberger wrote: > > On Thu, Jun 14, 2018 at 4:48 AM, Janine Hagemann wrote: >> We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of >> RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() >> to enable the RX delay. >> The MASK was used in a

Re: [U-Boot] [PATCH v2 2/3] rk3288: Disable JTAG function from sdmmc0 IO

On 11 Jun 2018, at 19:08, Carlo Caione wrote: > > On Mon, 2018-06-11 at 10:41 +0200, Dr. Philipp Tomsich wrote: >>> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > /cut >>> +#define GRF_SOC_CON0 0xff770244 >>> #define GRF_SOC_CON2 0xff77024c >> &

Re: [U-Boot] [PATCH v2 2/3] rk3288: Disable JTAG function from sdmmc0 IO

> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > From: Carlo Caione > > The GRF_SOC_CON0.grf_force_jtag bit is automatically set at boot and it > is preventing the SDMMC to work correctly. Disable the JTAG function on > the assumption that a working SD has higher priority over JTAG. > >

Re: [U-Boot] [PATCH v2 1/3] rk3288: veyron: Init boot-on regulators

> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > From: Carlo Caione > > Use regulators_enable_boot_on() to init all the regulators with > regulator-boot-on property. > > Signed-off-by: Carlo Caione > Reviewed-by: Simon Glass Reviewed-by: Philipp Tomsich Acked-by: Philipp Tomsich

Re: [U-Boot] [PATCH v2 3/3] rockchip: veyron: Set vcc33_sd regulator value

> On 11 Jun 2018, at 10:08, Carlo Caione wrote: > > From: Carlo Caione > > On the veyron board the vcc33_sd regulator is used as vmmc-supply for > the SD card. This regulator is powered in the MMC core during power on > but its value is never actually set. > > In the veyron platform the

Re: [U-Boot] [PATCH RESEND 1/2] rockchip: make_fit_atf: use elf entry point

Mian, Did you change anything or is this just a resend with the same content? I didn’t have a chance to review this yet, so wanted to make sure I work off the latest version... Thanks, Philipp. > On 8 Jun 2018, at 10:47, Mian Yousaf Kaukab wrote: > > make_fit_atf.py uses physical address of

Re: [U-Boot] [PATCH 1/1] rockchip: rk3399: spl: add missing \n to output

> On 3 Jun 2018, at 21:10, Heinrich Schuchardt wrote: > > Without the patch SPL (in case of an error) creates an output like: > > U-Boot SPL board initMissing DTB > > The patch adds the missing line feed. So now we get: > > U-Boot SPL board init > Missing DTB > >

Re: [U-Boot] [PATCH 1/1] rockchip: evb-rk3399: correct README for board bring up

> On 3 Jun 2018, at 16:50, Heinrich Schuchardt wrote: > > %s/rkflashtool/rkdeveloptool/ > > We are using rkdeveloptool not rkflashtool. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Philipp Tomsich Acked-by: Philipp Tomsich ___ U-Boot

Re: [U-Boot] Exception Level switching seems broken on RK3399

Vincente, > On 1 Jun 2018, at 00:28, Vicente Bergas wrote: > > On Thu, May 24, 2018 at 7:05 PM, Dr. Philipp Tomsich > wrote: >> Vincente, >> >> On 24 May 2018, at 18:48, Vicente Bergas wrote: >> >> Hello Philipp, >> your answer is much appreci

Re: [U-Boot] [PATCH] rtc: Add read8 and write8 support to isl1208 driver

> On 31 May 2018, at 20:14, Trent Piepho wrote: > > This can be used for device register access from board code. > > This allows access to capabilities in the RTC chip not abstracted in > U-Boot's RTC class. E.g., device NVRAM or a tamper detection circuit. > > Cc: Klaus Goger > Cc: Philipp

Re: [U-Boot] [PATCH v1 1/4] spl: record boot_device into spl_image and call spl_perform_fixups

Lukasz, > On 25 May 2018, at 00:11, Lukasz Majewski wrote: > > Hi Philipp, > >> On some boards, we want to give the board/architecture-specific code a >> chance to look at where the next image has been loaded from and >> perform fixups before starting the next image. This is of

Re: [U-Boot] Exception Level switching seems broken on RK3399

Vincente, > On 24 May 2018, at 18:48, Vicente Bergas <vice...@gmail.com> wrote: > > Hello Philipp, > your answer is much appreciated. > > On Thu, May 24, 2018 at 1:07 PM, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com > <mailto:philipp.t

Re: [U-Boot] Exception Level switching seems broken on RK3399

Vincente, > On 19 May 2018, at 16:58, Vicente Bergas wrote: > > Hello, > I am writing this from a standalone Sapphire board [1], > that is, without the Excavator base board. > The CPU is the Rockchip RK3399, which implements ARMv8.0-A. > > Currently the boot process is: >

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Marty, > On 19 May 2018, at 12:40, Marty E. Plummer <hanet...@startmail.com> wrote: > > On Mon, May 14, 2018 at 05:56:27PM +0200, Dr. Philipp Tomsich wrote: >> I had a bit more time to look into this and it looks as if we have two >> problem-spots... >>

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

09:24, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > >> >> On 9 May 2018, at 07:29, Marty E. Plummer <hanet...@startmail.com> wrote: >> >> On Tue, May 08, 2018 at 11:08:14PM +0200, Dr. Philipp Tomsich wrote: >>>

Re: [U-Boot] [PULL] Please pull u-boot-rockchip/master

Travis report (prior to a final rebase onto your latest master) is at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/378666041 > On 14 May 2018, at 17:32, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > Tom, > > I have t

[U-Boot] [PULL] Please pull u-boot-rockchip/master

Tom, I have two fixes for regressions (that unfortunately ended up in the last release) in my tree, ready for a merge onto master. Thanks, Philipp. The following changes since commit ca70cbabdcd19bf157ae4fa984559b126071ccff: Merge git://git.denx.de/u-boot-marvell (2018-05-14 08:52:48

Re: [U-Boot] [PATCH v2] Makefile: adopt --std=gnu11 for HOSTCFLAGS on Linux

> On 14 May 2018, at 16:53, Mark Kettenis wrote: > >> From: Philipp Tomsich >> Date: Mon, 14 May 2018 15:22:06 +0200 >> >> Following the conversion of the SPDX license tags, a number of files >> compiled with -pedantic now

Re: [U-Boot] [PATCH] tools: adopt --std=gnu99 where C99 comments are needed

While it’s not directly related to this patch, we should clearly state that the U-Boot code base (with the possible exception of the tools/ directory, which I have started touching here) has _implicitly_ moved to GNU11 (yes, even newer than C99), when be upgraded beyond GCC 5. For reference, see

Re: [U-Boot] rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC

> On 14 May 2018, at 12:42, Jonathan Gray <j...@jsg.id.au> wrote: > > On Mon, May 14, 2018 at 11:28:38AM +0200, Wadim Egorov wrote: >> Hi, >> >> >> Am 08.05.2018 um 10:05 schrieb Dr. Philipp Tomsich: >>> Looks like the designware GMAC driver

Re: [U-Boot] GCC 7.x vs. C++ comments

> On 9 May 2018, at 15:49, Tom Rini wrote: > > On Wed, May 09, 2018 at 02:46:54PM +0200, Wolfgang Denk wrote: >> Dear Tom, >> >> In message <20180509114828.gg12...@bill-the-cat.ec.rr.com> you wrote: >>> >>> We should go and update [1] to note some special exemptions to the

[U-Boot] GCC 7.x vs. C++ comments

Tom, I recently ran a local buildman with a came across these: > cc -Wp,-MD,tools/.gen_eth_addr.d -Wall -Wstrict-prototypes -O2 > -fomit-frame-pointer-include ./include/compiler.h -idirafterinclude > -idirafter./arch/arm/include -I./scripts/dtc/libfdt -I./tools -DUSE_HOSTCC >

Re: [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs

Kever, if this affects all SoCs, then apparently nobody tested -rc3 … I had made sure that all these last-minute changes had gone in before rc3. Regards, Philipp. > On 9 May 2018, at 10:12, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > Keve

Re: [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs

Kever, There were a number a merge conflicts with this series and it looks like I missed one of them. This is the risk when I try to resolve conflicts instead of asking for a series to be rebased onto master… Regards, Philipp. > On 9 May 2018, at 10:06, Kever Yang

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 9 May 2018, at 07:29, Marty E. Plummer <hanet...@startmail.com> wrote: > > On Tue, May 08, 2018 at 11:08:14PM +0200, Dr. Philipp Tomsich wrote: >> >>> On 8 May 2018, at 21:21, Marty E. Plummer <hanet...@startmail.com> wrote: >>> >>>

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 8 May 2018, at 21:21, Marty E. Plummer <hanet...@startmail.com> wrote: > > On Tue, May 08, 2018 at 12:21:24PM +0200, Dr. Philipp Tomsich wrote: >> Marty, >> >>> On 8 May 2018, at 02:52, Marty E. Plummer <hanet...@startmail.com> wrote: >>>

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

Good catch. I had a few merge-conflicts when merging that series. That one might have gotten lost. > On 8 May 2018, at 12:31, Jonathan Gray <j...@jsg.id.au> wrote: > > On Tue, May 08, 2018 at 09:41:32AM +0200, Dr. Philipp Tomsich wrote: >> Kever, >> >> Could

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Simon, Looks like we’d like to have a 64bit type for size in ‘struct ram_info’ (see below). Let us know what you think of the proposed change. Thanks, Philipp. > On 8 May 2018, at 12:21, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > Marty, &

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

Marty, > On 8 May 2018, at 02:52, Marty E. Plummer <hanet...@startmail.com> wrote: > > On Mon, May 07, 2018 at 11:16:28AM +0200, Dr. Philipp Tomsich wrote: >> >>> On 7 May 2018, at 04:34, Marty E. Plummer <hanet...@startmail.com> wrote: >>> >&g

Re: [U-Boot] [PATCH] rockchip: clk: rk3288: handle clk_enable requests for GMAC

> On 8 May 2018, at 11:49, Jonathan Gray wrote: > > Since b0ba1e7e9d9b9441a18048ec67a3b3100c096975 > (rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC) > Ethernet no longer probes on RK3288. > > Add no-ops for GMAC clocks observed to be requested which

Re: [U-Boot] rockchip: clk: rk3288: add clk_enable function and support USB HOST0/HSIC

Looks like the designware GMAC driver is trying to enable a clock and can’t deal with the -ENOENT. Could you try to see which clock it is requesting and add the necessary entries in the clock-enable function? If you have a patch, I’ll try to prioritise it, so we get these regressions cleaned up

Re: [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

Kever, Could you analyse and provide (against master) a patch for this? We’ll need to catch any left-overs from your changes at the start of the cycle before we try to merge any of the more invasive changes you have in-flight. Thanks, Philipp. > On 8 May 2018, at 09:30, Jonathan Gray

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 7 May 2018, at 04:34, Marty E. Plummer wrote: > > On Mon, May 07, 2018 at 10:20:55AM +0800, Kever Yang wrote: >> Hi Marty, >> >> >> On 05/06/2018 10:25 PM, Marty E. Plummer wrote: >>> Taken from coreboot's src/soc/rockchip/rk3288/sdram.c >>> >>> Without this

Re: [U-Boot] [PATCH 3/3] rockchip: fix incorrect detection of ram size

> On 6 May 2018, at 16:25, Marty E. Plummer wrote: > > Taken from coreboot's src/soc/rockchip/rk3288/sdram.c > > Without this change, my u-boot build for the asus c201 chromebook (4GiB) > is incorrectly detected as 0 Bytes of ram. Could you elaborate what the change is

Re: [U-Boot] [PATCH v2 1/3] drivers: Add board uclass

Simon, > On 1 May 2018, at 01:12, Simon Glass <s...@chromium.org> wrote: > > Hi, > > On 27 April 2018 at 07:02, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com > <mailto:philipp.toms...@theobroma-systems.com>> wrote: >> >>> O

Re: [U-Boot] [PATCH 3/5] api: Flush cache when closing api

> On 30 Apr 2018, at 10:34, Emmanuel Vadot wrote: > > Signed-off-by: Emmanuel Vadot > --- > api/api.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/api/api.c b/api/api.c > index 7eee2fc083..7d1608b520 100644 > --- a/api/api.c > +++

Re: [U-Boot] [PATCH v2 1/3] drivers: Add board uclass

> On 27 Apr 2018, at 14:51, Mario Six wrote: > > Since there is no canonical "board device" that can be used in board > files, it is difficult to use DM function for board initialization in > these cases. > > Hence, add a uclass that implements a simple "board device",

Re: [U-Boot] [PATCH v3 1/2] arm: preserve lr correctly in arm926ejs startup code

> On 26 Apr 2018, at 20:18, Klaus Goger > wrote: > > When building the mxs platform in thumb mode gcc generates code using > the intra procedure call scratch register (ip/r12) for the calling the > lowlevel_init function. This modifies the lr in flush_dcache

Re: [U-Boot] [U-Boot,2/3] rockchip: rk3188: add timer3 node

> On 26 Apr 2018, at 09:14, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > >> On 26 Apr 2018, at 04:50, Kever Yang <kever.y...@rock-chips.com> wrote: >> >> Hi Philipp, >> >> On 04/25/2018 06:17 PM, Dr. Phil

[U-Boot] [PULL] Please pull u-boot-rockchip

Tom, I have a number of fixes, cleanups and config-changes for the upcoming release ready for you in u-boot-rockchip/master. Please pull. The Travis-CI report for this tree can be found at https://travis-ci.org/ptomsich/u-boot-rockchip/builds/371249739 Thanks, Philipp. The following

Re: [U-Boot] [U-Boot,2/3] rockchip: rk3188: add timer3 node

> On 26 Apr 2018, at 04:50, Kever Yang <kever.y...@rock-chips.com> wrote: > > Hi Philipp, > > On 04/25/2018 06:17 PM, Dr. Philipp Tomsich wrote: >> Kever, >> >>> On 25 Apr 2018, at 12:04, Philipp Tomsich >>> <philipp.toms...@theobroma

Re: [U-Boot] [PATCH] sysreset: rockchip: use dev_read_addr_ptr get cru base

Andy, > On 24 Mar 2018, at 11:50, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > >> On 24 Mar 2018, at 07:49, Andy Yan <andy@rock-chips.com> wrote: >> >> Use system api dev_read_addr_ptr to get cru reg base, >> r

Re: [U-Boot] [U-Boot,2/3] rockchip: rk3188: add timer3 node

Kever, > On 25 Apr 2018, at 12:04, Philipp Tomsich > wrote: > >> Add dts node for timer3. >> Because of the rockchip timer can only KNOWN "dtd_rockchip_rk3368_timer" >> with OF_PLATDATA enable, so we override its compatible to >> "rockchip,rk3368-timer".

Re: [U-Boot] [PATCH v2 3/3] rockchip: rv1108: add ofdata_to_platdata() method for driver

> On 24 Apr 2018, at 05:27, Kever Yang wrote: > > Parse of data in dedicated api instead of in probe(). > > The clk_set_rate() may be called before the clk driver is probed, > after core support set default clock. > This patch fix system abort issue since: > f4fcba5

Re: [U-Boot] [PATCH v2 2/3] rockchip: rk3128: add ofdata_to_platdata() method for driver

> On 24 Apr 2018, at 05:27, Kever Yang wrote: > > Parse of data in dedicated api instead of in probe(). > > The clk_set_rate() may be called before the clk driver is probed, > after core support set default clock. > This patch fix system abort issue since: > f4fcba5

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Kever, > On 13 Apr 2018, at 09:51, Kever Yang wrote: > On 04/08/2018 09:45 AM, Kever Yang wrote: > +__weak int arch_cpu_init(void) +{ +return 0; +} + +__weak int rk_board_init_f(void) +{ +return 0; +} >>> This

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

> On 10 Apr 2018, at 14:32, Tom Rini wrote: > > On Tue, Apr 10, 2018 at 02:54:09PM +0800, Kever Yang wrote: >> Hi Tom, >> >> >> On 04/09/2018 06:35 AM, Tom Rini wrote: I have do a lot of test and re-work in my local branch and at last make it landed in

Re: [U-Boot] [RFC PATCH] net: phy: Don't limit phy addresses by default

> On 9 Apr 2018, at 10:01, Neil Armstrong wrote: > > On 30/03/2018 18:52, Joe Hershberger wrote: >> Some boards expect to find more than one phy while other boards are old >> and need to be limited to a specific phy address. Only limit the phy >> address for boards that

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Kever, > On 8 Apr 2018, at 03:45, Kever Yang wrote: > > Philipp, > > > On 04/02/2018 05:28 AM, Philipp Tomsich wrote: >> >> >> On Tue, 27 Mar 2018, Kever Yang wrote: >> >>> We use common board/spl/tpl file for all rockchip SoCs, >>> - all the SoC spec setting

Re: [U-Boot] [U-Boot, 36/36] rockchip: add common board file for rockchip platform

Kever, > On 9 Apr 2018, at 00:35, Tom Rini wrote: > > On Sun, Apr 08, 2018 at 09:45:22AM +0800, Kever Yang wrote: >> Philipp, >> >> >> On 04/02/2018 05:28 AM, Philipp Tomsich wrote: >>> >>> >>> On Tue, 27 Mar 2018, Kever Yang wrote: >>> We use common board/spl/tpl

Re: [U-Boot] [PATCH v2 5/6] sunxi: add code for recalculating the DRAM size in U-Boot

> On 3 Apr 2018, at 12:39, Icenowy Zheng wrote: > > > > 于 2018年4月3日 GMT+08:00 下午6:13:17, Andre Przywara > 写到: >> Hi, >> >> On 03/04/18 10:29, Maxime Ripard wrote: >>> On Thu, Mar 29, 2018 at 01:21:38PM +0100, Andre

Re: [U-Boot] [PATCH 1/2] image: fit: Show firmware configuration property if present

> On 26 Mar 2018, at 16:31, Michal Simek wrote: > > SPL ATF support requires to have firmware property which should be also > listed by mkimage -l when images is created. > > The patch is also using this macro in spl_fit to match keyword. > > When image is created: >

Re: [U-Boot] [U-Boot, 18/36] rockchip: rk3188: remove rockchip timer as sys timer

Arturri, > On 2 Apr 2018, at 11:38, Artturi Alm wrote: > > On Sun, Apr 01, 2018 at 10:21:50PM +0200, Philipp Tomsich wrote: >>> We use ARM arch timer instead. >>> >>> Signed-off-by: Kever Yang >>> --- >>> >>> include/configs/rk3188_common.h |

Re: [U-Boot] [PATCH] mkimage: do not fail if there is no print_header function

> On 30 Mar 2018, at 10:28, Guillaume GARDET wrote: > > Commit 253c60a breaks the exit value of 'mkimage -T rkimage' > and print the following error: > mkimage: Can't print header for Rockchip Boot Image support: Success > > It is not a failure to not print headers,

[U-Boot] [PULL] Please pull from u-boot-rockchip

Tom, Here’s a PR for a few changes available on the rockchip-tree for integration into master. While these are mainly bug-fixes, the plan is to have another PR either just-in-time for rc1 or slightly after with some larger series that still need review and discussion. Thanks, Philipp. The

Re: [U-Boot] [PATCH 26/36] rockchip: rk1108: remove rockchip timer for sys timer

> On 27 Mar 2018, at 11:29, Kever Yang wrote: > > We use ARM arch timer instead. Could you please provide a more useful commit message. Please consider that most people that look through the GIT log are not familiar with our platform. Thanks, Philipp.

Re: [U-Boot] [PATCH] sysreset: rockchip: use dev_read_addr_ptr get cru base

> On 24 Mar 2018, at 07:49, Andy Yan wrote: > > Use system api dev_read_addr_ptr to get cru reg base, > rather than rockchip private api rockchip_get_cru, which > will be cleanup later. > > Signed-off-by: Andy Yan Acked-by: Philipp Tomsich

Re: [U-Boot] Moving the rk_board_late_init() hook to a device-model based implementation.

Simon, ping? Thanks, Philipp. > On 26 Feb 2018, at 14:02, Dr. Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > Simon & Kever, > > We have the rk_board_late_init() hook for the Rockchip boards and I’d like to > convert > these

Re: [U-Boot] [PATCH 1/1] video: rk3399_mipi: correct error checking

Punit, > On 19 Mar 2018, at 18:21, Punit Agrawal wrote: > > Heinrich Schuchardt > writes: > >> Pointers are never negative. Use macro IS_ERR() for checking. >> cf. rk3288_mipi.c >> >> Signed-off-by: Heinrich Schuchardt

  1   2   3   4   5   >