Add a configuration option to measure the boot through the bootm
function.
Signed-off-by: Eddie James
---
boot/Kconfig| 23 ++
boot/bootm.c| 64 +
cmd/bootm.c | 2 ++
include/bootm.h | 2 ++
include/image.h | 1 +
5
The driver needs to support getting the PCRs in the capabilities
command. Fix various other things and support the max number
of PCRs for TPM2.
Signed-off-by: Eddie James
---
drivers/tpm/tpm2_tis_sandbox.c | 100 -
1 file changed, 72 insertions(+), 28 deletions
Use the sandbox TPM driver to measure some boot images in a unit
test case.
$ ./u-boot -T -c "ut measurement"
Running 1 measurement tests
Test: measure: measurement.c
Failures: 0
Signed-off-by: Eddie James
---
arch/sandbox/dts/test.dts | 12 +++
configs/sandbox_defconfig | 1
Add TPM2 functions to support boot measurement. This includes
starting up the TPM, initializing/appending the event log, and
measuring the U-Boot version. Much of the code was used in the
EFI subsystem, so remove it there and use the common functions.
Signed-off-by: Eddie James
---
include
sandbox TPM driver
Eddie James (5):
tpm: Fix spelling for tpmu_ha union
tpm: Support boot measurements
bootm: Support boot measurement
tpm: sandbox: Update for needed TPM2 capabilities
test: Add sandbox TPM boot measurement
arch/sandbox/dts/test.dts | 12 +
boot/Kconfig
On 1/9/23 17:26, Heinrich Schuchardt wrote:
On 1/10/23 00:13, Heinrich Schuchardt wrote:
On 1/9/23 22:55, Eddie James wrote:
Use the sandbox TPM driver to measure some boot images in a unit
test case.
$ ./u-boot -T -c "ut measurement"
Running 1 measurement tests
Test: measure: mea
On 1/9/23 17:35, Heinrich Schuchardt wrote:
On 1/9/23 22:55, Eddie James wrote:
This series adds support for measuring the boot images more generically
than the existing EFI support. Several EFI functions have been moved to
the TPM layer. The series includes optional measurement from the
On 1/10/23 16:02, Heinrich Schuchardt wrote:
On 1/10/23 17:38, Eddie James wrote:
On 1/9/23 17:26, Heinrich Schuchardt wrote:
On 1/10/23 00:13, Heinrich Schuchardt wrote:
On 1/9/23 22:55, Eddie James wrote:
Use the sandbox TPM driver to measure some boot images in a unit
test case.
$ ./u
On 1/10/23 16:37, Heinrich Schuchardt wrote:
On 1/10/23 23:32, Heinrich Schuchardt wrote:
On 1/9/23 22:55, Eddie James wrote:
Use the sandbox TPM driver to measure some boot images in a unit
test case.
$ ./u-boot -T -c "ut measurement"
Running 1 measurement tests
Tes
tmpu -> tpmu
Signed-off-by: Eddie James
Reviewed-by: Ilias Apalodimas
---
include/tpm-v2.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/tpm-v2.h b/include/tpm-v2.h
index 737e57551d..85feda3e06 100644
--- a/include/tpm-v2.h
+++ b/include/tpm-v2.h
@@ -16
since v1:
- Refactor TPM layer functions to allow EFI system to use them, and
remove duplicate EFI functions.
- Add test case
- Drop #ifdefs for bootm
- Add devicetree measurement config option
- Update sandbox TPM driver
Eddie James (6):
tpm: Fix spelling for tpmu_ha union
tpm
Add a configuration option to measure the boot through the bootm
function. Add the measurement state to the booti and bootz paths
as well.
Signed-off-by: Eddie James
---
boot/Kconfig| 23
boot/bootm.c| 70 +
cmd/booti.c
Use the sandbox TPM driver to measure some boot images in a unit
test case.
Signed-off-by: Eddie James
---
arch/sandbox/dts/sandbox.dtsi | 14
arch/sandbox/dts/test.dts | 13 +++
configs/sandbox_defconfig | 1 +
include/test/suites.h | 1 +
test/boot/Makefile
The driver needs to support getting the PCRs in the capabilities
command. Fix various other things and support the max number
of PCRs for TPM2.
Signed-off-by: Eddie James
Reviewed-by: Simon Glass
---
drivers/tpm/tpm2_tis_sandbox.c | 100 -
1 file changed, 72
Briefly describe the feature and specify the requirements.
Signed-off-by: Eddie James
---
doc/usage/index.rst | 1 +
doc/usage/measured_boot.rst | 23 +++
2 files changed, 24 insertions(+)
create mode 100644 doc/usage/measured_boot.rst
diff --git a/doc/usage
Add TPM2 functions to support boot measurement. This includes
starting up the TPM, initializing/appending the event log, and
measuring the U-Boot version. Much of the code was used in the
EFI subsystem, so remove it there and use the common functions.
Signed-off-by: Eddie James
---
include
On 1/12/23 17:43, Simon Glass wrote:
Hi Eddie,
On Thu, 12 Jan 2023 at 09:16, Eddie James wrote:
Add TPM2 functions to support boot measurement. This includes
starting up the TPM, initializing/appending the event log, and
measuring the U-Boot version. Much of the code was used in the
EFI
there. There's
no mention of ACPI in 3.3.4.2 PCR[1] – Host Platform Configuration.
However, in Figure 6 -- PCR Mapping of UEFI Components ACPI is shown
in PCR1. The general description also mentions PCR0 is for code and PCR1
is for data such as ACPI and SMBIOS.
Thanks, looks correct.
Reviewed
On 1/26/23 01:51, Ilias Apalodimas wrote:
Hi Eddie,
Thanks for the cleanup! Unfortunately this doesn't compile with EFI
selected, but in general it looks pretty good.
Thanks, yes I forgot to remove tcg2_pcr_read
On Wed, Jan 25, 2023 at 11:18:06AM -0600, Eddie James wrote:
Add
tmpu -> tpmu
Signed-off-by: Eddie James
Reviewed-by: Ilias Apalodimas
---
include/tpm-v2.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/tpm-v2.h b/include/tpm-v2.h
index 1c644f0048..84034c1559 100644
--- a/include/tpm-v2.h
+++ b/include/tpm-v2.h
@@ -16
Add a configuration option to measure the boot through the bootm
function. Add the measurement state to the booti and bootz paths
as well.
Signed-off-by: Eddie James
---
Changes since v4:
- Change PCR indexes for initrd and dtb
Changes since v2:
- Add measure state to booti and bootz.
- Skip
The driver needs to support getting the PCRs in the capabilities
command. Fix various other things and support the max number
of PCRs for TPM2.
Signed-off-by: Eddie James
Reviewed-by: Simon Glass
Acked-by: Ilias Apalodimas
---
drivers/tpm/tpm2_tis_sandbox.c | 100
mages that should be measured
Changes since v1:
- Refactor TPM layer functions to allow EFI system to use them, and
remove duplicate EFI functions.
- Add test case
- Drop #ifdefs for bootm
- Add devicetree measurement config option
- Update sandbox TPM driver
Eddie James (6):
tpm: Fix sp
Use the sandbox TPM driver to measure some boot images in a unit
test case.
Signed-off-by: Eddie James
Reviewed-by: Simon Glass
---
Changes since v4:
- Drop u8 casting in measurement test
Changes since v2:
- Changed reserved memory address to the top of the RAM for sandbox dts.
arch
Briefly describe the feature and specify the requirements.
Signed-off-by: Eddie James
---
Changes since v4:
- Use bullets for the requirements list
doc/usage/index.rst | 1 +
doc/usage/measured_boot.rst | 23 +++
2 files changed, 24 insertions(+)
create mode
Add TPM2 functions to support boot measurement. This includes
starting up the TPM, initializing/appending the event log, and
measuring the U-Boot version. Much of the code was used in the
EFI subsystem, so remove it there and use the common functions.
Signed-off-by: Eddie James
---
Changes since
On 2/2/23 11:12, Simon Glass wrote:
Hi Eddie / Ilias,
On Thu, 2 Feb 2023 at 09:24, Eddie James wrote:
On 1/26/23 01:51, Ilias Apalodimas wrote:
Hi Eddie,
Thanks for the cleanup! Unfortunately this doesn't compile with EFI
selected, but in general it looks pretty good.
Thanks,
SCL direct drive mode prevents communication with devices that
do clock stretching, so disable. The Linux driver doesn't use
this mode, and the engine can handle clock stretching.
Signed-off-by: Eddie James
---
drivers/i2c/ast_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Add a tpm driver that should support any TPMv2 compliant I2C chips,
such as the NPCT75X chip. In my testing I also noticed that the timeouts
weren't set before requesting the locality so I have included a fix.
Eddie James (2):
tpm: core: Set timeouts before requesting locality
tpm
Requesting the locality uses the timeout values, so they need
to be set beforehand.
Signed-off-by: Eddie James
---
drivers/tpm/tpm2_tis_core.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/tpm/tpm2_tis_core.c b/drivers/tpm/tpm2_tis_core.c
index 51392c4584
Add the tpm2_tis_i2c driver that should support any TPMv2 compliant
I2C chips, such as the NPCT75X chip.
Signed-off-by: Eddie James
---
drivers/tpm/Kconfig| 9 ++
drivers/tpm/Makefile | 1 +
drivers/tpm/tpm2_tis_i2c.c | 171 +
3 files
On 5/23/22 01:12, Ilias Apalodimas wrote:
Hi Eddie,
Thanks for the patch.
[...]
+static const struct tpm_tis_chip_data tpm_tis_std_chip_data = {
+ .pcr_count = 24,
+ .pcr_select_min = 3,
+};
+
+static const struct udevice_id tpm_tis_i2c_ids[] = {
+ {
+ .compa
Set the pinctrl groups for each I2C bus. These are essential to
I2C operating correctly.
Signed-off-by: Eddie James
---
arch/arm/dts/ast2600.dtsi | 33 +
1 file changed, 33 insertions(+)
diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi
index
Add support for the Aspeed SD host controller engine. This involves
adding an MMC SDHCI driver and various additions to the clock and reset
drivers for Aspeed chips.
Signed-off-by: Eddie James
---
arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 +
arch/arm/include/asm/gpio.h
drivers for
Aspeed chips.
Signed-off-by: Eddie James
---
arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 +
arch/arm/include/asm/gpio.h| 3 +-
arch/arm/mach-aspeed/ast2500-board.c | 3 +
drivers/clk/aspeed/clk_ast2500.c | 27 +
drivers
Add code to enable the SD clock on the ast2500 SoC.
Signed-off-by: Eddie James
---
arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 +++
drivers/clk/aspeed/clk_ast2500.c | 27 ++
drivers/pinctrl/aspeed/pinctrl_ast2500.c | 2 ++
3 files changed, 32
Add support for the Aspeed SD host controller engine.
Signed-off-by: Eddie James
---
drivers/mmc/Kconfig| 11 +++
drivers/mmc/Makefile | 1 +
drivers/mmc/aspeed_sdhci.c | 78 ++
3 files changed, 90 insertions(+)
create mode 100644
This series adds support for the SD host controller on Aspeed ast2XXX SocS.
It also enables MMC and the SD controller on the ast2500 EVB.
Changes since v1:
- split the patch up
- Add defconfig and dts changes
Eddie James (4):
clk: aspeed: Add support for SD clock
mmc: Add Aspeed SD
Add nodes for the Aspeed SD controllers with their necessary properties.
Signed-off-by: Eddie James
---
arch/arm/dts/ast2500-evb.dts | 14 ++
arch/arm/dts/ast2500-u-boot.dtsi | 16
2 files changed, 30 insertions(+)
diff --git a/arch/arm/dts/ast2500-evb.dts b
Initialize the MMC subsystem on the ast2500 board. Compile MMC and the
Aspeed SD controller on the ast2500 EVB.
Signed-off-by: Eddie James
---
arch/arm/include/asm/gpio.h | 3 ++-
arch/arm/mach-aspeed/ast2500-board.c | 3 +++
configs/evb-ast2500_defconfig| 6 ++
3 files
On 8/14/19 10:23 AM, Cédric Le Goater wrote:
On 13/08/2019 21:31, Eddie James wrote:
Initialize the MMC subsystem on the ast2500 board. Compile MMC and the
Aspeed SD controller on the ast2500 EVB.
Signed-off-by: Eddie James
---
arch/arm/include/asm/gpio.h | 3 ++-
arch/arm/mach
On 8/14/19 10:18 AM, Cédric Le Goater wrote:
On 13/08/2019 21:31, Eddie James wrote:
Add support for the Aspeed SD host controller engine.
It looks correct and simple enough. Some comments below.
Signed-off-by: Eddie James
---
drivers/mmc/Kconfig| 11 +++
drivers/mmc
Add code to enable the SD clock on the ast2500 SoC.
Reviewed-by: Cédric Le Goater
Signed-off-by: Eddie James
---
arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 3 +++
drivers/clk/aspeed/clk_ast2500.c | 27 ++
drivers/pinctrl/aspeed/pinctrl_ast2500.c
Enable the MMC subsystem and the Aspeed SD controller. Also enable the
use of the device tree for probing the controller.
Signed-off-by: Eddie James
---
configs/evb-ast2500_defconfig | 8
1 file changed, 8 insertions(+)
diff --git a/configs/evb-ast2500_defconfig b/configs/evb
in the driver probe function
Changes since v1:
- Split the patch up
- Add defconfig and devicetree changes
Eddie James (4):
clk: aspeed: Add support for SD clock
mmc: Add Aspeed SD controller driver
configs: AST2500 EVB: Enable SD controller
ARM: dts: ast2500: Add SDHCI nodes
arch/arm
Add nodes for the Aspeed SD controllers with their necessary properties.
Reviewed-by: Cédric Le Goater
Signed-off-by: Eddie James
---
arch/arm/dts/ast2500-evb.dts | 14 ++
arch/arm/dts/ast2500-u-boot.dtsi | 16
2 files changed, 30 insertions(+)
diff --git a
Add support for the Aspeed SD host controller engine.
Signed-off-by: Eddie James
---
arch/arm/include/asm/gpio.h | 3 +-
drivers/mmc/Kconfig | 11 ++
drivers/mmc/Makefile| 1 +
drivers/mmc/aspeed_sdhci.c | 90 +
4 files changed
Add support for the Aspeed SD host controller engine.
Signed-off-by: Eddie James
Reviewed-by: Cédric Le Goater
---
Changes since v3:
- Rebase on master
arch/arm/include/asm/gpio.h | 3 +-
drivers/mmc/Kconfig | 11 ++
drivers/mmc/Makefile| 1 +
drivers/mmc/aspeed_sdhci.c
support for the Aspeed SD host controller engine.
Signed-off-by: Eddie James
---
arch/arm/include/asm/gpio.h | 3 +-
drivers/mmc/Kconfig | 11 ++
drivers/mmc/Makefile| 1 +
drivers/mmc/aspeed_sdhci.c | 90
+
4 files changed, 104
On 3/26/24 11:15, Tim Harvey wrote:
On Tue, Mar 26, 2024 at 2:24 AM Ilias Apalodimas
wrote:
Hi Tim,
On Tue, 26 Mar 2024 at 03:15, Tim Harvey wrote:
Greetings,
I'm unable to understand why tcg2_platform_get_log is failing to read
a memory region.
For example the following diffs:
I am not
On 3/26/24 11:15, Tim Harvey wrote:
On Tue, Mar 26, 2024 at 2:24 AM Ilias Apalodimas
wrote:
Hi Tim,
On Tue, 26 Mar 2024 at 03:15, Tim Harvey wrote:
Greetings,
I'm unable to understand why tcg2_platform_get_log is failing to read
a memory region.
For example the following diffs:
I am not
On 1/16/23 06:00, Ilias Apalodimas wrote:
Hi Eddie
+static inline u16 tpm2_algorithm_to_len(enum tpm2_algorithms a)
+{
+ switch (a) {
+ case TPM2_ALG_SHA1:
+ return TPM2_SHA1_DIGEST_SIZE;
+ case TPM2_ALG_SHA256:
+ return TPM2_SHA256_DIGEST_SIZE;
tions.
- Add test case
- Drop #ifdefs for bootm
- Add devicetree measurement config option
- Update sandbox TPM driver
Eddie James (6):
tpm: Fix spelling for tpmu_ha union
tpm: Support boot measurements
bootm: Support boot measurement
tpm: sandbox: Update for needed TPM2 capabilities
test
tmpu -> tpmu
Signed-off-by: Eddie James
Reviewed-by: Ilias Apalodimas
---
include/tpm-v2.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/tpm-v2.h b/include/tpm-v2.h
index 737e57551d..85feda3e06 100644
--- a/include/tpm-v2.h
+++ b/include/tpm-v2.h
@@ -16
Briefly describe the feature and specify the requirements.
Signed-off-by: Eddie James
---
doc/usage/index.rst | 1 +
doc/usage/measured_boot.rst | 23 +++
2 files changed, 24 insertions(+)
create mode 100644 doc/usage/measured_boot.rst
diff --git a/doc/usage
Add a configuration option to measure the boot through the bootm
function. Add the measurement state to the booti and bootz paths
as well.
Signed-off-by: Eddie James
---
boot/Kconfig| 23
boot/bootm.c| 70 +
cmd/booti.c
Use the sandbox TPM driver to measure some boot images in a unit
test case.
Signed-off-by: Eddie James
---
arch/sandbox/dts/sandbox.dtsi | 14
arch/sandbox/dts/test.dts | 13 +++
configs/sandbox_defconfig | 1 +
include/test/suites.h | 1 +
test/boot/Makefile
Add TPM2 functions to support boot measurement. This includes
starting up the TPM, initializing/appending the event log, and
measuring the U-Boot version. Much of the code was used in the
EFI subsystem, so remove it there and use the common functions.
Signed-off-by: Eddie James
---
include
The driver needs to support getting the PCRs in the capabilities
command. Fix various other things and support the max number
of PCRs for TPM2.
Signed-off-by: Eddie James
Reviewed-by: Simon Glass
---
drivers/tpm/tpm2_tis_sandbox.c | 100 -
1 file changed, 72
On 1/25/23 19:41, Simon Glass wrote:
Hi Eddie,
On Wed, 25 Jan 2023 at 10:18, Eddie James wrote:
Add a configuration option to measure the boot through the bootm
function. Add the measurement state to the booti and bootz paths
as well.
Signed-off-by: Eddie James
---
boot/Kconfig| 23
On 2/4/22 09:24, Simon Glass wrote:
Hi Eddie,
On Thu, 3 Feb 2022 at 15:37, Eddie James wrote:
Use the CONFIG macros to conditionally build the GPIO hogging support in
either the SPL or U-Boot, or both, depending on the configuration. Also
call the GPIO hog probe function in the common SPL
-by: Eddie James
---
common/spl/spl.c | 4
drivers/gpio/Kconfig | 10 ++
drivers/gpio/gpio-uclass.c | 10 ++
3 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c
index 884102bdea..36115e674d 100644
--- a/common/spl
-by: Eddie James
---
Changes since v2:
- change #if to if() in gpio_post_bind
Changes since v1:
- remove #if guards around gpio include
- change #if to if() in spl board_init_r
common/spl/spl.c | 4
drivers/gpio/Kconfig | 10 ++
drivers/gpio/gpio-uclass.c | 8
101 - 163 of 163 matches
Mail list logo