[PATCH v3 08/19] video: mxsfb: add support for i.MXRT

2020-04-08 Thread Giulio Benetti
Add support for i.MXRT by adding CONFIG_IMXRT in register structure and adding .compatible = "fsl,imxrt-lcdif". Signed-off-by: Giulio Benetti --- arch/arm/include/asm/arch-imxrt/imx-regs.h | 6 ++ arch/arm/include/asm/mach-imx/regs-lcdif.h | 6 +++--- drivers/vid

[PATCH v3 09/19] video: mxsfb: refactor for using display_timings

2020-04-08 Thread Giulio Benetti
-by: Giulio Benetti --- drivers/video/mxsfb.c | 54 ++- 1 file changed, 23 insertions(+), 31 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 6826ba3d1b..cdd6dfaced 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c

[PATCH v3 03/19] clk: imx: clk-imxrt1050: setup PLL5 for video in non-SPL

2020-04-08 Thread Giulio Benetti
mxsfb needs PLL5 as source, so let's setup it at its default frequency specified in RM(650Mhz). Signed-off-by: Giulio Benetti Reviewed-by: Lukasz Majewski --- V1->V2: * removed LCDIF set_parent() since it's setup in dts file(suggested by Fabio) --- drivers/clk/imx/clk-imxrt1050.c

[PATCH v3 00/19] i.MXRT1050 add LCDIF support

2020-04-08 Thread Giulio Benetti
->V2: * moved hard-coded LCDIF's parent clock from clk-imxrt1050.c to imxrt1050-evk.dts * reworded some commit log V2->V3: * added comment to describe what is a ctfb in videomodes Giulio Benetti (19): clk: imx: pllv3: add enable_bit clk: imx: clk-imxrt1050: fix typo in clock name "vi

[PATCH v3 05/19] videomodes: add helper function to convert from ctfb to display_timing

2020-04-08 Thread Giulio Benetti
This function converts from "struct ctf_res_modes" to "struct display_timing". Signed-off-by: Giulio Benetti --- V2->V3: * comment function prototype and make it clear what ctfb is --- drivers/video/videomodes.c | 29 + drivers/video/videomode

[PATCH v3 01/19] clk: imx: pllv3: add enable_bit

2020-04-08 Thread Giulio Benetti
pllv3 PLLs have powerdown/up bits but enable bits too. Specifically "enable bit" enable the pll output, so when dis/enabling pll by setting/clearing power_bit we must also set/clear enable_bit. Signed-off-by: Giulio Benetti Reviewed-by: Lukasz Majewski --- drivers/clk/imx/clk-p

[PATCH v3 17/19] arch: arm: dts: imxrt1050-evk: add lcdif node

2020-04-08 Thread Giulio Benetti
Add lcdif node and its pinctrl. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050-evk.dts | 60 ++ 1 file changed, 60 insertions(+) diff --git a/arch/arm/dts/imxrt1050-evk.dts b/arch/arm/dts/imxrt1050-evk.dts index 56b75986e2..b5e781275e 100644 --- a/arch

[PATCH v3 18/19] configs: imxrt1050-evk: enable video support/console

2020-04-08 Thread Giulio Benetti
Enable DM_VIDEO subsystem and its BACKLIGHT_GPIO. Then enable SYS_WHITE_ON_BLACK to have classic black background on display. Need also to enable CONFIG_SYS_CONSOLE_ENV_OVERWRITE to retrieve stdin/stdout/stderr from CONFIG_EXTRA_ENV_SETTINGS. Signed-off-by: Giulio Benetti --- configs/imxrt1050

Re: [PATCH v2 00/19] i.MXRT1050 add LCDIF support

2020-04-15 Thread Giulio Benetti
I've pinged the wrong patchset, sorry for the noise, the right one is v3. -- Giulio Benetti Benetti Engineering sas On 4/15/20 9:51 PM, Giulio Benetti wrote: Kindly ping

Re: [PATCH v2 00/19] i.MXRT1050 add LCDIF support

2020-04-15 Thread Giulio Benetti
Kindly ping -- Giulio Benetti Benetti Engineering sas On 3/22/20 11:48 PM, Giulio Benetti wrote: This patchset passed travis: https://travis-ci.org/github/giuliobenetti/u-boot-imxrt/builds/665577905?utm_medium=notification_source=email And also: ./tools/buildman/buildman.py --branch=dev/imxrt

Re: [PATCH v3 00/19] i.MXRT1050 add LCDIF support

2020-04-15 Thread Giulio Benetti
Kindly ping -- Giulio Benetti Benetti Engineering sas On 4/8/20 5:10 PM, Giulio Benetti wrote: This patchset add support for LCDIF on i.MXRT1050 evk. This requires PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd has inverted PIXCLOCK from dts. With this patchset applied

Re: [PATCH v3 19/19] configs: imxrt1050-evk: temporary disable DCACHE

2020-04-17 Thread Giulio Benetti
Thank you Anatolij -- Giulio Benetti Benetti Engineering sas On 4/17/20 8:33 PM, Anatolij Gustschin wrote: On Wed, 8 Apr 2020 17:11:08 +0200 Giulio Benetti giulio.bene...@benettiengineering.com wrote: mxsfb needs a dcache function not implemented in cortex-M7, so for the moment let's keep

Re: [PATCH v2 04/19] clk: imx: clk-imxrt1050: add set_parent() callback

2020-04-17 Thread Giulio Benetti
Hi Lukasz, On 3/22/20 11:44 PM, Giulio Benetti wrote: Need to add set_parent() callback to allow dts assigned-clock-parents to work so let's add it accordingly. Signed-off-by: Giulio Benetti --- V1->V2: * introduce patch to allow clock's parent setting in dts to work --- drivers/clk/imx/

Re: [PATCH v2 00/19] i.MXRT1050 add LCDIF support

2020-04-16 Thread Giulio Benetti
Hi Fabio, Simon and Anatolij, On 4/16/20 5:23 PM, Fabio Estevam wrote: Hi Giulio, On Thu, Apr 16, 2020 at 12:20 PM Giulio Benetti wrote: Ah I didn't know I had to point someone. So in this case would be either Stefano or Fabio and indeed Fabio answered before here: https://lists.denx.de

Re: [PATCH v3 00/19] i.MXRT1050 add LCDIF support

2020-04-16 Thread Giulio Benetti
Hi Fabio, On 4/16/20 3:26 AM, Fabio Estevam wrote: Hi Giulio, On Wed, Apr 8, 2020 at 12:10 PM Giulio Benetti wrote: This patchset add support for LCDIF on i.MXRT1050 evk. This requires PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd has inverted PIXCLOCK from dts

Re: [PATCH v2 00/19] i.MXRT1050 add LCDIF support

2020-04-16 Thread Giulio Benetti
On 4/16/20 5:08 AM, Simon Glass wrote: Hi Giulio, On Wed, 15 Apr 2020 at 14:05, Giulio Benetti wrote: I've pinged the wrong patchset, sorry for the noise, the right one is v3. -- Giulio Benetti Benetti Engineering sas On 4/15/20 9:51 PM, Giulio Benetti wrote: Kindly ping Who are you

Re: [PATCH 0/5] i.MXRT1020 add basic support

2020-04-18 Thread Giulio Benetti
Hi Stefano, I ping you for reviewing this patchset, Lukasz already reviewed his patches, so it should be ready to be committed. Thank you -- Giulio Benetti Benetti Engineering sas On 2/18/20 8:02 PM, Giulio Benetti wrote: Add Soc i.MXRT1020 to i.MXRT family and its evk support. This Soc has

Re: [PATCH 0/5] i.MXRT1020 add basic support

2020-04-18 Thread Giulio Benetti
On 4/18/20 2:57 PM, Stefano Babic wrote: Hi Giulio, On 18/04/20 14:32, Giulio Benetti wrote: Hi Stefano, I ping you for reviewing this patchset, Lukasz already reviewed his patches, so it should be ready to be committed. Yes, I have already merge the big series after Anatolji's ACK

[PATCH] dt-bindings: pinctrl: imxrt1020: remove useless comment

2020-04-20 Thread Giulio Benetti
A comment note has been left after completing pinctrl listing, so let's remove it since it's useless. Signed-off-by: Giulio Benetti --- include/dt-bindings/pinctrl/pins-imxrt1020.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/dt-bindings/pinctrl/pins-imxrt1020.h b/include/dt

Re: [PATCH v5 06/14] sifive: fu540: add ddr driver

2020-03-13 Thread Giulio Benetti
: DDR PHY base address + * @ctrl : DDR control base address + * @physical_filter_ctrl : DDR physical filter control base address + */ +struct ddr_info { + struct udevice *dev; + struct ram_info info; + struct fu540_ddrctl *ctl; + struct fu540_ddrphy *phy; + u32 *physical_filter_ctrl; +}; IMHO I would keep all these structs and define in driver's .c file, I mean you should keep them private if not used outside. And then add to dt-bindings the define needed by dts files. Best regards -- Giulio Benetti Benetti Engineering sas

[PATCH v2 0/4] Various i.MXRT bug/typo fixes

2020-04-27 Thread Giulio Benetti
Hi Anatolij, Lukasz, Stefano, Fabio, All, this patchset fix 2 bugs preventing from LCDIF to work when booting from sd-card. There are also 2 little typo fixes for boards READMEs. V1->V2: * modify mxfsb.c patch as suggested by Fabio Giulio Benetti (4): imxrt1050-evk: README: fix dd comm

[PATCH v2 3/4] video: mxsfb: add clk_enable()

2020-04-27 Thread Giulio Benetti
BROM doesn't enable lcdif by default so add clk_enable() after clk_set_rate(). Signed-off-by: Giulio Benetti --- V1->V2: * call clk_enable() after clk_set_rate() as suggested by Fabio --- drivers/video/mxsfb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/mxsfb.

[PATCH v2 2/4] imxrt1020-evk: README: fix dd command destination

2020-04-27 Thread Giulio Benetti
Make "of=" the same for the 2 commands since we're writing to the same sd-card. Signed-off-by: Giulio Benetti --- board/freescale/imxrt1020-evk/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/imxrt1020-evk/README b/board/freescale/imxrt1020-

[PATCH v2 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate

2020-04-27 Thread Giulio Benetti
LCDIF clock gate was wrong so set it according to RM. Signed-off-by: Giulio Benetti --- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c index 329f4580c5..8279e784fe 100644

[PATCH v2 1/4] imxrt1050-evk: README: fix dd command destination

2020-04-27 Thread Giulio Benetti
Make "of=" the same for the 2 commands since we're writing to the same sd-card. Signed-off-by: Giulio Benetti --- board/freescale/imxrt1050-evk/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-

Re: [PATCH 3/4] video: mxsfb: add clk_enable()

2020-04-27 Thread Giulio Benetti
Hi Fabio, On 4/27/20 1:48 AM, Fabio Estevam wrote: Hi Giulio, On Sun, Apr 26, 2020 at 8:43 PM Giulio Benetti wrote: + ret = clk_enable(_clk); + if (ret < 0) { + dev_err(dev, "Failed to enable mxs clk: %d\n", ret); + return; + } +

[PATCH] ARM: dts: imxrt1050: indent lcdif node correctly

2020-04-28 Thread Giulio Benetti
Accidentally submitted a patch with indentation not correct, let's fix it by indenting wrong lines. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050

Re: [PATCH v2 1/4] imxrt1050-evk: README: fix dd command destination

2020-04-27 Thread Giulio Benetti
On 4/27/20 5:34 PM, Fabio Estevam wrote: Hi Giulio, On Mon, Apr 27, 2020 at 12:11 PM Giulio Benetti wrote: Make "of=" the same for the 2 commands since we're writing to the same sd-card. Signed-off-by: Giulio Benetti --- board/freescale/imxrt1050-evk/README | 2 +- 1 file

[PATCH v3 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate

2020-04-27 Thread Giulio Benetti
LCDIF clock gate was wrong so set it according to RM. Signed-off-by: Giulio Benetti --- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c index 329f4580c5..8279e784fe 100644

[PATCH v3 1/4] imxrt1050-evk: README: change dd command destination

2020-04-27 Thread Giulio Benetti
Set dd "of=" to "of=/dev/sdX" to be generic and prevent host hard drive damage. Signed-off-by: Giulio Benetti --- V2->V3: * change /dev/sdb to /dev/sdX as suggested by Fabio --- board/freescale/imxrt1050-evk/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v3 2/4] imxrt1020-evk: README: change dd command destination

2020-04-27 Thread Giulio Benetti
Set dd "of=" to "of=/dev/sdX" to be generic and prevent host hard drive damage. Signed-off-by: Giulio Benetti --- V2->V3: * change /dev/sdb to /dev/sdX as suggested by Fabio --- board/freescale/imxrt1020-evk/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v3 3/4] video: mxsfb: add clk_enable()

2020-04-27 Thread Giulio Benetti
BROM doesn't enable lcdif by default so add clk_enable() after clk_set_rate(). Signed-off-by: Giulio Benetti --- V1->V2: * call clk_enable() after clk_set_rate() as suggested by Fabio --- drivers/video/mxsfb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/mxsfb.

[PATCH v3 0/4] Various i.MXRT bug/typo fixes

2020-04-27 Thread Giulio Benetti
Fabio Giulio Benetti (4): imxrt1050-evk: README: change dd command destination imxrt1020-evk: README: change dd command destination video: mxsfb: add clk_enable() clk: imx: clk-imxrt1050: fix lcdif clock gate board/freescale/imxrt1020-evk/README | 4 ++-- board/freescale/imxrt1050-evk/READ

Re: [PATCH v3 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate

2020-04-27 Thread Giulio Benetti
Forgotten to add On 4/27/20 5:53 PM, Giulio Benetti wrote: LCDIF clock gate was wrong so set it according to RM. Signed-off-by: Giulio Benetti Reviewed-by: Anatolij Gustschin Reviewed-by: Fabio Estevam --- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v3 3/4] video: mxsfb: add clk_enable()

2020-04-27 Thread Giulio Benetti
Forgotten to add On 4/27/20 5:53 PM, Giulio Benetti wrote: BROM doesn't enable lcdif by default so add clk_enable() after clk_set_rate(). Signed-off-by: Giulio Benetti Reviewed-by: Anatolij Gustschin Reviewed-by: Fabio Estevam --- V1->V2: * call clk_enable() after clk_set_r

Re: [PATCH v3 0/4] Various i.MXRT bug/typo fixes

2020-04-27 Thread Giulio Benetti
On 4/27/20 5:57 PM, Fabio Estevam wrote: Hi Giulio, On Mon, Apr 27, 2020 at 12:53 PM Giulio Benetti wrote: Hi Anatolij, Lukasz, Stefano, Fabio, All, this patchset fix 2 bugs preventing from LCDIF to work when booting from sd-card. There are also 2 little typo fixes for boards READMEs. V1

[PATCH 0/4] Various i.MXRT bug/typo fixes

2020-04-26 Thread Giulio Benetti
Hi Anatolij, Stefano, Fabio, All, this patchset fix 2 bugs preventing from LCDIF to work when booting from sd-card. There are also 2 little typo fixes for boards READMEs. Giulio Benetti (4): imxrt1050-evk: README: fix dd command destination imxrt1020-evk: README: fix dd command destination

[PATCH 4/4] clk: imx: clk-imxrt1050: fix lcdif clock gate

2020-04-26 Thread Giulio Benetti
LCDIF clock gate was wrong so set it according to RM. Signed-off-by: Giulio Benetti --- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c index 329f4580c5..8279e784fe 100644

[PATCH 3/4] video: mxsfb: add clk_enable()

2020-04-26 Thread Giulio Benetti
BROM doesn't enable lcdif by default so add clk_enable() before clk_set_rate(). Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 8a5a61c9fb..7eab8835b0 100644 --- a/drivers/video

[PATCH 1/4] imxrt1050-evk: README: fix dd command destination

2020-04-26 Thread Giulio Benetti
Make "of=" the same for the 2 commands since we're writing to the same sd-card. Signed-off-by: Giulio Benetti --- board/freescale/imxrt1050-evk/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/imxrt1050-evk/README b/board/freescale/imxrt1050-

Re: [PATCH 0/4] Various i.MXRT bug/typo fixes

2020-04-26 Thread Giulio Benetti
On 4/27/20 1:42 AM, Giulio Benetti wrote: Hi Anatolij, Stefano, Fabio, All, forgotten Lukasz, sorry. -- Giulio Benetti Benetti Engineering sas this patchset fix 2 bugs preventing from LCDIF to work when booting from sd-card. There are also 2 little typo fixes for boards READMEs. Giulio

[PATCH 2/4] imxrt1020-evk: README: fix dd command destination

2020-04-26 Thread Giulio Benetti
Make "of=" the same for the 2 commands since we're writing to the same sd-card. Signed-off-by: Giulio Benetti --- board/freescale/imxrt1020-evk/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/freescale/imxrt1020-evk/README b/board/freescale/imxrt1020-

Re: [PATCH v8 06/21] sifive: fu540: add ddr driver

2020-05-09 Thread Giulio Benetti
+}; + +static const struct udevice_id fu540_ddr_ids[] = { + { .compatible = "sifive,fu540-c000-ddr" }, + { } +}; + +U_BOOT_DRIVER(fu540_ddr) = { + .name = "fu540_ddr", + .id = UCLASS_RAM, + .of_match = fu540_ddr_ids, + .ops = _ddr_ops, + .probe = fu540_ddr_probe, + .priv_auto_alloc_size = sizeof(struct ddr_info), +#if defined(CONFIG_TPL_BUILD) || \ + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) + .platdata_auto_alloc_size = sizeof(struct sifive_dmc_plat), +#endif +}; Best regards -- Giulio Benetti Benetti Engineering sas

Re: [PATCH 03/18] clk: imx: clk-imxrt1050: setup PLL5 for video in non-SPL

2020-03-22 Thread Giulio Benetti
Hi Lukasz, Fabio, On 3/9/20 10:11 AM, Lukasz Majewski wrote: On Sun, 8 Mar 2020 22:05:42 +0100 Giulio Benetti wrote: Hi Lukasz, On 3/8/20 9:27 PM, Lukasz Majewski wrote: On Wed, 26 Feb 2020 18:15:46 +0100 Giulio Benetti wrote: mxsfb needs PLL5 as source, so let's setup it and set

Re: [PATCH 00/18] i.MXRT1050 add LCDIF support

2020-03-22 Thread Giulio Benetti
Hi All, On 2/26/20 6:15 PM, Giulio Benetti wrote: This patchset add support for LCDIF on i.MXRT1050 evk. This requires PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd has inverted PIXCLOCK from dts. With this patchset applied we temporary loose DCache support until

[PATCH v2 07/19] video: mxsfb: add support for DM CLK

2020-03-22 Thread Giulio Benetti
Allow using DM CLK instead of mxs_set_lcdclk() so we can avoid to implement a special function to set lcd clock on i.MXRT. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/drivers/video

[PATCH v2 05/19] videomodes: add helper function to convert from ctfb to display_timing

2020-03-22 Thread Giulio Benetti
This function converts from "struct ctf_res_modes" to "struct display_timing". Signed-off-by: Giulio Benetti --- drivers/video/videomodes.c | 29 + drivers/video/videomodes.h | 3 +++ 2 files changed, 32 insertions(+) diff --git a/drivers/

[PATCH v2 08/19] video: mxsfb: add support for i.MXRT

2020-03-22 Thread Giulio Benetti
Add support for i.MXRT by adding CONFIG_IMXRT in register structure and adding .compatible = "fsl,imxrt-lcdif". Signed-off-by: Giulio Benetti --- arch/arm/include/asm/arch-imxrt/imx-regs.h | 6 ++ arch/arm/include/asm/mach-imx/regs-lcdif.h | 6 +++--- drivers/vid

[PATCH v2 10/19] video: mxsfb: enable setting HSYNC negative polarity

2020-03-22 Thread Giulio Benetti
HSYNC signal can now be flipped according to display_flags bitmaks by writing its bitmask on vdctrl0 register. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video

[PATCH v2 12/19] video: mxsfb: enable setting PIXDATA on negative edge

2020-03-22 Thread Giulio Benetti
DOTCLK signal can now be flipped by writing its bitmask on vdctrl0 register. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 4d33e24e1a..648e1c22fe 100644 --- a/drivers/video

[PATCH v2 09/19] video: mxsfb: refactor for using display_timings

2020-03-22 Thread Giulio Benetti
-by: Giulio Benetti --- drivers/video/mxsfb.c | 54 ++- 1 file changed, 23 insertions(+), 31 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 6826ba3d1b..cdd6dfaced 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c

[PATCH v2 04/19] clk: imx: clk-imxrt1050: add set_parent() callback

2020-03-22 Thread Giulio Benetti
Need to add set_parent() callback to allow dts assigned-clock-parents to work so let's add it accordingly. Signed-off-by: Giulio Benetti --- V1->V2: * introduce patch to allow clock's parent setting in dts to work --- drivers/clk/imx/clk-imxrt1050.c | 19 +++ 1 file changed,

[PATCH v2 02/19] clk: imx: clk-imxrt1050: fix typo in clock name "video:"

2020-03-22 Thread Giulio Benetti
"video:" must be "video", ":" is a typo. Signed-off-by: Giulio Benetti Reviewed-by: Lukasz Majewski --- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/cl

[PATCH v2 01/19] clk: imx: pllv3: add enable_bit

2020-03-22 Thread Giulio Benetti
pllv3 PLLs have powerdown/up bits but enable bits too. Specifically "enable bit" enable the pll output, so when dis/enabling pll by setting/clearing power_bit we must also set/clear enable_bit. Signed-off-by: Giulio Benetti Reviewed-by: Lukasz Majewski --- drivers/clk/imx/clk-p

[PATCH v2 06/19] sunxi: display: use common video_ctfb_mode_to_display_timing()

2020-03-22 Thread Giulio Benetti
Since video_ctfb_mode_to_display_timing() has been implemented by moving sunxi_ctfb_mode_to_display_timing() to video_modes.c and it's meant to be used by other video subsystem, let's use it instead of local sunxi_ctfb_mode_to_display_timing(). Signed-off-by: Giulio Benetti --- drivers/video

[PATCH v2 11/19] video: mxsfb: enable setting VSYNC negative polarity

2020-03-22 Thread Giulio Benetti
VSYNC signal can now be flipped by writing its bitmask on vdctrl0 register. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 9912cf3d82..4d33e24e1a 100644 --- a/drivers/video/mxsfb.c

[PATCH v2 14/19] imxrt1050_evk: add 16bpp video support if video layer enabled

2020-03-22 Thread Giulio Benetti
i.MXRT1050 provides mxsfb compatible lcd controller, so let's enable video mxsfb driver with 16bpp depth if CONFIG_DM_VIDEO is selected since board has 16bpp only connection. Signed-off-by: Giulio Benetti --- include/configs/imxrt1050-evk.h | 15 +++ 1 file changed, 15 insertions

Re: [PATCH v2 00/19] i.MXRT1050 add LCDIF support

2020-03-22 Thread Giulio Benetti
=../BUILD/ Best regards -- Giulio Benetti Benetti Engineering sas On 3/22/20 11:44 PM, Giulio Benetti wrote: This patchset add support for LCDIF on i.MXRT1050 evk. This requires PLL5 to be setup, mxsfb needs to use display_timing to retrieve if Lcd has inverted PIXCLOCK from dts. With this patchset

Re: [PATCH v2 15/19] ARM: dts: i.mxrt1050: add lcdif node

2020-03-22 Thread Giulio Benetti
Sorry I've sent this patch twice. -- Giulio Benetti Benetti Engineering sas On 3/22/20 11:44 PM, Giulio Benetti wrote: Add lcdif node to SoC. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/dts

[PATCH v2 17/19] arch: arm: dts: imxrt1050-evk: add lcdif node

2020-03-22 Thread Giulio Benetti
Add lcdif node and its pinctrl. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050-evk.dts | 60 ++ 1 file changed, 60 insertions(+) diff --git a/arch/arm/dts/imxrt1050-evk.dts b/arch/arm/dts/imxrt1050-evk.dts index 56b75986e2..b5e781275e 100644 --- a/arch

[PATCH v2 15/19] ARM: dts: i.mxrt1050: add lcdif node

2020-03-22 Thread Giulio Benetti
Add lcdif node to SoC. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050.dtsi index b1d98e6feb..0123f4788c 100644 --- a/arch/arm/dts/imxrt1050.dtsi +++ b/arch/arm/dts

[PATCH v2 16/19] ARM: dts: imxrt1050: allow this dtsi file to be compiled in Linux

2020-03-22 Thread Giulio Benetti
Linux doesn't provide skeleton.dtsi file so let's remove its include and provide #address-cells/size-cells = <1> that were defined in skeleton.dtsi before. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v2 13/19] video: mxsfb: enable setting ENABLE negative polarity

2020-03-22 Thread Giulio Benetti
ENABLE signal can now be flipped by writing its bitmask on vdctrl0 register. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 648e1c22fe..8a5a61c9fb 100644 --- a/drivers/video

[PATCH v2 19/19] configs: imxrt1050-evk: temporary disable DCACHE

2020-03-22 Thread Giulio Benetti
mxsfb needs a dcache function not implemented in cortex-M7, so for the moment let's keep dcache not enabled. Signed-off-by: Giulio Benetti --- configs/imxrt1050-evk_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/imxrt1050-evk_defconfig b/configs/imxrt1050-evk_defconfig

[PATCH v2 18/19] configs: imxrt1050-evk: enable video support/console

2020-03-22 Thread Giulio Benetti
Enable DM_VIDEO subsystem and its BACKLIGHT_GPIO. Then enable SYS_WHITE_ON_BLACK to have classic black background on display. Need also to enable CONFIG_SYS_CONSOLE_ENV_OVERWRITE to retrieve stdin/stdout/stderr from CONFIG_EXTRA_ENV_SETTINGS. Signed-off-by: Giulio Benetti --- configs/imxrt1050

[PATCH v2 15/19] ARM: dts: i.mxrt1050: add lcdif node

2020-03-22 Thread Giulio Benetti
Add lcdif node to SoC. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050.dtsi index b1d98e6feb..0123f4788c 100644 --- a/arch/arm/dts/imxrt1050.dtsi +++ b/arch/arm/dts

[PATCH v2 00/19] i.MXRT1050 add LCDIF support

2020-03-22 Thread Giulio Benetti
->V2: * moved hard-coded LCDIF's parent clock from clk-imxrt1050.c to imxrt1050-evk.dts * reworded some commit log Giulio Benetti (19): clk: imx: pllv3: add enable_bit clk: imx: clk-imxrt1050: fix typo in clock name "video:" clk: imx: clk-imxrt1050: setup PLL5 for video in non-S

[PATCH v2 03/19] clk: imx: clk-imxrt1050: setup PLL5 for video in non-SPL

2020-03-22 Thread Giulio Benetti
mxsfb needs PLL5 as source, so let's setup it at its default frequency specified in RM(650Mhz). Signed-off-by: Giulio Benetti Reviewed-by: Lukasz Majewski --- V1->V2: * removed LCDIF set_parent() since it's setup in dts file(suggested by Fabio) --- drivers/clk/imx/clk-imxrt1050.c

Re: [PATCH v2 05/19] videomodes: add helper function to convert from ctfb to display_timing

2020-03-23 Thread Giulio Benetti
On 3/23/20 4:36 PM, Simon Glass wrote: Hi Giulio, On Sun, 22 Mar 2020 at 16:44, Giulio Benetti wrote: This function converts from "struct ctf_res_modes" to "struct display_timing". Signed-off-by: Giulio Benetti --- drivers/video/videomodes.c | 29 +++

Re: [PATCH v2 05/19] videomodes: add helper function to convert from ctfb to display_timing

2020-03-23 Thread Giulio Benetti
On 3/23/20 7:42 PM, Simon Glass wrote: Hi Giulio, On Mon, 23 Mar 2020 at 10:00, Giulio Benetti wrote: On 3/23/20 4:36 PM, Simon Glass wrote: Hi Giulio, On Sun, 22 Mar 2020 at 16:44, Giulio Benetti wrote: This function converts from "struct ctf_res_modes" to "struct

Re: i.MX RT1050 toolchain

2020-10-16 Thread Giulio Benetti
correctly Best regards -- Giulio Benetti Benetti Engineering sas

Re: i.MX RT1050 toolchain

2020-10-18 Thread Giulio Benetti
, that should make it easier. Kind regards -- Giulio Benetti Benetti Engineering sas

Re: i.MX RT1050 toolchain

2020-10-18 Thread Giulio Benetti
> Il giorno 18 ott 2020, alle ore 14:53, Andy Pont > ha scritto: > > Giulio wrote… > >> Perfect, I suggest you to test it on a EVK before than going with your >> custom board if you can, and after port your board, that should make it >> easier. > I certainly will do! One supplementary

[RFC] VIDEO_MXS in Kconfig and SUNXI video DM

2020-12-30 Thread Giulio Benetti
board supports. What about that? Best regards -- Giulio Benetti Benetti Engineering sas

Re: [PATCH] sunxi: display: introduce "sunxi-video" environment variable

2021-01-11 Thread Giulio Benetti
On 1/11/21 10:48 AM, Maxime Ripard wrote: Hi, On Mon, Jan 11, 2021 at 10:13:32AM +0100, Giulio Benetti wrote: From: Giulio Benetti At the moment you can specify lcd_mode only through hardcoded CONFIG_VIDEO_LCD_MODE but this way, if you have a board with multiple lcds compatible, you have

[PATCH] sunxi: display: introduce "sunxi-video" environment variable

2021-01-11 Thread Giulio Benetti
From: Giulio Benetti At the moment you can specify lcd_mode only through hardcoded CONFIG_VIDEO_LCD_MODE but this way, if you have a board with multiple lcds compatible, you have to rebuild u-boot for every single lcd, so let's add sunxi-video environment variable to give the possibility

Re: [PATCH 0/5] Fix i.MXRT1050 hang on lcdif init and improve DT for mxsfb

2021-05-12 Thread Giulio Benetti
Hi Stefano, On 5/2/21 1:44 AM, Giulio Benetti wrote: On 4/13/21 1:05 AM, Giulio Benetti wrote: On 4/13/21 1:03 AM, Giulio Benetti wrote: This patchset fixes u-boot hang on i.MXRT1050 while setting lcdif in mxsfb driver. There are 2 gates to be enabled to initialize mxsfb so let's introduce

[PATCH v3 00/22] Fix i.MXRT1020/50

2021-05-13 Thread Giulio Benetti
lcdif init hang * improve some commit log --- Giulio Benetti (22): arm: imxrt: soc: make mpu regions generic timer: imx-gpt: Add timer support for i.MX SoCs family ARM: dts: imxrt1020: add node label to osc ARM: dts: imxrt1020: add gpt1 node ARM: dts: imxrt1020-evk: enable gpt1 timer AR

[PATCH v3 02/22] timer: imx-gpt: Add timer support for i.MX SoCs family

2021-05-13 Thread Giulio Benetti
This timer driver uses GPT Timer (General Purpose Timer) available on a lot of i.MX SoCs family. This driver deals with both 24Mhz oscillator as well as peripheral clock. Signed-off-by: Giulio Benetti [Giulio: added the driver's stub and handled peripheral clock prescaler setting making driver

[PATCH v3 06/22] ARM: dts: imxrt1020-evk: set gpt1 as tick-timer for u-boot

2021-05-13 Thread Giulio Benetti
Let's set gpt1 as u-boot timer. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1020-evk.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/imxrt1020-evk.dts b/arch/arm/dts/imxrt1020-evk.dts index a471ff3838..b527206fcf 100644 --- a/arch/arm/dts/imxrt1020-evk.dts +++ b

[PATCH v3 04/22] ARM: dts: imxrt1020: add gpt1 node

2021-05-13 Thread Giulio Benetti
Add gpt1 node for using it as timer. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1020.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/imxrt1020.dtsi b/arch/arm/dts/imxrt1020.dtsi index 0a3a3b451a..cab608c644 100644 --- a/arch/arm/dts/imxrt1020.dtsi +++ b

[PATCH v3 05/22] ARM: dts: imxrt1020-evk: enable gpt1 timer

2021-05-13 Thread Giulio Benetti
Enable gpt1 timer. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1020-evk.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imxrt1020-evk.dts b/arch/arm/dts/imxrt1020-evk.dts index ece13601bd..a471ff3838 100644 --- a/arch/arm/dts/imxrt1020-evk.dts +++ b/arch/arm/dts

[PATCH v3 08/22] ARM: dts: imxrt1020-evk: add device_type = "memory" to memory node

2021-05-13 Thread Giulio Benetti
Now device_type = "memory" is mandatory to allow u-boot to read memory node, so let's add it to memory node. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1020-evk.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/imxrt1020-evk.dts b/arch/arm/dts/imxrt1020-evk

[PATCH v3 12/22] ARM: dts: imxrt1050-evk: enable gpt1 timer

2021-05-13 Thread Giulio Benetti
Enable gpt1 timer. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050-evk.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imxrt1050-evk.dts b/arch/arm/dts/imxrt1050-evk.dts index b5e781275e..e592330332 100644 --- a/arch/arm/dts/imxrt1050-evk.dts +++ b/arch/arm/dts

[PATCH v3 09/22] configs: imxrt1020-evk: enable imx gpt timer as tick-timer

2021-05-13 Thread Giulio Benetti
Let's enable imx-gpt-timer in imx1020-evk defconfig. Signed-off-by: Giulio Benetti --- configs/imxrt1020-evk_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/imxrt1020-evk_defconfig b/configs/imxrt1020-evk_defconfig index ad408ebef8..f0b05b7165 100644 --- a/configs

[PATCH v3 03/22] ARM: dts: imxrt1020: add node label to osc

2021-05-13 Thread Giulio Benetti
Let's add node label to osc to be used as clock source for other nodes. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1020.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/imxrt1020.dtsi b/arch/arm/dts/imxrt1020.dtsi index 97f3cec9f3..0a3a3b451a 100644

[PATCH v3 10/22] ARM: dts: imxrt1050: add node label to osc

2021-05-13 Thread Giulio Benetti
Let's add node label to osc to be used as clock source for other nodes. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050.dtsi index a9281001e5..b7cc3fbc2a 100644

[PATCH v3 17/22] video: mxsfb: add enabling of "axi" clock other than "per" clock

2021-05-13 Thread Giulio Benetti
y with already existing .dts lcdif nodes implementation. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index e1fd36a62d..147bd668fe 100644 --- a/drivers/v

[PATCH v3 16/22] configs: imxrt1050-evk: enable imx gpt timer as tick-timer

2021-05-13 Thread Giulio Benetti
Let's enable imx-gpt-timer in imx1050-evk defconfig. Signed-off-by: Giulio Benetti --- configs/imxrt1050-evk_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/imxrt1050-evk_defconfig b/configs/imxrt1050-evk_defconfig index d03572e7db..9c8bdb07dc 100644 --- a/configs

[PATCH v3 01/22] arm: imxrt: soc: make mpu regions generic

2021-05-13 Thread Giulio Benetti
This mpu handling works for every i.MXRT SoC that we have, so let's generalize imxrt1050_region_config to imxrt_region_config. Signed-off-by: Giulio Benetti --- arch/arm/mach-imx/imxrt/soc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/imxrt/soc.c

Re: [PATCH v3 18/22] video: mxsfb: add enabling of "disp_axi" clock

2021-05-13 Thread Giulio Benetti
Sorry for this patch sent twice. My e-mail provider doesn't let me send more than 18 e-mail at a time, so I need to send it in 2 times and I've left this. Best regards -- Giulio Benetti Benetti Engineering sas On 5/13/21 12:19 PM, Giulio Benetti wrote: Some SoC needs "disp_axi&q

[PATCH v3 22/22] ARM: dts: imxrt1050-evk: remove u-boot,dm-spl

2021-05-13 Thread Giulio Benetti
We don't need lcdif to be enable in SPL, so let's remove u-boot,dm-spl. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050-evk.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/dts/imxrt1050-evk.dts b/arch/arm/dts/imxrt1050-evk.dts index dc66fc9c37..81db1a446d 100644

[PATCH v3 20/22] ARM: dts: imxrt1050: move lcdif assigned clock to dtsi

2021-05-13 Thread Giulio Benetti
Since we assume pll5 is the default lcdif clock source let's move assigned-clocks(-parents) properties to .dtsi file. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050-evk.dts | 3 --- arch/arm/dts/imxrt1050.dtsi| 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v3 11/22] ARM: dts: imxrt1050: add gpt1 node

2021-05-13 Thread Giulio Benetti
Add gpt1 node for using it as timer. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/imxrt1050.dtsi index b7cc3fbc2a..6f9da3fe8a 100644 --- a/arch/arm/dts/imxrt1050.dtsi +++ b

[PATCH v3 19/22] clk: imx: clk-imxrt1050: introduce LCDIF_PIX and rename LCDIF to LCDIF_APB

2021-05-13 Thread Giulio Benetti
Lcd peripheral needs 2 different gates to be enable to work, so let's introduce the missing one(LCDIF_PIX) and rename the existing one (LCDIF_APB). Signed-off-by: Giulio Benetti --- drivers/clk/imx/clk-imxrt1050.c | 6 -- include/dt-bindings/clock/imxrt1050-clock.h | 5 +++-- 2

[PATCH v3 21/22] ARM: dts: imxrt1050: set lcdif clocks according to mxsfb driver

2021-05-13 Thread Giulio Benetti
Lcdif needs both "pix" and "axi" clocks to be enabled so let's add them to lcdif node. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/imxrt1050.dtsi b/arch/arm/dts/

[PATCH v3 18/22] video: mxsfb: add enabling of "disp_axi" clock

2021-05-13 Thread Giulio Benetti
Some SoC needs "disp_axi" clock to be enabled, so let's try to retrieve it and enabling. If it fails it gives only a debug(), but this clock as well as "axi" clock is not mandatory. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 11 +++ 1 file changed, 11

[PATCH v3 07/22] ARM: dts: imxrt1020-evk-u-boot: make gpt1 present for SPL

2021-05-13 Thread Giulio Benetti
Timer needs to be already enabled in spl, so let's add its node to spl dtb. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1020-evk-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imxrt1020-evk-u-boot.dtsi b/arch/arm/dts/imxrt1020-evk-u-boot.dtsi index

[PATCH v3 14/22] ARM: dts: imxrt1050-evk-u-boot: make gpt1 present for SPL

2021-05-13 Thread Giulio Benetti
Timer needs to be already enabled in spl, so let's add its node to spl dtb. Signed-off-by: Giulio Benetti --- arch/arm/dts/imxrt1050-evk-u-boot.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/dts/imxrt1050-evk-u-boot.dtsi b/arch/arm/dts/imxrt1050-evk-u-boot.dtsi index

[PATCH v3 18/22] video: mxsfb: add enabling of "disp_axi" clock

2021-05-13 Thread Giulio Benetti
Some SoC needs "disp_axi" clock to be enabled, so let's try to retrieve it and enabling. If it fails it gives only a debug(), but this clock as well as "axi" clock is not mandatory. Signed-off-by: Giulio Benetti --- drivers/video/mxsfb.c | 11 +++ 1 file changed, 11

<    1   2   3   4   5   >