Re: [U-Boot] [PATCH 0/8] Initial integration of AVB2.0

ombine the AVB with A/B which I think should be >> two separate feature, are you going to split them? >> >> BTW, do you have plan to update boot_android cmd to support avb? >> the command is too weak for use now. >> And any plan to add opptee_client/smcc to tal

Re: [U-Boot] [PATCH 4/8] cmd: avb2.0: avb command for performing verification

elCase question?) > > Hi Igor, > > On 15 May 2018 at 11:31, Igor Opaniuk <igor.opan...@linaro.org> wrote: >> On 15 May 2018 at 19:26, Simon Glass <s...@chromium.org> wrote: >>> Hi Igor, >>> >>> On 16 May 2018 at 01:44, Igor Opaniuk <i

Re: [U-Boot] [PATCH 8/8] doc: avb2.0: add README about AVB2.0 integration

Hi Sam, Thanks, will include this notice in the v2 patchset Regards, Igor On 2 May 2018 at 22:12, Sam Protsenko <semen.protse...@linaro.org> wrote: > On 25 April 2018 at 16:18, Igor Opaniuk <igor.opan...@linaro.org> wrote: >> Contains: >> 1. Overview of And

Re: [U-Boot] [PATCH 4/8] cmd: avb2.0: avb command for performing verification

On 15 May 2018 at 19:26, Simon Glass <s...@chromium.org> wrote: > Hi Igor, > > On 16 May 2018 at 01:44, Igor Opaniuk <igor.opan...@linaro.org> wrote: >> Hi Simon, >> >> I've dug into DriverModel documentation and even created a PoC for >> existing avb

Re: [U-Boot] [PATCH 4/8] cmd: avb2.0: avb command for performing verification

within the same uclass in this case? Could you please explain in detail. Thanks Hi Sam, Thanks, will fix! On 3 May 2018 at 05:31, Simon Glass <s...@chromium.org> wrote: > Hi Igor, > > On 25 April 2018 at 07:18, Igor Opaniuk <igor.opan...@linaro.org> wrote: >> Enable

Re: [U-Boot] [PATCH 0/8] Initial integration of AVB2.0

ion_descriptor.h" > #include "../../lib/libavb/avb_crypto.h" > #include "../../lib/libavb/avb_descriptor.h" > #include "../../lib/libavb/avb_footer.h" > #include "../../lib/libavb/avb_hash_descriptor.h" > ---<-snip->--- > > And

[U-Boot] [PATCH v2 8/8] doc: avb2.0: add README about AVB2.0 integration

Contains: 1. Overview of Android Verified Boot 2.0 2. Description of avb subset of commands 3. Examples of errors when boot/vendor/system/vbmeta partitions are tampered 4. Examples of enabling AVB2.0 on your setup Signed-off-by: Igor Opaniuk --- doc/README.avb2 | 97

[U-Boot] [PATCH v2 7/8] test/py: avb2.0: add tests for avb commands

1. Run AVB 2.0 full verification chain, avb verify 2. Check if 'avb get_uuid' works, compare results with 'part list mmc 1' output 3. Test `avb read` commands, which reads N bytes from a partition identified by a name Signed-off-by: Igor Opaniuk --- test/py/tests/test_avb.py | 111

[U-Boot] [PATCH v2 5/8] avb2.0: add boot states and dm-verity support

1. Add initial support of boot states mode (red, green, yellow) 2. Add functions for enforcing dm-verity configurations Signed-off-by: Igor Opaniuk --- cmd/avb.c| 17 ++- common/avb_verify.c | 137 +-- include/avb_verify.h | 19

[U-Boot] [PATCH v2 6/8] am57xx_hs: avb2.0: add support of AVB 2.0

1. Add vbmeta partition info to android partition layout for am57xx SoC 2. Add support of AVB 2.0 (including avb subset of commands) for am57xx HS Signed-off-by: Igor Opaniuk --- include/configs/am57xx_evm.h | 11 +++ include/environment/ti/boot.h | 15 +++ 2 files changed

[U-Boot] [PATCH v2 4/8] cmd: avb2.0: avb command for performing verification

print uuid of a partition avb read_part - read data from partition avb read_part_hex - read data from partition and output to stdout avb write_part - write data to partition avb verify - run full verification chain Signed-off-by: Igor Opaniuk --- cmd/Kconfig | 16 +++ cmd/Makefile | 3 +

[U-Boot] [PATCH v2 3/8] avb2.0: implement AVB ops

is unlocked [1] https://android.googlesource.com/platform/external/avb/+/master/README.md Signed-off-by: Igor Opaniuk --- common/Makefile | 2 + common/avb_verify.c | 610 +++ include/avb_verify.h | 79 +++ 3 files changed, 691 insertions

[U-Boot] [PATCH v2 2/8] avb2.0: integrate avb 2.0 into the build system

Integrate libavb into the build system. Introduce CONFIG_LIBAVB build option. Signed-off-by: Igor Opaniuk --- lib/Kconfig | 14 ++ lib/Makefile| 1 + lib/libavb/Makefile | 15 +++ 3 files changed, 30 insertions(+) create mode 100644 lib/libavb/Makefile

[U-Boot] [PATCH v2 0/8] Initial integration of AVB2.0

umentation - Updated avb_slot_verify invocation, supplying with new AvbHashtreeErrorMode param - Fixed array boundary exceeded error when handling bootargs in avb_find_dm_args Igor Opaniuk (8): avb2.0: add Android Verified Boot 2.0 library avb2.0: integrate avb 2.0 into the build system avb2.0:

Re: [U-Boot] [PATCH v3 1/1] avb2.0: add get_size_of_partition()

Sam, Could you please double-check this patch and confirm that your tag can be still applied? Thanks! On 10 August 2018 at 17:06, Andrew F. Davis wrote: > On 08/10/2018 08:59 AM, Igor Opaniuk wrote: >> Implement get_size_of_partition() operation, >> which is required by the

Re: [U-Boot] [PATCH 7/7] common: avb_verify: Fix division by zero in mmc_byte_io()

Thanks for fixing this! Reviewed-by: Igor Opaniuk On 14 August 2018 at 03:43, Eugeniu Rosca wrote: > Compiling U-Boot with ubsan/asan libraries and running it in sandbox > may lead to below backtrace: > > => avb init 0 > => avb verify > ## Android Verifie

Re: [U-Boot] [PATCH 6/7] common: avb_verify: Fix never-occurring avb_free(ops_data)

Thanks for fixing this! Reviewed-by: Igor Opaniuk On 14 August 2018 at 03:43, Eugeniu Rosca wrote: > Cppcheck (v1.85) reports w/o this patch: > > [common/avb_verify.c:738] -> [common/avb_verify.c:741]: (warning) \ > Either the condition 'ops' is redundant or there i

Re: [U-Boot] [PATCH 2/7] common: avb_verify: Fix invalid 'for' loop condition

Reviewed-by: Igor Opaniuk On 14 August 2018 at 03:43, Eugeniu Rosca wrote: > Fix below compiler [1] warning: > > common/avb_verify.c: In function ‘avb_find_dm_args’: > common/avb_verify.c:179:30: warning: left-hand operand of comma expression > has no effect [-Wunused-value] &g

Re: [U-Boot] [PATCH 1/7] libavb: Handle wrong hashtree_error_mode in avb_append_options()

Reviewed-by: Igor Opaniuk On 14 August 2018 at 03:43, Eugeniu Rosca wrote: > From: Ievgen Maliarenko > > Exit with AVB_SLOT_VERIFY_RESULT_ERROR_INVALID_ARGUMENT > when hashtree_error_mode value passed to avb_append_options() > is unknown (not from AvbHashtreeErrorMode enum)

Re: [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS

perations" > depends on LIBAVB && FASTBOOT > + depends on PARTITION_UUIDS > help > This option enables compilation of bootloader-dependent operations, > used by Android Verified Boot 2.0 library (libavb). Includes: > -- > 2.18.0 > -- Regards, Igor Opaniuk ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 4/7] common: avb_verify: Make local data static

-by: Igor Opaniuk On 14 August 2018 at 03:43, Eugeniu Rosca wrote: > Fix sparse complaint: > > common/avb_verify.c:14:21: warning: \ > symbol 'avb_root_pub' was not declared. Should it be static? > > Signed-off-by: Eugeniu Rosca > --- > common/avb_verify.c | 2 +- >

Re: [U-Boot] [PATCH 5/7] common: avb_verify: Fix memory leaks

Reviewed-by: Igor Opaniuk On 14 August 2018 at 03:43, Eugeniu Rosca wrote: > Cppcheck (v1.85) reports w/o this patch: > > [common/avb_verify.c:351]: (error) Memory leak: part > [common/avb_verify.c:356]: (error) Memory leak: part > [common/avb_verify.c:361]: (error) Memory leak:

Re: [U-Boot] [PATCH 06/10] tee: add OP-TEE driver

Tested-by: Igor Opaniuk On 13 August 2018 at 18:53, Jens Wiklander wrote: > Adds a OP-TEE driver. > > * Targets ARM and ARM64 > * Supports using any u-boot memory as shared memory > * Probes OP-TEE version using SMCs > * Uses OPTEE message protocol version 2 to communicate

Re: [U-Boot] [PATCH 03/10] mmc: rpmb: add mmc_rpmb_route_frames()

As I didn't have any available Hikey board, tested this on Poplar: Tested-by: Igor Opaniuk BTW, we've had it up for discussion already, but just to clarify and summarize: As ID of eMMC is hardcoded in the OP-TEE OS core (CFG_RPMB_FS_DEV_ID), we will probably have issues on some platforms, where

Re: [U-Boot] [PATCH 04/10] Add UCLASS_TEE for Trusted Execution Environment

Tested this on Poplar: Tested-by: Igor Opaniuk On 13 August 2018 at 18:53, Jens Wiklander wrote: > Adds a uclass to interface with a TEE (Trusted Execution Environment). > > A TEE driver is a driver that interfaces with a trusted OS running in > some secure environment, for exampl

Re: [U-Boot] [PATCH 10/10] avb_verify: support using OP-TEE TA AVB

Rollback index: 4 Otherwise: Tested-by: Igor Opaniuk On 14 August 2018 at 14:20, Igor Opaniuk wrote: > Hi Jens, > > Could you please also add info about CONFIG_OPTEE_TA_AVB to the > existing doc/README.avb2 and more description of > how/where rollback indexes/device lock state are st

Re: [U-Boot] [PATCH 08/10] optee: support routing of rpmb data frames to mmc

Tested-by: Igor Opaniuk On 13 August 2018 at 18:53, Jens Wiklander wrote: > Adds support in optee supplicant to route signed (MACed) RPMB frames > from OP-TEE Secure OS to MMC and vice versa to manipulate the RPMB > partition. > > Signed-off-by: Jens Wiklander > --- &g

Re: [U-Boot] [PATCH 09/10] tee: optee: support AVB trusted application

Tested-by: Igor Opaniuk On 13 August 2018 at 18:53, Jens Wiklander wrote: > Adds configuration option OPTEE_TA_AVB and a header file describing the > interface to the AVB trusted application provided by OP-TEE. > > Signed-off-by: Jens Wiklander > --- > MAINTAINERS

Re: [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS

Hi Eugeniu, Makes sense, thanks for the explanation. Reviewed-by: Igor Opaniuk On 16 August 2018 at 21:25, Eugeniu Rosca wrote: > Hi Igor, > > First, thanks for the reviews! > > On Thu, Aug 16, 2018 at 11:38:18AM +0300, Igor Opaniuk wrote: >> Hi Eugeniu, >> >&

[U-Boot] [PATCH v3 1/1] avb2.0: add get_size_of_partition()

Implement get_size_of_partition() operation, which is required by the latest upstream libavb [1]. [1] https://android.googlesource.com/platform/external/avb/+/android-p-preview-5 Signed-off-by: Igor Opaniuk --- Changes for v3: - reword commit message, added avblib repository link, that stick

Re: [U-Boot] [PATCH 02/10] cmd: avb read_rb: print rb_idx in hexadecimal

Typo in the commit message "hexadeciaml number", otherwise: Reviewed-by: Igor Opaniuk On 13 August 2018 at 18:53, Jens Wiklander wrote: > Prior to this patch was do_avb_write_rb() reading supplied rb_idx as a > hexadecimal number while do_avb_read_rb() printed the read out rb_

Re: [U-Boot] [PATCH 10/10] avb_verify: support using OP-TEE TA AVB

+ if (rc) > + return rc; > + *out_is_unlocked = !param.u.value.a; > + return AVB_IO_RESULT_OK; > +#endif > } > > /** > @@ -737,6 +862,11 @@ void avb_ops_free(AvbOps *ops) > > ops_data = ops-&

Re: [U-Boot] [PATCH 09/10] tee: optee: support AVB trusted application

Reviewed-by: Igor Opaniuk On 16 August 2018 at 15:22, Igor Opaniuk wrote: > Tested-by: Igor Opaniuk > > On 13 August 2018 at 18:53, Jens Wiklander wrote: >> Adds configuration option OPTEE_TA_AVB and a header file describing the >> interface to the AVB trusted applicati

Re: [U-Boot] [PATCH 00/10] AVB using OP-TEE

gt; -- >>> 2.17.1 >>> >> >> I missed the Android Verified Boot stuff going in. I did see the v1 >> patch but not the v2. >> >> Was there discussion of coding style for lib/libavb? > > I don't know. It was Igor wh

[U-Boot] [PATCH v2 0/2] avb2.0: fix multiple compilation issues in sandbox

roper dependencies") commit message (added more details). - Extended description of AVB_VERIFY Kconfig symbol. - Replaced CONFIG_LIBAVB to CONFIG_AVB_VERIFY in common/Makefile. Igor Opaniuk (2): avb2.0: add proper dependencies avb2.0: use block API in AVB ops cmd/Kconfig | 2 +- comm

[U-Boot] [PATCH v2 1/2] avb2.0: add proper dependencies

to access MMC, similar to drivers/fastboot/fb_mmc.c. * Helpers to alloc/init/free avb ops. 2. Add CONFIG_FASTBOOT dependency, as fastboot buffer is re-used in partition verification operations. Reported-by: Eugeniu Rosca Signed-off-by: Igor Opaniuk --- cmd/Kconfig | 2 +- common/Kconfig | 10

[U-Boot] [PATCH v2 2/2] avb2.0: use block API in AVB ops

Use blk_dread()/blk_dwrite() in mmc_read()/mmc_write() AVB operation implementations. This fixes compilation issues when CONFIG_BLK is enabled. Signed-off-by: Igor Opaniuk --- common/avb_verify.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/common/avb_verify.c b

[U-Boot] [PATCH v2 1/1] avb2.0: add get_size_of_partition()

Implement get_size_of_partition() operation, which is required by the latest upstream libavb [1]. [1] https://android.googlesource.com/platform/external/avb/+/master/README.md Signed-off-by: Igor Opaniuk --- Changes for v2: - changed the return code for the case when out_size_num_bytes is NULL

[U-Boot] [PATCH 0/2] avb 2.0: fix multiple compilation issues in sandbox

CONFIG_FASTBOOT dependency, as fastboot buffer is re-used in partition verification operations. 3. Use blk_dread()/blk_dwrite() in mmc_read()/mmc_write() AVB operation implementations. This fixes compilation issues when CONFIG_BLK is enabled. Igor Opaniuk (2): avb2.0: add proper dependencies avb2.0: use

[U-Boot] [PATCH 1/2] avb2.0: add proper dependencies

Rosca Signed-off-by: Igor Opaniuk --- cmd/Kconfig | 2 +- common/Kconfig | 7 +++ doc/README.avb2 | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index aec2090..b3e030c 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1771,7 +1771,7 @@ config

[U-Boot] [PATCH 2/2] avb2.0: use block API in AVB ops

Use blk_dread()/blk_dwrite() in mmc_read()/mmc_write() AVB operation implementations. This fixes compilation issues when CONFIG_BLK is enabled. Signed-off-by: Igor Opaniuk --- common/avb_verify.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/common/avb_verify.c b

[U-Boot] [PATCH 1/1] avb2.0: add proper dependencies to libavb

Rosca Signed-off-by: Igor Opaniuk --- lib/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib/Kconfig index a77bf1c..4780e7e 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -191,7 +191,7 @@ menu "Android Verified Boot" config LIBAVB boo

Re: [U-Boot] [PATCH 1/1] avb2.0: add proper dependencies to libavb

Hi Eugeniu, Makes sense, will re-send this patch soon with changes based on your suggestions. Thanks Regards, Igor On 12 July 2018 at 12:27, Eugeniu Rosca wrote: > Hi Igor, > > Thanks for the fix. See my comments below. > > On Thu, Jul 12, 2018 at 10:34:24AM +0300, Igo

Re: [U-Boot] [PATCH 1/1] avb2.0: add get_size_of_partition()

and CONFIG_FASTBOOT_BUF_SIZE) The problem is that both CONFIG_FASTBOOT_BUF_ADDR and CONFIG_FASTBOOT_BUF_SIZE are defined for most platforms, and this is how I missed this issue. Will fix today and re-test, Thanks On 9 July 2018 at 18:33, Eugeniu Rosca wrote: > On Mon, Jul 09, 2018 at 03:15:54PM +0300, Igor Opan

[U-Boot] [PATCH 1/1] avb2.0: add get_size_of_partition()

Implement get_size_of_partition() operation, which is required by the latest upstream libavb [1]. [1] https://android.googlesource.com/platform/external/avb/+/master/README.md Signed-off-by: Igor Opaniuk --- common/avb_verify.c | 33 - 1 file changed, 32

Re: [U-Boot] [PATCH 1/1] avb2.0: add get_size_of_partition()

Hi Andrew, Sorry I missed your message. On 9 July 2018 at 18:21, Andrew F. Davis wrote: > On 07/09/2018 09:52 AM, Sam Protsenko wrote: >> On Mon, Jul 9, 2018 at 3:15 PM, Igor Opaniuk wrote: >>> Implement get_size_of_partition() operation, >>> which is required by th

[U-Boot] [PATCH 0/8] Initial integration of AVB2.0

in the future, that's why minimal amount of changes were introduced into the lib sources, so checkpatch may fail. For additional details check [1] AVB 2.0 README and doc/README.avb2, which is a part of this patchset. [1] https://android.googlesource.com/platform/external/avb/+/master/README.md Igor Opaniuk

[U-Boot] [PATCH 3/8] avb2.0: implement AVB ops

is unlocked [1] https://android.googlesource.com/platform/external/avb/+/master/README.md Signed-off-by: Igor Opaniuk <igor.opan...@linaro.org> --- common/Makefile | 2 + common/avb_verify.c | 614 +++ include/avb_verify.h | 80 +++ 3

[U-Boot] [PATCH 2/8] avb2.0: integrate avb 2.0 into the build system

Integrate libavb/libavb_ab into the build system. Introduce CONFIG_LIBAVB and CONFIG_LIBAVB_AVB options for enabling build. Signed-off-by: Igor Opaniuk <igor.opan...@linaro.org> --- lib/Kconfig| 20 lib/Makefile | 2 ++ lib/libavb/Makefile

[U-Boot] [PATCH 7/8] test/py: avb2.0: add tests for avb commands

1. Run AVB 2.0 full verification chain, avb verify 2. Check if 'avb get_uuid' works, compare results with 'part list mmc 1' output 3. Test `avb read` commands, which reads N bytes from a partition identified by a name Signed-off-by: Igor Opaniuk <igor.opan...@linaro.org> --- test/py

[U-Boot] [PATCH 8/8] doc: avb2.0: add README about AVB2.0 integration

Contains: 1. Overview of Android Verified Boot 2.0 2. Description of avb subset of commands 3. Examples of errors when boot/vendor/system/vbmeta partitions are tampered 4. Examples of enabling AVB2.0 on your setup Signed-off-by: Igor Opaniuk <igor.opan...@linaro.org> --- doc/README.avb2

[U-Boot] [PATCH 5/8] avb2.0: add boot states and dm-verity support

1. Add initial support of boot states mode (red, green, yellow) 2. Add functions for enforcing dm-verity configurations Signed-off-by: Igor Opaniuk <igor.opan...@linaro.org> --- cmd/avb.c| 17 ++- common/avb_verify.c

[U-Boot] [PATCH 6/8] am57xx_hs: avb2.0: add support of AVB 2.0

1. Add vbmeta partition info to android partition layout for am57xx SoC 2. Add support of AVB 2.0 (including avb subset of commands) for am57xx HS Signed-off-by: Igor Opaniuk <igor.opan...@linaro.org> --- configs/am57xx_hs_evm_defconfig | 3 +++ include/configs/am57xx_evm.h

[U-Boot] [PATCH 4/8] cmd: avb2.0: avb command for performing verification

print uuid of a partition avb read_part - read data from partition avb read_part_hex - read data from partition and output to stdout avb write_part - write data to partition avb verify - run full verification chain Signed-off-by: Igor Opaniuk <igor.opan...@linaro.org> --- cmd/Kconfig

Re: [U-Boot] [PATCH 0/8] Initial integration of AVB2.0

ify" removed) Best regards, Igor > > Thanks, > - Kever > On 04/25/2018 09:17 PM, Igor Opaniuk wrote: >> This series of patches introduces support of Android Verified Boot 2.0, >> which provides integrity checking of Android partitions on MMC. >> >> It int

Re: [U-Boot] [PATCH v2 4/7] cmd: Add 'ab_select' command

" Android slot metadata with a boot attempt, which can > cause\n" > + " successive calls to this function to return a different > result\n" > + " if the returned slot runs out of boot attempts.\n" > + "- If 'part_name' is passed, preceded with a # instead of :, > the\n" > + " partition name whose label is 'part_name' will be looked up > in\n" > + " the partition table. This is commonly the \"misc\" > partition.\n" > +); > -- > 2.7.4 > With/without my minor comments addressed: Reviewed-by: Igor Opaniuk -- Regards, Igor Opaniuk ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 3/7] common: Implement A/B metadata

t andr_bl_msg message; > + char slot_suffix[32]; > + char update_channel[128]; > + > + /* Round up the entire struct to 4096-byte */ > + char reserved[1888]; > +}; > + > +#define ANDROID_BOOT_CTRL_MAGIC 0x42414342 /* Bootloader Control AB */ > +#define ANDROID

Re: [U-Boot] [PATCH v2 7/7] env: am57xx: Implement A/B boot process

Reviewed-by: Igor Opaniuk On Wed, 12 Dec 2018 at 19:12, Ruslan Trofymenko wrote: > > Add support for A/B boot process on AM57xx based boards: > > 1. Define 'slot_suffix' variable (using 'ab_select' command) > 2. Extend 'emmc_android_boot' boot command (add comman

[U-Boot] [PATCH v3 1/1] avb: add support for named persistent values

values. Correspondent pull request in the OP-TEE OS project repo [2]. [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 [2]: https://github.com/OP-TEE/optee_os/pull/2699 Signed-off-by: Igor Opaniuk --- Changes in v3: - fix possible mem lick in avb_read_persistent

[U-Boot] [RESEND v3 1/1] avb: add support for named persistent values

values. Correspondent pull request in the OP-TEE OS project repo [2]. [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 [2]: https://github.com/OP-TEE/optee_os/pull/2699 Signed-off-by: Igor Opaniuk --- Changes in v3: - fix possible mem lick in avb_read_persistent

[U-Boot] [PATCH v1 1/1] arm64: dt: poplar: add optee node

As Poplar supports running TF-A with OP-TEE as BL32 payload, add op-tee node in DT, which enables usage of OP-TEE driver (which provides an interface for requesting services from OP-TEE). Signed-off-by: Igor Opaniuk --- arch/arm/dts/hi3798cv200-poplar.dts | 7 +++ 1 file changed, 7

Re: [U-Boot] [PATCH v2 1/7] cmd: part: Add 'number' sub-command

Reviewed-by: Igor Opaniuk On Wed, 12 Dec 2018 at 19:12, Ruslan Trofymenko wrote: > > This sub-command serves for getting the partition index from > partition name. Also it can be used to test the existence of specified > partition. > > Signed-off-by: Ruslan Trofymenko >

Re: [U-Boot] [PATCH v2 6/7] doc: android: Add simple guide for A/B updates

Reviewed-by: Igor Opaniuk On Wed, 12 Dec 2018 at 19:12, Ruslan Trofymenko wrote: > > Add a short documentation for A/B enablement and 'ab_select' command > usage. > > Signed-off-by: Ruslan Trofymenko > Reviewed-by: Alistair Strachan > Reviewed-by: Sam Protsenko

[U-Boot] [RESEND PATCH 1/1] avb: add support for named persistent values

values. Correspondent pull request in the OP-TEE OS project repo [2]. [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 [2]: https://github.com/OP-TEE/optee_os/pull/2699 Signed-off-by: Igor Opaniuk --- cmd/avb.c | 78

[U-Boot] [PATCH 1/1] avb2.0: add support for named persistent values

request in the OP-TEE OS project repo [2]. [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 [2]: https://github.com/OP-TEE/optee_os/pull/2699 Signed-off-by: Igor Opaniuk --- cmd/avb.c | 78 + common/avb_verify.c

Re: [U-Boot] [PATCH 09/13] serial: Remove DM_FLAG_PRE_RELOC flag in various drivers

.probe = stm32_serial_probe, > +#if !CONFIG_IS_ENABLED(OF_CONTROL) > .flags = DM_FLAG_PRE_RELOC, > +#endif > }; > > #ifdef CONFIG_DEBUG_UART_STM32 > diff --git a/drivers/serial/serial_xuartlite.c > b/drivers/serial/serial_xuartlite.c > index cead3c6..1be77

Re: [U-Boot] [PATCH v2 1/1] avb: add support for named persistent values

Update: Patch for OP-TEE AVB trusted application (which introduces implementation for persistent named values support on secure world side) was successfully merged [1]. [1]: https://github.com/OP-TEE/optee_os/pull/2699 On Fri, 14 Dec 2018 at 19:45, Igor Opaniuk wrote: > > AVB versi

Re: [U-Boot] [PATCH v2 1/1] avb: add support for named persistent values

Hi Simon, Could you please point me to the update test you mean? (I assume it's "test_avb.py"?) Thanks BR, Igor On Sat, 22 Dec 2018 at 22:52, Simon Glass wrote: > > Hi Igor, > > On Fri, 14 Dec 2018 at 10:45, Igor Opaniuk wrote: > > > > AVB versio

Re: [U-Boot] [PATCH v2 1/1] avb: add support for named persistent values

ok, np. will send in v3 patch On Thu, 27 Dec 2018 at 17:12, Simon Glass wrote: > > Hi Igor, > > On Thu, 27 Dec 2018 at 07:50, Igor Opaniuk wrote: > > > > Hi Simon, > > > > Could you please point me to the update test you mean? (I assume it's > > &quo

Re: [U-Boot] [PATCH] poplar: fix boot failure caused by serial driver change

Hi Shawn, Thanks, that fixes the problem! Reviewed-by: Igor Opaniuk Tested-by: Igor Opaniuk On Wed, 12 Dec 2018 at 09:25, Shawn Guo wrote: > > Commit 4687919684e0 ("serial: Remove DM_FLAG_PRE_RELOC flag in various > drivers") essentially drops flag DM_FLAG_PRE_RELOC from se

[U-Boot] [PATCH v2 1/1] avb: add support for named persistent values

values. Correspondent pull request in the OP-TEE OS project repo [2]. [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 [2]: https://github.com/OP-TEE/optee_os/pull/2699 Signed-off-by: Igor Opaniuk --- Changes in v2: - fix output format for avb read_pvalue/write_pvalue

[U-Boot] [PATCH 1/1] tee: change return code for REE FS supplicant cmd

/lib/libutee/tee_api_objects.c#L419 [2]: https://globalplatform.org/wp-content/uploads/2018/06/GPD_TEE_Internal_Core_API_Specification_v1.1.2.50_PublicReview.pdf Signed-off-by: Igor Opaniuk --- drivers/tee/optee/supplicant.c | 4 ++-- include/tee.h | 1 + 2 files changed, 3

Re: [U-Boot] [U-Boot, RESEND, v3, 1/1] avb: add support for named persistent values

Hi Tom, Thanks for notifying, I totally forgot about sandbox tee driver emulation (I've run these tests only on real hardware :( ). Will fix and send v4 ASAP. Regards, Igor On Sat, 26 Jan 2019 at 15:14, Tom Rini wrote: > > On Thu, Jan 17, 2019 at 02:17:00PM +0200, Igor Opaniuk

[U-Boot] [RESEND PATCH v4 1/1] avb: add support for named persistent values

values. Correspondent pull request in the OP-TEE OS project repo [2]. [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 [2]: https://github.com/OP-TEE/optee_os/pull/2699 Signed-off-by: Igor Opaniuk --- v4: - extend tee sandbox tee driver to support persistent values

[U-Boot] [PATCH v4 1/1] avb: add support for named persistent values

values. Correspondent pull request in the OP-TEE OS project repo [2]. [1]: https://android.googlesource.com/platform/external/avb/+/android-9.0.0_r22 [2]: https://github.com/OP-TEE/optee_os/pull/2699 Signed-off-by: Igor Opaniuk --- v4: - extend tee sandbox tee driver to support persistent values

Re: [U-Boot] [PATCH v1 04/14] apalis/colibri_imx6/imx6ull: make sure loadaddr does not collide

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:36 PM Marcel Ziswiler wrote: > > From: Stefan Agner > > Currently $loadaddr and $fdt_addr_r point to the same address. This > might be not ideal for some distro boot scripts which make use of > $loadaddr after loadi

Re: [U-Boot] [PATCH v1 07/14] colibri-imx6ull: configuration clean-up

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:39 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Drop disabling SPL_SYS_THUMB_BUILD as we anyway do not use SPL. > Enbale CRC32 verify, USB SDP and EFI loader support. > Drop CMD_GPT and disabling RANDOM_UUID.

Re: [U-Boot] [PATCH v1 09/14] colibri-imx6ull: migrate mmc to using driver model

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:38 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Migrate MMC to using driver model. > Migrate USDHC to using pinctrl. > While at it also add GPIO1_IO03__OSC32K_32K_OUT pin muxing. > While at it also up

Re: [U-Boot] [PATCH v1 01/14] tdx-cfg-block: add support for new colibri iMX6ull skus

Hi Marcel, Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:35 PM Marcel Ziswiler wrote: > > From: Gerard Salvatella > > Add support for new Colibri iMX6ULL SKUs. > > While at it also checkpatch fix the whole files. > > Signed-off-by: Gerard Salvatella >

Re: [U-Boot] [PATCH v1 03/14] colibri-imx6ull: set module variant depending on config block

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:36 PM Marcel Ziswiler wrote: > > From: Stefan Agner > > Using CPU temperature grading as a discriminator if the Wi-Fi / > Bluetooth chip is populated is no longer possible due to upcoming > SKUs. Set variant to -wifi only

Re: [U-Boot] [PATCH v1 14/14] ARM: dts: colibri-imx6ull: update device tree

Hi Marcel, Reviewed-by: Igor Opaniuk Please also check my comments below, thanks! On Fri, Mar 29, 2019 at 1:41 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Fix compatible node to use regular Toradex notation. > Annotate device tree with standard Colibri pin muxing

Re: [U-Boot] [PATCH v1 12/14] ARM: dts: colibri-imx6ull: fix uart-has-rtscts property

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:40 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Remove vendor pre-fix fsl, from uart-has-rtscts property. > > Signed-off-by: Marcel Ziswiler > > --- > > arch/arm/dts/imx6ull-colibri.dts | 7 +-- &

Re: [U-Boot] [PATCH v1 08/14] colibri-imx6ull: migrate pinctrl and regulators to dtb/dm

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:40 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Migrate pinctrl and regulators to device tree resp. driver model: > Ethernet, NAND and UART. > Drop BOARD_EARLY_INIT_F as it is anyway no longer used. > E

Re: [U-Boot] [PATCH v1 02/14] tdx-cfg-block: simplify i.MX 6 module detection

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:36 PM Marcel Ziswiler wrote: > > From: Stefan Agner > > Use CONFIG_TARGET_... at compile time to differentiate between > Apalis iMX6, Colibri iMX6 and Colibri iMX6ULL. Avoid code > duplication by moving question about Wi-Fi

Re: [U-Boot] [PATCH v1 05/14] colibri-imx6ull: fix ethernet phy power on

___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot -- Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http

Re: [U-Boot] [PATCH v1 06/14] board: imx6ull: Add disable PMIC_STBY_REQ

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:41 PM Marcel Ziswiler wrote: > > From: Philippe Schenker > > Disable output driver of PAD CCM_PMIC_STBY_REQ. This prevents the > SOC to request for a lower voltage during sleep. This is necessary > because the voltage is

Re: [U-Boot] [PATCH v1 13/14] ARM: dts: colibri-imx6ull: add osc32k_32k_out pinctrl

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:42 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Add GPIO1_IO03__OSC32K_32K_OUT pin muxing. > While at it also fix indentation of pinfunc header file. > > Signed-off-by: Marcel Ziswiler > > --- > >

Re: [U-Boot] [PATCH v1 11/14] colibri-imx6ull: migrate fec to using driver model

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 1:39 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Migrate Ethernet FEC to using driver model. > Drop PHY_MICREL_KSZ90X1 which slipped in from Apalis iMX6. > > Signed-off-by: Marcel Ziswiler > > --

[U-Boot] [PATCH 1/1] colibri_imx6: use UUID for rootfs

Replace usage of "/dev/mmcblk*p*" with a proper UUID of rootfs partition. This fixes the issue, when MMC controllers are probed in a different order in U-boot and Linux kernel. Signed-off-by: Igor Opaniuk --- configs/colibri_imx6_defconfig | 1 + include/configs/colibri_i

Re: [U-Boot] [PATCH v2 2/3] toradex: common: unify behaviour when config block is missing

Reviewed-by: Igor Opaniuk On Mon, Mar 25, 2019 at 6:19 PM Marcel Ziswiler wrote: > > From: Bhuvanchandra DV > > If the config block is missing, various things may fail or behave > strangely on certain modules. This patch unifies that behaviour by > using a fake MAC address,

Re: [U-Boot] [RESEND RFC PATCH v1] MLK-12883 usb: limit USB_MAX_XFER_BLK to 256

There is a typo in the comment: USB Massstorage Also regarding refering to a specific commit ("(cherry picked from commit df0052575b2bc9d66ae73584768e1a457ed5d914)" line): > If you want to refer to a specific commit, don’t just refer to the SHA-1 ID > of the commit. > Please also include the

Re: [U-Boot] [PATCH v2 11/22] colibri_vf: migrate fec, esdhc, nfc and usb to driver model

Reviewed-by: Igor Opaniuk On Mon, Mar 25, 2019 at 6:30 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Migrate FEC, ESDHC, NFC and USB to driver model. > > While at it also do no longer enable optional I2C clock in board file as > the generic clock code now handles

Re: [U-Boot] [PATCH v2 20/22] colibri_vf: adjust timing according to data sheet

Reviewed-by: Igor Opaniuk On Mon, Mar 25, 2019 at 6:32 PM Marcel Ziswiler wrote: > > From: Stefan Agner > > Using the DDR Validation tool in Processor Expert uncovered two > timing inconsistencies. Since those timings are related to the > suspend mode they do not affect

Re: [U-Boot] [PATCH v2 13/22] colibri_vf: add distroboot support

Hi Marcel, Reviewed-by: Igor Opaniuk Please check some minor comments below (could be addressed in a separate patchset): On Mon, Mar 25, 2019 at 6:35 PM Marcel Ziswiler wrote: > > From: Stefan Agner > > Add support for distro boot. This is especially helpful for extern

Re: [U-Boot] [PATCH v2 14/22] colibri_vf: set fdtfile for distroboot

Reviewed-by: Igor Opaniuk On Mon, Mar 25, 2019 at 6:32 PM Marcel Ziswiler wrote: > > From: Stefan Agner > > Set fdtfile to represent the current board. This allows distribution > to load the correct device tree, which in the module case often > deviates from the common fallb

Re: [U-Boot] [PATCH v1] apalis/colibri_imx6: add device trees to makefile

Hi Marcel, Could you please provide steps to reproduce this issue? I've double checked on the latest master of u-boot-imx, and can sucessfully build U-boot for Colibri iMX6DL (as an example). Thanks On Mon, Mar 25, 2019 at 6:38 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Add

Re: [U-Boot] [PATCH v2 10/22] colibri_vf: migrate pinctrl and regulators to dtb/dm

Reviewed-by: Igor Opaniuk On Mon, Mar 25, 2019 at 6:30 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Migrate pinctrl and regulators to device tree resp. driver model: DDR, > DSPI, ENET, ESDHC, I2C, NFC and UART. > > Enable CMD_DM, PINCTRL and DM_REGULATOR. > &

Re: [U-Boot] [PATCH v2 09/22] configs: colibri_vf: disable obscure options

Hi Marcel, The actual line which does have impact is `CONFIG_DFU_MMC=y`. Not sure I understand the reason of adding "# ... is not set" lines in this defconfig. Could you please explain? Regards, Igor On Mon, Mar 25, 2019 at 6:30 PM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Disable

Re: [U-Boot] [PATCH v1] colibri_vf: fix ethernet by adding explicit phy node

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 12:25 AM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > The implicit fallback mechanism for searching the whole MDIO bus for at > least one PHY has been gone with the following commit b882005a18de > ("drivers/ne

Re: [U-Boot] [PATCH v1] colibri_vf: fix tab vs. spaces

Reviewed-by: Igor Opaniuk On Fri, Mar 29, 2019 at 12:25 AM Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > Fix indentation using tab vs. spaces. > > Signed-off-by: Marcel Ziswiler > > --- > > board/toradex/colibri_vf/MAINTAINERS | 2 +- > 1 file ch

  1   2   3   4   5   6   7   8   9   10   >