Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Joakim Tjernlund
> > Need to check that location is valid on RAM before the fixup. Why this change? The [PATCH RFC] armv7: fixloop: don't fixup if location is NULL should be what you need. You could mention what causes these NULL fixups, here is commit entry for powerpc: powerpc: do not fixup NULL ptrs The f

[U-Boot] [PATCH 4/4] powerpc: Add LINK_OFF calls in early C-code.

2010-12-20 Thread Joakim Tjernlund
Only these 2 call sites depends on fixups for my mpc8321 based board. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/mpc83xx/cpu_init.c |2 +- arch/powerpc/lib/board.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx

[U-Boot] [PATCH 2/4] mpc83xx: Add link vs. load address calculation

2010-12-20 Thread Joakim Tjernlund
link_off calculates the difference between link address and actual load address. This is a must for true PIC u-boot. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/mpc83xx/start.S | 26 ++ include/common.h |7 +++ 2 files changed, 33

[U-Boot] [PATCH 3/4] mpc83xx: Add true PIC support.

2010-12-20 Thread Joakim Tjernlund
-base option to gcc. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/mpc83xx/start.S | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S index 16aed0a..af44fdd 100644

[U-Boot] [PATCH 1/4] mpc83xx: Make start.S true PIC

2010-12-20 Thread Joakim Tjernlund
Remove dependencies on link address. Use GOT and add an new function to calculate the actual address. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/mpc83xx/start.S | 35 +++ 1 files changed, 27 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/cpu

Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-17 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/12/17 17:13:47: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > Great! then we got: > > > [PATCH] PowerPC: Move -fPIC flag to common place > > > [PATCH] PowerPC: Add support for -msingle-pic-base

Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-17 Thread Joakim Tjernlund
> > Kim Phillips wrote on 2010/12/14 00:05:11: > > On Thu, 9 Dec 2010 13:02:58 -0600 > > Scott Wood wrote: > > > > > On Fri, 3 Dec 2010 10:30:38 -0600 > > > "Joakim Tjernlund" wrote: > > > > > > > By rearranging

[U-Boot] -Wundef anyone?

2010-12-16 Thread Joakim Tjernlund
Anyone tried to compile u-boot with -Wundef? It generates a lot of warnings that potentially hides bugs. The Linux kernel added -Wundef long ago to avoid these hidden bugs. Jocke ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailm

Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-13 Thread Joakim Tjernlund
Kim Phillips wrote on 2010/12/14 00:05:11: > On Thu, 9 Dec 2010 13:02:58 -0600 > Scott Wood wrote: > > > On Fri, 3 Dec 2010 10:30:38 -0600 > > "Joakim Tjernlund" wrote: > > > > > By rearranging the linker script we get support for > > >

Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-11 Thread Joakim Tjernlund
Scott Wood wrote on 2010/12/10 21:34:59: > > On Thu, 9 Dec 2010 21:30:16 +0100 > Joakim Tjernlund wrote: > > > > > If not, is there anything special I need to test it (specific > > > > toolchain?) besides these two patches? > > > > > > No,

Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-09 Thread Joakim Tjernlund
> > > > > > On Fri, 3 Dec 2010 10:30:38 -0600 > > "Joakim Tjernlund" wrote: > > > > > By rearranging the linker script we get support for > > > relocation of -fpic for free. > > > Move __got2_entries outside _GOT2_TABLE_ defining

Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-09 Thread Joakim Tjernlund
> > On Fri, 3 Dec 2010 10:30:38 -0600 > "Joakim Tjernlund" wrote: > > > By rearranging the linker script we get support for > > relocation of -fpic for free. > > Move __got2_entries outside _GOT2_TABLE_ defining scope > > matching the rest of P

Re: [U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-09 Thread Joakim Tjernlund
> > By rearranging the linker script we get support for > relocation of -fpic for free. > Move __got2_entries outside _GOT2_TABLE_ defining scope > matching the rest of PowerPC > > Signed-off-by: Joakim Tjernlund Ping? ___ U-Boo

Re: [U-Boot] [PATCH 1/2] PowerPC: Add relocation support for -fpic

2010-12-09 Thread Joakim Tjernlund
> > By rearranging the linker script we get support for > relocation of -fpic for free. > > Signed-off-by: Joakim Tjernlund Ping? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH 1/2] hashtable: drop all non-reentrant versions

2010-12-08 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/12/08 15:23:17: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > oh, and this does shrink the final u-boot a little, so that's good > > > -mike > > > > Nice, over the last years I have noti

Re: [U-Boot] [RFC PATCH 1/2] hashtable: drop all non-reentrant versions

2010-12-08 Thread Joakim Tjernlund
> > On Wednesday, December 08, 2010 06:26:04 Mike Frysinger wrote: > > The non-reentrant versions of the hashtable functions operate on a single > > shared hashtable. So if two different people try using these funcs for > > two different purposes, they'll cause problems for the other. > > > > Avoi

Re: [U-Boot] [PATCH] ppc: transform init_sequence into a function.

2010-12-07 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/12/07 14:07:56: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > > MPC8321 and BDI2000. I have to play games with some internal > > > > BDI command called SAP. Maybe they have fixed this in la

Re: [U-Boot] [PATCH] ppc: transform init_sequence into a function.

2010-12-07 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/12/07 07:34:49: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > > though the loop is cumbersome and not easy as BDI tends to > > > > flush the cache when it stops so you loose your stack. > >

Re: [U-Boot] [PATCH] ppc: transform init_sequence into a function.

2010-12-06 Thread Joakim Tjernlund
Scott Wood wrote on 2010/12/07 01:21:44: > > On Tue, 7 Dec 2010 01:07:30 +0100 > Joakim Tjernlund wrote: > > > Scott Wood wrote on 2010/12/06 23:49:04: > > > > > > On Tue, 7 Dec 2010 09:36:40 +1100 > > > Graeme Russ wrote: > > &

Re: [U-Boot] [PATCH] ppc: transform init_sequence into a function.

2010-12-06 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/12/06 23:36:21: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > This is indeed much uglier. What exactly is your problem with > > > debugging the existing code? > > > > Whenever I screw u

Re: [U-Boot] [PATCH] ppc: transform init_sequence into a function.

2010-12-06 Thread Joakim Tjernlund
Scott Wood wrote on 2010/12/06 23:49:04: > > On Tue, 7 Dec 2010 09:36:40 +1100 > Graeme Russ wrote: > > > On Tue, Dec 7, 2010 at 8:33 AM, Scott Wood wrote: > > > I think it's easier with the function pointers -- if you want to debug > > > a hang in that phase of the boot, just have the loop prin

Re: [U-Boot] [PATCH] ppc: transform init_sequence into a function.

2010-12-06 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/12/06 21:09:47: > > Dear Joakim Tjernlund, > > In message <1291658370-26367-1-git-send-email-joakim.tjernl...@transmode.se> > you wrote: > > init_sequence is an array with function pointers which > > are really hard to follow when you

[U-Boot] [PATCH] ppc: transform init_sequence into a function.

2010-12-06 Thread Joakim Tjernlund
data bss dec hex filename 1268 212 01480 5c8 lib_ppc/board.org 1224 92 01316 524 lib_ppc/board.new Signed-off-by: Joakim Tjernlund --- So I had to do debug this area again and I am getting really tiered of following function pointers so

Re: [U-Boot] [PATCH 1/2] Add support for XZ decompression algorithm.

2010-12-06 Thread Joakim Tjernlund
> > XZ (aka LZMA2) is the new version of lzma compression format. > The following patch add a cut-down version of XZ Embedded library (v20100702) > that supports only single-call API. > > In order to enable XZ support, the CONFIG_XZ must be defined by board > configuration file. > > For any details

[U-Boot] [PATCH] PowerPC: Add support for -msingle-pic-base

2010-12-06 Thread Joakim Tjernlund
-off-by: Joakim Tjernlund --- arch/powerpc/config.mk|2 ++ arch/powerpc/cpu/74xx_7xx/start.S | 11 ++- arch/powerpc/cpu/mpc512x/start.S | 11 ++- arch/powerpc/cpu/mpc5xx/start.S | 11 ++- arch/powerpc/cpu/mpc5xxx/start.S | 11 ++- arch

[U-Boot] [PATCH] PowerPC: Move -fPIC flag to common place

2010-12-06 Thread Joakim Tjernlund
) \ + flag_pic = 2;\ } while (0) #ifndef RS6000_BI_ARCH -- Signed-off-by: Joakim Tjernlund --- arch/powerpc/config.mk |2 +- arch/powerpc/cpu/74xx_7xx/config.mk |2 +- arch/powerpc/cpu/mpc512x/config.mk |2 +- arch/powerpc

Re: [U-Boot] [PATCH] LZMA: Avoid free on null pointer.

2010-12-06 Thread Joakim Tjernlund
ecause > the library is "one shot" and the other free are called (if called) > just to deallocate all structures (that are surely not null). There is nothing to fix, just move on. I will and consider this matter closed. > > best regards, > > luigi > > On Mon, De

Re: [U-Boot] [PATCH] LZMA: Avoid free on null pointer.

2010-12-06 Thread Joakim Tjernlund
> > On Mon, Dec 6, 2010 at 9:57 AM, Mike Frysinger wrote: > > > > sorry, but this is not an acceptable reason.  so unless you have an actual > > error report here, your patch gets NAK-ed. > > -mike > > > > Hi mike, > > my pov is different: free should (must) be called only on already > allocated p

Re: [U-Boot] [PATCH] LZMA: Avoid free on null pointer.

2010-12-05 Thread Joakim Tjernlund
Luigi Mantellini wrote on 2010/12/05 11:19:58: > On Sun, Dec 5, 2010 at 11:12 AM, Joakim Tjernlund > wrote: > >> > >> On structure Initialization, LZMA code tries to free the dictionary > >> and probs buffers, also when these are null pointers. Add some > >

Re: [U-Boot] [PATCH] LZMA: Avoid free on null pointer.

2010-12-05 Thread Joakim Tjernlund
> > On structure Initialization, LZMA code tries to free the dictionary > and probs buffers, also when these are null pointers. Add some > check in order to prevent the free on null pointers. > > Signed-off-by: Luigi 'Comio' Mantellini Why not move these NULL checks inside LzmaDec_FreeProbs? Then

Re: [U-Boot] [PATCH 2/6 v2] LZMA: Avoid free on null pointer

2010-12-04 Thread Joakim Tjernlund
> > Dear Luigi 'Comio' Mantellini, > > In message <1291469358-25023-3-git-send-email-luigi.mantell...@idf-hit.com> > you wrote: > > > > Signed-off-by: Luigi 'Comio' Mantellini > > --- > > lib/lzma/LzmaDec.c |4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/li

[U-Boot] [PATCH 1/2] PowerPC: Add relocation support for -fpic

2010-12-03 Thread Joakim Tjernlund
By rearranging the linker script we get support for relocation of -fpic for free. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/74xx_7xx/u-boot.lds |5 +++-- arch/powerpc/cpu/mpc512x/u-boot.lds |5 +++-- arch/powerpc/cpu/mpc5xx/u-boot.lds |5 +++-- arch/powerpc/cpu/mpc5xxx

[U-Boot] [PATCH 2/2] PowerPC, nand_spl: Add relocation support for -fpic

2010-12-03 Thread Joakim Tjernlund
By rearranging the linker script we get support for relocation of -fpic for free. Move __got2_entries outside _GOT2_TABLE_ defining scope matching the rest of PowerPC Signed-off-by: Joakim Tjernlund --- nand_spl/board/freescale/mpc8313erdb/u-boot.lds |4 +++- nand_spl/board/freescale

Re: [U-Boot] [PATCH] mpc83xx: remove some dead code, saving space

2010-11-30 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/30 22:17:31: > > On Tue, 30 Nov 2010 22:13:32 +0100 > Joakim Tjernlund wrote: > > > Scott Wood wrote on 2010/11/30 21:50:52: > > > > > > On Tue, 30 Nov 2010 21:45:19 +0100 > > > Joakim Tjernlund wrote: > > > &g

Re: [U-Boot] [PATCH] mpc83xx: remove some dead code, saving space

2010-11-30 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/30 21:50:52: > > On Tue, 30 Nov 2010 21:45:19 +0100 > Joakim Tjernlund wrote: > > > On a related note, I am not sure why the I and D cache needs to be flushed, > > aren't they coherent? > > They are not. Ah, I figured they would

Re: [U-Boot] [PATCH] mpc83xx: remove some dead code, saving space

2010-11-30 Thread Joakim Tjernlund
> > Dear Joakim Tjernlund, > > In message <1290537223-12160-1-git-send-email-joakim.tjernl...@transmode.se> > you wrote: > > > > Signed-off-by: Joakim Tjernlund > > --- > > arch/powerpc/cpu/mpc83xx/start.S |7 --- > > 1 files changed, 0

Re: [U-Boot] [STATUS] v2010.12-rc2 released

2010-11-30 Thread Joakim Tjernlund
> > On Tue, 2010-11-30 at 08:00 -0700, Wolfgang Denk wrote: > > Hello everybody. > > > > I apologise for being a bit late with this announcement: > > > > * U-Boot v2010.12-rc2 was released on Sunday, November 28. > > > > * Release "v2010.12" is (still) scheduled in 13 days: > > on December 13, 20

Re: [U-Boot] [PATCH 0/6] RFC: True PIC on 83xx

2010-11-30 Thread Joakim Tjernlund
> > Wolfgang Denk wrote on 2010/11/23 21:52:11: > > > > Dear Joakim Tjernlund, > > > > In message > > <1290538131-12383-1-git-send-email-joakim.tjernl...@transmode.se> you wrote: > > > Here goes my attempt to revive true PIC on ppc, starting wi

Re: [U-Boot] [PATCH 0/6] RFC: True PIC on 83xx

2010-11-30 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/23 21:52:11: > > Dear Joakim Tjernlund, > > In message <1290538131-12383-1-git-send-email-joakim.tjernl...@transmode.se> > you wrote: > > Here goes my attempt to revive true PIC on ppc, starting with 83xx. > > This uses a a new

Re: [U-Boot] [PATCH RFC 3/3] arm920t: do not relocate NULL pointer

2010-11-30 Thread Joakim Tjernlund
"Andreas Bießmann" wrote on 2010/11/30 12:48:41: > > Dear Joakim Tjernlund, > Dear Albert ARIBAUD, > > Am 30.11.2010 10:41, schrieb Joakim Tjernlund: > > Albert ARIBAUD wrote on 2010/11/30 10:02:45: > >> > >> Le 30/11/2010 09:47, Joakim Tjer

Re: [U-Boot] [PATCH RFC 3/3] arm920t: do not relocate NULL pointer

2010-11-30 Thread Joakim Tjernlund
Albert ARIBAUD wrote on 2010/11/30 10:02:45: > > Le 30/11/2010 09:47, Joakim Tjernlund a écrit : > >> > >> Le 30/11/2010 08:06, Andreas Bießmann a écrit : > >>> Signed-off-by: Andreas Bießmann > >> > >>> + cmp r1, #0 /* symbol

Re: [U-Boot] [PATCH RFC 3/3] arm920t: do not relocate NULL pointer

2010-11-30 Thread Joakim Tjernlund
> > Le 30/11/2010 08:06, Andreas Bießmann a écrit : > > Signed-off-by: Andreas Bießmann > > > + cmp r1, #0 /* symbol == NULL ? */ > > + beq fixnext > > Nak. Don't hide a null pointer. NULL pointers are *not* relocated, since > they are a constant. If a NULL ends up in relocation tab

Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again

2010-11-28 Thread Joakim Tjernlund
Kim Phillips wrote on 2010/11/28 17:31:25: > > On Tue, 23 Nov 2010 12:38:57 -0600 > Scott Wood wrote: > > > On Tue, 23 Nov 2010 19:16:01 +0100 > > Joakim Tjernlund wrote: > > > > > Could we have an ACK before relese please? > > > > > >

Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again

2010-11-28 Thread Joakim Tjernlund
Kim Phillips wrote on 2010/11/28 17:31:25: > > On Tue, 23 Nov 2010 12:38:57 -0600 > Scott Wood wrote: > > > On Tue, 23 Nov 2010 19:16:01 +0100 > > Joakim Tjernlund wrote: > > > > > Could we have an ACK before relese please? > > > > > >

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-28 Thread Joakim Tjernlund
Kim Phillips wrote on 2010/11/28 16:12:21: > > On Wed, 24 Nov 2010 22:59:55 +0100 > Wolfgang Denk wrote: > > > Dear Joakim Tjernlund, > > > > In message > > > > you wrote: > > > > > >Are you planning to apply some of my ear

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-24 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/24 22:45:11: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > Played a little with this but it seems like two BATs cannot overlap? > > IIRC they can, but the first (lower register numbers) mapping wins. This

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-24 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/24 22:41:19: > > > > > > How about playing with BATs before entering C code, so that the > > > > > > image > > > > > > always appears at the same effective address? > > > > > > > > > > hmm, never thought of that. The extra bonus would be that LINK_OFF > > > > > should

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-24 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/24 18:16:56: > > On Wed, 24 Nov 2010 12:04:15 +0100 > Joakim Tjernlund wrote: > > > > > > > Scott Wood wrote on 2010/11/23 23:32:04: > > > > > > > > On Tue, 23 Nov 2010 23:14:06 +0100 > > > > Joakim T

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-24 Thread Joakim Tjernlund
> > Scott Wood wrote on 2010/11/23 23:32:04: > > > > On Tue, 23 Nov 2010 23:14:06 +0100 > > Joakim Tjernlund wrote: > > > > > Scott Wood wrote on 2010/11/23 22:20:58: > > > > "load address" being pre-relocation? Currently these must

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-23 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/23 23:32:04: > > On Tue, 23 Nov 2010 23:14:06 +0100 > Joakim Tjernlund wrote: > > > Scott Wood wrote on 2010/11/23 22:20:58: > > > "load address" being pre-relocation? Currently these must be equal > > > (which doesn

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-23 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/23 22:20:58: > > On Tue, 23 Nov 2010 22:03:36 +0100 > Joakim Tjernlund wrote: > > > Scott Wood wrote on 2010/11/23 21:46:51: > > > "Only these" that you've found so far, for the board you've tried -- > > > >

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-23 Thread Joakim Tjernlund
> > Scott Wood wrote on 2010/11/23 21:46:51: > > On Tue, 23 Nov 2010 19:48:51 +0100 > > Joakim Tjernlund wrote: > > Please document the specific circumstances in which one would need > > to use this (any data-segment pointer before relocation?). > > Any pt

Re: [U-Boot] [PATCH 0/6] RFC: True PIC on 83xx

2010-11-23 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/23 21:52:11: > > Dear Joakim Tjernlund, > > In message <1290538131-12383-1-git-send-email-joakim.tjernl...@transmode.se> > you wrote: > > Here goes my attempt to revive true PIC on ppc, starting with 83xx. > > This uses a a new

Re: [U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-23 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/23 21:46:51: > On Tue, 23 Nov 2010 19:48:51 +0100 > Joakim Tjernlund wrote: > > > Only these 2 call sites depends on fixups for my mpc8321 based > > board. > > --- > > arch/powerpc/cpu/mpc83xx/cpu_init.c |2 +- > > arc

Re: [U-Boot] [PATCH 3/6] mpc83xx: Add link vs. load address calculation

2010-11-23 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/23 21:17:12: > > On Tue, 23 Nov 2010 21:08:37 +0100 > Joakim Tjernlund wrote: > > > Scott Wood wrote on 2010/11/23 20:32:32: > > > On Tue, 23 Nov 2010 19:48:48 +0100 > > > Joakim Tjernlund wrote: > > > > > &

Re: [U-Boot] [PATCH 3/6] mpc83xx: Add link vs. load address calculation

2010-11-23 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/23 20:32:32: > On Tue, 23 Nov 2010 19:48:48 +0100 > Joakim Tjernlund wrote: > > > diff --git a/include/common.h b/include/common.h > > index 8bca04f..f257ea4 100644 > > --- a/include/common.h > > +++ b/include/common.h > > @@ -

[U-Boot] [PATCH 6/6] powerpc: Add LINK_OFF calls in early C-code.

2010-11-23 Thread Joakim Tjernlund
Only these 2 call sites depends on fixups for my mpc8321 based board. --- arch/powerpc/cpu/mpc83xx/cpu_init.c |2 +- arch/powerpc/lib/board.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/cpu_init.c b/arch/powerpc/cpu/mpc83xx/cpu

[U-Boot] [PATCH 5/6] mpc83xx: Add true PIC support.

2010-11-23 Thread Joakim Tjernlund
By copying the GOT to the end of the INIT_RAM(dcache) and relocating it there, it is much esier to support true PIC on u-boot. This cannot handle FIXUP so C code that depends on fixups before relocation to RAM must use LINK_OFF to calculate the difference. This depends on the upcoming single-pic-b

[U-Boot] [PATCH 4/6] mpc83xx: Add support form -msingle-pic-base

2010-11-23 Thread Joakim Tjernlund
singel-pic-base is pending inclusinon in gcc and is useful for reducing code size and impl. true PIC. --- arch/powerpc/cpu/mpc83xx/start.S | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S index

[U-Boot] [PATCH 3/6] mpc83xx: Add link vs. load address calculation

2010-11-23 Thread Joakim Tjernlund
link_off calculates the difference between link address and actila load address. This is a must for true PIC u-boot. --- arch/powerpc/cpu/mpc83xx/start.S | 25 + include/common.h |5 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a

[U-Boot] [PATCH 2/6] mpc83xx: Make start.S true PIC

2010-11-23 Thread Joakim Tjernlund
Remove dependencies on link address. Use GOT and add an new function to calculate the actual address. --- arch/powerpc/cpu/mpc83xx/start.S | 36 1 files changed, 28 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cp

[U-Boot] [PATCH 1/6] mpc83xx: Add relocation support for -fpic

2010-11-23 Thread Joakim Tjernlund
By rearranging the linker script we get support for relocation of -fpic for free. --- arch/powerpc/cpu/mpc83xx/u-boot.lds |5 +++-- nand_spl/board/freescale/mpc8313erdb/u-boot.lds |4 +++- nand_spl/board/freescale/mpc8315erdb/u-boot.lds |4 +++- 3 files changed, 9 insertion

[U-Boot] [PATCH 0/6] RFC: True PIC on 83xx

2010-11-23 Thread Joakim Tjernlund
already sent. Anyhow, if this is an acceptable approach I will clean it up once the ongoing release is out. Joakim Tjernlund (6): mpc83xx: Add relocation support for -fpic mpc83xx: Make start.S true PIC mpc83xx: Add link vs. load address calculation mpc83xx: Add support form -msingle-pic-base

[U-Boot] [PATCH] mpc83xx: remove some dead code, saving space

2010-11-23 Thread Joakim Tjernlund
Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/mpc83xx/start.S |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S index f7da14b..121c276 100644 --- a/arch/powerpc/cpu/mpc83xx/start.S +++ b/arch

Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again

2010-11-23 Thread Joakim Tjernlund
fore continuing with the code that depends on it. > Final fix suggested by Scott Wood. > > Signed-off-by: Joakim Tjernlund > --- > > v2: Final adjustmenst based on inpt from Scott Wood. > arch/powerpc/cpu/mpc83xx/start.S |8 > 1 files changed, 8 insertions(+),

Re: [U-Boot] [PATCH 2/2] mpc83xx: Add relocation support for -fpic

2010-11-22 Thread Joakim Tjernlund
> > By rearranging the linker script we get support for > relocation of -fpic for free. > > Signed-off-by: Joakim Tjernlund > --- > arch/powerpc/cpu/mpc83xx/u-boot.lds |5 +++-- > nand_spl/board/freescale/mpc8313erdb/u-boot.lds |4 +++- > nand_spl/

Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again

2010-11-22 Thread Joakim Tjernlund
> > Joakim Tjernlund wrote on 2010/11/19 14:15:33: > > > > After the removal of COLD/WARM start flags my mpc8321 > > board didn't boot anymore. > > Trial and error suggests that map/remap_flash_by_xxx needs > > to wait after updating LBLAWAR1 to make s

[U-Boot] [PATCH 2/2] mpc83xx: Add relocation support for -fpic

2010-11-22 Thread Joakim Tjernlund
By rearranging the linker script we get support for relocation of -fpic for free. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/mpc83xx/u-boot.lds |5 +++-- nand_spl/board/freescale/mpc8313erdb/u-boot.lds |4 +++- nand_spl/board/freescale/mpc8315erdb/u-boot.lds |4

[U-Boot] [PATCH 1/2] powerpc: fix mpc8315erdb and mpc8313erdb NAND linker script

2010-11-22 Thread Joakim Tjernlund
You cannot use _GOT2_TABLE_ within its defintion. Move __got2_entries outside _GOT2_TABLE_ defining scope. Signed-off-by: Joakim Tjernlund --- nand_spl/board/freescale/mpc8313erdb/u-boot.lds |2 +- nand_spl/board/freescale/mpc8315erdb/u-boot.lds |2 +- 2 files changed, 2 insertions

Re: [U-Boot] [PATCHv2] mpc83xx: Make it boot again

2010-11-19 Thread Joakim Tjernlund
Joakim Tjernlund wrote on 2010/11/19 14:15:33: > > After the removal of COLD/WARM start flags my mpc8321 > board didn't boot anymore. > Trial and error suggests that map/remap_flash_by_xxx needs > to wait after updating LBLAWAR1 to make sure the the change has > reached t

[U-Boot] [PATCHv2] mpc83xx: Make it boot again

2010-11-19 Thread Joakim Tjernlund
ed by Scott Wood. Signed-off-by: Joakim Tjernlund --- v2: Final adjustmenst based on inpt from Scott Wood. arch/powerpc/cpu/mpc83xx/start.S |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S index e8

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-17 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/17 20:27:01: > > On Wed, 17 Nov 2010 20:15:01 +0100 > Joakim Tjernlund wrote: > > > Scott Wood wrote on 2010/11/17 20:03:25: > > > The "load, conditional branch, isync" sequence is documented in the > > > architectu

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-17 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/17 20:03:25: > > On Wed, 17 Nov 2010 18:26:02 +0100 > Joakim Tjernlund wrote: > > > Scott Wood wrote on 2010/11/17 18:05:37: > > > > > > On Wed, 17 Nov 2010 17:57:53 +0100 > > > Joakim Tjernlund wrote: > > >

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-17 Thread Joakim Tjernlund
Scott Wood wrote on 2010/11/17 18:05:37: > > On Wed, 17 Nov 2010 17:57:53 +0100 > Joakim Tjernlund wrote: > > > > From: Liu Dave-R63238 > > > To: Andre Schwarz > > > Cc: Wood Scott-B07421 , ku...@theia.denx.de, Tabi > > > Timur-B04825 ,

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-17 Thread Joakim Tjernlund
> From: Liu Dave-R63238 > To: Andre Schwarz > Cc: Wood Scott-B07421 , ku...@theia.denx.de, Tabi > Timur-B04825 , Phillips Kim-R1AAHA > , Gala , U-Boot List > > Date: 2010/11/15 17:58 > Subject: Re: [U-Boot] [PATCH] mpc83xx: Make it boot again > Sent by: u-boot-boun...@lists.denx.de > > > The

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-15 Thread Joakim Tjernlund
> > > The experts found an issue within init code and it looks like a proper > > patch will be added to mainline shortly. > > The discussion of the proper fix is right in this thread ... > > It should be timing issue in the SoC, software did not have a proper > process to handle > IMMR registers ac

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-15 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/15 10:57:30: > > On 11/12/2010 08:31 PM, Scott Wood wrote: > > On Fri, 12 Nov 2010 13:26:17 -0600 > > Kumar Gala wrote: > > > > > >> On Nov 12, 2010, at 11:22 AM, Scott Wood wrote: > >> > >> > >>> On Fri, 12 Nov 2010 09:58:53 -0600 > >>> Kumar Gala wrote: > >>> > >

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-12 Thread Joakim Tjernlund
Kumar Gala wrote on 2010/11/12 16:58:48: > > > On Nov 4, 2010, at 9:45 AM, Joakim Tjernlund wrote: > > > After the removal of COLD/WARM start flags my mpc8321 > > board didn't boot anymore. > > Trial and error suggests that map_flash_by_law1 needs > > a

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-12 Thread Joakim Tjernlund
> > > > > Timur Tabi wrote: > > > Wood Scott-B07421 wrote: > > > > To be totally safe, we probably want to do a readback plus twi (to turn > > > > a data dependency into a flow dependency) before the isync. > > > > > > twi == trap word immediate? > > > > Yes. > > > > > If so, I don't see how that w

Re: [U-Boot] [PATCH] PowerPC: Don't destroy fixup table while doing fixups

2010-11-10 Thread Joakim Tjernlund
Ping? > > The fixup procedure just stored a constant value in the > fixup table rather than just adjusting the table. > Although that doesn't seem to do any harm, it prevents > relocation more that once. > > Signed-off-by: Joakim Tjernlund > --- > arch/pow

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-10 Thread Joakim Tjernlund
> > Timur Tabi wrote: > > Wood Scott-B07421 wrote: > > > To be totally safe, we probably want to do a readback plus twi (to turn > > > a data dependency into a flow dependency) before the isync. > > > > twi == trap word immediate? > > Yes. > > > If so, I don't see how that will turn a data dependen

Re: [U-Boot] MPC8377: USB breaks board

2010-11-05 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/05 17:13:34: > On 11/05/2010 04:07 PM, Joakim Tjernlund wrote: > > Andre Schwarz wrote on 2010/11/05 15:51:13: > > > >> Jocke, > >> > >> sorry to bother you again, but it might relate to our last discussion. > >

Re: [U-Boot] MPC8377: USB breaks board

2010-11-05 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/05 15:51:13: > > Jocke, > > sorry to bother you again, but it might relate to our last discussion. > > Actually my MPC8377 based board is up and running with basic functionality. > Now I'm trying to add USB support - but as soon as CONFIG_USB_EHCI_FSL is > defined se

Re: [U-Boot] MPC8377: USB breaks board

2010-11-05 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/05 15:51:13: > > Jocke, > > sorry to bother you again, but it might relate to our last discussion. > > Actually my MPC8377 based board is up and running with basic functionality. > Now I'm trying to add USB support - but as soon as CONFIG_USB_EHCI_FSL is > defined se

Re: [U-Boot] Weak symbols: request for comments

2010-11-05 Thread Joakim Tjernlund
> > Dear Sebastien Carlier, > > Am 05.11.2010 11:39, schrieb Sebastien Carlier: > > Hello all, > > > So, U-boot needs to be fixed. I can see the following ways forward: > > > > 1.1) Stop using weak symbols; use pre-initialized function pointers > > instead (possibly grouped in a struct, for

[U-Boot] [PATCH] PowerPC: Don't destroy fixup table while doing fixups

2010-11-04 Thread Joakim Tjernlund
The fixup procedure just stored a constant value in the fixup table rather than just adjusting the table. Although that doesn't seem to do any harm, it prevents relocation more that once. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/74xx_7xx/start.S |2 +- arch/powerpc/cpu/mp

Re: [U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-04 Thread Joakim Tjernlund
Wood Scott-B07421 wrote on 2010/11/04 17:47:41: > > Joakim Tjernlund wrote: > > Trial and error suggests that map_flash_by_law1 needs > > an isync(padding with 4 nop's also did the trick) > > after updating LBLAWAR1 to make sure the the change has > > reache

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/04 15:49:06: > > Jocke, > > >> CPU: e300c4, MPC8379, Rev: 2.1 at 600 MHz, CSB: 400 MHz > >> > >> - Boot from NOR Flash > >> - HRCW from I2C EEPROM > >> - Reset Vector 0x100, i.e. low boot. > >> > > OK, almost the same as me, but I got a: > > CPU: e300c2, MPC8321,

[U-Boot] [PATCH] mpc83xx: Make it boot again

2010-11-04 Thread Joakim Tjernlund
code that depends on it. Add an isync to remap_flash_by_law0 for good measure too. Signed-off-by: Joakim Tjernlund --- arch/powerpc/cpu/mpc83xx/start.S |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S ind

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/04 14:32:15: > > Jocke, > > [snip] > > > still -E_TOO_LITTLE_INFO: > > > > sorry - thought it was clear already. > > > "include weather booted from NAND or NOR, CPU type(e300cX) and > > what reset vector is used." > > > CPU: e300c4, MPC8379, Rev: 2.1 at 600 MHz,

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/04 14:07:50: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > Could do what? Modify the memory map such that the Flash is mapped > > > > Issue an soft reset somehow. Don't know how but I gu

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/04 13:28:27: > > > >> Andy, > >> > Sure, but until freescale or someone else with eq. and motivation > researches it, we are stuck. I am not sure anyone else has tried > 83xx based boards yet. If someone has please report. Also > include weather b

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/04 13:46:17: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > What exactly is a "soft reset" in U-Boot? And how would you perform > > > one? > > > > Not in u-boot, but Linux

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/04 12:16:31: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > hmm, what if a board decides to do a soft reset anyway, perhaps by mistake. > > Would it not be a good thing if u-boot could handle that too? >

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/11/04 13:14:37: > > Andy, > >> Sure, but until freescale or someone else with eq. and motivation > >> researches it, we are stuck. I am not sure anyone else has tried > >> 83xx based boards yet. If someone has please report. Also > >> include weather booted from NAND or

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
"Andy Pont" wrote on 2010/11/04 11:58:19: > > Joakim wrote... > > > Sure, but until freescale or someone else with eq. and motivation > > researches it, we are stuck. I am not sure anyone else has tried > > 83xx based boards yet. If someone has please report. Also > > include weather booted from N

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
> > Wolfgang Denk wrote on 2010/11/04 10:57:42: > > > > Dear Joakim Tjernlund, > > > > In message > > > > you wrote: > > > > > > > 4 nops after _start does the trick, i.e. the board is up and running > > > > fin

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/04 10:57:42: > > Dear Joakim Tjernlund, > > In message > you > wrote: > > > > > 4 nops after _start does the trick, i.e. the board is up and running fine. > ... > > How is this going? If nothing else I think you shou

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/11/04 10:50:38: > > Dear Andre Schwarz, > > In message <4cc58b1b.8040...@matrix-vision.de> you wrote: > > > > Diffing both System.maps and U-Boot hexdump gives only trivial results : > > > > - "in_flash" and "_start_of_vectors" adress increment = 0x10. > > Hey, stop her

Re: [U-Boot] [PATCH] powerpc: do not fixup NULL ptrs

2010-11-04 Thread Joakim Tjernlund
Andre Schwarz wrote on 2010/10/25 15:50:19: > > Jocke, > > [snip] > > > You still haven't reported weather the 4 nop's helped or not, yet you > > seek my help. I am just going to ignore you until you do test it. > > > > > > finally I got both some time and hardware : > > 4 nops after _start does t

<    1   2   3   4   5   6   7   8   >