Hi all,
I am facing a problem with some boards that do not boot after some
weeks or months of normal usage, being unable to attach UBI. They do
not boot anymore event after a power cycle, in other words they are
totally bricked.
I don't know exactly what problem UBI has, but it is recoverable by
Hi Andreas,
Andreas Bießmann wrote:
...
Creating 1 MTD partitions on nand0:
0x0010-0x1000 : mtd=3
UBI: attaching mtd1 to ubi0
UBI: physical eraseblock size: 131072 bytes (128 KiB)
UBI: logical eraseblock size:129024 bytes
UBI: smallest flash I/O unit:2048
UBI: sub-page
Hi Andreas,
Andreas Bießmann wrote:
Hi Luca,
On 19.12.2012 16:56, Luca Ceresoli wrote:
Hi Andreas,
Andreas Bießmann wrote:
...
Creating 1 MTD partitions on nand0:
0x0010-0x1000 : mtd=3
UBI: attaching mtd1 to ubi0
UBI: physical eraseblock size: 131072 bytes (128 KiB)
UBI
://thread.gmane.org/gmane.comp.boot-loaders.u-boot/149624
Luca Ceresoli wrote:
Hi Andreas,
Andreas Bießmann wrote:
Hi Luca,
On 19.12.2012 16:56, Luca Ceresoli wrote:
Hi Andreas,
Andreas Bießmann wrote:
...
Creating 1 MTD partitions on nand0:
0x0010-0x1000 : mtd=3
UBI: attaching
Luca Ceresoli wrote:
Hi,
I'm Cc'ing the linux-mtd list as well as the authors of the Linux
commits cited below.
For these new readers: I reported a problem with U-Boot 2012.04.01 not
being able to attach an UBI partition in NAND, while Linux (2.6.37) can
attach and repair it.
It looks like
Thomas Weber wrote:
This patch removes the CONFIG_OMAP3430, because it is unused.
Acked-by: Enric Balletbo i Serraeballe...@iseebcn.com
Acked-by: Tom Rinitr...@ti.com
Acked-by: Igor Grinberggrinb...@compulab.co.il
Signed-off-by: Thomas Weberwe...@corscience.de
Acked-by: Luca Ceresoli
Thomas Weber wrote:
This patch removes the unused definition of SDRC_R_C_B
from the config files.
Acked-by: Enric Balletbo i Serraeballe...@iseebcn.com
Acked-by: Igor Grinberggrinb...@compulab.co.il
Signed-off-by: Thomas Weberwe...@corscience.de
Acked-by: Luca Ceresoli luca.ceres
...@corscience.de
This does not touch the board I maintain, but since I was in Cc:, and
I successfully tested the whole series on my board:
Acked-by: Luca Ceresoli luca.ceres...@comelit.it
Luca
___
U-Boot mailing list
U-Boot@lists.denx.de
http
Thomas Weber wrote:
This patch removes the unused definitions:
CONFIG_OMAP3_MICRON_DDR
CONFIG_OMAP3_NUMONYX_DDR
CONFIG_OMAP3_INFINEON_DDR
Signed-off-by: Thomas Weberwe...@corscience.de
Acked-by: Luca Ceresoli luca.ceres...@comelit.it
Luca
___
U
Mike Frysinger wrote:
On Monday, April 18, 2011 12:19:51 Luca Ceresoli wrote:
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.
the summary made me worried because i thought you were going to rename the env
var server
Luca Ceresoli wrote:
Il 19/04/2011 16:18, Detlev Zundel ha scritto:
Hi Luca,
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.
Signed-off-by: Luca Ceresoliluca.ceres...@comelit.it
Cc: Wolfgang Denkw...@denx.de
Wolfgang Denk wrote:
Dear Luca Ceresoli,
In message4dbff3af.4040...@comelit.it you wrote:
So assuming we never see any incoming packets - how long will we wait?
Once it has started, the server is stopped like the client is:
- on a complete file reception
- pressing Ctrl-C
- after waiting
Detlev Zundel wrote:
Hi Luca,
Signed-off-by: Luca Ceresoliluca.ceres...@comelit.it
Cc: Wolfgang Denkw...@denx.de
---
Changes in v2: none.
Only one comment below
net/tftp.c | 72
---
net/tftp.h |6 +
2 files
TFTP server.
The fourth patch adds a user command to launch the server.
I also added a trailing patch (#5 in this series), a trivial typo fix
requested by Detlev.
Luca
Luca Ceresoli (5):
TFTP: replace server with remote in local variable names
TFTP: rename STATE_RRQ to STATE_SEND_RRQ
TFTP
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2:
- fixed checkpatch issues.
Changes in v3:
- rebased on top of the net
With the upcoming TFTP server implementation, requests can be either
outgoing or incoming, so avoid ambiguities.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2: none.
Changes in v3:
- rebased on top of the net/tftp.c cleanup.
net/tftp.c
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2: none.
Changes in v3:
- rebased on top of the net/tftp.c cleanup;
- made do_tftpsrv() static;
- improved tftpsrv command help;
- removed all #ifdefs that used to remove negligible amounts
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2: none.
Changes in v3:
- rebased on top of the net/tftp.c cleanup;
- removed all #ifdefs that used to remove negligible amounts of compiled code,
at the cost of a much less readable source
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v3: this patch is new in v3.
net/tftp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/tftp.c b/net/tftp.c
index 6d44298..a893e02 100644
--- a/net/tftp.c
+++ b/net
to assume that it is negligible for all
boards?
OTOH it would give no visible advantage to those boards that will never want
tftpsrv at all, which are probably the vast majority.
I look forward to receive comments on this last question.
Luca
Luca Ceresoli
Luca Ceresoli luca.ceres
--
Luca Ceresoli
Comelit RD - Progettazione Software
Phone
Fax
Mail
Web
YouTube
luca.ceres...@comelit.it
http://www.comelitgroup.com/
http://www.youtube.com/comelitgroup
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
---
This patch is my implementation of the same functionality that Helmut's patch
implements. I'm sending it as a reference for him to look at the error
checking code and possibly merge it into his own patch.
drivers/net/smc911x.c | 41
Wolfgang, Albert, all,
following last week's discussion [1], here's the patch that would implement
Comelit CPS board support in U-boot.
The point is that this code is not booting.
It is a rebase on top of current master of a previous, working, version
based on v2010.06.
During the rebase
Board support for the Comelit Group SpA CPS board, which is a custom board
based on the BeagleBoard http://beagleboard.org/ by Texas Instruments.
The board support is based on the BeagleBoard implementation.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc
Wolfgang,
thanks for your patient and prompt review, and sorry for having
overlooked checkpatch.
Il 21/03/2011 12:55, Wolfgang Denk ha scritto:
Dear Luca Ceresoli,
In message1300707767-15682-2-git-send-email-luca.ceres...@comelit.it you
wrote:
Board support for the Comelit Group SpA CPS
Il 21/03/2011 17:32, Luca Ceresoli ha scritto:
...
--- a/boards.cfg
+++ b/boards.cfg
@@ -117,6 +117,7 @@ omap3_pandoraarm armv7
pandora -
igep0020 arm armv7 igep0020
isee omap3
igep0030
Hi all,
here's a patch series that incorporates all the changes required during the
review of v1.
Patches 1 to 3 are cleanups to issues that were discovered up during discussion.
Please note that the new board code is not working (see
http://lists.denx.de/pipermail/u-boot/2011-March/088704.html
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
include/configs/cm_t35.h|1 -
include/configs/devkit8000.h|1
CONFIG_OMAP34XX must be checked for existence, not value.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
arch/arm/cpu/armv7/start.S
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
arch/arm/cpu/armv7/omap3/mem.c |2 +-
include/configs/am3517_evm.h |2
Board support for the DIG297 board manufactured by Comelit Group SpA.
It is a custom board baseed on the BeagleBoard http://beagleboard.org/ by
Texas Instruments.
The board support is based on the BeagleBoard implementation.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk
in the commit messages. The content is the same.
Luca Ceresoli (4):
ARMV7: OMAP3: Fix preprocessor check for CONFIG_OMAP34XX
ARMV7: OMAP3: Remove unused variable boot_flash_env_addr
ARMV7: OMAP3: boot_flash_env_addr should not be volatile
ARMV7: OMAP3: Add support for Comelit DIG297 board
Luca
CONFIG_OMAP34XX must be checked for existence, not value.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
Changes in v3: none.
arch
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
Changes in v3: none.
include/configs/cm_t35.h|1 -
include/configs
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
Changes in v3: none.
arch/arm/cpu/armv7/omap3/mem.c |2 +-
include/configs
Board support for the DIG297 board manufactured by Comelit Group SpA.
It is a custom board based on the BeagleBoard http://beagleboard.org/ by
Texas Instruments.
The board support is based on the BeagleBoard implementation.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk
Dear custodians,
Luca Ceresoli wrote:
Hi all,
here's a resubmit of the DIG297 board support with minor OMAP3 fixes.
Sorry for the newbie question, but I didn't find the answer in the docs.
Now that the Merge Window is open, do I have to rebase these patches on top
of v2011.03 and resubmit
Il 06/04/2011 09:50, Wolfgang Denk ha scritto:
Dear Luca Ceresoli,
In message1301416116-5519-5-git-send-email-luca.ceres...@comelit.it you
wrote:
Board support for the DIG297 board manufactured by Comelit Group SpA.
It is a custom board based on the BeagleBoardhttp://beagleboard.org
Il 07/04/2011 23:49, Wolfgang Denk ha scritto:
Dear Luca Ceresoli,
In message4d9e12b7.2040...@comelit.it you wrote:
I'm going to define the bit values for the GPMC_CONFIGn registers.
Is arch/arm/include/asm/arch-omap3/omap_gpmc.h the correct place?
I think so, but I'm not an OMAP expert
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
---
Cross-compiling fw_{print,set}env has caused people to waste a lot of time:
- http://www.mail-archive.com/u-boot@lists.denx.de/msg42317.html
- http://www.mail-archive.com/u-boot@lists.denx.de/msg39735.html
- http://www.mail-archive.com/u
Wolfgang, Albert, Sandeep,
Luca Ceresoli wrote:
+#ifndef __ASSEMBLY__
+extern unsigned int boot_flash_base;
+extern unsigned int boot_flash_off;
+extern unsigned int boot_flash_sec;
+extern unsigned int boot_flash_type;
+#endif
Can we please get rid of this?
Hopefully. This mostly
Wolfgang Denk wrote:
Dear Luca Ceresoli,
In message4da0c56d.7030...@comelit.it you wrote:
...
Observations:
a. arch/arm/cpu/armv7/omap3/mem.c computes a value for those variables based
on config-values in the config file (see gpmc_init(), bottom half):
Note that arch/arm/cpu/armv7
Hi,
I am going to implement in U-Boot the ability to receive a file via TFTP acting
as a server, not a client. I've sketched up a way to implement it, and I would
appreciate any comments about it.
This is useful to solve the firewall issues that a Management Station can face
when sending files
Wolfgang,
thanks for the feedback.
Wolfgang Denk wrote:
...
From the user point of view, I would implement a new command, activated
only
when CONFIG_CMD_TFTPSRV is defined:
Usage:tftpsrv [loadaddr]
This would be used almost like tftpboot, except no file name is specified on
Luca Ceresoli wrote:
- net/tftp.c: extend the TFTP state machine (TftpHandler() and TftpStart())
a new STATE_WAITING state (it should be enough);
- the state machine would be different in the session setup: in
STATE_WAITING handle WRQ packets and select a new UDP port
in patch number 5.
Luca
Luca Ceresoli (6):
README: remove spurious line
NET: pass source IP address to packet handlers
TFTP: rename server to remote
TFTP: rename STATE_RRQ to STATE_SEND_RRQ
TFTP: net/tftp.c: add server mode receive
TFTP: add tftpsrv command
README
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
README |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/README b/README
index 4917e26..b9b0fcb 100644
--- a/README
+++ b/README
@@ -1299,7 +1299,6 @@ The following options need
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
A note on the style of this patch.
There are many hunks like this:
- if (TftpState != STATE_SEND_RRQ src != TftpRemotePort)
+ if (TftpState != STATE_SEND_RRQ
+#ifdef CONFIG_CMD_TFTPSRV
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
README |1 +
common/cmd_net.c | 14 ++
include/net.h|3 ++-
net/net.c| 10 --
4 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/README b
.
Luca
Luca Ceresoli (4):
ARMV7: OMAP3: Fix preprocessor check for CONFIG_OMAP34XX
ARMV7: OMAP3: Cleanup extern variables in mem.c
ARMV7: OMAP3: Add GPMC_CONFIGx register value definitions
ARMV7: OMAP3: Add support for Comelit DIG297 board
MAINTAINERS
CONFIG_OMAP34XX must be checked for existence, not value.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
Changes in v3: none
Removed boot_flash_* extern variables.
boot_flash_type was totally unused. The other ones were actually constants, so
they have been replaced with #defines in the board config files.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
---
Changes in v4:
- this patch is new in v4.
arch/arm/include/asm/arch-omap3/omap3-regs.h | 95 ++
1 files changed, 95 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/include/asm/arch-omap3/omap3-regs.h
CONFIG_OMAP34XX must be checked for existence, not value.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud albert.arib...@free.fr
Cc: Sandeep Paulraj s-paul...@ti.com
---
Changes in v2:
- this patch is new in v2.
Changes in v3: none
.
Luca
Luca Ceresoli (4):
ARMV7: OMAP3: Fix preprocessor check for CONFIG_OMAP34XX
ARMV7: OMAP3: Cleanup extern variables in mem.c
ARMV7: OMAP3: Add GPMC_CONFIGx register value definitions
ARMV7: OMAP3: Add support for Comelit DIG297 board
MAINTAINERS
Board support for the DIG297 board manufactured by Comelit Group SpA.
It is a custom board based on the BeagleBoard http://beagleboard.org/ by
Texas Instruments.
The board support is based on the BeagleBoard implementation.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk
Board support for the DIG297 board manufactured by Comelit Group SpA.
It is a custom board based on the BeagleBoard http://beagleboard.org/ by
Texas Instruments.
The board support is based on the BeagleBoard implementation.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
---
Changes in v4:
- this patch is new in v4.
arch/arm/include/asm/arch-omap3/omap3-regs.h | 95 ++
1 files changed, 95 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/include/asm/arch-omap3/omap3-regs.h
Removed boot_flash_* extern variables.
boot_flash_type was totally unused. The other ones were actually constants, so
they have been replaced with #defines in the board config files.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud
, RARP, ARP, TFTP, DHCP, PING, DNS, NFS, CDP, NETCONS,
SNTP,
Is a typedef *enum* considered bad in U-Boot?
Luca
Luca Ceresoli (6):
README: remove spurious line
NET: pass source IP address to packet handlers
TFTP: rename server to remote
TFTP: rename STATE_RRQ to STATE_SEND_RRQ
TFTP: net
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2: none.
README |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/README b/README
index 4917e26..b9b0fcb 100644
--- a/README
+++ b/README
@@ -1299,7 +1299,6
This is needed for the upcoming TFTP server implementation.
This also simplifies PingHandler() and fixes rxhand_f documentation.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2:
- fixed checkpatch issues.
drivers/net/netconsole.c |5
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2:
- fixed checkpatch issues.
net/tftp.c | 42
With the upcoming TFTP server implementation, requests can be either
outgoing or incoming, so avoid ambiguities.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2: none.
net/tftp.c | 12 ++--
1 files changed, 6 insertions(+), 6
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2: none.
README |1 +
common/cmd_net.c | 14 ++
include/net.h|3 ++-
net/net.c| 10 --
4 files changed, 25 insertions(+), 3 deletions
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
Changes in v2: none.
net/tftp.c | 72 ---
net/tftp.h |6 +
2 files changed, 74 insertions(+), 4 deletions(-)
diff --git a/net/tftp.c b/net
Paulraj, Sandeep wrote:
Board support for the DIG297 board manufactured by Comelit Group SpA.
It is a custom board based on the BeagleBoardhttp://beagleboard.org/ by
Texas Instruments.
...
I'll apply this after you resend the patch
ARMV7: OMAP3: Cleanup extern variables in mem.c
Il 19/04/2011 16:15, Detlev Zundel ha scritto:
Hi Luca,
This is needed for the upcoming TFTP server implementation.
This also simplifies PingHandler() and fixes rxhand_f documentation.
Signed-off-by: Luca Ceresoliluca.ceres...@comelit.it
Cc: Wolfgang Denkw...@denx.de
---
Changes in v2:
Il 19/04/2011 16:18, Detlev Zundel ha scritto:
Hi Luca,
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.
Signed-off-by: Luca Ceresoliluca.ceres...@comelit.it
Cc: Wolfgang Denkw...@denx.de
---
Changes in v2:
- fixed
Hi,
just a few e-mails ago along this thread Albert Aribaud wrote:
My opinion is that you should make sure that at least the code you touch
is checkpatch-clean, so yes, you should fix that; but there is no need
to submit 'checkpatch-compliance' patches. Just fix the line here so
that
Detlev Zundel wrote:
Hi Luca,
Il 19/04/2011 16:18, Detlev Zundel ha scritto:
Hi Luca,
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.
Signed-off-by: Luca Ceresoliluca.ceres...@comelit.it
Cc: Wolfgang Denkw...@denx.de
Hi all,
this patch series cleans up some OMAP3 stuff and adds DIG297 board support.
New in v5:
- rebased against u-boot-ti master (007965dbe4dae12);
- updated to support the new am3517 crane board;
- removed two patches that have already been pushed to u-boot-ti master.
Luca
Luca Ceresoli
Removed boot_flash_* extern variables.
boot_flash_type was totally unused. The other ones were actually constants, so
they have been replaced with #defines in the board config files.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Albert Aribaud
Board support for the DIG297 board manufactured by Comelit Group SpA.
It is a custom board based on the BeagleBoard http://beagleboard.org/ by
Texas Instruments.
The board support is based on the BeagleBoard implementation.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk
Hi Wolfgang,
Wolfgang Denk wrote:
Dear Luca Ceresoli,
In message1302796377-3321-3-git-send-email-luca.ceres...@comelit.it you
wrote:
This is needed for the upcoming TFTP server implementation.
This also simplifies PingHandler() and fixes rxhand_f documentation.
Signed-off-by: Luca
Il 30/04/2011 21:53, Wolfgang Denk ha scritto:
Dear Luca Ceresoli,
In message4da59b5e.5000...@comelit.it you wrote:
Usage:tftpsrv [loadaddr]
This would be used almost like tftpboot, except no file name is specified
on
the commandline.
loadaddrwould default
Detlev Zundel wrote:
I'll start a new thread to discuss this. Hopefully we then come up with
a policy to stick into that wiki page.
Now that the checkpatch policy is much more clear, I started to clean up
the networking stuff, on top of which the TFTP server sits.
net/net.c alone counts 76
in the commit message for patch 1;
- WARNING: Use of volatile is usually wrong [...]
I've had a quick look at these, but I don't know in detail how the
networking code and Ethernet drivers (and maybe DMA?) interact, so I cannot
remove them being sure that things will continue working.
Luca
This removes the following checkpatch errors:
- ERROR: do not initialise globals to 0 or NULL
- ERROR: spaces required around that '=' (ctx:VxV)
- ERROR: that open brace { should be on the previous line
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc
:
+ [4 tabs] memcpy(((Ethernet_t *)NetArpWaitTxPacket)-et_dest, ...
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
---
net/net.c | 238 +
1 files changed
of a line
- WARNING: space prohibited between function name and open
parenthesis '('
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
---
net/net.c | 192 ++--
1
This removes the following checkpatch issues:
- WARNING: braces {} are not necessary for single statement blocks
- WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder
This removes the following checkpatch issues:
- ERROR: foo * bar should be foo *bar
- ERROR: (foo*) should be (foo *)
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
---
net/net.c | 36
This removes the following checkpatch issues:
- ERROR: switch and case should be at the same indent
- WARNING: suspect code indent for conditional statements
- WARNING: labels should not be indented
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben
This removes the following checkpatch issue:
- ERROR: do not use assignment in if condition
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
---
net/net.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions
This removes the following checkpatch issue:
- ERROR: return is not a function, parentheses are not required
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
---
net/net.c | 30 +++---
1 files
Mike Frysinger wrote:
On Wed, May 4, 2011 at 08:40, Luca Ceresoli wrote:
- ERROR: that open brace { should be on the previous line
...
-uchar NetCDPAddr[6] =
- { 0x01, 0x00, 0x0c, 0xcc, 0xcc, 0xcc };
+uchar NetCDPAddr[6
Hi Mike,
Mike Frysinger wrote:
On Wednesday, May 04, 2011 08:40:40 Luca Ceresoli wrote:
-debug(Got ICMP ECHO REQUEST, return %d bytes
\n,
-ETHER_HDR_SIZE + len);
+debug(Got ICMP ECHO REQUEST
drivers (and maybe DMA?) interact, so I cannot
remove them being sure that things will continue working.
Luca
Luca Ceresoli (8):
net/net.c: cosmetic: fix lines over 80 characters
net/net.c: cosmetic: variable initializations
net/net.c: cosmetic: fix whitespace issues
net/net.c: cosmetic
: net.c:1537:
+ [4 tabs] memcpy(((Ethernet_t *)NetArpWaitTxPacket)-et_dest, ...
The other two cannot be fixed without splitting string literals, so it is
preferred to keep them longer than 80 characters.
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben
This removes the following checkpatch errors:
- ERROR: do not initialise globals to 0 or NULL
- ERROR: spaces required around that '=' (ctx:VxV)
- ERROR: that open brace { should be on the previous line
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc
This removes the following checkpatch issues:
- WARNING: braces {} are not necessary for single statement blocks
- WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder
of a line
- WARNING: space prohibited between function name and open
parenthesis '('
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
Cc: Mike Frysinger vap...@gentoo.org
---
Changes since v1: none.
net/net.c | 192
This removes the following checkpatch issues:
- ERROR: foo * bar should be foo *bar
- ERROR: (foo*) should be (foo *)
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
Cc: Mike Frysinger vap...@gentoo.org
---
Changes
This removes the following checkpatch issues:
- ERROR: switch and case should be at the same indent
- WARNING: suspect code indent for conditional statements
- WARNING: labels should not be indented
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben
This removes the following checkpatch issue:
- ERROR: return is not a function, parentheses are not required
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
Cc: Mike Frysinger vap...@gentoo.org
---
Changes since v1
This removes the following checkpatch issue:
- ERROR: do not use assignment in if condition
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
Cc: Ben Warren biggerbadder...@gmail.com
Cc: Mike Frysinger vap...@gentoo.org
---
Changes since v1: none.
net/net.c
Hi Wolfgang,
Wolfgang Denk wrote:
Dear Luca Ceresoli,
In message1303143594-5345-4-git-send-email-luca.ceres...@comelit.it you
wrote:
With the upcoming TFTP server implementation, the remote node can be
either a client or a server, so avoid ambiguities.
Signed-off-by: Luca
cannot
remove them being sure that things will continue working;
- WARNING: plain inline is preferred over __inline__
as I see many __inline__s in the current source and don't know what the
U-Boot policy is.
Luca Ceresoli (8):
net/tftp.c: cosmetic: fix lines over 80 characters
net
This removes the following checkpatch issue:
- WARNING: suspect code indent for conditional statements
Signed-off-by: Luca Ceresoli luca.ceres...@comelit.it
Cc: Wolfgang Denk w...@denx.de
---
net/tftp.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/net
1 - 100 of 212 matches
Mail list logo
