[PATCH] configs: meson64_android: don't show logo on ROM USB boot

2020-10-30 Thread Mattijs Korpershoek
From: Guillaume La Roque When booting from rom usb, skip the boot logo logic as it's possible that the partition containing the logo does not exist yet. Signed-off-by: Neil Armstrong Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h

[PATCH 3/9] configs: meson64_android: implement AVB support

2021-08-05 Thread Mattijs Korpershoek
AVB (Android Verified Boot) is well supported in U-Boot already. Add support for it in meson64_android. This is controlled by the "force_avb" environment variable and the CONFIG_CMD_AVB option. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- inclu

[PATCH 7/9] configs: sei510/sei610: reformat PARTS_default

2021-08-05 Thread Mattijs Korpershoek
There is a mix of spaces and tabs at the leading \. This makes updating theses lines harder. Add a single space before each \ for some consistency. Signed-off-by: Mattijs Korpershoek --- include/configs/sei510.h | 14 +++--- include/configs/sei610.h | 14 +++--- 2 files changed

[PATCH 9/9] configs: sei510/610: android bootflow via abootimg

2021-08-05 Thread Mattijs Korpershoek
to store various DTBOs - add a vbmeta partition for AVB hashes - Merge vendor and system into the "super" partition Note: avb support is disables by default. To activate it: => setenv force_avb 1; => saveenv; Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpersho

[PATCH 8/9] configs: sei510/sei610: don't use hard-coded gpt uuids

2021-08-05 Thread Mattijs Korpershoek
uid' command reads the current > value of the uuid_disk from the GPT. Since we have CONFIG_RANDOM_UUID=y, remove the hard-coded uuids and use meaningful variable names instead. Signed-off-by: Mattijs Korpershoek --- include/configs/sei510.h | 12 include/configs/sei610.h | 12

[PATCH 2/9] configs: meson64_android: increase SYS_MALLOC_LEN to 128M for AVB

2021-08-05 Thread Mattijs Korpershoek
To prepare for AVB support, increase SYS_MALLOC_LEN to 128M. This value has been found by testing the following on khadas vim3l: => avb init => avb verify Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 4 1 file changed, 4 insertions(+) diff --git a/i

[PATCH 4/9] configs: meson64_android: implement A/B slot support

2021-08-05 Thread Mattijs Korpershoek
-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 55 ++- 1 file changed, 47 insertions(+), 8 deletions(-) diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h index 48a23b6e41..83fa25bfb1

[PATCH 1/9] configs: meson64: permit redefining SYS_MALLOC_LEN

2021-08-05 Thread Mattijs Korpershoek
Permit redefining SYS_MALLOC_LEN for board specific configs. This is especially useful for Android with AVB, which requires a malloc length of 128M. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64.h | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 0/9] meson64_android: Android boot flow using abootimg

2021-08-05 Thread Mattijs Korpershoek
/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ Guillaume La Roque (2): configs: meson64_android: boot android via abootimg configs: sei510/610: android bootflow via abootimg Mattijs Korpershoek (7): configs: meson64: permit redefining SYS_MALLOC_LEN configs: meson64_android: increase

[PATCH 6/9] configs: meson64_android: boot android via abootimg

2021-08-05 Thread Mattijs Korpershoek
n is that we have only a "dtbo" partition, which includes all board dtbs and their dtbos [2] [1] https://source.android.com/devices/architecture/dto/partitions [2] https://android.googlesource.com/device/amlogic/yukawa/+/refs/heads/master/build/tasks/dtimages.mk#16 Signed-off-by: Guillaume La R

[PATCH 5/9] configs: meson64_android: define BOOT_CMD macro

2021-08-05 Thread Mattijs Korpershoek
BOOT_CMD might be different based on CONFIG_CMD_ABOOTIMG. To prepare for abootimg support, extract the boot command to a dedicated macro. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 6 -- 1 file changed, 4 insertions(+), 2

Re: [PATCH 1/9] configs: meson64: permit redefining SYS_MALLOC_LEN

2021-08-06 Thread Mattijs Korpershoek
Hi Tom, Neil, Neil Armstrong writes: > On 05/08/2021 19:16, Tom Rini wrote: >> On Thu, Aug 05, 2021 at 06:20:53PM +0200, Neil Armstrong wrote: >>> On 05/08/2021 17:17, Mattijs Korpershoek wrote: >>>> Permit redefining SYS_MALLOC_LEN for board specific configs.

[PATCH 3/6] configs: meson64_android: use CONFIG_FASTBOOT_USB_DEV

2021-07-29 Thread Mattijs Korpershoek
Right now, when running fastboot we use a hard-coded "0" for the device number. Use the Kconfig option named CONFIG_FASTBOOT_USB_DEV instead. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 4 ++-- 1 file changed, 2 insert

[PATCH 4/6] configs: meson64_android: use boot part label instead of index

2021-07-29 Thread Mattijs Korpershoek
el quite a lot on their public documentation [1] Load the boot partition by label instead of by index [1] https://source.android.com/devices/bootloader/partitions Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 10 ++ 1 file changed

[PATCH 2/6] configs: meson64_android: fix bad indent in EXTRA_ENV_SETTINGS

2021-07-29 Thread Mattijs Korpershoek
both lines seem to be joined together which is not the case for the meson64.h EXTRA_ENV_SETTINGS. Add a newline for consistency. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 5/6] configs: meson64_android: use logo part label instead of index

2021-07-29 Thread Mattijs Korpershoek
To display the bootup logo, we read the gpt and assume that the partition with index "2" will be the "logo" partition. This might not always be the case, and it's very error-prone. Load the logo partition by label instead of by index. Signed-off-by: Guillaume La Roque Si

[PATCH 6/6] configs: meson64_android: don't set console bootargs

2021-07-29 Thread Mattijs Korpershoek
Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h index 56545a72f8..3b61d5f703 100644 --- a/include/configs/meson64_android.h +++ b

[PATCH 0/6] VIM3: misc cleanups to prepare android support

2021-07-29 Thread Mattijs Korpershoek
Android. [1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards [2] https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ Mattijs Korpershoek (6): configs: sei610: fix typo in header comment configs: meson64_android: fix bad indent in EXTRA_ENV_SETTINGS

[PATCH 1/6] configs: sei610: fix typo in header comment

2021-07-29 Thread Mattijs Korpershoek
s/510/610/ Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/sei610.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/sei610.h b/include/configs/sei610.h index 6d093161c9..9eeffdd72c 100644 --- a/include/configs/sei610

[PATCH 5/5] configs: sei610/sei510: set CONFIG_CMD_BCB=y

2021-07-30 Thread Mattijs Korpershoek
SEI-610 and SEI-510 are both for Android boards based on Yukawa[1] Enable the BCB command to enable the standard Android boot flow. [1] https://android.googlesource.com/device/amlogic/yukawa/ Signed-off-by: Mattijs Korpershoek --- configs/sei510_defconfig | 1 + configs/sei610_defconfig | 1

[PATCH 3/5] configs: meson64_android: implement recovery boot via BCB

2021-07-30 Thread Mattijs Korpershoek
Right now meson64_android does not know how to boot into Android Recovery: it simply falls back to "fastboot" mode in the bootloader. Implement the boot to recovery. While at it, use the standard BCB way instead of a sm for consistency. Signed-off-by: Mattijs Korpershoek --- inclu

[PATCH 2/5] configs: meson64_android: use BCB for reboot to bootloader

2021-07-30 Thread Mattijs Korpershoek
ng sm calls. Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h index 3b61d5f703..d732032d1f 100644 -

[PATCH 1/5] Revert "ARM: meson: Add support for fastboot_set_reboot_flag()"

2021-07-30 Thread Mattijs Korpershoek
Signed-off-by: Mattijs Korpershoek --- arch/arm/mach-meson/board-common.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/arch/arm/mach-meson/board-common.c b/arch/arm/mach-meson/board-common.c index 1690b6b1e6..7ceba7cede 100644 --- a/arch/arm/mach-meson/board-comm

[PATCH 4/5] configs: meson64_android: reboot to fastbootd from bootloader

2021-07-30 Thread Mattijs Korpershoek
recovery mode or fastbootd mode. Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 4 1 file changed, 4 insertions(+) diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h index ce08346b70..f9f2b26416 100644 --- a/include/configs

[PATCH 0/5] meson64_android: use BCB for reboot reason

2021-07-30 Thread Mattijs Korpershoek
n handling to use the BCB, which is the standard Android way. [1] https://android.googlesource.com/device/amlogic/yukawa [2] https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ Mattijs Korpershoek (5): Revert "ARM: meson: Add support for fastboot_set_reboot_fl

[PATCH v2 2/5] configs: meson64_android: implement recovery boot via BCB

2021-07-30 Thread Mattijs Korpershoek
Right now meson64_android does not know how to boot into Android Recovery: it simply falls back to "fastboot" mode in the bootloader. Implement the boot to recovery. While at it, use the standard BCB way instead of a sm for consistency. Signed-off-by: Mattijs Korpershoek Acke

[PATCH v2 4/5] configs: sei610/sei510: set CONFIG_CMD_BCB=y

2021-07-30 Thread Mattijs Korpershoek
SEI-610 and SEI-510 are both for Android boards based on Yukawa[1] Enable the BCB command to enable the standard Android boot flow. [1] https://android.googlesource.com/device/amlogic/yukawa/ Signed-off-by: Mattijs Korpershoek Acked-by: Neil Armstrong --- configs/sei510_defconfig | 1

[PATCH v2 3/5] configs: meson64_android: reboot to fastbootd from bootloader

2021-07-30 Thread Mattijs Korpershoek
recovery mode or fastbootd mode. Signed-off-by: Mattijs Korpershoek Acked-by: Neil Armstrong --- include/configs/meson64_android.h | 4 1 file changed, 4 insertions(+) diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h index ce08346b70..f9f2b26416 100644

[PATCH v2 5/5] Revert "ARM: meson: Add support for fastboot_set_reboot_flag()"

2021-07-30 Thread Mattijs Korpershoek
Signed-off-by: Mattijs Korpershoek Acked-by: Neil Armstrong --- arch/arm/mach-meson/board-common.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/arch/arm/mach-meson/board-common.c b/arch/arm/mach-meson/board-common.c index 1690b6b1e6..7ceba7cede 100644 --- a/arc

[PATCH v2 1/5] configs: meson64_android: use BCB for reboot to bootloader

2021-07-30 Thread Mattijs Korpershoek
ng sm calls. Signed-off-by: Mattijs Korpershoek Acked-by: Neil Armstrong --- include/configs/meson64_android.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h index 3b61d5f70

[PATCH v2 0/5] meson64_android: use BCB for reboot reason

2021-07-30 Thread Mattijs Korpershoek
n handling to use the BCB, which is the standard Android way. [1] https://android.googlesource.com/device/amlogic/yukawa [2] https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ Changes in v2: * re-ordered commits * added Neil's Acked-by Mattijs Korpershoek (5): configs: meson

Re: [PATCH 0/5] meson64_android: use BCB for reboot reason

2021-07-30 Thread Mattijs Korpershoek
Hi Neil, Neil Armstrong writes: > On 30/07/2021 10:55, Mattijs Korpershoek wrote: >> The SEI-610 and SEI-510 boards are well supported in the >> Android Open Source project via the yukawa [1] platform. >> >> Their U-Boot version, despite being public [2] is not in m

Re: [PATCH 0/9] meson64_android: Android boot flow using abootimg

2021-08-06 Thread Mattijs Korpershoek
Hi Neil, Tom, Neil Armstrong writes: > On 05/08/2021 19:23, Tom Rini wrote: >> On Thu, Aug 05, 2021 at 05:17:19PM +0200, Mattijs Korpershoek wrote: >> >>> The SEI-610 and SEI-510 boards are well supported in the >>> Android Open Source project via the yukawa [

[PATCH 0/2] meson64_android: fix initial flashing failures

2021-11-17 Thread Mattijs Korpershoek
The SEI-610 and SEI-510 boards are well supported in the Android Open Source project via the yukawa [1] platform. Their U-Boot version, despite being public [2] is not in mainline. For initial boards, with an empty eMMC, we can have boot loops while using the flashing process described in [3].

[PATCH 1/2] configs: meson64_android: bypass other checks on run_fastboot=1

2021-11-17 Thread Mattijs Korpershoek
From: Neil Armstrong This can lead to GPT and BCB errors even if fastboot was selected early by usb rom boot and the eMMC is blank/invalid. Signed-off-by: Neil Armstrong Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 35 +-- 1 file

[PATCH 2/2] configs: meson64_android: add PANIC stage for SYSTEM fails

2021-11-17 Thread Mattijs Korpershoek
From: Neil Armstrong If bootloader was updated without running oem format, reboot will cause boot loop because the SYSTEM stage fails. Add a final PANIC stage running fastboot to permit recovery. Signed-off-by: Neil Armstrong Signed-off-by: Mattijs Korpershoek --- include/configs

[PATCH 2/5] configs: prepare khadas-vim3{l}_android for AOSP support

2021-11-19 Thread Mattijs Korpershoek
(commit 49c8ef0e45a91ec894ef15e7d043dafe8f1c5efd) and will be updated in future commits. [1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards [2] https://gitlab.com/baylibre/amlogic/atv/u-boot Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS | 2

[PATCH 5/5] configs: khadas-vim3{l}_android_ab: enable A/B support

2021-11-19 Thread Mattijs Korpershoek
meson64_android.h also relies on CMD_AB_SELECT so enable that as well. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 2 ++ configs/khadas-vim3l_android_ab_defconfig | 2 ++ include/configs/khadas-vim3_android.h | 16

[PATCH 0/5] meson64_android: add support for vim3/vim3l boards

2021-11-19 Thread Mattijs Korpershoek
-boot/v2021.07/integ Add defconfigs for both vim3, vim3l to support traditional and A/B booting/partitioning schemes. Mattijs Korpershoek (5): configs: meson64_android: add board specific env settings configs: prepare khadas-vim3{l}_android for AOSP support boards: meson: add khadas vim3{l

[PATCH 3/5] boards: meson: add khadas vim3{l} android support

2021-11-19 Thread Mattijs Korpershoek
Add all the necessary bits to flash and boot Android for both Khadas VIM3 and VIM3L boards. For Android instructions, refer to [1] [1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- configs/khadas

[PATCH 4/5] configs: prepare khadas-vim3{l}_ab_android for AOSP support

2021-11-19 Thread Mattijs Korpershoek
. This is identical to khadas-vim3{l}_ab_android but will be updated in the next commit. Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS| 2 + configs/khadas-vim3_android_ab_defconfig | 107 ++ configs/khadas-vim3l_android_ab_defconfig | 107

[PATCH 1/5] configs: meson64_android: add board specific env settings

2021-11-19 Thread Mattijs Korpershoek
This allows us to define extra board variables, such as "board" and "board_name". Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/meson64_

Re: [PATCH 3/5] boards: meson: add khadas vim3{l} android support

2021-11-22 Thread Mattijs Korpershoek
Hi Neil, Thank you for your review. Neil Armstrong writes: > Hi, > > On 19/11/2021 11:08, Mattijs Korpershoek wrote: >> Add all the necessary bits to flash and boot Android for both Khadas >> VIM3 and VIM3L boards. >> >> For Android instructio

Re: [PATCH 5/5] configs: khadas-vim3{l}_android_ab: enable A/B support

2021-11-22 Thread Mattijs Korpershoek
Hi Neil, Thank you for your review. Neil Armstrong writes: > Hi, > > On 19/11/2021 11:08, Mattijs Korpershoek wrote: >> meson64_android.h also relies on CMD_AB_SELECT so enable that as well. >> >> Signed-off-by: Guillaume La Roque >> Signed-off-by: Mattij

[PATCH v2 0/4] meson64_android: add support for vim3/vim3l boards

2021-11-22 Thread Mattijs Korpershoek
...@baylibre.com/T/#t Mattijs Korpershoek (4): configs: meson64_android: add board specific env settings configs: add khadas-vim3{l}_android for AOSP support configs: prepare khadas-vim3{l}_ab_android for AOSP support configs: khadas-vim3{l}_android_ab: enable A/B support board/amlogic/vim3

[PATCH v2 1/4] configs: meson64_android: add board specific env settings

2021-11-22 Thread Mattijs Korpershoek
This allows us to define extra board variables, such as "board" and "board_name". Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/configs/meson64_

[PATCH v2 3/4] configs: prepare khadas-vim3{l}_ab_android for AOSP support

2021-11-22 Thread Mattijs Korpershoek
. This is identical to khadas-vim3{l}_ab_android but will be updated in the next commit. Also update partitioning tables for A/B support. Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS| 2 + configs/khadas-vim3_android_ab_defconfig | 107 ++ configs

[PATCH v2 2/4] configs: add khadas-vim3{l}_android for AOSP support

2021-11-22 Thread Mattijs Korpershoek
to [1] [1] https://source.android.com/setup/build/devices#vim3_and_vim3l_boards [2] https://gitlab.com/baylibre/amlogic/atv/u-boot Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/MAINTAINERS | 2 + configs/khadas-vim3_android_defconfig | 107

[PATCH v2 4/4] configs: khadas-vim3{l}_android_ab: enable A/B support

2021-11-22 Thread Mattijs Korpershoek
meson64_android.h also relies on CMD_AB_SELECT so enable that as well. Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 2 ++ configs/khadas-vim3l_android_ab_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git

Re: [PATCH] fastboot: fix fastboot_set_reboot_flag()

2021-11-18 Thread Mattijs Korpershoek
[FASTBOOT_REBOOT_REASON_FASTBOOTD] = "boot-fastboot", >> > > Reviewed-by: Sean Anderson I'm using this in the (out of tree) U-Boot for khadas VIM3L/VIM3 boards: https://gitlab.com/baylibre/amlogic/atv/u-boot/-/tree/u-boot/v2021.07/integ Tested-by: Mattijs Korpershoek

Re: [PATCH] usb: gadget: dwc2_udc_otg: set ep's desc during enable/disable

2022-01-07 Thread Mattijs Korpershoek
gt; /* Nuke all pending requests */ >>> nuke(ep, -ESHUTDOWN); >>> >>> + _ep->desc = NULL; >>> ep->desc = 0; >>> ep->stopped = 1; >>> >>> >> >> An off-tree patch removed from our Yukawa backlog, thanks ! >> >> Reviewed-by: Neil Armstrong I can confirm this fixes flashing issues on VIM3/VIM3L boards when flashing AOSP(yukawa) with fastboot. Tested-by: Mattijs Korpershoek > > +CC Tom, can you pick this one for CURRENT 2022.01 release? > > Thank you

[PATCH] configs: meson64_android: define raw parts for bootloader

2022-01-07 Thread Mattijs Korpershoek
bootenv. [1] https://source.android.com/setup/build/devices#vim3-fastboot [2] https://u-boot.readthedocs.io/en/latest/board/amlogic/khadas-vim3l.html Suggested-by: Gary Bisson Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH] cmd: bcb: fix bcb struct alignment issue

2022-01-12 Thread Mattijs Korpershoek
s. > > To avoid issues the structure is aligned on DMA minimum alignment value > as it is passed directly to the read function. > > Signed-off-by: Gary Bisson > --- > cmd/bcb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Tested-by: Mattijs Korpershoek # on khadas vim3 &g

[PATCH] configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR for android

2022-01-12 Thread Mattijs Korpershoek
configs: amlogic: Disable CONFIG_NET_RANDOM_ETHADDR when unnecessary") cleanup. Disable CONFIG_NET_RANDOM_ETHADDR for the android configs as well to stay consistent. Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 1 - configs/khadas-vim3_android_defco

[PATCH] board: amlogic: vim3: configure serial# from ethaddr

2022-01-19 Thread Mattijs Korpershoek
Signed-off-by: Mattijs Korpershoek --- board/amlogic/vim3/vim3.c | 9 + 1 file changed, 9 insertions(+) diff --git a/board/amlogic/vim3/vim3.c b/board/amlogic/vim3/vim3.c index 5d9ac6458d68..fcd60ab1e058 100644 --- a/board/amlogic/vim3/vim3.c +++ b/board/amlogic/vim3/vim3.c @@ -153,6 +153,7

Re: [PATCH v2 15/17] usb: gadget: ether: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
On lun., sept. 04, 2023 at 11:10, Marek Vasut wrote: > On 9/4/23 09:56, Mattijs Korpershoek wrote: >> On ven., sept. 01, 2023 at 11:50, Marek Vasut wrote: >> >>> Convert to plain udevice interaction with UDC controller >>> device, avoid the use of UDC ucla

Re: [PATCH V6 10/20] include: env: ti: Add a generic default_findfdt.env

2023-08-28 Thread Mattijs Korpershoek
multiple boards and handles > architecture folder location changes centrally. > > TI ARMV7 platforms will need to override default_device_tree_subarch > in the env file to point to the appropriate platform. Note: default > "omap" is used to cater to "most common" default

Re: [PATCH V6 02/20] include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is not enabled

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > 'script' bootmethod that should be used with CONFIG_BOOTSTD. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > > Since Simon educated me to realize that the published documentation can > b

Re: [PATCH V6 11/20] board: ti: am62x: am62x.env: Use default findfdt

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > Use the default findfdt using CONFIG_DEFAULT_DEVICE_TREE > > Reviewed-by: Tom Rini > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change that pick

Re: [PATCH V6 08/20] include: configs: am62x_evm: Drop distro_bootcmd usage

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > Now that BOOTSTD is used by default, drop un-used header file > inclusion. > > Reviewed-by: Tom Rini > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- &

Re: [PATCH V6 00/20] board: ti: Add support for BeaglePlay

2023-08-28 Thread Mattijs Korpershoek
> > Robert Nelson (1): > arm: dts: Add k3-am625-beagleplay I re-tested v6. Using baseline 11cf91f755c7 ("Merge branch '2023-08-26-bootstd-chromeos-impreovements-and-move-to-gcc-13.2' into next") I could boot all the way to U-boot proper shell. And the LEDs work for me as well

Re: [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > If mmc dev reports that the device is not present, there is no point in > proceeding further to attempt to load the files. > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > new patch - notice

Re: [PATCH V6 06/20] board: ti: am62x: am62x.env: Add explicit boot_targets

2023-08-28 Thread Mattijs Korpershoek
ivalent > class. > > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change other than picking up reviews, tested tags along the way. > > V5: https://lore.kernel.org/r/20230824031101.3460411-5...@ti.com > board/ti/

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

2023-08-28 Thread Mattijs Korpershoek
> Reviewed-by: Tom Rini > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change other than picking up reviews, tested tags along the way. > V5: https://lore.kernel.org/r/20230824031101.3460411-6...@ti.com > configs

Re: [PATCH V6 16/20] configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset support

2023-08-28 Thread Mattijs Korpershoek
> Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > New patch picked from Jan > https://lore.kernel.org/all/c93b19ed-43fe-44a2-9726-371fb9d2f...@web.de/ > Changes: > - modify am62x_evm as common change. > - slight update to $subject and commit messag

Re: [PATCH V6 04/20] include: configs: am62x_evm: Drop unused SDRAM address

2023-08-28 Thread Mattijs Korpershoek
On ven., août 25, 2023 at 13:02, Nishanth Menon wrote: > Drop unused macro. This was meant for a second region of DDR which we > do not need for AM62x evm configurations. > > Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek &g

Re: [PATCH V6 05/20] include: configs: am62x_evm: Wrap distroboot with CONFIG_DISTRO_DEFAULTS

2023-08-28 Thread Mattijs Korpershoek
t; Tested-by: Mattijs Korpershoek > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > No change other than picking up reviews, tested tags along the way. > > V5: https://lore.kernel.org/r/20230824031101.3460411-4...@ti.com > > include/configs/am62x_ev

Re: [PATCH 2/2] arm: dts: k3-am625: Sync with kernel v6.6-rc1

2023-09-12 Thread Mattijs Korpershoek
On lun., sept. 11, 2023 at 09:02, Nishanth Menon wrote: > Sync device tree with v6.6-rc1 > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > arch/arm/dts/k3-am62-main.dtsi | 52 - > arch/arm/dts/k3-am62-mcu.dtsi| 24 +

Re: [PATCH 1/2] arm: dts: k3-pinctrl: Sync with kernel v6.6-rc1

2023-09-12 Thread Mattijs Korpershoek
On lun., sept. 11, 2023 at 09:02, Nishanth Menon wrote: > Sync pinctrl header with v6.6-rc1 > > Signed-off-by: Nishanth Menon Reviewed-by: Mattijs Korpershoek > --- > arch/arm/dts/k3-pinctrl.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arc

Re: [PATCH v5 10/21] boot: Rename Android-boot text

2023-09-15 Thread Mattijs Korpershoek
On jeu., sept. 14, 2023 at 10:55, Simon Glass wrote: > Phrases like 'Enable support for' are pointless since this is an option > which enables things. Drop that part so it is easier to follow. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > >

Re: [PATCH v2 05/17] cmd: rockusb: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
On ven., sept. 01, 2023 at 11:49, Marek Vasut wrote: > Convert to plain udevice interaction with UDC controller > device, avoid the use of UDC uclass dev_array . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Angus Ainslie > Cc: Dmitrii Merk

Re: [PATCH v2 07/17] cmd: thordown: Reorder variable declaration

2023-09-04 Thread Mattijs Korpershoek
On ven., sept. 01, 2023 at 11:49, Marek Vasut wrote: > Move the variable declaration around to improve code readability. > No functional change. > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Angus Ainslie > Cc: Dmitrii Merkurev > Cc

Re: [PATCH v2 13/17] thordown: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm Reviewed-by: Mattijs Ko

Re: [PATCH v2 14/17] usb: gadget: acm: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
On ven., sept. 01, 2023 at 11:50, Marek Vasut wrote: > Convert to plain udevice interaction with UDC controller > device, avoid the use of UDC uclass dev_array . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Angus Ainslie > Cc: Dmitrii Merk

Re: [PATCH v2 15/17] usb: gadget: ether: Use plain udevice for UDC controller interaction

2023-09-04 Thread Mattijs Korpershoek
c: Kever Yang > Cc: Lukasz Majewski > Cc: Miquel Raynal > Cc: Mattijs Korpershoek > Cc: Nishanth Menon > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Philipp Tomsich > Cc: Simon Glass > Cc: Stefan Roese > Cc: ker...@puri.sm > --- > V2: Use udev-

Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-02 Thread Mattijs Korpershoek
Hi Jaehoon, On mar., oct. 31, 2023 at 15:50, Mattijs Korpershoek wrote: > Hi, > > On Mon, 20 Jun 2022 20:13:54 +0900, Jaehoon Chung wrote: >> Add CONFIG_DFU_NAME_MAX_SIZE to change the proper size. >> If name is longer than default size, it can do wrong behavior during

RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-03 Thread Mattijs Korpershoek
Hi Jaehoon, On ven., nov. 03, 2023 at 10:07, "Jaehoon Chung" wrote: > Hi Mathtjjs, > >> -Original Message- >> From: Mattijs Korpershoek >> Sent: Thursday, November 2, 2023 6:15 PM >> To: Jaehoon Chung >> Cc: lu...@denx.de; u-boot@

[GIT PULL] Please pull u-boot-dfu-20231103

2023-11-03 Thread Mattijs Korpershoek
Hi Tom, Here is my first pull request of u-boot-dfu which includes: - Fix CRC chunk size in fastboot - Make size optional for dfu on mmc The CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/18433 Thanks, Mattijs The following changes since commit

Re: [PATCH] usb: gadget: f_mass_storage: Stop ums on START-STOP UNIT SCSI command

2023-11-07 Thread Mattijs Korpershoek
the media > and enter low power state. > > This effectively adds support for exitting the 'ums' command from > host using 'eject /dev/sdN' that is on par with 'dfu-util -e' . > > Signed-off-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > Cc: Lukasz Ma

RE: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-11-07 Thread Mattijs Korpershoek
Hi Jaehoon, On ven., nov. 03, 2023 at 14:49, "Jaehoon Chung" wrote: > Hi, > >> -Original Message- >> From: U-Boot On Behalf Of Jaehoon Chung >> Sent: Friday, November 3, 2023 10:07 AM >> To: 'Mattijs Korpershoek' >> Cc: lu...@denx.de; u-

Re: [PATCH] dfu: mmc: Add support for exposing whole mmc device

2023-10-31 Thread Mattijs Korpershoek
by: Marek Vasut > --- > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > doc/usage/dfu.rst | 5 + > drivers/dfu/dfu_mmc.c | 10 ++ > 2 files changed, 15 insertions(+) > > diff --git a/

Re: [PATCH] dfu: mmc: Add support for exposing whole mmc device

2023-10-31 Thread Mattijs Korpershoek
Hi, On Sun, 29 Oct 2023 23:37:22 +0100, Marek Vasut wrote: > Add support for exposing the whole mmc device by setting the 'size' > parameter to 0. This can be useful in case it is not clear what the > total device size is up front. Update the documentation accordingly. > > Thanks, Applied to

Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-10-31 Thread Mattijs Korpershoek
Hi, On Mon, 20 Jun 2022 20:13:54 +0900, Jaehoon Chung wrote: > Add CONFIG_DFU_NAME_MAX_SIZE to change the proper size. > If name is longer than default size, it can do wrong behavior during updating > image. So it need to change the proper maximum size. > > This patch is proviced the solution to

Re: [PATCH] fastboot: fix CRC32 chunk size checking

2023-10-31 Thread Mattijs Korpershoek
Hi, On Mon, 25 Sep 2023 12:37:15 +0200, Wojciech Nizinski wrote: > genimage create android-sparse file with CRC32 chunk at end. When > U-Boot's fastboot receives this chunk it returns error message: > `Fail Bogus chunk size for chunk type Dont Care` > > According to reference implementation of

Re: [PATCH] dfu: add CONFIG_DFU_NAME_MAX_SIZE configuration

2023-10-31 Thread Mattijs Korpershoek
imum size. > > This patch is proviced the solution to change value with configuration. > > Signed-off-by: Jaehoon Chung I could not find a maximum size in the DFU 1.1 spec [1] neither in the dfu-util codebase. [1] https://www.usb.org/sites/default/files/DFU_1.1.pdf Reviewed-by

[PATCH] configs: khadas-vim3*_android: fix environment saving

2023-10-26 Thread Mattijs Korpershoek
: b749d5ecdc06 ("configs: meson64_android: define raw parts for bootloader") Signed-off-by: Mattijs Korpershoek --- configs/khadas-vim3_android_ab_defconfig | 4 configs/khadas-vim3_android_defconfig | 4 configs/khadas-vim3l_android_ab_defconfig | 4 conf

Re: [PATCH v2 4/4] usb: Avoid unbinding devices in use by bootflows

2023-09-23 Thread Mattijs Korpershoek
Hi Simon, Thank you for your patch. On ven., sept. 22, 2023 at 15:38, Simon Glass wrote: > When a USB device is unbound, it causes any bootflows attached to it to > be removed, via a call to bootdev_clear_bootflows() from > bootdev_pre_unbind(). This obviously makes it impossible to boot the >

Re: [PATCH v5 39/43] command: Include a required header in command.h

2023-09-30 Thread Mattijs Korpershoek
On mer., sept. 27, 2023 at 08:22, Simon Glass wrote: > This uses ARRAY_SIZE() but does not include the header file which declares > it. Fix this, so that command.h can be included without common.h > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- &g

Re: [PATCH] fastboot: fix CRC32 chunk size checking

2023-10-02 Thread Mattijs Korpershoek
> > the chunk_header.total_sz is CHUNK_HEADER_LEN + 4 (CRC32 size). > > Signed-off-by: Wojciech Nizinski However, the change looks fine to me. Reviewed-by: Mattijs Korpershoek I also tested by reflashing a super image from aosp/main on the vim3 board. Base commit: 2173c4a99066 ("Me

Re: [PATCH RESEND v2 2/2] usb: udc: Try to clarify an error message

2023-10-05 Thread Mattijs Korpershoek
ses. Let's also hint people who would get this error and grep it into > the sources a better explanation of what's wrong with their workflow. > > Signed-off-by: Miquel Raynal Reviewed-by: Mattijs Korpershoek > --- > While doing this I really wanted to add "much more" er

Re: [PATCH RESEND v2 1/2] cmd: bind: Try to improve the (un)bind help

2023-10-05 Thread Mattijs Korpershoek
textual line. Unfortunately, > because of how this string is used (like within the 'help' command) I > cannot detail much more, but at least the pointer is there. > > Signed-off-by: Miquel Raynal Reviewed-by: Mattijs Korpershoek > --- > Resend: no change. > > Changes in

[PATCH 2/2] MAINTAINERS: fastboot: add Mattijs

2023-10-05 Thread Mattijs Korpershoek
Fastboot has been marked as orphaned since 2021. Since I'm interested in maintaining this, assign myself. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 008c593f30ee..6790f4ddbd45 100644

[PATCH 1/2] MAINTAINERS: usb gadget: add Mattijs

2023-10-05 Thread Mattijs Korpershoek
It seems that Lukasz and Marek could get some help in maintaining the usb gadget drivers. Assign myself as maintainer. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4df79254dfe1..008c593f30ee 100644

[PATCH 0/2] MAINTAINERS: Add Mattijs to USB/fastboot maintainers

2023-10-05 Thread Mattijs Korpershoek
ell. Note that I have no previous (open-source) maintainer experience so I will do my best to learn. Signed-off-by: Mattijs Korpershoek --- Mattijs Korpershoek (2): MAINTAINERS: usb gadget: add Mattijs MAINTAINERS: fastboot: add Mattijs MAINTAINERS | 4 +++- 1 file changed, 3 inserti

Re: [PATCH v3 1/3] cmd: Change the dependencies between CMD_BIND and USB_GADGET

2023-10-18 Thread Mattijs Korpershoek
ply' keyword to enforce this. > > Signed-off-by: Miquel Raynal Tested that the bind command exists when building with: configs/khadas-vim3_android_defconfig Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek # on vim3 > --- > cmd/Kconfig| 1 - > drivers/us

Re: [PATCH] phy: meson-g12a-usb2: fix ret check on power_domain_get

2023-10-18 Thread Mattijs Korpershoek
domain > No USB device found > USB init failed: -19 > > Add ENOENT check on ret in probe function. > > Fixes: 5533c883ce10 ("phy: support Amlogic A1 family") > > Signed-off-by: Guillaume La Roque Tested on vim3 with: => fastboot usb 0 Tested-by: Mattij

Re: [PATCH 0/2] MAINTAINERS: Add Mattijs to USB/fastboot maintainers

2023-10-19 Thread Mattijs Korpershoek
oot/custodians/u-boot-dfu ? If yes, I imagine I would need write access to it. > >> Signed-off-by: Mattijs Korpershoek >> --- >> Mattijs Korpershoek (2): >> MAINTAINERS: usb gadget: add Mattijs >> MAINTAINERS: fastboot: add Mattijs >> >>

Re: [PATCH 0/2] MAINTAINERS: Add Mattijs to USB/fastboot maintainers

2023-10-19 Thread Mattijs Korpershoek
On jeu., oct. 19, 2023 at 10:18, Lukasz Majewski wrote: > On Thu, 19 Oct 2023 09:40:37 +0200 > Mattijs Korpershoek wrote: > >> Hi Lukasz, Marek, >> >> On mer., oct. 18, 2023 at 12:52, Lukasz Majewski >> wrote: >> >> > Hi Mattijs, >> &

Re: [PATCH] doc: Replace dm_dump_all() with dm_dump_tree()

2023-10-20 Thread Mattijs Korpershoek
ed-off-by: Dylan Corrales Reviewed-by: Mattijs Korpershoek > --- > > doc/develop/driver-model/debugging.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/develop/driver-model/debugging.rst > b/doc/develop/driver-model/debugging.rst > index

Re: [PATCH 0/4] ARM: meson: Add boot over DFU RAM as an USB boot step

2023-10-24 Thread Mattijs Korpershoek
rmstrong I did a simple boot to aosp/main test on vim3 and also used fastboot to flash the bootloader. Tested-by: Mattijs Korpershoek # on vim3 > --- > Neil Armstrong (4): > ARM: meson: enable FIT with LEGACY_IMAGE_FORMAT on all configs > configs: meson64: declare addr

  1   2   3   4   5   >