Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-17 Thread Michal Simek
On 4/17/23 15:48, Jassi Brar wrote: On Mon, 17 Apr 2023 at 01:38, Michal Simek wrote: On 4/14/23 17:02, Jassi Brar wrote: + +/* This will dynamically allocate the fwu_mdata */ +#define CONFIG_FWU_NUM_BANKS 0 +#define CONFIG_FWU_NUM_IMAGES_PER_BANK 0 These two are

Re: [PATCH] Revert "spi: zynq_qspi: Use dummy buswidth in dummy byte calculation"

2023-04-17 Thread Michal Simek
On 3/31/23 16:44, Stefan Herbrechtsmeier wrote: From: Stefan Herbrechtsmeier This reverts commit e09784728689de7949d4cdd559a9590e0bfcc702. The commit wrongly divides the dummy bytes by dummy bus width to calculate the dummy bytes. The framework already converts the dummy cycles to the number

Re: [PATCH 1/2] firmware: zynqmp: Mask expected and show unexpected warning

2023-04-17 Thread Michal Simek
On 4/3/23 15:34, Stefan Herbrechtsmeier wrote: From: Stefan Herbrechtsmeier Mask the expected and show the unexpected warning "No permission to change config object" for NODE_OCM_BANK_0 because this node is used to detect if further zynqmp_pmufw_node function calls should be skipped. Signed

Re: [PATCH] arm64: zynqmp: Fix User MTD partition size

2023-04-17 Thread Michal Simek
On 4/12/23 16:30, Michal Simek wrote: The commit c8630167e0dc ("arm64: zynqmp: Add mtd partition for secure OS storage area") didn't update User partition size that's why size was beyond actual device size. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sm-k26

Re: [PATCH] arm64: zynqmp: Fix issue of apps executing from R5 core 1

2023-04-17 Thread Michal Simek
On 4/5/23 15:06, Michal Simek wrote: From: Ashok Reddy Soma In current implementation, applications can execute only on R5 core 0. The boot address for R5 core 1 is not supplied. Pass TCM address for R5 core 1 based on the argument to fix the issue. Remove incomplete comment. Signed-off

Re: [PATCH] ARM: zynq: Sync Microzed board with Linux kernel

2023-04-17 Thread Michal Simek
On 3/28/23 09:21, Michal Simek wrote: Fix model name, node locations and also add pinctrl description for usb. Signed-off-by: Michal Simek --- --- arch/arm/dts/zynq-microzed.dts | 42 -- 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/arch

Re: [PATCH] ARM: zynq: Switch from earlyprintk to earlycon

2023-04-17 Thread Michal Simek
On 3/28/23 09:17, Michal Simek wrote: Switch to earlycon which is preffered over earlyprintk. It is also sync with Linux kernel (zynq-microzed). Signed-off-by: Michal Simek --- --- arch/arm/dts/zynq-dlc20-rev1.0.dts | 2 +- arch/arm/dts/zynq-microzed.dts | 2 +- 2 files changed, 2

Re: [PATCH v2 2/2] configs: Add CONFIG_DEFAULT_ENV_IS_RW config for armada

2023-04-17 Thread Michal Simek
On 4/17/23 06:28, Venkatesh Yadav Abbarapu wrote: From: Algapally Santosh Sagar The DEFAULT_ENV_IS_RW is moved to the Kconfig for easier configuration. Hence, the CONFIG_DEFAULT_ENV_IS_RW config is added to the defconfig files to allow enabling them for armada boards. Signed-off-by: Algapal

Re: [PATCH v2 1/2] serial: zynqmp: Fetch baudrate from dtb and update

2023-04-17 Thread Michal Simek
On 4/17/23 06:28, Venkatesh Yadav Abbarapu wrote: From: Algapally Santosh Sagar The baudrate configured in .config is taken by default by serial. If change of baudrate is required then the .config needs to changed and u-boot recompilation is required or the u-boot environment needs to be upd

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-16 Thread Michal Simek
On 4/14/23 17:02, Jassi Brar wrote: On Fri, Apr 14, 2023 at 8:53 AM Michal Simek wrote: On 4/10/23 06:05, Jassi Brar wrote: On Wed, 29 Mar 2023 at 07:29, Michal Simek wrote: On 3/27/23 23:16, jassisinghb...@gmail.com wrote: diff --git a/tools/mkfwumdata.c b/tools/mkfwumdata.c new

Re: [PATCH v5 0/6] FWU: Add support for mtd backed feature on DeveloperBox

2023-04-14 Thread Michal Simek
On 4/11/23 01:01, jaswinder.si...@linaro.org wrote: From: Jassi Brar Introduce support for mtd backed storage for FWU feature and enable it on Synquacer platform based DeveloperBox. This revision is rebased onto patchset that trims the FWU api https://lore.kernel.org/u-boot/2023030623174

Re: [PATCH] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-04-14 Thread Michal Simek
On 4/11/23 07:38, Krzysztof Kozlowski wrote: On 11/04/2023 01:21, jaswinder.si...@linaro.org wrote: From: Jassi Brar Any requirement of FWU should not require changes to bindings of other subsystems. For example, for mtd-backed storage we can do without requiring 'fixed-partitions' children

Re: [PATCH v4 1/6] FWU: Add FWU metadata access driver for MTD storage regions

2023-04-14 Thread Michal Simek
On 4/10/23 05:56, Jassi Brar wrote: On Wed, 29 Mar 2023 at 07:00, Michal Simek wrote: On 3/27/23 23:15, jassisinghb...@gmail.com wrote: diff --git a/drivers/fwu-mdata/raw_mtd.c b/drivers/fwu-mdata/raw_mtd.c new file mode 100644 index 00..4b1a10073a --- /dev/null +++ b/drivers/fwu

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-14 Thread Michal Simek
On 4/10/23 06:05, Jassi Brar wrote: On Wed, 29 Mar 2023 at 07:29, Michal Simek wrote: On 3/27/23 23:16, jassisinghb...@gmail.com wrote: diff --git a/tools/mkfwumdata.c b/tools/mkfwumdata.c new file mode 100644 index 00..43dabf3b72 --- /dev/null +++ b/tools/mkfwumdata.c @@ -0,0

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-04-14 Thread Michal Simek
On 4/10/23 06:25, Jassi Brar wrote: On Wed, 29 Mar 2023 at 15:02, Simon Glass wrote: Hi, On Tue, 28 Mar 2023 at 10:16, wrote: From: Masami Hiramatsu Add 'mkfwumdata' tool to generate FWU metadata image for the meta-data partition to be used in A/B Update imeplementation. Signed-off-b

Re: [PATCH v4 6/6] fwu: DeveloperBox: add support for FWU

2023-04-14 Thread Michal Simek
On 4/10/23 06:21, Jassi Brar wrote: On Wed, 29 Mar 2023 at 08:02, Michal Simek wrote: On 3/27/23 23:16, jassisinghb...@gmail.com wrote: . + +void fwu_plat_get_bootidx(uint *boot_idx) +{ + int ret; + u32 active_idx; + u32 *bootidx = boot_idx; + + ret

[PATCH] arm64: zynqmp: Fix User MTD partition size

2023-04-12 Thread Michal Simek
The commit c8630167e0dc ("arm64: zynqmp: Add mtd partition for secure OS storage area") didn't update User partition size that's why size was beyond actual device size. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sm-k26-revA.dts | 2 +- 1 file changed, 1 inse

Re: [PATCH v2] cmd: sf/nand: Print and return failure when 0 length is passed

2023-04-12 Thread Michal Simek
return CMD_RET_FAILURE; + } + /* Consistency checking */ if (offset + size > flash->size) { printf("ERROR: attempting %s past flash size (%#x)\n", Acked-by: Michal Simek Thanks, Michal

Re: [PATCH] cmd: sf/nand: Print and return failure when 0 length is passed

2023-04-12 Thread Michal Simek
On 4/12/23 09:13, Ashok Reddy Soma wrote: For sf commands, when '0' length is passed for erase, update, write or read, we might see undesired results. Ideally '0' length means nothing to Use imperative mode. do. So print 'size is 0' and return cmd failure when length '0' is passed to sf c

Re: [PATCH 1/2] xen: Add dependency on armv8

2023-04-12 Thread Michal Simek
On 4/12/23 06:57, Marek Vasut wrote: On 4/11/23 13:23, Michal Simek wrote: Xen core calls HYPERVISOR_memory_op() in map_shared_info() which is just in xen_init() called from init_sequence_r[]. Xen can run only on armv8 where HVC calls are implemented that's why enable it only for

[PATCH 2/2] xen: Limit execution to EL1 only

2023-04-11 Thread Michal Simek
Xen core_init() is calling HVC which should be called from EL1 level that's why do Xen initialization only when U-Boot runs in EL1. Signed-off-by: Michal Simek --- drivers/xen/hypervisor.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/xen/hypervisor.c b/driver

[PATCH 1/2] xen: Add dependency on armv8

2023-04-11 Thread Michal Simek
Xen core calls HYPERVISOR_memory_op() in map_shared_info() which is just in xen_init() called from init_sequence_r[]. Xen can run only on armv8 where HVC calls are implemented that's why enable it only for arm64. Signed-off-by: Michal Simek --- Depends on https://lore.kernel.

Re: [PATCH] xen: Fix Kconfig dependencies

2023-04-06 Thread Michal Simek
On 4/6/23 10:22, Heinrich Schuchardt wrote: On 4/6/23 10:04, Michal Simek wrote: XEN config can be enabled by other platforms (even it doesn't need to make sense) that's why fix dependencies. XEN (xenbus.c) requires sscanf (also pvblock needs it). And PVBLOCK is inside drivers/

[PATCH] xen: Fix Kconfig dependencies

2023-04-06 Thread Michal Simek
XEN config can be enabled by other platforms (even it doesn't need to make sense) that's why fix dependencies. XEN (xenbus.c) requires sscanf (also pvblock needs it). And PVBLOCK is inside drivers/xen folder which requires XEN to be enabled. Signed-off-by: Michal Simek --- If XEN

[PATCH] arm64: zynqmp: Fix issue of apps executing from R5 core 1

2023-04-05 Thread Michal Simek
From: Ashok Reddy Soma In current implementation, applications can execute only on R5 core 0. The boot address for R5 core 1 is not supplied. Pass TCM address for R5 core 1 based on the argument to fix the issue. Remove incomplete comment. Signed-off-by: Ashok Reddy Soma Signed-off-by: Michal

Re: [PATCH v6 09/11] xilinx: Disable CONFIG_BOOTSTD_DEFAULTS for some xilinx boards

2023-04-02 Thread Michal Simek
's why disabling any configuration related to distro boot is the right way to go. Acked-by: Michal Simek Thanks, Michal

Re: [PATCH v4 0/6] FWU: Add support for mtd backed feature on DeveloperBox

2023-03-30 Thread Michal Simek
On 3/27/23 23:14, jassisinghb...@gmail.com wrote: From: Jassi Brar Introduce support for mtd backed storage for FWU feature and enable it on Synquacer platform based DeveloperBox. This revision is rebased onto patchset that trims the FWU api https://lore.kernel.org/u-boot/20230306231747.

Re: [PATCH v4 0/6] FWU: Add support for mtd backed feature on DeveloperBox

2023-03-29 Thread Michal Simek
On 3/27/23 23:14, jassisinghb...@gmail.com wrote: From: Jassi Brar Introduce support for mtd backed storage for FWU feature and enable it on Synquacer platform based DeveloperBox. This revision is rebased onto patchset that trims the FWU api https://lore.kernel.org/u-boot/20230306231747.

Re: [PATCH v4 6/6] fwu: DeveloperBox: add support for FWU

2023-03-29 Thread Michal Simek
On 3/27/23 23:16, jassisinghb...@gmail.com wrote: From: Jassi Brar Add code to support FWU_MULTI_BANK_UPDATE. The platform does not have gpt-partition storage for Banks and MetaData, rather it used SPI-NOR backed mtd regions for the purpose. Signed-off-by: Jassi Brar --- board/socionext/

Re: [PATCH v4 3/6] tools: Add mkfwumdata tool for FWU metadata image

2023-03-29 Thread Michal Simek
On 3/27/23 23:16, jassisinghb...@gmail.com wrote: From: Masami Hiramatsu Add 'mkfwumdata' tool to generate FWU metadata image for the meta-data partition to be used in A/B Update imeplementation. Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu Signed-off-by: Jassi Brar ---

Re: [PATCH v4 1/6] FWU: Add FWU metadata access driver for MTD storage regions

2023-03-29 Thread Michal Simek
On 3/27/23 23:15, jassisinghb...@gmail.com wrote: From: Masami Hiramatsu In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, on a separate region. Add a driver for reading from and writing to the metadata when the updatable imag

Re: [PATCH v4 2/6] FWU: mtd: Add helper functions for accessing FWU metadata

2023-03-29 Thread Michal Simek
On 3/27/23 23:16, jassisinghb...@gmail.com wrote: From: Masami Hiramatsu Add helper functions needed for accessing the FWU metadata which contains information on the updatable images. Signed-off-by: Masami Hiramatsu Signed-off-by: Jassi Brar --- include/fwu.h | 34

Re: [PATCH v4 4/6] dt: fwu: developerbox: enable fwu banks and mdata regions

2023-03-29 Thread Michal Simek
On 3/27/23 23:16, jassisinghb...@gmail.com wrote: From: Jassi Brar Specify Bank-0/1 and fwu metadata mtd regions. Signed-off-by: Jassi Brar --- .../synquacer-sc2a11-developerbox-u-boot.dtsi | 49 +-- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/arch/arm

Re: [PATCH v4 1/4] bootstd: Enable BOOTSTD_DEFAULTS by default

2023-03-29 Thread Michal Simek
nfigs/xilinx_zynqmp_mini_emmc1_defconfig | 2 +- 19 files changed, 19 insertions(+), 3 deletions(-) Acked-by: Michal Simek #xilinx Thanks, Michal

[PATCH] ARM: zynq: Sync Microzed board with Linux kernel

2023-03-28 Thread Michal Simek
Fix model name, node locations and also add pinctrl description for usb. Signed-off-by: Michal Simek --- --- arch/arm/dts/zynq-microzed.dts | 42 -- 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/arch/arm/dts/zynq-microzed.dts b/arch/arm/dts/zynq

[PATCH] ARM: zynq: Switch from earlyprintk to earlycon

2023-03-28 Thread Michal Simek
Switch to earlycon which is preffered over earlyprintk. It is also sync with Linux kernel (zynq-microzed). Signed-off-by: Michal Simek --- --- arch/arm/dts/zynq-dlc20-rev1.0.dts | 2 +- arch/arm/dts/zynq-microzed.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH] xilinx: Enable virtio mmio transport and devices

2023-03-27 Thread Michal Simek
On 3/23/23 15:52, Michal Simek wrote: Qemu can create virtio mmio transports and passing devices through it that's why enable virtio by default on all arm64 based SoCs. Signed-off-by: Michal Simek --- configs/xilinx_versal_net_virt_defconfig | 7 ++- co

Re: [PATCH v1 1/1] arch: arm: zynqmp: mp.c: tcminit halt both cores in split mode

2023-03-27 Thread Michal Simek
On 3/23/23 09:25, Neal Frager wrote: The "zynqmp tcminit split" command should halt both cores and not just RPU1 when configuring the TCM memory for split mode. Signed-off-by: Neal Frager --- arch/arm/mach-zynqmp/mp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-zyn

Re: [PATCH v2] net: phy: gmii2rgmii: Support external rgmii-id phy

2023-03-27 Thread Michal Simek
On 3/22/23 09:42, Stefan Herbrechtsmeier wrote: From: Stefan Herbrechtsmeier Read the phy mode of the external phy from the device tree if available and check that it is a RGMII variant. Signed-off-by: Stefan Herbrechtsmeier --- Changes in v2: - Check that the external phy mode is a RGMI

[PATCH] xilinx: Enable virtio mmio transport and devices

2023-03-23 Thread Michal Simek
Qemu can create virtio mmio transports and passing devices through it that's why enable virtio by default on all arm64 based SoCs. Signed-off-by: Michal Simek --- configs/xilinx_versal_net_virt_defconfig | 7 ++- configs/xilinx_versal_virt_defconfig | 7 ++- co

Re: [PATCH v2 1/2] lmb: Fix LMB_MEMORY_REGIONS flag usage

2023-03-23 Thread Michal Simek
lmb *lmb) #if IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) lmb->memory.max = CONFIG_LMB_MAX_REGIONS; lmb->reserved.max = CONFIG_LMB_MAX_REGIONS; -#elif defined(CONFIG_LMB_MEMORY_REGIONS) +#else lmb->memory.max = CONFIG_LMB_MEMORY_REGIONS; lmb->reserved.max = CONFIG_LMB_RESERVED_REGIONS; lmb->memory.region = lmb->memory_regions; Acked-by: Michal Simek Thanks, Michal

Re: [PATCH] net: phy: gmii2rgmii: Support external rgmii-id phy

2023-03-22 Thread Michal Simek
On 3/20/23 16:55, Stefan Herbrechtsmeier wrote: From: Stefan Herbrechtsmeier Read the phy mode of the external phy from the device tree if available. Signed-off-by: Stefan Herbrechtsmeier --- drivers/net/phy/xilinx_gmii2rgmii.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH] serial: zynqmp: Fetch baudrate from dtb and update

2023-03-21 Thread Michal Simek
Hi Simon and Tom, On 3/14/23 09:46, Venkatesh Yadav Abbarapu wrote: From: Algapally Santosh Sagar The baudrate configured in .config is taken by default by serial. If change of baudrate is required then the .config needs to changed and u-boot recompilation is required or the u-boot environment

Re: [PATCH 01/41] net: phy: aquantia: Staticize PHY driver entries

2023-03-21 Thread Michal Simek
Alex Nemirovsky Cc: Haolin Li Cc: Heinrich Schuchardt Cc: Joe Hershberger Cc: Joel Stanley Cc: Josua Mayer Cc: Marek Vasut Cc: Michael Trimarchi Cc: Michal Simek Cc: Nate Drude Cc: Neil Armstrong Cc: Radu Pirea Cc: Ramon Fried Cc: Samuel Mendoza-Jonas Cc: Stefan Roese Cc: T Karthik

Re: [PATCH 1/2] lmb: Fix LMB_MEMORY_REGIONS flag usage

2023-03-21 Thread Michal Simek
On 3/21/23 13:58, Patrick Delaunay wrote: Remove test on CONFIG_LMB_MEMORY_REGIONS introduced by commit 7c1860fce4e3 ("lmb: Fix lmb property's defination under struct lmb"). This code in lmb_init() is strange, because if CONFIG_LMB_USE_MAX_REGIONS and CONFIG_LMB_MEMORY_REGIONS are not defined

Re: [QUESTION] Device tree for gmii-to-rgmii phy driver

2023-03-17 Thread Michal Simek
Hi, On 3/16/23 17:52, Stefan Herbrechtsmeier wrote: Hi Siva Durga Prasad Paladugu, we want to add rgmii-id support to the gmiitorgmii phy driver. How does the correct device tree for the gmiitorgmii looks like? The converter sits between the MAC and the external PHY (MAC <==> GMII2RGMII <==>

[GIT PULL] xilinx patches for v2023.07-rc1

2023-03-15 Thread Michal Simek
ies Michael Grzeschik (1): arm64: zynqmp: Enable hs termination flag for USB dwc3 controller Michal Simek (6): xilinx: dts: Remove cdns,zynq-gem ARM: zynq: Use recommended dma-controller name instead of dmac ARM: zynq: Comment interrupt names IRQs for pl330 cmd: sm

Re: [PATCH v2 2/5] tools: relocate-rela: introduce elf16_to_cpu() and elf32_to_cpu()

2023-03-15 Thread Michal Simek
On 3/11/23 18:38, Ovidiu Panait wrote: Add elf16_to_cpu() and elf32_to_cpu() functions that allow to read data in both big-endian and little-endian formats. Reviewed-by: Michal Simek I didn't give you this line in v1. But patch looks fine now. Applied the whole series. Thanks, Michal

Re: [PATCH 5/5] microblaze: drop remnants of manual reloc

2023-03-08 Thread Michal Simek
-#endif /* Flush caches to ensure consistency */ brlid r15, flush_cache_all Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH 4/5] microblaze: drop CONFIG_NEEDS_MANUAL_RELOC

2023-03-08 Thread Michal Simek
f !NEEDS_MANUAL_RELOC + def_bool y choice prompt "Target select" Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH 3/5] tools: relocate-rela: add support for handling 32-bit big endian files

2023-03-08 Thread Michal Simek
swrela.r_offset = elf32_to_cpu(rela.r_offset); + swrela.r_info = elf32_to_cpu(rela.r_info); + swrela.r_addend = elf32_to_cpu(rela.r_addend); debug("SWRela:\toffset:\t%" PRIx32 " r_info:\t%" PRIu32 " r_addend:\t%" PRIx32 "\n", Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH 1/5] tools: relocate-rela: adjust le64_to_cpu -> le32_to_cpu in decode_elf32()

2023-03-08 Thread Michal Simek
offset = le32_to_cpu(sh_table[i].sh_offset); + sh_size = le32_to_cpu(sh_table[i].sh_size); if (!strcmp(".rela.dyn", sh_name)) { debug("Found section\t\".rela_dyn\"\n"); Reviewed-by: Michal Simek Thanks, Michal

Re: [PATCH 2/5] tools: relocate-rela: introduce elf16_to_cpu() and elf32_to_cpu()

2023-03-08 Thread Michal Simek
On 3/5/23 18:49, Ovidiu Panait wrote: Add elf16_to_cpu() and elf32_to_cpu() functions that allow to read data in both big-endian and little-endian formats. Signed-off-by: Ovidiu Panait --- tools/relocate-rela.c | 20 1 file changed, 20 insertions(+) diff --git a/too

Re: [PATCH v3 0/2] Fix sparse warnings

2023-03-08 Thread Michal Simek
On 3/1/23 11:33, Ashok Reddy Soma wrote: Run and fix sparse warnings in below files -arch/arm/mach-zynqmp/include/mach/sys_proto.h -common/spl/spl.c -arch/arm/mach-versal-net/include/mach/sys_proto.h -arch/arm/mach-versal/include/mach/sys_proto.h -drivers/mmc/zynq_sdhci.c -drivers/

Re: [PATCH 0/4] Fix arasan nand driver issues

2023-03-07 Thread Michal Simek
Hi, On 3/7/23 15:02, Michael Nazzareno Trimarchi wrote: Hi On Tue, Mar 7, 2023 at 2:35 PM Michal Simek <mailto:michal.si...@amd.com>> wrote: On 2/24/23 06:07, Ashok Reddy Soma wrote: > In this patch series >   - Remove hardcoding of NAND_BBT_USE_FLASH in na

Re: [PATCH 0/4] Fix arasan nand driver issues

2023-03-07 Thread Michal Simek
On 2/24/23 06:07, Ashok Reddy Soma wrote: In this patch series - Remove hardcoding of NAND_BBT_USE_FLASH in nand->bbt_options - Find and update nand ofnode. - Fix nand node in zynqmp-zc1751-xm017-dc3.dts file - Enable nand-on-flash-bbt flag in zynqmp DT's by default Ashok Reddy Soma

Re: [PATCH v2] spi: xilinx_spi: Fix spi reset

2023-03-07 Thread Michal Simek
; > > + regs = priv->regs = (struct xilinx_spi_regs *)dev_read_addr(bus); > priv->fifo_depth = dev_read_u32_default(bus, "fifo-size", 0); > > writel(SPISSR_RESET_VALUE, ®s->srr); > -- > 2.30.2 > Applied. M -- Michal Simek, Ing. (M.Eng), Ope

Re: [PATCH v5 1/6] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-02-28 Thread Michal Simek
On 2/28/23 01:52, jassisinghb...@gmail.com wrote: From: Jassi Brar Any requirement of FWU should not require changes to bindings of other subsystems. For example, for mtd-backed storage we can do without requiring 'fixed-partitions' children to also carry 'uuid', a property which is non-stan

Re: [PATCH 3/4] arm64: dts: zynqmp: Fix nand dt node

2023-02-27 Thread Michal Simek
On 2/27/23 15:58, Dario Binacchi wrote: Hi Ashok, On Fri, Feb 24, 2023 at 6:07 AM Ashok Reddy Soma wrote: DC3 nand node is not correct, it is showing all partitions under controller node directly. Create two sub nand nodes with partitions for each. Signed-off-by: Ashok Reddy Soma ---

Re: [PATCH] spi: xilinx_spi: Fix potential null pointer access

2023-02-27 Thread Michal Simek
On 2/21/23 06:22, Jiajie Chen wrote: It was incorrectly using an old priv->regs pointer, and may lead to null pointer access. I would describe it a little bit differently to describe what it happening. priv structure is initiated by DM core to zeros that's why regs property is pointing to

Re: [PATCH] arm64: zynqmp: Remove comment about gem spec in kv260

2023-02-27 Thread Michal Simek
On 2/20/23 09:09, Michal Simek wrote: The latest SOM specification doesn't enforce certain MIO lines allocated for ethernet or ethernet controller itself. That's why remove comment about it which is likely there from early version of specification. Also removed the same comment fr

Re: [PATCH 1/2] cmd: smccc: Print results in hex instead of dec

2023-02-27 Thread Michal Simek
On 2/15/23 09:45, Michal Simek wrote: Printing return value in HEX instead of DEC. Return values are 64 bit values which impossible to decode in DEC. For example getting CHIP ID in dec is quite long. Signed-off-by: Michal Simek --- cmd/smccc.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order

2023-02-23 Thread Michal Simek
Hi, On 2/24/23 05:53, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar Add missing prototype to fix the sparse warning, warning: no previous prototype for 'board_boot_order' [-Wmissing-prototypes]. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- Changes in

Re: [PATCH v2] usb: dwc3: Use the devm_gpiod_get_optional() API for reset gpio

2023-02-23 Thread Michal Simek
On 2/22/23 16:33, Marek Vasut wrote: On 2/22/23 08:01, Michal Simek wrote: On 2/22/23 02:06, Marek Vasut wrote: On 1/13/23 06:12, Venkatesh Yadav Abbarapu wrote: As the "reset-gpios" property is optional, don't return the error and just skip the gpio reset sequence.

Re: [PATCH v2] usb: dwc3: Use the devm_gpiod_get_optional() API for reset gpio

2023-02-21 Thread Michal Simek
On 2/22/23 02:06, Marek Vasut wrote: On 1/13/23 06:12, Venkatesh Yadav Abbarapu wrote: As the "reset-gpios" property is optional, don't return the error and just skip the gpio reset sequence. Signed-off-by: Venkatesh Yadav Abbarapu --- Changes in v2: - Replaced the gpio_request_by_name() th

Re: [PATCH 2/2] xilinx: zynqmp: Add missing prototype for board_boot_order

2023-02-20 Thread Michal Simek
On 2/21/23 08:03, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar Add missing prototype to fix the sparse warning, warning: no previous prototype for 'board_boot_order' [-Wmissing-prototypes]. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- arch/arm/mac

Re: [PATCH v2] arm64: zynqmp: Add an OP-TEE node to the device tree

2023-02-20 Thread Michal Simek
On 2/16/23 14:39, Ilias Apalodimas wrote: Since the zynqmp boards can run upstream OP-TEE, and having the DT node present doesn't cause any side effects add it in case someone tries to load OP-TEE. Signed-off-by: Ilias Apalodimas --- changes since v1: - move the defintion to the .dtsi coveri

[PATCH] arm64: zynqmp: Remove comment about gem spec in kv260

2023-02-20 Thread Michal Simek
be defined for different carrier cards. Signed-off-by: Michal Simek --- arch/arm/dts/zynqmp-sck-kr-g-revA.dts | 2 +- arch/arm/dts/zynqmp-sck-kr-g-revB.dts | 2 +- arch/arm/dts/zynqmp-sck-kv-g-revA.dts | 4 ++-- arch/arm/dts/zynqmp-sck-kv-g-revB.dts | 4 ++-- 4 files changed, 6 insertions(+), 6

Re: [PATCH] arm64: zynqmp: Add an OP-TEE node to the device tree

2023-02-16 Thread Michal Simek
On 2/16/23 13:44, Ilias Apalodimas wrote: Since the zynqmp boards can run upstream OP-TEE, and having the DT node present doesn't cause any side effects add it in case someone tries to load OP-TEE. Then I would expect you will enable it for all boards. It means patch zynqmp.dtsi instead of

Re: [ANN] U-Boot v2023.04-rc2 released

2023-02-16 Thread Michal Simek
rcs every other Monday, and with final release on April 3rd, 2023. Thanks all! can you please also resync defconfigs? Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Lin

Re: [PATCH 03/13] arm: zynq: Move to select'ing ARCH_EARLY_INIT_R if we have FPGA

2023-02-16 Thread Michal Simek
On 2/16/23 04:36, Tom Rini wrote: The function arch_early_init_r only does anything on these platforms if we have FPGA (or SPL and SPL_FPGA) enabled, so move the logic to select based on that. Cc: Michal Simek Signed-off-by: Tom Rini --- arch/arm/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH v1 1/1] fpga: zynqmppl: fix fpga loads command for unencrypted use case

2023-02-16 Thread Michal Simek
On 2/14/23 14:19, Neal Frager wrote: When using the fpga loads command, the driver is passing the AES encryption key address is all cases. However, for the authenticated, but not encrypted use case, there is no AES encryption key, and this value is 0. When AES encryption is not used on the f

[PATCH 2/2] xilinx: Enable SMC command for arm64 targets

2023-02-15 Thread Michal Simek
SMC command is very useful for TF-A testing or issuing commands which are not covered by any driver. Strongly recommend to disable this command on any product unless it is required. Signed-off-by: Michal Simek --- configs/xilinx_versal_net_virt_defconfig | 1 + configs

[PATCH 1/2] cmd: smccc: Print results in hex instead of dec

2023-02-15 Thread Michal Simek
Printing return value in HEX instead of DEC. Return values are 64 bit values which impossible to decode in DEC. For example getting CHIP ID in dec is quite long. Signed-off-by: Michal Simek --- cmd/smccc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/smccc.c b/cmd

Re: [PATCH v5 02/11] dm: Add support for handling old u-boot, dm- tags

2023-02-13 Thread Michal Simek
On 2/13/23 16:56, Simon Glass wrote: Add a CONFIG option to deal with this automatically, printing a warning when U-Boot starts up. This can be useful if the device tree comes from another project. We will maintain this through the 2023.07 release, providing 6 months for people to notice. Si

Re: [PATCH v4 10/11] dm: Add support for handling old u-boot, dm- tags

2023-02-12 Thread Michal Simek
! In connection to have tree working all the time for bisecting reasons I think the whole series should be a little bit rearranged and this shouldn't be the patch 10/11 but very early. But I will let Tom to decide if this should be rearranged or not. Acked-by: Michal Simek Thanks, Michal

Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema

2023-02-07 Thread Michal Simek
Hi Simon, On 2/7/23 14:38, Simon Glass wrote: Hi Michal, On Tue, 7 Feb 2023 at 06:14, Michal Simek wrote: Hi, On 2/6/23 18:12, Simon Glass wrote: +Peter Maydell Hi, On Mon, 6 Feb 2023 at 07:56, Michal Simek wrote: On 2/6/23 15:44, Tom Rini wrote: On Mon, Feb 06, 2023 at 01:22:48PM

Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema

2023-02-07 Thread Michal Simek
Hi, On 2/6/23 18:12, Simon Glass wrote: +Peter Maydell Hi, On Mon, 6 Feb 2023 at 07:56, Michal Simek wrote: On 2/6/23 15:44, Tom Rini wrote: On Mon, Feb 06, 2023 at 01:22:48PM +0100, Michal Simek wrote: Hi Simon, On 2/1/23 23:54, Simon Glass wrote: Update various build and test

Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema

2023-02-06 Thread Michal Simek
On 2/6/23 15:44, Tom Rini wrote: On Mon, Feb 06, 2023 at 01:22:48PM +0100, Michal Simek wrote: Hi Simon, On 2/1/23 23:54, Simon Glass wrote: Update various build and test components to use the new schema. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/ofnode.c

Re: [PATCH v3 6/8] dm: treewide: Complete migration to new driver model schema

2023-02-06 Thread Michal Simek
Hi Simon, On 2/1/23 23:54, Simon Glass wrote: Update various build and test components to use the new schema. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/ofnode.c| 10 +- drivers/video/video-uclass.c | 4 ++-- dts/Kconfig

Re: [PATCH] arm64: zynqmp: Add missing ZYNQMP_FIRMWARE dependencies

2023-02-03 Thread Michal Simek
On 2/1/23 10:55, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar There are missing Kconfig dependencies in the code which is using firmware interface. The commit 71efd45a5fc7 ("arm64: zynqmp: Change firmware dependency") add option to also disable ZYNQMP_FIRMWARE. But not all Kconfig d

Re: [PATCH v2] mtd: nand: Mark reserved blocks

2023-02-02 Thread Michal Simek
On 2/2/23 14:44, Michael Nazzareno Trimarchi wrote: Hi Il gio 2 feb 2023, 14:21 Michal Simek <mailto:mon...@monstr.eu>> ha scritto: Hi Dario, On 1/5/23 10:46, Ashok Reddy Soma wrote: > Reserved blocks are used for storing bad block tables. With "nand ba

Re: [PATCH v2] mtd: nand: Mark reserved blocks

2023-02-02 Thread Michal Simek
bbt reserved) 0x11680 0x116c0 0x1ff00 (bbt reserved) 0x1ff40 (bbt reserved) 0x1ff80 (bbt reserved) 0x1ffc0 (bbt reserved) Signed-off-by: Ashok Reddy Soma Reviewed-by: Michael Trimarchi --- Are you going to apply this patch? Thanks, Michal -

Re: [0/4] Add eMMC 5.1 support for Versal NET

2023-01-31 Thread Michal Simek
Hi Jaehoon, On 1/26/23 03:29, Jaehoon Chung wrote: Hi, -Original Message- From: Michal Simek Sent: Tuesday, January 24, 2023 10:02 PM To: Ashok Reddy Soma ; u-boot@lists.denx.de; Jaehoon Chung Cc: peng@nxp.com; kever.y...@rock-chips.com; hayashi.kunih...@socionext.com

[GIT PULL] xilinx patches for v2023.04-rc1

2023-01-27 Thread Michal Simek
e/configs/xilinx_versal_mini_qspi.h delete mode 100644 include/configs/xilinx_zynqmp_mini_emmc.h delete mode 100644 include/configs/xilinx_zynqmp_mini_qspi.h -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of

Re: [PATCH] fru: ops: Display FRU fields properly for 0xc1 fields

2023-01-27 Thread Michal Simek
On 1/25/23 13:06, Michal Simek wrote: From: Algapally Santosh Sagar FRU data is not displayed properly in case of 0xc1 fields. The 0xC1 can be used in two cases. 1. Char record type 8-bit ASCII + Latin 1 with length of 1. (For example board revision 'A') 2. C1h (type/length byte

Re: [PATCH v2 0/3] xilinx: board: Improve legacy format handling

2023-01-27 Thread Michal Simek
On 1/24/23 16:19, Michal Simek wrote: Hi, fix and improve legacy format handling to cover cases where eeprom content is corrupted and random. Very likely detection algorithm can be improved - for example check that mac address is valid, check all strings, etc. but the aim of this series is

Re: [PATCH v2 0/4] Fix sparse warnings

2023-01-27 Thread Michal Simek
On 1/20/23 06:36, Ashok Reddy Soma wrote: Run and fix sparse warnings in below files -drivers/mmc/zynq_sdhci.c -board/xilinx/common/board.h -drivers/gpio/zynqmp_gpio_modepin.c -board/xilinx/versal/board.c Changes in v2: - Included header file instead of declaring prototype - Modif

Re: [PATCH v2] net: zynq_gem: Wait for SGMII PCS link in zynq_gem_init()

2023-01-27 Thread Michal Simek
1 ms which fixes problems of dropped first packages. Signed-off-by: Stefan Roese Cc: Michal Simek Cc: Katakam Harini Cc: Ramon Fried Cc: Sean Anderson --- v2: - Move wait for PCS link into the code path only executed for SGMII w/o fixed-link - Reduce additional delay from 10 to 1ms - C

Re: [PATCH] arm64: versal-net: Enable remaking ELF from bin

2023-01-26 Thread Michal Simek
On 1/19/23 10:46, Michal Simek wrote: U-Boot is composing u-boot.bin from u-boot-nodtb.bin with appended dts/dt.dtb. It means U-Boot doesn't have DTB inside. When REMAKE_ELF is enabled make will also create u-boot.elf which is recreated from u-boot.bin. Below is build output for

Re: [PATCH v2 1/3] microblaze: spl: wrap spl_start_uboot() in SPL_OS_BOOT ifdefs

2023-01-26 Thread Michal Simek
On 1/25/23 17:41, Ovidiu Panait wrote: Make spl_start_uboot() available only if CONFIG_SPL_OS_BOOT is enabled, since it is only used for falcon mode. Signed-off-by: Ovidiu Panait --- Changes in v2: New patch. arch/microblaze/cpu/spl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletion

[PATCH] fru: ops: Display FRU fields properly for 0xc1 fields

2023-01-25 Thread Michal Simek
-bit value. (Unicode follows ISO/IEC 8859-1 in the layout of printable characters up to U+00FFh). So, print only printable chars and limit range from 0x20 ' ' to 0x7e '-' which will be also indication if 0xc1 behaves as record with one char or end of record. Signed-off-by: Algapa

[PATCH v2 3/3] xilinx: board: Update logic in xilinx_read_eeprom_legacy

2023-01-24 Thread Michal Simek
from eeprom content and then copy them to desc structure. Signed-off-by: Michal Simek --- Changes in v2: - Add +1 for strlcpy because only size -1 is used compare to strncpy. board/xilinx/common/board.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --

[PATCH v2 2/3] xilinx: board: Fix xilinx_eeprom_legacy_cleanup()

2023-01-24 Thread Michal Simek
When ethernet mac address contains 0x20 or 0xff MAC address is changed and bytes are converted to zeros. That's why fix decoding algorithm to ignore fields where MAC address is stored and all non printable chars (including space) are zeroed. Signed-off-by: Michal Simek --- (no changes sin

[PATCH v2 1/3] xilinx: board: Use ETH_ALEN macro for mac address size

2023-01-24 Thread Michal Simek
Use predefined macro for eth_mac legacy format. Signed-off-by: Michal Simek --- (no changes since v1) board/xilinx/common/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c index 823d703ea93c..6fc41e978669

[PATCH v2 0/3] xilinx: board: Improve legacy format handling

2023-01-24 Thread Michal Simek
mac address and never copy more bytes than expected. Thanks, Michal Changes in v2: - Add +1 for strlcpy because only size -1 is used compare to strncpy. Michal Simek (3): xilinx: board: Use ETH_ALEN macro for mac address size xilinx: board: Fix xilinx_eeprom_legacy_cleanup() xilinx: board

[PATCH 1/3] xilinx: board: Use ETH_ALEN macro for mac address size

2023-01-24 Thread Michal Simek
Use predefined macro for eth_mac legacy format. Signed-off-by: Michal Simek --- board/xilinx/common/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c index 823d703ea93c..6fc41e978669 100644 --- a/board/xilinx

[PATCH 3/3] xilinx: board: Update logic in xilinx_read_eeprom_legacy

2023-01-24 Thread Michal Simek
from eeprom content and then copy them to desc structure. Signed-off-by: Michal Simek --- board/xilinx/common/board.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c index 8bcb54d

[PATCH 0/3] xilinx: board: Improve legacy format handling

2023-01-24 Thread Michal Simek
mac address and never copy more bytes than expected. Thanks, Michal Michal Simek (3): xilinx: board: Use ETH_ALEN macro for mac address size xilinx: board: Fix xilinx_eeprom_legacy_cleanup() xilinx: board: Update logic in xilinx_read_eeprom_legacy board/xilinx/common/board.c | 34

[PATCH 2/3] xilinx: board: Fix xilinx_eeprom_legacy_cleanup()

2023-01-24 Thread Michal Simek
When ethernet mac address contains 0x20 or 0xff MAC address is changed and bytes are converted to zeros. That's why fix decoding algorithm to ignore fields where MAC address is stored and all non printable chars (including space) are zeroed. Signed-off-by: Michal Simek --- board/xilinx/c

<    5   6   7   8   9   10   11   12   13   14   >