Re: [U-Boot] [PATCH] mmc: add wrappers for MMC block_{read, write, erase}

2014-06-02 Thread Pantelis Antoniou
Hi Steve, I wanted the discussion to settle a bit before I reply to this series. On May 29, 2014, at 1:15 AM, Steve Rae wrote: Each wrapper function: - switches to the specified physical partition, then - performs the original function, and then - switches back to the original physical

Re: [U-Boot] [PATCH] mmc: return meaningful error codes from mmc_select_hwpart

2014-06-10 Thread Pantelis Antoniou
On Jun 10, 2014, at 7:00 PM, Stephen Warren wrote: On 06/02/2014 12:18 AM, Pantelis Antoniou wrote: On May 23, 2014, at 9:47 PM, Stephen Warren wrote: Rather than just returning -1 everywhere, try to return something meaningful from mmc_select_hwpart(). Note that most other MMC functions

Re: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-06-12 Thread Pantelis Antoniou
Hi Stephen, On May 23, 2014, at 9:59 PM, Stephen Warren wrote: On 05/20/2014 10:57 AM, Stephen Warren wrote: From: Bryan Wu coolo...@gmail.com mmc dev ${devnum} will return 0 as success even if there is no card inserted. Booting script like tegra-common-post.h will call mmc dev ${devnum}

Re: [U-Boot] [PATCH 1/2] cmd_mmc: default to HW partition 0 if not specified

2014-06-12 Thread Pantelis Antoniou
be any users that care about it. Thanks, applied. -- Pantelis Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] disk: default to HW partition 0 if not specified

2014-06-12 Thread Pantelis Antoniou
, applied. -- Pantelis Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] cmd_mmc: add force_init parameter to init_mmc_device()

2014-06-12 Thread Pantelis Antoniou
Looks fine. I have a slight preference for not using bools in C code, but I see it's already creeping in the codebase. I'll apply it as is, and if we have any complaints by people using really ancient compilers I'll convert to int. Thanks, applied. -- Pantelis Acked-by: Pantelis Antoniou pa

Re: [U-Boot] [PATCH 2/3] cmd_mmc: Use init_mmc_device() from do_mmc_rescan()

2014-06-12 Thread Pantelis Antoniou
. -- Pantelis Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/3] cmd_mmc: make mmc dev always re-probe the HW

2014-06-12 Thread Pantelis Antoniou
ahead and get it in. Thanks, applied. -- Pantelis Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: free allocated memory on initialization errors

2014-06-12 Thread Pantelis Antoniou
)) + if (init_kona_mmc_core(host)) { + free(host); return -EINVAL; + } if (quirks SDHCI_QUIRK_REG32_RW) host-version = sdhci_readl(host, SDHCI_HOST_VERSION - 2) 16; -- 1.7.9.5 Thanks, applied. -- Pantelis Acked-by: Pantelis Antoniou pa

[U-Boot] Pull request: u-boot-mmc 12/06/2014

2014-06-12 Thread Pantelis Antoniou
Hi Tom, The following changes since commit e153b13c8e300236e6d505bea629cc81fd0988cb: common/xyzModem.c: move empty statements to newline (2014-06-11 16:27:06 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to

Re: [U-Boot] Pull request: u-boot-mmc 12/06/2014

2014-06-12 Thread Pantelis Antoniou
Hi Igor, On Jun 12, 2014, at 4:10 PM, Igor Grinberg wrote: Hi Pantelis, On 06/12/14 15:41, Pantelis Antoniou wrote: Hi Tom, The following changes since commit e153b13c8e300236e6d505bea629cc81fd0988cb: common/xyzModem.c: move empty statements to newline (2014-06-11 16:27:06 -0400

Re: [U-Boot] [PATCH 2/3] env_mmc: support env partition setup in runtime

2014-06-12 Thread Pantelis Antoniou
Hi Dmitry, I took a good look at the patch and there's a problem. On Apr 27, 2014, at 1:18 PM, Dmitry Lifshitz wrote: Add callback with __weak annotation to allow setup of environment partition number in runtime from a board file. Signed-off-by: Dmitry Lifshitz lifsh...@compulab.co.il

Re: [U-Boot] [PATCH 3/3] cmd_mmc: make mmc dev always re-probe the HW

2014-06-12 Thread Pantelis Antoniou
Hi Stephen, On Jun 12, 2014, at 7:19 PM, Stephen Warren wrote: On 06/12/2014 05:31 AM, Pantelis Antoniou wrote: On May 23, 2014, at 10:24 PM, Stephen Warren wrote: Currently, U-Boot behaves as follows: - Begin with no SD card inserted in mmc 1 - Execute: mmc dev 1 - This fails, since

Re: [U-Boot] [RFC PATCH 0/3] Implement fastboot flash for eMMC

2014-06-25 Thread Pantelis Antoniou
Hi Rob, On Jun 25, 2014, at 4:59 PM, Rob Herring wrote: On Mon, Jun 23, 2014 at 1:37 PM, Steve Rae s...@broadcom.com wrote: Rob Sebastian I would appreciate your comments on this issue; I suspect that you had some ideas regarding the implementation of the fastboot flash and erase

Re: [U-Boot] [PATCH] mmc/dwmmc: remove recursive FIFO threshold setup

2013-11-26 Thread Pantelis Antoniou
Hi Alexey, On Nov 27, 2013, at 9:11 AM, Alexey Brodkin wrote: Hi Jaehoon, On Wed, 2013-11-27 at 14:33 +0900, Jaehoon Chung wrote: Hi, Alexey, I think good that use the initial fifoth value at register. Then we need not to change the value. But according to my experiment, some SoC needs

Re: [U-Boot] [PATCH] mmc/dwmmc: remove recursive FIFO threshold setup

2013-11-27 Thread Pantelis Antoniou
Hi Alexey, On Nov 27, 2013, at 9:45 AM, Alexey Brodkin wrote: Hi Pantelis, On Wed, 2013-11-27 at 09:21 +0200, Pantelis Antoniou wrote: Hi Alexey, On Nov 27, 2013, at 9:11 AM, Alexey Brodkin wrote: ATM if no host-fifoth_val value is provided the code will calculate one and write

Re: [U-Boot] [PATCH] mmc: dw_mmc: remove the exynos specific code in dw-mmc.c

2013-11-29 Thread Pantelis Antoniou
); unsigned int (*get_mmc_clk)(int dev_index); }; -- 1.7.9.5 Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Pantelis Antoniou
Hi Alexey, On Nov 29, 2013, at 12:08 PM, Alexey Brodkin wrote: On Fri, 2013-11-29 at 19:00 +0900, Jaehoon Chung wrote: remove this and use callback function like the host-board_init()? if (host-board_init()) host-board_init(host); Then we can reuse the this function for board

Re: [U-Boot] [PATCH v2] mmc/dwmmc: modify FIFO threshold only if value explicitly set

2013-12-06 Thread Pantelis Antoniou
Hi Alexey, Will do so over the weekend. Regards -- Pantelis On Dec 6, 2013, at 12:52 PM, Alexey Brodkin wrote: On Wed, 2013-11-27 at 22:07 +0900, Jaehoon Chung wrote: Acked-by: Jaehoon Chung jh80.ch...@samsung.com Any chance to get this patch applied? -Alexey

Re: [U-Boot] [PATCH 3/7] mmc: Enhance erase handling procedure

2013-12-08 Thread Pantelis Antoniou
Hi Haijun, On Nov 5, 2013, at 8:23 AM, Haijun Zhang wrote: Erass sequence: 1. check if erase command is support by card. If not return. 2. Check the erase range to see if it was aligned. The min erase size should be one erase group. SD card it was one block(512), mmc card it should be one

Re: [U-Boot] [PATCH 4/7] mmc: Update the handling of returned erase block

2013-12-08 Thread Pantelis Antoniou
Hi Haijun, On Nov 5, 2013, at 8:23 AM, Haijun Zhang wrote: If the block rang was not algined, We tried to algined the range, then erase the block. So the block range erased should be less or equal to the block range send. If error occured during erase procedure part of them will be erased.

Re: [U-Boot] [PATCH 5/7] mmc: Enhance mmcinfo command

2013-12-08 Thread Pantelis Antoniou
Hi Haijun, On Nov 5, 2013, at 8:23 AM, Haijun Zhang wrote: Once mmc initialization was faild has_init should be set to 0, prepard for the next initialization to recover from error. Once mmcinfo command failed error should point out instead of print incorrect mmc device information.

Re: [U-Boot] [PATCH 7/7] powerpc/esdhc: Update esdhc command execution process

2013-12-08 Thread Pantelis Antoniou
Hi Haijun, On Nov 5, 2013, at 8:23 AM, Haijun Zhang wrote: The max timeout value esdhc host can accept was about 2.69 sec At 50 Mhz SD_CLK period, the max busy timeout value = 2^27 * SD_CLK period ~= 2.69 sec. In case erase command CMD38 timeout is caculate by ^ calculated? mult * 300ms

Re: [U-Boot] [PATCH 1/3] esdhc: Workaround for card can't be detected on T4240QDS

2013-12-08 Thread Pantelis Antoniou
Hi Haijun, On Dec 2, 2013, at 7:25 AM, Haijun Zhang wrote: Card detection pin is ineffective on T4240QDS. This workaround force sdhc driver scan and initialize the card regardless of whether the card is inserted. if no card is in the slot, the error message card is not inserted will be

Re: [U-Boot] [PATCH 3/3] eSDHC: Calculate envaddr accroding to the address format

2013-12-08 Thread Pantelis Antoniou
Hi Haijun, On Dec 2, 2013, at 7:25 AM, Haijun Zhang wrote: On BSC9131 and BSC9132: For High Capacity SD Cards ( 2 GBytes), the 32-bit source address specifies the memory address in block address format. Block length is fixed to 512 bytes as per the SD High Capacity specification. So we need

Re: [U-Boot] [PATCH 2/3] esdhc: Detecting 8 bit width before mmc initialization

2013-12-08 Thread Pantelis Antoniou
Hi Haijun, On Dec 2, 2013, at 7:25 AM, Haijun Zhang wrote: The upper 4 data signals of esdhc are shared with spi flash. So detect if the upper 4 pins are assigned to esdhc before enable sdhc 8 bit width. Signed-off-by: Haijun Zhang haijun.zh...@freescale.com --- drivers/mmc/fsl_esdhc.c

Re: [U-Boot] [PATCH v2] mmc/dwmmc: modify FIFO threshold only if value explicitly set

2013-12-08 Thread Pantelis Antoniou
: Jaehoon Chung jh80.ch...@samsung.com Cc: Amar amarendra...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Simon Glass s...@chromium.org Cc: Pantelis Antoniou pa...@antoniou-consulting.com Cc: Andy Fleming aflem...@freescale.com --- drivers/mmc

Re: [U-Boot] [PATCH] include/mmc.h: Remove declaration for spl_mmc_load()

2013-12-08 Thread Pantelis Antoniou
Hi Lad, On Dec 3, 2013, at 8:47 AM, Lad, Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com The spl_mmc_load() was removed while converting to CONFIG_SPL_FRAMEWORK usage the definition was removed but the declaration was missed. This patch removes this declaration.

Re: [U-Boot] [PATCH][v3] powerpc: mmc: Add corenet devices support in esdhc spl

2013-12-08 Thread Pantelis Antoniou
-read_bl_len; err = mmc-block_dev.block_read(0, blk_start, blk_cnt, -- 1.7.4.1 Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com Thanks. -- Pantelis ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u

Re: [U-Boot] [PATCH] mmc: add Faraday FTSDC021 SDHCI controller support

2013-12-08 Thread Pantelis Antoniou
-2.0+ + */ + +#ifndef __FTSDC021_H +#define __FTSDC021_H + +int ftsdc021_sdhci_init(u32 regbase); + +#endif /* __FTSDC021_H */ -- 1.7.9.5 Acked-by; Pantelis Antoniou pa...@antoniou-consulting.com Thanks -- Pantelis ___ U-Boot mailing list U-Boot

[U-Boot] Pull request mmc tree

2013-12-09 Thread Pantelis Antoniou
Hi Tom, The following changes since commit f44483b57c49282299da0e5c10073b909cdad979: Merge branch 'serial' of git://git.denx.de/u-boot-microblaze (2013-12-02 08:48:02 -0500) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to

Re: [U-Boot] [PATCH 2/7 V3] mmc: Get secure erase information from card

2013-12-10 Thread Pantelis Antoniou
Hi Haijun, On Dec 10, 2013, at 7:39 AM, Haijun Zhang wrote: Read command class from csd register and secure erase support bit from ext csd register. Also calculate the erase timeout and secure erase timeout. If read ext csd error, error status should be returned instead of give some

Re: [U-Boot] [PATCH 3/7 V3] mmc: Enhance erase handling procedure

2013-12-10 Thread Pantelis Antoniou
Hi Haijun, On Dec 10, 2013, at 7:39 AM, Haijun Zhang wrote: This patch enhances the currently implemented erase procedure in u-boot, which has the following problems/missing features... ^ this is exactly what I responded earlier. What are the problems? What are the missing features?

Re: [U-Boot] [PATCH 4/7 V3] mmc: Update the handling of returned erase block

2013-12-10 Thread Pantelis Antoniou
Hi Haijun, On Dec 10, 2013, at 7:39 AM, Haijun Zhang wrote: If the block rang was not algined, We tried to algined the range, range, aligned, We try to align then erase the block. So the block range erased should be less or equal to the block range sent. If error occured during erase

Re: [U-Boot] [RFC] mmc: add setdsr support

2013-12-16 Thread Pantelis Antoniou
Hi Markus, On Dec 16, 2013, at 1:57 PM, Markus Niebel wrote: From: Markus Niebel markus.nie...@tqs.de The eMMC and the SD-Card specifications describe the optional SET_DSR command. During measurements at our lab we found that some cards implementing this feature having really strong

Re: [U-Boot] [PATCH V2] mmc: add setdsr support

2013-12-16 Thread Pantelis Antoniou
a call to mmc_set_dsr() in board_mmc_init() after calling fsl_esdhc_initialize() for the eMMC. Signed-off-by: Markus Niebel markus.nie...@tqs.de --- changes for V2: - extend documentation according to the comments from Pantelis Antoniou common/cmd_mmc.c | 23

Re: [U-Boot] [PATCH] mmc: add setdsr support

2013-12-16 Thread Pantelis Antoniou
() for the eMMC. Signed-off-by: Markus Niebel markus.nie...@tqs.de --- changes for V2: - extend documentation according to the comments from Pantelis Antoniou changes for V3: - correct formatting of if condition in mmc_startup as sugested by Pantelis Antoniou the stray new

Re: [U-Boot] [PATCH] include/mmc.h: Remove declaration for spl_mmc_load()

2014-01-08 Thread Pantelis Antoniou
, unsigned long rpmbsize); -- 1.7.9.5 Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mmc/dwmmc: Using calloc instead malloc

2014-01-08 Thread Pantelis Antoniou
Cc: Rajeshwari Shinde rajeshwar...@samsung.com Cc: Jaehoon Chung jh80.ch...@samsung.com Cc: Mischa Jonker mjon...@synopsys.com Cc: Alexey Brodkin abrod...@synopsys.com Cc: Andy Fleming aflem...@freescale.com Cc: Pantelis Antoniou pa...@antoniou-consulting.com --- Changes for v2 - Adding u

Re: [U-Boot] [PATCH] ARM: omap5_uevm: Enable 8-bit eMMC access

2014-01-08 Thread Pantelis Antoniou
+#define CONFIG_HSMMC2_8BIT /* Required support for the TCA642X GPIO we have on the uEVM */ #define CONFIG_TCA642X -- 1.7.9.5 Applied, thanks Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH v2] mmc/dwmmc: use bounce buffer for data exchange between CPU and MMC controller

2014-01-09 Thread Pantelis Antoniou
Cc: Amar amarendra...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Simon Glass s...@chromium.org Cc: Pantelis Antoniou pa...@antoniou-consulting.com Cc: Andy Fleming aflem...@gmail.com --- drivers/mmc/dw_mmc.c| 32

Re: [U-Boot] [PATCH] mmc: Minor cleanup of sdhci.c

2014-01-09 Thread Pantelis Antoniou
Hi Darwin (Rambo? - cool name) On Dec 30, 2013, at 12:25 AM, Darwin Rambo wrote: -Original Message- From: Jaehoon Chung [mailto:jh80.ch...@samsung.com] Sent: Wednesday, December 25, 2013 11:32 PM To: Darwin Rambo; u-boot@lists.denx.de Cc: Pantelis Antoniou Subject: Re: [U-Boot

Re: [U-Boot] [PATCH V2] mmc: add setdsr support

2014-01-09 Thread Pantelis Antoniou
() for the eMMC. Signed-off-by: Markus Niebel markus.nie...@tqs.de --- changes for V2: - extend documentation according to the comments from Pantelis Antoniou common/cmd_mmc.c | 23 +++ drivers/mmc/mmc.c | 18 ++ include/mmc.h |3 +++ 3 files

Re: [U-Boot] [PATCH v3] socfpga/dwmmc: Adding DesignWare MMC driver support for SOCFPGA

2014-01-09 Thread Pantelis Antoniou
Shinde rajeshwar...@samsung.com Cc: Jaehoon Chung jh80.ch...@samsung.com Cc: Pantelis Antoniou pa...@antoniou-consulting.com Cc: Wolfgang Denk w...@denx.de --- Changes for v3 - Used structure instead macro for the register access - Made drvsel and smpsel configurable - Used better macro

Re: [U-Boot] [PATCH 1/3 V2] esdhc: Workaround for card can't be detected on T4240QDS

2014-01-09 Thread Pantelis Antoniou
Hi Haijun, On Dec 11, 2013, at 7:35 AM, Haijun Zhang wrote: Card detection pin is ineffective on T4240QDS Rev1.0. There are two cards can be connected to board. 1. eMMC card is built-in board, can not be removed. so For eMMC card it is always there. 2. Card detecting pin is functional for

Re: [U-Boot] [PATCH 2/3 V2] esdhc: Detecting 8 bit width before mmc initialization

2014-01-09 Thread Pantelis Antoniou
Hi Haijun, On Dec 11, 2013, at 7:35 AM, Haijun Zhang wrote: The upper 4 data signals of esdhc are shared with spi flash. So detect if the upper 4 pins are assigned to esdhc before enable sdhc 8 bit width. Signed-off-by: Haijun Zhang haijun.zh...@freescale.com --- changs for V2: -

Re: [U-Boot] [PATCH 3/3 V2] eSDHC: Calculate envaddr accroding to the address format

2014-01-09 Thread Pantelis Antoniou
Hi Haijun, On Dec 11, 2013, at 7:35 AM, Haijun Zhang wrote: On BSC9131 and BSC9132: For High Capacity SD Cards ( 2 GBytes), the 32-bit source address specifies the memory address in block address format. Block length is fixed to 512 bytes as per the SD High Capacity specification. So we need

Re: [U-Boot] [PATCH 7/7 V5] powerpc/esdhc: Update esdhc command execution process

2014-01-09 Thread Pantelis Antoniou
Hi Haijun, Patch does not apply. On Dec 30, 2013, at 10:20 AM, Haijun Zhang wrote: The max timeout value esdhc host can accept is about 2.69 sec. At 50 Mhz SD_CLK period, the max busy timeout value = 2^27 * SD_CLK period ~= 2.69 sec. In case erase command CMD38 timeout is caculated by

Re: [U-Boot] [PATCH 2/7 V5] mmc: Get secure erase information from card

2014-01-09 Thread Pantelis Antoniou
Hi Haijun, Since this is part of the core mmc functionality, I'll need to run some test on some board that are affected. Pending verification and testing from now on. Regards -- Pantelis On Dec 30, 2013, at 10:20 AM, Haijun Zhang wrote: Read command class from csd register and secure erase

[U-Boot] Pull request mmc tree

2014-01-09 Thread Pantelis Antoniou
Hi Tom, The following changes since commit e7be18225fbea76d1f0034b224f0d1e60f07cfcf: Merge branch 'master' of git://git.denx.de/u-boot-mpc85xx (2014-01-06 14:07:08 -0500) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to

Re: [U-Boot] [PATCH 2/2] PPC: remove support for MPC82xx processors

2014-01-15 Thread Pantelis Antoniou
/me sniffs High five... On Jan 15, 2014, at 3:55 PM, Joakim Tjernlund wrote: You are asking a heretical question! ;-) 8xx is where it all started - U-Boot was anteceded by the PPCBoot project, which started as 8xxrom - some 15 years ago... Ripping this out of U-Boot would just break my

Re: [U-Boot] [PATCH] mmc: set correct block size value in bfin sdh driver

2014-10-02 Thread Pantelis Antoniou
Hi Sonic, On Aug 6, 2014, at 1:14 PM, Sonic Zhang sonic@gmail.com wrote: From: Sonic Zhang sonic.zh...@analog.com Wait data transfer till the data end bit other than the data block end bit is set. Signed-off-by: Sonic Zhang sonic.zh...@analog.com --- drivers/mmc/bfin_sdh.c | 7

Re: [U-Boot] [PATCH] mmc: fix ERASE_GRP_DEF handling

2014-10-02 Thread Pantelis Antoniou
Hi Hannes, On Aug 12, 2014, at 8:47 AM, Hannes Petermaier hannes.peterma...@br-automation.com wrote: Hi, Hannes. Hi Jaehoon, diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index a26f3ce..52a8e36 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1010,6 +1010,8 @@ static int

Re: [U-Boot] [PATCH 2/2] mmc: restore capacity when switching to partition 0

2014-10-02 Thread Pantelis Antoniou
-by: Tom Rini tr...@ti.com I’m going to take this in. It’s required to get the bone to boot from a standard MMC and I’d rather not introduce another boneblack variant to get it to boot from MMC. -- Tom Tested-by: Pantelis Antoniou pa...@antoniou-consulting.com Acked-by: Pantelis Antoniou pa

Re: [U-Boot] [PATCH v3] env_mmc: correct fini partition to match init partition

2014-10-02 Thread Pantelis Antoniou
; #endif - if (CONFIG_SYS_MMC_ENV_PART != mmc-part_num) + if (mmc_get_env_part(mmc) != mmc-part_num) mmc_switch_part(dev, mmc-part_num); #endif } -- 1.8.5.5 Applied, thanks. Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com

Re: [U-Boot] [PATCH v2] mvebu_mmc: Driver addition

2014-10-02 Thread Pantelis Antoniou
-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: Fix mmc bus width

2014-10-02 Thread Pantelis Antoniou
[EXT_CSD_HC_WP_GRP_SIZE] \ ext_csd[EXT_CSD_REV] \ == test_csd[EXT_CSD_REV] ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE] \ -- 1.8.4.5 Applied, thanks. Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com

Re: [U-Boot] [PATCH] cmd_mmc: fix bootpart-resize maxarg to 4

2014-10-03 Thread Pantelis Antoniou
-resize, 4, 0, do_mmc_boot_resize, , ), U_BOOT_CMD_MKENT(partconf, 5, 0, do_mmc_partconf, , ), U_BOOT_CMD_MKENT(rst-function, 3, 0, do_mmc_rst_func, , ), #endif -- 1.7.10.4 Thanks, applied. Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com

[U-Boot] Pull request: u-boot-mmc 03102014

2014-10-03 Thread Pantelis Antoniou
Hi Tom, The following changes since commit be9f643ae6aa9044c60fe80e3a2c10be8371c692: Merge branch 'for-tom' of git://git.denx.de/u-boot-dm (2014-09-26 20:10:48 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to

Re: [U-Boot] [PATCH v2] mmc: sdhci: Avoid commands errors by simple timeout adaptation.

2013-10-29 Thread Pantelis Antoniou
v2: - move global variable cmd_timeout into function sdhci_send_command() - change condition == to = when comparing time with timeout - print information about timeout increasing and card busy timeout Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Cc: Pantelis Antoniou pa

Re: [U-Boot] [PATCH v2] mmc: sdhci: Avoid commands errors by simple timeout adaptation.

2013-10-29 Thread Pantelis Antoniou
Dear Przemyslaw, On Oct 29, 2013, at 3:24 PM, Przemyslaw Marczak wrote: Dear Pantelis, On 10/29/2013 02:08 PM, Pantelis Antoniou wrote: Dear Przemyslaw, On Oct 29, 2013, at 3:02 PM, Przemyslaw Marczak wrote: Dear Pantelis, You don't reply for a long time. Could you look

Re: [U-Boot] [PATCH 2/2 V2] powerpc/esdhc: Add 3.3v voltage support in esdhc capacity register

2013-10-30 Thread Pantelis Antoniou
Hi Scott, Haijun, On Oct 30, 2013, at 8:58 PM, Scott Wood wrote: On Wed, 2013-10-30 at 11:36 +0800, Haijun Zhang wrote: T4240QDS eSDHC host capabilities reigster should have VS33 bit define. Add quirk CONFIG_SYS_FSL_MMC_HAS_CAPBLT_VS33 to deal with capacity missing Signed-off-by: Roy Zang

Re: [U-Boot] Patch about mmc and sdhci, Please look it, i can not pull the patch. I copy it here.

2013-10-30 Thread Pantelis Antoniou
Hi Richie, Please take a look at our patch submission guidelines. http://www.denx.de/wiki/U-Boot/Patches Some of the methods you use are questionable to say the least. Is your magic variable something to do with a quirk? I understand what you're trying to do, but you need to be more

Re: [U-Boot] [PATCH 1/2] mmc: Fix calculation of capacity for hc cards

2013-10-31 Thread Pantelis Antoniou
Hi Oliver, On Oct 1, 2013, at 9:32 PM, Oliver Metz wrote: When using a high capacity card with a density less than 2 GB a wrong size is calculated. According to JEDEC 4.41 there is no differentiation for C_SIZE register between low and high capacity cards. Use ext_csd sector count to

Re: [U-Boot] [PATCH 2/2] mmc: Fix erase_grp_size for partitioned card

2013-10-31 Thread Pantelis Antoniou
+211,7 @@ #define MMCPART_NOAVAILABLE (0xff) #define PART_ACCESS_MASK (0x7) #define PART_SUPPORT (0x1) +#define PART_ENH_ATTRIB (0x1f) /* Maximum block size for MMC */ #define MMC_MAX_BLOCK_LEN 512 -- 1.8.4 Applied, thanks. Acked-by: Pantelis Antoniou pa

Re: [U-Boot] [PATCH] mmc: dw_mmc: change the callback function name.

2013-10-31 Thread Pantelis Antoniou
(*get_mmc_clk)(int dev_index); }; struct dwmci_idmac { -- 1.7.9.5 Applied, thanks Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mmc: sdhci: Avoid commands errors by simple timeout adaptation.

2013-10-31 Thread Pantelis Antoniou
--; + time++; udelay(1000); } -- 1.7.9.5 Applied, thanks Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 10/10 V6] DWMMC: SMDK5420: Disable SMU for eMMC

2013-10-31 Thread Pantelis Antoniou
; void *ioaddr; -- 1.7.12.4 Applied, thanks Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2 V2] Powerpc/esdhc: Add simple description of esdhc register

2013-10-31 Thread Pantelis Antoniou
register */ + charreserved8[712]; /* reserved */ + uintscr;/* eSDHC control register */ }; /* Return the XFERTYP flags for a given command and data packet */ -- 1.8.4 Applied, thanks Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com

Re: [U-Boot] [PATCH 1/2 V3] esdhc: memset mmc struct before putting into use

2013-10-31 Thread Pantelis Antoniou
, FSL_SDHC); regs = (struct fsl_esdhc *)cfg-esdhc_base; -- 1.8.4 Applied, thanks. Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2 V3] powerpc/esdhc: Add 3.3v voltage support in esdhc capacity register

2013-10-31 Thread Pantelis Antoniou
CONFIG_SYS_FSL_MMC_HAS_CAPBLT_VS33 #endif #define CONFIG_BOOTDELAY 10 /* -1 disables auto-boot */ -- 1.8.4 Applied, thanks. Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http

[U-Boot] Pull request: u-boot-mmc 31102013

2013-10-31 Thread Pantelis Antoniou
Hi Tom, The following changes since commit 509dca7a11aad394d781a9d31a7bfa6692562741: Merge branch 'master' of git://git.denx.de/u-boot-video (2013-10-30 08:36:48 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to

Re: [U-Boot] [PATCH] fsl_esdhc: Add Auto command 12 interrupt bit detecting

2013-11-01 Thread Pantelis Antoniou
Hi Zhang, I'll take a look at it over the weekend. Regards -- Pantelis On Nov 1, 2013, at 9:44 AM, Zhang Haijun wrote: Hi, Antonious How about this patch? Could you give some advice? 于 2013/10/21 17:23, Zhang Haijun 写道: Hi, Babic Thanks. This patch is test on PPC.

Re: [U-Boot] [PATCH 1/2 V2] powerpc/esdhc: Map register for eSDHC Host Controller V3.0

2013-11-18 Thread Pantelis Antoniou
, I known this patch have been merged at u-boot-mmc repository. Best Regards, Jaehoon Chung On 11/18/2013 02:16 PM, Zhang Haijun wrote: Hi, all Who could help review this patch set? Thanks in advance. 于 2013/10/31 15:51, Pantelis Antoniou 写道: Hi Haijun, On Oct 30, 2013, at 5:37

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-12 Thread Pantelis Antoniou
Hi Lukasz, On Mar 12, 2014, at 10:06 AM, Lukasz Majewski wrote: Hi Tom, Pantelis Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, Looks fine to me. Let

[U-Boot] [PATCH 0/3] mmc: Cleanup time for mmc_struct

2014-03-12 Thread Pantelis Antoniou
the mmc device creation now gets much more easier by using the new mmc_create() call Pantelis Antoniou (3): mmc: Remove ops from struct mmc and put in mmc_ops mmc: Convert mmc struct's name array to a pointer mmc: Split mmc struct, rework mmc initialization arch/arm/include/asm/arch-davinci

[U-Boot] [PATCH 1/3] mmc: Remove ops from struct mmc and put in mmc_ops

2014-03-12 Thread Pantelis Antoniou
compilation b0rked issue on omap platforms where OMAP_GPIO was not set. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/mmc/arm_pl180_mmci.c | 12 +++--- drivers/mmc/bfin_sdh.c | 11 +++--- drivers/mmc/davinci_mmc.c| 13 --- drivers/mmc/dw_mmc.c

[U-Boot] [PATCH 2/3] mmc: Convert mmc struct's name array to a pointer

2014-03-12 Thread Pantelis Antoniou
Using an array is pointless; even more pointless (and scary) is using sprintf to fill it without a format string. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/mmc/arm_pl180_mmci.c | 2 +- drivers/mmc/bfin_sdh.c | 2 +- drivers/mmc/davinci_mmc.c| 2

Re: [U-Boot] [PATCH] dfu: mmc: Replace calls to u-boot commands with native mmc API

2014-03-12 Thread Pantelis Antoniou
On Mar 12, 2014, at 1:12 PM, Lukasz Majewski wrote: Hi Pantelis, Tom, Hi Lukasz, On Mar 12, 2014, at 10:06 AM, Lukasz Majewski wrote: Hi Tom, Pantelis Hi Lukasz, On Feb 27, 2014, at 11:21 AM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Feb 27, 2014, at 10:36 AM,

Re: [U-Boot] [PATCH v1 7/9] sunxi: mmc support

2014-03-14 Thread Pantelis Antoniou
Hi Ian, On Mar 14, 2014, at 12:33 PM, Ian Campbell wrote: Based linux-sunxi#sunxi commit d854c4de2f57 arm: Handle .gnu.hash section in ldscripts vs v2014.01. As well as the following signed-off-by the sunxi branch shows commits to these files authored by the following: Stefan Roese Tom

[U-Boot] Pull request: u-boot-mmc 24032014

2014-03-24 Thread Pantelis Antoniou
to eea4e6fe82fef9975e0153644935b89882890450: dfu: mmc: Replace calls to u-boot commands with native mmc API (2014-03-24 12:59:54 +0200) Pantelis Antoniou (3): mmc: Remove ops from struct mmc and put in mmc_ops mmc: Convert

Re: [U-Boot] [PATCH 1/2] mmc: sh_mmcif: Fix compile error

2014-03-31 Thread Pantelis Antoniou
: Pantelis Antoniou pa...@antoniou-consulting.com Reported-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mmc/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c index 64b5b47..ad5b23c 100644 --- a/drivers/mmc

Re: [U-Boot] [PATCH 2/2] mmc: sh_mmcif: Fix warning by unused variable

2014-03-31 Thread Pantelis Antoniou
Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/2] mmc: sh_mmcif: Fix compile error

2014-03-31 Thread Pantelis Antoniou
2014-03-31 15:45 GMT+09:00 Pantelis Antoniou pa...@antoniou-consulting.com: Hi Nobuhiro, Thank you for catching this. On Mar 31, 2014, at 8:54 AM, Nobuhiro Iwamatsu wrote: BY commit mmc: Split mmc struct, rework mmc initialization (v2), sh_mmcif has compile error. This fixes compile error

Re: [U-Boot] [PATCH 3/3] dfu: Introduction of the dfu_checksum_method env variable for checksum method setting

2014-03-31 Thread Pantelis Antoniou
Hi Lukasz, On Mar 31, 2014, at 11:48 AM, Lukasz Majewski wrote: Up till now the CRC32 of received data was calculated unconditionally. The standard crc32 implementation causes long delays when large images were uploaded. The dfu_checksum_method environment variable gives the opportunity to

Re: [U-Boot] [PATCH 3/3] dfu: Introduction of the dfu_checksum_method env variable for checksum method setting

2014-03-31 Thread Pantelis Antoniou
Hi Lukasz, On Mar 31, 2014, at 3:04 PM, Lukasz Majewski wrote: Hi Pantelis, Hi Lukasz, On Mar 31, 2014, at 11:48 AM, Lukasz Majewski wrote: Up till now the CRC32 of received data was calculated unconditionally. The standard crc32 implementation causes long delays when large images

Re: [U-Boot] [PATCH 3/3] dfu: Introduction of the dfu_checksum_method env variable for checksum method setting

2014-03-31 Thread Pantelis Antoniou
Hi Lukasz, Hmm, looking at the code the crc is updated when draining the buffer. That means that in essence you're working with cache-cold data. Can you try performing the crc32 right in the dfu_write() function just after the memcpy? Regards -- Pantelis On Mar 31, 2014, at 3:04 PM, Lukasz

Re: [U-Boot] [PATCH] mmc: Handle switch error status bit in MMC card status

2014-04-02 Thread Pantelis Antoniou
Hi Andrew, In general looks good; only a small nag. On Mar 24, 2014, at 9:39 AM, Andrew Gabbasov wrote: MMC switch command for unsupported feature (e.g. bus width) sets a switch error bit in card status. This bit should be checked, and, if it's set, no access with new controller settings

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: add controller reset in case of data related errors too

2014-04-02 Thread Pantelis Antoniou
)) + ; + } + } + esdhc_write32(regs-irqstat, -1); - return 0; + return err; } static void set_sysctl(struct mmc *mmc, uint clock) -- 1.7.10.4 Thanks Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: fix calculation of timeout for data transactions

2014-04-02 Thread Pantelis Antoniou
-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V2] mmc:eSDHC: Workaround for data timeout issue on Txxx SoC

2014-04-02 Thread Pantelis Antoniou
needed. -- 1.8.5 Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCHv2 00/10] mmc: code cleanup and support DDR mode

2014-04-02 Thread Pantelis Antoniou
Hi Jaehoon, On Apr 2, 2014, at 9:17 AM, Jaehoon Chung wrote: If card and host are supported DDR mode, then it can be used the DDR mode. This patch-set has dependency about beomho's patch-set. (Based-on u-boot-samsung repository) http://patchwork.ozlabs.org/patch/331986/

[U-Boot] Pull request: u-boot-mmc 02042014

2014-04-02 Thread Pantelis Antoniou
Hi Tom, The following changes since commit c494eaf409cb8db9a5a513e9bdfac20b7a83daca: Prepare v2014.04-rc3 (2014-03-31 15:24:48 -0400) are available in the git repository at: git://git.denx.de/u-boot-mmc.git master for you to fetch changes up to 1336e2d343f088b71ec71907855caccd1053d166:

Re: [U-Boot] Merge conflicts between ARM and mainline U-Boot trees

2014-04-08 Thread Pantelis Antoniou
, -- Albert. Acked-by: Pantelis Antoniou pa...@antoniou-consulting.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] dfu, nand: add medium specific polltimeout function

2014-04-10 Thread Pantelis Antoniou
the DFU_MANIFEST_POLL_TIMEOUT only on nand ubi partitions, which is currently the only usecase. Signed-off-by: Heiko Schocher h...@denx.de Cc: Lukasz Majewski l.majew...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Marek Vasut ma...@denx.de Cc: Pantelis Antoniou pa...@antoniou

Re: [U-Boot] MMC: proposal to support multiple physical partitions

2014-04-29 Thread Pantelis Antoniou
Hi Steve, On Apr 24, 2014, at 8:50 PM, Steve Rae wrote: In addition to using the MMC user area (the device's physical partition), I am also using the first MMC boot partition and the second MMC boot partition... As a result, I am currently using the following code snippet in a number of

Re: [U-Boot] [PATCH] mmc: postponed needless timer initialization

2014-04-29 Thread Pantelis Antoniou
Hi Mateusz, Looks good. I'll apply it. On Apr 29, 2014, at 8:16 PM, Mateusz Zalega wrote: mmc_init() doesn't call get_timer() anymore if MMC is already initialized. Change-Id: Iec694abe3315d146d35dc130ad80b73dffd0983b Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Pantelis

Re: [U-Boot] [PATCH v5 01/12] mmc: mmc header fix

2014-04-30 Thread Pantelis Antoniou
files. Signed-off-by: Mateusz Zalega m.zal...@samsung.com Cc: Minkyu Kang mk7.k...@samsung.com Cc: Pantelis Antoniou pa...@antoniou-consulting.com --- Changes since v1: - none --- include/mmc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/mmc.h b/include/mmc.h index 42d0125

[U-Boot] [PATCH 6/9] Properly zero out timeout value

2012-11-27 Thread Pantelis Antoniou
Zero out timeout value; letting it filled with undefined values ends up with the dfu host hanging. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/usb/gadget/f_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget

[U-Boot] [PATCH 3/9] Only perform DFU board_usb_init() for TRATS

2012-11-27 Thread Pantelis Antoniou
USB initialization shouldn't happen for all the boards. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- common/cmd_dfu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c index 01d6b3a..327c738 100644 --- a/common/cmd_dfu.c +++ b/common

<    1   2   3   4   5   >