Re: [PATCH v4 1/1] cmd: gpt: add eMMC and GPT support

2020-11-04 Thread Thirupathaiah Annapureddy
On 7/23/2020 5:00 AM, Rayagonda Kokatanur wrote: > From: Corneliu Doban > > Add eMMC and GPT support. > - GPT partition list and command to create the GPT added to u-boot > environment > - eMMC boot commands added to u-boot environment > - new gpt commands (enumarate and setenv) that are

Re: [PATCH] net: ftgmac100: Add support for board specific PHY interface address

2020-09-28 Thread Thirupathaiah Annapureddy
Hi Tom/Joe, Is this going to be applied to u-boot/next or u-boot-net? Best Regards, Thiru On 8/17/2020 5:08 PM, Thirupathaiah Annapureddy wrote: > ftgmac100 driver is using hard-coded PHY interface address of zero. > Each board can have different PHY interface address (phy_addr). > Th

Re: [RFC PATCH 1/1] image: add anti rollback protection for FIT Images

2020-09-15 Thread Thirupathaiah Annapureddy
Hi Tom, Please see my comment(s) in-line. On 9/15/2020 6:40 AM, Tom Rini wrote: > On Mon, Sep 14, 2020 at 11:18:25PM -0700, Thirupathaiah Annapureddy wrote: >> Hi Simon, >> >> Thanks for the review. >> >> On 9/6/2020 6:43 PM, Simon Glass wrote: >>>> &

Re: [RFC PATCH 0/1] Anti rollback protection for FIT Images

2020-09-15 Thread Thirupathaiah Annapureddy
On 9/7/2020 11:15 PM, Rasmus Villemoes wrote: > On 02/09/2020 09.58, Rasmus Villemoes wrote: >> On 01/09/2020 22.48, Thirupathaiah Annapureddy wrote: >>> Anti rollback protection is required when there is a need to retire >>> previous versions of FIT images du

Re: [RFC PATCH 1/1] image: add anti rollback protection for FIT Images

2020-09-15 Thread Thirupathaiah Annapureddy
Hi Simon, Thanks for the review. On 9/6/2020 6:43 PM, Simon Glass wrote: >> >> diff --git a/Kconfig b/Kconfig >> index 883e3f71d0..3959a6592c 100644 >> --- a/Kconfig >> +++ b/Kconfig >> @@ -533,6 +533,15 @@ config FIT_CIPHER >> Enable the feature of data ciphering/unciphering in the

Re: [RFC PATCH 0/1] Anti rollback protection for FIT Images

2020-09-14 Thread Thirupathaiah Annapureddy
Hi Rasmus, Thanks for the review. Please see in-line: On 9/2/2020 12:58 AM, Rasmus Villemoes wrote: > On 01/09/2020 22.48, Thirupathaiah Annapureddy wrote: >> Anti rollback protection is required when there is a need to retire >> previous versions of FIT images due to securit

[RFC PATCH 0/1] Anti rollback protection for FIT Images

2020-09-01 Thread Thirupathaiah Annapureddy
kernel-1 image has an arbvn of 1. if plat_arbvn is 1, the system will boot with this FIT image. if plat_arbvn is 2 or more, U-Boot will prevent the system from booting with this FIT image. Thirupathaiah Annapureddy (1): image: add anti rollback protection for FIT Images Kconfig|

[RFC PATCH 1/1] image: add anti rollback protection for FIT Images

2020-09-01 Thread Thirupathaiah Annapureddy
. Signed-off-by: Thirupathaiah Annapureddy --- Kconfig| 9 + common/image-fit-sig.c | 79 ++ common/image-fit.c | 24 + include/image.h| 23 4 files changed, 135 insertions(+) diff --git a/Kconfig b

[PATCH v2] arm: dts: fix ast2500-evb inclusion for the correct soc family

2020-09-01 Thread Thirupathaiah Annapureddy
is using a different ARM CPU(s) with different ARM architecture revision. It is not possible to support all 3 of these families in a single binary. So there is no need to build ast2500-evb.dtb for other SOC families. Signed-off-by: Thirupathaiah Annapureddy --- Changes in v2: - Incorporated

Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target

2020-08-22 Thread Thirupathaiah Annapureddy
On 8/20/2020 5:03 PM, Tom Rini wrote: > On Thu, Aug 20, 2020 at 02:09:55PM -0700, Thirupathaiah Annapureddy wrote: >> Hi Ryan, >> >> Thanks for reviewing the patch. Please see my comment(s): >> >> On 8/19/2020 7:06 PM, Ryan Chen wrote: >>> Hi

Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target

2020-08-20 Thread Thirupathaiah Annapureddy
Hi Ryan, Thanks for reviewing the patch. Please see my comment(s): On 8/19/2020 7:06 PM, Ryan Chen wrote: > Hi >> -Original Message- >> From: Thirupathaiah Annapureddy [mailto:thir...@linux.microsoft.com] >> Sent: Thursday, August 20, 2020 8:16 AM >> To: u-boot

Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target

2020-08-19 Thread Thirupathaiah Annapureddy
Adding Ryan and Chiawei to the list. On 8/17/2020 5:53 PM, Thirupathaiah Annapureddy wrote: > Include ast2500-evb.dtb for CONFIG_TARGET_EVB_AST2500 instead of > for all aspeed targets. > > Signed-off-by: Thirupathaiah Annapureddy --- > arch/arm/dts/Makefile | 2 +- >

[PATCH] arm: dts: fix ast2500-evb inclusion for correct target

2020-08-17 Thread Thirupathaiah Annapureddy
Include ast2500-evb.dtb for CONFIG_TARGET_EVB_AST2500 instead of for all aspeed targets. Signed-off-by: Thirupathaiah Annapureddy --- arch/arm/dts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 7e29b9096b

[PATCH] include: phy: fix NULL pointer check in phy_write()

2020-08-17 Thread Thirupathaiah Annapureddy
phy_write() uses bus->write() instead of bus->read(). This means NULL pointer pre-check needs to happen on bus->write instead of bus->read. Signed-off-by: Thirupathaiah Annapureddy --- include/phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/phy

[PATCH] net: ftgmac100: Add support for board specific PHY interface address

2020-08-17 Thread Thirupathaiah Annapureddy
ftgmac100 driver is using hard-coded PHY interface address of zero. Each board can have different PHY interface address (phy_addr). This commit modifies the driver to make use of board specific address by leveraging CONFIG_PHY_ADDR. Signed-off-by: Thirupathaiah Annapureddy --- drivers/net

[PATCH v3 1/3] vboot: add DTB policy for supporting multiple required conf keys

2020-08-17 Thread Thirupathaiah Annapureddy
Signed-off-by: Thirupathaiah Annapureddy Reviewed-by: Simon Glass --- Changes in v3: - Replaced 'u-boot' with 'U-Boot' in commit message. - Added an explicit print message to indicate that no required signature was verified. Changes in v2: - Modify fit_config_verify_required_sigs() to process required-m

[PATCH v3 2/3] test: vboot: add tests for multiple required keys

2020-08-17 Thread Thirupathaiah Annapureddy
(). sign_fit_norequire() was removed as part of the following: commit b008677daf2a ("test: vboot: Fix pylint errors"). This patch leverages sign_fit_norequire() to fix the existing bug. Signed-off-by: Thirupathaiah Annapureddy Reviewed-by: Simon Glass --- Changes in v3: - Modified comm

[PATCH v3 3/3] doc: verified-boot: add required-mode information

2020-08-17 Thread Thirupathaiah Annapureddy
Add documentation about 'required-mode' property in /signature node in U-Boot's control FDT. Signed-off-by: Thirupathaiah Annapureddy Reviewed-by: Simon Glass --- Changes in v3: - Added commit description to address checkpatch warning. Changes in v2: - New. doc/uImage.FIT/signature.txt | 14

[PATCH v3 0/3] Add support for multiple required keys

2020-08-17 Thread Thirupathaiah Annapureddy
and Rasmus): - Introduce a policy variable in U-boot DTB to control whether any or all required keys must have signed configuration. - Added tests to cover any or all required keys policy. - Updated signature.txt to include required-mode policy information. Thirupathaiah Annapureddy (3): vboot

Re: [PATCH v2 3/3] doc: verified-boot: add required-mode information

2020-08-16 Thread Thirupathaiah Annapureddy
On 7/28/2020 11:58 AM, Simon Glass wrote: > Hi Thirupathaiah, > > On Fri, 17 Jul 2020 at 21:20, Thirupathaiah Annapureddy > wrote: >> >> Signed-off-by: Thirupathaiah Annapureddy >> --- >> >> Changes in v2: >> - New >> >> doc/uIm

[PATCH v2 2/3] test: vboot: add tests for multiple required keys

2020-07-17 Thread Thirupathaiah Annapureddy
(). sign_fit_norequire() was removed as part of the commit: b008677daf2a9dc0335260c7c4e24390487fe0ca (test: vboot: Fix pylint errors) This patch leverages sign_fit_norequire() to fix the existing bug. Signed-off-by: Thirupathaiah Annapureddy --- Changes in v2: - Added tests to cover any or all required

[PATCH v2 3/3] doc: verified-boot: add required-mode information

2020-07-17 Thread Thirupathaiah Annapureddy
Signed-off-by: Thirupathaiah Annapureddy --- Changes in v2: - New doc/uImage.FIT/signature.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/uImage.FIT/signature.txt b/doc/uImage.FIT/signature.txt index d4afd755e9..a3455889ed 100644 --- a/doc/uImage.FIT/signature.txt

[PATCH v2 0/3] Add support for multiple required keys

2020-07-17 Thread Thirupathaiah Annapureddy
any or all required keys policy. - Updated signature.txt to include required-mode policy information. Thirupathaiah Annapureddy (3): vboot: add DTB policy for supporting multiple required conf keys test: vboot: add tests for multiple required keys doc: verified-boot: add required-mode

[PATCH v2 1/3] vboot: add DTB policy for supporting multiple required conf keys

2020-07-17 Thread Thirupathaiah Annapureddy
Signed-off-by: Thirupathaiah Annapureddy --- Changes in v2: - Modify fit_config_verify_required_sigs() to process required-mode policy variable in U-boot DTB. common/image-fit-sig.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/common/image-fit-sig.

Re: [PATCH 1/2] vboot: add support for multiple required keys

2020-07-08 Thread Thirupathaiah Annapureddy
gt;> >> On Thu, 25 Jun 2020 at 09:51, Thirupathaiah Annapureddy >> wrote: >>> >>> Currently Verified Boot fails if there is a signature verification failure >>> using required key in U-boot DTB. This patch adds support for multiple >>> required keys

[PATCH 0/2] Add support for multiple required keys

2020-06-25 Thread Thirupathaiah Annapureddy
This patch series adds the support for multiple required keys in U-Boot DTB with test support. Thirupathaiah Annapureddy (2): vboot: add support for multiple required keys test: vboot: add a test for multiple required keys common/image-fit-sig.c | 12 +++- test/py/tests

[PATCH 1/2] vboot: add support for multiple required keys

2020-06-25 Thread Thirupathaiah Annapureddy
to resolve this with the following patch: https://lists.denx.de/pipermail/u-boot/2019-April/366047.html The above patch was failing "make tests". Signed-off-by: Thirupathaiah Annapureddy --- common/image-fit-sig.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --gi

[PATCH 2/2] test: vboot: add a test for multiple required keys

2020-06-25 Thread Thirupathaiah Annapureddy
: commit b008677daf2a ("test: vboot: Fix pylint errors"). This patch leverages sign_fit_norequire() to fix the existing bug. Signed-off-by: Thirupathaiah Annapureddy --- test/py/tests/test_vboot.py | 33 +++-- 1 file changed, 31 insertions(+), 2 deletion

Re: [PATCH v3 1/1] cmd: bootefi: Parse reserved-memory node from DT

2020-03-23 Thread Thirupathaiah Annapureddy
On 3/17/2020 4:10 AM, Heinrich Schuchardt wrote: > On 3/17/20 9:06 AM, Patrick DELAUNAY wrote: >> Hi, >> >>> From: U-Boot On Behalf Of Heinrich Schuchardt >>> Sent: dimanche 15 mars 2020 13:03 >>> > > It makes sense to keep these coding stretches in sync. > > @Thirupathaiah > * I did not

[PATCH] menu: add support for client defined statusline function

2020-03-18 Thread Thirupathaiah Annapureddy
. Signed-off-by: Thirupathaiah Annapureddy --- cmd/bootmenu.c | 61 + cmd/pxe_utils.c | 2 +- common/menu.c | 13 +++ include/menu.h | 2 +- 4 files changed, 41 insertions(+), 37 deletions(-) diff --git a/cmd/bootmenu.c b/cmd/bootmenu.c

[PATCH] Revert "dm: fdt: scan for devices under /firmware too"

2020-02-17 Thread Thirupathaiah Annapureddy
Subnodes under "/firmware" node are scanned twice in dm_scan_fdt_node() and dm_extended_scan_fdt(). This patch removes the scanning in dm_scan_fdt_node() to avoid double scanning. This reverts commit 747558d014577526bf2e8d9fe9ca748fdbf75d8a. Signed-off-by: Thirupathaiah Annapureddy --

Re: [PATCH] image: fdt: check "status" of "/reserved-memory" subnodes

2020-02-04 Thread Thirupathaiah Annapureddy
Thank You Simon for the review. May I know what are the next steps in making forward progress on this? Best Regards, Thiru On 1/7/2020 12:33 AM, Simon Goldschmidt wrote: > On Tue, Jan 7, 2020 at 7:21 AM Thirupathaiah Annapureddy > wrote: >> >> boot_fdt_add_mem_r

Re: [PATCH] tpm2: ftpm: A driver for firmware TPM running inside TEE

2020-02-04 Thread Thirupathaiah Annapureddy
Hi All, May I know what are the next steps in making forward progress on this? Best Regards, Thiru On 1/12/2020 11:34 PM, Thirupathaiah Annapureddy wrote: > Add a driver for a firmware TPM running inside TEE. > > Documentation of the firmware TPM: > https://www.microsoft.com/en

[PATCH] tpm2: ftpm: A driver for firmware TPM running inside TEE

2020-01-12 Thread Thirupathaiah Annapureddy
Signed-off-by: Thirupathaiah Annapureddy --- drivers/tpm/Kconfig | 6 + drivers/tpm/Makefile| 1 + drivers/tpm/tpm2_ftpm_tee.c | 250 drivers/tpm/tpm2_ftpm_tee.h | 35 + 4 files changed, 292 insertions(+) create mode 100644 drivers

Re: [PATCH] Revert "dm: core: Scan "/firmware" node by default"

2020-01-08 Thread Thirupathaiah Annapureddy
On 1/8/2020 9:39 AM, Simon Glass wrote: > Hi T, > > On Tue, 7 Jan 2020 at 20:24, Thirupathaiah Annapureddy > wrote: >> >> Subnodes under "/firmware" node are scanned twice in dm_scan_fdt_node >> and dm_extended_scan_fdt. This patch removes the do

[PATCH] Revert "dm: core: Scan "/firmware" node by default"

2020-01-07 Thread Thirupathaiah Annapureddy
Subnodes under "/firmware" node are scanned twice in dm_scan_fdt_node and dm_extended_scan_fdt. This patch removes the double scanning. This reverts commit 1712ca21924bff678f19fd3141f435408d23bdbf. Signed-off-by: Thirupathaiah Annapureddy --- drivers/core/root.c | 8 +--- 1 file

[PATCH] image: fdt: check "status" of "/reserved-memory" subnodes

2020-01-07 Thread Thirupathaiah Annapureddy
t;status" property before adding it to reserved lmb regions. Signed-off-by: Thirupathaiah Annapureddy --- common/image-fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/image-fdt.c b/common/image-fdt.c index 48388488d9..cf13d655c0 100644 --- a/common/image-