Re: [IMPORTANT] gitlab relocation / rename

2021-02-28 Thread Wolfgang Denk
should experience any problems, please do not hesitate to ask Harald Seiler , he will try to help you. Thanks for your patience! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzel

Re: [PATCH] hush: Fix assignments being misinterpreted as commands

2021-03-03 Thread Wolfgang Denk
dy been wasted over the years for such little fixes here and there wew could have upgraded long ago. Grooming a dead horse makes little sense to me. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-8

Re: [IMPORTANT] gitlab relocation / rename

2021-03-09 Thread Wolfgang Denk
g environment has proven to work fine for a FOSS community project. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email

Re: Cover Letter of Patchsets

2020-07-06 Thread Wolfgang Denk
atch series. Also it should commet on the changes between versions of the patch series, if these are needed (especially when major rework is done between submissions). But it is only supplementary information which gets lost when the patches are pulled into the git repository. Best regards,

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-13 Thread Wolfgang Denk
stems where the size of a bank of memory is not a power of two. So I feel what you are doing here is not an improvement, but a "workaround" for some incorrect usage. I don't think we should accept this patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing

Re: Using gerrit or github for review?

2020-07-13 Thread Wolfgang Denk
ot repositories are hosted on a gitlab server, would it not be much more natural to look for gitlab features to use? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone

Re: Using gerrit or github for review?

2020-07-13 Thread Wolfgang Denk
uld 1) check out the branch and try it, 2) > have test automation attached, 3) use a UI for review. As for automation, you know that Heiko has been using tbot for years for automatic patch series download from patchwork, checking and testing (checkpatch, build, install, boot)? Best regards,

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-14 Thread Wolfgang Denk
we should update the > codes with the above power of two assumptions documented. That would indeed make sense. On the other hand, I would have expected that this behaviour is kind of obvious from the fact, that we just bit shift the address location used for testing? Best regards, Wolf

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-14 Thread Wolfgang Denk
0xBFFC 0xBFFE 0xBFFF What do you intend with such a sequence? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49

Re: [PATCH] memsize: Make get_ram_size() work with arbitary RAM size

2020-07-20 Thread Wolfgang Denk
address lanes), and this really fast so it can be kept in the production version. You drop all this very practical functionality for a feature which is of hypothetical use at best? > The algorithm runs in O(log(UINT_MAX)) which is the same time complexity > as for the current algorithm.

[ADMIN] Change of Mailing List configuration

2020-02-12 Thread Wolfgang Denk
e (which is no surprise, as most of our postings have a number of mailing list members on Cc:) Hope this helps. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone:

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2020-02-13 Thread Wolfgang Denk
ch can easily be implemented with existing scripting capabilites. And so far I don't see the limitation you are running into. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germa

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2020-02-16 Thread Wolfgang Denk
left": slot=none for i in $BOOT_ORDER ; do setenv tmp_cmd 'setexpr tmp_val sub '^' "" $'BOOT_${i}_LEFT run tmp_cmd test $slot = none && test $tmp_val -gt 0 && slot=$i && left=$tmp_val done

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2020-02-16 Thread Wolfgang Denk
patch, too. It can be implemented by simple scripting, so there is no need to add code that has to be maintained by all but is used by a very small minoryty, if at all. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office:

Re: [U-Boot] [RFC] cmd: add bootslot command to select/boot slot based on boot counts

2020-02-16 Thread Wolfgang Denk
d a lot of code that can be implemented as a few lines of shell scripts as well, especially as this code is neither time critical nor has the potential of becoming widely used. NAKed-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolf

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2020-02-16 Thread Wolfgang Denk
ER ; do setenv tmp_cmd 'setenv tmp_val $'BOOT_${i}_LEFT run tmp_cmd test $slot = none && test $tmp_val -gt 0 && slot=$i && left=$tmp_val done echo "## Chosen Slot = $slot ; Left = $left" Best regards, Wolfgang Denk --

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Wolfgang Denk
d time consuming tasks? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de All he had was nothing, but that w

Re: use invd instead of wbinvd in real mode start code

2020-02-17 Thread Wolfgang Denk
Dear Andy, In message you wrote: > On Mon, Feb 17, 2020 at 5:09 PM Wolfgang Denk wrote: > > In message > > you > > wrote: > > > > > > > > git bisect is the usual way to figure out the culprit. > > > > > > > > Too much wo

Re: [PATCH] ARM: socfpga: Add initial support for the ABB SECU board

2020-02-17 Thread Wolfgang Denk
ould it make sense to rename keymile -> abb (or abb-ch) here (ditto for KM in the config options / macro names) ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+

Re: use invd instead of wbinvd in real mode start code

2020-02-19 Thread Wolfgang Denk
such testcases? I think this should even be covered in the tbot docs? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80

Re: [PATCH 0/5] CMD_SAVEENV ifdef cleanup

2020-02-19 Thread Wolfgang Denk
SPI NOR flash, NAND flash, UBI, UNIFS, etc. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In a busi

Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-19 Thread Wolfgang Denk
works? How do the sizes of the images differe before and after applying your changes? [Same question for ext4] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49

Re: [PATCH] rename keymile boards to ABB wcom

2020-02-19 Thread Wolfgang Denk
name? I cannot find any company name that relates even remotely to yours? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80

Re: [PATCH 3/5] env/fat.c: remove private CMD_SAVEENV logic

2020-02-21 Thread Wolfgang Denk
AVEENV also works as expected. OK. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de When you die

Re: [cmd] "env import" command behaviour observation

2020-02-28 Thread Wolfgang Denk
- > Is this expected?? or should it be raised as a BUG. Yes, this is expected behaviour. These variables are read-only (resp.write-once), so you cannot modify them if they are already set. [At least not without additional measures.] Best regards, Wolfgang Denk --

Re: [cmd]:"env edit" vs "env set", do we need both options for "env" command ??

2020-02-28 Thread Wolfgang Denk
e mention of the environment > variable value in the same line. "env edit" is an _interactive_ command. You cannot use it in scripts, for example. > Can we have only one of these commands ??. No, they serve very different purposes. Best regards, Wolfgang Denk -- DENX Software

Re: [cmd] Notation for "mandatory" and "optional" parameters in "help shell_cmd" output

2020-03-01 Thread Wolfgang Denk
separate choices, and ellipses (...) can be repeated. Only we don't have bold or italic fonts, so bold is often omitted and in some cases we may write . But note that these texts have been written buy a large number of developers, so don't expect strict consistency. But as usual: pat

Re: [PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

2020-03-11 Thread Wolfgang Denk
Dear Andy, dear Igor, In message you wrote: > > > Unfortunately current state of tooling in U-Boot is not too good to be able > > to read thoughts of people and guess their wishes. > > See above. *Algo is simple*. Come on, guys, in theory none of the Cc:s should be needed at all as you get ever

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-10-30 Thread Wolfgang Denk
dynamically loadable modules - well, then a close look is needed because such an approach has to be generic enough (end probably borrow much from Linux). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5,

[U-Boot] Drop "" Subject tag and footer?

2019-10-30 Thread Wolfgang Denk
senders [8]: https://tools.ietf.org/html/rfc7489 ___ All comments welcome. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groeben

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-10-31 Thread Wolfgang Denk
> I don't know if this could work with the general API or not. One reason we > did What exactly do you need this for? Why don't you just link your code with the rest of U-Boot? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang D

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-10-31 Thread Wolfgang Denk
etc.) > > It will still be a large SoC, though. Have you already looked at formal requirements, like coding style etc.? Did you ever run your additions through checkpatch.pl, for example? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk H

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-11-04 Thread Wolfgang Denk
the rest of U-Boot? It has been mentioned before, but just to be sure: this code which uses your new API is licensed under a GPLv2 conforming lincense? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D

Re: [U-Boot] [PATCH v5 00/19] efi_loader: non-volatile variables support

2019-11-04 Thread Wolfgang Denk
sked for the size impact, especially for non-UEFI systems. Please keep in mind that there are many cases where we need access to the environment already in SPL, and on all systems where security plays any role we must have the same set of features enabled for the environment code in SPL and TPL (if th

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-11-05 Thread Wolfgang Denk
oes not have to be linked. You access internal interfaces of U-Boot that have not been exported for non-GPL use, so your code still has to be licensed under GPLv2 or a compatible license. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HR

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-11-05 Thread Wolfgang Denk
e too much of operating system functionality into a mere boot loader? Using tools for purposes they have not been designed for has never been a good idea... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-11-05 Thread Wolfgang Denk
from internal interfaces of U-Boot which are not exported for non-GPL use. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-8

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-11-06 Thread Wolfgang Denk
can only interpret from that that there is a call table, where your applications call into interfaces that have not been exported for non-GPL use. This is not what I call "completely separate". Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wol

[U-Boot] [PATCH] [Cosmetic] Fix CRLF mess in shell script

2019-11-08 Thread Wolfgang Denk
tools/img2brec.sh includes a number of inappropriate CR charaters, which apparently mess up git's text file recognition. Drop all CRs. Signed-off-by: Wolfgang Denk --- tools/img2brec.sh | 570 +++--- 1 file changed, 285 insertions(+), 285 dele

Re: [U-Boot] [PATCH] gitattributes: dont treat non-text files as text

2019-11-08 Thread Wolfgang Denk
ext executable, with CRLF, CR, LF line terminators If git misunderstands this, then probably because of the CR / CRLF / LF mess in this file. This should be fixed, then you can omit this incorrectline. Patch just sent. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

[U-Boot] White space cleanup

2019-11-08 Thread Wolfgang Denk
, trailing blank lines which I would like to clean up. However, this affects more than 500 files, so it might cause a large number of mege conflicts with other changes. When would be a good point of time in the release cycle to submit such a patch series? Best regards, Wolfgang Denk -- DENX

Re: [U-Boot] White space cleanup

2019-11-08 Thread Wolfgang Denk
re. But you did not answer my key question: When would be a good point of time in the release cycle to submit such a patch series? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Ger

Re: [PATCH 06/16] arm: stm32mp: spl: display error in board_init_f

2020-04-23 Thread Wolfgang Denk
his change makes little sense to me/ If you want error messages, then > > just turn > > above debug() into printf(), and be done with it. > > As an additional benefit so see at once which step failed. > > In this patch, I try to display error as soon as console is available > (a

Re: [PATCH 2/7] examples: rename __start to _start on MIPS

2020-04-23 Thread Wolfgang Denk
linker script. Maybe Wolfgang knows more? Sorry, I can't remember resp. I think I never knew. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989

Re: U-Boot Statistics updates?

2020-04-27 Thread Wolfgang Denk
> > Is that no longer going to be supported? > > I only ask, because I don't see any reference to 2020.04 at all. > > This was usually done by Wolfgang. Thanks for the reminder. Doing that now. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Ma

U-Boot v2020.01 Release Statistics

2020-04-27 Thread Wolfgang Denk
%) Broadcom 4 (2.0%) ST Microelectronics 4 (2.0%) BayLibre SAS 3 (1.5%) ... Full list as usial at [1] [1] http://www.denx.de/wiki/U-Boot/UbootStat_2020_01 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk

U-Boot v2020.04 Release Statistics

2020-04-27 Thread Wolfgang Denk
Microelectronics 4 (2.1%) Amarula Solutions3 (1.6%) ... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989

Re: [U-Boot] [BUG] cmd : Local Hush Variable Could not be deleted

2019-10-14 Thread Wolfgang Denk
empty value anyway. Same as in other shells. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Care

Re: [U-Boot] [BUG] cmd : 'env exists envvar' does not display the existence of environment variable

2019-10-14 Thread Wolfgang Denk
AY exists U-Boot> if env exists bootdelay ; then echo BOOTDELAZ exists ; else echo BOOTDELAZ does not exist ; fi BOOTDELAZ exists U-Boot> env exists bootdelay && printenv bootdelay bootdelay=3 There is no bug. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, M

Re: [U-Boot] [BUG] cmd : Local Hush Variable Could not be deleted

2019-10-15 Thread Wolfgang Denk
ION=0.01 foo=hello U-Boot> foo='' U-Boot> showvar HUSH_VERSION=0.01 foo=hello Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germa

Re: [U-Boot] [PATCH v4 0/3] env: Add CONFIG_ENV_FULL_SUPPORT

2019-10-15 Thread Wolfgang Denk
ed a lot. Sorry, I can't really tell... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If

Re: [U-Boot] [BUG] cmd : 'env exists envvar' does not display the existence of environment variable

2019-10-15 Thread Wolfgang Denk
documents or > guidelines to follow while they > explore u-boot ( from user/tester/developer perspective ). I found it always useful to read and remember the recommendations posted in [1]. [1] http://www.catb.org/%7eesr/faqs/smart-questions.html Best regards, Wolfgang Denk -- DENX Software Engin

Re: [U-Boot] [PATCH v5 00/19] efi_loader: non-volatile variables support

2019-10-25 Thread Wolfgang Denk
UEFI specific though. Is this a new problem, or do you just mention this here for completeness? We always had this issue, didn't we? > > > * I cannot test all the platforms affected by this patchset. Sure, so please seek help from the board maintainers. And please provide

Re: [U-Boot] [PATCH v5 00/19] efi_loader: non-volatile variables support

2019-10-25 Thread Wolfgang Denk
can be done on boards that don't use FAT to store > > the environment? > > As I said, > > > > > In this version, only FAT file system and flash devices are > > > > > supported, > > > > > but it is quite straightforward to modify othe

Re: [U-Boot] [EXT] Re: Cavium/Marvell Octeon Support

2019-10-29 Thread Wolfgang Denk
ust to be replaced by an operating system. I have to admit that I have problems understanding why someone would need hot plug support for hardware in U-Boot. It would be best to restrict initial upstreaming to a minimal sub-set that gives maintainers even a chance to review it. Best regards, Wolfgang Den

Re: [U-Boot] [PATCH v5 00/19] efi_loader: non-volatile variables support

2019-10-29 Thread Wolfgang Denk
mplementation. My suggestion would be to use something > > that is not file system based, but using plain storage, say a board > > which has the environment in SPI NOR flash. > > What do you mean by "non-UEFI"? Disabling UEFI, or testing U-Boot environment > variables o

Re: PowerPC progress

2020-08-01 Thread Wolfgang Denk
r migrated and updated. Actually we're just discussing with a customer to bring MPC82xx back into mainline (and maintain it for another 5...7 years Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr

Error handling broken for block devices

2020-01-20 Thread Wolfgang Denk
actually supported in a given U-Boot binary. Or is there such a tool?] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email

Re: [PATCH] env: introduce CONFIG_ENV_DOTVARS_TEMPORARY

2020-01-20 Thread Wolfgang Denk
. This is not a good idea. The decision whether a variable shall be stored permanently or not, or wheter it is readonly or writable, and other such properties should never based on their name. There may be many good reasons that some .name variable _shall_ be persistent. Naked-by: Wolfgang Denk

Re: [RFC PATCH] Provide mechanism for build-time default env entries

2020-01-20 Thread Wolfgang Denk
gt; + CONFIG_USER_ENV_SETTINGS > #endif What exactly is the difference between CONFIG_EXTRA_ENV_SETTINGS and CONFIG_USER_ENV_SETTINGS for you, i. e. what can you do with CONFIG_USER_ENV_SETTINGS that cannot be done in exatly the same way with CONFIG_EXTRA_ENV_SETTINGS? Maybe it would help if you in

Re: [RFC PATCH] Provide mechanism for build-time default env entries

2020-01-20 Thread Wolfgang Denk
en installed where. > if there is a better way to accomplish this I'd be all for it, but I > couldn't find anything, thus the RFC patch. There are many ways to provision code new hardware; depending on hardware features more or less. You can always import envrionment b

Re: [PATCH] env: introduce CONFIG_ENV_DOTVARS_TEMPORARY

2020-01-21 Thread Wolfgang Denk
So, would you accept introducing env_flags_varaccess_temporary, for > which I could then add tmp_.*:st ? Please look up the last discussion of this topic; see the thread "efi_loader: implementing non-volatile UEFI variables" starting here: https://lists.denx.de/pipermail/u-boot/2019-

Re: [RFC PATCH] Provide mechanism for build-time default env entries

2020-01-21 Thread Wolfgang Denk
ed blob) can easily be attached to the U-Boot image and handled as a combined unit. Then you just import the additional environment from this well-known address. This gives you all the possibilities you have for handling the environment, conflict free. Best regards, Wolfgang Denk -- DEN

Re: [RFC PATCH] Provide mechanism for build-time default env entries

2020-01-22 Thread Wolfgang Denk
er (much more flexible) ways exist? My general thinking at uch things is: if you can script something or do it in other ways that don't require code changes, then it is worth having a closer look in those other ways. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing

[PATCH] [FS] Print error message for unknown device type

2020-01-22 Thread Wolfgang Denk
File system commands like "ls" etc. require a device type parameter. If an unknown type is specified, they return an error code but no visible feedback to the user: -> ls FOOBAR 1:1 / -> Add an error message to make clear what happens, and why. Signed-off-by: Wolfgang Denk

Re: [PATCH] Output information about device look up failure.

2020-01-22 Thread Wolfgang Denk
my other patch instead. You are using incorrect brace style, and I think your error message is a bit misleading - "look up failed" sounds like some internal error, the reason of which is still unclear. We should instead say clearly the the given device type is not supported/known in the

Re: [PATCH] [FS] Print error message for unknown device type

2020-01-22 Thread Wolfgang Denk
the user: > > > > -> ls FOOBAR 1:1 / > > -> > > > > Add an error message to make clear what happens, and why. > > > > Signed-off-by: Wolfgang Denk > > --- > > disk/part.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deleti

Re: [PATCH 3/5] cmd: env: check real location for env info command

2020-01-24 Thread Wolfgang Denk
m. The following locations should be returned by order > + * of descending priorities, from the highest to the lowest priority. > + * > + * Returns: > + * an enum env_location value on success, a negative error code otherwise > + */ > +enum env_location env_get_location(enum env_ope

Re: [PATCH] env: add prototypes for weak function

2020-01-24 Thread Wolfgang Denk
> +/* allows to set ext4 device and partition */ > +const char *env_ext4_get_dev_part(void); A "get device and partition" function is not supposed to set anything? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich,

Re: [PATCH] [FS] Print error message for unknown device type

2020-01-24 Thread Wolfgang Denk
r. > > > If an unknown type is specified, they return an error code but no > > > visible feedback to the user: > > > > > > -> ls FOOBAR 1:1 / > > > -> > > > > > > Add an error message to make clear what happens, and why. >

Re: [PATCH v4 01/10] env: nowhere: set default enviroment

2020-01-27 Thread Wolfgang Denk
V_READY) which never is true > for the nowhere case and hence env_set returns 1. > > If any of the memory based ENV config is set i see that env_set_default > is called hence env_set works nicely. So we need to have env_set_default > in the case of nowhere configuration as well. An

Re: [PATCH v4 01/10] env: nowhere: set default enviroment

2020-01-28 Thread Wolfgang Denk
e nowhere > path as well. I see. Sorry, I didn't read the original patch. As you see in the quote above, the "env_set_default" somehow got lost, and this was what triggered my comment. Feel free to ignore it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: DWC4 ethernet in U-Boot receiving it's own traffic

2020-01-29 Thread Wolfgang Denk
ated discussions here on the U-Boot mailing list? Redirecting to some vendor forum is not really helpful to the community. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, German

Re: [U-Boot] [PATCH v2 2/3] env: Tidy up some of the env code

2020-01-30 Thread Wolfgang Denk
ng standard interfaces. I also dislike the seocnd part of the patch. First, this is unrelated to the hsearch_r changes, so it should have been a separate commit anyway. But renaming _do_env_set() into do_interactive_env_set() makes absolutely no sense. It is called in many places from code, whic

Re: [U-Boot] [PATCH v2 3/3] env: Provide programmatic equivalent to 'setenv -f'

2020-01-30 Thread Wolfgang Denk
) > +{ > + return do_programmatic_env_set(varname, varvalue, H_FORCE); > } You add another level of function nesting and add more lines of code than if just coppying the 3 C statements. If possible, please also try not to come up with so awfully long names like do_programmatic_env_set()

Re: [U-Boot] [PATCH] tools: env: handle corrupted ubi volumes during sanity check

2020-01-30 Thread Wolfgang Denk
ser at least. Saying "oh, this error is not an error" is wrong. Think especially of the case when there is no redundant environment at all! If you want to drop through to trying to read the other copy of the enviropnment (if there is one !!!) this needs to be implemented differently.

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-31 Thread Wolfgang Denk
s just From: Faiz Abbas To: Cc: michal.si...@xilinx.com It would be interesting to check the MTA los on the sender side if the Cc:s were actually sent... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Mu

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-31 Thread Wolfgang Denk
Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "355/113 -- Not the famous irrational nu

Re: [PATCH v2 02/10] mmc: Add init() API

2020-01-31 Thread Wolfgang Denk
;t really trust mailman if it's getting dark outside, but I have no good way to check this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax

Re: [U-Boot] [PATCH v2 2/3] env: Tidy up some of the env code

2020-01-31 Thread Wolfgang Denk
nge nonstandard, I think this > should be a change we actively vote for (and the above 2 patches did not > seem to take this into account). Indeed. I'm pretty sure I did not notice these. Thanks! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing D

Re: [PATCH v2] cmd: Handle CONFIG_(SPL_|TPL_)ENV_SUPPORT for toggling nvedit object

2020-02-02 Thread Wolfgang Denk
regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Experience is that marvelous thing that enable you to re

Re: [PATCH v2 02/10] mmc: Add init() API

2020-02-09 Thread Wolfgang Denk
ist tool works, and how the recipient filters his incoming e-mail. But I don't have any clever solution either. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone

[MAINTENANCE] Downtime on lists.denx.de / gitlab.denx.de

2020-02-10 Thread Wolfgang Denk
be up to 8 hours. I apologize for the inconvenience, but we cannot help it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989

Re: [PATCH v2 02/10] mmc: Add init() API

2020-02-11 Thread Wolfgang Denk
need to consider such a > heavy-handed work-around. Thanks for looking into this more! We will continue to look into this a bit deeper; I will report back. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchen

Re: [PATCH v2 02/10] mmc: Add init() API

2020-02-11 Thread Wolfgang Denk
s://bugs.launchpad.net/mailman/+bug/1216960 [3] https://bugs.launchpad.net/mailman/+bug/266682 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:

Re: [PATCH v2 02/10] mmc: Add init() API

2020-02-11 Thread Wolfgang Denk
able as 1449 # it can break DKIM signatures and possibly cause confusion. To avoid changes 1450 # to Cc: headers, set the list's drop_cc to No. 1451 DEFAULT_DROP_CC = Yes Agreed? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2020-02-11 Thread Wolfgang Denk
, update the help texts and try to handle the Kconfig issue if > this is something that might be accepted. I'm pretty sure this will blow up in your face in real life, because if side effects on existing shell scripts even if you don't expect this. This needs _lots_ of tes

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2020-02-12 Thread Wolfgang Denk
> corresponds to > > eval "result=\${BOOT_${x}_LEFT}" ...and things become already very tricky here, as you can see from the need of having "\$" and "$" mixed. Now assume you have more of this in the embedded variables... I consider this change a ba

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2020-02-12 Thread Wolfgang Denk
lt; print $result' => slot=B => run foo result=BOOT_B_LEFT BOOT_B_LEFT=boot b left => slot=X => run foo result=BOOT_X_LEFT BOOT_X_LEFT=boot x left => slot=A => run foo result=BOOT_A_LEFT BOOT_A_LEFT=boot a left Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [PATCH 00/33] sandbox: Move to SDL2

2020-02-12 Thread Wolfgang Denk
ation? And why is this the default? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Let the progr

Re: [PATCH] powerpc: reduce number of WATCHDOG_RESET calls from flush_cache

2020-09-23 Thread Wolfgang Denk
lease write readable code. The use of SZ_ here is not a good idea. Also, you might want to make the actual parameter configurable, so boards with specific timing requirements can adjust this as needed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfga

Re: [PATCH 2/2] env: add CONFIG_ENV_SECT_SIZE_AUTO

2020-09-24 Thread Wolfgang Denk
ot time since our logic always causes the > > environment to be written during boot. Is this your way of implementing scheduled obsolescence? Automatically writing the environment on every boot is always a really bad idea. Never ever do that. Best regards, Wolfgang Denk -- DENX Soft

Re: [PATCH] powerpc: reduce number of WATCHDOG_RESET calls from flush_cache

2020-09-24 Thread Wolfgang Denk
ng requirements can still work. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The human mind ord

Re: [PATCH 2/2] watchdog: add watchdog behavior configuration

2020-09-25 Thread Wolfgang Denk
e user we've turned off > the WDT that we had told them is on. Any so-called "watchdog" that can be disabled / switched off by software is not really woth this name. As such, the concept of disabling a watchdog in software, is misleading at best and should never ibe implemente

Re: [PATCH 0/3] add "call" command

2020-09-25 Thread Wolfgang Denk
n. All this needs a bit of a long term maintainable concept. Quick hacking of the ancient code is not a good idea. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (

Re: [PATCH 1/3] cli_hush.c: refactor handle_dollar() to prepare for cmd_call

2020-09-25 Thread Wolfgang Denk
this a soft-NAK ;-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "The good Christian should b

Re: [PATCH 2/2] watchdog: add watchdog behavior configuration

2020-09-25 Thread Wolfgang Denk
p in ind that any real watchdog (which is worth the money and the name) _cannot_ be disabled by software once it was started. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germa

Re: [PATCH 0/3] add "call" command

2020-09-25 Thread Wolfgang Denk
way round. This is simple. The PoLA (Principle of Least Astonishment) applies here. Behaviour must be the same as in other (to some extent POSIX compatible) shells. A shell should parse it's input, not adhoculate it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Mana

Re: [PATCH 2/3] cli_hush.c: add "call" command

2020-09-26 Thread Wolfgang Denk
writing "busybox shell" when I mean > "U-Boot shell". Sorry. I hope the meaning is clear anyway. U-Boot copied the code from BusyBox, where the hush shell originated AFAIK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang

Re: [PATCH 2/2] watchdog: add watchdog behavior configuration

2020-09-26 Thread Wolfgang Denk
> Appendix R - Glossary > > p. 2444 > Watchdog Time > An alarm timer that may be set to go off. This can be used to regain > control in cases where a code path in the boot services environment > fails to or is unable to return control by the expected path. Again this does not

<    1   2   3   4   5   6   7   8   9   10   >