Re: [U-Boot] [PATCH 1/3] Add support for PCA953x I2C gpio devices

2008-11-18 Thread Wolfgang Denk
ds and tried to replicate similar functionality in this > driver. I like the info command but understand if others want it > removed. Don't remove it, but maybe make it a selectable option so those who like it can include it while others that are tryting to minimize the memory foo

Re: [U-Boot] [PATCH 2/3] Add support for Maxim's DS4510 I2C device

2008-11-18 Thread Wolfgang Denk
nt\n" > > > + " - read/write 'cnt' bytes at SRAM offset 'off'\n" > > > > Why do we need the "chip" argument? It just adds typing... > > In theory more than 1 chip could be on a board. The chip uses an > address p

Re: [U-Boot] [PATCH] dataflash: fix a problem with the last partition

2008-11-18 Thread Wolfgang Denk
diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c > > index 201e518..43746e7 100644 > > --- a/drivers/mtd/dataflash.c > > +++ b/drivers/mtd/dataflash.c > Who is supposed to handle this one? Now that you claimed responsibility for dataflash code, could you pl

Re: [U-Boot] [PATCH 0/2] 85xx: Support for XPedite5200

2008-11-18 Thread Wolfgang Denk
a board with the name "XPedite5200" uses a MPC5200 processor, but no, it's a MPC8548 instead. This is a really confusing name, isn't it? [I guess you do this intentionally to shock competitors about the performance you get out of a 5200, right?] Best regards, Wolfgang

Re: [U-Boot] [PATCH 2/2] XPedite5200 board support

2008-11-18 Thread Wolfgang Denk
/xpedite5200/ddr.c b/board/xes/xpedite5200/ddr.c > new file mode 100644 > index 000..c5616d5 > --- /dev/null > +++ b/board/xes/xpedite5200/ddr.c I think one day we will have to merge all these 20+ ddr.c files into one or a few common ones :-( Much to much copy & paste around here

Re: [U-Boot] [U-boot] Export functions using Jumptable in Standalone application

2008-11-18 Thread Wolfgang Denk
is under GPL. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] "If that makes any

Re: [U-Boot] [PATCH 03/10] AVR32: Make cacheflush cpu-dependent

2008-11-18 Thread Wolfgang Denk
/cacheflush.h > delete mode 100644 include/asm-avr32/cacheflush.h Please provide the patch such that files get renamed, not removed and re-added. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchen

Re: [U-Boot] [PATCH 04/10] AVR32: Move addrspace.h to arch-directory, and move some functions from io.h to addrspace.h

2008-11-18 Thread Wolfgang Denk
-- > lib_avr32/bootm.c |2 +- > 4 files changed, 87 insertions(+), 84 deletions(-) > delete mode 100644 include/asm-avr32/addrspace.h > create mode 100644 include/asm-avr32/arch-at32ap700x/addrspace.h Please provide the patch such that files g

Re: [U-Boot] [PATCH 05/10] AVR32: macb - Disable 100mbps if clock is slow

2008-11-18 Thread Wolfgang Denk
if (get_hsb_clk_rate() < min_hz) { > + printf("%s: HSB clock < %u MHz in %s mode - " > +"disabling 100mbit.\n", netdev->name, min_hz / 100, Use str_mhz() to round and print the frequency. And please use "Mbit/s" o

Re: [U-Boot] [PATCH 05/10] AVR32: macb - Disable 100mbps if clock is slow

2008-11-18 Thread Wolfgang Denk
Dear Ben Warren, In message <[EMAIL PROTECTED]> you wrote: > > Applied to net/testing. Please see previous review comment. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-8

Re: [U-Boot] [PATCH 07/10] AVR32: Disable relocation of command table when on AT32UC3A for now

2008-11-18 Thread Wolfgang Denk
t you rom using U-Boot to update itself in flash? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAI

Re: [U-Boot] [PATCH 09/10] AVR32: CPU support for AT32UC3A0xxx CPUs

2008-11-18 Thread Wolfgang Denk
; > +} > + > +static inline void portmux_enable_usart2(unsigned long drive_strength) > +{ > + portmux_select_peripheral(PORTMUX_PORT_B, (1 << 29) | (1 << 30), > + PORTMUX_FUNC_A, 0); > +} > + > +static inline void portmux_enable_usart3(unsign

Re: [U-Boot] [PATCH 10/10] AVR32: Board support for ATEVK1100

2008-11-18 Thread Wolfgang Denk
orted. Please also add board to MAKEALL script and to MAINTAINERS file. And fix some too long lines, please. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone:

Re: [U-Boot] [PATCH] fsl ddr skip interleaving if not supported.

2008-11-18 Thread Wolfgang Denk
++-- > cpu/mpc8xxx/ddr/options.c | 20 ++-- > 2 files changed, 17 insertions(+), 12 deletions(-) Who of you is going to pick this up (or reject it) ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich

Re: [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not

2008-11-19 Thread Wolfgang Denk
r.o fdt_sw.o > > fdt_wip.o > > > > ? > no because we may do not have the CONFIG_OF_LIBFDT and CONFIG_FIT at the same > time Yes, of course we may have both at the same time. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev

Re: [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not

2008-11-19 Thread Wolfgang Denk
for FIT images (if there are any). Note: You must also change the Makefile to use COBJS := $(sort $(COBJS-y)) or we will get errors because of duplicated opjects. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 1

Re: [U-Boot] [PATCH] Fix FIT and fdt blob support to have CONFIG_OF_LIBFDT and CONFIG_FIT independant

2008-11-19 Thread Wolfgang Denk
but want to use > the new uImage format, we just need FIT support (ex : ARM). Please see comments to previous patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, German

Re: [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not

2008-11-19 Thread Wolfgang Denk
CONFIG_FIT > 2) fdt blob only CONFIG_OF_LIBFDT > 3) both CONFIG_OF_LIBFDT & CONFIG_FIT > > so CONFIG_FIT could have CONFIG_FIT without CONFIG_OF_LIBFDT Yes, that's what we've been discussing all the time - but let's not forget that there is obviou

Re: [U-Boot] [PATCH 00/10] AVR32: RFC/preview - support for ATEVK1100 evaluation board

2008-11-19 Thread Wolfgang Denk
the comments you got > during review. Umm... but please do NOT merge this branch into your AVR32 repository for me to poll from. In mainline, I want to see consolidated patches only. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel

Re: [U-Boot] Linux booting speed up.

2008-11-19 Thread Wolfgang Denk
accomplished patching U Boot ad hoc, but can it be done > through standard commands and variables ? Yes, see above. Also keep in mind that turning of the checksums (verify=no) helps a bit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detl

Re: [U-Boot] Linux booting speed up.

2008-11-19 Thread Wolfgang Denk
mistake if you look for fast boot times. See for example http://www.denx.de/wiki/view/DULG/RootFileSystemSelection Using a crafs file system image instead of a ramdisk often saves 30...50% of the boot time. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk

Re: [U-Boot] Code style questions (weak functions, cpu/ v's lib_arch/)

2008-11-19 Thread Wolfgang Denk
r the trees myself. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Conscious is when yo

Re: [U-Boot] PowerPC 440EP hard-float

2008-11-20 Thread Wolfgang Denk
th hard float a bad idea somehow? Has > soft-float any advantages? A 4xx FP toolchain is a perfectly good idea - that's why we support such a configuration in ppc_4xxFP with the ELDK. But it doesn't need any changes to U-Boot. Best regards, Wolfgang Denk -- DENX Software Eng

Re: [U-Boot] PowerPC 440EP hard-float

2008-11-20 Thread Wolfgang Denk
> without depending of the toolchains support of hard-float or soft-float Note that this is not the cause of the problem. It works fine with the ELDK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchens

Re: [U-Boot] U-boot resets when booting Linux kernel

2008-11-20 Thread Wolfgang Denk
looks way too small for a 2.6.2x PowerPC kernel image. Are you sure you are using a sane configuration which includes all the essentiual things? And did you try a port-mortem dump of the log buffer? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detle

Re: [U-Boot] Linux booting speed up.

2008-11-20 Thread Wolfgang Denk
in the boot process. Note that the header checksum is still verified. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax:

Re: [U-Boot] U-boot resets when booting Linux kernel

2008-11-20 Thread Wolfgang Denk
ow is it made? lib_ppc/board.c > U-boot.map shows only where the functions is stored at flash but I > need to know where they are executing in RAM... A simple method is to print the relocation offset in the debugger - register r2 holds the global data pointer. Best regards, Wolfgang Denk

Re: [U-Boot] Merge fixes/clean up outside merge window? was: Re: [PATCH] lib_arm: do_bootm_linux() - correct a small mistake

2008-11-20 Thread Wolfgang Denk
is sent? Isn't this an important fix which should go into > mainline even if merge window is not open? Yes, this *should* go into mainline ASAP. I am waiting for a pull request for u-boot-arm myself, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolf

Re: [U-Boot] virt to phys mapping function

2008-11-20 Thread Wolfgang Denk
[next_rx]))|RX_DMA_ENABLE; > cpu/mips/au1x00_eth.c:fifo_tx[i].addr = > virt_to_phys(&txbuf[0]); > cpu/mips/au1x00_eth.c:fifo_rx[i].addr = > (virt_to_phys(NetRxPackets[i]))|RX_DMA_ENABLE; They have to be checked and fixed, like all other uses

Re: [U-Boot] [PATCH] inka4x0: hardware diagnosis and RTC.

2008-11-20 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message <[EMAIL PROTECTED]> you wrote: > > why not make configurable via if def > as > > ifndef CONFIG_RTC_RTC4543 > #define CONFIG_RTC_MPC5200 > #endif Because it doesn't make sense? Best regards, Wolfgang Denk --

Re: [U-Boot] [PATCH V2] Fix FIT and fdt blob support to have CONFIG_OF_LIBFDT and CONFIG_FIT independant

2008-11-20 Thread Wolfgang Denk
w defines, and move them to architecture specific files, i. e. we leave every- thing as is (architecture dependent), just much more complicated and information distributed over tens of files. I cannot accept this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang D

Re: [U-Boot] [PATCH] UBI: Change size of UBI commands to default to hex instead of decimal

2008-11-21 Thread Wolfgang Denk
ommands do. You may want to rephrase the Subject a bit. For me "Change size of UBI commands" is not what you actually mean (changing the parsing of the size parameter). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 16

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Convert readl/writel and replace hardcoded values

2008-11-23 Thread Wolfgang Denk
gram- ming syle of defining only register offsets instead of proper data structures like for example PowerPC has been doing for ages. Do you see a chance to convert the OMAP3 code to use data structures instead of offset definitions to describe the processor registers and peripherals? Bes

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Convert readl/writel and replace hardcoded values

2008-11-23 Thread Wolfgang Denk
an write writel(0x000, ptr->ecc_config); or similar - and the compiler will actually perform type checking. [Actually thius should be done for ALL such offset lists for all systems that use such stuff, i. e. for probably all ARM systems.] I am aware that this is a major style

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Convert readl/writel and replace hardcoded values

2008-11-23 Thread Wolfgang Denk
_byte(SC520_DRCCTL) & 0xcf) | (val<<4)); > with: > mmcrptr->drcctl = (mmcrptr->drcctl & 0xcf) | (val<<4); > > Is this appropriate? Probably not. Check what the Linux kenrel is doing (but then, x86 may be a poor example; these processors are simply not advanc

Re: [U-Boot] [PATCH-OMAP3] OMAP3: Convert readl/writel and replace hardcoded values

2008-11-23 Thread Wolfgang Denk
ecture does that in a similar way. [x86 may be different, because it always is.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-81

Re: [U-Boot] [PATCH] at91rm9200: fix broken boot from nor flash

2008-11-23 Thread Wolfgang Denk
-by: Peter Pearse <[EMAIL PROTECTED]> Signed-off-by: Ulf Samuelsson <[EMAIL PROTECTED]> Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (

[U-Boot] FDT warning: redefinition of `uintptr_t'

2008-11-24 Thread Wolfgang Denk
nks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Genitiv ins Wasser, we

[U-Boot] mkimage warning: ISO C99 requires ...

2008-11-24 Thread Wolfgang Denk
mkimage.c:25: mkimage.h:41:23: warning: ISO C does not permit named variadic macros mkimage.c:243:47: warning: ISO C99 requires rest arguments to be used mkimage.c:622:48: warning: ISO C99 requires rest arguments to be used Could you please have a look? Thanks. Best regards, Wolfgang Denk -- DENX

Re: [U-Boot] Info on different Versions of U-Boot.

2008-11-24 Thread Wolfgang Denk
an upgrade, but then you mention v1.3.1 which is pretty obsolete, too. You should really use current code for any such work. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, German

Re: [U-Boot] [PATCH 2/4] FDT: Enable microblaze cpu in image.c

2008-11-24 Thread Wolfgang Denk
pport), and thus can be selected on a board level. It is *not* an architecture thing, so it is incorrect to enable or disable it depending on the current arch settings. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Mu

Re: [U-Boot] Can I have a backup boot option ?

2008-11-24 Thread Wolfgang Denk
file names that contain auto_update or fwupdate, and/or read doc/README.update Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8

Re: [U-Boot] [PATCH] at91rm9200: fix broken boot from nor flash

2008-11-24 Thread Wolfgang Denk
question goes to DK users and arm custodian. For DK, the situation looks clear now. Thanks for the patch! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-81

[U-Boot] [PATCH] AT91RM9200DK: fix broken boot from NOR flash

2008-11-24 Thread Wolfgang Denk
From: Wolfgang Denk <[EMAIL PROTECTED]> Signed-off-by: Wolfgang Denk <[EMAIL PROTECTED]> --- cpu/arm920t/start.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpu/arm920t/start.S b/cpu/arm920t/start.S index f99d129..5143cfc 100644 --- a/cpu/arm920t/start

Re: [U-Boot] [ubi] Please pull git://www.denx.de/git/u-boot-ubi.git

2008-11-25 Thread Wolfgang Denk
ver. Kyungmin, is there anything we can do to make access to the git repository easier to you? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989

Re: [U-Boot] [cfi-flash] Please pull git://www.denx.de/git/u-boot-cfi-flash.git

2008-11-25 Thread Wolfgang Denk
drivers/mtd/Makefile|1 + > drivers/mtd/cfi_flash.c | 72 - > drivers/mtd/cfi_mtd.c | 202 > +++ > include/flash.h | 12 +++ > 5 files changed, 272 insertions(+), 20 deletions(-) > create mode 1

Re: [U-Boot] Please pull u-boot-mpc83xx

2008-11-25 Thread Wolfgang Denk
Dear Kim Phillips, In message <[EMAIL PROTECTED]> you wrote: > Dear Wolfgang Denk, > > please pull a couple of minor fixes for 83xx: > > The following changes since commit 9b827cf1720acda2473afa516956eab6f7cca9a1: > Selvamuthukumar (1): > Align end of bss by

Re: [U-Boot] ARM pull request

2008-11-25 Thread Wolfgang Denk
-- > lib_arm/bootm.c|2 +- > 2 files changed, 65 insertions(+), 68 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82

Re: [U-Boot] [ppc4xx] Please pull git://www.denx.de/git/u-boot-ppc4xx.git

2008-11-25 Thread Wolfgang Denk
/sw_services/uboot_v1_00_a/data/uboot_v2_1_0.mld > delete mode 100644 > board/xilinx/ml300/sw_services/uboot_v1_00_a/data/uboot_v2_1_0.tcl > create mode 100644 include/asm-ppc/ppc4xx-isram.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wol

Re: [U-Boot] [ubi] Please pull git://www.denx.de/git/u-boot-ubi.git

2008-11-25 Thread Wolfgang Denk
100644 drivers/mtd/ubi/wl.c > create mode 100644 include/linux/crc32.h > create mode 100644 include/linux/mtd/partitions.h > delete mode 100644 include/linux/mtd/ubi-user.h > create mode 100644 include/linux/mtd/ubi.h > create mode 100644 include/mtd/ubi-user.h > create mode 100

Re: [U-Boot] AT91 pull request

2008-11-25 Thread Wolfgang Denk
s changed, 52 insertions(+), 19 deletions(-) Done, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [E

Re: [U-Boot] [PATCH 2/4][RFC] Add ehci core functionality

2008-11-25 Thread Wolfgang Denk
. And please stop sending to the old sourceforge list. The mailing list address is u-boot@lists.denx.de > Markus Klotzbücher wrote: ... > > Not for me (board is sequoia): ... >Can you please send your configuration? Markus explicitely mentioned that he was using the "sequoia"

Re: [U-Boot] New board

2008-11-25 Thread Wolfgang Denk
e/wiki/U-Boot/Patches Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] No one can guarantee t

Re: [U-Boot] [PATCH v3] mpc83xx: New board support SIMPC8313

2008-11-25 Thread Wolfgang Denk
was a bug-fix to the old compiler, the essence of the bug being that the ldmw/stmw should not be used when the sequence of registers is "broken" by the use of "-ffixed=" options and global register variables, as in the case of U-Boot. See http://gcc.gnu.org/bugzilla/show_bug.cgi?id

Re: [U-Boot] New board

2008-11-25 Thread Wolfgang Denk
ns)? For ARM Linux? Well, that's [EMAIL PROTECTED] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL

Re: [U-Boot] PHY lib

2008-11-25 Thread Wolfgang Denk
They must have grown out of sync terribly? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Ven

Re: [U-Boot] PHY lib

2008-11-25 Thread Wolfgang Denk
this topic. yes, I know. Maybe we should make the old stuff available in a branch in our git repo so we can at least show others the existing code? That would require little effort and probably be a good base for further discussions? Best regards, Wolfgang Denk -- DENX Software Engine

Re: [U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread Wolfgang Denk
re difficult to 'grep' for the > > strings printed in the terminal to find them back in the code. > > So, I am very curious about the point of view Wolfgang about this > > rule. (How strict does this rule need to be applied?) > > > I prefer to break the l

Re: [U-Boot] weak functions not being over-ridden (location dependent)

2008-11-26 Thread Wolfgang Denk
e respective object files. See the ML archive for the previous discussion. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-

Re: [U-Boot] [RFC PATCH] USB style patch

2008-11-26 Thread Wolfgang Denk
an: this is a warning that obsolete code will be removed. So let's actually remove that obsolete code, and the warning with it. This long line disappears then, too :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich,

Re: [U-Boot] Generic CFI flash driver is not so generic?

2008-11-26 Thread Wolfgang Denk
the problem is that for some reason flash_read16() might not result in 16bit bus accesses. Do you have a chance to verify this suspicion, for example with a logic analyzer? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235

Re: [U-Boot] Need input: Use Virtual address in commands; add translation/physical

2008-11-26 Thread Wolfgang Denk
really difficult. > Stuff face, write code. Does it get any better than that? ;-) I'm an optimist, to yes, of course it does. The amount of code that needs to get written grows and grows. Enough work for all of us :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [U-Boot] Need input: Use Virtual address in commands; add translation/physical

2008-11-26 Thread Wolfgang Denk
ecause that would also stop you from doing clever things." - Doug Gwyn Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-

Re: [U-Boot] Can I run ELDK on Cygwin

2008-11-27 Thread Wolfgang Denk
ted on the ELDK mailing list - it was off topic here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAI

Re: [U-Boot] [PATCH] Added support for the Guntermann & Drunck PowerPC 440 EP/GR ETX module.

2008-11-27 Thread Wolfgang Denk
nit_r() */ > +#if 0 > +#define CONFIG_BOARD_RESET 1 /* call board_reset() */ > +#endif Please do not add dead code. > +/*--- > + * Base addresses -- Note these are effective addresses where

Re: [U-Boot] Need input: Use Virtual address in commands; add translation/physical

2008-11-27 Thread Wolfgang Denk
the freedom of things you can do with U-Boot. We didn't have anything like that for the last 8+ years, and I still see no need for it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 G

Re: [U-Boot] [PATCH] Added support for the Guntermann & Drunck PowerPC 440 EP/GR ETX module.

2008-11-27 Thread Wolfgang Denk
ters word :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] It is a good thing for an

Re: [U-Boot] [PATCH] Added support for the Guntermann & Drunck PowerPC 440 EP/GR ETX module.

2008-11-28 Thread Wolfgang Denk
-generic/xilinx_ppc440_generic.c board/xilinx/ppc405-generic/xilinx_ppc405_generic.c Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fa

Re: [U-Boot] LXT971 Ethernet problem

2008-12-02 Thread Wolfgang Denk
08.10 or even better top of tree from the git repository), and then try again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-6

Re: [U-Boot] LXT971 Ethernet problem

2008-12-02 Thread Wolfgang Denk
without knowing these things. Mainline U-Boot does include support for the at91sam9260ek board. If you happen to be using an out of tree port you should bury all hope for help from this list - how should we be able to comment on code we don't know, especially if it's more than 2

Re: [U-Boot] [PATCH] tools/mkimage: use lseek rather than fstat for file size for -l option

2008-12-02 Thread Wolfgang Denk
d, 0, SEEK_END); > + if (sbuf.st_size == (off_t)-1) { > + fprintf (stderr, "%s: Can't get size of %s: %s\n", If you don't use *stat(), you should not use any struct stat type either. Best regards, Wolfgang Denk -- DENX Software Engine

Re: [U-Boot] Problem building fw_printenv un u-boot 1.3.4

2008-12-03 Thread Wolfgang Denk
When I run it I get the following > error. > > Cannot parse config file: No such file or directory Obviously you have to create a config file in your target file system... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 16

Re: [U-Boot] Is arm-2008-11-24.iso the right image to compile U Boot for ARM ?

2008-12-03 Thread Wolfgang Denk
is no > definition for Cross compile variable for ARM , it talks mostly about Power > PC , how do I proceed from here ? See the README.html included with the ISO image. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Mun

Re: [U-Boot] how compilor know where .text section starts from?

2008-12-03 Thread Wolfgang Denk
ing MPC8548CDS, document says .text section begins > from 0xfff8000, but I haven't find this value in u-boot.lds? > So it must be specified in some other place, right? See board//config.mk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detl

Re: [U-Boot] [PATCH] tools/mkimage: use lseek rather than fstat for file size for -l option

2008-12-03 Thread Wolfgang Denk
. > Wolfgang> If you don't use *stat(), you should not use any struct > Wolfgang> stat type either. > > Ok, I kept it like that to keep the patch as minimal as possible - > I'll change it and resend. I think it makes little sense as my feeling is the changes make mkimag

Re: [U-Boot] [PATCH v2] tools/mkimage: ignore trailing garbage

2008-12-03 Thread Wolfgang Denk
ength checking of the image is intentional and shall not be removed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-8

Re: [U-Boot] [PATCH v2] tools/mkimage: use lseek rather than fstat for file size for -l option

2008-12-03 Thread Wolfgang Denk
e > latter doesn't support mmap. > > Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> As mentioned before, this doesn't work because the length you are checking is not the image length, but the device size. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH

Re: [U-Boot] Pull requst u-boot-mpc86xx

2008-12-04 Thread Wolfgang Denk
; include/configs/stxgp3.h |1 - > include/configs/stxssa.h |1 - > 28 files changed, 33 insertions(+), 35 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Offic

Re: [U-Boot] Pull request: nand flash

2008-12-04 Thread Wolfgang Denk
sitory at: > > git://git.denx.de/u-boot-nand-flash.git master > > Stefan Roese (1): > OneNAND: Add missing mtd info struct before calling onenand_erase() > > common/env_onenand.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Applied, thanks. Be

Re: [U-Boot] Please pull u-boot-mpc85xx.git

2008-12-04 Thread Wolfgang Denk
- > include/configs/sbc8548.h |1 - > include/configs/sbc8560.h |1 - > include/configs/sbc8641d.h |1 - > include/configs/socrates.h |1 - > include/configs/stxgp3.h |1 - > include/configs/stxs

Re: [U-Boot] Pull Request: u-boot-usb.git

2008-12-04 Thread Wolfgang Denk
0.c |4 - > fs/fat/fat.c|4 +- > include/fat.h |2 +- > include/usb.h | 222 ++++--- > 12 files changed, 477 insertions(+), 429 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engin

Re: [U-Boot] AT91 Pull request

2008-12-04 Thread Wolfgang Denk
anged, 15 insertions(+), 16 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-8

Re: [U-Boot] [PATCH] net/net.c: add get_timer_ms()

2008-12-05 Thread Wolfgang Denk
et to 1000 while get_timer() is implemented correctly, then get_timer_ms() willnot do what it claims to do. Not to mention what happens if someone has CONFIG_SYS_HZ defined as 999, for example. The whole aproach is broken - instead of coating bugs we should fix the cause of the bugs. NAK. Best

Re: [U-Boot] [ARM] How up-to-date is http://www.denx.de/wiki/U-Boot/PatchStatus ?

2008-12-05 Thread Wolfgang Denk
Dear "Thomas De Schampheleire", In message <[EMAIL PROTECTED]> you wrote: > > I stumbled upon the following link: http://www.denx.de/wiki/U-Boot/PatchStatus > It seems to contain some sort of "TODO" for the ARM-code. How > up-to-date is this page? Well, the buttom of the page reads:

Re: [U-Boot] [PATCH] net/net.c: correct timeout function

2008-12-05 Thread Wolfgang Denk
e > get_timer_ms(). Apart from that, looks good. If you re-submit soon I'll > pull it in. Please do not pull this. It just covers bugs elsewhere in the code. We need to fix the real bugs, not put paint and wallpaper over it. Best regards, Wolfgang Denk -- DENX Software Enginee

Re: [U-Boot] [PATCH] net/net.c: add get_timer_ms()

2008-12-05 Thread Wolfgang Denk
function like mine should > exist somewhere in the code. Probably not in net/net.c, though. No, it should not exist at all. It is not needed for all correct implementations where get_timer() is already returning milliseconds. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH

Re: [U-Boot] [PATCH] net/net.c: add get_timer_ms()

2008-12-05 Thread Wolfgang Denk
? You best coordinate this with Jean-Christophe, the PXA custodian. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-6

Re: [U-Boot] [PATCH V2] FPGA: move fpga drivers to drivers/fpga

2008-12-05 Thread Wolfgang Denk
t; drivers/fpga}/fpga.c (100%) > rename {common => drivers/fpga}/spartan2.c (100%) > rename {common => drivers/fpga}/spartan3.c (100%) > rename {common => drivers/fpga}/stratixII.c (100%) > rename {common => drivers/fpga}/virtex2.c (100%) > rename {common => drivers/f

Re: [U-Boot] [PATCH] ignore .gdb_history files

2008-12-05 Thread Wolfgang Denk
deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Misquotation is

Re: [U-Boot] [PATCH] cmd_elf: CONFIG_ELF_SIMPLE_LOAD: load ELFs according to PHDRs

2008-12-05 Thread Wolfgang Denk
's requirements at runtime instead of compile time? We could either make this depend on some environment variable setting, or on a command line option when running the command. If you prefer to stick with the CONFIG_ELF_SIMPLE_LOAD solution, then this variable has to be documented in th

Re: [U-Boot] [PATCH]: FFS/UFS filesystems support

2008-12-05 Thread Wolfgang Denk
is list of conditions and the following disclaimer in the > + *documentation and/or other materials provided with the distribution. > + * 4. Neither the name of the University nor the names of its contributors > + *may be used to endorse or promote products derived from this softwar

Re: [U-Boot] [PATCH] lwmon, tqm8xx: Fix build errors

2008-12-05 Thread Wolfgang Denk
|2 -- > board/tqc/tqm8xx/tqm8xx.c |5 +++-- > 2 files changed, 3 insertions(+), 4 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groe

Re: [U-Boot] [PATCH v5] Update U-Boot's build timestamp on every compile

2008-12-05 Thread Wolfgang Denk
t;include/timestamp.h"? Could you add this to the cleanup rules, please? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989

Re: [U-Boot] [PATCH v5] Update U-Boot's build timestamp on every compile

2008-12-06 Thread Wolfgang Denk
+- > lib_sh/board.c |3 ++- > net/net.c |3 +++ > 47 files changed, 135 insertions(+), 52 deletions(-) > create mode 100644 include/timestamp.h Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, M

Re: [U-Boot] [PATCH] lcd: Let the board code show board-specific info cleanup

2008-12-06 Thread Wolfgang Denk
WIW. > > board/tqc/tqm8xx/tqm8xx.c |3 +++ > common/lcd.c |1 - > 2 files changed, 3 insertions(+), 1 deletions(-) Applied remaining part of patch. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HR

Re: [U-Boot] [PATCH 1/4]v2: Document CONFIG_SYS parameters for vxworks

2008-12-06 Thread Wolfgang Denk
Applied (with edits). Please note: 1) the "v2:" part in the Subject line belongs *within* the [PATCH...] brackets, otherwise it becomes part of the commit message which makes no sense. 2) The comments above belon into the commit messages of the respective patches *or* below the

Re: [U-Boot] [PATCH 3/4]v2: Cleanup bootvx and handle new CONFIG_SYS_VXWORKS parameters

2008-12-06 Thread Wolfgang Denk
lied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Let's say the docs

Re: [U-Boot] [PATCH 4/4]v2: Use new CONFIG_SYS_VXWORKS parameters for Netstal boards

2008-12-06 Thread Wolfgang Denk
Dear Niklaus Giger, In message <[EMAIL PROTECTED]> you wrote: > > Signed-off-by: Niklaus Giger <[EMAIL PROTECTED]> > --- > include/configs/netstal-common.h | 29 ++--- > 1 files changed, 14 insertions(+), 15 deletions(-) Applied, thanks. B

Re: [U-Boot] [PATCH] strings: use puts() rather than printf()

2008-12-06 Thread Wolfgang Denk
rysinger <[EMAIL PROTECTED]> > --- > common/cmd_strings.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194

Re: [U-Boot] [PATCH] cmd_elf: CONFIG_ELF_SIMPLE_LOAD: load ELFs according to PHDRs

2008-12-06 Thread Wolfgang Denk
hink we should move into that direction instead of adding more and more magic environment variables. But if you submit a patch that uses environment variables I would not object either. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Z

<    2   3   4   5   6   7   8   9   10   11   >