; Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_loader/efi_image_loader.c | 31 +++
> 1 file changed, 27 insertions(+), 4 deletions(-)
Reviewed-by: Asherah Connor
Looking at cmd/qfw.c as I touched it last:
On 21/04/19 08:04:p, Tom Rini wrote:
> ** CID 331156: Incorrect expression (UNUSED_VALUE)
> /cmd/qfw.c: 40 in qemu_fwcfg_cmd_setup_kernel()
>
>
>
Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and
arm64).
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
---
(no changes since v5)
Changes in v5:
* Split adding MMIO driver to QEMU arm/64 into own commit.
* Use the generic qemu-arm board config
Add MMIO driver for QFW.
Note that there is no consumer as of this patch.
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
---
(no changes since v5)
Changes in v5:
* Split MMIO driver into its own commit.
* Add CONFIG_QFW_MMIO for selection by arch/board
A sandbox driver and test are added for the qfw uclass, and a test in
QEMU added for qfw functionality to confirm it doesn't break in real
world use.
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
Reviewed-by: Bin Meng
---
Changes in v8:
* Removed extraneous newline at EOF.
Changes
We move qfw into its own uclass and split the PIO functions into a
specific driver for that uclass. The PIO driver is selected in the
qemu-x86 board config (this covers x86 and x86_64).
include/qfw.h is cleaned up and documentation added.
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
.
Changes in v5:
* Split conversion of existing x86-only QFW to DM into its own patch.
* Split MMIO driver into its own commit.
* Split adding MMIO driver to QEMU arm/64 into own commit.
Asherah Connor (4):
x86: qemu: move QFW to its own uclass
test: qemu: add qfw sandbox driver, dm tests, qemu tests
On 21/03/19 12:03:p, Bin Meng wrote:
> When applying this series, there are warnings:
>
> $ git am 1.patch
> Applying: x86: qemu: move QFW to its own uclass
> .git/rebase-apply/patch:438: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: test: qemu: add qfw sandbox
Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and
arm64).
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
---
(no changes since v5)
Changes in v5:
* Split adding MMIO driver to QEMU arm/64 into own commit.
* Use the generic qemu-arm board config rather than adding
Add MMIO driver for QFW.
Note that there is no consumer as of this patch.
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
---
(no changes since v5)
Changes in v5:
* Split MMIO driver into its own commit.
* Add CONFIG_QFW_MMIO for selection by arch/board.
drivers/misc/Kconfig
A sandbox driver and test are added for the qfw uclass, and a test in
QEMU added for qfw functionality to confirm it doesn't break in real
world use.
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
---
Changes in v7:
* Make the qfw tests agnostic to running against a real QEMU instance
We move qfw into its own uclass and split the PIO functions into a
specific driver for that uclass. The PIO driver is selected in the
qemu-x86 board config (this covers x86 and x86_64).
include/qfw.h is cleaned up and documentation added.
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
into its own commit.
* Split adding MMIO driver to QEMU arm/64 into own commit.
Asherah Connor (4):
x86: qemu: move QFW to its own uclass
test: qemu: add qfw sandbox driver, dm tests, qemu tests
qemu: add MMIO driver for QFW
qemu: arm: select QFW, MMIO on qemu-arm
arch/x86/cpu/qemu/cpu.c
On 21/03/14 04:03:p, Tom Rini wrote:
> A small thing, CMD_QFW needs to be disabled on sandbox_spl_defconfig (a
> special config for some tests only). A larger thing is that these tests
> fail for me both locally and in CI:
> https://source.denx.de/u-boot/u-boot/-/jobs/237539
>
serial_reinit_all() is only available if CONFIG_SERIAL is defined (i.e.
!CONFIG_DM_SERIAL).
Signed-off-by: Asherah Connor
---
cmd/terminal.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cmd/terminal.c b/cmd/terminal.c
index 733701e059..9e32a4191e 100644
--- a/cmd
already
have several outstanding.
Asherah Connor (2):
terminal: correct stdio_dev invocations
terminal: only serial_reinit_all if available
cmd/terminal.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
--
2.20.1
stdio_dev methods have taken a pointer to themselves since 709ea543
(nearly 7 years ago).
Signed-off-by: Asherah Connor
---
cmd/terminal.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/cmd/terminal.c b/cmd/terminal.c
index f6e4d2539e..733701e059 100644
Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and
arm64).
Signed-off-by: Asherah Connor
---
(no changes since v5)
Changes in v5:
* Split adding MMIO driver to QEMU arm/64 into own commit.
* Use the generic qemu-arm board config rather than adding to multiple
defconfigs
Add MMIO driver for QFW.
Note that there is no consumer as of this patch.
Signed-off-by: Asherah Connor
---
(no changes since v5)
Changes in v5:
* Split MMIO driver into its own commit.
* Add CONFIG_QFW_MMIO for selection by arch/board.
drivers/misc/Kconfig| 7 +++
drivers/misc
A sandbox driver and test are added for the qfw uclass, and a test in
QEMU added for qfw functionality to confirm it doesn't break in real
world use.
Signed-off-by: Asherah Connor
Reviewed-by: Simon Glass
---
(no changes since v1)
drivers/misc/Makefile | 1 +
drivers/misc
We move qfw into its own uclass and split the PIO functions into a
specific driver for that uclass. The PIO driver is selected in the
qemu-x86 board config (this covers x86 and x86_64).
include/qfw.h is cleaned up and documentation added.
Signed-off-by: Asherah Connor
---
Changes in v6
x86-only QFW to DM into its own patch.
* Split MMIO driver into its own commit.
* Split adding MMIO driver to QEMU arm/64 into own commit.
Asherah Connor (4):
x86: qemu: move QFW to its own uclass
test: qemu: add qfw sandbox driver, dm tests, qemu tests
qemu: add MMIO driver for QFW
qemu
Hi Bin, Simon,
On 21/03/05 10:03:p, Bin Meng wrote:
> On Fri, Mar 5, 2021 at 10:31 PM Simon Glass wrote:
> > If I previously reviewed it you can add my tag.
I wasn't sure of the correct etiquette when a large rearrangement of the
patches had been done; I'll keep this in mind.
> > I think
Hi Simon,
On 21/03/04 11:03:p, Simon Glass wrote:
> This looks sensible but it really is a huge patch. Can it be split up a bit?
This is a rejig of v4 previously Reviewed-by: you, see
https://patchwork.ozlabs.org/project/uboot/list/?series=230778=%2a.
Bin Meng suggested the patch be reworked
without CONFIG_DM_GPIO; so far, none do, but soon a QEMU
board may.
Signed-off-by: Asherah Connor
---
drivers/video/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 667157c2e9..220c008f8a 100644
--- a/drivers/video
Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and
arm64).
Signed-off-by: Asherah Connor
---
Changes in v5:
* Split adding MMIO driver to QEMU arm/64 into own commit.
* Use the generic qemu-arm board config rather than adding to multiple
defconfigs.
board/emulation/qemu-arm
Add MMIO driver for QFW.
Note that there is no consumer as of this patch.
Signed-off-by: Asherah Connor
---
Changes in v5:
* Split MMIO driver into its own commit.
* Add CONFIG_QFW_MMIO for selection by arch/board.
drivers/misc/Kconfig| 7 +++
drivers/misc/Makefile | 1 +
drivers
it doesn't break in real world
use.
include/qfw.h is cleaned up and documentation added.
Signed-off-by: Asherah Connor
---
Changes in v5:
* Split conversion of existing x86-only QFW to DM into its own patch.
* Fix qfw_get_dev() so it actually returns -ENODEV when device is
missing.
* Add
QFW to DM into its own patch.
* Split MMIO driver into its own commit.
* Split adding MMIO driver to QEMU arm/64 into own commit.
Asherah Connor (3):
x86: qemu: move QFW to its own uclass
qemu: add MMIO driver for QFW
qemu: arm: select QFW, MMIO on qemu-arm
arch/x86/cpu/qemu/cpu.c
Hi Bin,
On 21/02/26 10:02:p, Bin Meng wrote:
> On Fri, Feb 26, 2021 at 10:14 AM Bin Meng wrote:
> > This patch mixed two things together. The adding ARM support should
> > not belong to this patch.
>
> So we need to split the patch like this:
>
> 1. Convert the existing QFW driver of x86 to
On 21/02/25 09:02:p, Heinrich Schuchardt wrote:
> > -void qfw_read_entry(struct udevice *dev, u16 entry, u32 length, void
> > *address);
> > +/**
> > + * Read a QEMU firmware config entry
>
> This will not generate documentation for qfw_read_entry() with Sphinx.
>
> See
>
On 21/02/25 02:02:p, Simon Glass wrote:
> On Tue, 23 Feb 2021 at 22:24, Asherah Connor wrote:
> >
> > Also rename a "length" to "size" for consistency with the rest of qfw.
>
> Here also you add comments so should mention that.
I thought that may
On 21/02/24 02:02:p, Asherah Connor wrote:
> This series moves the QFW driver into a uclass, UCLASS_QFW, and splits
> the driver into qfw_pio and qfw_mmio. A sandbox driver is also added,
> and a DM unit test against that driver.
I thought it might be worth adding: I've continued and im
Also rename a "length" to "size" for consistency with the rest of qfw.
Signed-off-by: Asherah Connor
---
(no changes since v1)
drivers/misc/qfw.c | 6 ++--
include/qfw.h | 86 +++---
2 files changed, 84 insertions(+), 8 dele
Updates the QFW driver to use the driver model, splitting the driver
into qfw_pio and qfw_mmio (for non-x86) in their own uclass.
Signed-off-by: Asherah Connor
---
Changes in v4:
- PIO definitions are now #defines
- qfw_*_plat structs are no longer in header files
- Remove yield/pause in DMA
We minimally exercise the sandbox driver.
Signed-off-by: Asherah Connor
---
(no changes since v1)
arch/sandbox/dts/sandbox.dtsi | 4 ++
arch/sandbox/dts/test.dts | 4 ++
drivers/misc/Makefile | 1 +
drivers/misc/qfw_sandbox.c| 129 ++
test
Signed-off-by: Asherah Connor
---
(no changes since v1)
test/py/tests/test_qfw.py | 21 +
1 file changed, 21 insertions(+)
create mode 100644 test/py/tests/test_qfw.py
diff --git a/test/py/tests/test_qfw.py b/test/py/tests/test_qfw.py
new file mode 100644
index 00
There's a mixture of "qemu_fwcfg_"-prefixed functions and
"qfw_"-prefixed ones. Now that the qfw name is applied in multiple
places (i.e. the uclass itself, and each of its drivers), let's
consistently use the prefix "qfw_" for anything relating to the
drivers.
he changes online, see:
https://git.src.kameliya.ee/~kameliya/u-boot/log/qfw-priv
Asherah Connor (5):
arm: x86: qemu: move qfw to DM uclass, add Arm support
arm: x86: qemu: unify qfw driver functions as qfw_
qemu: add sandbox driver and tests
test: qemu: add simple test for cmd_qfw
On 21/02/23 01:02:p, Heinrich Schuchardt wrote:
> On 23.02.21 12:43, Asherah Connor wrote:
> For which architectures does the fw_cfg device exist?
>
> It it is only ARM and X86, than I am missing such a dependency on
> CONFIG_CMD_QFW.
Right now we have:
a
On 21/02/23 06:02:p, Tom Rini wrote:
> Ah well, so my experiment would likely have not worked back then anyhow
> (but I don't recall seeing an error at the time). Anyhow, for now in
> U-Boot as there's not a generic QEMU symbol, this side of things should
> depend on ARM||X86 for now and let
On 21/02/23 11:02:p, Tom Rini wrote:
> On Tue, Feb 23, 2021 at 05:15:49PM +0100, Heinrich Schuchardt wrote:
> > On 2/23/21 5:03 PM, Tom Rini wrote:
> > > On Tue, Feb 23, 2021 at 04:54:45PM +0100, Heinrich Schuchardt wrote:
> > > > qemu-system-riscv64 does not allow me to specify a file for the qfw
On 21/02/23 10:02:p, Asherah Connor wrote:
> We minimally exercise the sandbox driver.
It looks like the test in QEMU is pretty trivial. I'll include it in
the next series version, but here's what it looks like. New tests have
been tested as passing against qemu_arm, qemu_arm64, qemu-
We minimally exercise the sandbox driver.
Signed-off-by: Asherah Connor
---
(no changes since v1)
arch/sandbox/dts/sandbox.dtsi | 4 ++
arch/sandbox/dts/test.dts | 4 ++
drivers/misc/Makefile | 11 ++-
drivers/misc/qfw_sandbox.c| 129
There's a mixture of "qemu_fwcfg_"-prefixed functions and
"qfw_"-prefixed ones. Now that the qfw name is applied in multiple
places (i.e. the uclass itself, and each of its drivers), let's
consistently use the prefix "qfw_" for anything relating to the
drivers.
Split the qfw driver into qfw_pio and qfw_mmio, under their own uclass.
Each driver does arch/platform-specific I/O.
Signed-off-by: Asherah Connor
---
Changes in v3:
- Add new UCLASS_QFW, split qfw driver into PIO and MMIO variants.
- QFW no longer depends on or selects MISC.
arch/x86/cpu
Updates the QFW driver to use the driver model, and adds support for QFW
on Arm platforms by configuring from the device tree and using MMIO
accordingly. A sandbox driver for QFW is also included, and a simple DM
unit test for it.
Signed-off-by: Asherah Connor
---
Changes in v3:
- ARCH_QEMU
Changes in v3:
- ARCH_QEMU now implies CMD_QFW, not QFW
- rename qemu_fwcfg_read_entry_pio to ..._io
Asherah Connor (4):
arm: x86: qemu: move qfw to DM, include Arm support
arm: x86: qemu: add UCLASS_QFW, split driver into _pio and _mmio
arm: x86: qemu: unify qfw driver functions as qfw_
On 21/02/22 10:02:p, Tom Rini wrote:
> As Stephen is no longer actively maintaining the uboot-test-hooks
> repository, switch to using the instance on our GitLab.
We may also want to update the Contributing.md in the u-boot-test-hooks
repository:
Hi Simon,
I should've replied to this earlier.
On 21/02/20 04:02:p, Simon Glass wrote:
> The cros_ec driver has different transports for the actual comms, so
> it might be useful as an example.
This was extremely helpful to reference, thank you.
> What is a ramfb?
ramfb is a qemu-specific
Hi Tom, Simon;
On 21/02/20 05:02:p, Tom Rini wrote:
> On Sat, Feb 20, 2021 at 04:54:41AM -0700, Simon Glass wrote:
> > Probably create a uclass. I expect there are operations and some
> > private data. We also need to think about testing, since all uclasses
> > need a sandbox test.
>
> Well,
On 21/02/20 04:02:p, Asherah Connor wrote:
> Updates the QFW driver to use the driver model, and adds support for QFW
> on Arm platforms by configuring from the device tree and using MMIO
> accordingly.
>
> Signed-off-by: Asherah Connor
> ---
>
> (no changes since v
Updates the QFW driver to use the driver model, and adds support for QFW
on Arm platforms by configuring from the device tree and using MMIO
accordingly.
Signed-off-by: Asherah Connor
---
(no changes since v1)
arch/arm/Kconfig | 1 +
arch/x86/cpu/qemu/cpu.c | 7 +-
arch/x86/cpu
misc/qfw.c
(no changes since v1)
Asherah Connor (1):
arm: x86: qemu: move qfw to DM, include Arm support
arch/arm/Kconfig | 1 +
arch/x86/cpu/qemu/cpu.c | 7 +-
arch/x86/cpu/qemu/qemu.c | 54 ++--
arch/x86/cpu/qfw_cpu.c | 11 +-
cmd/qfw.c| 44 +++---
dr
Hello Heinrich,
On 21/02/19 06:02:p, Heinrich Schuchardt wrote:
> virtio-gpu is an alternative to ramfb. Why are you targeting ramfb and
> not virtio-gpu? Which impact does it have on the guest OS?
It happens to be what I'm already using, and the interface appears quite
simple. I am hacking on
On 21/02/19 06:02:p, Heinrich Schuchardt wrote:
> drivers/misc/qfw.c should be converted to the driver model instead of
> initializing the driver in arch_early_init_r() on qemu-arm and
> qemu_chipset_init() on qemu-x86.
>
> Cf. https://u-boot.readthedocs.io/en/latest/driver-model/index.html
>
>
Adds support for QFW on Arm platforms by checking the device tree for a
"qemu,fw-cfg-mmio"-compatible node in arch_early_init_r and initialising
the driver if found. Both MMIO and DMA are supported on this
architecture.
Signed-off-by: Asherah Connor
---
arch/arm/Kconfig
rrently
considered "hidden" and only selected when "CMD_QFW" is.
* I would be happy to maintain this going forward. Let me know if I
should submit a patch for MAINTAINTERS.
Asherah Connor (1):
arm: qemu: support qfw
arch/arm/Kconfig| 1 +
arch/arm/Makefi
Hi Heinrich. Thanks for the review!
On 21/02/09 07:02:p, Heinrich Schuchardt wrote:
> Thank you for reporting and addressing the issue.
>
> Is this patch related to an observed problem or is it resulting from
> code review?
Yes, this was seen in action (and took quite a bit of logging and
et in some other section, since we load sections in reverse order
and sections are usually laid out sequentially.
Signed-off-by: Asherah Connor
CC: Heinrich Schuchardt
---
lib/efi_loader/efi_image_loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_imag
60 matches
Mail list logo
