Re: [PATCH] nokia_rx51: disable obsolete VIDEO config

2020-10-18 Thread Tom Rini
On Sun, Oct 18, 2020 at 10:59:36PM +0200, Pali Rohár wrote: > On Sunday 18 October 2020 22:54:41 Anatolij Gustschin wrote: > > If you need video console support, then please convert to DM_VIDEO. > > Ok, but I'm waiting until other N900 issues are fixed. There are pending > patches which needs to

Re: [PATCH 1/1] Makefile: consistent include path for out of tree build

2020-10-17 Thread Tom Rini
On Sat, Oct 17, 2020 at 07:57:31PM +0200, Heinrich Schuchardt wrote: > On 10/17/20 6:49 PM, Tom Rini wrote: > > On Sat, Oct 17, 2020 at 06:42:53PM +0200, Heinrich Schuchardt wrote: > > > >> When compiling path/foo.c, we should not add -I$(scr_tree)/path to the gcc >

Re: [PATCH 1/1] Makefile: consistent include path for out of tree build

2020-10-17 Thread Tom Rini
On Sat, Oct 17, 2020 at 06:42:53PM +0200, Heinrich Schuchardt wrote: > When compiling path/foo.c, we should not add -I$(scr_tree)/path to the gcc > flags. Otherwise we get different build results for in tree and out of tree > builds. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH] test: Fix sandbox tests failing to build

2020-10-17 Thread Tom Rini
On Tue, Oct 13, 2020 at 03:20:52PM -0400, Sean Anderson wrote: > syslog_test.h is in test/log/, not include/ > > Fixes: 52d3df7fef ("log: Allow LOG_DEBUG to always enable log output") > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [BUG] sandbox_defconfig fails to build with origin/master dadc1e38306b1c3

2020-10-17 Thread Tom Rini
On Sat, Oct 17, 2020 at 02:46:27PM +0200, Heinrich Schuchardt wrote: > On 10/17/20 2:15 PM, Tom Rini wrote: > > On Sat, Oct 17, 2020 at 01:43:25PM +0200, Heinrich Schuchardt wrote: > >> Hello Tom, hello Simon, > >> > >> make sandbox_defconfig > >>

Re: [BUG] sandbox_defconfig fails to build with origin/master dadc1e38306b1c3

2020-10-17 Thread Tom Rini
On Sat, Oct 17, 2020 at 01:43:25PM +0200, Heinrich Schuchardt wrote: > Hello Tom, hello Simon, > > make sandbox_defconfig > make V=1 > > yields: > > make -f ./scripts/Makefile.build obj=test/log > gcc -Wp,-MD,test/log/.syslog_test.o.d -nostdinc -isystem >

Re: Please pull u-boot-marvell/master

2020-10-16 Thread Tom Rini
On Fri, Oct 16, 2020 at 03:40:46PM +0200, Stefan Roese wrote: > Hi Tom, > > please pull an update of Marvell Octeon TX/TX2 related patches. Here the > summary log: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] libfdt: Fix signedness comparison warnings

2020-10-16 Thread Tom Rini
On Fri, Oct 16, 2020 at 10:57:19AM -0400, Tom Rini wrote: > On Fri, Oct 16, 2020 at 03:42:50PM +0100, Andre Przywara wrote: > > > This is a combination of upstream libfdt commits to fix warnings about > > comparing signed and unsigned integers: > > == >

Re: [PATCH] libfdt: Fix signedness comparison warnings

2020-10-16 Thread Tom Rini
On Fri, Oct 16, 2020 at 03:42:50PM +0100, Andre Przywara wrote: > This is a combination of upstream libfdt commits to fix warnings about > comparing signed and unsigned integers: > == > scripts/dtc/libfdt/fdt.c: In function ‘fdt_offset_ptr’: > scripts/dtc/libfdt/fdt.c:137:18: warning:

Re: [PATCH 16/16] dm: Don't undefine dev_xxx macros

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:57PM -0400, Sean Anderson wrote: > Now that linux/compat.h does not define these macros, we do not need to > undefine them. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 15/16] linux/compat.h: Remove redefinition of dev_xxx macros

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:56PM -0400, Sean Anderson wrote: > All users of these functions now include dm/device_compat.h directly. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/3] usb: dwc3: Include device_compat.h in dwc3-octeon-glue.c

2020-10-16 Thread Tom Rini
On Fri, Oct 16, 2020 at 08:42:46AM -0400, Tom Rini wrote: > Necessary for dev_xxx. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/3] clk: at91: Include device_compat.h in compat.c

2020-10-16 Thread Tom Rini
On Fri, Oct 16, 2020 at 08:42:45AM -0400, Tom Rini wrote: > Necessary for dev_xxx. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 11/16] timer: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:52PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/3] arm: fsl-layerscape: Include device_compat.h in soc.c

2020-10-16 Thread Tom Rini
On Fri, Oct 16, 2020 at 08:42:44AM -0400, Tom Rini wrote: > Necessary for dev_xxx. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 13/16] usb: musb-new: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:54PM -0400, Sean Anderson wrote: > This was included, but was ifdef'd out. We also need dm.h for struct > udevice. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 10/16] tee: optee: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:51PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 12/16] usb: xhci: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:53PM -0400, Sean Anderson wrote: > This header is necessary for the dev_xxx macros. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 14/16] usb: musb-new: mt85xx: Fix not calling dev_err with a device

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:55PM -0400, Sean Anderson wrote: > This driver doesn't use DM (in the correct places), so we use a device and > not a udevice. We also need to include device_compat.h > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 08/16] spi: nxp_fspi: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:49PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 07/16] ram: imxrt: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:48PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 06/16] phy: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:47PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 09/16] spi: fsl_qspi: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:50PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 03/16] firmware: scmi: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:44PM -0400, Sean Anderson wrote: > This header is necessary for the dev_xxx macros. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 02/16] dm: syscon: Set LOG_CATEGORY

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:43PM -0400, Sean Anderson wrote: > We call log_debug, but do not have a category set. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 01/16] clk: sifive: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:42PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 04/16] mtd: mxs_nand: Fix not calling dev_xxx with a device

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:45PM -0400, Sean Anderson wrote: > This includes device_compat.h, and fixes several calls to dev_xxx. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 05/16] net: ldpaa_eth: Include device_compat.h

2020-10-16 Thread Tom Rini
On Sun, Oct 04, 2020 at 09:39:46PM -0400, Sean Anderson wrote: > Necessary for dev_xxx. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH 1/3] arm: fsl-layerscape: Include device_compat.h in soc.c

2020-10-16 Thread Tom Rini
Necessary for dev_xxx. Signed-off-by: Tom Rini --- arch/arm/cpu/armv8/fsl-layerscape/soc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c index ba42c185c47d..96b2775f3f98 100644 --- a/arch/arm/cpu/armv8/fsl

[PATCH 3/3] usb: dwc3: Include device_compat.h in dwc3-octeon-glue.c

2020-10-16 Thread Tom Rini
Necessary for dev_xxx. Signed-off-by: Tom Rini --- drivers/usb/host/dwc3-octeon-glue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/dwc3-octeon-glue.c b/drivers/usb/host/dwc3-octeon-glue.c index 39b318561634..c3cac9c5abdb 100644 --- a/drivers/usb/host/dwc3-octeon-glue.c

[PATCH 2/3] clk: at91: Include device_compat.h in compat.c

2020-10-16 Thread Tom Rini
Necessary for dev_xxx. Signed-off-by: Tom Rini --- drivers/clk/at91/compat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/at91/compat.c b/drivers/clk/at91/compat.c index 8cf6254046dd..9563285674b3 100644 --- a/drivers/clk/at91/compat.c +++ b/drivers/clk/at91/compat.c @@ -9,6

Re: [PATCH] lib: zlib: Use post-increment only in inffast.c

2020-10-16 Thread Tom Rini
On Fri, Oct 16, 2020 at 04:40:00AM +0800, Ley Foon Tan wrote: > On Fri, Jul 17, 2020 at 9:29 PM Tom Rini wrote: > > > > On Wed, Jun 24, 2020 at 04:34:03PM +0800, Ley Foon Tan wrote: > > > > > From: Chin Liang See > > > > > > This fixes CVE-2016

Re: Missing license/copyright notice in zlib.h

2020-10-15 Thread Tom Rini
On Thu, Oct 15, 2020 at 03:33:20AM +, Tan, Ley Foon wrote: > Hi Mike > > All *.c and *.h files under > https://gitlab.denx.de/u-boot/u-boot/-/blob/master/lib/zlib/ have header > statement "For conditions of distribution and use, see copyright notice in > zlib.h". But, there is no

Re: Please pull mmc-2020-10-14

2020-10-15 Thread Tom Rini
On Thu, Oct 15, 2020 at 06:14:41AM +, Peng Fan wrote: > Hi Tom, > > Please pull mmc-2020-10-14 > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-15 Thread Tom Rini
On Wed, Oct 14, 2020 at 11:39:40PM +0300, Alper Nebi Yasak wrote: > On 14/10/2020 22:31, Tom Rini wrote: > > On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: > >> On 14/10/2020 18:24, Tom Rini wrote: > >>> Ugh. In so far as anything can

Re: fatal error: Python.h: No such file or directory

2020-10-15 Thread Tom Rini
On Thu, Oct 15, 2020 at 09:32:52AM +, Peng Fan wrote: > All: > > When select BINMAN, I met error. > fatal error: Python.h: No such file or directory > > I am using openSUSE, python files are installed under /usr/include/python3.8 > > After I " export C_INCLUDE_PATH=/usr/include/python3.8",

Re: Please pull u-boot-marvell/master

2020-10-14 Thread Tom Rini
On Wed, Oct 14, 2020 at 10:19:26AM +0200, Stefan Roese wrote: > Hi Tom, > > please pull the first series of Marvell MVEBU related patches. Here the > summary log: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Tom Rini
On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: > On 14/10/2020 18:24, Tom Rini wrote: > > On Tue, Oct 13, 2020 at 09:54:55AM -0600, Simon Glass wrote: > >> I think it is OK to change the file to GPL2. I'm not sure if changing > >> coreboot parts to 2

Re: [PATCH v5 2/3] test: Add PStore command tests

2020-10-14 Thread Tom Rini
ff-by: Frédéric Danis > Cc: Tom Rini > Cc: Heinrich Schuchardt > Cc: Wolfgang Denk > Cc: Heiko Schocher With the test files supplied off-list and some minor changes to ensure it works reliably with separate source/build/run directories: Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2] net: e1000: add defaults for i210 TX/RX PBSIZE

2020-10-14 Thread Tom Rini
On Tue, Oct 06, 2020 at 04:08:35PM +0200, Christian Gmeiner wrote: > Set the defaults on probe for the packet buffer size registers > for the i210. > > The TX/RX PBSIZE register of the i210 resets to its default value > only at power-on - see Intel Ethernet Controller I210 Datasheet rev 3.5 >

Re: [PATCH v2] doc: Sphinx.override_domain() deprecated

2020-10-14 Thread Tom Rini
On Tue, Oct 06, 2020 at 05:56:59PM +0200, Heinrich Schuchardt wrote: > Sphinx.override_domain() is deprecated since Sphinx 1.8 and removed in > Sphinx 3. > > Use Sphinx.add_domain(, override=True) instead. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v5 3/3] cmd: Fixup DT to pass PStore Ramoops parameters

2020-10-14 Thread Tom Rini
> Signed-off-by: Frédéric Danis > Cc: Tom Rini > Cc: Heinrich Schuchardt > Cc: Wolfgang Denk > Cc: Heiko Schocher Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v5 1/3] cmd: Add command to display or save Linux PStore dumps

2020-10-14 Thread Tom Rini
nly 1st FTrace log is displayed or saved > > Signed-off-by: Frédéric Danis > Cc: Tom Rini > Cc: Heinrich Schuchardt > Cc: Wolfgang Denk > Cc: Heiko Schocher Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/2] treewide: Fix wrong CONFIG_IS_ENABLED() handling

2020-10-14 Thread Tom Rini
On Mon, Oct 05, 2020 at 09:57:29AM +0300, Alper Nebi Yasak wrote: > CONFIG_IS_ENABLED() takes the kconfig name without the CONFIG_ prefix, > e.g. CONFIG_IS_ENABLED(CLK) for CONFIG_CLK. Some of these were being > fixed every now and then, see: > > commit 71ba2cb0d678 ("board: stm32mp1:

Re: [PATCH v2 2/2] checkpatch.pl: Make CONFIG_IS_ENABLED(CONFIG_*) an error

2020-10-14 Thread Tom Rini
On Mon, Oct 05, 2020 at 09:57:30AM +0300, Alper Nebi Yasak wrote: > CONFIG_IS_ENABLED() takes the kconfig name without the CONFIG_ prefix, > e.g. CONFIG_IS_ENABLED(CLK) for CONFIG_CLK. Make including the prefix > an error in checkpatch.pl so calls in the wrong format aren't > accidentally

Re: [PATCH v3 1/3] global_data.h: convert GD_FLG_* to enum

2020-10-14 Thread Tom Rini
On Mon, Oct 05, 2020 at 08:30:08AM +0200, Heinrich Schuchardt wrote: > Sphinx documentation is only available for enums not for #defines. > Anyway it is better to keep related definitions in an enum. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master,

Re: [PATCH 2/2] spl: Add SPL_SERIAL as requirement for SDP_USB_SDP

2020-10-14 Thread Tom Rini
On Tue, Sep 29, 2020 at 11:14:29PM -0300, Otavio Salvador wrote: > The USB SDP protocol require the SPL serial support to allow the build > to succeed. > > Signed-off-by: Otavio Salvador Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 2/3] global_data.h: add Sphinx documentation

2020-10-14 Thread Tom Rini
On Mon, Oct 05, 2020 at 08:30:09AM +0200, Heinrich Schuchardt wrote: > Add the missing Sphinx documentation for struct global_data and > gd_board_type(). > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH v3 3/3] doc: global data pointer

2020-10-14 Thread Tom Rini
On Mon, Oct 05, 2020 at 08:30:10AM +0200, Heinrich Schuchardt wrote: > Add the description of the global data pointer to the generated HTML > documentation. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 1/1] bootm: add {arch,board}_preboot_os() to bootm.h

2020-10-14 Thread Tom Rini
On Tue, Sep 15, 2020 at 01:58:11AM +0200, Heinrich Schuchardt wrote: > Functions that are used in multiple C modules should be defined in an > include. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Michael Walle Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH v2 3/3] cmd/button: return button status

2020-10-14 Thread Tom Rini
On Mon, Sep 14, 2020 at 12:50:56PM +0200, Heinrich Schuchardt wrote: > To make the button command useful in a shell script it should return the > status of the button: > > * 0 (true) - pressed, on > * 1 (false) - not pressed, off > > The button command takes only one argument. Correct maxargs.

Re: [PATCH 1/1] arm: enable DM_RNG on QEMU by default

2020-10-14 Thread Tom Rini
On Sat, Sep 19, 2020 at 07:55:35AM +0200, Heinrich Schuchardt wrote: > The EFI_RNG_PROTOCOL is needed for address randomization in Linux. > We should provide it by default on QEMU. > > Reported-by: François Ozog > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v2 1/3] test: sharpen button label unit test

2020-10-14 Thread Tom Rini
On Mon, Sep 14, 2020 at 12:50:54PM +0200, Heinrich Schuchardt wrote: > Using different strings for the device tree node labels and the label > property of buttons sharpens the button label unit test. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Philippe Reynes Applied to

Re: [PATCH v2 2/3] drivers: gpio: keep output value for input on sandbox

2020-10-14 Thread Tom Rini
On Mon, Sep 14, 2020 at 12:50:55PM +0200, Heinrich Schuchardt wrote: > For testing purposes keep the output value when switching to input. > This allows us to manipulate the input value via the gpio command. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Philippe Reynes Applied to

Re: [PATCH] spl: Avoid printing boot device if silent console is enabled

2020-10-14 Thread Tom Rini
On Thu, Sep 03, 2020 at 02:25:15PM -0300, Otavio Salvador wrote: > Signed-off-by: Otavio Salvador > Reviewed-by: Tom Rini > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] cmd: fat: Use do_save() for fatwrite

2020-10-14 Thread Tom Rini
On Tue, Sep 29, 2020 at 08:13:00AM +0100, Lad Prabhakar wrote: > do_save() function defined in fs.c also supports FAT file system > re-use the same for fatwrite command. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das > --- > cmd/fat.c | 43 +--

Re: [PATCH 1/2] mmc: remove duplicate mmc_get_env_dev() implementations

2020-10-14 Thread Tom Rini
On Tue, Aug 04, 2020 at 10:05:46AM +0100, David Woodhouse wrote: > Since it's so trivial I could just about tolerate this when there were only > two copies of it. But now there are about to be three. > > Signed-off-by: David Woodhouse Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 2/2] env/ext4.c: allow loading from an EXT4 partition on the MMC boot device

2020-10-14 Thread Tom Rini
On Tue, Aug 04, 2020 at 10:05:47AM +0100, David Woodhouse wrote: > This parallels what I added for FAT in commit 6731bef6966, allowing the > environment to be found in a specific partition on the device that the > board's mmc_get_env_dev() returns. On the Banana Pi R2 that means the > device that

Re: [PATCH v2] time: Fix get_ticks being non-monotonic

2020-10-14 Thread Tom Rini
On Wed, Sep 09, 2020 at 04:24:56PM -0400, Sean Anderson wrote: > get_ticks does not always succeed. Sometimes it can be called before the > timer has been initialized. If it does, it returns a negative errno. > This causes the timer to appear non-monotonic, because the value will > become much

Re: [PATCH V2 00/12] imx: doc update

2020-10-14 Thread Tom Rini
On Wed, Oct 14, 2020 at 05:11:58PM +0800, Peng Fan wrote: > V2: > Migrate README to doc/board/freescale > patch 1 is not changed. Thanks for doing this! -- Tom signature.asc Description: PGP signature

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-14 Thread Tom Rini
s for that [1]), but the license > > difference makes it difficult. Could the coreboot parts be relicensed to > > GPL-2.0+ by Google and/or Rockchip? Alternatively, is it OK to change > > the U-Boot one to GPL-2.0-only to sync things from coreboot? > > I think it is OK to

Re: [PATCH v5 2/3] test: Add PStore command tests

2020-10-13 Thread Tom Rini
On Tue, Oct 13, 2020 at 02:03:46PM -0400, Tom Rini wrote: > On Tue, Oct 13, 2020 at 06:35:51PM +0200, Frédéric Danis wrote: > > Hi Tom, > > > > On 13/10/2020 17:48, Tom Rini wrote: > > > On Fri, Mar 20, 2020 at 10:59:23AM +0100, Frédéric Danis wrote: > > >

Re: [PATCH v5 2/3] test: Add PStore command tests

2020-10-13 Thread Tom Rini
On Tue, Oct 13, 2020 at 06:35:51PM +0200, Frédéric Danis wrote: > Hi Tom, > > On 13/10/2020 17:48, Tom Rini wrote: > > On Fri, Mar 20, 2020 at 10:59:23AM +0100, Frédéric Danis wrote: > > > > > Add PStore command to sandbox and sandbox64 defconfigs. > >

Re: [PATCH v5 2/3] test: Add PStore command tests

2020-10-13 Thread Tom Rini
ff-by: Frédéric Danis > Cc: Tom Rini > Cc: Heinrich Schuchardt > Cc: Wolfgang Denk > Cc: Heiko Schocher > --- > Changes in v5: > - Fix test_pstore.py license > > Changes in v4: > - Fix PStore memory address in sandbox defconfig files for tests > > Changes

Re: [PATCH 1/2] fit: cipher: aes: allow to store the IV in the FIT image

2020-10-13 Thread Tom Rini
On Thu, Sep 17, 2020 at 03:01:46PM +0200, Philippe Reynes wrote: > Binaries may be encrypted in a FIT image with AES. This > algo needs a key and an IV (Initialization Vector). The > IV is provided in a file (pointer by iv-name-hint in the > ITS file) when building the ITB file. > > This commits

Re: [PATCH 1/1] rsa: fix retrieving public exponent on big-endian systems

2020-10-13 Thread Tom Rini
On Tue, Oct 06, 2020 at 12:09:45PM +0200, Rasmus Villemoes wrote: > Commit fdf0819afb (rsa: fix alignment issue when getting public > exponent) changed the logic to avoid doing an 8-byte access to a > possibly-not-8-byte-aligned address. > > However, using rsa_convert_big_endian is wrong: That

Re: [PATCH 1/1] lib/hashtable: remove superfluous check

2020-10-13 Thread Tom Rini
On Thu, Aug 20, 2020 at 07:57:45PM +0200, Heinrich Schuchardt wrote: > We assign first_deleted = 0. There is no need to check its value without > any further assignment in between. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/1] lib: rsa: superfluous initialization in rsa_verify()

2020-10-13 Thread Tom Rini
On Thu, Oct 08, 2020 at 08:53:13PM +0200, Heinrich Schuchardt wrote: > Remove initialization of ret with unused value. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/2] fit: cipher: aes: allow to read the IV in the FIT image

2020-10-13 Thread Tom Rini
On Thu, Sep 17, 2020 at 03:01:47PM +0200, Philippe Reynes wrote: > This commit add the support in u-boot to read the IV > in the FIT image instead of u-boot device tree. > > Signed-off-by: Philippe Reynes Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v3 3/3] doc: verified-boot: add required-mode information

2020-10-13 Thread Tom Rini
On Sun, Aug 16, 2020 at 11:01:11PM -0700, Thirupathaiah Annapureddy wrote: > Add documentation about 'required-mode' property in /signature node > in U-Boot's control FDT. > > Signed-off-by: Thirupathaiah Annapureddy > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] lib: rsa: check algo match in rsa_verify_with_keynode

2020-10-13 Thread Tom Rini
On Wed, Sep 23, 2020 at 07:11:44PM +0200, Matthieu CASTET wrote: > The algo name should match between the FIT's signature node and the > U-Boot's control FDT. > > If we do not check it, U-Boot's control FDT can expect sha512 hash but > nothing will prevent to accept image with sha1 hash if the

Re: [PATCH v3 2/3] test: vboot: add tests for multiple required keys

2020-10-13 Thread Tom Rini
On Sun, Aug 16, 2020 at 11:01:10PM -0700, Thirupathaiah Annapureddy wrote: > This patch adds vboot tests to verify the support for multiple > required keys using new required-mode DTB policy. > > This patch also fixes existing test where dev > key is assumed to be marked as not required,

Re: [PATCH v3 1/3] vboot: add DTB policy for supporting multiple required conf keys

2020-10-13 Thread Tom Rini
On Sun, Aug 16, 2020 at 11:01:09PM -0700, Thirupathaiah Annapureddy wrote: > Currently FIT image must be signed by all required conf keys. This means > Verified Boot fails if there is a signature verification failure > using any required key in U-Boot DTB. > > This patch introduces a new policy

Re: [PATCH] board: imx: address dd usage in README

2020-10-13 Thread Tom Rini
On Mon, Oct 12, 2020 at 02:14:43PM +0800, Peng Fan wrote: > When using cygwin64 "dd (coreutils) 8.26 Packaged by Cygwin (8.26-2)", > the last not 512bytes aligned data wat cut off and not burned into SD > card. > > Saying the flash.bin size is 1085608 bytes, not 512bytes aligned. It only >

Re: [GIT PULL] SoCFPGA changes for v2021.01-rc1

2020-10-12 Thread Tom Rini
On Mon, Oct 12, 2020 at 10:12:12AM +, Tan, Ley Foon wrote: > Hi Tom > > Please pull the SoCFPGA changes for 2021.01. > > Travis CI build: https://travis-ci.org/github/lftan/u-boot/builds/734245377 > > Thanks. > Regards > Ley Foon > > The following changes since commit

Re: [GIT PULL] TI changes for v2021.01-rc1

2020-10-12 Thread Tom Rini
On Mon, Oct 12, 2020 at 02:34:27PM +0530, Lokesh Vutla wrote: > Hi Tom, > Please find the PR containing TI related changes targeted for > v2020.01-rc1. Details about the PR are updated in the tag message. > > Travis CI build: >

Re: [PATCH 2/2] am335x_evm: Allow booting from usb-storage device

2020-10-12 Thread Tom Rini
On Fri, Oct 09, 2020 at 09:19:53AM -0400, Tom Rini wrote: > On Sun, Oct 04, 2020 at 02:23:21PM +0300, Matwey V. Kornilov wrote: > > > > Ping? and I see this was applied back in September to the -next branch, so this is in master now. > > > > пн, 24 авг. 2020 г.

Re: [PATCH 1/1] rsa: fix retrieving public exponent on big-endian systems

2020-10-12 Thread Tom Rini
On Mon, Oct 12, 2020 at 09:04:28AM +0200, Rasmus Villemoes wrote: > On 09/10/2020 15.08, Tom Rini wrote: > > On Wed, Oct 07, 2020 at 12:17:56AM +0200, Rasmus Villemoes wrote: > >> On 07/10/2020 00.02, Simon Glass wrote: > >>> > >>> Reviewed-by: Simon Glass

Re: [PATCH v2] log: Allow LOG_DEBUG to always enable log output

2020-10-11 Thread Tom Rini
On Sun, Sep 27, 2020 at 09:55:34AM -0600, Simon Glass wrote: > At present if CONFIG_LOG enabled, putting LOG_DEBUG at the top of a file > (before log.h inclusion) causes _log() to be executed for every log() > call, regardless of the build- or run-time logging level. > > However there is no

Re: [PATCH 2/4] log: Drop #ifdef in log_test

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 12:28:48PM -0600, Simon Glass wrote: > This is not needed as the Makefile only builds the file if CONFIG_LOG_TEST > is enabled. Drop it. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/4] log: Add a way to enable/disable a log device

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 12:28:49PM -0600, Simon Glass wrote: > At present all log devices are enabled by default. Add a function to allow > devices to be disabled or enabled at runtime. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 1/1] doc: remove redundant doc/README.log

2020-10-11 Thread Tom Rini
On Mon, Sep 14, 2020 at 10:12:19AM +0200, Heinrich Schuchardt wrote: > doc/README.log was already moved to doc/develop/logging.rst but has been > recreated by an incorrect merge. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 4/4] log: Disable the syslog driver by default

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 12:28:50PM -0600, Simon Glass wrote: > This driver interferes with other sandbox tests since it causes log output > to be interspersed with "No ethernet found." messages. Disable this driver > by default. > > Enable it for the syslog tests so that they still pass. > >

Re: [PATCH 3/3] log: syslog: Handle errors in net_init

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 05:45:44PM -0400, Sean Anderson wrote: > Since the previous patch, net_init now exposes some errors, so check for > them. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/3] net: Expose some errors generated in net_init

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 05:45:43PM -0400, Sean Anderson wrote: > net_init does not always succeed, and there is no existing mechanism to > discover errors. This patch allows callers of net_init (such as net_init) > to handle errors. The root issue is that eth_get_dev can fail, but > net_init_loop

Re: [PATCH v2 1/2] log: Allow LOG_DEBUG to always enable log output

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 11:13:34AM -0600, Simon Glass wrote: > At present if CONFIG_LOG enabled, putting LOG_DEBUG at the top of a file > (before log.h inclusion) causes _log() to be executed for every log() > call, regardless of the build- or run-time logging level. > > However there is no

Re: [PATCH 1/4] log: Add a flag to enable log drivers

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 12:28:47PM -0600, Simon Glass wrote: > At present there is no way to disable a log driver. But the syslog driver > causes (attempted) network traffic in sandbox every time a log message > is printed, which is often. > > Add a flag to enable a log driver. Adjust struct

Re: [PATCH v2 2/2] lib: Allow hexdump to be used in SPL

2020-10-11 Thread Tom Rini
On Sat, Sep 12, 2020 at 11:13:35AM -0600, Simon Glass wrote: > It is sometimes useful to output hex dumps in SPL. Add a config option to > allow this. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 2/2] test: log: test message continuation

2020-10-10 Thread Tom Rini
On Sat, Oct 10, 2020 at 05:47:26PM -0400, Sean Anderson wrote: > On 10/10/20 5:28 PM, Tom Rini wrote: > > On Thu, Sep 17, 2020 at 02:19:02PM +0200, Heinrich Schuchardt wrote: > > > >> Provide a unit test checking that a continuation message will use the same > &g

Re: [PATCH 2/2] test: log: test message continuation

2020-10-10 Thread Tom Rini
On Thu, Sep 17, 2020 at 02:19:02PM +0200, Heinrich Schuchardt wrote: > Provide a unit test checking that a continuation message will use the same > log level and log category as the previous message. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass [snip] > +

Re: [PATCH 00/16] Kconfig: Tidy up the top-level kconfig menu

2020-10-09 Thread Tom Rini
On Thu, Sep 10, 2020 at 08:21:11PM -0600, Simon Glass wrote: > At present this menu is pretty messy, with quite a few minor options shown > at the top level. This series creates a few new menus and moves things > around so that the top-level menu is cleaner. > > There is more to do, but this is

Re: [PATCH] common, autoboot: sync functionality with Kconfig description

2020-10-09 Thread Tom Rini
On Wed, Oct 07, 2020 at 08:06:54AM +0200, Heiko Schocher wrote: > add back again special case: -2 > autoboot with no delay and no check for abort > > as described in Kconfig option, see common/Kconfig > help text for option BOOTDELAY. > > Signed-off-by: Heiko Schocher

Re: [PATCH 2/2] am335x_evm: Allow booting from usb-storage device

2020-10-09 Thread Tom Rini
; #if CONFIG_IS_ENABLED(CMD_PXE) > > # define BOOT_TARGET_PXE(func) func(PXE, pxe, na) > > #else > > @@ -84,6 +90,7 @@ > > func(MMC, mmc, 1) \ > > func(LEGACY_MMC, legacy_mmc, 1) \ > > func(NAND, nand, 0) \ > > + BOOT_TARGET_USB(func) \ > > BOOT_TARGET_PXE(func) \ > > BOOT_TARGET_DHCP(func) Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH] Define default CONFIG_PREBOOT with right config option

2020-10-09 Thread Tom Rini
On Wed, Oct 07, 2020 at 08:37:57AM +, Patrick DELAUNAY wrote: > Hi, > > > From: U-Boot On Behalf Of Peter Robinson > > Sent: mardi 29 septembre 2020 11:48 > > > > The 44758771ee commit removes CONFIG_PREBOOT but actually sets the > > USE_PREBOOT Kconfig option which isn't CONFIG_PREBOOT and

Re: [PATCH 1/1] rsa: fix retrieving public exponent on big-endian systems

2020-10-09 Thread Tom Rini
On Wed, Oct 07, 2020 at 12:17:56AM +0200, Rasmus Villemoes wrote: > On 07/10/2020 00.02, Simon Glass wrote: > > Hi Rasmus, > > > > On Tue, 6 Oct 2020 at 04:10, Rasmus Villemoes > > wrote: > >> > >> Commit fdf0819afb (rsa: fix alignment issue when getting public > >> exponent) changed the logic

Re: [PATCH v2 5/6] qemu-arm: Drop ARCH_SUPPORT_TFABOOT

2020-10-09 Thread Tom Rini
tion anymore. > > Signed-off-by: Andre Przywara > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 6/6] qemu-arm64: Enable POSITION_INDEPENDENT

2020-10-09 Thread Tom Rini
On Wed, Sep 30, 2020 at 05:39:18PM +0100, Andre Przywara wrote: > Now that PIE works when U-Boot is started from ROM, let's enable > CONFIG_POSITION_INDEPENDENT, which allows to load U-Boot also via > ARM Trusted-Firmware's fip.bin to DRAM, without tweaking the > configuration. > > To get a

Re: [PATCH v2 4/6] qemu-arm: Remove need to specify flash banks

2020-10-09 Thread Tom Rini
On Wed, Sep 30, 2020 at 05:39:16PM +0100, Andre Przywara wrote: > Currently we hard-code the number and initial addresses of QEMU's flash > banks, even though our code is perfectly able to gather the same > information from the DTB provided by QEMU. > This is especially annoying, since we have

Re: [PATCH v2 3/6] arm64: PIE: Allow fixed stack pointer

2020-10-09 Thread Tom Rini
On Wed, Sep 30, 2020 at 05:39:15PM +0100, Andre Przywara wrote: > Currently selecting CONFIG_POSITION_INDEPENDENT also forces us to use an > initial stack pointer relative to the beginning of the BSS section. > This makes some sense, because this should be writable memory anyway. > > However the

Re: [PATCH] arm: Kconfig: Explain TFABOOT

2020-10-09 Thread Tom Rini
zywara > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

  1   2   3   4   5   6   7   8   9   10   >