RE: [PATCH 4/4] imx: imx8mp_evk: convert to OF_UPSTREAM

2024-03-27 Thread Peng Fan
> Subject: Re: [PATCH 4/4] imx: imx8mp_evk: convert to OF_UPSTREAM
> 
> Hi Peng,
> 
> On Wed, Mar 27, 2024 at 10:27 PM Peng Fan (OSS) 
> wrote:
> 
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -1105,7 +1105,6 @@ dtb-$(CONFIG_ARCH_IMX8M) += \
> > imx8mp-dhcom-pdk2.dtb \
> > imx8mp-dhcom-pdk3.dtb \
> > imx8mp-dhcom-pdk3-overlay-rev100.dtbo \
> > -   imx8mp-evk.dtb \
> 
> Here you removed imx8mp-evk.dtb from the Makefile, which is correct.
> 
> You should do the same on the other patches.

Oh, yes.

> 
> Have you boot-tested all these boards?

Tested imx8m/n/p evk. Not have imx8mq evk at hand. But checked
dts for imx8mq, there is no difference that would affect uboot boot.

Regards,
Peng.


Re: [PATCH 4/4] imx: imx8mp_evk: convert to OF_UPSTREAM

2024-03-27 Thread Fabio Estevam
Hi Peng,

On Wed, Mar 27, 2024 at 10:27 PM Peng Fan (OSS)  wrote:

> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -1105,7 +1105,6 @@ dtb-$(CONFIG_ARCH_IMX8M) += \
> imx8mp-dhcom-pdk2.dtb \
> imx8mp-dhcom-pdk3.dtb \
> imx8mp-dhcom-pdk3-overlay-rev100.dtbo \
> -   imx8mp-evk.dtb \

Here you removed imx8mp-evk.dtb from the Makefile, which is correct.

You should do the same on the other patches.

Have you boot-tested all these boards?


[PATCH 4/4] imx: imx8mp_evk: convert to OF_UPSTREAM

2024-03-27 Thread Peng Fan (OSS)
From: Peng Fan 

Convert to OF_UPSTREAM for i.MX8MP EVK

Signed-off-by: Peng Fan 
---
 arch/arm/dts/Makefile   |   1 -
 arch/arm/dts/imx8mp-evk.dts | 684 
 arch/arm/mach-imx/imx8m/Kconfig |   1 +
 configs/imx8mp_evk_defconfig|   2 +-
 4 files changed, 2 insertions(+), 686 deletions(-)

diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index d85a33055c9..55e9ab0725e 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -1105,7 +1105,6 @@ dtb-$(CONFIG_ARCH_IMX8M) += \
imx8mp-dhcom-pdk2.dtb \
imx8mp-dhcom-pdk3.dtb \
imx8mp-dhcom-pdk3-overlay-rev100.dtbo \
-   imx8mp-evk.dtb \
imx8mp-icore-mx8mp-edimm2.2.dtb \
imx8mp-msc-sm2s.dtb \
imx8mp-phyboard-pollux-rdk.dtb \
diff --git a/arch/arm/dts/imx8mp-evk.dts b/arch/arm/dts/imx8mp-evk.dts
deleted file mode 100644
index 9f1469db554..000
--- a/arch/arm/dts/imx8mp-evk.dts
+++ /dev/null
@@ -1,684 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-/*
- * Copyright 2019 NXP
- */
-
-/dts-v1/;
-
-#include 
-#include "imx8mp.dtsi"
-
-/ {
-   model = "NXP i.MX8MPlus EVK board";
-   compatible = "fsl,imx8mp-evk", "fsl,imx8mp";
-
-   chosen {
-   stdout-path = 
-   };
-
-   gpio-leds {
-   compatible = "gpio-leds";
-   pinctrl-names = "default";
-   pinctrl-0 = <_gpio_led>;
-
-   status {
-   label = "yellow:status";
-   gpios = < 16 GPIO_ACTIVE_HIGH>;
-   default-state = "on";
-   };
-   };
-
-   memory@4000 {
-   device_type = "memory";
-   reg = <0x0 0x4000 0 0xc000>,
- <0x1 0x 0 0xc000>;
-   };
-
-   pcie0_refclk: pcie0-refclk {
-   compatible = "fixed-clock";
-   #clock-cells = <0>;
-   clock-frequency = <1>;
-   };
-
-   reg_can1_stby: regulator-can1-stby {
-   compatible = "regulator-fixed";
-   regulator-name = "can1-stby";
-   pinctrl-names = "default";
-   pinctrl-0 = <_flexcan1_reg>;
-   regulator-min-microvolt = <330>;
-   regulator-max-microvolt = <330>;
-   gpio = < 5 GPIO_ACTIVE_HIGH>;
-   enable-active-high;
-   };
-
-   reg_can2_stby: regulator-can2-stby {
-   compatible = "regulator-fixed";
-   regulator-name = "can2-stby";
-   pinctrl-names = "default";
-   pinctrl-0 = <_flexcan2_reg>;
-   regulator-min-microvolt = <330>;
-   regulator-max-microvolt = <330>;
-   gpio = < 27 GPIO_ACTIVE_HIGH>;
-   enable-active-high;
-   };
-
-   reg_pcie0: regulator-pcie {
-   compatible = "regulator-fixed";
-   pinctrl-names = "default";
-   pinctrl-0 = <_pcie0_reg>;
-   regulator-name = "MPCIE_3V3";
-   regulator-min-microvolt = <330>;
-   regulator-max-microvolt = <330>;
-   gpio = < 6 GPIO_ACTIVE_HIGH>;
-   enable-active-high;
-   };
-
-   reg_usdhc2_vmmc: regulator-usdhc2 {
-   compatible = "regulator-fixed";
-   pinctrl-names = "default";
-   pinctrl-0 = <_reg_usdhc2_vmmc>;
-   regulator-name = "VSD_3V3";
-   regulator-min-microvolt = <330>;
-   regulator-max-microvolt = <330>;
-   gpio = < 19 GPIO_ACTIVE_HIGH>;
-   enable-active-high;
-   };
-};
-
-_0 {
-   cpu-supply = <_arm>;
-};
-
-_1 {
-   cpu-supply = <_arm>;
-};
-
-_2 {
-   cpu-supply = <_arm>;
-};
-
-_3 {
-   cpu-supply = <_arm>;
-};
-
- {
-   pinctrl-names = "default";
-   pinctrl-0 = <_eqos>;
-   phy-mode = "rgmii-id";
-   phy-handle = <>;
-   snps,force_thresh_dma_mode;
-   snps,mtl-tx-config = <_tx_setup>;
-   snps,mtl-rx-config = <_rx_setup>;
-   status = "okay";
-
-   mdio {
-   compatible = "snps,dwmac-mdio";
-   #address-cells = <1>;
-   #size-cells = <0>;
-
-   ethphy0: ethernet-phy@1 {
-   compatible = "ethernet-phy-ieee802.3-c22";
-   reg = <1>;
-   eee-broken-1000t;
-   reset-gpios = < 22 GPIO_ACTIVE_LOW>;
-   reset-assert-us = <1>;
-   reset-deassert-us = <8>;
-   realtek,clkout-disable;
-   };
-   };
-
-   mtl_tx_setup: tx-queues-config {
-   snps,tx-queues-to-use = <5>;
-   snps,tx-sched-sp;
-
-   queue0 {
-   snps,dcb-algorithm;
-   snps,priority = <0x1>;
-   };
-
-