Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Hello Tobias, On 09/21/2015 01:18 AM, Tobias Jakobi wrote: Hello, currently operation on Exynos4412-based Odroid devices is broken. The bootloader stops with this message: Card did not respond to voltage select! *** Warning - MMC init failed, using default environment This series fixes error handling in the s5p sdhci driver and the cause of the issue, which is an inverted card detection check. Thanks goes to Marek Vasut and Sjoerd Simons who helped me on IRC to get this triaged. With best wishes, Tobias Tobias Jakobi (4): exynos: Properly initialize host_caps in s5p_sdhci_core_init() exynos: Fix passing of errors in exynos_mmc_init() exynos: be more verbose in process_nodes() exynos: fix and cleanup do_sdhci_init() drivers/mmc/s5p_sdhci.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) NAK for the series, since the real problem is in device tree parsing, not in s5p_sdhci.c. I will send patches in a moment. Best regards, -- Przemyslaw Marczak Samsung R Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Hi, Tobias, On 09/21/2015 08:00 PM, Tobias Jakobi wrote: > Forgot to ask this: What about the first three patches? Will check and review them. Best Regards, Jaehoon Chung > > - Tobias > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Hello, Jaehoon Chung wrote: > Hi, > > On 09/21/2015 08:18 AM, Tobias Jakobi wrote: >> Hello, >> >> currently operation on Exynos4412-based Odroid devices is broken. >> >> The bootloader stops with this message: >> Card did not respond to voltage select! >> *** Warning - MMC init failed, using default environment > > Which board did you use? and Which cad is failed? SD or eMMC? This is an Odroid-X2. I'm booting from SD with a Sandisk Extreme. I don't have any eMMC here. Actually it was some other person who encountered this issue with his Odroid-X2 and booting from SD. After he made me aware of it, I also updated my u-boot (I was then using a version from May 2015, which works perfectly btw) and encountered the very same issue as him. > Your [PATCH 4/4] is strange..so i want to get more information. For me it restores proper operation of the bootloader to the board. With best wishes, Tobias > > If you can share more information, i can explain more exactly about your > problem. > > Best Regards, > Jaehoon Chung > >> >> This series fixes error handling in the s5p sdhci driver >> and the cause of the issue, which is an inverted card >> detection check. >> >> Thanks goes to Marek Vasut and Sjoerd Simons who helped >> me on IRC to get this triaged. >> >> With best wishes, >> Tobias >> >> Tobias Jakobi (4): >> exynos: Properly initialize host_caps in s5p_sdhci_core_init() >> exynos: Fix passing of errors in exynos_mmc_init() >> exynos: be more verbose in process_nodes() >> exynos: fix and cleanup do_sdhci_init() >> >> drivers/mmc/s5p_sdhci.c | 39 +++ >> 1 file changed, 23 insertions(+), 16 deletions(-) >> > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Forgot to ask this: What about the first three patches? - Tobias ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Dear, Tobias. On 09/21/2015 06:34 PM, Tobias Jakobi wrote: > Hello, > > Jaehoon Chung wrote: >> Hi, >> >> On 09/21/2015 08:18 AM, Tobias Jakobi wrote: >>> Hello, >>> >>> currently operation on Exynos4412-based Odroid devices is broken. >>> >>> The bootloader stops with this message: >>> Card did not respond to voltage select! >>> *** Warning - MMC init failed, using default environment >> >> Which board did you use? and Which cad is failed? SD or eMMC? > This is an Odroid-X2. I'm booting from SD with a Sandisk Extreme. I > don't have any eMMC here. But if your patch is applied, other exynos4412 and exynos using s5p_sdhci don't work fine for SD-card. This case is the specific X2 board. I think schematic is wrong. (I have checked the Odrodd_X-base_Rev_06.pdf) Commonly, SD-detect pin is supplied to always-on power. But odroid-x/u board used the same supplier with I/O line. It's wrong. This is H/W mis-designed problem, not code problem. Well, I will reproduce your problem with X2 board. And if reproduced your problem, I will find other solution, not this. how about? > > Actually it was some other person who encountered this issue with his > Odroid-X2 and booting from SD. After he made me aware of it, I also > updated my u-boot (I was then using a version from May 2015, which works > perfectly btw) and encountered the very same issue as him. > Need to consider other SoC. You seems to consider only Odroid based-on exyno4412. Did you test other exynos4412 board? Best Regards, Jaehoon Chung > > >> Your [PATCH 4/4] is strange..so i want to get more information. > For me it restores proper operation of the bootloader to the board. > > > With best wishes, > Tobias > > >> >> If you can share more information, i can explain more exactly about your >> problem. >> >> Best Regards, >> Jaehoon Chung >> >>> >>> This series fixes error handling in the s5p sdhci driver >>> and the cause of the issue, which is an inverted card >>> detection check. >>> >>> Thanks goes to Marek Vasut and Sjoerd Simons who helped >>> me on IRC to get this triaged. >>> >>> With best wishes, >>> Tobias >>> >>> Tobias Jakobi (4): >>> exynos: Properly initialize host_caps in s5p_sdhci_core_init() >>> exynos: Fix passing of errors in exynos_mmc_init() >>> exynos: be more verbose in process_nodes() >>> exynos: fix and cleanup do_sdhci_init() >>> >>> drivers/mmc/s5p_sdhci.c | 39 +++ >>> 1 file changed, 23 insertions(+), 16 deletions(-) >>> >> > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Hello Jaehoon, Jaehoon Chung wrote: > Dear, Tobias. > > On 09/21/2015 06:34 PM, Tobias Jakobi wrote: >> Hello, >> >> Jaehoon Chung wrote: >>> Hi, >>> >>> On 09/21/2015 08:18 AM, Tobias Jakobi wrote: Hello, currently operation on Exynos4412-based Odroid devices is broken. The bootloader stops with this message: Card did not respond to voltage select! *** Warning - MMC init failed, using default environment >>> >>> Which board did you use? and Which cad is failed? SD or eMMC? >> This is an Odroid-X2. I'm booting from SD with a Sandisk Extreme. I >> don't have any eMMC here. > > But if your patch is applied, other exynos4412 and exynos using s5p_sdhci > don't work fine for SD-card. > This case is the specific X2 board. I think schematic is wrong. > (I have checked the Odrodd_X-base_Rev_06.pdf) > > Commonly, SD-detect pin is supplied to always-on power. > But odroid-x/u board used the same supplier with I/O line. It's wrong. I wouldn't know, I don't even know how to properly read these schematics. > This is H/W mis-designed problem, not code problem. > Well, I will reproduce your problem with X2 board. > And if reproduced your problem, I will find other solution, not this. how > about? Sure, as long as this fixes the issue. Let me know if I can test anything. >> Actually it was some other person who encountered this issue with his >> Odroid-X2 and booting from SD. After he made me aware of it, I also >> updated my u-boot (I was then using a version from May 2015, which works >> perfectly btw) and encountered the very same issue as him. >> > > Need to consider other SoC. You seems to consider only Odroid based-on > exyno4412. > Did you test other exynos4412 board? I have only one ARM board here, which is the Odroid-X2. Nothing else. With best wishes, Tobias > > Best Regards, > Jaehoon Chung > >> >> >>> Your [PATCH 4/4] is strange..so i want to get more information. >> For me it restores proper operation of the bootloader to the board. >> >> >> With best wishes, >> Tobias >> >> >>> >>> If you can share more information, i can explain more exactly about your >>> problem. >>> >>> Best Regards, >>> Jaehoon Chung >>> This series fixes error handling in the s5p sdhci driver and the cause of the issue, which is an inverted card detection check. Thanks goes to Marek Vasut and Sjoerd Simons who helped me on IRC to get this triaged. With best wishes, Tobias Tobias Jakobi (4): exynos: Properly initialize host_caps in s5p_sdhci_core_init() exynos: Fix passing of errors in exynos_mmc_init() exynos: be more verbose in process_nodes() exynos: fix and cleanup do_sdhci_init() drivers/mmc/s5p_sdhci.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) >>> >> >> > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Hi, On 09/21/2015 08:18 AM, Tobias Jakobi wrote: > Hello, > > currently operation on Exynos4412-based Odroid devices is broken. > > The bootloader stops with this message: > Card did not respond to voltage select! > *** Warning - MMC init failed, using default environment Which board did you use? and Which cad is failed? SD or eMMC? Your [PATCH 4/4] is strange..so i want to get more information. If you can share more information, i can explain more exactly about your problem. Best Regards, Jaehoon Chung > > This series fixes error handling in the s5p sdhci driver > and the cause of the issue, which is an inverted card > detection check. > > Thanks goes to Marek Vasut and Sjoerd Simons who helped > me on IRC to get this triaged. > > With best wishes, > Tobias > > Tobias Jakobi (4): > exynos: Properly initialize host_caps in s5p_sdhci_core_init() > exynos: Fix passing of errors in exynos_mmc_init() > exynos: be more verbose in process_nodes() > exynos: fix and cleanup do_sdhci_init() > > drivers/mmc/s5p_sdhci.c | 39 +++ > 1 file changed, 23 insertions(+), 16 deletions(-) > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/4] Fix operation on Odroid devices
Hello, currently operation on Exynos4412-based Odroid devices is broken. The bootloader stops with this message: Card did not respond to voltage select! *** Warning - MMC init failed, using default environment This series fixes error handling in the s5p sdhci driver and the cause of the issue, which is an inverted card detection check. Thanks goes to Marek Vasut and Sjoerd Simons who helped me on IRC to get this triaged. With best wishes, Tobias Tobias Jakobi (4): exynos: Properly initialize host_caps in s5p_sdhci_core_init() exynos: Fix passing of errors in exynos_mmc_init() exynos: be more verbose in process_nodes() exynos: fix and cleanup do_sdhci_init() drivers/mmc/s5p_sdhci.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) -- 2.0.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
