Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Jason Liu
2010/11/17 Stefano Babic sba...@denx.de: On 11/17/2010 08:29 AM, Jason Liu wrote: Agree. But I think the original commit for 128KiB env size has been reviewed on the mail list and no one against it. This does not mean that we cannot change this value when we find it is wrong As Wofgang

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Wolfgang Denk
Dear Jason Liu, In message aanlktikso-fairdbtsevxos6e3u2imp5df-wrm3nm...@mail.gmail.com you wrote: OK, I will set it to 8KiB for mx51evk. You are falling from one extreme into the next one. Why not using 16 KiB as suggested? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Scott Wood
On Wed, 17 Nov 2010 08:42:16 +0100 Wolfgang Denk w...@denx.de wrote: Dear Jason Liu, In message aanlktim4k-pnufdgwvyj3ty4mtlcz7uzy1-to9vex...@mail.gmail.com you wrote: So, I keep the same setting. If I change it, some guys main complain why it change, it will make it incompatible with

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Wolfgang Denk
Dear Scott Wood, In message 20101117152851.767ec...@udp111988uds.am.freescale.net you wrote: So, I keep the same setting. If I change it, some guys main complain why it change, it will make it incompatible with the original env setting and make the customer env lost. I missed that

[U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Jason Liu
fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0 Signed-off-by: Jason Liu r64...@freescale.com --- include/configs/mx51evk.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Stefano Babic
On 11/16/2010 09:41 AM, Jason Liu wrote: Hi Jason, fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0 -#define CONFIG_ENV_SECT_SIZE(128 * 1024) -#define CONFIG_ENV_SIZE

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Jason Liu
2010/11/17 Stefano Babic sba...@denx.de: On 11/16/2010 09:41 AM, Jason Liu wrote: Hi Jason, fix saveenv or env save command not work on mx51evk board. with this patch, we can use savenv or env save to store enviroments to mmc card slot 0 -#define CONFIG_ENV_SECT_SIZE    (128 * 1024)

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Wolfgang Denk
Dear Jason Liu, In message aanlktikb6nytdz=4cmr_rduhvxqjta9zukaed+vw4...@mail.gmail.com you wrote: I set it according to the following reason, - Keep the same setting as the original when you commit the mx51 support patch. Why you select 128KB? :) Copying settings without reflecting if

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Jason Liu
2010/11/17 Wolfgang Denk w...@denx.de: Dear Jason Liu, In message aanlktikb6nytdz=4cmr_rduhvxqjta9zukaed+vw4...@mail.gmail.com you wrote:  I set it according to the following reason, - Keep the same setting as the original when you commit the mx51 support patch. Why you select 128KB? :)

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Wolfgang Denk
Dear Jason Liu, In message aanlktim4k-pnufdgwvyj3ty4mtlcz7uzy1-to9vex...@mail.gmail.com you wrote: Agree. But I think the original commit for 128KiB env size has been reviewed on the mail list and no one against it. Nobody claims 100.0% coverage in a review. Sometimes such things slip

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Stefano Babic
On 11/17/2010 02:44 AM, Jason Liu wrote: I set it according to the following reason, - Keep the same setting as the original when you commit the mx51 support patch. Why you select 128KB? :) No idea, I cannot remember, probably I missed the point. When I commit the mx51 stuff, there is no

Re: [U-Boot] [PATCH 1/1] mx51evk: savenv or env save command does not work

2010-11-16 Thread Stefano Babic
On 11/17/2010 08:29 AM, Jason Liu wrote: Agree. But I think the original commit for 128KiB env size has been reviewed on the mail list and no one against it. This does not mean that we cannot change this value when we find it is wrong And as I said previously, the value had no effect