Re: [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS

2018-08-17 Thread Igor Opaniuk
Hi Eugeniu, Makes sense, thanks for the explanation. Reviewed-by: Igor Opaniuk On 16 August 2018 at 21:25, Eugeniu Rosca wrote: > Hi Igor, > > First, thanks for the reviews! > > On Thu, Aug 16, 2018 at 11:38:18AM +0300, Igor Opaniuk wrote: >> Hi Eugeniu, >> >> Why not keep all dependencies on

Re: [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS

2018-08-16 Thread Eugeniu Rosca
Hi Igor, First, thanks for the reviews! On Thu, Aug 16, 2018 at 11:38:18AM +0300, Igor Opaniuk wrote: > Hi Eugeniu, > > Why not keep all dependencies on the same line in this case? Simply: > depends LIBAVB && FASTBOOT && PARTITION_UUIDS I guess it's a matter of personal preference (but maybe

Re: [U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS

2018-08-16 Thread Igor Opaniuk
Hi Eugeniu, Why not keep all dependencies on the same line in this case? Simply: depends LIBAVB && FASTBOOT && PARTITION_UUIDS Regards, Igor On 14 August 2018 at 03:43, Eugeniu Rosca wrote: > Avoid below compiler [1] errors, reproduced with configuration [2]: > > common/avb_verify.c: In

[U-Boot] [PATCH 3/7] common: kconfig: Mark AVB_VERIFY as dependent on PARTITION_UUIDS

2018-08-13 Thread Eugeniu Rosca
Avoid below compiler [1] errors, reproduced with configuration [2]: common/avb_verify.c: In function ‘get_unique_guid_for_partition’: common/avb_verify.c:692:31: error: ‘disk_partition_t {aka struct disk_partition}’ has no member named ‘uuid’ uuid_size = sizeof(part->info.uuid);