Re: [U-Boot] [PATCH v2] imx: Fix regression with CONFIG_DM_MMC=y

[Sébastien Szymanski]

Hello Fabio,

On 10/20/2017 01:41 PM, Fabio Estevam wrote:
> When CONFIG_DM_MMC=y, CONFIG_BLK should be selected, otherwise the
> SD/eMMC card cannot be used.
> 
> Also, select CONFIG_DM_USB=y when CONFIG_USB=y to avoid build failure.
> 
> Tested on mx6slevk, mx7dsabresd and mx6ullevk.
> 
> Signed-off-by: Fabio Estevam 
> ---
> Changes since v1:
> - Cover all imx boards
> 
>  configs/imx6q_logic_defconfig | 1 -
>  configs/imx6qdl_icore_nand_defconfig  | 1 -
>  configs/imx6ul_geam_mmc_defconfig | 1 -
>  configs/imx6ul_geam_nand_defconfig| 1 -
>  configs/imx6ul_isiot_emmc_defconfig   | 1 -
>  configs/imx6ul_isiot_mmc_defconfig| 1 -
>  configs/imx6ul_isiot_nand_defconfig   | 1 -
>  configs/mx6slevk_defconfig| 2 +-
>  configs/mx6slevk_spinor_defconfig | 2 +-
>  configs/mx6sllevk_defconfig   | 1 -
>  configs/mx6sllevk_plugin_defconfig| 1 -
>  configs/mx6sxsabreauto_defconfig  | 2 +-
>  configs/mx6ull_14x14_evk_defconfig| 1 -
>  configs/mx6ull_14x14_evk_plugin_defconfig | 1 -
>  configs/mx7dsabresd_defconfig | 1 -
>  configs/mx7dsabresd_secure_defconfig  | 1 -
>  configs/mx7ulp_evk_defconfig  | 1 -
>  configs/mx7ulp_evk_plugin_defconfig   | 1 -
>  configs/opos6uldev_defconfig  | 1 -
>  19 files changed, 3 insertions(+), 19 deletions(-)
>

The compilation fails for the opos6uldev board. The following change is
needed to fix it:

diff --git a/include/configs/opos6uldev.h b/include/configs/opos6uldev.h
index d018984..04fc602 100644
--- a/include/configs/opos6uldev.h
+++ b/include/configs/opos6uldev.h
@@ -17,6 +17,7 @@
 #ifdef CONFIG_SPL_BUILD
 #undef CONFIG_DM_GPIO
 #undef CONFIG_DM_MMC
+#undef CONFIG_BLK

 #define CONFIG_MXC_UART_BASE   UART1_BASE
 #endif


Otherwise, your change fixes the eMMC on the board.

Tested-by: Sébastien Szymanski 

Thanks.

Regards,

-- 
Sébastien Szymanski
Software engineer, Armadeus Systems
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] imx: Fix regression with CONFIG_DM_MMC=y

[Adam Ford]

On Fri, Oct 20, 2017 at 6:51 AM, Jaehoon Chung  wrote:
> On 10/20/2017 08:41 PM, Fabio Estevam wrote:
>> When CONFIG_DM_MMC=y, CONFIG_BLK should be selected, otherwise the
>> SD/eMMC card cannot be used.
>>
>> Also, select CONFIG_DM_USB=y when CONFIG_USB=y to avoid build failure.
>>
>> Tested on mx6slevk, mx7dsabresd and mx6ullevk.
>>
>> Signed-off-by: Fabio Estevam 
>
> Reviewed-by: Jaehoon Chung 

This fixed the Logic PD iMX6 development kit.

Tested-by: Adam Ford 
>> ---
>> Changes since v1:
>> - Cover all imx boards
>>
>>  configs/imx6q_logic_defconfig | 1 -
>>  configs/imx6qdl_icore_nand_defconfig  | 1 -
>>  configs/imx6ul_geam_mmc_defconfig | 1 -
>>  configs/imx6ul_geam_nand_defconfig| 1 -
>>  configs/imx6ul_isiot_emmc_defconfig   | 1 -
>>  configs/imx6ul_isiot_mmc_defconfig| 1 -
>>  configs/imx6ul_isiot_nand_defconfig   | 1 -
>>  configs/mx6slevk_defconfig| 2 +-
>>  configs/mx6slevk_spinor_defconfig | 2 +-
>>  configs/mx6sllevk_defconfig   | 1 -
>>  configs/mx6sllevk_plugin_defconfig| 1 -
>>  configs/mx6sxsabreauto_defconfig  | 2 +-
>>  configs/mx6ull_14x14_evk_defconfig| 1 -
>>  configs/mx6ull_14x14_evk_plugin_defconfig | 1 -
>>  configs/mx7dsabresd_defconfig | 1 -
>>  configs/mx7dsabresd_secure_defconfig  | 1 -
>>  configs/mx7ulp_evk_defconfig  | 1 -
>>  configs/mx7ulp_evk_plugin_defconfig   | 1 -
>>  configs/opos6uldev_defconfig  | 1 -
>>  19 files changed, 3 insertions(+), 19 deletions(-)
>>
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2] imx: Fix regression with CONFIG_DM_MMC=y

[Jaehoon Chung]

On 10/20/2017 08:41 PM, Fabio Estevam wrote:
> When CONFIG_DM_MMC=y, CONFIG_BLK should be selected, otherwise the
> SD/eMMC card cannot be used.
> 
> Also, select CONFIG_DM_USB=y when CONFIG_USB=y to avoid build failure.
> 
> Tested on mx6slevk, mx7dsabresd and mx6ullevk.
> 
> Signed-off-by: Fabio Estevam 

Reviewed-by: Jaehoon Chung 

> ---
> Changes since v1:
> - Cover all imx boards
> 
>  configs/imx6q_logic_defconfig | 1 -
>  configs/imx6qdl_icore_nand_defconfig  | 1 -
>  configs/imx6ul_geam_mmc_defconfig | 1 -
>  configs/imx6ul_geam_nand_defconfig| 1 -
>  configs/imx6ul_isiot_emmc_defconfig   | 1 -
>  configs/imx6ul_isiot_mmc_defconfig| 1 -
>  configs/imx6ul_isiot_nand_defconfig   | 1 -
>  configs/mx6slevk_defconfig| 2 +-
>  configs/mx6slevk_spinor_defconfig | 2 +-
>  configs/mx6sllevk_defconfig   | 1 -
>  configs/mx6sllevk_plugin_defconfig| 1 -
>  configs/mx6sxsabreauto_defconfig  | 2 +-
>  configs/mx6ull_14x14_evk_defconfig| 1 -
>  configs/mx6ull_14x14_evk_plugin_defconfig | 1 -
>  configs/mx7dsabresd_defconfig | 1 -
>  configs/mx7dsabresd_secure_defconfig  | 1 -
>  configs/mx7ulp_evk_defconfig  | 1 -
>  configs/mx7ulp_evk_plugin_defconfig   | 1 -
>  configs/opos6uldev_defconfig  | 1 -
>  19 files changed, 3 insertions(+), 19 deletions(-)
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2] imx: Fix regression with CONFIG_DM_MMC=y

[Fabio Estevam]

When CONFIG_DM_MMC=y, CONFIG_BLK should be selected, otherwise the
SD/eMMC card cannot be used.

Also, select CONFIG_DM_USB=y when CONFIG_USB=y to avoid build failure.

Tested on mx6slevk, mx7dsabresd and mx6ullevk.

Signed-off-by: Fabio Estevam 
---
Changes since v1:
- Cover all imx boards

 configs/imx6q_logic_defconfig | 1 -
 configs/imx6qdl_icore_nand_defconfig  | 1 -
 configs/imx6ul_geam_mmc_defconfig | 1 -
 configs/imx6ul_geam_nand_defconfig| 1 -
 configs/imx6ul_isiot_emmc_defconfig   | 1 -
 configs/imx6ul_isiot_mmc_defconfig| 1 -
 configs/imx6ul_isiot_nand_defconfig   | 1 -
 configs/mx6slevk_defconfig| 2 +-
 configs/mx6slevk_spinor_defconfig | 2 +-
 configs/mx6sllevk_defconfig   | 1 -
 configs/mx6sllevk_plugin_defconfig| 1 -
 configs/mx6sxsabreauto_defconfig  | 2 +-
 configs/mx6ull_14x14_evk_defconfig| 1 -
 configs/mx6ull_14x14_evk_plugin_defconfig | 1 -
 configs/mx7dsabresd_defconfig | 1 -
 configs/mx7dsabresd_secure_defconfig  | 1 -
 configs/mx7ulp_evk_defconfig  | 1 -
 configs/mx7ulp_evk_plugin_defconfig   | 1 -
 configs/opos6uldev_defconfig  | 1 -
 19 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/configs/imx6q_logic_defconfig b/configs/imx6q_logic_defconfig
index 8018198..c7d3046 100644
--- a/configs/imx6q_logic_defconfig
+++ b/configs/imx6q_logic_defconfig
@@ -28,7 +28,6 @@ CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_CMD_MTDPARTS=y
 CONFIG_ENV_IS_IN_NAND=y
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_NAND=y
 CONFIG_NAND_MXS=y
diff --git a/configs/imx6qdl_icore_nand_defconfig 
b/configs/imx6qdl_icore_nand_defconfig
index c341b17..80a8679 100644
--- a/configs/imx6qdl_icore_nand_defconfig
+++ b/configs/imx6qdl_icore_nand_defconfig
@@ -32,7 +32,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_CMD_UBI=y
 CONFIG_OF_LIST="imx6q-icore imx6dl-icore"
 CONFIG_ENV_IS_IN_NAND=y
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_NAND=y
 CONFIG_NAND_MXS=y
diff --git a/configs/imx6ul_geam_mmc_defconfig 
b/configs/imx6ul_geam_mmc_defconfig
index 7c79873..ce7c288 100644
--- a/configs/imx6ul_geam_mmc_defconfig
+++ b/configs/imx6ul_geam_mmc_defconfig
@@ -32,7 +32,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_ENV_IS_IN_MMC=y
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_SMSC=y
diff --git a/configs/imx6ul_geam_nand_defconfig 
b/configs/imx6ul_geam_nand_defconfig
index d6038c1..8d7eb0d 100644
--- a/configs/imx6ul_geam_nand_defconfig
+++ b/configs/imx6ul_geam_nand_defconfig
@@ -31,7 +31,6 @@ CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_CMD_UBI=y
 CONFIG_ENV_IS_IN_NAND=y
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_NAND=y
 CONFIG_NAND_MXS=y
diff --git a/configs/imx6ul_isiot_emmc_defconfig 
b/configs/imx6ul_isiot_emmc_defconfig
index 67fa9a0..94af53e 100644
--- a/configs/imx6ul_isiot_emmc_defconfig
+++ b/configs/imx6ul_isiot_emmc_defconfig
@@ -31,7 +31,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_ENV_IS_IN_MMC=y
-# CONFIG_BLK is not set
 CONFIG_PHYLIB=y
 CONFIG_PHY_SMSC=y
 CONFIG_FEC_MXC=y
diff --git a/configs/imx6ul_isiot_mmc_defconfig 
b/configs/imx6ul_isiot_mmc_defconfig
index c673d93..0a990d7 100644
--- a/configs/imx6ul_isiot_mmc_defconfig
+++ b/configs/imx6ul_isiot_mmc_defconfig
@@ -32,7 +32,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_ENV_IS_IN_MMC=y
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_SMSC=y
diff --git a/configs/imx6ul_isiot_nand_defconfig 
b/configs/imx6ul_isiot_nand_defconfig
index e481151..e806127 100644
--- a/configs/imx6ul_isiot_nand_defconfig
+++ b/configs/imx6ul_isiot_nand_defconfig
@@ -31,7 +31,6 @@ CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_CMD_UBI=y
 CONFIG_ENV_IS_IN_NAND=y
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_NAND=y
 CONFIG_NAND_MXS=y
diff --git a/configs/mx6slevk_defconfig b/configs/mx6slevk_defconfig
index 16e2cca..7b1ddac 100644
--- a/configs/mx6slevk_defconfig
+++ b/configs/mx6slevk_defconfig
@@ -28,7 +28,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_MMC=y
 CONFIG_DM=y
-# CONFIG_BLK is not set
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_DM_MMC=y
@@ -45,6 +44,7 @@ CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
 CONFIG_DM_THERMAL=y
 CONFIG_USB=y
+CONFIG_DM_USB=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_HOST_ETHER=y
 CONFIG_USB_ETHER_ASIX=y
diff --git a/configs/mx6slevk_spinor_defconfig 
b/configs/mx6slevk_spinor_defconfig
index 020d19f..4b9c04e 100644
--- a/configs/mx6slevk_spinor_defconfig
+++ b/configs/mx6slevk_spinor_defconfig
@@ -28,7 +28,6 @@ CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_CONTROL=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
 CONFIG_DM=y
-# CONFIG_BLK is not set
 CONFIG_DM_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_DM_MMC=y
@@ -45,6 +44,7 @@ CONFIG_DM_REGULATOR_FIXED=y