Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-07 Thread Marek Vasut
On Friday, November 07, 2014 at 02:10:28 AM, Peng Fan wrote: [...] > >> In board/freescale/mx6sxsabresd/mx6sxsabresd.c: > >> 295 int board_usb_phy_mode(int port) > >> 296 { > >> 297 void __iomem *phy_reg; > >> 298 void __iomem *phy_ctrl; > >> 299 u32 val; > >> 300 > >> 301

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-06 Thread Peng Fan
在 11/7/2014 4:20 AM, Marek Vasut 写道: On Wednesday, November 05, 2014 at 10:18:25 AM, Peng Fan wrote: 在 11/5/2014 5:03 PM, Marek Vasut 写道: On Wednesday, November 05, 2014 at 07:00:32 AM, Peng Fan wrote: 在 11/5/2014 1:33 AM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 02:29:56 PM, Peng F

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-06 Thread Marek Vasut
On Wednesday, November 05, 2014 at 10:18:25 AM, Peng Fan wrote: > 在 11/5/2014 5:03 PM, Marek Vasut 写道: > > On Wednesday, November 05, 2014 at 07:00:32 AM, Peng Fan wrote: > >> 在 11/5/2014 1:33 AM, Marek Vasut 写道: > >>> On Tuesday, November 04, 2014 at 02:29:56 PM, Peng Fan wrote: > Hi Marek, >

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-05 Thread Peng Fan
在 11/5/2014 5:03 PM, Marek Vasut 写道: On Wednesday, November 05, 2014 at 07:00:32 AM, Peng Fan wrote: 在 11/5/2014 1:33 AM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 02:29:56 PM, Peng Fan wrote: Hi Marek, 在 11/4/2014 7:01 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 11:50:29 A

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-05 Thread Marek Vasut
On Wednesday, November 05, 2014 at 07:00:32 AM, Peng Fan wrote: > 在 11/5/2014 1:33 AM, Marek Vasut 写道: > > On Tuesday, November 04, 2014 at 02:29:56 PM, Peng Fan wrote: > >> Hi Marek, > >> > >> 在 11/4/2014 7:01 PM, Marek Vasut 写道: > >>> On Tuesday, November 04, 2014 at 11:50:29 AM, Peng Fan wrote:

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Peng Fan
在 11/5/2014 1:33 AM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 02:29:56 PM, Peng Fan wrote: Hi Marek, 在 11/4/2014 7:01 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 11:50:29 AM, Peng Fan wrote: 在 11/4/2014 6:33 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 08:50:00 AM,

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Marek Vasut
On Tuesday, November 04, 2014 at 02:29:56 PM, Peng Fan wrote: > Hi Marek, > > 在 11/4/2014 7:01 PM, Marek Vasut 写道: > > On Tuesday, November 04, 2014 at 11:50:29 AM, Peng Fan wrote: > >> 在 11/4/2014 6:33 PM, Marek Vasut 写道: > >>> On Tuesday, November 04, 2014 at 08:50:00 AM, Peng Fan wrote: >

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Jeroen Hofstee
Hello Peng, On 04-11-14 14:36, Peng Fan wrote: Hi Jeroen, 在 11/4/2014 7:40 PM, Jeroen Hofstee 写道: Hello Peng, On 04-11-14 08:50, Peng Fan wrote: Include a weak function board_ehci_usb_mode to gives board code a choice. If the board want the otg port work in host mode but not device mode, th

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Peng Fan
Hi Jeroen, 在 11/4/2014 7:40 PM, Jeroen Hofstee 写道: Hello Peng, On 04-11-14 08:50, Peng Fan wrote: Include a weak function board_ehci_usb_mode to gives board code a choice. If the board want the otg port work in host mode but not device mode, this should be handled. Signed-off-by: Peng Fan S

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Peng Fan
Hi Marek, 在 11/4/2014 7:01 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 11:50:29 AM, Peng Fan wrote: 在 11/4/2014 6:33 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 08:50:00 AM, Peng Fan wrote: Include a weak function board_ehci_usb_mode to gives board code a choice. What cho

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Jeroen Hofstee
Hello Peng, On 04-11-14 08:50, Peng Fan wrote: Include a weak function board_ehci_usb_mode to gives board code a choice. If the board want the otg port work in host mode but not device mode, this should be handled. Signed-off-by: Peng Fan Signed-off-by: Ye Li --- Changes v2: Introduce a ne

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Marek Vasut
On Tuesday, November 04, 2014 at 11:50:29 AM, Peng Fan wrote: > 在 11/4/2014 6:33 PM, Marek Vasut 写道: > > On Tuesday, November 04, 2014 at 08:50:00 AM, Peng Fan wrote: > >> Include a weak function board_ehci_usb_mode to gives board code > >> a choice. > > > > What choice? > > > >> If the board wan

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Peng Fan
在 11/4/2014 6:33 PM, Marek Vasut 写道: On Tuesday, November 04, 2014 at 08:50:00 AM, Peng Fan wrote: Include a weak function board_ehci_usb_mode to gives board code a choice. What choice? If the board want the otg port work in host mode but not device mode, this should be handled. How? Al

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Marek Vasut
On Tuesday, November 04, 2014 at 08:50:00 AM, Peng Fan wrote: > Include a weak function board_ehci_usb_mode to gives board code > a choice. What choice? > If the board want the otg port work in host mode but not > device mode, this should be handled. How? Also, isn't usb_phy_enable() supposed t

[U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-03 Thread Peng Fan
Include a weak function board_ehci_usb_mode to gives board code a choice. If the board want the otg port work in host mode but not device mode, this should be handled. Signed-off-by: Peng Fan Signed-off-by: Ye Li --- Changes v2: Introduce a new weak function to let board have a choice to decid