On Tue, 5 Aug 2008, Scott Wood wrote:
> Also, remove the ctrl variable in favor of passing the constants
> directly, and remove redundant (u8) casts.
>
> Signed-off-by: Scott Wood <[EMAIL PROTECTED]>
Tested-by: Guennadi Liakhovetski <[EMAIL PROTECTED]>
It works.
Thanks
Guennadi
> ---
> This p
Guennadi Liakhovetski wrote:
>> /* Begin command latch cycle */
>> -this->cmd_ctrl(mtd, cmd, ctrl);
>> +this->cmd_ctrl(mtd, cmd, NAND_CTRL_CLE | NAND_CTRL_CHANGE);
>
> [snip]
>
> See? you do the same! You replace short lowercase variable with long
> uppercase macros:-)
:-)
Yes, b
On Tue, 5 Aug 2008, Scott Wood wrote:
> Also, remove the ctrl variable in favor of passing the constants
> directly, and remove redundant (u8) casts.
>
> Signed-off-by: Scott Wood <[EMAIL PROTECTED]>
> ---
> This patch is untested, as I don't have the hardware.
> Applied to u-boot-nand-flash/test
Also, remove the ctrl variable in favor of passing the constants
directly, and remove redundant (u8) casts.
Signed-off-by: Scott Wood <[EMAIL PROTECTED]>
---
This patch is untested, as I don't have the hardware.
Applied to u-boot-nand-flash/testing.
nand_spl/nand_boot.c | 50 ++
