Re: [PATCH 4/5] sandbox: implement reset

2020-10-27 Thread Rasmus Villemoes
On 27/10/2020 14.33, Heinrich Schuchardt wrote: > On 27.10.20 13:12, Rasmus Villemoes wrote: >> On 25/10/2020 07.04, Heinrich Schuchardt wrote: >>> Up to now the sandbox would shutdown upon a cold reset request. Instead it >>> should be reset. >>> >>> In our coding we use static variables. The

Re: Please pull u-boot-video

2020-10-27 Thread Anatolij Gustschin
On Tue, 27 Oct 2020 10:50:53 -0400 Tom Rini tr...@konsulko.com wrote: ... > > nokia_rx51: disable obsolete VIDEO config > > So I'm not quite sure what to do here. Are you concerned about reported issue with nokia_rx51 patch? -- Anatolij

Re: [PATCH] arm: sunxi: disable obsolete VIDEO config

2020-10-27 Thread Maxime Ripard
On Mon, Oct 19, 2020 at 10:50:49AM -0400, Tom Rini wrote: > On Mon, Oct 19, 2020 at 11:17:54AM +0200, Maxime Ripard wrote: > > On Sun, Oct 18, 2020 at 09:18:15PM +0200, Anatolij Gustschin wrote: > > > DM_VIDEO conversion deadline has passed, disable VIDEO config > > > option by default. Boards

Re: [PATCH 1/2] power: twl4030: Add twl4030_i2c_read() function

2020-10-27 Thread Jaehoon Chung
Hi, On 10/27/20 6:36 AM, Pali Rohár wrote: > Function twl4030_i2c_read() is like twl4030_i2c_read_u8() but instead of > single value it rather returns array of values. Just minor comment. Is there a reason not to touch twl4030_i2c_write_u8()? Best Regards, Jaehoon Chung > > Signed-off-by:

[PATCH v2 8/8] doc: add sandbox API

2020-10-27 Thread Heinrich Schuchardt
Add sandbox API to generated HTML documentation Signed-off-by: Heinrich Schuchardt --- v2: new patch --- doc/api/index.rst | 1 + doc/api/sandbox.rst | 9 + 2 files changed, 10 insertions(+) create mode 100644 doc/api/sandbox.rst diff --git a/doc/api/index.rst

[PATCH v2 4/8] sandbox: use O_CLOEXEC in os_open()

2020-10-27 Thread Heinrich Schuchardt
During a cold reset execv() is used to relaunch the U-Boot binary. We must ensure that all files are closed in this case. Signed-off-by: Heinrich Schuchardt --- v2: new patch --- arch/sandbox/cpu/os.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/sandbox/cpu/os.c

[PATCH v2 2/8] sandbox: enable poweroff command

2020-10-27 Thread Heinrich Schuchardt
The command to shut down a device is 'poweroff'. It is a deficit of the sandbox that it does not support resetting yet but shuts down upong seeing the 'reset' command. Once the sandbox properly supports reset we need the 'poweroff' command to leave the sandbox. Signed-off-by: Heinrich Schuchardt

[PATCH v3 7/8] sandbox: update function descriptions in os.h

2020-10-27 Thread Heinrich Schuchardt
Use Sphinx style function descriptions. Signed-off-by: Heinrich Schuchardt --- v3: no change v2: new patch --- include/os.h | 223 ++- 1 file changed, 130 insertions(+), 93 deletions(-) diff --git a/include/os.h b/include/os.h

[PATCH v3 8/8] doc: add sandbox API

2020-10-27 Thread Heinrich Schuchardt
Add sandbox API to generated HTML documentation Signed-off-by: Heinrich Schuchardt --- v3: no change v2: new patch --- doc/api/index.rst | 1 + doc/api/sandbox.rst | 9 + 2 files changed, 10 insertions(+) create mode 100644 doc/api/sandbox.rst diff --git

[PATCH v3 2/8] sandbox: enable poweroff command

2020-10-27 Thread Heinrich Schuchardt
The command to shut down a device is 'poweroff'. It is a deficit of the sandbox that it does not support resetting yet but shuts down upong seeing the 'reset' command. Once the sandbox properly supports reset we need the 'poweroff' command to leave the sandbox. Signed-off-by: Heinrich Schuchardt

[PATCH v3 6/8] test: adjust sysreset tests

2020-10-27 Thread Heinrich Schuchardt
As we have a working COLD_RESET on the sandbox the sysreset test has to be adjusted. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change v2: no change --- test/dm/sysreset.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH v3 5/8] sandbox: implement reset

2020-10-27 Thread Heinrich Schuchardt
Up to now the sandbox would shutdown upon a cold reset request. Instead it should be reset. In our coding we use static variables like LIST_HEAD(efi_obj_list). A reset can occur at any time, e.g. via an UEFI binary calling the reset service. The only safe way to return to an initial state is to

Re: [PATCH v3 23/23] doc: Update logging documentation

2020-10-27 Thread Tom Rini
On Sat, Oct 17, 2020 at 02:07:48PM -0400, Sean Anderson wrote: > This updates logging documentation with some examples of the new commands > added in the previous commits. It also removes some items from the to-do > list which have been implemented. > > Signed-off-by: Sean Anderson >

[PATCH 2/2] video: simple_panel: Add boe,nv101wxmn51 display

2020-10-27 Thread Alper Nebi Yasak
Add "boe,nv101wxmn51" to the compatible node. This is the panel for chromebook_bob. Signed-off-by: Alper Nebi Yasak --- I didn't test this as I don't have a gru-bob, but this panel is listed among Linux's simple-panel compatibles [1] just like gru-kevin's (which I tested) so I strongly believe

Re: [PATCH v2 5/8] sandbox: implement reset

2020-10-27 Thread Rasmus Villemoes
On 27/10/2020 19.47, Heinrich Schuchardt wrote: > Up to now the sandbox would shutdown upon a cold reset request. Instead it > should be reset. > > In our coding we use static variables like LIST_HEAD(efi_obj_list). A reset > can occur at any time, e.g. via an UEFI binary calling the reset

Re: [PATCH v3 04/23] log: Add new category names to log_cat_name

2020-10-27 Thread Sean Anderson
On 10/27/20 1:45 PM, Tom Rini wrote: > On Sat, Oct 17, 2020 at 02:07:29PM -0400, Sean Anderson wrote: > >> Without every category between LOGC_NONE and LOGC_COUNT present in >> log_cat_name, log_get_cat_by_name will dereference NULL pointers if it >> doesn't find a name early enough. >> >>

Re: Please pull u-boot-video

2020-10-27 Thread Anatolij Gustschin
On Tue, 27 Oct 2020 15:43:15 -0400 Tom Rini tr...@konsulko.com wrote: ... > I took the follow-up patch right afterwards. OK, thanks! -- Anatolij

[PATCH 1/2] Add HMAC-SHA-256

2020-10-27 Thread GlovePuppet
Required by TPM2 Extended Auth, cloned from sha1.c Signed-off-by: GlovePuppet --- include/u-boot/sha256.h | 13 + lib/sha256.c| 40 2 files changed, 53 insertions(+) diff --git a/include/u-boot/sha256.h b/include/u-boot/sha256.h

Reading from a Ubifs filesystem on LS1046 Freeway

2020-10-27 Thread Jan Hoogerbrugge
Hi, I am using a NXP LS1046 Freeway board. I want to create a Ubifs file system on the NAND flash and write to it from Linux and read from it in Uboot. I create a Ubifs file system and a dummy file on it as follows: root@localhost:~# ubiformat /dev/mtd0 ubiformat: mtd0 (nand), size 536870912

[PATCH 2/2] Add TPM2 Unseal command and supporting functions

2020-10-27 Thread GlovePuppet
Unseals a loaded object, identified by handle, and returns data at a memory location or in an environment variable Caveats -The PolicyPCR command only supports one PCR -The auth request code only supports one handle Signed-off-by: GlovePuppet --- cmd/tpm-v2.c| 60 +++

[PATCH v3 3/8] test/py: test poweroff

2020-10-27 Thread Heinrich Schuchardt
It is the 'poweroff' and not the 'reset' command that should shut down the sandbox. Adjust the unit test accordingly Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change v2: no change --- test/py/tests/test_sandbox_exit.py | 8 1 file changed,

[PATCH v3 0/8] sandbox: implement cold reset

2020-10-27 Thread Heinrich Schuchardt
The command to shut down a device is 'poweroff'. It is a deficit of the sandbox that it does not support resetting yet but shuts down upong seeing the 'reset' command. The patch series implements the cold reset function as a relaunch of the U-Boot binary via execv(). Unit tests are adjusted. A

[PATCH v3 1/8] sandbox: eth-raw: do not close the console input

2020-10-27 Thread Heinrich Schuchardt
When the sandbox eth-raw device host_lo is removed this leads to closing the console input. Do not call close(0). Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change v2: no change --- arch/sandbox/cpu/eth-raw-os.c | 8 arch/sandbox/cpu/os.c

[PATCH v3 4/8] sandbox: use O_CLOEXEC in os_open()

2020-10-27 Thread Heinrich Schuchardt
During a cold reset execv() is used to relaunch the U-Boot binary. We must ensure that all files are closed in this case. Signed-off-by: Heinrich Schuchardt --- v3: no change v2: new patch --- arch/sandbox/cpu/os.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH 1/1] efi_loader: daylight saving time

2020-10-27 Thread Heinrich Schuchardt
Adjust the SetTime() and GetTime() runtime services to correctly convert the daylight saving time information when communicating with the RTC. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_runtime.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff

Re: [PATCH v3 21/23] test: Add a test for log filter-*

2020-10-27 Thread Tom Rini
On Sat, Oct 17, 2020 at 02:07:46PM -0400, Sean Anderson wrote: > This exercises a few success and failure modes of the log filter-* > commands. log filter-list is not tested because it's purely informational. > I don't think there's a good way to test it except by testing if the output > of the

Re: [PATCH v3 23/23] doc: Update logging documentation

2020-10-27 Thread Heinrich Schuchardt
On 17.10.20 20:07, Sean Anderson wrote: > This updates logging documentation with some examples of the new commands > added in the previous commits. It also removes some items from the to-do > list which have been implemented. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass > --- > >

Re: [PATCH 1/2] power: twl4030: Add twl4030_i2c_read() function

2020-10-27 Thread Pali Rohár
On Wednesday 28 October 2020 06:45:51 Jaehoon Chung wrote: > Hi, > > On 10/27/20 6:36 AM, Pali Rohár wrote: > > Function twl4030_i2c_read() is like twl4030_i2c_read_u8() but instead of > > single value it rather returns array of values. > > Just minor comment. > Is there a reason not to touch

Re: [PATCH v2 21/30] patman: Require tags to be before sign-off

2020-10-27 Thread Sean Anderson
On 10/27/20 2:05 AM, Jonathan Nieder wrote: > Simon Glass wrote: >> On Sun, 25 Oct 2020 at 19:23, Sean Anderson wrote: > >>> I also like to put SOBs on top because it groups all the commit-specific >>> information before any patman-specific tags. The last commit (the HEAD) >>> usually has

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-27 Thread Ard Biesheuvel
On Tue, 27 Oct 2020 at 18:25, Tom Rini wrote: > > On Fri, Oct 09, 2020 at 05:00:44PM +, Patrick DELAUNAY wrote: > > Hi Ard, > > > > > From: Ard Biesheuvel > > > Sent: mercredi 7 octobre 2020 15:16 > > > > > > On Wed, 7 Oct 2020 at 13:53, Ahmad Fatoum wrote: > > > > > > > > Hello, > > > > >

Re: [PATCH 2/2] video: simple_panel: Add boe,nv101wxmn51 display

2020-10-27 Thread Mark Kettenis
> From: Alper Nebi Yasak > Date: Wed, 28 Oct 2020 00:41:55 +0300 > > Add "boe,nv101wxmn51" to the compatible node. This is the panel for > chromebook_bob. I do have bob, and would be interested in testing chainloading u-boot on it. Can you give some guidance on how to test this? Which set of

[PATCH v2 1/2] rockchip: rk3399: Init clocks in U-Boot proper if SPL was not run

2020-10-27 Thread Alper Nebi Yasak
It's possible to chainload U-Boot proper from the vendor firmware in rk3399 chromebooks, but the way the vendor firmware sets up clocks is somehow different than what U-Boot expects. This causes the display to stay devoid of content even though vidconsole claims to work (with patches in process of

[PATCH v2 2/2] rockchip: gru: Allow setting up clocks in U-Boot proper

2020-10-27 Thread Alper Nebi Yasak
Commit fe974716326c ("rockchip: rk3288: Allow setting up clocks in U-Boot proper") fixes some clock issues when chainloading U-Boot on rk3288 chromebooks. Part of that change is still available in veyron's board_early_init_r() function. Since chain-loading U-Boot proper from vendor firmware is

Re: [PATCH v3 04/23] log: Add new category names to log_cat_name

2020-10-27 Thread Tom Rini
On Tue, Oct 27, 2020 at 02:07:04PM -0400, Sean Anderson wrote: > > On 10/27/20 1:45 PM, Tom Rini wrote: > > On Sat, Oct 17, 2020 at 02:07:29PM -0400, Sean Anderson wrote: > > > >> Without every category between LOGC_NONE and LOGC_COUNT present in > >> log_cat_name, log_get_cat_by_name will

[PATCH v2 0/8] sandbox: implement cold reset

2020-10-27 Thread Heinrich Schuchardt
The command to shut down a device is 'poweroff'. It is a deficit of the sandbox that it does not support resetting yet but shuts down upong seeing the 'reset' command. The patch series implements the cold reset function as a relaunch of the U-Boot binary via execv(). Unit tests are adjusted. A

[PATCH v2 1/8] sandbox: eth-raw: do not close the console input

2020-10-27 Thread Heinrich Schuchardt
When the sandbox eth-raw device host_lo is removed this leads to closing the console input. Do not call close(0). Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v2: no change --- arch/sandbox/cpu/eth-raw-os.c | 8 arch/sandbox/cpu/os.c | 5 - 2

Re: Please pull u-boot-video

2020-10-27 Thread Tom Rini
On Tue, Oct 27, 2020 at 08:37:48PM +0100, Anatolij Gustschin wrote: > On Tue, 27 Oct 2020 10:50:53 -0400 > Tom Rini tr...@konsulko.com wrote: > ... > > > nokia_rx51: disable obsolete VIDEO config > > > > So I'm not quite sure what to do here. > > Are you concerned about reported issue

Re: [PATCH v3 21/23] test: Add a test for log filter-*

2020-10-27 Thread Tom Rini
On Tue, Oct 27, 2020 at 05:11:58PM -0400, Sean Anderson wrote: > > On 10/27/20 5:00 PM, Tom Rini wrote: > > On Sat, Oct 17, 2020 at 02:07:46PM -0400, Sean Anderson wrote: > > > >> This exercises a few success and failure modes of the log filter-* > >> commands. log filter-list is not tested

Re: [PATCH v3 21/23] test: Add a test for log filter-*

2020-10-27 Thread Sean Anderson
On 10/27/20 5:00 PM, Tom Rini wrote: > On Sat, Oct 17, 2020 at 02:07:46PM -0400, Sean Anderson wrote: > >> This exercises a few success and failure modes of the log filter-* >> commands. log filter-list is not tested because it's purely informational. >> I don't think there's a good way to test

Re: [PATCH v3 23/23] doc: Update logging documentation

2020-10-27 Thread Sean Anderson
On 10/27/20 5:00 PM, Heinrich Schuchardt wrote: > On 17.10.20 20:07, Sean Anderson wrote: >> This updates logging documentation with some examples of the new commands >> added in the previous commits. It also removes some items from the to-do >> list which have been implemented. >> >>

[PATCH v2 7/8] sandbox: update function descriptions in os.h

2020-10-27 Thread Heinrich Schuchardt
Use Sphinx style function descriptions. Signed-off-by: Heinrich Schuchardt --- v2: new patch --- include/os.h | 223 ++- 1 file changed, 130 insertions(+), 93 deletions(-) diff --git a/include/os.h b/include/os.h index

[PATCH v2 6/8] test: adjust sysreset tests

2020-10-27 Thread Heinrich Schuchardt
As we have a working COLD_RESET on the sandbox the sysreset test has to be adjusted. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v2: no change --- test/dm/sysreset.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/test/dm/sysreset.c

[PATCH v2 5/8] sandbox: implement reset

2020-10-27 Thread Heinrich Schuchardt
Up to now the sandbox would shutdown upon a cold reset request. Instead it should be reset. In our coding we use static variables like LIST_HEAD(efi_obj_list). A reset can occur at any time, e.g. via an UEFI binary calling the reset service. The only safe way to return to an initial state is to

[PATCH v2 3/8] test/py: test poweroff

2020-10-27 Thread Heinrich Schuchardt
It is the 'poweroff' and not the 'reset' command that should shut down the sandbox. Adjust the unit test accordingly Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v2: no change --- test/py/tests/test_sandbox_exit.py | 8 1 file changed, 4 insertions(+), 4

[PATCH 1/2] video: simple_panel: Add sharp,lq123p1jx31 display

2020-10-27 Thread Alper Nebi Yasak
Add "sharp,lq123p1jx31" to the compatible node. This is the panel for chromebook_kevin. Signed-off-by: Alper Nebi Yasak --- drivers/video/simple_panel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/simple_panel.c b/drivers/video/simple_panel.c index

[PATCH v4 02/22] log: Fix incorrect documentation of log_filter.cat_list

2020-10-27 Thread Sean Anderson
Logging category lists are terminated by LOGC_END, not LOGC_NONE. Fixes: e9c8d49d54 ("log: Add an implementation of logging") Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- (no changes since v2) Changes in v2: - Also fix misdocumentation of for log_add_filter()

[PATCH v4 04/22] log: Use CONFIG_IS_ENABLED() for LOG_TEST

2020-10-27 Thread Sean Anderson
Checkpatch complains about using #ifdef for CONFIG variables. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) cmd/log.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/log.c b/cmd/log.c index 6afe6ead25..16a6ef7539 100644 ---

[PATCH v4 00/22] log: Add commands for manipulating filters

2020-10-27 Thread Sean Anderson
This series adds several commands for adding, listing, and removing log filters. It also adds getopt, since the filter-add command needs to have several optional arguments to be complete, and positional specification of those arguments would have been difficult. Passing CI:

[PATCH v4 03/22] log: Add additional const qualifier to arrays

2020-10-27 Thread Sean Anderson
Both these arrays and their members are const. Fixes checkpatch complaint. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - New common/log.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/log.c b/common/log.c

[PATCH v4 01/22] log: Fix missing negation of ENOMEM

2020-10-27 Thread Sean Anderson
Errors returned should be negative. Fixes: 45fac9fc18 ("log: Correct missing free() on error in log_add_filter()") Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- (no changes since v1) common/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 09/22] test: log: Give tests names instead of numbers

2020-10-27 Thread Sean Anderson
Now that the log test command is no more, we can give the log tests proper names. Signed-off-by: Sean Anderson --- (no changes since v3) Changes in v3: - New test/log/log_test.c | 48 ++--- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git

[PATCH v4 06/22] log: Add function to create a filter with flags

2020-10-27 Thread Sean Anderson
This function exposes a way to specify flags when creating a filter. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) common/log.c | 6 -- include/log.h | 29 +++-- 2 files changed, 31 insertions(+), 4 deletions(-) diff --git

[PATCH v4 10/22] test: Add tests for LOGFF_DENY

2020-10-27 Thread Sean Anderson
This adds some tests for log filters which deny if they match. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v3) Changes in v3: - Modified to be completely written in C test/log/log_test.c | 67 + 1 file changed, 67

[PATCH v4 05/22] log: Expose some helper functions

2020-10-27 Thread Sean Anderson
These functions are required by "cmd: log: Add commands to manipulate filters" and "test: Add a test for log filter-*". Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - Expose log_has_cat and log_has_file for filter tests common/log.c | 23

Re: [PATCH v9 0/2] Basic Kontron SMARC-sAL28 board support

2020-10-27 Thread Tom Rini
On Tue, Oct 27, 2020 at 11:23:23PM +0100, Michael Walle wrote: > Hi Tom, Hi all, > > Am 2020-10-15 23:08, schrieb Michael Walle: > > Add basic board support for the Kontron SMARC-sAL28 board. Please note, > > that this board doesn't support TF-a (yet). Therefore, the u-boot SPL is > > the first

Re: [patch v2 10/10] drivers/video/rockchip/rk_vop.c: Add reset support

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > In order to ensure that the VOP registers are in correct state, > add missing support for the VOP reset lines found in the device-tree > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in patch 1): Tested-by: Alper Nebi Yasak

Re: [patch v2 09/10] drivers/video/rockchip/rk_edp.c: Add missing reset support

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > In order to ensure that the eDP registers are in correct state, > add missing support for the eDP reset lines found in the device-tree. > > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in patch 1): Tested-by: Alper Nebi

Re: [patch v2 08/10] drivers/video/rockchip/rk_vop.c: Fix format of fbbase in debug string

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > The debug string printing the device name, framebuffer address and of node > is using %lu as format for the framebuffer address, which is not so nice. > Change it to %lx. > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in

[PATCH v4 19/22] cmd: log: Add commands to manipulate filters

2020-10-27 Thread Sean Anderson
This adds several commands to add, list, and remove log filters. Due to the complexity of adding a filter, `log filter-list` uses options instead of positional arguments. These commands have been added as subcommands to log by using a dash to join the subcommand and subsubcommand. This is

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-10-27 Thread Pali Rohár
On Tuesday 27 October 2020 20:10:37 Simon Glass wrote: > Hi Paul, > > On Mon, 26 Oct 2020 at 07:11, Pali Rohár wrote: > > > > On more places is used pattern 'command > $@ || rm -f $@'. But it does not > > propagate failure from 'command' as 'rm -f' returns success. > > > > Fix it by calling

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-10-27 Thread Simon Glass
Hi Paul, On Mon, 26 Oct 2020 at 07:11, Pali Rohár wrote: > > On more places is used pattern 'command > $@ || rm -f $@'. But it does not > propagate failure from 'command' as 'rm -f' returns success. > > Fix it by calling 'false' to correctly propagate failure after 'rm -f'. > > Signed-off-by:

Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > The current code is using an hard coded enum and the of node reg value of > endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order > is different between rk3288, rk3399 vop little, rk3399 vop big. > > A possible solution would be

Re: [patch v2 02/10] drivers/video/rockchip/rk_edp.c: Add rk3399 support

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP > support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399 > eDP IPs are nearly the same, the difference is in the grf register > (SOC_CON6 versus SOC_CON20). So,

Re: [patch v2 03/10] drivers/video/rockchip/rk_edp.c: Change interrupt polarity configuration

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > The linux code is setting polarity configuration to 3 but > uboot code is setting it to 1. Change the configuration to match the > linux configuration > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in patch 1): Tested-by:

Re: [patch v2 00/10] rk3399 (Pinebook pro) EDP support

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > This patchset add support for the rk3399 eDP. It has been tested on the > pinebook > pro and Google Kevin chromeos devices. > > The changes have been written by studying the linux code, since I didn't find > any > manual for theses part of the

Re: [patch v2 07/10] drivers/pwm/rk_pwm.c: Fix default polarity

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > In the code, the default polarity is set to positive/positive, > which is neither normal polarity or inverted polarity. It's > only the hardware default. This leads to booting linux with > wrong polarity setting. > > Update the code to use

Re: [patch v2 04/10] drivers/video/rockchip/rk_vop.c: Reserve efi fb memory

2020-10-27 Thread Alper Nebi Yasak
On 27/10/2020 16:21, Arnaud Patard (Rtp) wrote: > When booting with EFI and graphics, the memory used for framebuffer > has to be reserved, otherwise it may leads to kernel memory > overwrite. > > Signed-off-by: Arnaud Patard On a rk3399-gru-kevin, (see comment in patch 1): Tested-by: Alper

Re: [PATCH 1/2] power: twl4030: Add twl4030_i2c_read() function

2020-10-27 Thread Jaehoon Chung
On 10/28/20 6:57 AM, Pali Rohár wrote: > On Wednesday 28 October 2020 06:45:51 Jaehoon Chung wrote: >> Hi, >> >> On 10/27/20 6:36 AM, Pali Rohár wrote: >>> Function twl4030_i2c_read() is like twl4030_i2c_read_u8() but instead of >>> single value it rather returns array of values. >> >> Just minor

Re: [PATCH v9 0/2] Basic Kontron SMARC-sAL28 board support

2020-10-27 Thread Michael Walle
Hi Tom, Hi all, Am 2020-10-15 23:08, schrieb Michael Walle: Add basic board support for the Kontron SMARC-sAL28 board. Please note, that this board doesn't support TF-a (yet). Therefore, the u-boot SPL is the first code which is run and it has to set up the RAM. With the merge window

Re: [PATCH 2/2] cmd: Kconfig: migrate CONFIG_SYS_PROMPT_HUSH_PS2

2020-10-27 Thread Simon Glass
On Mon, 26 Oct 2020 at 02:31, Patrick Delaunay wrote: > > Move CONFIG_SYS_PROMPT_HUSH_PS2 in Kconfig, depending > on CONFIG_HUSH_PARSER, and remove the default value defined > in cli_hush.c under __U_BOOT__. > > Signed-off-by: Patrick Delaunay > --- > > README | 7 ---

Re: [PATCH v5 18/27] misc: am33xx: add control module driver

2020-10-27 Thread Simon Glass
On Sun, 25 Oct 2020 at 06:40, Dario Binacchi wrote: > > The implementation of this driver was needed to bind the device tree > sub-nodes of the 'clocks' node. In fact, the lack of the compatible > property in the 'clocks' node does not allow the generic 'syscon' or > 'simple-bus' drivers linked

Re: [PATCH v2 1/7] riscv: Add DMA 64-bit address support

2020-10-27 Thread Padmarao Begari
Hi Anup, On Sun, Oct 25, 2020 at 11:13 AM Anup Patel wrote: > On Thu, Oct 22, 2020 at 1:23 PM Padmarao Begari > wrote: > > > > dma_addr_t holds any valid DMA address. If the DMA API only uses > 32/64-bit > > addresses, dma_addr_t need only be 32/64 bits wide. > > > > Signed-off-by: Padmarao

Re: [PATCH v2 5/7] riscv: dts: Add device tree for Microchip Icicle Kit

2020-10-27 Thread Padmarao Begari
Hi Atish, On Tue, Oct 27, 2020 at 6:27 AM Atish Patra wrote: > On Mon, Oct 26, 2020 at 6:14 AM Bin Meng wrote: > > > > On Thu, Oct 22, 2020 at 3:23 PM Padmarao Begari > > wrote: > > > > > > Add device tree for Microchip PolarFire SoC Icicle Kit. > > > > > > Signed-off-by: Padmarao Begari > >

Re: U-Boot i2c bus num 1 is broken on Nokia N900

2020-10-27 Thread Heiko Schocher
Hello Pali, sorry for late response ... Am 26.10.2020 um 22:48 schrieb Pali Rohár: On Monday 27 April 2020 09:03:13 Heiko Schocher wrote: Hello Pali, Am 26.04.2020 um 01:54 schrieb Pali Rohár: Adding Hannes and Heiko to the loop, please look at this problem. On Saturday 25 April 2020

Re: [PATCH v2 5/7] riscv: dts: Add device tree for Microchip Icicle Kit

2020-10-27 Thread Padmarao Begari
Hi Bin, On Mon, Oct 26, 2020 at 6:44 PM Bin Meng wrote: > On Thu, Oct 22, 2020 at 3:23 PM Padmarao Begari > wrote: > > > > Add device tree for Microchip PolarFire SoC Icicle Kit. > > > > Signed-off-by: Padmarao Begari > > --- > > arch/riscv/dts/Makefile | 1 + > >

Re: [PATCH v2 6/7] riscv: Add Microchip MPFS Icicle Kit support

2020-10-27 Thread Padmarao Begari
Hi Bin, On Mon, Oct 26, 2020 at 6:48 PM Bin Meng wrote: > On Thu, Oct 22, 2020 at 3:23 PM Padmarao Begari > wrote: > > > > This patch adds Microchip MPFS Icicle Kit support. For now, only > > NS16550 Serial, Microchip clock, Cadence eMMC and MACB drivers are > > only enabled. The Microchip

Re: [PATCH v2 6/7] riscv: Add Microchip MPFS Icicle Kit support

2020-10-27 Thread Padmarao Begari
Hi Anup, On Sun, Oct 25, 2020 at 11:57 AM Anup Patel wrote: > On Thu, Oct 22, 2020 at 12:53 PM Padmarao Begari > wrote: > > > > This patch adds Microchip MPFS Icicle Kit support. For now, only > > NS16550 Serial, Microchip clock, Cadence eMMC and MACB drivers are > > only enabled. The

Re: [PATCH v2 5/7] riscv: dts: Add device tree for Microchip Icicle Kit

2020-10-27 Thread Padmarao Begari
Hi Anup, On Sun, Oct 25, 2020 at 11:20 AM Anup Patel wrote: > On Thu, Oct 22, 2020 at 12:53 PM Padmarao Begari > wrote: > > > > Add device tree for Microchip PolarFire SoC Icicle Kit. > > > > Signed-off-by: Padmarao Begari > > --- > > arch/riscv/dts/Makefile | 1 + > >

Re: [PATCH v2 4/7] clk: Add Microchip PolarFire SoC clock driver

2020-10-27 Thread Padmarao Begari
Hi Anup, On Sun, Oct 25, 2020 at 11:25 AM Anup Patel wrote: > On Thu, Oct 22, 2020 at 1:11 PM Padmarao Begari > wrote: > > > > Add clock driver code for the Microchip PolarFire SoC. This driver > > handles reset and clock control of the Microchip PolarFire SoC device. > > > > Signed-off-by:

Re: [PATCH v2 2/7] net: macb: Add DMA 64-bit address support for macb

2020-10-27 Thread Padmarao Begari
Hi Anup, On Sun, Oct 25, 2020 at 11:37 AM Anup Patel wrote: > On Thu, Oct 22, 2020 at 12:52 PM Padmarao Begari > wrote: > > > > Enable 64-bit DMA support in the macb driver when CONFIG_DMA_ADDR_T_64BIT > > is enabled. 32-bit DMA is enabled by default. > > > > Signed-off-by: Padmarao Begari >

Re: [PATCH v2 3/7] net: macb: Add phy address to read it from device tree

2020-10-27 Thread Padmarao Begari
Hi Anup, On Sun, Oct 25, 2020 at 11:50 AM Anup Patel wrote: > On Thu, Oct 22, 2020 at 12:52 PM Padmarao Begari > wrote: > > > > Read phy address from device tree and use it to find the phy device > > if not found then search in the range of 0 to 31. > > > > Signed-off-by: Padmarao Begari > >

Re: [PATCH 2/2] video: simple_panel: Add boe,nv101wxmn51 display

2020-10-27 Thread Alper Nebi Yasak
On 28/10/2020 00:52, Mark Kettenis wrote: >> From: Alper Nebi Yasak >> Date: Wed, 28 Oct 2020 00:41:55 +0300 >> >> Add "boe,nv101wxmn51" to the compatible node. This is the panel for >> chromebook_bob. > > I do have bob, and would be interested in testing chainloading u-boot > on it. Can you

[PATCH v4 21/22] doc: Add log kerneldocs to documentation

2020-10-27 Thread Sean Anderson
The functions in log.h are already mostly documented, so add them to the generated documentation. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - Add % before constants in kerneldocs - Document log_level_t and log_category_t members

[PATCH v4 17/22] lib: Add getopt

2020-10-27 Thread Sean Anderson
Some commands can get very unweildy if they have too many positional arguments. Adding options makes them easier to read, remember, and understand. This implementation of getopt has been taken from barebox, which has had option support for quite a while. I have made a few modifications to their

[PATCH v4 20/22] test: Add a test for log filter-*

2020-10-27 Thread Sean Anderson
This exercises a few success and failure modes of the log filter-* commands. log filter-list is not tested because it's purely informational. I don't think there's a good way to test it except by testing if the output of the command exactly matches a sample run. Signed-off-by: Sean Anderson

[PATCH v4 22/22] doc: Update logging documentation

2020-10-27 Thread Sean Anderson
This updates logging documentation with some examples of the new commands added in the previous commits. It also removes some items from the to-do list which have been implemented. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v4: - Add some more examples to docs

[PATCH v4 07/22] log: Add filter flag to deny on match

2020-10-27 Thread Sean Anderson
Without this flag, log filters can only explicitly accept messages. Allowing denial makes it easier to filter certain subsystems. Unlike allow-ing filters, deny-ing filters are added to the beginning of the filter list. This should do the Right Thing most of the time, but it's less-universal than

[PATCH v4 08/22] test: log: Convert log_test from python to C

2020-10-27 Thread Sean Anderson
When rebasing this series I had to renumber all my log tests because someone made another log test in the meantime. This involved updaing a number in several places (C and python), and it wasn't checked by the compiler. So I though "how hard could it be to just rewrite in C?" And though it wasn't

[PATCH v4 13/22] cmd: log: Use sub-commands for log

2020-10-27 Thread Sean Anderson
This reduces duplicate code, and makes adding new sub-commands easier. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) cmd/log.c | 31 --- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/cmd/log.c b/cmd/log.c index

[PATCH v4 12/22] test: Add test for LOGFF_MIN

2020-10-27 Thread Sean Anderson
This tests log filters matching on a minimum level. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v3) Changes in v3: - Modified to be completely written in C test/log/log_test.c | 23 +++ 1 file changed, 23 insertions(+) diff --git

[PATCH v4 18/22] test: Add a test for getopt

2020-10-27 Thread Sean Anderson
A few of these tests were inspired by those in glibc. The syntax for invoking test_getopt is a bit funky, but it's necessary so that the CPP can parse the arguments correctly. Signed-off-by: Sean Anderson --- (no changes since v1) test/lib/Makefile | 1 + test/lib/getopt.c | 123

[PATCH v4 15/22] cmd: log: Add commands to list categories and drivers

2020-10-27 Thread Sean Anderson
This allows users to query which categories and drivers are available on their system. This allows them to construct filter-add commands without (e.g.) adjusting the log format to show categories and drivers. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v3)

[PATCH v4 11/22] log: Add filter flag to match greater than a log level

2020-10-27 Thread Sean Anderson
This is the complement of the existing behavior to match only messages with a log level less than a threshold. This is primarily useful in conjunction with LOGFF_DENY. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) common/log.c | 12 +---

[PATCH v4 14/22] cmd: log: Split off log level parsing

2020-10-27 Thread Sean Anderson
Move parsing of log level into its own function so it can be re-used. This also adds support for using log level names instead of just the integer equivalent. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - Print an error message if the log

[PATCH v4 16/22] cmd: log: Make "log level" print all log levels

2020-10-27 Thread Sean Anderson
This makes the log level command print all valid log levels. The default log level is annotated. This provides an easy way to see which log levels are compiled-in. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - New cmd/log.c | 12

Re: [PATCH v3 04/23] log: Add new category names to log_cat_name

2020-10-27 Thread Tom Rini
On Sat, Oct 17, 2020 at 02:07:29PM -0400, Sean Anderson wrote: > Without every category between LOGC_NONE and LOGC_COUNT present in > log_cat_name, log_get_cat_by_name will dereference NULL pointers if it > doesn't find a name early enough. > > Fixes: c3aed5db59 ("sandbox: spi: Add more

Re: [PATCH 4/5] sandbox: implement reset

2020-10-27 Thread Rasmus Villemoes
On 25/10/2020 07.04, Heinrich Schuchardt wrote: > Up to now the sandbox would shutdown upon a cold reset request. Instead it > should be reset. > > In our coding we use static variables. The only safe way to return to an > initial state is to relaunch the U-Boot binary. > > The reset

Re: [PATCH v2 21/30] patman: Require tags to be before sign-off

2020-10-27 Thread Jonathan Nieder
Simon Glass wrote: > On Sun, 25 Oct 2020 at 19:23, Sean Anderson wrote: >> I also like to put SOBs on top because it groups all the commit-specific >> information before any patman-specific tags. The last commit (the HEAD) >> usually has several tags (Series-to/cc, Series-process-log, >>

[RFC PATCH] scripts/setlocalversion: avoid keeping double-quotes in UBOOTRELEASE

2020-10-27 Thread Rasmus Villemoes
CONFIG_LOCALVERSION is a string Kconfig item, so auto.conf always contains a line of the form CONFIG_LOCALVERSION="foo" (usually with nothing between the quotes). Since 81630a3b (scripts: setlocalversion: safely extract variables from auto.conf using awk), those quotes are no longer

Re: [PATCH] spi: xilinx_spi: remove unused local variable

2020-10-27 Thread Michal Simek
st 14. 10. 2020 v 11:38 odesílatel Michal Simek napsal: > > From: T Karthik Reddy > > Remove unused variable 'count' which is causing warning while > compilation. > > Signed-off-by: T Karthik Reddy > Signed-off-by: Michal Simek > --- > > drivers/spi/xilinx_spi.c | 6 +++--- > 1 file changed,

  1   2   >